Re: [PATCH v3 0/1] Add KUnit tests for llist

2024-09-20 Thread Shuah Khan
On 9/20/24 01:10, David Gow wrote: On Fri, 20 Sept 2024 at 00:01, Shuah Khan wrote: On 9/16/24 18:51, Artur Alves wrote: Hi all, This is part of a hackathon organized by LKCAMP[1], focused on writing tests using KUnit. We reached out a while ago asking for advice on what would be a useful

Re: [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value

2024-09-20 Thread Shuah Khan
On 9/17/24 23:46, Muhammad Usama Anjum wrote: On 9/17/24 6:56 AM, Shuah Khan wrote: On 9/16/24 00:32, Muhammad Usama Anjum wrote: On 9/12/24 8:44 PM, Shuah Khan wrote: On 9/12/24 04:31, Muhammad Usama Anjum wrote: The value of __NR_userfaultfd was changed to 282 when asm-generic/unistd.h was

Re: [PATCH v3 0/1] Add KUnit tests for llist

2024-09-19 Thread Shuah Khan
On 9/16/24 18:51, Artur Alves wrote: Hi all, This is part of a hackathon organized by LKCAMP[1], focused on writing tests using KUnit. We reached out a while ago asking for advice on what would be a useful contribution[2] and ended up choosing data structures that did not yet have tests. This p

Re: [PATCH] selftests: Makefile: create OUTPUT dir

2024-09-19 Thread Shuah Khan
On 9/16/24 01:56, Anders Roxell wrote: When cross building kselftest out-of-tree the following issue can be seen: [...] make[4]: Entering directory '/src/kernel/linux/tools/testing/selftests/net/lib' CC csum /usr/lib/gcc-cross/aarch64-linux-gnu/13/../../../../aarch64-linux-gnu/bin/ld: c

Re: [PATCH v2] selftests/vDSO: support DT_GNU_HASH

2024-09-19 Thread Shuah Khan
On 9/15/24 00:49, Fangrui Song wrote: glibc added support for DT_GNU_HASH in 2006 and DT_HASH has been obsoleted for more than one decade in many Linux distributions. Many vDSOs support DT_GNU_HASH. This patch adds selftests support. Signed-off-by: Fangrui Song Tested-by: Xi Ruoyao -- Changes

Re: [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value

2024-09-16 Thread Shuah Khan
On 9/16/24 00:32, Muhammad Usama Anjum wrote: On 9/12/24 8:44 PM, Shuah Khan wrote: On 9/12/24 04:31, Muhammad Usama Anjum wrote: The value of __NR_userfaultfd was changed to 282 when asm-generic/unistd.h was included. It makes the test to fail every time as the correct number of this syscall

[GIT PULL] KUnit update for Linux 6.12-rc1

2024-09-16 Thread Shuah Khan
Hi Linus, Please pull the following kunit update for Linux 6.12-rc1. This kunit update for Linux 6.12-rc1 consists of: -- a new int_pow test suite -- documentation update to clarify filename best practices -- kernel-doc fix for EXPORT_SYMBOL_IF_KUNIT -- change to build compile_commands.json aut

[GIT PULL] Kselftest update for Linux 6.12-rc1

2024-09-16 Thread Shuah Khan
user suite selftests: lib: remove strscpy test Piotr Zalewski (1): kselftest: timers: Fix const correctness Shreeya Patel (1): kselftest: cpufreq: Add RTC wakeup alarm Shuah Khan (1): selftests:resctrl: Fix build failure on archs without __cpuid_count() Steven Rostedt

[GIT PULL] nolibc for 6.12-rc1

2024-09-16 Thread Shuah Khan
Highlights -- * Clang support (including LTO) Other Changes - * stdbool.h support * argc/argv/envp arguments for constructors * Small #include ordering fix -------- Shuah Khan (1): Merge tag 'nolibc-20240824-for-6.

Re: [PATCH 2/2] kselftests: mm: Fail the test if userfaultfd syscall isn't found

2024-09-12 Thread Shuah Khan
On 9/12/24 10:10, Shuah Khan wrote: On 9/12/24 04:31, Muhammad Usama Anjum wrote: The userfaultfd is enabled in the config fragment of mm selftest suite. It must always be present. If it isn't present, we should throw error and not just skip. This would have helped us catch the test bre

Re: [PATCH] selftests: Makefile: add missing 'net/lib' to targets

2024-09-12 Thread Shuah Khan
On 9/12/24 09:23, Jakub Kicinski wrote: On Thu, 12 Sep 2024 08:31:18 +0200 Anders Roxell wrote: Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests") Signed-off-by: Anders Roxell --- tools/testing/selftests/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/s

Re: [PATCH 2/2] kselftests: mm: Fail the test if userfaultfd syscall isn't found

2024-09-12 Thread Shuah Khan
On 9/12/24 04:31, Muhammad Usama Anjum wrote: The userfaultfd is enabled in the config fragment of mm selftest suite. It must always be present. If it isn't present, we should throw error and not just skip. This would have helped us catch the test breakage. Please elaborate on this to help unde

Re: [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value

2024-09-12 Thread Shuah Khan
On 9/12/24 04:31, Muhammad Usama Anjum wrote: The value of __NR_userfaultfd was changed to 282 when asm-generic/unistd.h was included. It makes the test to fail every time as the correct number of this syscall on x86_64 is 323. Fix the header to asm/unistd.h. "please elaborate every time" - I

Re: [PATCH] selftests: kselftest: Use strerror() on nolibc

2024-09-11 Thread Shuah Khan
On 9/11/24 09:44, Thomas Weißschuh wrote: Hi Shuah, On 2024-09-11 09:36:50+, Shuah Khan wrote: On 9/10/24 22:42, zhangjiao2 wrote: From: zhang jiao Nolibc gained an implementation of strerror() recently. Use it and drop the ifndef. Signed-off-by: zhang jiao --- tools/testing

Re: [PATCH] selftests: kselftest: Use strerror() on nolibc

2024-09-11 Thread Shuah Khan
On 9/10/24 22:42, zhangjiao2 wrote: From: zhang jiao Nolibc gained an implementation of strerror() recently. Use it and drop the ifndef. Signed-off-by: zhang jiao --- tools/testing/selftests/kselftest.h | 8 1 file changed, 8 deletions(-) diff --git a/tools/testing/selftests/ksel

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-09 Thread Shuah Khan
On 9/8/24 23:16, Dev Jain wrote: On 9/7/24 01:29, Shuah Khan wrote: On 9/4/24 23:56, Dev Jain wrote: On 9/4/24 22:35, Shuah Khan wrote: On 9/3/24 22:52, Dev Jain wrote: On 9/4/24 03:14, Shuah Khan wrote: On 8/30/24 10:29, Dev Jain wrote: On 8/27/24 17:16, Dev Jain wrote: On 8/27/24

[GIT PULL] KUnit fixes second update for Linux 6.11-rc7

2024-09-06 Thread Shuah Khan
Hi Linus, Please pull the following KUnit fixes second update for Linux 6.11-rc7. This KUnit fixes update for Linux 6.11-rc7 consists of a fix to missing function parameter warning found during documentation build in linux-next. diff is attached. thanks, -- Shuah -

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-06 Thread Shuah Khan
On 9/4/24 23:56, Dev Jain wrote: On 9/4/24 22:35, Shuah Khan wrote: On 9/3/24 22:52, Dev Jain wrote: On 9/4/24 03:14, Shuah Khan wrote: On 8/30/24 10:29, Dev Jain wrote: On 8/27/24 17:16, Dev Jain wrote: On 8/27/24 17:14, Shuah Khan wrote: On 8/22/24 06:14, Dev Jain wrote: Rename

Re: [PATCH v2] selftests/timers: Remove unused NSEC_PER_SEC macro

2024-09-06 Thread Shuah Khan
On 9/6/24 11:02, John Stultz wrote: On Fri, Sep 6, 2024 at 7:29 AM Shuah Khan wrote: On 9/5/24 20:52, zhangjiao2 wrote: diff --git a/tools/testing/selftests/timers/skew_consistency.c b/tools/testing/selftests/timers/skew_consistency.c index c8e6bffe4e0a..83450145fe65 100644 --- a/tools

Re: [PATCH v2] selftests/timers: Remove unused NSEC_PER_SEC macro

2024-09-06 Thread Shuah Khan
uot;../kselftest.h" -#define NSEC_PER_SEC 10LL - int main(int argc, char **argv) { struct timex tx; This looks good to me. Reviewed-by: Shuah Khan John, I can pick this up with if you are okay with this change. thanks, -- Shuah

Re: [PATCH] selftests:resctrl: Fix build failure on archs without __cpuid_count()

2024-09-06 Thread Shuah Khan
On 9/6/24 01:35, Muhammad Usama Anjum wrote: Hi Shuah, Thank you for fixing it. On 9/5/24 11:02 PM, Shuah Khan wrote: When resctrl is built on architectures without __cpuid_count() support, build fails. resctrl uses __cpuid_count() defined in kselftest.h. Even though the problem is seen

Re: [PATCH] selftests:resctrl: Fix build failure on archs without __cpuid_count()

2024-09-06 Thread Shuah Khan
On 9/6/24 04:12, Ilpo Järvinen wrote: On Thu, 5 Sep 2024, Shuah Khan wrote: When resctrl is built on architectures without __cpuid_count() support, build fails. resctrl uses __cpuid_count() defined in kselftest.h. Even though the problem is seen while building resctrl on aarch64, this error

Re: [PATCH v4 0/4] selftests: Fix cpuid / vendor checking build issues

2024-09-05 Thread Shuah Khan
On 9/5/24 14:43, Reinette Chatre wrote: Hi Shuah, On 9/5/24 11:06 AM, Shuah Khan wrote: On 9/4/24 06:54, Ilpo Järvinen wrote: On Wed, 4 Sep 2024, Shuah Khan wrote: On 9/4/24 06:18, Ilpo Järvinen wrote: On Tue, 3 Sep 2024, Shuah Khan wrote: On 9/3/24 08:45, Ilpo Järvinen wrote: This

Re: [PATCH] selftests:resctrl: Fix build failure on archs without __cpuid_count()

2024-09-05 Thread Shuah Khan
On 9/5/24 14:45, Reinette Chatre wrote: Hi Shuah, Thank you very much for looking into this. On 9/5/24 11:02 AM, Shuah Khan wrote: When resctrl is built on architectures without __cpuid_count() support, build fails. resctrl uses __cpuid_count() defined in kselftest.h. Even though the problem

Re: [PATCH v2] selftests: futex: Fix missing free in main

2024-09-05 Thread Shuah Khan
On 9/4/24 20:01, zhangjiao2 wrote: From: zhang jiao By readind the code, I found there is no free() after asprintf(). Just free it. Signed-off-by: zhang jiao --- v1->v2: Set a flag to determine if test_name needs free. tools/testing/selftests/futex/functional/futex_requeue_

Re: [PATCH v4 0/4] selftests: Fix cpuid / vendor checking build issues

2024-09-05 Thread Shuah Khan
On 9/4/24 06:54, Ilpo Järvinen wrote: On Wed, 4 Sep 2024, Shuah Khan wrote: On 9/4/24 06:18, Ilpo Järvinen wrote: On Tue, 3 Sep 2024, Shuah Khan wrote: On 9/3/24 08:45, Ilpo Järvinen wrote: This series first generalizes resctrl selftest non-contiguous CAT check to not assume non-AMD vendor

[PATCH] selftests:resctrl: Fix build failure on archs without __cpuid_count()

2024-09-05 Thread Shuah Khan
cro ‘__cpuid_count’ 306 | __cpuid_count(0x10, 2, eax, ebx, ecx, edx); Reported-by: Muhammad Usama Anjum Reported-by: Ilpo Järvinen Signed-off-by: Shuah Khan --- tools/testing/selftests/kselftest.h| 2 ++ tools/testing/selftests/resctrl/cat_test.c | 6 -- 2 files changed, 6 insertions(+), 2 d

Re: [PATCH] Date: Remove unused macro

2024-09-05 Thread Shuah Khan
On 9/5/24 02:52, zhangjiao2 wrote: From: zhang jiao This macro NSEC_PER_SEC is never referenced in the code. Just remove it. Is this duplicate patch? I think I commented on your patch on futex - include how you found the problem in change logs. Also you have to include subsystem prefix in th

Re: [PATCH] Date: Remove unused macro

2024-09-05 Thread Shuah Khan
On 9/5/24 02:13, zhangjiao2 wrote: From: zhang jiao This macro NSEC_PER_SEC is never referenced in the code. Just remove it. I think I commented on your patch on futex - include how you found the problem in change logs. Also you have to include subsystem prefix in the subject line: selftests

Re: [PATCH] kunit: Fix missing kerneldoc comment

2024-09-05 Thread Shuah Khan
On 9/4/24 20:47, David Gow wrote: Add a missing kerneldoc comment for the 'test' test context parameter, fixing the following warning: include/kunit/test.h:492: warning: Function parameter or struct member 'test' not described in 'kunit_kfree_const' Reported-by: Stephen Rothwell Closes: https

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-04 Thread Shuah Khan
On 9/3/24 22:52, Dev Jain wrote: On 9/4/24 03:14, Shuah Khan wrote: On 8/30/24 10:29, Dev Jain wrote: On 8/27/24 17:16, Dev Jain wrote: On 8/27/24 17:14, Shuah Khan wrote: On 8/22/24 06:14, Dev Jain wrote: Rename sigaltstack to generic signal directory, to allow adding more signal tests

Re: [PATCH] selftests: futex: Fix missing free in main

2024-09-04 Thread Shuah Khan
On 9/3/24 20:55, zhangjiao2 wrote: From: zhang jiao Free string allocated by asprintf(). How did you find this problem? Include the details in the change log - The tool and output from the tool. Signed-off-by: zhang jiao --- tools/testing/selftests/futex/functional/futex_requeue_pi.c |

Re: [PATCH v2] selftests/futex: Create test for robust list

2024-09-04 Thread Shuah Khan
On 9/3/24 07:40, André Almeida wrote: Create a test for the robust list mechanism. What does this test - can you elaborate on the testing details? It will help reviewers catch if any tests are missed or not - be able to review the patch. Include output from the test in the chane log. Signed

Re: [PATCH v4 0/4] selftests: Fix cpuid / vendor checking build issues

2024-09-04 Thread Shuah Khan
On 9/4/24 06:18, Ilpo Järvinen wrote: On Tue, 3 Sep 2024, Shuah Khan wrote: On 9/3/24 08:45, Ilpo Järvinen wrote: This series first generalizes resctrl selftest non-contiguous CAT check to not assume non-AMD vendor implies Intel. Second, it improves selftests such that the use of

Re: [PATCH v4 0/4] selftests: Fix cpuid / vendor checking build issues

2024-09-03 Thread Shuah Khan
On 9/3/24 08:45, Ilpo Järvinen wrote: This series first generalizes resctrl selftest non-contiguous CAT check to not assume non-AMD vendor implies Intel. Second, it improves selftests such that the use of __cpuid_count() does not lead into a build failure (happens at least on ARM). While ARM doe

Re: [PATCH v2] selftests: splice: Add usage() to splice_read.c

2024-09-03 Thread Shuah Khan
On 8/30/24 23:14, Rong Tao wrote: From: Rong Tao Give the programmer more help information to inform the program on how to use it. Signed-off-by: Rong Tao --- tools/testing/selftests/splice/splice_read.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/test

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-03 Thread Shuah Khan
On 8/30/24 10:29, Dev Jain wrote: On 8/27/24 17:16, Dev Jain wrote: On 8/27/24 17:14, Shuah Khan wrote: On 8/22/24 06:14, Dev Jain wrote: Rename sigaltstack to generic signal directory, to allow adding more signal tests in the future. Sorry - I think I mentioned I don't like this

Re: [PATCH] selftests/vDSO: support DT_GNU_HASH

2024-09-03 Thread Shuah Khan
On 8/27/24 07:37, Fangrui Song wrote: On Tue, Aug 27, 2024 at 10:12 PM Shuah Khan wrote: On 8/26/24 00:07, Xi Ruoyao wrote: On Wed, 2024-08-14 at 20:26 -0700, Fangrui Song wrote: glibc added support for DT_GNU_HASH in 2006 and DT_HASH has been obsoleted for more than one decade in many

Re: [PATCH] selftests: filesystems: fix warn_unused_result build warnings

2024-09-03 Thread Shuah Khan
On 8/16/24 07:11, Shuah Khan wrote: On 8/10/24 07:53, Abhinav Jain wrote: Add return value checks for read & write calls in test_listmount_ns function. This patch resolves below compilation warnings: ``` statmount_test_ns.c: In function ‘test_listmount_ns’: statmount_test_ns.c:322:17: war

Re: [PATCH] tools/latency-collector: fix -Wformat-security compile warns

2024-05-21 Thread Shuah Khan
On 4/3/24 19:10, Shuah Khan wrote: Fix the following -Wformat-security compile warnings adding missing format arguments: latency-collector.c: In function ‘show_available’: latency-collector.c:938:17: warning: format not a string literal and no format arguments [-Wformat-security] 938

[PATCH] tools/latency-collector: fix -Wformat-security compile warns

2024-04-03 Thread Shuah Khan
literal and no format arguments [-Wformat-security] 1881 | errx(EXIT_FAILURE, no_tracer_msg); | ^~~~ Signed-off-by: Shuah Khan --- tools/tracing/latency/latency-collector.c | 8 1 file changed, 4 insertions(+), 4 deletions

Re: [PATCH v3] Documentation: dev-tools: Add Testing Overview

2021-04-20 Thread Shuah Khan
On 4/14/21 11:40 PM, David Gow wrote: The kernel now has a number of testing and debugging tools, and we've seen a bit of confusion about what the differences between them are. Add a basic documentation outlining the testing tools, when to use each, and how they interact. This is a pretty quick

Re: [PATCH 5.4 00/73] 5.4.114-rc1 review

2021-04-19 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 000/103] 5.10.32-rc1 review

2021-04-19 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.11 000/122] 5.11.16-rc1 review

2021-04-19 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.11.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH RFC v3] media: em28xx: Fix race condition between open and init function

2021-04-16 Thread Shuah Khan
On 4/16/21 1:33 PM, Igor Torrente wrote: On 4/15/21 2:25 PM, Shuah Khan wrote: On 4/15/21 8:07 AM, Igor Matheus Andrade Torrente wrote: Fixes a race condition - for lack of a more precise term - between em28xx_v4l2_open and em28xx_v4l2_init, by detaching the v4l2_dev, media_pad and vdev

Re: [PATCH 4.4 00/38] 4.4.267-rc1 review

2021-04-15 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.14 00/68] 4.14.231-rc1 review

2021-04-15 Thread Shuah Khan
rivers: net: fix memory leak in atusb_probe Phillip Potter net: tun: set tun->dev->addr_len during TUNSETLINK processing Du Cheng cfg80211: remove WARN_ON() in cfg80211_sme_connect Shuah Khan usbip: fix vudc usbip_sockfd_store races leading to gpf Samuel Mendoza-Jonas

Re: [PATCH 4.9 00/47] 4.9.267-rc1 review

2021-04-15 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.14 00/68] 4.14.231-rc1 review

2021-04-15 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 00/18] 5.4.113-rc1 review

2021-04-15 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 00/13] 4.19.188-rc1 review

2021-04-15 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 00/25] 5.10.31-rc1 review

2021-04-15 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.11 00/23] 5.11.15-rc1 review

2021-04-15 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.11.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH RFC v3] media: em28xx: Fix race condition between open and init function

2021-04-15 Thread Shuah Khan
On 4/15/21 8:07 AM, Igor Matheus Andrade Torrente wrote: Fixes a race condition - for lack of a more precise term - between em28xx_v4l2_open and em28xx_v4l2_init, by detaching the v4l2_dev, media_pad and vdev structs from the em28xx_v4l2, and managing the lifetime of those objects more dynamicaly

Re: [PATCH v3] firmware_loader: fix use-after-free in firmware_fallback_sysfs

2021-04-15 Thread Shuah Khan
On 4/14/21 9:26 AM, Shuah Khan wrote: On 4/14/21 6:55 AM, Luis Chamberlain wrote: Shuah, a question for you toward the end here. On Wed, Apr 14, 2021 at 02:24:05PM +0530, Anirudh Rayabharam wrote: This use-after-free happens when a fw_priv object has been freed but hasn't been removed

Re: [PATCH v3] firmware_loader: fix use-after-free in firmware_fallback_sysfs

2021-04-14 Thread Shuah Khan
On 4/14/21 6:55 AM, Luis Chamberlain wrote: Shuah, a question for you toward the end here. On Wed, Apr 14, 2021 at 02:24:05PM +0530, Anirudh Rayabharam wrote: This use-after-free happens when a fw_priv object has been freed but hasn't been removed from the pending list (pending_fw_head). The ne

Re: [PATCH 4.19 00/66] 4.19.187-rc1 review

2021-04-12 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. No problems with wifi this time. I will be on the lookout for this in the future. Tested-by: Shuah Khan thanks

Re: [PATCH 5.4 000/111] 5.4.112-rc1 review

2021-04-12 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 000/188] 5.10.30-rc1 review

2021-04-12 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.11 000/210] 5.11.14-rc1 review

2021-04-12 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.11.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.9 00/13] 4.9.266-rc1 review

2021-04-09 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 00/18] 4.19.186-rc1 review

2021-04-09 Thread Shuah Khan
On 4/9/21 3:53 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.186 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 5.4 00/23] 5.4.111-rc1 review

2021-04-09 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 00/41] 5.10.29-rc1 review

2021-04-09 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.11 00/45] 5.11.13-rc1 review

2021-04-09 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.11.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 2/2] iommu/amd: Remove performance counter pre-initialization test

2021-04-09 Thread Shuah Khan
On 4/9/21 2:00 PM, Shuah Khan wrote: On 4/9/21 2:58 AM, Suravee Suthikulpanit wrote: In early AMD desktop/mobile platforms (during 2013), when the IOMMU Performance Counter (PMC) support was first introduced in commit 30861ddc9cca ("perf/x86/amd: Add IOMMU Performance Counter res

Re: [PATCH 2/2] iommu/amd: Remove performance counter pre-initialization test

2021-04-09 Thread Shuah Khan
30935570.3...@monopod.intra.ispras.ru/ Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201753 Cc: Tj (Elloe Linux) Cc: Shuah Khan Cc: Alexander Monakov Cc: David Coe Cc: Paul Menzel Signed-off-by: Suravee Suthikulpanit --- Tested-by: Shuah Khan thanks, -- Shuah Results with this patch on AMD Ryzen 5 PR

Re: [PATCH 2/2] iommu/amd: Remove performance counter pre-initialization test

2021-04-09 Thread Shuah Khan
On 4/9/21 10:37 AM, Shuah Khan wrote: On 4/9/21 2:58 AM, Suravee Suthikulpanit wrote: In early AMD desktop/mobile platforms (during 2013), when the IOMMU Performance Counter (PMC) support was first introduced in commit 30861ddc9cca ("perf/x86/amd: Add IOMMU Performance Counter res

Re: [PATCH 1/2] Revert "iommu/amd: Fix performance counter initialization"

2021-04-09 Thread Shuah Khan
to removing the pre-init test. Link: https://lore.kernel.org/linux-iommu/alpine.lnx.3.20.13.2006030935570.3...@monopod.intra.ispras.ru/ Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201753 Cc: Tj (Elloe Linux) Cc: Shuah Khan Cc: Alexander Monakov Cc: David Coe Signed-off-by: Paul Menzel

Re: [PATCH 2/2] iommu/amd: Remove performance counter pre-initialization test

2021-04-09 Thread Shuah Khan
n use be relatively safe to remove this legacy logic. Link: https://lore.kernel.org/linux-iommu/alpine.lnx.3.20.13.2006030935570.3...@monopod.intra.ispras.ru/ Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201753 Cc: Tj (Elloe Linux) Cc: Shuah Khan Cc: Alexander Monakov Cc: David Coe Cc: P

Re: [PATCH] media: em28xx: Fix race condition between open and init function

2021-04-08 Thread Shuah Khan
On 4/8/21 6:10 AM, Igor Matheus Andrade Torrente wrote: Fixes a race condition - for lack of a more precise term - between em28xx_v4l2_open and em28xx_v4l2_init, by detaching the v4l2_dev, media_pad and vdev structs from the em28xx_v4l2, and managing the lifetime of those objects more dynamicaly.

Re: [PATCH] usbip: vhci_hcd: do proper error handling

2021-04-08 Thread Shuah Khan
On 3/31/21 5:23 AM, Muhammad Usama Anjum wrote: On Fri, 2021-03-26 at 14:24 -0600, Shuah Khan wrote: On 3/25/21 5:46 AM, Muhammad Usama Anjum wrote: The driver was assuming that all the parameters would be valid. But it is possible that parameters are sent from userspace. For those cases

Re: [PATCH v2] selftests/resctrl: Change a few printed messages

2021-04-07 Thread Shuah Khan
On 4/7/21 1:57 PM, Fenghua Yu wrote: Change a few printed messages to report test progress more clearly. Add a missing "\n" at the end of one printed message. Suggested-by: Shuah Khan Signed-off-by: Fenghua Yu --- Change log: v2: - Add "Pass:" and "Fail:" sub-st

Re: [PATCH] Documentation: kunit: add tips for using current->kunit_test

2021-04-07 Thread Shuah Khan
On 4/7/21 2:07 PM, Brendan Higgins wrote: On Tue, Apr 6, 2021 at 3:51 PM Daniel Latypov wrote: As of commit 359a376081d4 ("kunit: support failure from dynamic analysis tools"), we can use current->kunit_test to find the current kunit test. Mention this in tips.rst and give an example of how t

Re: [PATCH] selftests/resctrl: Change a few printed messages

2021-04-07 Thread Shuah Khan
On 4/7/21 11:12 AM, Fenghua Yu wrote: Hi, Shuah, On Wed, Apr 07, 2021 at 08:33:23AM -0600, Shuah Khan wrote: On 4/5/21 6:52 PM, Fenghua Yu wrote: - ksft_print_msg("%s cache miss rate within %d%%\n", - ret ? "Fail:" : "

Re: [PATCH] selftests/resctrl: Change a few printed messages

2021-04-07 Thread Shuah Khan
On 4/5/21 6:52 PM, Fenghua Yu wrote: A few printed messages contain pass/fail strings which should be shown in test results. Remove the pass/fail strings in the messages to avoid confusion. Add "\n" at the end of one printed message. Suggested-by: Shuah Khan Signed-off-by:

[PATCH] ath10k: Fix ath10k_wmi_tlv_op_pull_peer_stats_info() unlock without lock

2021-04-06 Thread Shuah Khan
_by_ifaddr()") Reported-by: Pavel Machek Signed-off-by: Shuah Khan --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index d97b33f789e4..7efbe03fbc

Re: [PATCH] kunit: fix -Wunused-function warning for __kunit_fail_current_test

2021-04-06 Thread Shuah Khan
On 4/6/21 2:50 PM, Brendan Higgins wrote: On Tue, Apr 6, 2021 at 10:29 AM Daniel Latypov wrote: When CONFIG_KUNIT is not enabled, __kunit_fail_current_test() an empty static function. But GCC complains about unused static functions, *unless* they're static inline. So add inline to make GCC ha

Re: [PATCH 4.4 00/28] 4.4.265-rc1 review

2021-04-05 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.9 00/35] 4.9.265-rc1 review

2021-04-05 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 00/74] 5.4.110-rc1 review

2021-04-05 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 00/56] 4.19.185-rc1 review

2021-04-05 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 047/126] ath10k: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()

2021-04-05 Thread Shuah Khan
On 4/5/21 9:34 AM, Pavel Machek wrote: Hi! Fix ath10k_wmi_tlv_op_pull_peer_stats_info() to hold RCU lock before it calls ieee80211_find_sta_by_ifaddr() and release it when the resulting pointer is no longer needed. It does that. But is also does the unlock even if it did not take the lock:

Re: [PATCH 5.10 000/126] 5.10.28-rc1 review

2021-04-05 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.11 000/152] 5.11.12-rc1 review

2021-04-05 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.11.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] firmware_loader: Remove unnecessary conversion to bool

2021-04-02 Thread Shuah Khan
On 2/18/21 2:12 AM, Jiapeng Chong wrote: Fix the following coccicheck warnings: ./tools/testing/selftests/firmware/fw_namespace.c:98:54-59: WARNING: conversion to bool not needed here. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- tools/testing/selftests/firmware/fw_namespace.c

Re: [PATCH v4 1/2] kunit: support failure from dynamic analysis tools

2021-04-02 Thread Shuah Khan
On 4/2/21 3:44 PM, Shuah Khan wrote: On 4/2/21 3:25 PM, Daniel Latypov wrote: On Fri, Apr 2, 2021 at 10:53 AM Shuah Khan wrote: On 4/2/21 2:55 AM, Brendan Higgins wrote: On Thu, Mar 11, 2021 at 7:23 AM Daniel Latypov wrote: From: Uriel Guajardo Add a kunit_fail_current_test() function

Re: [PATCH v4 1/2] kunit: support failure from dynamic analysis tools

2021-04-02 Thread Shuah Khan
On 4/2/21 3:25 PM, Daniel Latypov wrote: On Fri, Apr 2, 2021 at 10:53 AM Shuah Khan wrote: On 4/2/21 2:55 AM, Brendan Higgins wrote: On Thu, Mar 11, 2021 at 7:23 AM Daniel Latypov wrote: From: Uriel Guajardo Add a kunit_fail_current_test() function to fail the currently running test, if

Re: [PATCH v6 00/21] Miscellaneous fixes for resctrl selftests

2021-04-02 Thread Shuah Khan
On 4/2/21 12:18 PM, Fenghua Yu wrote: Hi, Shuah, On Fri, Apr 02, 2021 at 12:17:17PM -0600, Shuah Khan wrote: On 3/26/21 1:45 PM, Fenghua Yu wrote: Hi, Shuah, On Wed, Mar 17, 2021 at 02:22:34AM +, Fenghua Yu wrote: This patch set has several miscellaneous fixes to resctrl selftest tool

Re: [PATCH v6 12/21] selftests/resctrl: Check for resctrl mount point only if resctrl FS is supported

2021-04-02 Thread Shuah Khan
On 3/16/21 8:22 PM, Fenghua Yu wrote: check_resctrlfs_support() does the following 1. Checks if the platform supports resctrl file system or not by looking for resctrl in /proc/filesystems 2. Calls opendir() on default resctrl file system path (i.e. /sys/fs/resctrl) 3. Checks if resctrl f

Re: [PATCH] kunit: tool: make --kunitconfig accept dirs, add lib/kunit fragment

2021-04-02 Thread Shuah Khan
On 4/2/21 1:27 PM, Daniel Latypov wrote: On Fri, Apr 2, 2021 at 11:00 AM Shuah Khan wrote: On 4/2/21 3:32 AM, Brendan Higgins wrote: TL;DR $ ./tools/testing/kunit/kunit.py run --kunitconfig=lib/kunit Per suggestion from Ted [1], we can reduce the amount of typing by assuming a convention

Re: [PATCH] kunit: make KUNIT_EXPECT_STREQ() quote values, don't print literals

2021-04-02 Thread Shuah Khan
On 4/2/21 1:09 PM, Daniel Latypov wrote: On Fri, Apr 2, 2021 at 10:47 AM Shuah Khan wrote: On 4/2/21 3:35 AM, Brendan Higgins wrote: On Fri, Feb 5, 2021 at 2:18 PM Daniel Latypov wrote: Before: Expected str == "world", but str == hello "world&qu

Re: [PATCH v6 00/21] Miscellaneous fixes for resctrl selftests

2021-04-02 Thread Shuah Khan
On 3/26/21 1:45 PM, Fenghua Yu wrote: Hi, Shuah, On Wed, Mar 17, 2021 at 02:22:34AM +, Fenghua Yu wrote: This patch set has several miscellaneous fixes to resctrl selftest tool that are easily visible to user. V1 had fixes to CAT test and CMT test but they were dropped in V2 because having

Re: [PATCH v5 00/21] Miscellaneous fixes for resctrl selftests

2021-04-02 Thread Shuah Khan
On 3/12/21 3:11 PM, Fenghua Yu wrote: Hi, Babu, On Fri, Mar 12, 2021 at 01:08:11PM -0600, Babu Moger wrote: Hi Fenghua, Thanks for the patches. Sanity tested them on AMD systems. Appears to work fine. Few minor comments in few patches. Tested-by: Babu Moger I will add Tested-by: Babu Moger i

Re: [PATCH] kunit: tool: make --kunitconfig accept dirs, add lib/kunit fragment

2021-04-02 Thread Shuah Khan
On 4/2/21 3:32 AM, Brendan Higgins wrote: TL;DR $ ./tools/testing/kunit/kunit.py run --kunitconfig=lib/kunit Per suggestion from Ted [1], we can reduce the amount of typing by assuming a convention that these files are named '.kunitconfig'. In the case of [1], we now have $ ./tools/testing/kuni

Re: [PATCH v4 1/2] kunit: support failure from dynamic analysis tools

2021-04-02 Thread Shuah Khan
On 4/2/21 2:55 AM, Brendan Higgins wrote: On Thu, Mar 11, 2021 at 7:23 AM Daniel Latypov wrote: From: Uriel Guajardo Add a kunit_fail_current_test() function to fail the currently running test, if any, with an error message. This is largely intended for dynamic analysis tools like UBSAN and

Re: [PATCH] kunit: make KUNIT_EXPECT_STREQ() quote values, don't print literals

2021-04-02 Thread Shuah Khan
On 4/2/21 3:35 AM, Brendan Higgins wrote: On Fri, Feb 5, 2021 at 2:18 PM Daniel Latypov wrote: Before: Expected str == "world", but str == hello "world" == world After: Expected str == "world", but str == "hello" Note: like the literal ellision for integers, this d

[PATCH 0/4] usbip synchronize sysfs code paths

2021-03-29 Thread Shuah Khan
uses it in vhci_hcd in the first patch. Subsequent patches fix usbip_host, vudc and the last patch fixes the common event handler code path. Shuah Khan (4): usbip: add sysfs_lock to synchronize sysfs code paths usbip: stub-dev synchronize sysfs code paths usbip: vudc synchronize sysfs code paths

[PATCH 1/4] usbip: add sysfs_lock to synchronize sysfs code paths

2021-03-29 Thread Shuah Khan
-and-tested-by: syzbot+a93fba6d384346a76...@syzkaller.appspotmail.com Cc: sta...@vger.kernel.org Signed-off-by: Shuah Khan --- drivers/usb/usbip/usbip_common.h | 3 +++ drivers/usb/usbip/vhci_hcd.c | 1 + drivers/usb/usbip/vhci_sysfs.c | 30 +- 3 files changed, 29

  1   2   3   4   5   6   7   8   9   10   >