[PATCH 4/4] usbip: synchronize event handler with sysfs code paths

2021-03-29 Thread Shuah Khan
. Reported-and-tested-by: syzbot+a93fba6d384346a76...@syzkaller.appspotmail.com Cc: sta...@vger.kernel.org Signed-off-by: Shuah Khan --- drivers/usb/usbip/usbip_event.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/usbip/usbip_event.c b/drivers/usb/usbip/usbip_event.c index

Re: [PATCH 4.4 00/33] 4.4.264-rc1 review

2021-03-29 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.9 00/53] 4.9.264-rc1 review

2021-03-29 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 00/72] 4.19.184-rc1 review

2021-03-29 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 000/111] 5.4.109-rc1 review

2021-03-29 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 000/219] 5.10.27-rc2 review

2021-03-29 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.11 000/252] 5.11.11-rc2 review

2021-03-29 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.11.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] sched/psi.c: Rudimentary typo fixes

2021-03-29 Thread Shuah Khan
On 3/26/21 1:42 PM, Bhaskar Chowdhury wrote: On 19:41 Fri 26 Mar 2021, Peter Zijlstra wrote: On Fri, Mar 26, 2021 at 02:00:18PM -0400, Johannes Weiner wrote: On Fri, Mar 26, 2021 at 06:12:33PM +0530, Bhaskar Chowdhury wrote: > > s/possible/possible/ > s/ exceution/execution/ > s/manupulations/m

Re: [PATCH] usbip: vhci_hcd: do proper error handling

2021-03-26 Thread Shuah Khan
On 3/25/21 5:46 AM, Muhammad Usama Anjum wrote: The driver was assuming that all the parameters would be valid. But it is possible that parameters are sent from userspace. For those cases, appropriate error checks have been added. Are you sure this change is necessary for vhci_hcd? Is there a

Re: [PATCH] selftests/timers: remove unneeded semicolon

2021-03-26 Thread Shuah Khan
On 3/9/21 12:49 AM, Jiapeng Chong wrote: Fix the following coccicheck warnings: ./tools/testing/selftests/timers/nanosleep.c:75:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- tools/testing/selftests/timers/nanosleep.c | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH] selftests/timers: Fix spelling mistake "clocksourc" -> "clocksource"

2021-03-26 Thread Shuah Khan
On 3/15/21 12:41 PM, John Stultz wrote: On Mon, Mar 15, 2021 at 5:33 AM Colin King wrote: From: Colin Ian King There is a spelling mistake in a comment. Fix it. Signed-off-by: Colin Ian King Akcde-yb: John Stultz I kid, I kid! My apologies and thanks! Acked-by: John Stultz Thank

Re: [PATCH v5 2/2] usbip: tools: add usage of device mode in usbip_list.c

2021-03-24 Thread Shuah Khan
ets bound to usbip-vudc\n"; void usbip_list_usage(void) { Thank you. Looks good. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v5 1/2] usbip: tools: add options and examples in man page related to device mode

2021-03-24 Thread Shuah Khan
r g_mass_storage +- Unbind a gadget from usbip-vudc. +- in this example, the previous mass storage gadget is unbound. + .SH "SEE ALSO" \fBusbip\fP\fB(8)\fB\fP Thank you. Looks good. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] tools: usbip: list.h: fix kernel-doc for list_del()

2021-03-24 Thread Shuah Khan
-by: Randy Dunlap Cc: Valentina Manea Cc: Shuah Khan Cc: Shuah Khan Cc: linux-...@vger.kernel.org --- tools/usb/usbip/libsrc/list.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) --- linux-next-20210323.orig/tools/usb/usbip/libsrc/list.h +++ linux-next-20210323/tools/usb/us

[PATCH] usbip: vhci_hcd fix shift out-of-bounds in vhci_hub_control()

2021-03-24 Thread Shuah Khan
Signed-off-by: Shuah Khan --- drivers/usb/usbip/vhci_hcd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c index 3209b5ddd30c..a20a8380ca0c 100644 --- a/drivers/usb/usbip/vhci_hcd.c +++ b/drivers/usb/usbip/vhci_hcd.c @@ -594,6 +594,8

Re: [syzbot] UBSAN: shift-out-of-bounds in vhci_hub_control (2)

2021-03-24 Thread Shuah Khan
On 3/24/21 2:05 PM, Muhammad Usama Anjum wrote: On Wed, 2021-03-24 at 10:36 -0700, syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:84196390 Merge tag 'selinux-pr-20210322' of git://git.kern.. git tree: upstream console output: https://syzkaller.appspot.com/x/log

Re: [PATCH v4 1/2] usbip: tools: add options and examples in man page related to device mode

2021-03-23 Thread Shuah Khan
On 3/23/21 6:55 AM, Hongren Zheng (Zenithal) wrote: The commit e0546fd8b748 ("usbip: tools: Start using VUDC backend in usbip tools") implemented device mode for user space tools, however the corresponding options are not documented in man page. This commit documents the options and provides exa

[GIT PULL] KUnit fixes update for Linux 5.12-rc5

2021-03-23 Thread Shuah Khan
Hi Linus, Please pull the following KUnit fixes update for Linux 5.12-rc5. This KUnit update for Linux 5.12-rc5 consists of two fixes to kunit tool from David Gow. diff is attached. thanks, -- Shuah The following changes since

Re: [PATCH v4 2/2] usbip: tools: add usage of device mode in usbip_list.c

2021-03-23 Thread Shuah Khan
n" + "-d, --device List the local USB gadgets bound to usbip-vudc\n"; void usbip_list_usage(void) { Looks good to me. Thanks for adding this. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-18 Thread Shuah Khan
On 3/17/21 9:06 AM, Shuah Khan wrote: On 3/17/21 12:21 AM, Tetsuo Handa wrote: Shuah, this driver is getting more and more cryptic and buggy. Please explain the strategy for serialization before you write patches. - Fix attach_store() to check usbip_event_happened() before    waking up

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-17 Thread Shuah Khan
On 3/17/21 9:38 AM, Tetsuo Handa wrote: On 2021/03/18 0:06, Shuah Khan wrote: Yes. I haven't sent the patch for that reason. I am trying to test a solution. I haven't come up with a solution yet. Holding event_lock isn't the right solution. I am not going to accept that. This i

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-17 Thread Shuah Khan
On 3/17/21 12:21 AM, Tetsuo Handa wrote: Shuah, this driver is getting more and more cryptic and buggy. Please explain the strategy for serialization before you write patches. - Fix attach_store() to check usbip_event_happened() before waking up threads. No, this helps nothing. diff --gi

Re: [PATCH] usbip: fix vhci races in connection tear down

2021-03-12 Thread Shuah Khan
On 3/12/21 12:08 AM, Hillf Danton wrote: On Thu, 11 Mar 2021 19:27:37 -0700 Shuah Khan wrote: vhci_shutdown_connection() references connection state (tcp_socket, tcp_rx, tcp_tx, sockfd) saved in usbpip_device without holding the lock. Current connection tear down sequence: Step 1: shutdown

Re: [PATCH] usbip: fix vhci races in connection tear down

2021-03-12 Thread Shuah Khan
On 3/12/21 3:45 AM, Johan Hovold wrote: On Thu, Mar 11, 2021 at 07:27:37PM -0700, Shuah Khan wrote: vhci_shutdown_connection() references connection state (tcp_socket, tcp_rx, tcp_tx, sockfd) saved in usbpip_device without holding the lock. Current connection tear down sequence: Step 1

[PATCH] usbip: fix vhci races in connection tear down

2021-03-11 Thread Shuah Khan
. Reported-and-tested-by: syzbot+a93fba6d384346a76...@syzkaller.appspotmail.com Signed-off-by: Shuah Khan --- drivers/usb/usbip/usbip_common.h | 1 + drivers/usb/usbip/vhci_hcd.c | 55 +++- drivers/usb/usbip/vhci_sysfs.c | 4 +++ 3 files changed, 45 insertions(+), 15

Re: [PATCH][next] usbip: Fix incorrect double assignment to udc->ud.tcp_rx

2021-03-11 Thread Shuah Khan
On 3/11/21 7:16 AM, Shuah Khan wrote: On 3/11/21 3:44 AM, Colin King wrote: From: Colin Ian King Currently udc->ud.tcp_rx is being assigned twice, the second assignment is incorrect, it should be to udc->ud.tcp_tx instead of rx. Fix this. Addresses-Coverity: ("Unused va

Re: [PATCH][next] usbip: Fix incorrect double assignment to udc->ud.tcp_rx

2021-03-11 Thread Shuah Khan
d.tcp_tx = tcp_tx; udc->ud.status = SDEV_ST_USED; spin_unlock_irq(&udc->ud.lock); Thank you for finding and fixing this. This is my bad. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.4 0/7] 4.4.261-rc1 review

2021-03-10 Thread Shuah Khan
: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 00/39] 4.19.180-rc1 review

2021-03-10 Thread Shuah Khan
at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.9 00/11] 4.9.261-rc1 review

2021-03-10 Thread Shuah Khan
: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 00/24] 5.4.105-rc1 review

2021-03-10 Thread Shuah Khan
: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.11 00/36] 5.11.6-rc1 review

2021-03-10 Thread Shuah Khan
: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.11.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 00/47] 5.10.23-rc2 review

2021-03-10 Thread Shuah Khan
at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 00/49] 5.10.23-rc1 review

2021-03-10 Thread Shuah Khan
On 3/10/21 11:27 AM, Greg Kroah-Hartman wrote: On Wed, Mar 10, 2021 at 11:08:10PM +0530, Naresh Kamboju wrote: On Wed, 10 Mar 2021 at 18:54, wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 5.10.23 release. There are 49 patches in this series, all will be

Re: [PATCH v2] kunit: fix checkpatch warning

2021-03-10 Thread Shuah Khan
On 3/4/21 4:12 PM, Shuah Khan wrote: On 3/3/21 9:35 PM, Lucas Stankus wrote: On Wed, Mar 03, 2021 at 12:56:05PM -0800, Brendan Higgins wrote: Did you change anything other than fixing the Signed-off-by that Shuah requested? No, I only fixed the Signed-off-by warning. Generally when you

Re: [PATCH 4/6] usbip: fix stub_dev usbip_sockfd_store() races leading to gpf

2021-03-09 Thread Shuah Khan
On 3/9/21 6:02 PM, Tetsuo Handa wrote: On 2021/03/10 9:29, Shuah Khan wrote: It is not a large grain lock. Since event_handler() is exclusively executed, this lock does _NOT_ block event_handler() unless attach/detach operations run concurrently. event handler queues the events. It

Re: [PATCH 4/6] usbip: fix stub_dev usbip_sockfd_store() races leading to gpf

2021-03-09 Thread Shuah Khan
On 3/9/21 5:03 PM, Tetsuo Handa wrote: On 2021/03/10 8:52, Shuah Khan wrote: On 3/9/21 4:40 PM, Tetsuo Handa wrote: On 2021/03/10 4:50, Shuah Khan wrote: On 3/9/21 4:04 AM, Tetsuo Handa wrote: On 2021/03/09 1:27, Shuah Khan wrote: Yes. We might need synchronization between events, threads

Re: [PATCH 4/6] usbip: fix stub_dev usbip_sockfd_store() races leading to gpf

2021-03-09 Thread Shuah Khan
On 3/9/21 4:40 PM, Tetsuo Handa wrote: On 2021/03/10 4:50, Shuah Khan wrote: On 3/9/21 4:04 AM, Tetsuo Handa wrote: On 2021/03/09 1:27, Shuah Khan wrote: Yes. We might need synchronization between events, threads, and shutdown in usbip_host side and in connection polling and threads in vhci

Re: [PATCH 4/6] usbip: fix stub_dev usbip_sockfd_store() races leading to gpf

2021-03-09 Thread Shuah Khan
On 3/9/21 4:04 AM, Tetsuo Handa wrote: On 2021/03/09 1:27, Shuah Khan wrote: Yes. We might need synchronization between events, threads, and shutdown in usbip_host side and in connection polling and threads in vhci. I am also looking at the shutdown sequences closely as well since the local

Re: [PATCH 4/6] usbip: fix stub_dev usbip_sockfd_store() races leading to gpf

2021-03-09 Thread Shuah Khan
On 3/8/21 9:27 AM, Shuah Khan wrote: On 3/8/21 3:10 AM, Tetsuo Handa wrote: On 2021/03/08 16:35, Tetsuo Handa wrote: On 2021/03/08 12:53, Shuah Khan wrote: Fix the above problems: - Stop using kthread_get_run() macro to create/start threads. - Create threads and get task struct reference

Re: [PATCH 4/6] usbip: fix stub_dev usbip_sockfd_store() races leading to gpf

2021-03-08 Thread Shuah Khan
On 3/8/21 3:10 AM, Tetsuo Handa wrote: On 2021/03/08 16:35, Tetsuo Handa wrote: On 2021/03/08 12:53, Shuah Khan wrote: Fix the above problems: - Stop using kthread_get_run() macro to create/start threads. - Create threads and get task struct reference. - Add kthread_create() failure handling

[PATCH 3/6] usbip: fix vudc to check for stream socket

2021-03-07 Thread Shuah Khan
Fix usbip_sockfd_store() to validate the passed in file descriptor is a stream socket. If the file descriptor passed was a SOCK_DGRAM socket, sock_recvmsg() can't detect end of stream. Cc: sta...@vger.kernel.org Suggested-by: Tetsuo Handa Signed-off-by: Shuah Khan --- drivers/usb/

[PATCH 4/6] usbip: fix stub_dev usbip_sockfd_store() races leading to gpf

2021-03-07 Thread Shuah Khan
t Reported-by: syzbot Reported-by: syzbot Reported-by: Tetsuo Handa Fixes: 9720b4bc76a83807 ("staging/usbip: convert to kthread") Cc: sta...@vger.kernel.org Signed-off-by: Shuah Khan --- drivers/usb/usbip/stub_dev.c | 32 +--- 1 file changed, 25 insertions(

[PATCH 5/6] usbip: fix vhci_hcd attach_store() races leading to gpf

2021-03-07 Thread Shuah Khan
o kthread") Cc: sta...@vger.kernel.org Signed-off-by: Shuah Khan --- drivers/usb/usbip/vhci_sysfs.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/drivers/usb/usbip/vhci_sysfs.c b/drivers/usb/usbip/vhci_sysfs.c index 1e1ae9bd06ab..c4b4256e5

[PATCH 1/6] usbip: fix stub_dev to check for stream socket

2021-03-07 Thread Shuah Khan
Fix usbip_sockfd_store() to validate the passed in file descriptor is a stream socket. If the file descriptor passed was a SOCK_DGRAM socket, sock_recvmsg() can't detect end of stream. Cc: sta...@vger.kernel.org Suggested-by: Tetsuo Handa Signed-off-by: Shuah Khan --- drivers/usb/

[PATCH 2/6] usbip: fix vhci_hcd to check for stream socket

2021-03-07 Thread Shuah Khan
Fix attach_store() to validate the passed in file descriptor is a stream socket. If the file descriptor passed was a SOCK_DGRAM socket, sock_recvmsg() can't detect end of stream. Cc: sta...@vger.kernel.org Suggested-by: Tetsuo Handa Signed-off-by: Shuah Khan --- drivers/usb/usbip/vhci_sy

[PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-07 Thread Shuah Khan
get_run() error path bug and starting threads before updating the local and shared state bug in the stub-up sequence. Shuah Khan (6): usbip: fix stub_dev to check for stream socket usbip: fix vhci_hcd to check for stream socket usbip: fix vudc to check for stream socket usbi

[PATCH 6/6] usbip: fix vudc usbip_sockfd_store races leading to gpf

2021-03-07 Thread Shuah Khan
eported-by: Tetsuo Handa Fixes: 9720b4bc76a83807 ("staging/usbip: convert to kthread") Cc: sta...@vger.kernel.org Signed-off-by: Shuah Khan --- drivers/usb/usbip/vudc_sysfs.c | 42 +++--- 1 file changed, 34 insertions(+), 8 deletions(-) diff --git

[tip: locking/core] lockdep: Add lockdep_assert_not_held()

2021-03-06 Thread tip-bot2 for Shuah Khan
The following commit has been merged into the locking/core branch of tip: Commit-ID: 3e31f94752e454bdd0ca4a1d046ee21f80c166c5 Gitweb: https://git.kernel.org/tip/3e31f94752e454bdd0ca4a1d046ee21f80c166c5 Author:Shuah Khan AuthorDate:Fri, 26 Feb 2021 17:06:58 -07:00

[tip: locking/core] lockdep: Add lockdep lock state defines

2021-03-06 Thread tip-bot2 for Shuah Khan
The following commit has been merged into the locking/core branch of tip: Commit-ID: f8cfa46608f8aa5ca5421ce281ab314129c15411 Gitweb: https://git.kernel.org/tip/f8cfa46608f8aa5ca5421ce281ab314129c15411 Author:Shuah Khan AuthorDate:Fri, 26 Feb 2021 17:06:59 -07:00

[tip: locking/core] ath10k: Detect conf_mutex held ath10k_drain_tx() calls

2021-03-06 Thread tip-bot2 for Shuah Khan
The following commit has been merged into the locking/core branch of tip: Commit-ID: bdb1050ee1faaec1e78c15de8b1959176f26c655 Gitweb: https://git.kernel.org/tip/bdb1050ee1faaec1e78c15de8b1959176f26c655 Author:Shuah Khan AuthorDate:Fri, 26 Feb 2021 17:07:00 -07:00

Re: [PATCH v2] kunit: fix checkpatch warning

2021-03-04 Thread Shuah Khan
On 3/3/21 9:35 PM, Lucas Stankus wrote: On Wed, Mar 03, 2021 at 12:56:05PM -0800, Brendan Higgins wrote: Did you change anything other than fixing the Signed-off-by that Shuah requested? No, I only fixed the Signed-off-by warning. Generally when you make a small change after receiving a Revi

[tip: locking/core] lockdep: Add lockdep_assert_not_held()

2021-03-03 Thread tip-bot2 for Shuah Khan
The following commit has been merged into the locking/core branch of tip: Commit-ID: ac1cce36595238680c32c3f197e5aa18db6fa7a3 Gitweb: https://git.kernel.org/tip/ac1cce36595238680c32c3f197e5aa18db6fa7a3 Author:Shuah Khan AuthorDate:Fri, 26 Feb 2021 17:06:58 -07:00

[tip: locking/core] ath10k: Detect conf_mutex held ath10k_drain_tx() calls

2021-03-03 Thread tip-bot2 for Shuah Khan
The following commit has been merged into the locking/core branch of tip: Commit-ID: de469d82991b905548b5dc6539177f7b881dce1b Gitweb: https://git.kernel.org/tip/de469d82991b905548b5dc6539177f7b881dce1b Author:Shuah Khan AuthorDate:Fri, 26 Feb 2021 17:07:00 -07:00

[tip: locking/core] lockdep: Add lockdep lock state defines

2021-03-03 Thread tip-bot2 for Shuah Khan
The following commit has been merged into the locking/core branch of tip: Commit-ID: 298df9652725502bedf3593203721c03b75271f3 Gitweb: https://git.kernel.org/tip/298df9652725502bedf3593203721c03b75271f3 Author:Shuah Khan AuthorDate:Fri, 26 Feb 2021 17:06:59 -07:00

Re: [PATCH] selftests: gpio: update .gitignore

2021-03-02 Thread Shuah Khan
On 3/2/21 9:07 AM, Bartosz Golaszewski wrote: On Tue, Mar 2, 2021 at 4:27 PM Shuah Khan wrote: On 3/2/21 7:44 AM, Linus Walleij wrote: On Wed, Feb 24, 2021 at 7:53 PM Bartosz Golaszewski wrote: From: Bartosz Golaszewski The executable that we build for GPIO selftests was renamed to gpio

Re: [PATCH] selftests: gpio: update .gitignore

2021-03-02 Thread Shuah Khan
On 3/2/21 7:44 AM, Linus Walleij wrote: On Wed, Feb 24, 2021 at 7:53 PM Bartosz Golaszewski wrote: From: Bartosz Golaszewski The executable that we build for GPIO selftests was renamed to gpio-mockup-cdev. Let's update .gitignore so that we don't show it as an untracked file. Fixes: 8bc395a

Re: [PATCH] kunit: fix checkpatch warning

2021-03-01 Thread Shuah Khan
On 2/26/21 2:05 PM, Brendan Higgins wrote: On Fri, Feb 26, 2021 at 12:54 PM Lucas Pires Stankus wrote: Tidy up code by fixing the following checkpatch warnings: CHECK: Alignment should match open parenthesis CHECK: Lines should not end with a '(' Signed-off-by: Lucas Stankus Reviewed-by: B

Re: [PATCH 4.4 00/93] 4.4.259-rc1 review

2021-03-01 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 000/247] 4.19.178-rc1 review

2021-03-01 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.9 000/134] 4.9.259-rc1 review

2021-03-01 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 000/661] 5.10.20-rc2 review

2021-03-01 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.11 000/774] 5.11.3-rc2 review

2021-03-01 Thread Shuah Khan
On 3/1/21 2:23 PM, Shuah Khan wrote: On 3/1/21 12:38 PM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.11.3 release. There are 774 patches in this series, all will be posted as a response to this one.  If anyone has any issues with these being applied, please

Re: [PATCH 5.11 000/774] 5.11.3-rc2 review

2021-03-01 Thread Shuah Khan
On 3/1/21 12:38 PM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.11.3 release. There are 774 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH v3 0/3] Add lockdep_assert_not_held()

2021-03-01 Thread Shuah Khan
On 3/1/21 4:02 AM, Kalle Valo wrote: Peter Zijlstra writes: On Mon, Mar 01, 2021 at 10:45:32AM +0200, Kalle Valo wrote: Peter Zijlstra writes: On Fri, Feb 26, 2021 at 05:06:57PM -0700, Shuah Khan wrote: Shuah Khan (3): lockdep: add lockdep_assert_not_held() lockdep: add lockdep

[PATCH v3 1/3] lockdep: add lockdep_assert_not_held()

2021-02-26 Thread Shuah Khan
lockdep_assert_not_held(). Link: https://lore.kernel.org/lkml/37a29c383bff2fb1605241ee6c7c9be3784fb3c6.1613171185.git.sk...@linuxfoundation.org/ Link: https://lore.kernel.org/linux-wireless/871rdmu9z9@codeaurora.org/ Signed-off-by: Shuah Khan --- include/linux/lockdep.h | 11 --- kernel

[PATCH v3 3/3] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-26 Thread Shuah Khan
://lore.kernel.org/lkml/37a29c383bff2fb1605241ee6c7c9be3784fb3c6.1613171185.git.sk...@linuxfoundation.org/ Link: https://lore.kernel.org/linux-wireless/871rdmu9z9@codeaurora.org/ Acked-by: Kalle Valo Signed-off-by: Shuah Khan --- drivers/net/wireless/ath/ath10k/mac.c | 2 ++ 1 file changed, 2 insertions

[PATCH v3 2/3] lockdep: add lockdep lock state defines

2021-02-26 Thread Shuah Khan
) and __lock_is_held() to use the new defines. Link: https://lore.kernel.org/lkml/37a29c383bff2fb1605241ee6c7c9be3784fb3c6.1613171185.git.sk...@linuxfoundation.org/ Link: https://lore.kernel.org/linux-wireless/871rdmu9z9@codeaurora.org/ Signed-off-by: Shuah Khan --- include/linux/lockdep.h

[PATCH v3 0/3] Add lockdep_assert_not_held()

2021-02-26 Thread Shuah Khan
s the new interface in ath10k_drain_tx() function. Added Kalle Valo's Ack from v1 for this change. Tested on the mainline from yesterday. Shuah Khan (3): lockdep: add lockdep_assert_not_held() lockdep: add lockdep lock state defines ath10k: detect conf_mutex held ath10k_drain_tx() calls

Re: [PATCH] iommu/amd: Fix event counter availability check

2021-02-26 Thread Shuah Khan
On 2/26/21 2:44 PM, Paul Menzel wrote: [cc: +suravee, +jörg] Dear Alex, dear Shuah, dear Suravee, dear Jörg, Am 03.06.20 um 08:54 schrieb Alexander Monakov: On Tue, 2 Jun 2020, Shuah Khan wrote: I changed the logic to read config to get max banks and counters before checking if counters

Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()

2021-02-26 Thread Shuah Khan
On 2/26/21 2:07 PM, Peter Zijlstra wrote: On Fri, Feb 26, 2021 at 10:52:13AM -0700, Shuah Khan wrote: + /* avoid false negative lockdep_assert_not_held() +* and lockdep_assert_held() +*/ That's a coding style fail. Checkpatch didn'

Re: [PATCH v2 2/3] lockdep: add lockdep lock state defines

2021-02-26 Thread Shuah Khan
On 2/26/21 11:03 AM, Johannes Berg wrote: @@ -5475,7 +5476,7 @@ noinstr int lock_is_held_type(const struct lockdep_map *lock, int read) /* avoid false negative lockdep_assert_not_held() * and lockdep_assert_held() */ - return -1;

Re: [PATCH 5/5] ath10k: reduce invalid ht params rate message noise

2021-02-26 Thread Shuah Khan
On 2/11/21 4:24 AM, Kalle Valo wrote: Shuah Khan writes: On 2/10/21 1:28 AM, Kalle Valo wrote: Wen Gong writes: On 2021-02-10 08:42, Shuah Khan wrote: ath10k_mac_get_rate_flags_ht() floods dmesg with the following messages, when it fails to find a match for mcs=7 and rate=1440

[PATCH v2 2/3] lockdep: add lockdep lock state defines

2021-02-26 Thread Shuah Khan
/lkml/37a29c383bff2fb1605241ee6c7c9be3784fb3c6.1613171185.git.sk...@linuxfoundation.org/ Link: https://lore.kernel.org/linux-wireless/871rdmu9z9@codeaurora.org/ Signed-off-by: Shuah Khan --- include/linux/lockdep.h | 11 +-- kernel/locking/lockdep.c | 3 ++- 2 files changed, 11 inser

[PATCH v2 3/3] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-26 Thread Shuah Khan
://lore.kernel.org/lkml/37a29c383bff2fb1605241ee6c7c9be3784fb3c6.1613171185.git.sk...@linuxfoundation.org/ Link: https://lore.kernel.org/linux-wireless/871rdmu9z9@codeaurora.org/ Acked-by: Kalle Valo Signed-off-by: Shuah Khan --- drivers/net/wireless/ath/ath10k/mac.c | 2 ++ 1 file changed, 2 insertions

[PATCH v2 0/3] Add lockdep_assert_not_held()

2021-02-26 Thread Shuah Khan
from yesterday. Shuah Khan (3): lockdep: add lockdep_assert_not_held() lockdep: add lockdep lock state defines ath10k: detect conf_mutex held ath10k_drain_tx() calls drivers/net/wireless/ath/ath10k/mac.c | 2 ++ include/linux/lockdep.h | 18 +++--- kernel/loc

[PATCH v2 1/3] lockdep: add lockdep_assert_not_held()

2021-02-26 Thread Shuah Khan
lockdep_assert_not_held(). Link: https://lore.kernel.org/lkml/37a29c383bff2fb1605241ee6c7c9be3784fb3c6.1613171185.git.sk...@linuxfoundation.org/ Link: https://lore.kernel.org/linux-wireless/871rdmu9z9@codeaurora.org/ Signed-off-by: Shuah Khan --- include/linux/lockdep.h | 11 --- kernel

Re: [PATCH 5.4 00/17] 5.4.101-rc1 review

2021-02-25 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.11 00/12] 5.11.2-rc1 review

2021-02-25 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.11.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 00/23] 5.10.19-rc1 review

2021-02-25 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.11 00/12] 5.11.1-rc1 review

2021-02-23 Thread Shuah Khan
On 2/23/21 2:05 PM, Shuah Khan wrote: On 2/22/21 5:12 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.11.1 release. There are 12 patches in this series, all will be posted as a response to this one.  If anyone has any issues with these being applied, please

Re: [PATCH 4.4 00/35] 4.4.258-rc1 review

2021-02-23 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.9 00/49] 4.9.258-rc1 review

2021-02-23 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 00/50] 4.19.177-rc1 review

2021-02-23 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 00/13] 5.4.100-rc1 review

2021-02-23 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 00/29] 5.10.18-rc1 review

2021-02-23 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.11 00/12] 5.11.1-rc1 review

2021-02-23 Thread Shuah Khan
I narrowed it down to the following as a possible lead to start looking: amdgpu :0b:00.0: [drm] Cannot find any crtc or sizes Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 1/2] lockdep: add lockdep_assert_not_held()

2021-02-22 Thread Shuah Khan
On 2/15/21 9:10 AM, Johannes Berg wrote: On Mon, 2021-02-15 at 17:04 +0100, Peter Zijlstra wrote: On Mon, Feb 15, 2021 at 02:12:30PM +0100, Johannes Berg wrote: On Mon, 2021-02-15 at 11:44 +0100, Peter Zijlstra wrote: I think something like so will work, but please double check. Yeah, that l

Re: [PATCH 00/20] Manual replacement of all strlcpy in favor of strscpy

2021-02-22 Thread Shuah Khan
On 2/22/21 8:12 AM, Romain Perier wrote: strlcpy() copy a C-String into a sized buffer, the result is always a valid NULL-terminated that fits in the buffer, howerver it has severals issues. It reads the source buffer first, which is dangerous if it is non NULL-terminated or if the corresponding

Re: [PATCH 19/20] usbip: usbip_host: Manual replacement of the deprecated strlcpy() with return values

2021-02-22 Thread Shuah Khan
-E2BIG) return -EINVAL; if (!strncmp(buf, "add ", 4)) { Looks good to me. Thank you. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] Revert "ath9k: fix ath_tx_process_buffer() potential null ptr dereference"

2021-02-18 Thread Shuah Khan
On 2/17/21 11:23 PM, Kalle Valo wrote: Shuah Khan wrote: This reverts commit a56c14bb21b296fb6d395164ab62ef2e419e5069. ath_tx_process_buffer() doesn't dereference or check sta and passes it to ath_tx_complete_aggr() and ath_tx_complete_buf(). ath_tx_complete_aggr() checks the pointer b

[GIT PULL] KUnit update for Linux 5.12-rc1

2021-02-17 Thread Shuah Khan
Hi Linus, Please pull the following KUnit update for Linux 5.12-rc1. This KUnit update for Linux 5.12-rc1 consists of consists of: -- support for filtering test suites using glob from Daniel Latypov. "kunit_filter.glob" command line option is passed to the UML kernel, which currently onl

[GIT PULL] Kselftest update for Linux 5.12-rc1

2021-02-17 Thread Shuah Khan
Hi Linus, Please pull the following Kselftest update for Linux 5.12-rc1. This Kselftest update for Linux 5.12-rc1 consists of: - dmabuf-heaps test fixes and cleanups from John Stultz. - seccomp test fix to accept any valid fd in user_notification_addfd. - Minor fixes to breakpoints and vDSO tes

Re: [PATCH 5.10 00/54] 5.10.16-rc1 review

2021-02-17 Thread Shuah Khan
On 2/13/21 5:58 AM, Greg Kroah-Hartman wrote: On Fri, Feb 12, 2021 at 09:17:13AM -0700, Shuah Khan wrote: On 2/11/21 8:01 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.16 release. There are 54 patches in this series, all will be posted as a response to

[PATCH] Revert "ath9k: fix ath_tx_process_buffer() potential null ptr dereference"

2021-02-17 Thread Shuah Khan
g buffer completion if the pointer (sta) is NULL. Signed-off-by: Shuah Khan --- drivers/net/wireless/ath/ath9k/xmit.c | 28 --- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k

Re: [PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference

2021-02-17 Thread Shuah Khan
On 2/17/21 7:56 AM, Shuah Khan wrote: On 2/17/21 12:30 AM, Kalle Valo wrote: Shuah Khan writes: On 2/16/21 12:53 AM, Felix Fietkau wrote: On 2021-02-16 08:03, Kalle Valo wrote: Shuah Khan wrote: ath_tx_process_buffer() references ieee80211_find_sta_by_ifaddr() return pointer (sta

Re: [PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference

2021-02-17 Thread Shuah Khan
On 2/17/21 12:30 AM, Kalle Valo wrote: Shuah Khan writes: On 2/16/21 12:53 AM, Felix Fietkau wrote: On 2021-02-16 08:03, Kalle Valo wrote: Shuah Khan wrote: ath_tx_process_buffer() references ieee80211_find_sta_by_ifaddr() return pointer (sta) outside null check. Fix it by moving the

Re: [PATCH 5.4 00/60] 5.4.99-rc1 review

2021-02-16 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 000/104] 5.10.17-rc1 review

2021-02-16 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference

2021-02-16 Thread Shuah Khan
On 2/16/21 12:53 AM, Felix Fietkau wrote: On 2021-02-16 08:03, Kalle Valo wrote: Shuah Khan wrote: ath_tx_process_buffer() references ieee80211_find_sta_by_ifaddr() return pointer (sta) outside null check. Fix it by moving the code block under the null check. This problem was found while

<    1   2   3   4   5   6   7   8   9   10   >