Re: [PATCH 4.4 00/31] 4.4.253-rc1 review

2021-01-22 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 00/22] 4.19.170-rc1 review

2021-01-22 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.9 00/35] 4.9.253-rc1 review

2021-01-22 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 00/33] 5.4.92-rc1 review

2021-01-22 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 00/43] 5.10.10-rc1 review

2021-01-22 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 3/8] cpupower: Add CPUPOWER_CAP_AMD_HW_PSTATE cpuid caps flag

2021-01-22 Thread Shuah Khan
On 1/22/21 10:38 AM, Nathan Fontenot wrote: Add a check in get_cpu_info() for the ability to read frequencies from hardware and set the CPUPOWER_CAP_AMD_HW_PSTATE cpuid flag. The cpuid flag is set when CPUID_8007_EDX[7] is set, which is all families >= 10h. The check excludes family 14h becau

Re: [PATCH 1/8] cpupower: Update msr_pstate union struct naming

2021-01-22 Thread Shuah Khan
On 1/22/21 10:38 AM, Nathan Fontenot wrote: The msr_pstate union struct named fam17h_bits is misleading since this is the struct to use for all families >= 0x17, not just for family 0x17. Rename the bits structs to be 'pstate' (for pre family 17h CPUs) and 'pstatedef' (for CPUs since fam 17h) to

Re: [PATCH] cpupower: add Makefile dependencies for install targets

2021-01-22 Thread Shuah Khan
On 1/7/21 2:29 PM, Thomas Renninger wrote: Am Donnerstag, 7. Januar 2021, 22:15:16 CET schrieb Ivan Babrou: On Thu, Jan 7, 2021 at 12:59 PM Thomas Renninger wrote: Am Donnerstag, 7. Januar 2021, 18:42:25 CET schrieb Ivan Babrou: On Thu, Jan 7, 2021 at 2:07 AM Thomas Renninger wrote: Am Dien

Re: rpc_xprt_debugfs_register() - atomic_inc_return() usage

2021-01-21 Thread Shuah Khan
On 1/21/21 10:56 AM, Trond Myklebust wrote: On Wed, 2021-01-20 at 16:52 -0700, Shuah Khan wrote: Hi Anna and Trond, I came across the following while reviewing atomic_inc_return() usages that cast return value to unsigned rpc_xprt_debugfs_register()'s atomic_inc_return() usage looks a bi

rpc_xprt_debugfs_register() - atomic_inc_return() usage

2021-01-20 Thread Shuah Khan
Hi Anna and Trond, I came across the following while reviewing atomic_inc_return() usages that cast return value to unsigned rpc_xprt_debugfs_register()'s atomic_inc_return() usage looks a bit odd. - cur_id isn't initialized - id = (unsigned int)atomic_inc_return(&cur_id); Please note that id

Re: [PATCH 4.4 00/18] 4.4.252-rc1 review

2021-01-15 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.9 00/25] 4.9.252-rc1 review

2021-01-15 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 00/43] 4.19.168-rc1 review

2021-01-15 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 00/62] 5.4.90-rc1 review

2021-01-15 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 000/103] 5.10.8-rc1 review

2021-01-15 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH -next] usb: usbip: Use DEFINE_SPINLOCK() for spinlock

2021-01-15 Thread Shuah Khan
lock); - for (i = 0; i < MAX_BUSID; i++) spin_lock_init(&busid_table[i].busid_lock); } Sorry for the delay on this. Looks good to me. Acked-by: Shuah Khan thanks, -- Shuah

[GIT PULL] Kselftest fixes for Linux 5.11-rc4

2021-01-14 Thread Shuah Khan
Hi Linus, Please pull the following Kselftest fixes update for Linux 5.11-rc4 This Kselftest fixes update for Linux 5.11-rc4 consists of one single fix to skip BPF selftests by default. BPF selftests have a hard dependency on cutting edge versions of tools in the BPF ecosystem including LLVM. S

Re: [PATCH 5.10 000/144] 5.10.7-rc2 review

2021-01-11 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 00/92] 5.4.89-rc1 review

2021-01-11 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 00/77] 4.19.167-rc1 review

2021-01-11 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.9 00/45] 4.9.251-rc1 review

2021-01-11 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.4 00/38] 4.4.251-rc1 review

2021-01-11 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

[GIT PULL] KUnit update for Linux 5.11-rc3

2021-01-08 Thread Shuah Khan
Hi Linus, Please pull the following KUnit fixes update for Linux 5.11-rc3. This kunit update for Linux 5.11-rc3 consists one fix to force the use of the 'tty' console for UML. Given that kunit tool requires the console output, explicitly stating the dependency makes sense than relying on it bein

[GIT PULL] Kselftest fixes for Linux 5.11-rc3

2021-01-08 Thread Shuah Khan
Hi Linus, Please pull the following fixes update for Linux 5.11-rc3. This fixes update for 5.11-rc3 consists of two minor fixes to vDSO test changes in 5.11-rc1 update. diff is attached. thanks, -- Shuah The following changes si

Re: [PATCH 4.4 00/19] 4.4.250-rc1 review

2021-01-07 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.4 00/20] 4.4.250-rc2 review

2021-01-07 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.9 00/33] 4.9.250-rc2 review

2021-01-07 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 00/13] 5.4.88-rc1 review

2021-01-07 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 0/8] 4.19.166-rc1 review

2021-01-07 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 00/20] 5.10.6-rc1 review

2021-01-07 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] kunit: tool: Force the use of the 'tty' console for UML

2021-01-07 Thread Shuah Khan
On 1/7/21 9:53 AM, Petr Mladek wrote: On Wed 2021-01-06 12:29:12, David Gow wrote: On Wed, Jan 6, 2021 at 3:52 AM Shuah Khan wrote: On 1/5/21 11:57 AM, Andy Shevchenko wrote: On Tue, Jan 05, 2021 at 09:34:33AM -0700, Shuah Khan wrote: On 1/5/21 9:21 AM, Petr Mladek wrote: On Mon 2021-01

Re: [PATCH] kunit: tool: Force the use of the 'tty' console for UML

2021-01-05 Thread Shuah Khan
On 1/5/21 11:57 AM, Andy Shevchenko wrote: On Tue, Jan 05, 2021 at 09:34:33AM -0700, Shuah Khan wrote: On 1/5/21 9:21 AM, Petr Mladek wrote: On Mon 2021-01-04 09:23:57, Shuah Khan wrote: On 12/22/20 4:11 AM, Andy Shevchenko wrote: On Mon, Dec 21, 2020 at 11:39:00PM -0800, David Gow wrote

Re: [PATCH] cpuidle_set accepts alpha numeric values for idle-set operation

2021-01-05 Thread Shuah Khan
On 1/5/21 11:03 AM, Shuah Khan wrote: On 1/5/21 5:24 AM, Brahadambal Srinivasan wrote: For both the d and e options in cpuidle_set, an atoi() conversion is done without checking if the input argument is all numeric. So, an atoi conversion is done on any character provided as input and the CPU

Re: [PATCH] cpuidle_set accepts alpha numeric values for idle-set operation

2021-01-05 Thread Shuah Khan
On 1/5/21 11:03 AM, Shuah Khan wrote: On 1/5/21 5:24 AM, Brahadambal Srinivasan wrote: For both the d and e options in cpuidle_set, an atoi() conversion is done without checking if the input argument is all numeric. So, an atoi conversion is done on any character provided as input and the CPU

Re: [PATCH] cpuidle_set accepts alpha numeric values for idle-set operation

2021-01-05 Thread Shuah Khan
On 1/5/21 5:24 AM, Brahadambal Srinivasan wrote: For both the d and e options in cpuidle_set, an atoi() conversion is done without checking if the input argument is all numeric. So, an atoi conversion is done on any character provided as input and the CPU idle_set operation continues with that in

Re: [PATCH 4.19 00/35] 4.19.165-rc1 review

2021-01-05 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 00/47] 5.4.87-rc1 review

2021-01-05 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 00/63] 5.10.5-rc1 review

2021-01-05 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] kunit: tool: Force the use of the 'tty' console for UML

2021-01-05 Thread Shuah Khan
On 1/5/21 9:21 AM, Petr Mladek wrote: On Mon 2021-01-04 09:23:57, Shuah Khan wrote: On 12/22/20 4:11 AM, Andy Shevchenko wrote: On Mon, Dec 21, 2020 at 11:39:00PM -0800, David Gow wrote: kunit_tool relies on the UML console outputting printk() output to the tty in order to get results. Since

Re: [PATCH] kunit: tool: Force the use of the 'tty' console for UML

2021-01-04 Thread Shuah Khan
On 12/22/20 4:11 AM, Andy Shevchenko wrote: On Mon, Dec 21, 2020 at 11:39:00PM -0800, David Gow wrote: kunit_tool relies on the UML console outputting printk() output to the tty in order to get results. Since the default console driver could change, pass 'console=tty' to the kernel. This is tri

Re: [PATCH] selftests/vDSO: fix -Wformat warning in vdso_test_correctness

2020-12-17 Thread Shuah Khan
On 12/17/20 9:32 AM, Tobias Klauser wrote: Fix the following -Wformat warnings in vdso_test_correctness.c: vdso_test_correctness.c: In function ‘test_one_clock_gettime64’: vdso_test_correctness.c:352:21: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘long lo

Re: [PATCH] selftests/vDSO: add additional binaries to .gitignore

2020-12-17 Thread Shuah Khan
On 12/17/20 9:31 AM, Tobias Klauser wrote: Add the test binaries introduced by commit 693f5ca08ca0 ("kselftest: Extend vDSO selftest"), commit 03f55c7952c9 ("kselftest: Extend vDSO selftest to clock_getres") and commit c7e5789b24d3 ("kselftest: Move test_vdso to the vDSO test suite") to .gitignor

Re: [PATCH v4] kcov, usbip: collect coverage from vhci_rx_loop

2020-12-16 Thread Shuah Khan
Konovalov Signed-off-by: Andrey Konovalov --- Changes in v4: - Add USB/IP specific wrappers around kcov functions to avoid having a lot of ifdef CONFIG_KCOV in the USB/IP code. Looks good to me. Sorry for the delay on this. It just got lost in my Inbox. Acked-by: Shuah Khan thanks, -- Shuah

[GIT PULL] KUnit update for Linux 5.11-rc1

2020-12-15 Thread Shuah Khan
Hi Linus, Please pull the following KUnit update for Linux 5.11-rc1. This kunit update for Linux 5.11-rc1 consists of: -- documentation update and fix to kunit_tool to parse diagnostic messages correctly from David Gow -- Support for Parameterized Testing and fs/ext4 test updates to use K

[GIT PULL] Kselftest update for Linux 5.11-rc1

2020-12-15 Thread Shuah Khan
Hi Linus, Please pull the following Kselftest update for Linux 5.11-rc1. This kselftest update for Linux 5.11-rc1 consists of: - Much needed gpio test Makefile cleanup to various problems with test dependencies and build errors from Michael Ellerman - Enabling vDSO test on non x86 platforms

Re: related to fixing depreciated api

2020-12-15 Thread Shuah Khan
On 12/15/20 9:12 AM, Shuah Khan wrote: On 12/14/20 9:42 AM, Jeffrin Jose T wrote: hello, i have worked on to  fix  depreciated api issue from tools/testing/selftests/intel_pstate/aerf.c i met with the following error related... --x--x-> $pwd /h

[GIT PULL] Kselftest fixes update for Linux 5.11-rc1

2020-12-15 Thread Shuah Khan
Hi Linus, Please pull this Kselftest fixes update for Linux 5.11-rc1. This Kselftest fixes update for Linux 5.11-rc1 consists of build error fixes for clone3 and rseq tests. diff is attached. thanks, -- Shuah The following chang

Re: [PATCH v2 4/4] MAINTAINERS: Add lib/test_scanf.c to VSPRINTF

2020-12-15 Thread Shuah Khan
On 12/9/20 7:22 AM, Petr Mladek wrote: On Mon 2020-11-30 14:58:00, Richard Fitzgerald wrote: Adds the new scanf test to the VSPRINTF group. Signed-off-by: Richard Fitzgerald I would prefer to squash this into the 2nd patch that adds the file. But anyway: Reviewed-by: Petr Mladek Agree w

Re: related to fixing depreciated api

2020-12-15 Thread Shuah Khan
On 12/14/20 9:42 AM, Jeffrin Jose T wrote: hello, i have worked on to fix depreciated api issue from tools/testing/selftests/intel_pstate/aerf.c i met with the following error related... --x--x-> $pwd /home/jeffrin/UP/linux-kselftest/tools/testing/

Re: [PATCH 5.9 000/105] 5.9.15-rc1 review

2020-12-14 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: common_interrupt: No irq handler for vector

2020-12-14 Thread Shuah Khan
On 12/14/20 3:28 PM, Thomas Gleixner wrote: Shuah, On Mon, Dec 14 2020 at 13:57, Shuah Khan wrote: On 12/14/20 1:41 PM, Thomas Gleixner wrote: Here is the processor and BIOS info: AMD Ryzen 7 4700G with Radeon Graphics LENOVO ThinkCentre Embedded Controller -[O4ZCT12A-1.12]- LENOVO ThinkCentre

Re: [PATCH 5.10 0/2] 5.10.1-rc1 review

2020-12-14 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 00/36] 5.4.84-rc1 review

2020-12-14 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: common_interrupt: No irq handler for vector

2020-12-14 Thread Shuah Khan
On 12/14/20 1:41 PM, Thomas Gleixner wrote: On Mon, Dec 14 2020 at 09:11, Shuah Khan wrote: On 12/12/20 12:33 PM, Thomas Gleixner wrote: On Fri, Dec 11 2020 at 13:41, Shuah Khan wrote: I am debugging __common_interrupt: 1.55 No irq handler for vector messages and noticed comments and code

Re: common_interrupt: No irq handler for vector

2020-12-14 Thread Shuah Khan
On 12/12/20 12:33 PM, Thomas Gleixner wrote: On Fri, Dec 11 2020 at 13:41, Shuah Khan wrote: I am debugging __common_interrupt: 1.55 No irq handler for vector messages and noticed comments and code don't agree: I bet that's on an AMD system with broken AGESA BIOS Good luck de

common_interrupt: No irq handler for vector

2020-12-11 Thread Shuah Khan
I am debugging __common_interrupt: 1.55 No irq handler for vector messages and noticed comments and code don't agree: arch/x86/kernel/apic/msi.c: msi_set_affinity() says: * If the vector is in use then the installed device handler will * denote it as spurious which is no harm as this is a rar

Re: [PATCH] selftests: propagate CC to selftest submakes

2020-12-10 Thread Shuah Khan
On 12/10/20 5:10 PM, Andrew Delgadillo wrote: On Thu, Dec 10, 2020 at 3:08 PM Nick Desaulniers wrote: On Thu, Dec 3, 2020 at 2:10 PM Andrew Delgadillo wrote: lib.mk defaults to gcc when CC is not set. When building selftests as part of a kernel compilation, MAKEFLAGS is cleared to allow imp

Re: [PATCH 4.4 00/39] 4.4.248-rc1 review

2020-12-10 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.9 00/45] 4.9.248-rc1 review

2020-12-10 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 00/39] 4.19.163-rc1 review

2020-12-10 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 00/54] 5.4.83-rc2 review

2020-12-10 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.9 00/75] 5.9.14-rc1 review

2020-12-10 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v2] selftests/clone3: Fix build error

2020-12-07 Thread Shuah Khan
On 11/26/20 8:16 PM, Xingxing Su wrote: When compiling the selftests with the -std=gnu99 option the build can fail with. Following build error: test_core.c: In function ‘test_cgcore_destroy’: test_core.c:87:2: error: ‘for’ loop initial declarations are only allowed in C99 mode for

Re: [PATCH] rseq/selftests: Fix MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ build error under other arch.

2020-12-07 Thread Shuah Khan
On 11/25/20 9:10 AM, Mathieu Desnoyers wrote: - On Nov 24, 2020, at 11:04 PM, Xingxing Su suxingx...@loongson.cn wrote: Except arch x86, the function rseq_offset_deref_addv is not defined. The function test_membarrier_manager_thread call rseq_offset_deref_addv produces a build error. The R

Re: [PATCH v9 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature

2020-12-02 Thread Shuah Khan
On 12/2/20 9:07 AM, Theodore Y. Ts'o wrote: On Mon, Nov 16, 2020 at 11:11:50AM +0530, Arpitha Raghunandan wrote: Modify fs/ext4/inode-test.c to use the parameterized testing feature of KUnit. Signed-off-by: Arpitha Raghunandan <98.a...@gmail.com> Signed-off-by: Marco Elver Acked-by: Theodore

Re: [PATCH v9 1/2] kunit: Support for Parameterized Testing

2020-12-02 Thread Shuah Khan
On 12/1/20 4:31 PM, Marco Elver wrote: On Tue, 1 Dec 2020 at 23:28, Shuah Khan wrote: On 11/30/20 3:22 PM, Brendan Higgins wrote: On Mon, Nov 23, 2020 at 11:25 PM David Gow wrote: On Mon, Nov 23, 2020 at 9:08 PM Marco Elver wrote: On Tue, 17 Nov 2020 at 08:21, David Gow wrote: On Mon

Re: [PATCH 4.4 00/24] 4.4.247-rc1 review

2020-12-02 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.9 00/42] 4.9.247-rc1 review

2020-12-02 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 00/57] 4.19.161-rc1 review

2020-12-02 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 00/98] 5.4.81-rc1 review

2020-12-02 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.9 000/152] 5.9.12-rc1 review

2020-12-02 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v9 1/2] kunit: Support for Parameterized Testing

2020-12-01 Thread Shuah Khan
On 11/30/20 3:22 PM, Brendan Higgins wrote: On Mon, Nov 23, 2020 at 11:25 PM David Gow wrote: On Mon, Nov 23, 2020 at 9:08 PM Marco Elver wrote: On Tue, 17 Nov 2020 at 08:21, David Gow wrote: On Mon, Nov 16, 2020 at 1:41 PM Arpitha Raghunandan <98.a...@gmail.com> wrote: Implementation o

[GIT PULL] cpupower update for Linux 5.11-rc1

2020-11-30 Thread Shuah Khan
Hi Rafael, Please pull the following cpupower update for Linux 5.11-rc1. This cpupower update for Linux 5.11-rc1 consists of a change to provide online and offline CPU information. This change makes it easier to keep track of offline cpus whose cpuidle or cpufreq property aren't changed when upd

Re: linux-next: manual merge of the tip tree with the cpupower tree

2020-11-30 Thread Shuah Khan
On 11/22/20 7:42 PM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the tip tree got a conflict in: tools/power/cpupower/utils/helpers/misc.c between commit: 748f0d70087c ("cpupower: Provide online and offline CPU information") from the cpupower tree and commit: 8113ab

Re: [PATCH 4.4 00/38] 4.4.246-rc1 review

2020-11-23 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.9 00/47] 4.9.246-rc1 review

2020-11-23 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 00/91] 4.19.160-rc1 review

2020-11-23 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.9 000/252] 5.9.11-rc1 review

2020-11-23 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 000/158] 5.4.80-rc1 review

2020-11-23 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.4 00/15] 4.4.245-rc1 review

2020-11-20 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.9 00/16] 4.9.245-rc1 review

2020-11-20 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 00/14] 4.19.159-rc1 review

2020-11-20 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 00/17] 5.4.79-rc1 review

2020-11-20 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.9 00/14] 5.9.10-rc1 review

2020-11-20 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v12 5/5] selftest: mhi: Add support to test MHI LOOPBACK channel

2020-11-20 Thread Shuah Khan
On 11/16/20 3:46 PM, Hemant Kumar wrote: Loopback test opens the MHI device file node and writes a data buffer to it. MHI UCI kernel space driver copies the data and sends it to MHI uplink (Tx) LOOPBACK channel. MHI device loops back the same data to MHI downlink (Rx) LOOPBACK channel. This data

Re: [PATCH v2] android/ion: fix error return code in opensocket()

2020-11-18 Thread Shuah Khan
On 11/18/20 3:47 AM, Wang Hai wrote: Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 47a18c42d992 ("android/ion: userspace test utility for ion buffer sharing") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2

[GIT PULL] Kunit fixes update for Linux 5.10-rc5

2020-11-17 Thread Shuah Khan
Hi Linus, Please pull the following Kunit fixes update for Linux 5.10-rc5. This Kunit update for Linux 5.10-rc5 consists of several fixes Kunit documentation, tool, compile time fixes not pollute source directory, and fix to remove tools/testing/kunit/.gitattributes file. diff is attached. Bre

Re: [PATCH 4.9 00/78] 4.9.244-rc1 review

2020-11-17 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 000/101] 4.19.158-rc1 review

2020-11-17 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 000/151] 5.4.78-rc1 review

2020-11-17 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.9 000/255] 5.9.9-rc1 review

2020-11-17 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v2 01/13] seqnum_ops: Introduce Sequence Number Ops

2020-11-17 Thread Shuah Khan
On 11/17/20 10:38 AM, Matthew Wilcox wrote: On Tue, Nov 17, 2020 at 09:34:24AM -0700, Shuah Khan wrote: seqnum_inc() should just return the new value -- seqnum_inc_return is too verbose. And do we not need a seqnum_add()? I had the patch series with seqnum_inc() all ready to go and then

Re: [PATCH v2 01/13] seqnum_ops: Introduce Sequence Number Ops

2020-11-17 Thread Shuah Khan
On 11/17/20 10:38 AM, Matthew Wilcox wrote: On Tue, Nov 17, 2020 at 09:34:24AM -0700, Shuah Khan wrote: seqnum_inc() should just return the new value -- seqnum_inc_return is too verbose. And do we not need a seqnum_add()? I had the patch series with seqnum_inc() all ready to go and then

Re: [PATCH v2 01/13] seqnum_ops: Introduce Sequence Number Ops

2020-11-17 Thread Shuah Khan
On 11/13/20 2:03 PM, Matthew Wilcox wrote: +== +Sequence Number Operations +== + +:Author: Shuah Khan +:Copyright: |copy| 2020, The Linux Foundation +:Copyright: |copy| 2020, Shuah Khan + +Sequence Number api provides interfaces for unsigned up

Re: [PATCH v2 01/13] seqnum_ops: Introduce Sequence Number Ops

2020-11-17 Thread Shuah Khan
On 11/16/20 7:53 AM, Peter Zijlstra wrote: On Fri, Nov 13, 2020 at 10:46:03AM -0700, Shuah Khan wrote: +Increment interface +--- + +Increments sequence number and returns the new value. :: + +seqnum32_inc_return() --> (u32) atomic_inc_return(seq

Re: [PATCH v2 01/13] seqnum_ops: Introduce Sequence Number Ops

2020-11-17 Thread Shuah Khan
On 11/16/20 7:58 AM, Peter Zijlstra wrote: On Mon, Nov 16, 2020 at 03:49:14PM +0100, Peter Zijlstra wrote: On Fri, Nov 13, 2020 at 09:03:27PM +, Matthew Wilcox wrote: I think almost all of this information should go into atomic_ops.rst No, we should delete atomic_ops.rst. It's bitrotted n

Re: checking for "config" file existence.

2020-11-16 Thread Shuah Khan
On 11/12/20 10:40 AM, Jeffrin Jose T wrote: hello, i wrote a small program to check for the existence of "config" files for testing projects under kselftest framework. chmod 755 test_config.py This file should be located in "tools/testing/selftests" This can be run as "./test_config.py" Why

Re: [PATCH v41 20/24] selftests/x86: Add a selftest for SGX

2020-11-16 Thread Shuah Khan
On 11/12/20 3:01 PM, Jarkko Sakkinen wrote: Add a selftest for SGX. It is a trivial test where a simple enclave copies one 64-bit word of memory between two memory locations, but ensures that all SGX hardware and software infrastructure is functioning. Cc: Shuah Khan Cc: linux-kselft

[PATCH v2 05/13] drivers/base/test/test_async_driver_probe: convert to use seqnum_ops

2020-11-13 Thread Shuah Khan
: Shuah Khan --- drivers/base/test/test_async_driver_probe.c | 28 + 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/base/test/test_async_driver_probe.c b/drivers/base/test/test_async_driver_probe.c index 3bb7beb127a9..75a3b617dcac 100644 --- a/drivers

[PATCH v2 12/13] drivers/staging/unisys/visorhba: convert stats to use seqnum_ops

2020-11-13 Thread Shuah Khan
Sequence Number api provides interfaces for unsigned atomic up counters leveraging atomic_t and atomic64_t ops underneath. Convert it to use seqnum_ops. atomic_t variable used for error_count are atomic counters. Convert it to use seqnum_ops. Signed-off-by: Shuah Khan --- .../staging/unisys

<    1   2   3   4   5   6   7   8   9   10   >