an Brauner
Signed-off-by: Shuah Khan
---
drivers/android/binder.c | 41 ---
drivers/android/binder_internal.h | 3 ++-
2 files changed, 23 insertions(+), 21 deletions(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index f936530a19b0..52
to tag the log messages and nothing more.
Convert it to use counter_atomic32.
This conversion doesn't change the overflow wrap around behavior.
Acked-by: Rafael J. Wysocki
Acked-by: Borislav Petkov
Reviewed-by: Kees Cook
Signed-off-by: Shuah Khan
---
drivers/acpi/apei/ghes.c | 5 +++--
1
-- We discussed if binder counters can be non-atomic. For now I left
them the same as the RFC patch - using counter_atomic32
-- Unrelated to this patch series:
The patch series review uncovered improvements could be made to
test_async_driver_probe and vmw_vmci/vmci_guest. I will track
t
On 10/7/20 4:30 AM, Hillf Danton wrote:
Mon, 05 Oct 2020 06:59:19
syzbot found the following issue on:
HEAD commit:d3d45f82 Merge tag 'pinctrl-v5.9-2' of git://git.kernel.or..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15781d8f90
kernel config:
On 10/7/20 3:04 AM, Greg KH wrote:
On Tue, Oct 06, 2020 at 02:44:32PM -0600, Shuah Khan wrote:
Introduce Simple atomic counters.
There are a number of atomic_t usages in the kernel where atomic_t api
is used strictly for counting and not for managing object lifetime. In
some cases, atomic_t
On 10/7/20 12:27 PM, Kees Cook wrote:
On Tue, Oct 06, 2020 at 02:44:41PM -0600, Shuah Khan wrote:
counter_atomic* is introduced to be used when a variable is used as
a simple counter and doesn't guard object lifetimes. This clearly
differentiates atomic_t usages that guard object life
On 10/7/20 1:38 PM, Johannes Berg wrote:
On Wed, 2020-10-07 at 13:33 -0600, Shuah Khan wrote:
On 10/7/20 12:15 PM, Kees Cook wrote:
On Tue, Oct 06, 2020 at 02:44:35PM -0600, Shuah Khan wrote:
counter_atomic* is introduced to be used when a variable is used as
a simple counter and doesn&#
On 10/7/20 12:15 PM, Kees Cook wrote:
On Tue, Oct 06, 2020 at 02:44:35PM -0600, Shuah Khan wrote:
counter_atomic* is introduced to be used when a variable is used as
a simple counter and doesn't guard object lifetimes. This clearly
differentiates atomic_t usages that guard object life
On 10/7/20 12:11 PM, Kees Cook wrote:
On Tue, Oct 06, 2020 at 02:44:32PM -0600, Shuah Khan wrote:
Introduce Simple atomic counters.
There are a number of atomic_t usages in the kernel where atomic_t api
is used strictly for counting and not for managing object lifetime. In
some cases, atomic_t
On 10/7/20 8:28 AM, Andrey Konovalov wrote:
On Wed, Oct 7, 2020 at 3:56 PM Shuah Khan wrote:
On 10/5/20 2:44 PM, Shuah Khan wrote:
On 10/5/20 8:04 AM, Andrey Konovalov wrote:
On Mon, Oct 5, 2020 at 3:59 PM syzbot
wrote:
Hello,
syzbot found the following issue on:
HEAD commit
On 10/5/20 2:44 PM, Shuah Khan wrote:
On 10/5/20 8:04 AM, Andrey Konovalov wrote:
On Mon, Oct 5, 2020 at 3:59 PM syzbot
wrote:
Hello,
syzbot found the following issue on:
HEAD commit: d3d45f82 Merge tag 'pinctrl-v5.9-2' of
git://git.kernel.or..
git tree: upstream
cons
ed to xmit the urb and can give it back.
This path runs in task context.
Disable irqs around usb_hcd_giveback_urb() call.
Reported-by: Andrey Konovalov
Suggested-by: Alan Stern
Signed-off-by: Shuah Khan
---
Changes in v2: Changelog updated with correct information.
drivers/usb/usbip/vhci
On 10/6/20 4:16 PM, Andrey Konovalov wrote:
On Tue, Oct 6, 2020 at 11:51 PM Shuah Khan wrote:
Fix the following warning from kcov regarding usb_hcd_giveback_urb()
call being made without disabling interrupts.
Hi Shuah,
This won't fix the kcov warning, as it still requires its ow
el/kthread.c:292
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
Dumping ftrace buffer:
(ftrace buffer empty)
Kernel Offset: disabled
Rebooting in 1 seconds..
Reported-by: Andrey Konovalov
Suggested-by: Alan Stern
Signed-off-by: Shuah Khan
---
drivers/usb/usbip/vhci_hcd.c | 8 +++-
1
ag the log messages and nothing more.
Convert it to use counter_atomic32.
This conversion doesn't change the overflow wrap around behavior.
Acked-by: Rafael J. Wysocki
Signed-off-by: Shuah Khan
---
drivers/acpi/acpi_extlog.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-
se.
Convert it to use counter_atomic32.
This conversion doesn't change the overflow wrap around behavior.
Reviewed-by: Greg Kroah-Hartman
Signed-off-by: Shuah Khan
---
drivers/misc/vmw_vmci/vmci_guest.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/d
ow to hold them to upper bounds. Overflow and
wrap around doesn't impact errors, and warns.
Convert them to use counter_atomic32.
This conversion doesn't change the overflow wrap around behavior.
Reviewed-by: Greg Kroah-Hartman
Signed-off-by: Shuah Khan
---
drivers/base/test/test_async
ag the log messages and nothing more.
Convert it to use counter_atomic32.
This conversion doesn't change the overflow wrap around behavior.
Acked-by: Rafael J. Wysocki
Acked-by: Borislav Petkov
Signed-off-by: Shuah Khan
---
drivers/acpi/apei/ghes.c | 5 +++--
1 file changed, 3 i
o
the conversion.
Acked-by: Borislav Petkov
Signed-off-by: Shuah Khan
---
drivers/edac/edac_pci.h | 5 +++--
drivers/edac/edac_pci_sysfs.c | 28 ++--
2 files changed, 17 insertions(+), 16 deletions(-)
diff --git a/drivers/edac/edac_pci.h b/drivers/edac/edac_pci.h
keep track of the current log entry
location. Overflow is handled in the code. Since it is used as a
counter, convert it to use counter_atomic32.
This conversion doesn't change the overflow wrap around behavior.
Reviewed-by: Joel Fernandes (Google)
Signed-off-by: Shuah Khan
---
drivers/androi
chance
of this counter overflowing. Convert it to use counter_atomic32.
This conversion doesn't change the overflow wrap around behavior.
Reviewed-by: Greg Kroah-Hartman
Signed-off-by: Shuah Khan
---
drivers/base/devcoredump.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff
lowing.
This counter controls the wait for known devices to complete their
probing, and probe_count == 0 ends the wait. Other than that it
meets the other criteria to be converted. Convert it to use
counter_atomic32.
Reviewed-by: Greg Kroah-Hartman
Signed-off-by: Shuah Khan
---
dr
igned-off-by: Shuah Khan
---
drivers/char/ipmi/ipmi_msghandler.c | 9 +
drivers/char/ipmi/ipmi_si_intf.c| 9 +
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c
b/drivers/char/ipmi/ipmi_msghandler.c
index 737c0b6b24ea..36c0b1b
guard resource
lifetimes, device usage and open counts that control state changes, and
pm states.
Using counter_atomic* to guard lifetimes could lead to use-after free
when it overflows and undefined behavior when used to manage state
changes and device usage/open states.
Signed-off-by: Shuah
times could lead to use-after free
when it overflows and undefined behavior when used to manage state
changes and device usage/open states.
Reviewed-by: Greg Kroah-Hartman
Signed-off-by: Shuah Khan
---
Documentation/core-api/counters.rst | 103 +
MAINTAINERS
patch series review uncovered improvements could be made to
test_async_driver_probe and vmw_vmci/vmci_guest. I will track
these for fixing later.
Shuah Khan (11):
counters: Introduce counter_atomic* counters
selftests:lib:test_counters: add new test for counters
drivers/base: convert deferred_tr
On 10/6/20 5:07 AM, Stephen Rothwell wrote:
Hi all,
Today's linux-next merge of the akpm tree got a conflict in:
tools/testing/selftests/vm/gup_test.c
between commit:
aa803771a80a ("tools: Avoid comma separated statements")
from the kselftest-fixes tree and commit:
5c64830675a6 ("m
On 9/28/20 5:13 PM, Kees Cook wrote:
On Mon, Sep 28, 2020 at 04:41:47PM -0600, Shuah Khan wrote:
On 9/26/20 10:29 AM, Kees Cook wrote:
On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote:
7. Verified that the test module compiles in kunit env. and test
module can be loaded
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.8.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
On 10/5/20 9:25 AM, Alan Stern wrote:
On Mon, Oct 05, 2020 at 05:21:30PM +0200, Andrey Konovalov wrote:
On Mon, Oct 5, 2020 at 5:18 PM Greg Kroah-Hartman
wrote:
On Mon, Oct 05, 2020 at 05:08:11PM +0200, Andrey Konovalov wrote:
Dear USB and USB/IP maintainers,
While fuzzing the USB/IP stack
On 10/5/20 8:04 AM, Andrey Konovalov wrote:
On Mon, Oct 5, 2020 at 3:59 PM syzbot
wrote:
Hello,
syzbot found the following issue on:
HEAD commit:d3d45f82 Merge tag 'pinctrl-v5.9-2' of git://git.kernel.or..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x
On 10/2/20 5:44 PM, Jens Axboe wrote:
On 10/2/20 4:34 PM, Shuah Khan wrote:
All,
I came across these atomic_inc_return_safe() & atomic_dec_return_safe()
functions that hold the counters at safe values.
atomic_inc_return_safe()
If the counter is already 0 it will not be incremented.
If
All,
I came across these atomic_inc_return_safe() & atomic_dec_return_safe()
functions that hold the counters at safe values.
atomic_inc_return_safe()
If the counter is already 0 it will not be incremented.
If the counter is already at its maximum value returns
-EINVAL without updating it.
ato
Hi Sudip,
While looking at atomic_t usages and noticed a few potential
problem the way struct pp_struct: atomic_t irqc field
- There is inconsistencies the lock hold in this driver.
pp_do_mutex is help before pp_do_ioctl() is called.
static int pp_do_ioctl()
pp_do_mutex
case PPCLRI
On 9/29/20 7:11 AM, Brahadambal Srinivasan wrote:
When a user tries to modify cpuidle or cpufreq properties on offline
CPUs, the tool returns success (exit status 0) but also does not provide
any warning message regarding offline cpus that may have been specified
but left unchanged. In case of al
On 9/29/20 7:42 AM, Shuah Khan wrote:
On 9/29/20 7:34 AM, Joe Perches wrote:
On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote:
On Tue, 29 Sep 2020, Dan Carpenter wrote:
The times where commas are used deliberately to replace curly braces
are
just evil. Either way the code is cleaner
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.9.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.14.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.8.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
On 9/29/20 2:11 PM, John Hubbard wrote:
On 9/29/20 1:00 PM, Shuah Khan wrote:
On 9/29/20 1:53 PM, Jason Gunthorpe wrote:
I only remarked because I didn't know it wasn't using kbuild. I
thought it would have used the existing HOSTCC stuff, not sure why it
is special.
The only inves
On 9/29/20 1:53 PM, Jason Gunthorpe wrote:
On Tue, Sep 29, 2020 at 12:48:43PM -0700, John Hubbard wrote:
On 9/29/20 12:08 PM, Jason Gunthorpe wrote:
On Tue, Sep 29, 2020 at 11:59:55AM -0700, John Hubbard wrote:
On 9/29/20 10:55 AM, Jason Gunthorpe wrote:
On Tue, Sep 29, 2020 at 10:44:31AM -07
On 9/29/20 7:34 AM, Joe Perches wrote:
On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote:
On Tue, 29 Sep 2020, Dan Carpenter wrote:
The times where commas are used deliberately to replace curly braces are
just evil. Either way the code is cleaner with semi-colons.
I also found exaamples
On 9/26/20 10:33 AM, Kees Cook wrote:
On Fri, Sep 25, 2020 at 06:13:37PM -0600, Shuah Khan wrote:
On 9/25/20 5:52 PM, Kees Cook wrote:
On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote:
-- Addressed Kees's comments:
1. Non-atomic counters renamed to counter_simple3
On 9/28/20 3:17 PM, Joel Fernandes wrote:
On Mon, Sep 28, 2020 at 01:34:31PM -0700, Kees Cook wrote:
On Sun, Sep 27, 2020 at 07:35:26PM -0400, Joel Fernandes wrote:
On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote:
This patch series is a result of discussion at the refcount_t BOF
On 9/26/20 10:29 AM, Kees Cook wrote:
On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote:
7. Verified that the test module compiles in kunit env. and test
module can be loaded to run the test.
I meant write it using KUnit interfaces (e.g. KUNIT_EXPECT*(),
kunit_test_suite
On 9/26/20 10:22 AM, Kees Cook wrote:
On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote:
This patch series is a result of discussion at the refcount_t BOF
the Linux Plumbers Conference. In this discussion, we identified
a need for looking closely and investigating atomic_t usages in
On 9/25/20 6:15 PM, Corey Minyard wrote:
On Fri, Sep 25, 2020 at 05:47:23PM -0600, Shuah Khan wrote:
counter_atomic* is introduced to be used when a variable is used as
a simple counter and doesn't guard object lifetimes. This clearly
differentiates atomic_t usages that guard object life
On 9/25/20 5:52 PM, Kees Cook wrote:
On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote:
-- Addressed Kees's comments:
1. Non-atomic counters renamed to counter_simple32 and counter_simple64
to clearly indicate size.
2. Added warning for counter_simple* usage a
ag the log messages and nothing more.
Convert it to use counter_atomic32.
This conversion doesn't change the overflow wrap around behavior.
Acked-by: Rafael J. Wysocki
Signed-off-by: Shuah Khan
---
drivers/acpi/apei/ghes.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff
o
the conversion.
Signed-off-by: Shuah Khan
---
drivers/edac/edac_pci.h | 5 +++--
drivers/edac/edac_pci_sysfs.c | 28 ++--
2 files changed, 17 insertions(+), 16 deletions(-)
diff --git a/drivers/edac/edac_pci.h b/drivers/edac/edac_pci.h
index 5175f5724cfa..797b25a6afc0 1
guard resource lifetimes, device usage and
open counts that control state changes, and pm states.
atomic_t variables used for stats are atomic counters. Overflow will
wrap around and reset the stats and no change with the conversion.
Convert them to use counter_atomic32.
Signed-off-by: Shuah
se.
Convert it to use counter_atomic32.
This conversion doesn't change the overflow wrap around behavior.
Reviewed-by: Greg Kroah-Hartman
Signed-off-by: Shuah Khan
---
drivers/misc/vmw_vmci/vmci_guest.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/d
keep track of the current log entry
location. Overflow is handled in the code. Since it is used as a
counter, convert it to use counter_atomic32.
This conversion doesn't change the overflow wrap around behavior.
Signed-off-by: Shuah Khan
---
drivers/android/binder.c
ag the log messages and nothing more.
Convert it to use counter_atomic32.
This conversion doesn't change the overflow wrap around behavior.
Acked-by: Rafael J. Wysocki
Signed-off-by: Shuah Khan
---
drivers/acpi/acpi_extlog.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-
ow to hold them to upper bounds. Overflow and
wrap around doesn't impact errors, and warns.
Convert them to use counter_atomic32.
This conversion doesn't change the overflow wrap around behavior.
Reviewed-by: Greg Kroah-Hartman
Signed-off-by: Shuah Khan
---
drivers/base/test/test_async
chance
of this counter overflowing. Convert it to use counter_atomic32.
This conversion doesn't change the overflow wrap around behavior.
Reviewed-by: Greg Kroah-Hartman
Signed-off-by: Shuah Khan
---
drivers/base/devcoredump.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff
lowing.
This counter controls the wait for known devices to complete their
probing, and probe_count == 0 ends the wait. Other than that it
meets the other criteria to be converted. Convert it to use
counter_atomic32.
Reviewed-by: Greg Kroah-Hartman
Signed-off-by: Shuah Khan
---
dr
free
when it overflows and undefined behavior when used to manage state
changes and device usage/open states.
Signed-off-by: Shuah Khan
---
MAINTAINERS | 1 +
tools/testing/selftests/lib/Makefile | 1 +
tools/testing/selftests/lib/config |
driver_probe and vmw_vmci/vmci_guest. I will track
these for fixing later.
Shuah Khan (11):
counters: Introduce counter_simple* and counter_atomic* counters
selftests:lib:test_counters: add new test for counters
drivers/base: convert deferred_trigger_count and probe_count to
counter_atomic32
an
Signed-off-by: Shuah Khan
---
Documentation/core-api/counters.rst | 174 ++
MAINTAINERS | 7 +
include/linux/counters.h| 350
lib/Kconfig | 10 +
lib/Makefile|
On 9/25/20 3:16 PM, Kees Cook wrote:
On Fri, Sep 25, 2020 at 01:51:53PM +0530, Naresh Kamboju wrote:
On Mon, 14 Sep 2020 at 07:53, Hangbin Liu wrote:
Currently, after generating run_kselftest.sh, there is no way to choose
which test we could run. All the tests are listed together and we have
On 9/25/20 3:16 PM, Kees Cook wrote:
On Fri, Sep 25, 2020 at 01:51:53PM +0530, Naresh Kamboju wrote:
On Mon, 14 Sep 2020 at 07:53, Hangbin Liu wrote:
Currently, after generating run_kselftest.sh, there is no way to choose
which test we could run. All the tests are listed together and we have
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.8.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
Hi Pavel,
On 9/25/20 4:47 AM, Pavel Machek wrote:
Hi!
In linux-next, I published TODO list for LED subsystem. Is that
something linux-kernel-mentees could help with?
Best regards,
Pavel
Thanks for putting this list together. Will you b
On 9/24/20 5:13 AM, Rafael J. Wysocki wrote:
On Wed, Sep 23, 2020 at 3:44 AM Shuah Khan wrote:
counter_atomic is introduced to be used when a variable is used as
a simple counter and doesn't guard object lifetimes. This clearly
differentiates atomic_t usages that guard object life
On 9/23/20 3:19 PM, Brendan Higgins wrote:
Alltests flag evidently stopped working when run from outside of the
root of the source tree, so fix that. Also add an additional broken
config to the broken_on_uml config.
Signed-off-by: Brendan Higgins
---
tools/testing/kunit/configs/broken_on_uml.
On 9/23/20 2:58 PM, Kees Cook wrote:
On Wed, Sep 23, 2020 at 02:48:22PM -0600, Shuah Khan wrote:
On 9/23/20 1:04 PM, Kees Cook wrote:
On Tue, Sep 22, 2020 at 07:43:30PM -0600, Shuah Khan wrote:
I would really like these APIs to be _impossible_ to use for object
lifetime management. To that end
On 9/23/20 1:04 PM, Kees Cook wrote:
On Tue, Sep 22, 2020 at 07:43:30PM -0600, Shuah Khan wrote:
Introduce Simple atomic and non-atomic counters.
There are a number of atomic_t usages in the kernel where atomic_t api
is used strictly for counting and not for managing object lifetime. In
some
On 9/23/20 2:41 AM, Oded Gabbay wrote:
On Tue, Sep 22, 2020 at 1:08 AM Shuah Khan wrote:
All,
While I was looking at the atomic_t api usages for an unrelated issue,
I noticed free_slots_cnt in struct hl_cq incerment/decrement/reads are
not consistent.
atomic_inc() and atomic_set() are used
guard resource lifetimes, device usage and
open counts that control state changes, and pm states.
atomic_t variables used for pci counters keep track of pci parity and
non-parity errors. Overflow will wrap around and reset the counts as
was the case prior to the conversion.
Signed-off-by: Shuah
guard resource lifetimes, device usage and
open counts that control state changes, and pm states.
atomic_t variables used for stats are atomic counters. Overflow will
wrap around and reset the stats and no change with the conversion.
Convert them to use counter_atomic.
Signed-off-by: Shuah Khan
---
dr
ce
of this counter overflowing. Convert it to use counter_atomic.
This conversion doesn't change the oveflow wrap around behavior.
Signed-off-by: Shuah Khan
---
drivers/base/devcoredump.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/base/devcoredump.c
ee
when it overflows and undefined behavior when used to manage state
changes and device usage/open states.
Signed-off-by: Shuah Khan
---
MAINTAINERS | 1 +
tools/testing/selftests/lib/Makefile | 1 +
tools/testing/selftests/lib/config | 1 +
too
track of the current log entry
location. Overflow is handled in the code. Since it is used as a
counter, convert it to use counter_atomic.
This conversion doesn't change the oveflow wrap around behavior.
Signed-off-by: Shuah Khan
---
drivers/android/binder.c
ag the log messages and nothing more.
Convert it to use counter_atomic.
This conversion doesn't change the oveflow wrap around behavior.
Signed-off-by: Shuah Khan
---
drivers/acpi/acpi_extlog.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/acpi_ext
se.
Convert it to use counter_atomic.
This conversion doesn't change the oveflow wrap around behavior.
Signed-off-by: Shuah Khan
---
drivers/misc/vmw_vmci/vmci_guest.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/vmw_vmci/vmci_guest.c
b/d
d resource lifetimes, device usage and open counts
that control state changes, and pm states.
Using counter_atomic to guard lifetimes could lead to use-after free
when it overflows and undefined behavior when used to manage state
changes and device usage/open states.
Signed-off-by:
lowing.
This counter controls the wait for known devices to complete their
probing, and probe_count == 0 ends the wait. Other than that it
meets the other criteria to be converted. Convert it to use
counter_atomic.
Signed-off-by: Shuah Khan
---
drivers/base/dd.c | 19 ++-
1 file ch
ag the log messages and nothing more.
Convert it to use counter_atomic.
This conversion doesn't change the oveflow wrap around behavior.
Signed-off-by: Shuah Khan
---
drivers/acpi/apei/ghes.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/apei/ghes.c
hold them to upper bounds. Overflow and
wrap around doesn't impact errors, and warns.
Convert them to use counter_atomic.
This conversion doesn't change the oveflow wrap around behavior.
Signed-off-by: Shuah Khan
---
drivers/base/test/test_async_driver_probe.c | 23 --
device usage counts, device open counts, and pm states.
2. Variable is used for stats and counters.
3. The conversion doesn't change the overflow behavior.
Please review and let me know if non-stat conversions e.g: probe_count,
deferred_trigger_count make sense.
Shuah Khan (11):
counters: I
All,
While I was looking at the atomic_t api usages for an unrelated issue,
I noticed free_slots_cnt in struct hl_cq incerment/decrement/reads are
not consistent.
atomic_inc() and atomic_set() are used, however instead of atomic_read()
the value is referenced directly in
drivers/misc/habanalabs/
On 9/17/20 9:37 PM, Michael Ellerman wrote:
Shuah Khan writes:
On 9/16/20 10:53 PM, Max Filippov wrote:
On Wed, Sep 16, 2020 at 9:16 PM Michael Ellerman wrote:
The test harness forks() a child to run each test. Both the parent and
the child print to stdout using libc functions. That can
While looking at this file for an unrelated issue, I happen to notice
there is a double locking on mhi_cntrl->pm_lock in the mhi_device_put()
when it gets called from mhi_driver_remove()
The other two calls from mhi_driver_probe() don't hold the pm_lock.
In addition, lock holding while dev_wake
On 9/17/20 6:58 AM, Shuah Khan wrote:
On 9/16/20 10:53 PM, Max Filippov wrote:
On Wed, Sep 16, 2020 at 9:16 PM Michael Ellerman
wrote:
The test harness forks() a child to run each test. Both the parent and
the child print to stdout using libc functions. That can lead to
duplicated (or more
On 9/17/20 8:46 AM, Greg Kroah-Hartman wrote:
On Thu, Sep 17, 2020 at 08:34:58AM -0600, Shuah Khan wrote:
On 9/16/20 11:25 AM, Greg Kroah-Hartman wrote:
On Wed, Sep 16, 2020 at 09:34:52AM -0600, Shuah Khan wrote:
On 9/16/20 9:26 AM, Greg Kroah-Hartman wrote:
On Wed, Sep 16, 2020 at 08:26
On 9/16/20 11:25 AM, Greg Kroah-Hartman wrote:
On Wed, Sep 16, 2020 at 09:34:52AM -0600, Shuah Khan wrote:
On 9/16/20 9:26 AM, Greg Kroah-Hartman wrote:
On Wed, Sep 16, 2020 at 08:26:48AM -0600, Shuah Khan wrote:
On 9/16/20 12:29 AM, Greg Kroah-Hartman wrote:
On Tue, Sep 15, 2020 at 08:54
On 9/16/20 10:53 PM, Max Filippov wrote:
On Wed, Sep 16, 2020 at 9:16 PM Michael Ellerman wrote:
The test harness forks() a child to run each test. Both the parent and
the child print to stdout using libc functions. That can lead to
duplicated (or more) output if the libc buffers are not flush
On 9/16/20 9:26 AM, Greg Kroah-Hartman wrote:
On Wed, Sep 16, 2020 at 08:26:48AM -0600, Shuah Khan wrote:
On 9/16/20 12:29 AM, Greg Kroah-Hartman wrote:
On Tue, Sep 15, 2020 at 08:54:24PM -0600, Shuah Khan wrote:
On 9/15/20 3:06 PM, Shuah Khan wrote:
On 9/15/20 8:11 AM, Greg Kroah-Hartman
On 9/16/20 12:29 AM, Greg Kroah-Hartman wrote:
On Tue, Sep 15, 2020 at 08:54:24PM -0600, Shuah Khan wrote:
On 9/15/20 3:06 PM, Shuah Khan wrote:
On 9/15/20 8:11 AM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 5.8.10 release.
There are 177 patches in this
On 9/15/20 3:06 PM, Shuah Khan wrote:
On 9/15/20 8:11 AM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 5.8.10 release.
There are 177 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
501 - 600 of 2693 matches
Mail list logo
