In some occasions the remoteproc device might need to
prepare some hardware before the coredump can be performed
and cleanup the state afterwards.
Q6V5 modem requires the mba to be loaded before the
coredump and some cleanup of the resources afterwards.
Signed-off-by: Sibi Sankar <
Synchronize proxy unvote of clks/regs from q6v5_stop and
handover interrupt to prevent multiple proxy unvotes
for a single rproc start.
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
drivers/remoteproc/qcom_q6v5_pil.c | 73 ++
1 file changed, 54 inse
Introduce interrupt handler for smp2p ready interrupt to
handle start completion. Move the proxy votes for clocks
and regulators to the handover interrupt context.
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
drivers/remoteproc/qcom_q6v5_pil.c | 29 +++--
Corrected few typos and replaced misconfigured author name
V2:
Addressed reset-qcom-aoss review suggestions and reworked
re-ordering of the active clk and reset sequence in
qcom_q6v5_pil
Sibi Sankar (8):
dt-bindings: reset: Add AOSS reset bindings for SDM845 SoCs
reset: qcom: AOSS (always
Add SDM845 AOSS (always on subsystem) reset controller binding
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
.../bindings/reset/qcom,aoss-reset.txt| 52 +++
include/dt-bindings/reset/qcom,sdm845-aoss.h | 17 ++
2 files changed, 69 insertions(+)
creat
Adding reset assert/deassert helper functions to handle SoC
specific reset sequences. This wil be used by SDM845 to assert and
deassert ALT_RESET and MSS_RESET signals.
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
drivers/remoteproc/qcom_q6v5_pil.c | 16 +---
1 file c
Add GLINK subdevice to allow definition of GLINK edge as a
child of modem-pil.
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
drivers/remoteproc/qcom_q6v5_pil.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers/remoteproc/qcom_q6v5
Add reset controller driver for Qualcomm SDM845 SoC to
control reset signals provided by AOSS for Modem, Venus
ADSP, GPU, Camera, Wireless, Display subsystem
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
drivers/reset/Kconfig | 9 +++
drivers/reset/Makefile
ert/deassert. Use the SoC specific reset helper function to
add support for ALT_RESET in SDM845.
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
drivers/remoteproc/qcom_q6v5_pil.c | 109 -
1 file changed, 107 insertions(+), 2 deletions(-)
diff --git a/drivers/r
Add new compatible string for Qualcomm SDM845 SoCs
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
b/Documen
In some occasions the remoteproc device might need to
prepare some hardware before the coredump can be performed
and cleanup the state afterwards.
Q6V5 modem requires the mba to be loaded before the
coredump and some cleanup of the resources afterwards.
Signed-off-by: Sibi Sankar <
Add new compatible string for Qualcomm SDM845 SoCs
Reviewed-by: Rob Herring
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
b/Documentation
Add reset controller driver for Qualcomm SDM845 SoC to
control reset signals provided by AOSS for Modem, Venus
ADSP, GPU, Camera, Wireless, Display subsystem
Reviewed-by: Bjorn Andersson
Signed-off-by: Sibi Sankar
---
drivers/reset/Kconfig | 9 +++
drivers/reset/Makefile
Add SDM845 AOSS (always on subsystem) reset controller binding
Signed-off-by: Sibi Sankar
---
Not including Rob's earlier Reviewed-by due to change in compatible
.../bindings/reset/qcom,aoss-reset.txt| 52 +++
include/dt-bindings/reset/qcom,sdm845-aoss.h | 17
Add all the necessary dt nodes to support SMEM driver
on SDM845. It also adds the required memory carveouts
so that the kernel does not access memory that is in
use.
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
This patch depends on:
https://patchwork.kernel.org/patch/10276419/
Refactor re-useable parts of mba load/unload sequence into mba_load and
mba_reclaim respectively and introduce mba_load flag. This is done in
order to prevent code duplication for modem coredump which requires the
mba to be loaded.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc
Introduce custom dump function per remoteproc segment. It is responsible
for filling the device memory segment associated with coredump
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/remoteproc_core.c | 15 ++-
include/linux/remoteproc.h | 3 +++
2 files changed, 13
segment
dump function
V2:
Introduce prepare/unprepare ops for rproc coredump
Sibi Sankar (6):
remoteproc: Introduce custom dump function for each remoteproc segment
remoteproc: Add mechanism for custom dump function assignment
remoteproc: qcom: q6v5-pil: Refactor mba load/unload sequence
The per segment dump function is responsible for loading the mba
before device memory segments associated with coredump can be populated
and for cleaning up the resources post coredump.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 25 +
1 file
Register the MDT segments and custom dumpfn with the remoteproc core
dump functionality.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 40 ++
1 file changed, 40 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers/remoteproc
This patch adds a mechanism for assigning each rproc segment with
a custom dump function. It is to be called for each rproc segment
during coredump if assigned.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/remoteproc_core.c | 37
include/linux/remoteproc.h
Add reset controller for SDM845 SoC to control reset signals
provided by PDC for Modem, Compute, Display, GPU, Debug, AOP,
Sensors, Audio, SP and APPS
Signed-off-by: Sibi Sankar
---
drivers/reset/Kconfig | 9 +++
drivers/reset/Makefile | 1 +
drivers/reset/reset-qcom-pdc.c
Add SDM845 PDC (Power Domain Controller) reset controller binding
Signed-off-by: Sibi Sankar
---
.../bindings/reset/qcom,pdc-reset.txt | 52 +++
include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++
2 files changed, 72 insertions(+)
create mode 100644
In the presence of a PDC block working with subsystem RSC,
assert/deassert PDC restart in modem start/stop path.
Signed-off-by: Sibi Sankar
---
.../bindings/remoteproc/qcom,q6v5.txt | 4 +++
drivers/remoteproc/qcom_q6v5_pil.c| 27 ---
2 files changed, 27
Explicitly get mss_restart to facilitate adding PDC
restart line for modem on SDM845 SoCs
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers/remoteproc
Assign the relocated base of the modem image, as the offsets
from the virtual memory might not be based on the physical
address.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers
Hi Vinod,
Thanks for the review,
On 08/07/2018 11:45 AM, Vinod wrote:
Hi Sibi,
On 27-07-18, 20:49, Sibi Sankar wrote:
Introduce custom dump function per remoteproc segment. It is responsible
for filling the device memory segment associated with coredump
Signed-off-by: Sibi Sankar
On 08/07/2018 11:48 PM, Rob Herring wrote:
On Fri, Jul 27, 2018 at 08:58:11PM +0530, Sibi Sankar wrote:
In the presence of a PDC block working with subsystem RSC,
assert/deassert PDC restart in modem start/stop path.
Signed-off-by: Sibi Sankar
---
.../bindings/remoteproc/qcom,q6v5.txt
Hi Rob,
Thanks for the review
On 08/07/2018 11:46 PM, Rob Herring wrote:
On Tue, Jul 31, 2018 at 06:27:24PM +0530, Sibi S wrote:
Hi Philipp,
Thanks for the review!
On 07/31/2018 02:12 PM, Philipp Zabel wrote:
Hi Sibi,
On Fri, 2018-07-27 at 20:58 +0530, Sibi Sankar wrote:
Add SDM845 PDC
Add additional pdc_reset binding required for Q6V5 Modem PIL on
SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
b
In the presence of a PDC block working with subsystem RSC, assert/deassert
PDC reset in modem start/stop path.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/drivers/remoteproc
with devm_reset_control_get_exclusive()
Separted dt binding from the drivers
The last 4 remoteproc patches can be picked up after the pdc global
reset driver lands on linux-next.
Sibi Sankar (6):
dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
reset: qcom: PDC Global (Power Domain Controller) reset
Add reset controller for SDM845 SoCs to control reset signals provided
by PDC Global for Modem, Compute, Display, GPU, Debug, AOP, Sensors,
Audio, SP and APPS
Signed-off-by: Sibi Sankar
---
drivers/reset/Kconfig | 9 +++
drivers/reset/Makefile | 1 +
drivers/reset/reset
Explicitly get mss_restart to facilitate adding PDC reset line
for modem on SDM845 SoCs
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers/remoteproc/qcom_q6v5_pil.c
Remove the additional definition tag declared for WCSS sub-system
under reset-names.
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom
Add PDC Global(Power Domain Controller) binding for SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
.../bindings/reset/qcom,pdc-global.txt| 52 +++
include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++
2 files changed, 72 insertions(+)
create mode 100644 Documentation
Reviewed-by: Sibi Sankar
On 2018-08-28 12:42, Bjorn Andersson wrote:
Add the SMP2P nodes for the remoteproc states for adsp, cdsp, mpss and
slpi.
Signed-off-by: Bjorn Andersson
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 88
1 file changed, 88 insertions(+)
diff
Tested-by: Sibi Sankar
On 2018-08-28 12:44, Bjorn Andersson wrote:
Add support for booting the Audio and Compute DSPs found in Qualcomm's
SDM845 platform.
As with the previous platforms the power rail handling needs to be
updated once the appropriate support lands upstream.
Signed-off
Hi Bjorn/Matthias,
Thanks for the review, will fix them in the next-respin.
On 2018-08-28 08:32, Bjorn Andersson wrote:
On Mon 27 Aug 17:22 PDT 2018, Matthias Kaehlcke wrote:
On Fri, Aug 24, 2018 at 06:48:56PM +0530, Sibi Sankar wrote:
> diff --git a/drivers/reset/reset-qcom-pdc.c b/driv
:57PM +0530, Sibi Sankar wrote:
Remove the additional definition tag declared for WCSS sub-system
under reset-names.
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Documentation
tly in later patches (needs more discussion) and that'll add
more complexity.
I think for these reasons we shouldn't combine these two governors.
Let me know what you think.
Friendly reminder.
Thanks,
Saravana
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code A
interface so that the devfreq governors can be shared across SoCs
+ and architectures.
+
source "drivers/devfreq/event/Kconfig"
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
Add additional pdc_reset binding required for Q6V5 Modem PIL on
SDM845 SoCs.
Reviewed-by: Rob Herring
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/remoteproc
Add reset controller for SDM845 SoCs to control reset signals provided
by PDC Global for Modem, Compute, Display, GPU, Debug, AOP, Sensors,
Audio, SP and APPS
Signed-off-by: Sibi Sankar
---
drivers/reset/Kconfig | 9 +++
drivers/reset/Makefile | 1 +
drivers/reset/reset
Remove the additional definition tag declared for WCSS sub-system
under reset-names.
Reviewed-by: Matthias Kaehlcke
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation
Add PDC Global (Power Domain Controller) binding for SDM845 SoCs.
Reviewed-by: Bjorn Andersson
Reviewed-by: Rob Herring
Signed-off-by: Sibi Sankar
---
.../bindings/reset/qcom,pdc-global.txt| 52 +++
include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++
2 files
Philipp/Bjorn/Rob suggestions
Renamed reset binding to pdc-global.txt
replaced offset with #define of register name
replaced with devm_reset_control_get_exclusive()
Separted dt binding from the drivers
Sibi Sankar (6):
dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
reset: qcom
Explicitly get mss_restart to facilitate adding PDC reset line
for modem on SDM845 SoCs
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers/remoteproc/qcom_q6v5_pil.c
In the presence of a PDC block working with subsystem RSC, assert/deassert
PDC reset in modem start/stop path.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/drivers/remoteproc
unvoting axis2 clk caused modem hang]
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers/remoteproc/qcom_q6v5_pil.c
index e04319573c91..d7a4b9eca5d2 100644
--- a/drivers/remoteproc
This patch add the node to support APSS shared
mailbox on SDM845
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
This patch depends on https://patchwork.kernel.org/patch/10276419/
arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch
Add the corresponding APSS shared offset for SDM845 SoC
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
drivers/mailbox/qcom-apcs-ipc-mailbox.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
Include SDM845 APSS shared to the list of possible bindings
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
.../devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt| 1 +
1 file changed, 1 insertion(+)
diff --git
a/Documentation/devicetree/bindings/mailbox/qcom,apc
Add all the necessary dt nodes to support SMEM driver
on SDM845. It also adds the required memory carveouts
so that the kernel does not access memory that is in
use.
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
This patch depends on:
https://patchwork.kernel.org/patch/10276419/
Introduce interrupt handler for smp2p ready interrupt and
handle start completion. Remove the proxy votes for clocks
and regulators in the handover interrupt context. Disable
wdog and fatal interrupts on remoteproc device stop and
re-enable them on remoteproc device start.
Signed-off-by: Sibi
>From SDM845, the Q6SS reset sequence on software side has been
simplified with the introduction of boot FSM which assists in
bringing the Q6 out of reset
Add GLINK subdevice to allow definition of GLINK edge as a
child of modem-pil
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
Add reset controller driver for Qualcomm SDM845 SoC to
control reset signals provided by AOSS for Modem, Venus
ADSP, GPU, Camera, Wireless, Display subsystem
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
drivers/reset/Kconfig | 9 +++
drivers/reset/Makefile
into separate patches
Corrected few typos and replaced misconfigured author name
V2:
Addressed reset-qcom-aoss review suggestions and reworked
re-ordering of the active clk and reset sequence in
qcom_q6v5_pil
Depends on:
https://patchwork.kernel.org/patch/10363397/
Sibi Sankar (5):
dt
Add SDM845 AOSS (always on subsystem) reset controller binding
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
.../bindings/reset/qcom,aoss-reset.txt| 52 +++
include/dt-bindings/reset/qcom,sdm845-aoss.h | 17 ++
2 files changed, 69 insertions(+)
creat
functions to handle SoC specific reset sequences
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
drivers/remoteproc/qcom_q6v5_pil.c | 81 --
1 file changed, 76 insertions(+), 5 deletions(-)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers/remo
Add new compatible string for Qualcomm SDM845 SoCs
Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
b/Documen
software bypass to avoid high MX current in mpss error path.
* Remove the proxy votes of clk/regs only after the active/reset clks/regs.
* Reclaim MBA memory after mpss_load failure in mba_reclaim func.
* Set/Unset the dump_mba_loaded flag on mba_load/mba_reclaim respectively.
Signed-off-by: Sibi Sankar
The per segment dump function is responsible for loading the mba
before device memory segments associated with coredump can be populated
and for cleaning up the resources post coredump.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 33 ++
1 file
Introduce custom dump function and private data per remoteproc dump
segment. The dump function is responsible for filling the device memory
segment associated with coredump
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/remoteproc_core.c | 16 ++--
include/linux/remoteproc.h
generalised per segment
dump function
V2:
Introduce prepare/unprepare ops for rproc coredump
Sibi Sankar (5):
remoteproc: Introduce custom dump function for each remoteproc segment
remoteproc: Add mechanism for custom dump function assignment
remoteproc: qcom: q6v5-mss: Refactor mba load
This patch adds a mechanism for assigning each rproc dump segment with
a custom dump function and private data. The dump function is to be
called for each rproc segment during coredump if assigned.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/remoteproc_core.c | 39
Register the MDT segments, custom dumpfn and private data with the
remoteproc core dump functionality.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 42 ++
1 file changed, 42 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5_mss.c
b
Add reserve-memory nodes for mpss and mba required for
remoteproc mss pil.
Signed-off-by: Sibi Sankar
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index
This patch adds the node to support PDC Global reset driver on
SDM845 SoCs
Signed-off-by: Sibi Sankar
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index
Add SCM DT node to enable SCM functionality on SDM845.
Signed-off-by: Sibi Sankar
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index b72bdb0a31a5..fad22acfda4d
Hi Bjorn,
Thanks for the review!
On 2018-10-22 01:46, Bjorn Andersson wrote:
On Sun 30 Sep 08:56 PDT 2018, Sibi Sankar wrote:
From: Bjorn Andersson
rmtfs_mem provides access to physical storage and is crucial for the
operation of the Qualcomm modem subsystem.
The rmtfs_mem implementation
Hi Brian,
Thanks for the review!
On 2018-10-18 06:24, Brian Norris wrote:
Hi Sibi,
On Sun, Sep 30, 2018 at 09:26:46PM +0530, Sibi Sankar wrote:
From: Bjorn Andersson
rmtfs_mem provides access to physical storage and is crucial for the
operation of the Qualcomm modem subsystem
Add reserve-memory nodes for mpss and mba required for
remoteproc mss pil.
Reviewed-by: Bjorn Andersson
Signed-off-by: Sibi Sankar
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
b/arch/arm64/boot
Hi Doug,
Thanks for the review!
I noticed both the quirks just after sending it out :(, will fix them.
On 2018-10-30 00:07, Doug Anderson wrote:
Hi,
On Fri, Oct 26, 2018 at 5:28 AM Sibi Sankar
wrote:
Add reserve-memory nodes for mpss and mba required for
remoteproc mss pil.
Signed-off
Introduce RMTFS qmi lookup client to synchronize bring up/down modem
with the REMOTE FS QMI service.
Signed-off-by: Sibi Sankar
---
The currently implemented workaround in the Linaro QCOMLT releases is to
blacklist the qcom_q6v5_pil kernel module and load this explicitly after rmtfs
has been
Hi Stan,
Thanks for the review!
On 2018-10-29 15:02, Stanimir Varbanov wrote:
Hi Sibi,
On 10/26/2018 03:25 PM, Sibi Sankar wrote:
Add SCM DT node to enable SCM functionality on SDM845.
Signed-off-by: Sibi Sankar
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++
1 file changed, 6
Hey Phillip,
Will the PDC driver make the cut for reset/next this time for the
4.20rc?
On 09/04/2018 01:06 AM, Bjorn Andersson wrote:
On Wed 29 Aug 12:12 PDT 2018, Sibi Sankar wrote:
This patch series add support for PDC Global (Power Domain Controller)
on SDM845 SoCs and adds pdc reset
Hi Bjorn,
Thanks for the review :)
On 2018-10-08 11:53, Bjorn Andersson wrote:
On Fri 27 Jul 08:19 PDT 2018, Sibi Sankar wrote:
Introduce custom dump function per remoteproc segment. It is
responsible
for filling the device memory segment associated with coredump
Signed-off-by: Sibi Sankar
Hi Bjorn,
Thanks for the review !
On 2018-10-08 12:18, Bjorn Andersson wrote:
On Fri 27 Jul 08:20 PDT 2018, Sibi Sankar wrote:
Register the MDT segments and custom dumpfn with the remoteproc core
dump functionality.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 40
This patch adds a mechanism for assigning each rproc dump segment with
a custom dump function and private data. The dump function is to be
called for each rproc segment during coredump if assigned.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/remoteproc_core.c | 39
Register the MDT segments, custom dumpfn and private data with the
remoteproc core dump functionality.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 43 ++
1 file changed, 43 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5_mss.c
b
Introduce custom dump function and private data per remoteproc dump
segment. The dump function is responsible for filling the device memory
segment associated with coredump
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/remoteproc_core.c | 16 ++--
include/linux/remoteproc.h
ops with a more generalised per segment
dump function
V2:
Introduce prepare/unprepare ops for rproc coredump
Sibi Sankar (5):
remoteproc: Introduce custom dump function for each remoteproc segment
remoteproc: Add mechanism for custom dump function assignment
remoteproc: qcom: q6v5-mss
Hi Bjorn,
Thanks for the review !
On 2018-10-08 12:15, Bjorn Andersson wrote:
On Fri 27 Jul 08:20 PDT 2018, Sibi Sankar wrote:
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers/remoteproc/qcom_q6v5_pil.c
[..]
+static void qcom_q6v5_dump_segment(struct rproc *rproc, void *ptr,
size_t
Refactor re-useable parts of mba load/unload sequence into mba_load and
mba_reclaim respectively. This is done in order to prevent code duplication
for modem coredump, which requires the mba to be loaded before dumping
the segments. No change in functionality is intended.
Signed-off-by: Sibi
The per segment dump function is responsible for loading the mba
before device memory segments associated with coredump can be populated
and for cleaning up the resources post coredump.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 25 +
1 file
e exactly, but FWIW I'm running some form of ATF on SDM845
and I'm running with 'needs_memory_protection' (hence, this patch).
AFAIK ATF will eventually support the hyp assign calls even though they
are just stubs as of now.
Regards,
Brian
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is
On 2018-09-28 00:33, Bjorn Andersson wrote:
Add compatibles for the three PAS based remote processors found in
QCS404.
Signed-off-by: Bjorn Andersson
---
Reviewed-by: Sibi Sankar
Changes since v1:
- Fixed incorrect sysmon_name, as pointed out by Sibi.
.../devicetree/bindings/remoteproc
Brian
+ if (!rmtfs_mem->rproc)
+ return -EPROBE_DEFER;
+ }
+
device_initialize(_mem->dev);
rmtfs_mem->dev.parent = >dev;
rmtfs_mem->dev.groups = qcom_rmtfs_mem_groups;
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
and control it based on the availability of
the rmtfs_mem implementation.
Signed-off-by: Bjorn Andersson
[sibis: Added qmi lookup for Remote file system service]
Signed-off-by: Sibi Sankar
---
The currently implemented workaround in the Linaro QCOMLT releases is to
blacklist the qcom_q6v5_pil kernel
, loading mpss
remoteproc remoteproc0: remote processor 408.remoteproc is now up
[bjorn: move running flag to the end of fatal interrupt handler]
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers
rproc_del+0x28/0xa0
adsp_remove+0x20/0x5c [qcom_adsp_pil]
platform_drv_remove+0x28/0x50
device_release_driver_internal+0x124/0x1c8
driver_detach+0x44/0x80
bus_remove_driver+0x78/0x9c
driver_unregister+0x34/0x54
platform_driver_unregister+0x1c/0x28
cleanup_module+0x14/0x6bc [qcom_adsp_pil]
SyS_delete_module+0x1c4/0x214
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
Hi Rohit,
Thanks for the quick turnaround, the patches look fine.
Reviewed-by: Sibi Sankar
Tested-by: Sibi Sankar
On 2018-09-24 16:37, Rohit kumar wrote:
This adds Non PAS ADSP PIL driver for Qualcomm
Technologies Inc SoCs.
Added initial support for SDM845 with ADSP bootup and
shutdown
On 2018-09-24 12:19, Rohit Kumar wrote:
Thanks Sibi for reviewing.
On 9/22/2018 1:11 AM, Sibi Sankar wrote:
Hi Rohit,
On 2018-09-03 17:22, Rohit kumar wrote:
This adds Non PAS ADSP PIL driver for Qualcomm
Technologies Inc SoCs.
Added initial support for SDM845 with ADSP bootup and
shutdown
On 2018-09-24 12:38, Rohit Kumar wrote:
On 9/24/2018 12:19 PM, Rohit Kumar wrote:
Thanks Sibi for reviewing.
On 9/22/2018 1:11 AM, Sibi Sankar wrote:
Hi Rohit,
On 2018-09-03 17:22, Rohit kumar wrote:
This adds Non PAS ADSP PIL driver for Qualcomm
Technologies Inc SoCs.
Added initial
On 2018-09-26 05:05, Bjorn Andersson wrote:
On Tue 25 Sep 03:18 PDT 2018, Sibi Sankar wrote:
On 2018-09-20 22:52, Bjorn Andersson wrote:
> diff --git a/drivers/remoteproc/qcom_adsp_pil.c
> b/drivers/remoteproc/qcom_adsp_pil.c
> index da2254ea1135..fcbb816a9698 100644
> --- a/driver
being
returned, the driver is therefor not reprobed later.
The patch looks fine.
Reviewed-by: Sibi Sankar
Fixes: 3b415c8fb263 ("remoteproc: q6v5: Extract common resource
handling")
Cc: sta...@vger.kernel.org
Signed-off-by: Bjorn Andersson
---
drivers/remoteproc/qcom_q6v5.c | 12 +
_resource_init},
{ .compatible = "qcom,msm8996-slpi-pil", .data =
_resource_init},
+ { .compatible = "qcom,qcs404-adsp-pas", .data = _resource_init
},
+ { .compatible = "qcom,qcs404-cdsp-pas", .data = _resource_init
},
+ { .compatible = "qcom,qcs404-wcss-pas", .data = _
Hi Bjorn,
Thanks for the review!
On 2018-12-06 22:28, Bjorn Andersson wrote:
On Tue 20 Nov 13:08 PST 2018, Sibi Sankar wrote:
Add power-domain bindings for Q6V5 MSS on SDM845 SoCs.
Thanks Sibi,
Signed-off-by: Sibi Sankar
---
Add dt-binding corresponding to
https://patchwork.kernel.org
Add optional shutdown-irq binding required for sysmon shutdown on
SDM845/MSM8996/QCS404 SoCs.
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings
1 - 100 of 623 matches
Mail list logo
