Re: [PATCH v4 06/10] powerpc/smp: Generalize 2nd sched domain

* Michael Ellerman [2020-07-31 17:45:37]: > Srikar Dronamraju writes: > > Currently "CACHE" domain happens to be the 2nd sched domain as per > > powerpc_topology. This domain will collapse if cpumask of l2-cache is > > same as SMT domain. However

Re: [PATCH v4 07/10] Powerpc/numa: Detect support for coregroup

* Michael Ellerman [2020-07-31 17:49:55]: > Srikar Dronamraju writes: > > Add support for grouping cores based on the device-tree classification. > > - The last domain in the associativity domains always refers to the > > core. > > - If primary reference domain ha

Re: [PATCH v4 00/10] Coregroup support on Powerpc

* Srikar Dronamraju [2020-07-27 11:02:20]: > Changelog v3 ->v4: > v3: > https://lore.kernel.org/lkml/20200723085116.4731-1-sri...@linux.vnet.ibm.com/t/#u > Here is a summary of some of the testing done with coregroup v4 patchsets. It includes ebizzy, schbench, perf b

Re: [PATCH v4 09/10] Powerpc/smp: Create coregroup domain

* Valentin Schneider [2020-07-28 16:03:11]: Hi Valentin, Thanks for looking into the patches. > On 27/07/20 06:32, Srikar Dronamraju wrote: > > Add percpu coregroup maps and masks to create coregroup domain. > > If a coregroup doesn't exist, the coregroup domain will

Re: [PATCH v3 09/10] powerpc/smp: Create coregroup domain

The reason I modified it in v4 is not for degeneration or for future case but for the current PowerNV/SMT 4 case. I could have as well detected the the same and modified bigcore but thought fixup at one place would be better. -- Thanks and Regards Srikar Dronamraju

[PATCH 7/7] powerpc/smp: Depend on cpu_l1_cache_map when adding cpus

: Michael Ellerman Cc: Nicholas Piggin Cc: Anton Blanchard Cc: Oliver O'Halloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 7

[PATCH 5/7] powerpc/smp: Limit cpus traversed to within a node.

: Michael Ellerman Cc: Nicholas Piggin Cc: Anton Blanchard Cc: Oliver O'Halloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 2

[PATCH 4/7] powerpc/smp: Optimize remove_cpu_from_masks

Shenoy Cc: Satheesh Rajendran Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index

[PATCH 6/7] powerpc/smp: Stop passing mask to update_mask_by_l2

: Michael Neuling Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel/smp.c b/arch

[PATCH 1/7] powerpc/topology: Update topology_core_cpumask

Piggin Cc: Anton Blanchard Cc: Oliver O'Halloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Signed-off-by: Srikar Dronamraju --- arch/powerpc/include/asm/topology.h | 2 +- 1 file changed, 1

[PATCH 0/7] Optimization to improve cpu online/offline on Powerpc

: Anton Blanchard Cc: Oliver O'Halloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Srikar Dronamraju (7): powerpc/topology: Update topology_core_cpumask powerpc/smp: Stop updating cpu_core_mask

[PATCH 2/7] powerpc/smp: Stop updating cpu_core_mask

-by: Srikar Dronamraju --- arch/powerpc/include/asm/smp.h | 5 - arch/powerpc/kernel/smp.c | 33 +++-- 2 files changed, 7 insertions(+), 31 deletions(-) diff --git a/arch/powerpc/include/asm/smp.h b/arch/powerpc/include/asm/smp.h index 5bdc17a7049f..cf6e7c7be62b

[PATCH 3/7] powerpc/smp: Remove get_physical_package_id

Cc: LKML Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Anton Blanchard Cc: Oliver O'Halloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Signed-off-by: Srikar Dronamraju --- arch/powerpc

Re: [PATCH v4 00/10] Coregroup support on Powerpc

* Srikar Dronamraju [2020-07-27 10:47:55]: > Changelog v3 ->v4: > v3: > https://lore.kernel.org/lkml/20200723085116.4731-1-sri...@linux.vnet.ibm.com/t/#u > > powerpc/smp: Create coregroup domain > if coregroup_support doesn't exist, update MC mask to the next >

[PATCH v4 10/10] powerpc/smp: Implement cpu_to_coregroup_id

: Michael Ellerman Cc: Nicholas Piggin Cc: Anton Blanchard Cc: Oliver O'Halloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by : Gautham R. Shenoy Signed-off-by: Srikar Dronamraju

[PATCH v4 07/10] Powerpc/numa: Detect support for coregroup

Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: Explained Coregroup in commit msg (Michael Ellerman) arch/powe

[PATCH v4 08/10] powerpc/smp: Allocate cpumask only after searching thread group

Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel

[PATCH v4 09/10] Powerpc/smp: Create coregroup domain

Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v3 ->v4: if coregroup_support doesn't exist, update MC mask to the next smaller domain mask. Changelog

[PATCH v4 06/10] powerpc/smp: Generalize 2nd sched domain

stra Cc: Valentin Schneider Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: Moved shared_cache topology fixup to fixup_topology (Gautham) arch/powerpc/kernel/smp.c | 48 +++ 1 file changed, 34 insertions(+), 14 deletions(-

[PATCH v4 00/10] Coregroup support on Powerpc

Cc: Nick Piggin Cc: Oliver OHalloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Anton Blanchard Cc: Gautham R Shenoy Cc: Vaidyanathan Srinivasan Cc: Jordan Niethe Srikar Dronamraju (10): powerpc/smp: Fix a warning under !NEED_MULTIPLE_NODES powerpc/smp: Merge Power9 topology with Power topology

[PATCH v4 05/10] powerpc/smp: Dont assume l2-cache to be superset of sibling

Piggin Cc: Anton Blanchard Cc: Oliver O'Halloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: Set cpum

[PATCH v4 02/10] powerpc/smp: Merge Power9 topology with Power topology

: Anton Blanchard Cc: Oliver O'Halloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: Replaced a refere

[PATCH v4 03/10] powerpc/smp: Move powerpc_topology above

Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 116 +++--- 1 file changed, 58 insertions(+), 58 deletions

[PATCH v4 04/10] powerpc/smp: Move topology fixups into a new function

Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v2 -> v3: Rewrote changelog (Gautham) Renamed to powerpc/smp: Move topology fixups into a new function arch/powe

[PATCH v4 01/10] powerpc/smp: Fix a warning under !NEED_MULTIPLE_NODES

Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v2 -> v3: Removed node caching part. Rewrote the Commit msg (Michael Ellerman) Renamed to powerpc/smp: Fix a warning under !NEED_M

[PATCH v4 03/10] powerpc/smp: Move powerpc_topology above

Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 116 +++--- 1 file changed, 58 insertions(+), 58 deletions

[PATCH v4 01/10] powerpc/smp: Fix a warning under !NEED_MULTIPLE_NODES

Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v2 -> v3: Removed node caching part. Rewrote the Commit msg (Michael Ellerman) Renamed to powerpc/smp: Fix a warning under !NEED_M

[PATCH v4 10/10] powerpc/smp: Implement cpu_to_coregroup_id

: Michael Ellerman Cc: Nicholas Piggin Cc: Anton Blanchard Cc: Oliver O'Halloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by : Gautham R. Shenoy Signed-off-by: Srikar Dronamraju

[PATCH v4 02/10] powerpc/smp: Merge Power9 topology with Power topology

: Anton Blanchard Cc: Oliver O'Halloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: Replaced a refere

[PATCH v4 08/10] powerpc/smp: Allocate cpumask only after searching thread group

Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel

[PATCH v4 06/10] powerpc/smp: Generalize 2nd sched domain

stra Cc: Valentin Schneider Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: Moved shared_cache topology fixup to fixup_topology (Gautham) arch/powerpc/kernel/smp.c | 49 --- 1 file changed, 35 insertions(+), 14 deletions(-

[PATCH v4 09/10] Powerpc/smp: Create coregroup domain

Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v3 ->v4: if coregroup_support doesn't exist, update MC mask to the next smaller domain mask. Changelog

[PATCH v4 04/10] powerpc/smp: Move topology fixups into a new function

Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v2 -> v3: Rewrote changelog (Gautham) Renamed to powerpc/smp: Move topology fixups into a new function arch/powe

[PATCH v4 00/10] Coregroup support on Powerpc

Cc: Nick Piggin Cc: Oliver OHalloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Anton Blanchard Cc: Gautham R Shenoy Cc: Vaidyanathan Srinivasan Cc: Jordan Niethe Srikar Dronamraju (10): powerpc/smp: Fix a warning under !NEED_MULTIPLE_NODES powerpc/smp: Merge Power9 topology with Power topology

[PATCH v4 05/10] powerpc/smp: Dont assume l2-cache to be superset of sibling

Piggin Cc: Anton Blanchard Cc: Oliver O'Halloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: Set cpum

[PATCH v4 07/10] Powerpc/numa: Detect support for coregroup

Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: Explained Coregroup in commit msg (Michael Ellerman) arch/powe

Re: [PATCH] uprobes: change handle_swbp() to send SIGTRAP with si_code=SI_KERNEL

tch. > > Reported-by: Aaron Merey > Cc: sta...@vger.kernel.org > Signed-off-by: Oleg Nesterov Looks good to me. Reviewed-by: Srikar Dronamraju > --- > kernel/events/uprobes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/events/uprob

[PATCH v3 00/10] Coregroup support on Powerpc

olnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Nick Piggin Cc: Oliver OHalloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Anton Blanchard Cc: Gautham R Shenoy Cc: Vaidyanathan Srinivasan Cc: Jordan Niethe Srikar Dronamraju (10): powerpc/smp: Fix a warning under !NEED_MULTIPLE_NODES po

[PATCH v3 09/10] powerpc/smp: Create coregroup domain

Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v2 -> v3: Add optimization for mask updation under coregroup_support Changelog v1 -> v2: Moved cor

[PATCH v3 08/10] powerpc/smp: Allocate cpumask only after searching thread group

Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel

[PATCH v3 10/10] powerpc/smp: Implement cpu_to_coregroup_id

: Michael Ellerman Cc: Nicholas Piggin Cc: Anton Blanchard Cc: Oliver O'Halloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by : Gautham R. Shenoy Signed-off-by: Srikar Dronamraju

[PATCH v3 06/10] powerpc/smp: Generalize 2nd sched domain

stra Cc: Valentin Schneider Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: Moved shared_cache topology fixup to fixup_topology (Gautham) arch/powerpc/kernel/smp.c | 49 --- 1 file changed, 35 insertions(+), 14 deletions(-

[PATCH v3 07/10] powerpc/numa: Detect support for coregroup

Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: Explained Coregroup in commit msg (Michael Ellerman) arch/powe

[PATCH v3 04/10] powerpc/smp: Move topology fixups into a new function

Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v2 -> v3: Rewrote changelog (Gautham) Renamed to powerpc/smp: Move topology fixups into a new function arch/powerpc/kernel/smp.c |

[PATCH v3 01/10] powerpc/smp: Fix a warning under !NEED_MULTIPLE_NODES

Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v2 -> v3: Removed node caching part. Rewrote the Commit msg (Michael Ellerman) Renamed to powerpc/smp: Fix a warning under !NEED_M

[PATCH v3 02/10] powerpc/smp: Merge Power9 topology with Power topology

: Anton Blanchard Cc: Oliver O'Halloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: Replaced a reference to cpu_smt_mask with per_

[PATCH v3 03/10] powerpc/smp: Move powerpc_topology above

Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 116 +++--- 1 file changed, 58 insertions(+), 58 deletions

[PATCH v3 05/10] powerpc/smp: Dont assume l2-cache to be superset of sibling

Piggin Cc: Anton Blanchard Cc: Oliver O'Halloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Gautham R Shenoy Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: Set cpumask after verifying l2-ca

Re: [PATCH v2 06/10] powerpc/smp: Generalize 2nd sched domain

* pet...@infradead.org [2020-07-22 09:46:24]: > On Tue, Jul 21, 2020 at 05:08:10PM +0530, Srikar Dronamraju wrote: > > Currently "CACHE" domain happens to be the 2nd sched domain as per > > powerpc_topology. This domain will collapse if cpumask of l2-cache is > >

Re: [PATCH v2 01/10] powerpc/smp: Cache node for reuse

* Michael Ellerman [2020-07-22 17:41:41]: > Srikar Dronamraju writes: > > While cpu_to_node is inline function with access to per_cpu variable. > > However when using repeatedly, it may be cleaner to cache it in a local > > variable. > > It's not clear what &q

Re: [PATCH v2 06/10] powerpc/smp: Generalize 2nd sched domain

* Gautham R Shenoy [2020-07-22 12:26:40]: > Hello Srikar, > > On Tue, Jul 21, 2020 at 05:08:10PM +0530, Srikar Dronamraju wrote: > > Currently "CACHE" domain happens to be the 2nd sched domain as per > > powerpc_topology. This domain will collapse if cpumask

Re: [PATCH v2 09/10] Powerpc/smp: Create coregroup domain

f in future, if we want to consolidate the domains before calling set_sched_topology(), this order would be ideal. > > > if (shared_caches) { > > pr_info("Using shared cache scheduler topology\n"); > > powerpc_topology[bigcore_idx].mask = shared_cache_mask; > -- Thanks and Regards Srikar Dronamraju

Re: [PATCH v2 04/10] powerpc/smp: Enable small core scheduling sooner

* Gautham R Shenoy [2020-07-22 11:29:25]: > Hello Srikar, > > On Tue, Jul 21, 2020 at 05:08:08PM +0530, Srikar Dronamraju wrote: > > Enable small core scheduling as soon as we detect that we are in a > > system that supports thread group. Doing so would avoid

Re: [PATCH v2 05/10] powerpc/smp: Dont assume l2-cache to be superset of sibling

same chip as this CPU. > > +*/ > > + if (shared_caches) > > + mask = cpu_l2_cache_mask; > > + > > + for_each_cpu(i, mask(cpu)) > > + set_cpus_related(cpu, i, cpu_core_mask); > > > > - if (pkg_id == -1) > > return; > > + } > > > ... since "cpu" is not yet set in the cpu_online_mask, do we not miss setting > "cpu" in the cpu_core_mask(cpu) in the for-loop below ? > > As noted above, we are setting before. So we don't missing the cpu and hence have not different from before. > -- > Thanks and Regards > gautham. -- Thanks and Regards Srikar Dronamraju

[PATCH v2 03/10] powerpc/smp: Move powerpc_topology above

OHalloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Anton Blanchard Cc: Gautham R Shenoy Cc: Vaidyanathan Srinivasan Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 116 +++--- 1 file changed, 58

[PATCH v2 10/10] powerpc/smp: Implement cpu_to_coregroup_id

: Michael Ellerman Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Nick Piggin Cc: Oliver OHalloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Anton Blanchard Cc: Gautham R Shenoy Cc: Vaidyanathan Srinivasan Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v1

[PATCH v2 04/10] powerpc/smp: Enable small core scheduling sooner

: Nathan Lynch Cc: Michael Neuling Cc: Anton Blanchard Cc: Gautham R Shenoy Cc: Vaidyanathan Srinivasan Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: powerpc/smp: Enable small core scheduling sooner Restored the previous info msg (Jordan) Moved

[PATCH v2 08/10] powerpc/smp: Allocate cpumask only after searching thread group

Cc: Nathan Lynch Cc: Michael Neuling Cc: Anton Blanchard Cc: Gautham R Shenoy Cc: Vaidyanathan Srinivasan Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH v2 07/10] Powerpc/numa: Detect support for coregroup

Cc: Oliver OHalloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Anton Blanchard Cc: Gautham R Shenoy Cc: Vaidyanathan Srinivasan Cc: Jordan Niethe Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: Powerpc/numa: Detect support for coregr

[PATCH v2 06/10] powerpc/smp: Generalize 2nd sched domain

Cc: Gautham R Shenoy Cc: Vaidyanathan Srinivasan Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: powerpc/smp: Generalize 2nd sched domain Moved shared_cache topology fixup to fixup_topology (Gautham) arch/powerpc/kernel/smp.c | 49

[PATCH v2 09/10] Powerpc/smp: Create coregroup domain

: Oliver OHalloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Anton Blanchard Cc: Gautham R Shenoy Cc: Vaidyanathan Srinivasan Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: Powerpc/smp: Create coregroup domain Moved coregroup topology fixup to fixup_topol

[PATCH v2 05/10] powerpc/smp: Dont assume l2-cache to be superset of sibling

Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Nick Piggin Cc: Oliver OHalloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Anton Blanchard Cc: Gautham R Shenoy Cc: Vaidyanathan Srinivasan Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: powerpc/smp: Dont assume

[PATCH v2 02/10] powerpc/smp: Merge Power9 topology with Power topology

Zijlstra Cc: Valentin Schneider Cc: Nick Piggin Cc: Oliver OHalloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Anton Blanchard Cc: Gautham R Shenoy Cc: Vaidyanathan Srinivasan Cc: Jordan Niethe Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: powerpc/smp: Merge Power9 topol

[PATCH v2 01/10] powerpc/smp: Cache node for reuse

Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index 73199470c265..680c0edcc59d 100644 --- a/arch/powerpc/kernel/smp.c +++ b/arch/powerpc/ke

[PATCH v2 00/10] Coregroup support on Powerpc

hael Ellerman Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Nick Piggin Cc: Oliver OHalloran Cc: Nathan Lynch Cc: Michael Neuling Cc: Anton Blanchard Cc: Gautham R Shenoy Cc: Vaidyanathan Srinivasan Cc: Jordan Niethe Srikar Dronamraju (10): powerpc/smp: Cache n

Re: [PATCH v2 4/4] perf-probe: Warn if the target function is GNU Indirect function

y --call-graph dwarf -aR ./perf > > Thus, I decided to warn user when the perf probe detects the probe point > is on the GNU IFUNC symbol. Someone who wants to probe an IFUNC symbol to > debug the IFUNC function, they can ignore this warning. > > Reported-by: Andi Kleen > Si

Re: [PATCH 1/4] perf-probe: Avoid setting probes on same address on same event

for (i = 0; i < j; i++) > + if (sym->start == syms[i]->start) { > + pr_debug("find duplicated symbol %s @ %lx\n", > sym->name, sym->start); Would "Found" sound better than "find"? > +

Re: [PATCH 3/4] perf-probe: Fix memory leakage when the probe point is not found

; Signed-off-by: Masami Hiramatsu Looks good to me. Reviewed-by: Srikar Dronamraju > --- > tools/perf/util/probe-finder.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c > index 9963

Re: [PATCH 2/4] perf-probe: Fix wrong variable warning when the probe point is not found

.@vger.kernel.org > Signed-off-by: Masami Hiramatsu Looks good to me. Reviewed-by: Srikar Dronamraju > --- > tools/perf/util/probe-finder.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c >

Re: [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function

uprobes) Also instead of printing the address, can we print the pp->function? > break; > } > if (!address) { > -- Thanks and Regards Srikar Dronamraju

Re: [PATCH v5 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

dy used by the renumbered one > though. It would likely conflate the two I am afraid. But I am not sure > this is really possible with x86 and a lack of a bug report would > suggest that nobody is doing that at least. > JFYI, Satheesh copied in this mailchain had opened a bug a year on crash with vcpu hotplug on memoryless node. https://bugzilla.kernel.org/show_bug.cgi?id=202187 -- Thanks and Regards Srikar Dronamraju

Re: [PATCH v5 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

* Michal Hocko [2020-07-02 10:41:23]: > On Thu 02-07-20 12:14:08, Srikar Dronamraju wrote: > > * Michal Hocko [2020-07-01 14:21:10]: > > > > > > >>>>> The autonuma problem sounds interesting but again this patch > > > > >>>>>

Re: [PATCH v5 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

; > [0.009731] ACPI: SRAT: Node 0 PXM 1 [mem 0x-0x0009] > > [0.009732] ACPI: SRAT: Node 0 PXM 1 [mem 0x0010-0xbfff] > > [0.009733] ACPI: SRAT: Node 0 PXM 1 [mem 0x1-0x13fff] > > This begs a question whether ppc can do the same thing? Certainly ppc can be made to adapt to this situation but that would be a workaround. Do we have a reason why we think node 0 is unique and special? If yes can we document it so that in future also people know why we consider node 0 to be special. I do understand the *fear of the unknown* but when we are unable to theoretically or practically come up a case, then it may probably be better we hit the situation to understand what that unknown is? > I would swear that we've had x86 system with node 0 but I cannot really > find it and it is possible that it was not x86 after all... -- Thanks and Regards Srikar Dronamraju

Re: [PATCH v5 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

* David Hildenbrand [2020-07-01 12:15:54]: > On 01.07.20 12:04, Srikar Dronamraju wrote: > > * Michal Hocko [2020-07-01 10:42:00]: > > > >> > >>> > >>> 2. Also existence of dummy node also leads to inconsistent information. > &

Re: [PATCH v5 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

vid mentioned and reported back at https://lore.kernel.org/lkml/20200511174731.gd1...@linux.vnet.ibm.com/t/#u As a summary, David's steps are still not creating a memoryless/cpuless on x86 VM. I have tried booting with Numa/non-numa on all the x86 machines that I could get to. -- Thanks and Regards Srikar Dronamraju

Re: [PATCH v5 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

* Christopher Lameter [2020-06-29 14:58:40]: > On Wed, 24 Jun 2020, Srikar Dronamraju wrote: > > > Currently Linux kernel with CONFIG_NUMA on a system with multiple > > possible nodes, marks node 0 as online at boot. However in practice, > > there are systems which h

[PATCH v5 2/3] powerpc/numa: Prefer node id queried from vphn

-kernel@vger.kernel.org Cc: Michal Hocko Cc: Mel Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: David Hildenbrand Signed-off-by: Srikar

[PATCH v5 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

orman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: David Hildenbrand Signed-off-by: Srikar Dronamraju --- Changelog v4:->v5: - rebased to v5.8-rc2

[PATCH v5 0/3] Offline memoryless cpuless node 0

quot;Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: David Hildenbrand Srikar Dronamraju (3): powerpc/numa: Set numa_node for all possible cpus powerpc/numa: Prefer node id quer

[PATCH v5 1/3] powerpc/numa: Set numa_node for all possible cpus

Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: David Hildenbrand Signed-off-by: Srikar Dronamraju --- Changelog v4:->v5: - rebased to v5.

Re: [PATCH] tracing/probe: fix memleak in fetch_op_data operations

Actually he is more upto date with uprobes code. -- Thanks and Regards Srikar Dronamraju

Re: [RFC PATCH v5 3/3] docs: scheduler: Add introduction to scheduler context-switch

t; + task. Same as for exiting process in this case, the context_switch() Did you mean existing instead of exiting? > + function saves the pointer to the memory descriptor used by prev in the > + runqueue???s prev_mm field and resets prev task active address space. > + -- Thanks and Regards Srikar Dronamraju

Re: [PATCH v4 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

* Christopher Lameter [2020-05-12 16:31:26]: > On Tue, 12 May 2020, Srikar Dronamraju wrote: > > > +#ifdef CONFIG_NUMA > > + [N_ONLINE] = NODE_MASK_NONE, > > Again. Same issue as before. If you do this then you do a global change > for all architectures

[PATCH v4 1/3] powerpc/numa: Set numa_node for all possible cpus

Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: David Hildenbrand Signed-off-by: Srikar Dronamraju --- Changelog v3:->v4: - Resolved

[PATCH v4 0/3] Offline memoryless cpuless node 0

: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: David Hildenbrand Srikar Dronamraju (3): powerpc/numa: Set numa_node for all possible cpus powerpc/numa: Prefer node id que

[PATCH v4 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

llerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: David Hildenbrand Signed-off-by: Srikar Dronamraju --- Changelog v1:->v2: - Rebased to v5.7-rc3 Link v2: https://lore.kernel.org/linuxppc-dev/20200428093836.27190-1-sri...@linux.vnet.ibm.com/t/#u

[PATCH v4 2/3] powerpc/numa: Prefer node id queried from vphn

-kernel@vger.kernel.org Cc: Michal Hocko Cc: Mel Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: David Hildenbrand Signed-off-by: Srikar

Re: [PATCH v2 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

* David Hildenbrand [2020-05-12 09:49:05]: > On 11.05.20 19:47, Srikar Dronamraju wrote: > > * David Hildenbrand [2020-05-08 15:42:12]: > > > > > > [root@localhost ~]# cat /sys/devices/system/node/online > > 0 > > [root@localhost ~]# cat /sys/devices/sys

Re: [PATCH v2 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

ark node 0 as cpuless,memoryless and node 1 as actual node, the system somewhere marks node 0 as the actual node. > > David / dhildenb > -- Thanks and Regards Srikar Dronamraju

Re: [PATCH v3 1/3] powerpc/numa: Set numa_node for all possible cpus

* Christopher Lameter [2020-05-02 22:55:16]: > On Fri, 1 May 2020, Srikar Dronamraju wrote: > > > - for_each_present_cpu(cpu) > > - numa_setup_cpu(cpu); > > + for_each_possible_cpu(cpu) { > > + /* > > +* Powerpc with CONF

Re: [PATCH v3 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

* Christopher Lameter [2020-05-02 23:05:28]: > On Fri, 1 May 2020, Srikar Dronamraju wrote: > > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -116,8 +116,10 @@ EXPORT_SYMBOL(latent_entropy); > > */ > > nodemask_t node_states[NR_NODE_STATES] _

Re: [PATCH v2 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

rces for a node(node 0) are available but still online. However they find other nodes (nodes 1-6) with don't have resources but not online. So they tend to think the kernel has been unable to online some of the resources or the resources have gone bad. Please do note that on hypervisors like PowerVM, the admins don't have control over which nodes the resources are allocated. -- Thanks and Regards Srikar Dronamraju

Re: [PATCH] uprobes: ensure that uprobe->offset and ->ref_ctr_offset are properly aligned

ted-by: Linus Torvalds > Signed-off-by: Oleg Nesterov Thanks Oleg. Looks good to me. Reviewed-by: Srikar Dronamraju > --- -- Thanks and Regards Srikar Dronamraju

[PATCH v3 1/3] powerpc/numa: Set numa_node for all possible cpus

Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v1:->v2: - Rebased to v5.7-rc3 arch/powerpc/mm/numa.c | 16 +++

[PATCH v3 2/3] powerpc/numa: Prefer node id queried from vphn

-kernel@vger.kernel.org Cc: Michal Hocko Cc: Mel Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v2:->v3: - Resolved

[PATCH v3 0/3] Offline memoryless cpuless node 0

nuxppc-...@lists.ozlabs.org Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org Cc: Michal Hocko Cc: Mel Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Srikar Dronamraj

[PATCH v3 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

llerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v1:->v2: - Rebased to v5.7-rc3 Link v2: https://lore.kernel.org/linuxppc-dev/20200428093836.27190-1-sri...@linux.vnet.ibm.com/t/#u mm/page_alloc.c | 4 +++- 1 file changed, 3 i

Re: [PATCH v2 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

* Michal Hocko [2020-04-29 14:22:11]: > On Wed 29-04-20 07:11:45, Srikar Dronamraju wrote: > > > > > > > > By marking, N_ONLINE as NODE_MASK_NONE, lets stop assuming that Node 0 > > > > is > > > > always online. > > > > >

Re: [PATCH v2 2/3] powerpc/numa: Prefer node id queried from vphn

NUMA_NO_NODE ? If so, > should we still call node_set_online() below ? Yeah, I think It makes sense to retain the BUG_ON and if check. Will incorporate both of them in the next version. > > > > node_set_online(nid); > > } > > > > -- > > 2.20.1 > > > -- > Thanks and Regards > gautham. -- Thanks and Regards Srikar Dronamraju

Re: [PATCH v2 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

3. NUMA Multi node but with CPUs and memory from node 0. 4. NUMA Multi node but with no CPUs and memory from node 0. -- Thanks and Regards Srikar Dronamraju

<    1   2   3   4   5   6   7   8   9   10   >