tomic()
APIs to prevent CPUs from going offline, while invoking from atomic context.
Cc: Dipankar Sarma
Cc: "Paul E. McKenney"
Signed-off-by: Srivatsa S. Bhat
---
kernel/rcutree.c |4
1 file changed, 4 insertions(+)
diff --git a/kernel/rcutree.c b/kernel/rcutree.c
index c
Peter Zijlstra
Signed-off-by: Srivatsa S. Bhat
---
kernel/sched/rt.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 01970c8..03d9f38 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -6,6 +6,7 @@
#include &qu
ixner
Signed-off-by: Srivatsa S. Bhat
---
kernel/timer.c |4
1 file changed, 4 insertions(+)
diff --git a/kernel/timer.c b/kernel/timer.c
index 15ffdb3..5db594c 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -729,6 +729,7 @@ __mod_timer(struct timer_list *timer, unsigned long ex
n
Cc: Wang YanQing
Cc: Shaohua Li
Cc: Jan Beulich
Cc: liguang
Signed-off-by: Srivatsa S. Bhat
---
kernel/smp.c | 52 ++--
1 file changed, 30 insertions(+), 22 deletions(-)
diff --git a/kernel/smp.c b/kernel/smp.c
index 4dba0f7..1f36d6d 100644
Convert the macros in the CPU hotplug code to static inline C functions.
Cc: Thomas Gleixner
Cc: Andrew Morton
Cc: Tejun Heo
Cc: "Rafael J. Wysocki"
Signed-off-by: Srivatsa S. Bhat
---
include/linux/cpu.h |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
di
We need not use the raw_spin_lock_irqsave/restore primitives because
all CPU_DYING notifiers run with interrupts disabled. So just use
raw_spin_lock/unlock.
Cc: Ingo Molnar
Cc: Peter Zijlstra
Signed-off-by: Srivatsa S. Bhat
---
kernel/sched/core.c |4 ++--
1 file changed, 2 insertions
Peter Zijlstra
Signed-off-by: Srivatsa S. Bhat
---
kernel/sched/core.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 195658b..accd550 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -11
Gleixner
Cc: Andrew Morton
Cc: Yasuaki Ishimatsu
Cc: "Rafael J. Wysocki"
Signed-off-by: Srivatsa S. Bhat
---
kernel/cpu.c |4
1 file changed, 4 insertions(+)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 5297ec1..35e7115 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -832,
from atomic context.
Cc: Rob Landley
Cc: linux-...@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat
---
Documentation/cpu-hotplug.txt | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/Documentation/cpu-hotplug.txt b/Documentation/cpu-hotplug.txt
index 9f
Signed-off-by: Srivatsa S. Bhat
---
lib/Kconfig.debug |8
1 file changed, 8 insertions(+)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 566cf2b..ec6be74 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -512,6 +512,14 @@ config DEBUG_PREEMPT
if kernel co
: Yasuaki Ishimatsu
Cc: "Rafael J. Wysocki"
Signed-off-by: Srivatsa S. Bhat
---
kernel/cpu.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 2d03398..860f51a 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -139,6 +139,13 @@ s
ation of these APIs to a suitable synchronization scheme.
Reviewed-by: Steven Rostedt
Cc: Thomas Gleixner
Cc: Andrew Morton
Cc: Tejun Heo
Cc: "Rafael J. Wysocki"
Cc: Yasuaki Ishimatsu
Signed-off-by: Srivatsa S. Bhat
---
include/linux/cpu.h | 20
kernel/cpu.
l.org/lkml/2012/12/4/88
3. Links to previous versions of this patchset:
v1: http://lwn.net/Articles/556138/
--
Srivatsa S. Bhat (45):
CPU hotplug: Provide APIs to prevent CPU offline from atomic context
CPU hotplug: Clarify the usage of different synchronization APIs
Doc
t CPU.
My patchset will retain these guarantees even after removing stop_machine().
And these are required for the correct execution of the code in this path,
since they rely on these semantics.
So I guess I'll retain the patch as it is. Thank you!
Regards,
Srivatsa S. Bhat
--
To unsubsc
On 06/25/2013 04:56 AM, Steven Rostedt wrote:
> On Sun, 2013-06-23 at 19:08 +0530, Srivatsa S. Bhat wrote:
>
>
> Just to make the code a little cleaner, can you add:
>
>> diff --git a/kernel/cpu.c b/kernel/cpu.c
>> index 860f51a..e90d9d7 100644
>> --- a/k
ld be superfluous in this case...
But as you said, simply invoking those functions is much simpler ;-)
> Can you please at least add a comment explaining that?
>
Sure, will do. Thanks a lot Tejun!
Regards,
Srivatsa S. Bhat
--
To unsubscribe from this list: send the line "unsubscrib
On 06/24/2013 12:47 AM, Joe Perches wrote:
> On Mon, 2013-06-24 at 00:25 +0530, Srivatsa S. Bhat wrote:
>> On 06/23/2013 11:47 PM, Greg Kroah-Hartman wrote:
>>> On Sun, Jun 23, 2013 at 07:13:33PM +0530, Srivatsa S. Bhat wrote:
> []
>>>> diff --git a/drivers/sta
On 06/23/2013 08:38 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 23-06-2013 17:39, Srivatsa S. Bhat wrote:
>
>> Now that we have all the pieces of the CPU hotplug debug infrastructure
>> in place, expose the feature by growing a new Kconfig option,
>> CONFIG_DEBUG
On 06/23/2013 11:20 PM, Matt Turner wrote:
> On Sun, Jun 23, 2013 at 6:45 AM, Srivatsa S. Bhat
> wrote:
>> Once stop_machine() is gone from the CPU offline path, we won't be able
>> to depend on disabling preemption to prevent CPUs from going offline
>> fro
On 06/23/2013 11:47 PM, Greg Kroah-Hartman wrote:
> On Sun, Jun 23, 2013 at 07:13:33PM +0530, Srivatsa S. Bhat wrote:
>> Once stop_machine() is gone from the CPU offline path, we won't be able
>> to depend on disabling preemption to prevent CPUs from going offline
>> fr
ation of these APIs to a suitable synchronization scheme.
Cc: Thomas Gleixner
Cc: Andrew Morton
Cc: Tejun Heo
Cc: "Rafael J. Wysocki"
Cc: Yasuaki Ishimatsu
Signed-off-by: Srivatsa S. Bhat
---
include/linux/cpu.h | 18 ++
kernel/cpu.
igned-off-by: Srivatsa S. Bhat
---
arch/tile/kernel/module.c |3 +++
arch/tile/kernel/tlb.c| 15 +++
arch/tile/mm/homecache.c |3 +++
3 files changed, 21 insertions(+)
diff --git a/arch/tile/kernel/module.c b/arch/tile/kernel/module.c
index 4918d91..db7d858 100644
--- a
iller"
Cc: Sam Ravnborg
Cc: Thomas Gleixner
Cc: Dave Kleikamp
Cc: sparcli...@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat
---
arch/sparc/kernel/smp_64.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/sparc/kernel/smp_64.c b/arch/sparc/kernel
homas Gleixner
Cc: linux...@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat
---
arch/sh/kernel/smp.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/sh/kernel/smp.c b/arch/sh/kernel/smp.c
index 4569645..42ec182 100644
--- a/arch/sh/kernel/smp.c
+++ b/ar
k
Cc: Jesper Nilsson
Cc: Thomas Gleixner
Cc: linux-cris-ker...@axis.com
Signed-off-by: Srivatsa S. Bhat
---
arch/cris/arch-v32/kernel/smp.c |5 +
1 file changed, 5 insertions(+)
diff --git a/arch/cris/arch-v32/kernel/smp.c b/arch/cris/arch-v32/kernel/smp.c
index cdd1202..b2d4612 100644
nghua Yu
Cc: linux-i...@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat
---
arch/ia64/kernel/smp.c | 12 ++--
arch/ia64/mm/tlb.c |4 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/ia64/kernel/smp.c b/arch/ia64/kernel/smp.c
index 9fcd4e6..25991ba 1
s
Cc: Koichi Yasutake
Cc: linux-am33-l...@redhat.com
Signed-off-by: Srivatsa S. Bhat
---
arch/mn10300/mm/cache-smp.c |3 +++
arch/mn10300/mm/tlb-smp.c | 17 +
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/arch/mn10300/mm/cache-smp.c b/arch/mn10300/mm/cache-
ASCII character present in this file!
Cc: Richard Henderson
Cc: Ivan Kokshaysky
Cc: Matt Turner
Cc: Thomas Gleixner
Cc: linux-al...@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat
---
arch/alpha/kernel/smp.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff
r
Cc: Bob Liu
Cc: Steven Miao
Cc: Thomas Gleixner
Cc: uclinux-dist-de...@blackfin.uclinux.org
Signed-off-by: Srivatsa S. Bhat
---
arch/blackfin/mach-common/smp.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/blackfin/mach-common/smp.c b/arch/blackfin/mach-common/
nghua Yu
Cc: Andrew Morton
Cc: "Eric W. Biederman"
Cc: Thomas Gleixner
Cc: linux-i...@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat
---
arch/ia64/kernel/irq_ia64.c | 15 +++
arch/ia64/kernel/perfmon.c |8 +++-
2 files changed, 22 insertions(+), 1 deletion(-
: Li Zhong
Cc: linuxppc-...@lists.ozlabs.org
Signed-off-by: Srivatsa S. Bhat
---
arch/powerpc/kernel/irq.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
index ea185e0..ca39bac 100644
--- a/arch/powerpc/kernel/irq.c
o
Cc: Thomas Gleixner
Cc: linux-hexa...@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat
---
arch/hexagon/kernel/smp.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/hexagon/kernel/smp.c b/arch/hexagon/kernel/smp.c
index 0e364ca..30d4318 100644
--- a/arch/hexagon/kernel/smp.c
+++ b
hmidt
Cc: Gleb Natapov
Cc: Alexander Graf
Cc: Rob Herring
Cc: Grant Likely
Cc: Kumar Gala
Cc: Zhao Chenhui
Cc: linuxppc-...@lists.ozlabs.org
Cc: k...@vger.kernel.org
Cc: kvm-...@vger.kernel.org
Cc: oprofile-l...@lists.sf.net
Cc: cbe-oss-...@lists.ozlabs.org
Signed-off-by: Srivatsa S.
: Zhao Chenhui
Cc: Thomas Gleixner
Cc: linuxppc-...@lists.ozlabs.org
Signed-off-by: Srivatsa S. Bhat
---
arch/powerpc/kernel/smp.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 2123bec..59c9a09 100644
--- a/arch/powerpc
e
Cc: David Daney
Cc: Yong Zhang
Cc: Thomas Gleixner
Cc: Sanjay Lal
Cc: "Steven J. Hill"
Cc: John Crispin
Cc: Florian Fainelli
Cc: linux-m...@linux-mips.org
Signed-off-by: Srivatsa S. Bhat
---
arch/mips/kernel/cevt-smtc.c |7 +++
arch/mips/kernel/smp.c | 16 +++
Wilk
Cc: Jeremy Fitzhardinge
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc: x...@kernel.org
Cc: xen-de...@lists.xensource.com
Cc: virtualizat...@lists.linux-foundation.org
Signed-off-by: Srivatsa S. Bhat
---
arch/x86/xen/mmu.c |9 +++--
1 file changed, 7 i
a
Cc: linux-m...@ml.linux-m32r.org
Cc: linux-m32r...@ml.linux-m32r.org
Signed-off-by: Srivatsa S. Bhat
---
arch/m32r/kernel/smp.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/m32r/kernel/smp.c b/arch/m32r/kernel/smp.c
index ce7aea3..ffafdba 100644
v
Cc: Paolo Bonzini
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc: x...@kernel.org
Cc: k...@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat
---
arch/x86/kvm/vmx.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arc
r
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc: x...@kernel.org
Cc: Tony Luck
Cc: Borislav Petkov
Cc: Konrad Rzeszutek Wilk
Cc: Sebastian Andrzej Siewior
Cc: Joerg Roedel
Cc: Jan Beulich
Cc: Joonsoo Kim
Cc: linux-e...@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat
---
arch/x86/kernel
v
Cc: Paolo Bonzini
Cc: k...@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat
---
virt/kvm/kvm_main.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 302681c..5bbfa30 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_m
n
Cc: de...@driverdev.osuosl.org
Signed-off-by: Srivatsa S. Bhat
---
drivers/staging/octeon/ethernet-rx.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/octeon/ethernet-rx.c
b/drivers/staging/octeon/ethernet-rx.c
index 34afc16..8588b4d 100644
--- a/drivers/staging/o
n
Cc: Christoph Raisch
Cc: Roland Dreier
Cc: Sean Hefty
Cc: Hal Rosenstock
Cc: linux-r...@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat
---
drivers/infiniband/hw/ehca/ehca_irq.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c
b/drivers/infin
e
Cc: "James E.J. Bottomley"
Cc: de...@open-fcoe.org
Cc: linux-s...@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat
---
drivers/scsi/fcoe/fcoe.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index 292b24f.
ff-by: Srivatsa S. Bhat
---
lib/percpu_counter.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/percpu_counter.c b/lib/percpu_counter.c
index ba6085d..9cf9086 100644
--- a/lib/percpu_counter.c
+++ b/lib/percpu_counter.c
@@ -98,6 +98,7 @@ s64 __percpu_counter_sum(struct percpu_co
ras
Cc: Ingo Molnar
Cc: Arnaldo Carvalho de Melo
Cc: Thomas Gleixner
Cc: "H. Peter Anvin"
Cc: x...@kernel.org
Signed-off-by: Srivatsa S. Bhat
---
arch/x86/kernel/cpu/perf_event_intel_uncore.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/x86/kernel/cpu/perf_event_i
d-off-by: Srivatsa S. Bhat
---
block/blk-softirq.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/block/blk-softirq.c b/block/blk-softirq.c
index 467c8de..bbab3d3 100644
--- a/block/blk-softirq.c
+++ b/block/blk-softirq.c
@@ -58,6 +58,7 @@ static void trigger_softirq(void
ixner
Signed-off-by: Srivatsa S. Bhat
---
kernel/time/tick-broadcast.c |8
1 file changed, 8 insertions(+)
diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
index d66f554..53493a6 100644
--- a/kernel/time/tick-broadcast.c
+++ b/kernel/time/tick-broadcast.c
@@ -2
iller"
Cc: Eric Dumazet
Cc: Alexander Duyck
Cc: Cong Wang
Cc: Ben Hutchings
Cc: net...@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat
---
net/core/dev.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index fc1e289..90519
ixner
Signed-off-by: Srivatsa S. Bhat
---
kernel/irq/manage.c |7 +++
kernel/irq/proc.c |3 +++
2 files changed, 10 insertions(+)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index e16caa8..4d89f19 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -18,6
z
Cc: Thomas Gleixner
Signed-off-by: Srivatsa S. Bhat
---
kernel/time/clocksource.c |5 +
1 file changed, 5 insertions(+)
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index e713ef7..c4bbc25 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -30,6
ecker
Cc: Thomas Gleixner
Cc: Andrew Morton
Cc: Sedat Dilek
Cc: "Paul E. McKenney"
Signed-off-by: Srivatsa S. Bhat
---
kernel/softirq.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 3d6833f..c289722 100644
--- a/kernel/softirq
Peter Zijlstra
Signed-off-by: Srivatsa S. Bhat
---
kernel/sched/fair.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index c0ac2c3..88f056e 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3338,7 +3
ixner
Signed-off-by: Srivatsa S. Bhat
---
kernel/timer.c |4
1 file changed, 4 insertions(+)
diff --git a/kernel/timer.c b/kernel/timer.c
index 15ffdb3..5db594c 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -729,6 +729,7 @@ __mod_timer(struct timer_list *timer, unsigned long ex
We need not use the raw_spin_lock_irqsave/restore primitives because
all CPU_DYING notifiers run with interrupts disabled. So just use
raw_spin_lock/unlock.
Cc: Ingo Molnar
Cc: Peter Zijlstra
Signed-off-by: Srivatsa S. Bhat
---
kernel/sched/core.c |4 ++--
1 file changed, 2 insertions
Peter Zijlstra
Signed-off-by: Srivatsa S. Bhat
---
kernel/sched/core.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 195658b..accd550 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -11
Peter Zijlstra
Signed-off-by: Srivatsa S. Bhat
---
kernel/sched/rt.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 01970c8..03d9f38 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -6,6 +6,7 @@
#include &qu
n
Cc: Wang YanQing
Cc: Shaohua Li
Cc: Jan Beulich
Cc: liguang
Signed-off-by: Srivatsa S. Bhat
---
kernel/smp.c | 52 ++--
1 file changed, 30 insertions(+), 22 deletions(-)
diff --git a/kernel/smp.c b/kernel/smp.c
index 4dba0f7..1f36d6d 100644
tomic()
APIs to prevent CPUs from going offline, while invoking from atomic context.
Cc: Dipankar Sarma
Cc: "Paul E. McKenney"
Signed-off-by: Srivatsa S. Bhat
---
kernel/rcutree.c |4
1 file changed, 4 insertions(+)
diff --git a/kernel/rcutree.c b/kernel/rcutree.c
index c
Convert the macros in the CPU hotplug code to static inline C functions.
Cc: Thomas Gleixner
Cc: Andrew Morton
Cc: Tejun Heo
Cc: "Rafael J. Wysocki"
Signed-off-by: Srivatsa S. Bhat
---
include/linux/cpu.h |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
di
Morton
Cc: Joonsoo Kim
Signed-off-by: Srivatsa S. Bhat
---
include/linux/cpumask.h | 47 +--
lib/cpumask.c |8
2 files changed, 53 insertions(+), 2 deletions(-)
diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h
Now that we have all the pieces of the CPU hotplug debug infrastructure
in place, expose the feature by growing a new Kconfig option,
CONFIG_DEBUG_HOTPLUG_CPU.
Cc: Andrew Morton
Cc: "Paul E. McKenney"
Cc: Akinobu Mita
Cc: Catalin Marinas
Cc: Michel Lespinasse
Signed-off-by: Srivat
Gleixner
Cc: Andrew Morton
Cc: Yasuaki Ishimatsu
Cc: "Rafael J. Wysocki"
Signed-off-by: Srivatsa S. Bhat
---
kernel/cpu.c |4
1 file changed, 4 insertions(+)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index e90d9d7..23df9ba 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -818,
Gleixner
Cc: Andrew Morton
Cc: Yasuaki Ishimatsu
Cc: "Rafael J. Wysocki"
Signed-off-by: Srivatsa S. Bhat
---
include/linux/cpumask.h | 12
kernel/cpu.c| 75 +++
2 files changed, 87 insertions(+)
diff --git a/inc
19/
v5: http://lwn.net/Articles/533553/
v4: https://lkml.org/lkml/2012/12/11/209
v3: https://lkml.org/lkml/2012/12/7/287
v2: https://lkml.org/lkml/2012/12/5/322
v1: https://lkml.org/lkml/2012/12/4/88
--
Srivatsa S. Bhat (45):
CPU hotplug: Provide APIs to prevent CPU offline from
: Yasuaki Ishimatsu
Cc: "Rafael J. Wysocki"
Signed-off-by: Srivatsa S. Bhat
---
kernel/cpu.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 2d03398..860f51a 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -139,6 +139,13 @@ s
from atomic context.
Cc: Rob Landley
Cc: linux-...@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat
---
Documentation/cpu-hotplug.txt | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/Documentation/cpu-hotplug.txt b/Documentation/cpu-hotplug.txt
index 9f
On 05/29/2013 01:38 AM, Phillip Susi wrote:
>
> On 4/19/2013 3:12 AM, Srivatsa S. Bhat wrote:
>> But going further, as I had mentioned in my TODO list, we can be
>> smarter than this while doing compaction to evacuate memory regions
>> - we can choose to migrate only the
On 05/21/2013 02:28 PM, anish singh wrote:
> On Tue, May 21, 2013 at 1:19 PM, Srivatsa S. Bhat
> wrote:
>> On 05/21/2013 11:04 AM, anish singh wrote:
>>> On Mon, May 20, 2013 at 9:31 PM, Frederic Weisbecker
>>> wrote:
>>>> When the watchdog code
thread get back in action
> after the schedule call.Then sysctl and procfs will work I think.
kthread_unpark() can wake up a task only if the task is in TASK_PARKED
state. But since the above task would be in TASK_INTERRUPTIBLE state
(since it is not parked), kthread_unpark() will be powerles
because immediately after
coming out of the parked state, the 'continue' statement helps
re-evaluate the stop/park condition.
So this fix is only for the ->setup() case.
> callbacks look like proper way to implement cancellation in
> general. So let's fix it that way.
>
ak;
> then the cpu
> would be taken down with part of the DOWN_PREPARE notifier callbacks
> called, and something bad could happen after that.
>
> Signed-off-by: Li Zhong
> ---
Reviewed-by: Srivatsa S. Bhat
> kernel/time/tick-sched.c |2 +-
> 1 files changed, 1 ins
be triggered via sysfs also, but it would
be good to get a confirmation.]
And Viresh, in the regular hotplug paths, the call to gov_cancel_work() is
supposed to kill any pending workqueue functions pertaining to offline CPUs
right? Could there be a synchronization bug somewhere due to which this
might not be happening properly?
Regards,
Srivatsa S. Bhat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On 05/18/2013 05:21 AM, Rafael J. Wysocki wrote:
> On Saturday, May 18, 2013 01:20:10 AM Srivatsa S. Bhat wrote:
>> On 05/17/2013 11:47 PM, Olivier Doucet wrote:
>>> Hello,
>>>
>>> This performance penalty is still present in kernel 3.9.2. And
>>> CONFI
- use the interfaces provided by the kernel to
fix your problem:
- you can give idle=poll in the kernel command line,
- OR you can echo 0 > /dev/cpu_dma_latency
Irrespective of your kernel configuration options (CONFIG_PM=y/n), the
CPUs will not enter deep idle states, giving you th
@@ -56,6 +56,7 @@ void __weak arch_cpu_idle_dead(void) { }
> void __weak arch_cpu_idle(void)
> {
> cpu_idle_force_poll = 1;
> + local_irq_enable();
> }
>
> /*
>
This patch looks like the correct fix to me.
Reviewed-by: Srivatsa S. Bhat
Regards,
Srivatsa S. Bha
config INIT_ALL_POSSIBLE
Regards,
Srivatsa S. Bhat
> Signed-off-by: liguang
> ---
> kernel/cpu.c |5 -
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index cd166d3..2697d1a 100644
> --- a/kernel/cpu.c
> +++ b
Commit-ID: b47430d3adbedbfdb5979ba4874f5dadf94f16b1
Gitweb: http://git.kernel.org/tip/b47430d3adbedbfdb5979ba4874f5dadf94f16b1
Author: Srivatsa S. Bhat
AuthorDate: Tue, 14 May 2013 04:01:27 +0530
Committer: Thomas Gleixner
CommitDate: Tue, 14 May 2013 17:43:29 +0200
rcu/idle: Wrap cpu
On 05/14/2013 01:50 PM, Bjørn Mork wrote:
> "Srivatsa S. Bhat" writes:
>> On 05/14/2013 01:08 PM, Bjørn Mork wrote:
>>> "Srivatsa S. Bhat" writes:
>>>
>>>> The problem appears to be in the cpu idle poll implementation. You can
>&g
On 05/14/2013 01:16 PM, Srivatsa S. Bhat wrote:
> On 05/14/2013 01:08 PM, Bjørn Mork wrote:
>> "Srivatsa S. Bhat" writes:
>>> On 05/13/2013 08:09 PM, Bjørn Mork wrote:
>>>
>>>> Hey, hey, hey. Turns out this wasn't that wrong after all.
On 05/14/2013 01:08 PM, Bjørn Mork wrote:
> "Srivatsa S. Bhat" writes:
>> On 05/13/2013 08:09 PM, Bjørn Mork wrote:
>>
>>> Hey, hey, hey. Turns out this wasn't that wrong after all. That merge
>>> includes a oneline diff in kernel/cpu/idle.c and
explain the patch properly, so I think I need some help from
> Thomas here. Unless this makes you understand the real issue?
>
> Thomas, why does powertop trigger the
>
> WARNING: at kernel/rcutree.c:502 rcu_eqs_exit_common.isra.48+0x3d/0x125()
>
> without the attached patc
On 05/13/2013 08:55 PM, Daniel Lezcano wrote:
> On 05/13/2013 11:04 AM, Srivatsa S. Bhat wrote:
>> On 05/13/2013 12:22 PM, Lianwei Wang wrote:
>>> Thank you. Patch is updated.
>>>
>>> From 2d0b4afb5461847dcdf08a87b02015d061b12e85 Mon Sep 17 00:00:00 2001
>&
dder cpu idle governors, the value set
in cpu_dma_latency is used to compare with the *exit-latency* of the sleep
state in order to decide which sleep state to go to. IOW, it has got *nothing*
to do with the duration of the sleep!!
> + if ((long)l < (long)s) {
... and hence, th
that what I have now is simply wrong for Robin's
>> application. Robin, can you please check this? We probably want to
>> make the does-something version of cpu_hotplug_disable/enable available
>> if CONFIG_HOTPLUG_CPU.
>
> This patch came from "Srivatsa S. B
On 05/09/2013 04:15 PM, Benjamin Herrenschmidt wrote:
> On Thu, 2013-05-09 at 16:03 +0530, Srivatsa S. Bhat wrote:
>> Can you check if the patch posted here fixes it?
>>
>> http://marc.info/?l=linux-kernel&m=136791823608013&w=2
>
> I believe I've alre
On 05/07/2013 12:55 PM, CAI Qian wrote:
> Never saw any of those messages were floating in any of the RC testing, but
> now happened in 3.9 GA on Power 7 systems.
>
Can you check if the patch posted here fixes it?
http://marc.info/?l=linux-kernel&m=136791823608013&w=2
Regards,
So remove the bogus write
permission to fix the warning.
Reported-by: CAI Qian
Signed-off-by: Srivatsa S. Bhat
---
arch/powerpc/kernel/sysfs.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/sysfs.c b/arch/powerpc/kernel/sysfs.c
index 3ce1f86..e68a84
1b
> [ 18.402308] ---[ end trace 3eb6a6f51fb8cafb ]---
> [ 18.402406] [ cut here ]
>
For the x86-64 case, does the patch posted here fix the issue?
http://marc.info/?l=linux-edac&m=136731542432210&w=2
Regards,
Srivatsa S. Bhat
--
To unsubscrib
ion to get rid of the warning.
Signed-off-by: Srivatsa S. Bhat
---
drivers/edac/edac_mc_sysfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
index 5899a76..769d92e 100644
--- a/drivers/edac/edac_mc_
gt; /* Any cleanup work */
> printk(KERN_INFO "Brought up %ld CPUs\n", (long)num_online_cpus());
> smp_cpus_done(setup_max_cpus);
>
So you moved cpu_notify(CPU_ONLINE) from cpu_up() to the SMP boot-up code.
That means, after boot, you'll never be a
On 04/29/2013 10:12 AM, li guang wrote:
> 在 2013-04-29一的 10:00 +0530,Srivatsa S. Bhat写道:
>> On 04/29/2013 08:19 AM, liguang wrote:
>>> in cpu_down(), _cpu_down() will do
>>> "
>>> if (num_online_cpus() == 1)
>>> return -
sons. One such case is suspend/resume.
That's why, if you have noticed, the suspend/resume code invokes the
_cpu_down() version, in order to bypass the flag and get its job done.
So, no, I think the check needs to stay.
Regards,
Srivatsa S. Bhat
> Signed-off-by: liguang
> ---
> kern
On 04/18/2013 10:40 PM, Dave Hansen wrote:
> On 04/09/2013 02:45 PM, Srivatsa S. Bhat wrote:
>> 2. Performance overhead is expected to be low: Since we retain the simplicity
>>of the algorithm in the page allocation path, page allocation can
>>potentially remain a
Rusty Russell
> Cc: Paul McKenney
> Cc: Peter Zijlstra
> Cc: Srivatsa S. Bhat
> Cc: Magnus Damm
> Signed-off-by: Kevin Hilman
> ---
Reviewed-by: Srivatsa S. Bhat
Regards,
Srivatsa S. Bhat
> Applies on tip/smp/hotplug where generic idle feature is added
>
> arch/Kcon
;t offline CPU0 if any PIC irq can not be migrated
out of it
80aa1df x86, Kconfig: Add config switch for CPU0 hotplug
f78cff4 doc: Add x86 CPU0 online/offline feature
Regards,
Srivatsa S. Bhat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body o
On 04/18/2013 08:43 PM, Srinivas Pandruvada wrote:
> On 04/18/2013 02:54 AM, Srivatsa S. Bhat wrote:
>> On 04/17/2013 10:23 PM, Srinivas Pandruvada wrote:
>>> On 04/09/2013 02:45 PM, Srivatsa S. Bhat wrote:
>>>> [I know, this cover letter is a little too long
On 04/19/2013 11:04 AM, Simon Jeons wrote:
> Hi Srivatsa,
> On 04/10/2013 05:45 AM, Srivatsa S. Bhat wrote:
>> [I know, this cover letter is a little too long, but I wanted to clearly
>> explain the overall goals and the high-level design of this patchset in
>> detail. I h
On 04/18/2013 10:40 PM, Dave Hansen wrote:
> On 04/09/2013 02:45 PM, Srivatsa S. Bhat wrote:
>> 2. Performance overhead is expected to be low: Since we retain the simplicity
>>of the algorithm in the page allocation path, page allocation can
>>potentially remain a
On 04/17/2013 10:23 PM, Srinivas Pandruvada wrote:
> On 04/09/2013 02:45 PM, Srivatsa S. Bhat wrote:
>> [I know, this cover letter is a little too long, but I wanted to clearly
>> explain the overall goals and the high-level design of this patchset in
>> detail. I hope th
On 04/17/2013 03:33 PM, Robin Holt wrote:
> On Wed, Apr 17, 2013 at 09:48:35AM +0200, Ingo Molnar wrote:
>>
>> * Robin Holt wrote:
>>
>>> On Tue, Apr 16, 2013 at 09:18:07PM +0530, Srivatsa S. Bhat wrote:
>>>> On 04/16/2013 05:36 PM, Robin Holt wrote:
>
801 - 900 of 1351 matches
Mail list logo