[PATCH v4 03/36] ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their connections

2017-02-15 Thread Steve Longerbeam
Zabel -- - Removed some dangling/unused endpoints (ipu2_csi0_from_csi2ipu) - Renamed the mipi virtual channel endpoint labels, from "mipi_csiX_..." to "mipi_vcX...". - Added input endpoint anchors to the video muxes for the connections from parallel sensors. Signed-off-

[PATCH v4 05/36] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-02-15 Thread Steve Longerbeam
oards that have the HW workaround for ERR006687") Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 4 1 file changed, 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelit

[PATCH v4 08/36] ARM: dts: imx6-sabreauto: create i2cmux for i2c3

2017-02-15 Thread Steve Longerbeam
X7310) are thus moved into i2cmux. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 65 +--- 1 file changed, 44 insertions(+), 21 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto

[PATCH v4 09/36] ARM: dts: imx6-sabreauto: add reset-gpios property for max7310_b

2017-02-15 Thread Steve Longerbeam
max7310_b, that chip is needed by more functions (usb and adv7180). Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi ind

[PATCH v4 15/36] platform: add video-multiplexer subdevice driver

2017-02-15 Thread Steve Longerbeam
but allows for it to be merged now, before adding the chaining support. Signed-off-by: Steve Longerbeam --- .../bindings/media/video-multiplexer.txt | 59 +++ drivers/media/platform/Kconfig | 8 + drivers/media/platform/Makefile| 2 + dri

[PATCH v4 25/36] ARM: imx_v6_v7_defconfig: Enable staging video4linux drivers

2017-02-15 Thread Steve Longerbeam
max zoneorder to allow larger video buffer allocations. Signed-off-by: Steve Longerbeam --- arch/arm/configs/imx_v6_v7_defconfig | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index

[PATCH v4 13/36] [media] v4l2: add a frame timeout event

2017-02-15 Thread Steve Longerbeam
Add a new FRAME_TIMEOUT event to signal that a video capture or output device has timed out waiting for reception or transmit completion of a video frame. Signed-off-by: Steve Longerbeam --- Documentation/media/uapi/v4l/vidioc-dqevent.rst | 5 + Documentation/media/videodev2

[PATCH v4 19/36] media: imx: Add Capture Device Interface

2017-02-15 Thread Steve Longerbeam
. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile| 2 +- drivers/staging/media/imx/imx-media-capture.c | 654 ++ 2 files changed, 655 insertions(+), 1 deletion(-) create mode 100644 drivers/staging/media/imx/imx-media-capture.c diff

[PATCH v4 34/36] media: imx: csi: add frame skipping support

2017-02-15 Thread Steve Longerbeam
From: Philipp Zabel The CSI can skip any out of up to 6 input frames, allowing to reduce the frame rate at the output pads by small fractions. Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 119 +- 1

[PATCH v4 36/36] media: imx: propagate sink pad formats to source pads

2017-02-15 Thread Steve Longerbeam
Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-ic-prp.c | 11 ++- drivers/staging/media/imx/imx-ic-prpencvf.c | 22 ++ drivers/staging/media/imx/imx-media-csi.c | 26 +- drivers/staging/media/imx/imx-media-vdic.c | 15

[PATCH v4 30/36] media: imx: update capture dev format on IDMAC output pad set_fmt

2017-02-15 Thread Steve Longerbeam
When configuring the IDMAC output pad formats (in ipu_csi, ipu_ic_prpenc, and ipu_ic_prpvf subdevs), the attached capture device format must also be updated. Signed-off-by: Steve Longerbeam Suggested-by: Philipp Zabel --- drivers/staging/media/imx/imx-ic-prpencvf.c | 9 + drivers

[PATCH v4 35/36] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-02-15 Thread Steve Longerbeam
From: Philipp Zabel The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 11 +-- 1 file

[PATCH v4 33/36] media: imx: redo pixel format enumeration and negotiation

2017-02-15 Thread Steve Longerbeam
(u32 *code, u32 index, enum codespace_sel cs_sel); The tables have been split into separate tables for YUV and RGB formats to support the implementation of the above. The subdev's .enum_mbus_code() and .set_fmt() operations have been rewritten using the above APIs. Signed-off-by: Steve Longe

[PATCH v4 31/36] media: imx: csi: add __csi_get_fmt

2017-02-15 Thread Steve Longerbeam
Add __csi_get_fmt() and use it to return the correct mbus format (active or try) in get_fmt. Use it in other places as well. Signed-off-by: Steve Longerbeam Suggested-by: Russell King --- drivers/staging/media/imx/imx-media-csi.c | 52 --- 1 file changed, 40

[PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-15 Thread Steve Longerbeam
Adds MIPI CSI-2 Receiver subdev driver. This subdev is required for sensors with a MIPI CSI2 interface. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile | 1 + drivers/staging/media/imx/imx6-mipi-csi2.c | 573 + 2 files changed, 574

[PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-15 Thread Steve Longerbeam
d-off-by: Russell King Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx6-mipi-csi2.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c b/drivers/staging/media/imx/imx6-mipi-csi2.c index 23dca80..c62f14e 1

[PATCH v4 32/36] media: imx: csi/fim: add support for frame intervals

2017-02-15 Thread Steve Longerbeam
Add support to CSI for negotiation of frame intervals, and use this information to configure the frame interval monitor. Signed-off-by: Russell King Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 36 --- drivers/staging/media/imx/imx

[PATCH v4 28/36] media: imx: csi: fix crop rectangle changes in set_fmt

2017-02-15 Thread Steve Longerbeam
ff-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 35 --- 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index ae24b42..3cb97e2 100644 --- a/dr

[PATCH v4 22/36] media: imx: Add IC subdev drivers

2017-02-15 Thread Steve Longerbeam
directly from the CSI or from the VDIC. Scaled output is limited to 1024x1024 resolution. Output frames are routed to the capture device. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/imx-ic-common.c | 113 +++ drivers

[PATCH v4 27/36] media: imx: csi: add support for bayer formats

2017-02-15 Thread Steve Longerbeam
: bayer formats and 16-bit parallel buses. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 50 ++- 1 file changed, 42 insertions(+), 8 deletions(-) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx

[PATCH v4 26/36] media: imx: add support for bayer formats

2017-02-15 Thread Steve Longerbeam
From: Russell King Add the bayer formats to imx-media's list of supported pixel and bus formats. Signed-off-by: Russell King - added a bayer boolean to struct imx_media_pixfmt. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-utils.c

[PATCH v4 21/36] media: imx: Add VDIC subdev driver

2017-02-15 Thread Steve Longerbeam
v4l2_set_subdevdata(&priv->sd, priv); + priv->sd.internal_ops = &vdic_internal_ops; + priv->sd.entity.ops = &vdic_entity_ops; + priv->sd.entity.function = MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER; + priv->sd.dev = &pdev->dev; + priv->sd.owner = THIS_MODULE; + priv->sd.flags = V4L2_SUBDEV_FL_HAS_DEVNODE; + /* get our group id */ + priv->sd.grp_id = pdata->grp_id; + strncpy(priv->sd.name, pdata->sd_name, sizeof(priv->sd.name)); + + return v4l2_async_register_subdev(&priv->sd); +} + +static int imx_vdic_remove(struct platform_device *pdev) +{ + struct v4l2_subdev *sd = platform_get_drvdata(pdev); + + v4l2_info(sd, "Removing\n"); + + v4l2_async_unregister_subdev(sd); + media_entity_cleanup(&sd->entity); + + return 0; +} + +static const struct platform_device_id imx_vdic_ids[] = { + { .name = "imx-ipuv3-vdic" }, + { }, +}; +MODULE_DEVICE_TABLE(platform, imx_vdic_ids); + +static struct platform_driver imx_vdic_driver = { + .probe = imx_vdic_probe, + .remove = imx_vdic_remove, + .id_table = imx_vdic_ids, + .driver = { + .name = "imx-ipuv3-vdic", + }, +}; +module_platform_driver(imx_vdic_driver); + +MODULE_DESCRIPTION("i.MX VDIC subdev driver"); +MODULE_AUTHOR("Steve Longerbeam "); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:imx-ipuv3-vdic"); -- 2.7.4

[PATCH v4 24/36] [media] add Omnivision OV5640 sensor driver

2017-02-15 Thread Steve Longerbeam
This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve Longerbeam --- .../devicetree/bindings/media/i2c/ov5640.txt | 43 + drivers/media/i2c/Kconfig

[PATCH v4 20/36] media: imx: Add CSI subdev driver

2017-02-15 Thread Steve Longerbeam
This is a media entity subdevice for the i.MX Camera Sensor Interface module. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Kconfig | 13 + drivers/staging/media/imx/Makefile|2 + drivers/staging/media/imx/imx-media-csi.c | 1220

[PATCH v4 18/36] media: Add i.MX media core driver

2017-02-15 Thread Steve Longerbeam
Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam --- Documentation/media/v4l-drivers/imx.rst | 542 + drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile| 1 + drivers/staging/media/imx

[PATCH v4 17/36] media: Add userspace header file for i.MX

2017-02-15 Thread Steve Longerbeam
This adds a header file for use by userspace programs wanting to interact with the i.MX media driver. It defines custom v4l2 controls and events generated by the i.MX v4l2 subdevices. Signed-off-by: Steve Longerbeam --- include/uapi/media/Kbuild | 1 + include/uapi/media/imx.h | 29

[PATCH v4 11/36] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

2017-02-15 Thread Steve Longerbeam
Enables the ADV7180 decoder sensor. The ADV7180 connects to the parallel-bus mux input on ipu1_csi0_mux. The ADV7180 power pin is via max7310_b port expander. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 58 1 file changed, 58

[PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-02-15 Thread Steve Longerbeam
v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities in a pipeline to a given video device. Signed-off-by: Steve Longerbeam --- drivers/media/v4l2-core/v4l2-mc.c | 48 +++ include/media/v4l2-mc.h | 25

[PATCH v4 16/36] UAPI: Add media UAPI Kbuild file

2017-02-15 Thread Steve Longerbeam
Add an empty UAPI Kbuild file for media UAPI headers. Signed-off-by: Steve Longerbeam --- include/uapi/Kbuild | 1 + include/uapi/media/Kbuild | 1 + 2 files changed, 2 insertions(+) create mode 100644 include/uapi/media/Kbuild diff --git a/include/uapi/Kbuild b/include/uapi/Kbuild

[PATCH v4 12/36] add mux and video interface bridge entity functions

2017-02-15 Thread Steve Longerbeam
From: Philipp Zabel Signed-off-by: Philipp Zabel - renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX Signed-off-by: Steve Longerbeam --- Documentation/media/uapi/mediactl/media-types.rst | 22 ++ include/uapi/linux/media.h| 6 ++ 2 files changed

[PATCH v4 10/36] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

2017-02-15 Thread Steve Longerbeam
Add pinctrl groups for both GPT input capture channels. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi index

[PATCH v4 07/36] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

2017-02-15 Thread Steve Longerbeam
Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. The OV5640 connects to the input port on the MIPI CSI-2 receiver on mipi_csi. Until the OV5652 sensor module compatible with the SabreSD becomes avai

[PATCH v4 06/36] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-02-15 Thread Steve Longerbeam
-2 receiver on mipi_csi. The OV5642 node is disabled temporarily while the subdev driver is cleaned up and submitted later. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6dl-sabrelite.dts | 5 ++ arch/arm/boot/dts/imx6q-sabrelite.dts| 5 ++ arch/arm/boot/dts/imx6qdl

[PATCH v4 04/36] ARM: dts: imx6qdl: add capture-subsystem device

2017-02-15 Thread Steve Longerbeam
Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6dl.dtsi | 5 + arch/arm/boot/dts/imx6q.dtsi | 5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi index 371288a..f1743fc 100644 --- a/arch/arm/boot/dts/imx6dl.dtsi

[PATCH v4 01/36] [media] dt-bindings: Add bindings for i.MX media driver

2017-02-15 Thread Steve Longerbeam
Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 66 + 1 file changed, 66 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx.txt diff --git a

Re: [PATCH v4 32/36] media: imx: csi/fim: add support for frame intervals

2017-02-15 Thread Steve Longerbeam
Sorry, I forgot to change authorship on this patch. It should be authored by Russell King . Steve On 02/15/2017 06:19 PM, Steve Longerbeam wrote: Add support to CSI for negotiation of frame intervals, and use this information to configure the frame interval monitor. Signed-off-by: Russell

Re: [PATCH v4 18/36] media: Add i.MX media core driver

2017-02-16 Thread Steve Longerbeam
On 02/16/2017 02:27 AM, Russell King - ARM Linux wrote: On Wed, Feb 15, 2017 at 06:19:20PM -0800, Steve Longerbeam wrote: Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam Just as I reported on the 30th January: Applying: media: Add i.MX media core driver .git/rebase

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-16 Thread Steve Longerbeam
On 02/16/2017 02:28 AM, Russell King - ARM Linux wrote: On Wed, Feb 15, 2017 at 06:19:25PM -0800, Steve Longerbeam wrote: Adds MIPI CSI-2 Receiver subdev driver. This subdev is required for sensors with a MIPI CSI2 interface. Signed-off-by: Steve Longerbeam Just like I reported on the

Re: [PATCH v4 28/36] media: imx: csi: fix crop rectangle changes in set_fmt

2017-02-16 Thread Steve Longerbeam
On 02/16/2017 03:05 AM, Russell King - ARM Linux wrote: On Wed, Feb 15, 2017 at 06:19:30PM -0800, Steve Longerbeam wrote: diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index ae24b42..3cb97e2 100644 --- a/drivers/staging/media/imx/imx-media

Re: [PATCH v4 36/36] media: imx: propagate sink pad formats to source pads

2017-02-16 Thread Steve Longerbeam
On 02/16/2017 03:29 AM, Philipp Zabel wrote: On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: [...] diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c index dd9d499..c43f85f 100644 --- a/drivers/staging/media/imx/imx-ic-prpencvf.c

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-16 Thread Steve Longerbeam
On 02/16/2017 03:37 AM, Russell King - ARM Linux wrote: Two problems. On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote: media: imx: propagate sink pad formats to source pads 1) It looks like all cases aren't being caught: - entity 74: ipu1_csi0 (3 pads, 4

Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver

2017-02-16 Thread Steve Longerbeam
On 02/16/2017 04:40 AM, Russell King - ARM Linux wrote: On Thu, Feb 16, 2017 at 11:52:06AM +, Russell King - ARM Linux wrote: On Wed, Feb 15, 2017 at 06:19:22PM -0800, Steve Longerbeam wrote: +static const struct platform_device_id imx_csi_ids[] = { + { .name = "imx-ipuv

Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver

2017-02-16 Thread Steve Longerbeam
On 02/16/2017 06:20 AM, Russell King - ARM Linux wrote: On Thu, Feb 16, 2017 at 01:09:35PM +, Russell King - ARM Linux wrote: More crap. If the "complete" method fails (or, in fact, anything in v4l2_async_test_notify() fails) then all hell breaks loose, because of the total lack of clea

Re: [PATCH v4 01/36] [media] dt-bindings: Add bindings for i.MX media driver

2017-02-16 Thread Steve Longerbeam
On 02/16/2017 03:54 AM, Philipp Zabel wrote: On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 66 + 1 file changed

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-16 Thread Steve Longerbeam
On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote: On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote: In version 4: With this version, I get: [28762.892053] imx6-mipi-csi2: LP-11 timeout, phy_state = 0x [28762.899409] ipu1_csi0: pipeline_set_stream failed with

Re: [PATCH v4 07/36] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

2017-02-16 Thread Steve Longerbeam
On 02/16/2017 04:51 PM, Fabio Estevam wrote: Hi Steve, On Thu, Feb 16, 2017 at 12:19 AM, Steve Longerbeam wrote: Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. The OV5640 connects to the

Re: [PATCH v4 18/36] media: Add i.MX media core driver

2017-02-16 Thread Steve Longerbeam
On 02/16/2017 05:02 AM, Philipp Zabel wrote: On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: + +- Clean up and move the ov5642 subdev driver to drivers/media/i2c, and + create the binding docs for it. This is done already, right? I cleaned up ov5640 and moved it to drivers

Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver

2017-02-12 Thread Steve Longerbeam
(resending text only) On 02/02/2017 02:36 AM, Laurent Pinchart wrote: Hi Steve, Thank you for the patch. Many of the comments below apply to the ov5642 driver too, please take them into account when reworking patch 23/24. On Friday 06 Jan 2017 18:11:40 Steve Longerbeam wrote: This driver is

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-13 Thread Steve Longerbeam
(#!##* Thunderbird! resending text only) Hi Philipp, On 02/13/2017 01:20 AM, Philipp Zabel wrote: Hi Steve, On Thu, 2017-02-09 at 15:51 -0800, Steve Longerbeam wrote: On 02/09/2017 03:49 PM, Steve Longerbeam wrote: On 02/08/2017 03:42 PM, Russell King - ARM Linux wrote: On Wed, Feb 08

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-17 Thread Steve Longerbeam
On 02/17/2017 06:16 AM, Philipp Zabel wrote: On Fri, 2017-02-17 at 11:47 +0100, Philipp Zabel wrote: On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: +static void csi2_dphy_init(struct csi2_dev *csi2) +{ + /* +* FIXME: 0x14 is derived from a fixed D-PHY reference

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-17 Thread Steve Longerbeam
On 02/15/2017 06:19 PM, Steve Longerbeam wrote: From: Russell King Setting and getting frame rates is part of the negotiation mechanism between subdevs. The lack of support means that a frame rate at the sensor can't be negotiated through the subdev path. Add support at MIPI CSI2 leve

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-17 Thread Steve Longerbeam
On 02/15/2017 06:19 PM, Steve Longerbeam wrote: From: Russell King Setting and getting frame rates is part of the negotiation mechanism between subdevs. The lack of support means that a frame rate at the sensor can't be negotiated through the subdev path. Add support at MIPI CSI2 leve

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-18 Thread Steve Longerbeam
On 02/18/2017 01:23 AM, Russell King - ARM Linux wrote: On Fri, Feb 17, 2017 at 05:12:44PM -0800, Steve Longerbeam wrote: Hi Russell, I signed-off on this but after more review I'm not sure this is right. The CSI-2 receiver really has no control over frame rate. It's output fra

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-18 Thread Steve Longerbeam
On 02/16/2017 02:57 PM, Russell King - ARM Linux wrote: On Thu, Feb 16, 2017 at 02:27:41PM -0800, Steve Longerbeam wrote: On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote: On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote: In version 4: With this version, I get

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-20 Thread Steve Longerbeam
On 02/20/2017 02:04 PM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: From: Russell King Setting and getting frame rates is part of the negotiation mechanism between subdevs. The lack of support means that a frame rate at the sensor can&#

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-20 Thread Steve Longerbeam
On 02/20/2017 02:56 PM, Steve Longerbeam wrote: On 02/20/2017 02:04 PM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: From: Russell King Setting and getting frame rates is part of the negotiation mechanism between subdevs. The lack of

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-20 Thread Steve Longerbeam
On 02/20/2017 04:13 PM, Russell King - ARM Linux wrote: On Tue, Feb 21, 2017 at 12:04:10AM +0200, Sakari Ailus wrote: On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: From: Russell King Setting and getting frame rates is part of the negotiation mechanism between subdevs

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-06 Thread Steve Longerbeam
On 02/06/2017 02:33 PM, Laurent Pinchart wrote: Hi Hans, (CC'ing Sakari) On Monday 06 Feb 2017 10:50:22 Hans Verkuil wrote: On 02/05/2017 04:48 PM, Laurent Pinchart wrote: On Tuesday 24 Jan 2017 18:07:55 Steve Longerbeam wrote: On 01/24/2017 04:02 AM, Philipp Zabel wrote: On Fri, 20

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

2017-02-06 Thread Steve Longerbeam
On 02/02/2017 02:35 PM, Russell King - ARM Linux wrote: However, "*vfd" contains a struct device, and you _correctly_ set the release function for "*vfd" to video_device_release via camif_videodev. However, if you try to rmmod imx-media, then you end up with a kernel warning that you're freein

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-02-06 Thread Steve Longerbeam
On 02/02/2017 02:50 PM, Russell King - ARM Linux wrote: On Fri, Jan 06, 2017 at 06:11:34PM -0800, Steve Longerbeam wrote: +/* register an internal subdev as a platform device */ +static struct imx_media_subdev * +add_internal_subdev(struct imx_media_dev *imxmd, + const

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-08 Thread Steve Longerbeam
On 02/02/2017 03:50 AM, Philipp Zabel wrote: + struct v4l2_subdev *src_sd; + struct v4l2_subdev *sink_sd[CSI2_NUM_SRC_PADS]; I see no reason to store pointers to the remote v4l2_subdevs. + intinput_pad; + struct clk *dphy_clk;

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-09 Thread Steve Longerbeam
On 02/08/2017 03:42 PM, Russell King - ARM Linux wrote: On Wed, Feb 08, 2017 at 03:23:53PM -0800, Steve Longerbeam wrote: Actually, this exact function already exists as dw_mipi_dsi_phy_write in drivers/gpu/drm/rockchip/dw-mipi-dsi.c, and it looks like the D-PHY register 0x44 might contain a

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-09 Thread Steve Longerbeam
On 02/09/2017 03:49 PM, Steve Longerbeam wrote: On 02/08/2017 03:42 PM, Russell King - ARM Linux wrote: On Wed, Feb 08, 2017 at 03:23:53PM -0800, Steve Longerbeam wrote: Actually, this exact function already exists as dw_mipi_dsi_phy_write in drivers/gpu/drm/rockchip/dw-mipi-dsi.c, and it

[PATCH v2] gpio: pca953x: Add optional reset gpio control

2017-01-10 Thread Steve Longerbeam
Add optional reset-gpios pin control. If present, de-assert the specified reset gpio pin to bring the chip out of reset. Signed-off-by: Steve Longerbeam Cc: Linus Walleij Cc: Alexandre Courbot Cc: linux-g...@vger.kernel.org Cc: linux-kernel@vger.kernel.org -- v2: - Specify that reset signal

[PATCH v2] pca953x: Add optional reset gpio control

2017-01-10 Thread Steve Longerbeam
In version 2: - Specify that reset signal to PCA953x chip is active low, in binding doc. - reorder includes in gpio-pca953x.c. - remove dev_err() on devm_gpiod_get_optional() error return. Steve Longerbeam (1): gpio: pca953x: Add optional reset gpio control Documentation/devicetree

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-11 Thread Steve Longerbeam
Hi Tim, On 01/11/2017 03:14 PM, Tim Harvey wrote: Hi Steve, I took a stab at testing this today on a gw51xx which has an adv7180 hooked up as follows: - i2c3@0x20 - 8bit data bus from DAT12 to DAT19, HSYNC, VSYNC, PIXCLK on CSI0 pads (CSI0_IPU1) - PWRDWN# on MX6QDL_PAD_CSI0_DATA_EN__GPIO5_I

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-02 Thread Steve Longerbeam
Hi Russell, I don't recommend spending too much time debugging this OOPS. The dma buffer ring has been removed completely in version 4 (which I'm trying to get ready to post hopefully by end of this week). Steve On 02/02/2017 09:22 AM, Russell King - ARM Linux wrote: I seem to be getting some

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-02 Thread Steve Longerbeam
On 02/02/2017 09:56 AM, Russell King - ARM Linux wrote: On Thu, Feb 02, 2017 at 05:22:46PM +, Russell King - ARM Linux wrote: I thought, maybe, it's the IPU overwriting past the end of the buffer, but I've added checks and that doesn't seem to have fired. I also wondered if it was some ki

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-02 Thread Steve Longerbeam
On 02/02/2017 10:58 AM, Russell King - ARM Linux wrote: On Thu, Feb 02, 2017 at 10:26:55AM -0800, Steve Longerbeam wrote: On 02/02/2017 09:56 AM, Russell King - ARM Linux wrote: and for whatever reason we end up falling out through free_ring. This is VERY bad news, because it means that the

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-03 Thread Steve Longerbeam
On 02/03/2017 06:41 AM, Laurent Pinchart wrote: Hello, On Wednesday 01 Feb 2017 16:19:27 Steve Longerbeam wrote: On 02/01/2017 01:30 AM, Philipp Zabel wrote: media-ctl propagates the output pad format to all remote subdevices' input pads for all enabled links: https://git.linuxtv.or

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-03 Thread Steve Longerbeam
On 02/02/2017 02:29 PM, Russell King - ARM Linux wrote: On Thu, Feb 02, 2017 at 11:12:41AM -0800, Steve Longerbeam wrote: Here is the current .queue_setup() op in imx-media-capture.c: static int capture_queue_setup(struct vb2_queue *vq, unsigned int *nbuffers

Re: [PATCH v3 01/12] gpu: ipu-cpmem: Add ipu_cpmem_set_uv_offset()

2016-08-01 Thread Steve Longerbeam
On 08/01/2016 02:13 AM, Philipp Zabel wrote: > Am Sonntag, den 31.07.2016, 12:42 -0700 schrieb Steve Longerbeam: >> Adds ipu_cpmem_set_uv_offset(), to set planar U/V offsets. >> >> Signed-off-by: Steve Longerbeam > There is no need to resend already applied patches. >

Re: [PATCH v3 10/12] gpu: ipu-v3: Add FSU channel linking support

2016-08-01 Thread Steve Longerbeam
On 08/01/2016 02:13 AM, Philipp Zabel wrote: > Am Sonntag, den 31.07.2016, 12:42 -0700 schrieb Steve Longerbeam: >> Adds functions to link and unlink source channels to sink >> channels in the FSU: >> >> int ipu_fsu_link(struct ipu_soc *ipu, int src_ch, int sink_ch); &

Re: [PATCH v3 09/12] gpu: ipu-v3: Add Video Deinterlacer unit

2016-08-01 Thread Steve Longerbeam
On 08/01/2016 02:13 AM, Philipp Zabel wrote: > > Please remove the unused headers. I think you can remove all but > export.h, types.h, errno.h, and io.h. > Other than that, the patch now looks fine to me. > I was able to prune all but io.h, the rest is provided by ipu-prv.h. Steve

[PATCH v4 1/8] media: adv7180: fix field type

2016-08-03 Thread Steve Longerbeam
From: Steve Longerbeam The ADV7180 and ADV7182 transmit whole fields, bottom field followed by top (or vice-versa, depending on detected video standard). So for chips that do not have support for explicitly setting the field mode via I2P, set the field mode to V4L2_FIELD_ALTERNATE. Signed-off

[PATCH v4 7/8] v4l: Add signal lock status to source change events

2016-08-03 Thread Steve Longerbeam
Add a signal lock status change to the source changes bitmask. This indicates there was a signal lock or unlock event detected at the input of a video decoder. Signed-off-by: Steve Longerbeam Cc: Mauro Carvalho Chehab --- v4: - converted to rst from DocBook v3: no changes v2: no changes

[PATCH v4 0/8] adv7180 subdev fixes, v4

2016-08-03 Thread Steve Longerbeam
Steve Longerbeam (8): media: adv7180: fix field type media: adv7180: define more registers media: adv7180: add support for NEWAVMODE media: adv7180: add power pin control media: adv7180: implement g_parm media: adv7180: change mbus format to UYVY v4l: Add signal lock status to source

[PATCH v4 5/8] media: adv7180: implement g_parm

2016-08-03 Thread Steve Longerbeam
Implement g_parm to return the current standard's frame period. Signed-off-by: Steve Longerbeam Tested-by: Tim Harvey Acked-by: Tim Harvey --- v4: no changes v3: no changes v2: no changes --- drivers/media/i2c/adv7180.c | 22 ++ 1 file changed, 22 insertions(+)

[PATCH v4 4/8] media: adv7180: add power pin control

2016-08-03 Thread Steve Longerbeam
Some targets control the ADV7180 power pin via a gpio, so add optional support for "powerdown" pin control. Signed-off-by: Steve Longerbeam Tested-by: Tim Harvey Acked-by: Tim Harvey Acked-by: Lars-Peter Clausen --- v4: no changes v3: no changes v2: - placed call to gpiod_get

[PATCH v4 8/8] media: adv7180: enable lock/unlock interrupts

2016-08-03 Thread Steve Longerbeam
Enable the SD lock/unlock interrupts and send V4L2_EVENT_SRC_CH_LOCK_STATUS in the interrupt handler on a detected lock/unlock. Signed-off-by: Steve Longerbeam --- v4: no changes v3: no changes v2: - last version of this patch was based on the old reverted autodetect code. This version now

[PATCH v4 6/8] media: adv7180: change mbus format to UYVY

2016-08-03 Thread Steve Longerbeam
Change the media bus format from YUYV8_2X8 to UYVY8_2X8. Colors now look correct when capturing with the i.mx6 backend. Signed-off-by: Steve Longerbeam Tested-by: Tim Harvey Acked-by: Tim Harvey Acked-by: Lars-Peter Clausen Acked-by: Niklas Söderlund --- v4: no changes v3: no changes v2: no

[PATCH v4 3/8] media: adv7180: add support for NEWAVMODE

2016-08-03 Thread Steve Longerbeam
Parse the optional v4l2 endpoint DT node. If the bus type is V4L2_MBUS_BT656 and the endpoint node specifies "newavmode", configure the BT.656 bus in NEWAVMODE. Signed-off-by: Steve Longerbeam --- v4: no changes v3: - the newavmode endpoint property is now private

[PATCH v4 2/8] media: adv7180: define more registers

2016-08-03 Thread Steve Longerbeam
Replace hard-coded addresses with new register macro defines. No functional changes. Signed-off-by: Steve Longerbeam Acked-by: Lars-Peter Clausen --- v4: no changes v3: no changes --- drivers/media/i2c/adv7180.c | 73 ++--- 1 file changed, 49 insertions

Re: [PATCH v2 11/13] gpu: ipu-ic: Add complete image conversion support with tiling

2016-08-03 Thread Steve Longerbeam
On 08/01/2016 02:29 AM, Philipp Zabel wrote: > Am Donnerstag, den 28.07.2016, 16:09 -0700 schrieb Steve Longerbeam: >>> Now split the frame in half and suddenly pixel x' = 640 is the start of >>> a new tile, so it is sampled at x = 160, and pixel x' = 1279 will be

Re: [PATCH 12/16] gpu: ipu-v3: Fix CSI0 blur in NTSC format

2016-07-10 Thread Steve Longerbeam
On 07/08/2016 10:34 AM, Philipp Zabel wrote: Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: From: Suresh Dhandapani This patch will change the register IPU_CSI0_CCIR_CODE_2 value from 0x40596 to 0x405A6. The change is related to the Start of field 1 first blanking line

[PATCH v4 2/4] gpu: ipu-v3: Add FSU channel linking support

2016-08-17 Thread Steve Longerbeam
SI_DIRECT -> IPUV3_CHANNEL_CSI_VDI_PREV More links can be added to the fsu_link_info[] array. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-common.c | 131 drivers/gpu/ipu-v3/ipu-prv.h| 27 + include/video/imx-ipu-v3.h | 13 3 files changed, 17

[PATCH v4 0/4] IPUv3 prep for i.MX5/6 v4l2 staging drivers, v4

2016-08-17 Thread Steve Longerbeam
. Steve Longerbeam (4): gpu: ipu-v3: Add Video Deinterlacer unit gpu: ipu-v3: Add FSU channel linking support gpu: ipu-ic: Add complete image conversion support with tiling gpu: ipu-ic: allow multiple handles to ic drivers/gpu/ipu-v3/Makefile |2 +- drivers/gpu/ipu-v3/ipu-common.c

[PATCH v4 1/4] gpu: ipu-v3: Add Video Deinterlacer unit

2016-08-17 Thread Steve Longerbeam
Adds the Video Deinterlacer (VDIC) unit. Signed-off-by: Steve Longerbeam --- v4: - pruned included headers. v3: - renamed and exported ipu_vdi_set_top_field_man() to ipu_vdi_set_field_order(). Args include std and field to determine correct field order. - exported ipu_vdi_set_motion

[PATCH v4 3/4] gpu: ipu-ic: Add complete image conversion support with tiling

2016-08-17 Thread Steve Longerbeam
void ipu_image_convert_unprepare(struct image_converter_ctx *ctx); Unprepares the conversion context. Any active or pending runs will be aborted by calling image_convert_abort(). Signed-off-by: Steve Longerbeam --- v4: - do away with struct ipu_ic_tile_off, and move tile offsets into struct ipu_ic

[PATCH v4 4/4] gpu: ipu-ic: allow multiple handles to ic

2016-08-17 Thread Steve Longerbeam
handle to the IC at a time, so we should be ok there. Signed-off-by: Steve Longerbeam --- v4: no changes v3: no changes v2: no changes --- drivers/gpu/ipu-v3/ipu-ic.c | 25 + 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-ic.c b/drivers

Re: [PATCH 1/3] v4l2-subdev: Add subdev ioctl support for ENUM/GET/SET INPUT

2020-06-25 Thread Steve Longerbeam
Hi Laurent, all, On 6/24/20 7:01 PM, Laurent Pinchart wrote: Hi Jacopo, On Wed, Jun 24, 2020 at 09:53:07AM +0200, Jacopo Mondi wrote: On Tue, Jun 16, 2020 at 12:00:15PM +0200, Ramzi BEN MEFTAH wrote: From: Steve Longerbeam +Niklas, +Laurent Niklas, Laurent, how does this play with

Re: [PATCH] media: rcar-vin: Move media_device_register to async completion

2020-06-17 Thread Steve Longerbeam
: From: Steve Longerbeam The media_device is registered during driver probe, before async completion, so it is possible for .link_notify to be called before all devices are bound. Fix this by moving media_device_register() to rvin_group_notify_complete(). This ensures that all devices are now bound

Re: [PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver

2017-03-28 Thread Steve Longerbeam
On 03/28/2017 05:21 PM, Rob Herring wrote: On Mon, Mar 27, 2017 at 7:40 PM, Steve Longerbeam wrote: Add bindings documentation for the i.MX media driver. + +mipi_csi2 node +-- + +This is the device node for the MIPI CSI-2 Receiver, required for MIPI +CSI-2 sensors. + +Required

Re: [RFC 2/2] mux: mmio-based syscon mux controller

2017-04-19 Thread Steve Longerbeam
On 04/19/2017 08:27 AM, Philipp Zabel wrote: On Wed, 2017-04-19 at 13:58 +0200, Peter Rosin wrote: On 2017-04-19 13:50, Philipp Zabel wrote: On Thu, 2017-04-13 at 18:09 -0700, Steve Longerbeam wrote: On 04/13/2017 08:48 AM, Philipp Zabel wrote: This adds a driver for mmio-based syscon

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-04 Thread Steve Longerbeam
On 03/30/2017 10:25 AM, Philipp Zabel wrote: The TVP5150 DT bindings specify a single output port (port 0) that corresponds to the video output pad (pad 1, DEMOD_PAD_VID_OUT). Signed-off-by: Philipp Zabel --- I'm trying to get this to work with a TVP5150 analog TV decoder, and the first probl

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-04 Thread Steve Longerbeam
On 04/04/2017 04:10 PM, Russell King - ARM Linux wrote: On Thu, Mar 30, 2017 at 07:25:49PM +0200, Philipp Zabel wrote: The TVP5150 DT bindings specify a single output port (port 0) that corresponds to the video output pad (pad 1, DEMOD_PAD_VID_OUT). Signed-off-by: Philipp Zabel --- I'm tryin

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-04 Thread Steve Longerbeam
On 04/04/2017 05:40 PM, Steve Longerbeam wrote: On 04/04/2017 04:10 PM, Russell King - ARM Linux wrote: On Thu, Mar 30, 2017 at 07:25:49PM +0200, Philipp Zabel wrote: The TVP5150 DT bindings specify a single output port (port 0) that corresponds to the video output pad (pad 1

Re: [PATCH v6 19/39] media: Add i.MX media core driver

2017-04-06 Thread Steve Longerbeam
On 04/06/2017 02:43 AM, Philipp Zabel wrote: On Mon, 2017-03-27 at 17:40 -0700, Steve Longerbeam wrote: Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam [...] diff --git a/drivers/staging/media/imx/imx-media-of.c b/drivers/staging/media/imx/imx-media-of.c new file

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

2017-04-11 Thread Steve Longerbeam
On 04/04/2017 05:47 AM, Sakari Ailus wrote: Hi Steve, Philipp and Pavel, On Mon, Mar 27, 2017 at 05:40:34PM -0700, Steve Longerbeam wrote: From: Philipp Zabel This driver can handle SoC internal and external video bus multiplexers, controlled either by register bit fields or by a GPIO. The

Re: [PATCH v6 00/39] i.MX Media Driver

2017-03-30 Thread Steve Longerbeam
On 03/30/2017 04:02 AM, Russell King - ARM Linux wrote: This fails at step 1. The removal of the frame interval support now means my setup script fails when trying to set the frame interval on the camera: Enumerating pads and links Setting up format SRGGB8_1X8 816x616 on pad imx219 0-0010/0 F

<    2   3   4   5   6   7   8   9   >