Re: [-mm Patch] INFINIBAND: check the return value of kmalloc

2007-07-09 Thread Steve Wise
Looks good. Roland Dreier wrote: thanks, I added Jesper's suggestion to the original patch and queued this for 2.6.23: (Steve, let me know if this looks OK or not to you) commit 8d339921a2cb279457dce79f8a308978e0b41b27 Author: WANG Cong <[EMAIL PROTECTED]> Date: Thu Jul 5 14:40:32 2007

Re: [-mm Patch] INFINIBAND: check the return value of kmalloc

2007-07-09 Thread Steve Wise
Looks good. Roland Dreier wrote: thanks, I added Jesper's suggestion to the original patch and queued this for 2.6.23: (Steve, let me know if this looks OK or not to you) commit 8d339921a2cb279457dce79f8a308978e0b41b27 Author: WANG Cong [EMAIL PROTECTED] Date: Thu Jul 5 14:40:32 2007 -0700

Re: [PATCH 0/6] iw_cxgb3: Bug Fixes for 2.6.23

2007-06-27 Thread Steve Wise
Roland Dreier wrote: > Here are some bug fixes to the iw_cxgb3 driver that I'd like included > for 2.6.23. NOTE: Patch 1 requires a firmware interface change, so > there is a version bump to 4.3 included in that patch that hits cxgb3. > This will likely conflict with a previous version

[PATCH 5/6] iw_cxgb3: Don't post TID_RELEASE message.

2007-06-27 Thread Steve Wise
iw_cxgb3: Don't post TID_RELEASE message. The LLD does this for us in cxgb3_remove_tid(). Also fixed active open failure cases where we shouldn't be releasing the TID as well. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_cm.c | 13 ++

[PATCH 6/6] iw_cxgb3: Don't abort after failures sending the mpa reply.

2007-06-27 Thread Steve Wise
() must not abort a connection if an error is returned after being awakened. If any errors did occur while iwch_accept_cr() is blocked, then the connection has already been aborted on the thread processing the error. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw

[PATCH 3/6] iw_cxgb3: Don't count neg_adv abort_req_rss messages as real aborts.

2007-06-27 Thread Steve Wise
iw_cxgb3: Don't count neg_adv abort_req_rss messages as real aborts. negative advice messages should _not_ count toward the 2 abort requests needed to indicate an abort request. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_cm.c | 14 +++

[PATCH 4/6] iw_cxgb3: ctrl-qp init/clear shouldn't set the gen bit.

2007-06-27 Thread Steve Wise
iw_cxgb3: ctrl-qp init/clear shouldn't set the gen bit. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/cxio_hal.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw

[PATCH 2/6] iw_cxgb3: TERMINATE WRs can hang the tx ofld queue.

2007-06-27 Thread Steve Wise
iw_cxgb3: TERMINATE WRs can hang the tx ofld queue. Don't set the gen bits nor length bits in the terminate wr. This is done by the LLD driver. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_qp.c |6 +++--- 1 files changed, 3 insertions(+), 3 del

[PATCH 1/6] iw_cxgb3: Streaming -> RDMA mode transition fixes.

2007-06-27 Thread Steve Wise
nge also bumps the required firmware version to 4.3. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/cxio_hal.c |2 - drivers/infiniband/hw/cxgb3/cxio_wr.h |3 + drivers/infiniband/hw/cxgb3/iwch_cm.c | 82 drivers/infi

[PATCH 0/6] iw_cxgb3: Bug Fixes for 2.6.23

2007-06-27 Thread Steve Wise
Hey Roland, Here are some bug fixes to the iw_cxgb3 driver that I'd like included for 2.6.23. NOTE: Patch 1 requires a firmware interface change, so there is a version bump to 4.3 included in that patch that hits cxgb3. This will likely conflict with a previous version change that is in Jeff's

[PATCH 0/6] iw_cxgb3: Bug Fixes for 2.6.23

2007-06-27 Thread Steve Wise
Hey Roland, Here are some bug fixes to the iw_cxgb3 driver that I'd like included for 2.6.23. NOTE: Patch 1 requires a firmware interface change, so there is a version bump to 4.3 included in that patch that hits cxgb3. This will likely conflict with a previous version change that is in Jeff's

[PATCH 1/6] iw_cxgb3: Streaming - RDMA mode transition fixes.

2007-06-27 Thread Steve Wise
also bumps the required firmware version to 4.3. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/cxio_hal.c |2 - drivers/infiniband/hw/cxgb3/cxio_wr.h |3 + drivers/infiniband/hw/cxgb3/iwch_cm.c | 82 drivers/infiniband/hw

[PATCH 2/6] iw_cxgb3: TERMINATE WRs can hang the tx ofld queue.

2007-06-27 Thread Steve Wise
iw_cxgb3: TERMINATE WRs can hang the tx ofld queue. Don't set the gen bits nor length bits in the terminate wr. This is done by the LLD driver. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_qp.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions

[PATCH 3/6] iw_cxgb3: Don't count neg_adv abort_req_rss messages as real aborts.

2007-06-27 Thread Steve Wise
iw_cxgb3: Don't count neg_adv abort_req_rss messages as real aborts. negative advice messages should _not_ count toward the 2 abort requests needed to indicate an abort request. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_cm.c | 14 +++--- 1

[PATCH 4/6] iw_cxgb3: ctrl-qp init/clear shouldn't set the gen bit.

2007-06-27 Thread Steve Wise
iw_cxgb3: ctrl-qp init/clear shouldn't set the gen bit. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/cxio_hal.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3

[PATCH 5/6] iw_cxgb3: Don't post TID_RELEASE message.

2007-06-27 Thread Steve Wise
iw_cxgb3: Don't post TID_RELEASE message. The LLD does this for us in cxgb3_remove_tid(). Also fixed active open failure cases where we shouldn't be releasing the TID as well. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_cm.c | 13 ++--- 1 files

[PATCH 6/6] iw_cxgb3: Don't abort after failures sending the mpa reply.

2007-06-27 Thread Steve Wise
() must not abort a connection if an error is returned after being awakened. If any errors did occur while iwch_accept_cr() is blocked, then the connection has already been aborted on the thread processing the error. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3

Re: [PATCH 0/6] iw_cxgb3: Bug Fixes for 2.6.23

2007-06-27 Thread Steve Wise
Roland Dreier wrote: Here are some bug fixes to the iw_cxgb3 driver that I'd like included for 2.6.23. NOTE: Patch 1 requires a firmware interface change, so there is a version bump to 4.3 included in that patch that hits cxgb3. This will likely conflict with a previous version change

cxgb3 regression in 2.6.22-rc5

2007-06-18 Thread Steve Wise
I get this crash running the chelsio cxgb3 module on 2.6.22-rc5. This is regression. I believe Divy from Chelsio has already posted a fix for this. This needs to be in 2.6.22... Jeff do you have this fix queued for 2.6.22? I think Divy's patches are here:

cxgb3 regression in 2.6.22-rc5

2007-06-18 Thread Steve Wise
I get this crash running the chelsio cxgb3 module on 2.6.22-rc5. This is regression. I believe Divy from Chelsio has already posted a fix for this. This needs to be in 2.6.22... Jeff do you have this fix queued for 2.6.22? I think Divy's patches are here:

Re: [PATCH 2.6.22 5/5] iw_cxgb3: Update required firmware revision to 4.0.0.

2007-04-27 Thread Steve Wise
On Thu, 2007-04-26 at 20:12 -0700, Roland Dreier wrote: > > Update required firmware revision to 4.0.0. > > Hmm... should we fold this into the earlier patch, which actually > needs this new FW? Or at least merge this patch first? > I separated it only because cxgb3 is maintained by Jeff.

Re: [PATCH 2.6.22 5/5] iw_cxgb3: Update required firmware revision to 4.0.0.

2007-04-27 Thread Steve Wise
On Thu, 2007-04-26 at 20:12 -0700, Roland Dreier wrote: Update required firmware revision to 4.0.0. Hmm... should we fold this into the earlier patch, which actually needs this new FW? Or at least merge this patch first? I separated it only because cxgb3 is maintained by Jeff. Feel

[PATCH 2.6.22 2/5] iw_cxgb3: Fail qp creation if the requested max_inline is too large.

2007-04-26 Thread Steve Wise
Fail qp creation if the requested max_inline is too large. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/cxio_wr.h |1 + drivers/infiniband/hw/cxgb3/iwch_provider.c |3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/d

[PATCH 2.6.22 5/5] iw_cxgb3: Update required firmware revision to 4.0.0.

2007-04-26 Thread Steve Wise
Update required firmware revision to 4.0.0. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/net/cxgb3/version.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/cxgb3/version.h b/drivers/net/cxgb3/version.h index 042e27e..b112317

[PATCH 2.6.22 4/5] iw_cxgb3: Support for new abort logic.

2007-04-26 Thread Steve Wise
Support for new abort logic. The HW now posts 2 ABORT_RPL and/or PEER_ABORT_REQ messages. We need to handle them by silenty dropping the 1st but mark that we're ready for the final message. This plugs some close races between the uP and HW. Signed-off-by: Steve Wise <[EMAIL PROTEC

[PATCH 2.6.22 3/5] iw_cxgb3: Initialize cpu_idx field in cpl_close_listserv_req message.

2007-04-26 Thread Steve Wise
Initialize cpu_idx field in cpl_close_listserv_req message. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_cm.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw

[PATCH 2.6.22 1/5] iw_cxgb3: Fix TERM codes.

2007-04-26 Thread Steve Wise
Fix TERM codes. Fix TERMINATE layer, type, and ecode values based on conformance testing. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_qp.c | 69 ++--- 1 files changed, 38 insertions(+), 31 deletions(-) diff --git a/d

[PATCH 2.6.22 0/5] iw_cxgb3: Bug Fixes + Firmware update

2007-04-26 Thread Steve Wise
in this series because its required by the patch preceeding it in the series. Steve. Shortlog: Steve Wise: Fix TERM codes. Fail qp creation if the requested max_inline is too large. Initialize cpu_idx field in cpl_close_listserv_req message. Support for new abort logic

[PATCH 2.6.22 0/5] iw_cxgb3: Bug Fixes + Firmware update

2007-04-26 Thread Steve Wise
in this series because its required by the patch preceeding it in the series. Steve. Shortlog: Steve Wise: Fix TERM codes. Fail qp creation if the requested max_inline is too large. Initialize cpu_idx field in cpl_close_listserv_req message. Support for new abort logic

[PATCH 2.6.22 1/5] iw_cxgb3: Fix TERM codes.

2007-04-26 Thread Steve Wise
Fix TERM codes. Fix TERMINATE layer, type, and ecode values based on conformance testing. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_qp.c | 69 ++--- 1 files changed, 38 insertions(+), 31 deletions(-) diff --git a/drivers

[PATCH 2.6.22 3/5] iw_cxgb3: Initialize cpu_idx field in cpl_close_listserv_req message.

2007-04-26 Thread Steve Wise
Initialize cpu_idx field in cpl_close_listserv_req message. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_cm.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3

[PATCH 2.6.22 4/5] iw_cxgb3: Support for new abort logic.

2007-04-26 Thread Steve Wise
Support for new abort logic. The HW now posts 2 ABORT_RPL and/or PEER_ABORT_REQ messages. We need to handle them by silenty dropping the 1st but mark that we're ready for the final message. This plugs some close races between the uP and HW. Signed-off-by: Steve Wise [EMAIL PROTECTED

[PATCH 2.6.22 5/5] iw_cxgb3: Update required firmware revision to 4.0.0.

2007-04-26 Thread Steve Wise
Update required firmware revision to 4.0.0. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/net/cxgb3/version.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/cxgb3/version.h b/drivers/net/cxgb3/version.h index 042e27e..b112317 100644

[PATCH 2.6.22 2/5] iw_cxgb3: Fail qp creation if the requested max_inline is too large.

2007-04-26 Thread Steve Wise
Fail qp creation if the requested max_inline is too large. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/cxio_wr.h |1 + drivers/infiniband/hw/cxgb3/iwch_provider.c |3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers

Re: [ofa-general] [PATCH 6/6] [RFC]mlx4 build system stuff

2007-04-25 Thread Steve Wise
On Fri, 2007-04-20 at 15:32 -0700, Roland Dreier wrote: > Hook up mlx4_core and mlx4_ib drivers to Kconfig and Makefiles. > > Signed-off-by: Roland Dreier <[EMAIL PROTECTED]> > > --- > > infiniband/Kconfig |2 ++ > infiniband/Makefile |1 + > infiniband/hw/mlx4/Kconfig

Re: [ofa-general] [PATCH 6/6] [RFC]mlx4 build system stuff

2007-04-25 Thread Steve Wise
On Fri, 2007-04-20 at 15:32 -0700, Roland Dreier wrote: Hook up mlx4_core and mlx4_ib drivers to Kconfig and Makefiles. Signed-off-by: Roland Dreier [EMAIL PROTECTED] --- infiniband/Kconfig |2 ++ infiniband/Makefile |1 + infiniband/hw/mlx4/Kconfig |9

xmon debugger doc?

2007-04-12 Thread Steve Wise
Can someone please point me at ppc64 xmon debugger usage / documentation? I've had little luck finding info on-line. Thanks in advance, Steve. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 2.6.21] iw_cxgb3 - Add set_tcb_rpl_handler.

2007-04-12 Thread Steve Wise
On Thu, 2007-04-12 at 08:23 -0700, Roland Dreier wrote: > So is the cxgb3 net driver change in question already in Linus's tree? > What is the exact patch that this change goes with? The patch is the 3rd of 3: http://marc.info/?l=linux-kernel=117617444622279=2 Jeff applied it into his upstream

[PATCH 2.6.21] iw_cxgb3 - Add set_tcb_rpl_handler.

2007-04-12 Thread Steve Wise
). It was an oversight that this patch didn't really get included in Divy's series since the two go together. See http://marc.info/?l=linux-netdev=11761722260=2 Thanks, Steve. --- Add set_tcb_rpl_handler. The Ethernet Driver no longer handles SET_TCB replies. Signed-off-by: Steve Wise <[EM

[PATCH 2.6.21] iw_cxgb3 - Add set_tcb_rpl_handler.

2007-04-12 Thread Steve Wise
). It was an oversight that this patch didn't really get included in Divy's series since the two go together. See http://marc.info/?l=linux-netdevm=11761722260w=2 Thanks, Steve. --- Add set_tcb_rpl_handler. The Ethernet Driver no longer handles SET_TCB replies. Signed-off-by: Steve Wise [EMAIL

Re: [PATCH 2.6.21] iw_cxgb3 - Add set_tcb_rpl_handler.

2007-04-12 Thread Steve Wise
On Thu, 2007-04-12 at 08:23 -0700, Roland Dreier wrote: So is the cxgb3 net driver change in question already in Linus's tree? What is the exact patch that this change goes with? The patch is the 3rd of 3: http://marc.info/?l=linux-kernelm=117617444622279w=2 Jeff applied it into his upstream

xmon debugger doc?

2007-04-12 Thread Steve Wise
Can someone please point me at ppc64 xmon debugger usage / documentation? I've had little luck finding info on-line. Thanks in advance, Steve. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 2.6.21] iw_cxgb3: Fix TERM codes.

2007-03-29 Thread Steve Wise
Fix TERM codes. Fix TERMINATE layer, type, and ecode values based on conformance testing. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_qp.c | 69 ++--- 1 files changed, 38 insertions(+), 31 deletions(-) diff --git a/d

[PATCH 2.6.21] iw_cxgb3: Fix TERM codes.

2007-03-29 Thread Steve Wise
Fix TERM codes. Fix TERMINATE layer, type, and ecode values based on conformance testing. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_qp.c | 69 ++--- 1 files changed, 38 insertions(+), 31 deletions(-) diff --git a/drivers

[PATCH 2.6.21] iw_cxgb3: Fix a resource leak in cxio_hal_init_ctrl_qp().

2007-03-22 Thread Steve Wise
Fix a resource leak in cxio_hal_init_ctrl_qp(). Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/cxio_hal.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw

[PATCH 2.6.21] iw_cxgb3: Handle build_phys_page_list() failure in iwch_reregister_phys_mem().

2007-03-22 Thread Steve Wise
Handle build_phys_page_list() failure in iwch_reregister_phys_mem(). Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_provider.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c b/d

[PATCH 2.6.21] iw_cxgb3: Handle build_phys_page_list() failure in iwch_reregister_phys_mem().

2007-03-22 Thread Steve Wise
Handle build_phys_page_list() failure in iwch_reregister_phys_mem(). Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_provider.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c b/drivers

[PATCH 2.6.21] iw_cxgb3: Fix a resource leak in cxio_hal_init_ctrl_qp().

2007-03-22 Thread Steve Wise
Fix a resource leak in cxio_hal_init_ctrl_qp(). Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/cxio_hal.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3

Re: drivers/infiniband/hw/cxgb3/iwch_provider.c: uninitialized variable used

2007-03-19 Thread Steve Wise
Thanks Adrian, I'll address this... Steve. On Mon, 2007-03-19 at 10:26 +0100, Adrian Bunk wrote: > The Coverity checker spotted that "npages" will be used uninitialized in > the following code if !(mr_rereg_mask & IB_MR_REREG_TRANS): > > <-- snip --> > > ... > static int

Re: drivers/infiniband/hw/cxgb3/iwch_provider.c: uninitialized variable used

2007-03-19 Thread Steve Wise
Thanks Adrian, I'll address this... Steve. On Mon, 2007-03-19 at 10:26 +0100, Adrian Bunk wrote: The Coverity checker spotted that npages will be used uninitialized in the following code if !(mr_rereg_mask IB_MR_REREG_TRANS): -- snip -- ... static int

[PATCH 2.6.21-rc2] iw_cxgb3: Start ep timer on a MPA reject.

2007-03-05 Thread Steve Wise
Start ep timer on a MPA reject. If the consumer rejects the connection we end up under-referencing the endpoint structure. The fix is to call iwch_ep_disconnect() instead of the low level disconnect functions so that the endpoint close timer is started correctly. Signed-off-by: Steve Wise

Re: [PATCH]: CXGB3 infiniband build fix

2007-03-05 Thread Steve Wise
Acked-by: Steve Wise <[EMAIL PROTECTED]> On Mon, 2007-03-05 at 15:21 -0800, David Miller wrote: > Uses dma_alloc_coherent() et al. thus needs linux/dma-mapping.h > include in order to build reliably. > > Noticed on sparc64. > > Signed-off-by: David S. Miller <[

Re: [PATCH]: CXGB3 infiniband build fix

2007-03-05 Thread Steve Wise
Acked-by: Steve Wise [EMAIL PROTECTED] On Mon, 2007-03-05 at 15:21 -0800, David Miller wrote: Uses dma_alloc_coherent() et al. thus needs linux/dma-mapping.h include in order to build reliably. Noticed on sparc64. Signed-off-by: David S. Miller [EMAIL PROTECTED] diff --git a/drivers

[PATCH 2.6.21-rc2] iw_cxgb3: Start ep timer on a MPA reject.

2007-03-05 Thread Steve Wise
Start ep timer on a MPA reject. If the consumer rejects the connection we end up under-referencing the endpoint structure. The fix is to call iwch_ep_disconnect() instead of the low level disconnect functions so that the endpoint close timer is started correctly. Signed-off-by: Steve Wise

Re: Someone please turn on the http protocol on git.kernel.org!

2007-03-02 Thread Steve Wise
On Fri, 2007-03-02 at 16:30 -0600, Timur Tabi wrote: > Mike Accetta wrote: > > > error: Couldn't get > > http://www.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git/refs/tags/v2.6.11 > > > > for tags/v2.6.11 > > The requested URL returned error: 404 > > error: Could not interpret

[PATCH 2.6.21-rc2] iw_cxgb3: Don't use mm after its freed in iwch_mmap().

2007-03-02 Thread Steve Wise
Don't use mm after its freed in iwch_mmap(). Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_provider.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c b/drivers/infinib

Re: Someone please turn on the http protocol on git.kernel.org!

2007-03-02 Thread Steve Wise
On Fri, 2007-03-02 at 16:30 -0600, Timur Tabi wrote: Mike Accetta wrote: error: Couldn't get http://www.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git/refs/tags/v2.6.11 for tags/v2.6.11 The requested URL returned error: 404 error: Could not interpret tags/v2.6.11 as

[PATCH 2.6.21-rc2] iw_cxgb3: Don't use mm after its freed in iwch_mmap().

2007-03-02 Thread Steve Wise
Don't use mm after its freed in iwch_mmap(). Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_provider.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c b/drivers/infiniband/hw/cxgb3

[PATCH 2.6.21 4/6] iw_cxgb3: Squelch logging AE errors.

2007-03-01 Thread Steve Wise
Squelch logging AE errors. Only post one AE error for a given connection in the kernel log. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_ev.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw

[PATCH 2.6.21 1/6] iw_cxgb3: Fixes for "normal close" failures.

2007-03-01 Thread Steve Wise
Fixes for "normal close" failures. - Start normal close timer when moving to CLOSING state. - Handle ABORTING state in close_con_rpl(). - Stop timer correctly on abort during a normal close. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/

[PATCH 2.6.21 2/6] iw_cxgb3: Move QP to error on destroy if the state is IDLE.

2007-03-01 Thread Steve Wise
Move QP to error on destroy if the state is IDLE. Change iwch_destroy_qp() to always move the QP to ERROR and let iwch_modify_qp() decide what to do. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_provider.c |6 ++ 1 files changed, 2 inse

[PATCH 2.6.21 3/6] iw_cxgb3: Stop the endpoint timer when the MPA exchange is aborted by the peer.

2007-03-01 Thread Steve Wise
Stop the endpoint timer when the MPA exchange is aborted by the peer. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_cm.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infinib

[PATCH 2.6.21 5/6] iw_cxgb3: Don't reuse skbuffs that are non-linear or cloned.

2007-03-01 Thread Steve Wise
Don't reuse skbuffs that are non-linear or cloned. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_cm.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwc

[PATCH 2.6.21 6/6] iw_cxgb3: Fix MR permission problems.

2007-03-01 Thread Steve Wise
to utilize the new functions. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_provider.c | 24 +++- drivers/infiniband/hw/cxgb3/iwch_provider.h | 33 +++ drivers/infiniband/hw/cxgb3/iwch_qp.c |2 +- 3

[PATCH 2.6.21 0/6] iw_cxgb3: Bug Fixes

2007-03-01 Thread Steve Wise
Hey Roland, Here is a set of bug fixes for iw_cxgb3 that I'd like to roll into 2.6.21. Thanks, Steve. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2.6.21 0/6] iw_cxgb3: Bug Fixes

2007-03-01 Thread Steve Wise
Hey Roland, Here is a set of bug fixes for iw_cxgb3 that I'd like to roll into 2.6.21. Thanks, Steve. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

[PATCH 2.6.21 6/6] iw_cxgb3: Fix MR permission problems.

2007-03-01 Thread Steve Wise
to utilize the new functions. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_provider.c | 24 +++- drivers/infiniband/hw/cxgb3/iwch_provider.h | 33 +++ drivers/infiniband/hw/cxgb3/iwch_qp.c |2 +- 3 files

[PATCH 2.6.21 5/6] iw_cxgb3: Don't reuse skbuffs that are non-linear or cloned.

2007-03-01 Thread Steve Wise
Don't reuse skbuffs that are non-linear or cloned. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_cm.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c

[PATCH 2.6.21 3/6] iw_cxgb3: Stop the endpoint timer when the MPA exchange is aborted by the peer.

2007-03-01 Thread Steve Wise
Stop the endpoint timer when the MPA exchange is aborted by the peer. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_cm.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw

[PATCH 2.6.21 1/6] iw_cxgb3: Fixes for normal close failures.

2007-03-01 Thread Steve Wise
Fixes for normal close failures. - Start normal close timer when moving to CLOSING state. - Handle ABORTING state in close_con_rpl(). - Stop timer correctly on abort during a normal close. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_cm.c | 11

[PATCH 2.6.21 2/6] iw_cxgb3: Move QP to error on destroy if the state is IDLE.

2007-03-01 Thread Steve Wise
Move QP to error on destroy if the state is IDLE. Change iwch_destroy_qp() to always move the QP to ERROR and let iwch_modify_qp() decide what to do. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_provider.c |6 ++ 1 files changed, 2 insertions(+), 4

[PATCH 2.6.21 4/6] iw_cxgb3: Squelch logging AE errors.

2007-03-01 Thread Steve Wise
Squelch logging AE errors. Only post one AE error for a given connection in the kernel log. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_ev.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3

Re: [PATCH 7/7] cxgb3 - Add SW LRO support

2007-02-27 Thread Steve Wise
On Tue, 2007-02-27 at 09:53 -0500, Jeff Garzik wrote: > Steve Wise wrote: > > On Mon, 2007-02-26 at 05:13 +, Christoph Hellwig wrote: > >> On Sat, Feb 24, 2007 at 04:44:23PM -0800, [EMAIL PROTECTED] wrote: > >>> From: Divy Le Ray <[EMAIL PROTECTED]> &

Re: [PATCH 7/7] cxgb3 - Add SW LRO support

2007-02-27 Thread Steve Wise
On Mon, 2007-02-26 at 05:13 +, Christoph Hellwig wrote: > On Sat, Feb 24, 2007 at 04:44:23PM -0800, [EMAIL PROTECTED] wrote: > > From: Divy Le Ray <[EMAIL PROTECTED]> > > > > Add all-in-sw lro support. > > Doing this in a LLDD doesn't sound like a good idea. Have you > tried doing this in

Re: [PATCH 7/7] cxgb3 - Add SW LRO support

2007-02-27 Thread Steve Wise
On Mon, 2007-02-26 at 05:13 +, Christoph Hellwig wrote: On Sat, Feb 24, 2007 at 04:44:23PM -0800, [EMAIL PROTECTED] wrote: From: Divy Le Ray [EMAIL PROTECTED] Add all-in-sw lro support. Doing this in a LLDD doesn't sound like a good idea. Have you tried doing this in the core

Re: [PATCH 7/7] cxgb3 - Add SW LRO support

2007-02-27 Thread Steve Wise
On Tue, 2007-02-27 at 09:53 -0500, Jeff Garzik wrote: Steve Wise wrote: On Mon, 2007-02-26 at 05:13 +, Christoph Hellwig wrote: On Sat, Feb 24, 2007 at 04:44:23PM -0800, [EMAIL PROTECTED] wrote: From: Divy Le Ray [EMAIL PROTECTED] Add all-in-sw lro support. Doing this in a LLDD

Re: [PATCH 3/7] cxgb3 - FW version update

2007-02-25 Thread Steve Wise
> I would rather fix the code to use constants, and thus avoid this > problem ever happening again. > > Jeff > How's this (not tested)? --- drivers/net/cxgb3/t3_hw.c |6 -- drivers/net/cxgb3/version.h |2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 3/7] cxgb3 - FW version update

2007-02-25 Thread Steve Wise
Hey Divy, You missed a printk change. Here is an updated patch. Update FW version to 3.2 Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/cxgb3/t3_hw.c b/d

Re: [PATCH 3/7] cxgb3 - FW version update

2007-02-25 Thread Steve Wise
Hey Divy, You missed a printk change. Here is an updated patch. Update FW version to 3.2 Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/net/cxgb3/t3_hw.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/cxgb3/t3_hw.c b/drivers/net

Re: [PATCH 3/7] cxgb3 - FW version update

2007-02-25 Thread Steve Wise
I would rather fix the code to use constants, and thus avoid this problem ever happening again. Jeff How's this (not tested)? --- drivers/net/cxgb3/t3_hw.c |6 -- drivers/net/cxgb3/version.h |2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 0/7] cxgb3 - Chelsio T3 1G/10G driver updates

2007-02-22 Thread Steve Wise
Divy, Do these need to be pulled into OFED 1.2 as well? Steve. On Thu, 2007-02-22 at 03:58 -0800, Divy Le Ray wrote: > Jeff, > > I'm sending a series of incremental patches updating > the cxgb3 driver. These patches are built against Linus'git tree. > > Cheers, > Divy > - > To unsubscribe

Re: [PATCH 0/7] cxgb3 - Chelsio T3 1G/10G driver updates

2007-02-22 Thread Steve Wise
Divy, Do these need to be pulled into OFED 1.2 as well? Steve. On Thu, 2007-02-22 at 03:58 -0800, Divy Le Ray wrote: Jeff, I'm sending a series of incremental patches updating the cxgb3 driver. These patches are built against Linus'git tree. Cheers, Divy - To unsubscribe from this

[PATCH 2.6.21] iw_cxgb3: Stop the EP Timer on BAD CLOSE.

2007-02-21 Thread Steve Wise
Stop the ep timer in ec_status() if the status indicates a bad close. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_cm.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infinib

Re: [2.6 patch] drivers/infiniband/hw/cxgb3/: cleanups

2007-02-21 Thread Steve Wise
Thanks Adrian! Acked-by: Steve Wise <[EMAIL PROTECTED]> On Wed, 2007-02-21 at 11:52 +0100, Adrian Bunk wrote: > On Tue, Feb 20, 2007 at 08:43:06AM -0600, Steve Wise wrote: > > On Tue, 2007-02-20 at 01:02 +0100, Adrian Bunk wrote: > > > This patch contains the fol

Re: [2.6 patch] drivers/infiniband/hw/cxgb3/: cleanups

2007-02-21 Thread Steve Wise
Thanks Adrian! Acked-by: Steve Wise [EMAIL PROTECTED] On Wed, 2007-02-21 at 11:52 +0100, Adrian Bunk wrote: On Tue, Feb 20, 2007 at 08:43:06AM -0600, Steve Wise wrote: On Tue, 2007-02-20 at 01:02 +0100, Adrian Bunk wrote: This patch contains the following possible cleanups: - don't

[PATCH 2.6.21] iw_cxgb3: Stop the EP Timer on BAD CLOSE.

2007-02-21 Thread Steve Wise
Stop the ep timer in ec_status() if the status indicates a bad close. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_cm.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw

Re: [2.6 patch] drivers/infiniband/hw/cxgb3/: possible cleanups

2007-02-20 Thread Steve Wise
On Tue, 2007-02-20 at 01:02 +0100, Adrian Bunk wrote: > This patch contains the following possible cleanups: > - don't mark static functions in C files as inline - gcc should know > best whether inlining makes sense > - never compile the unused cxio_dbg.c > - make the following needlessly global

Re: [2.6 patch] drivers/infiniband/hw/cxgb3/: possible cleanups

2007-02-20 Thread Steve Wise
On Tue, 2007-02-20 at 01:02 +0100, Adrian Bunk wrote: This patch contains the following possible cleanups: - don't mark static functions in C files as inline - gcc should know best whether inlining makes sense - never compile the unused cxio_dbg.c - make the following needlessly global

[PATCH] iw_cxgb3 Fix copyrights in the iw_cxgb3 driver.

2007-02-15 Thread Steve Wise
Fix copyrights in the iw_cxgb3 driver. Remove the Open Grid Computing copyright. It shouldn't be there. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/cxio_dbg.c |1 - drivers/infiniband/hw/cxgb3/cxio_hal.c |1 - drivers/infiniband/hw

[PATCH] cxgb3 Fix copyrights in the cxgb3 driver.

2007-02-15 Thread Steve Wise
Fix copyrights in the cxgb3 driver. Remove the Open Grid Computing copyright. It shouldn't be there. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_defs.h|1 - drivers/net/cxgb3/cxgb3_offload.c |1 - drivers/net/cxgb3/cxgb3_offload.h |1 - d

[PATCH] 2.6.21 iw_cxgb3 Fail posts synchronously when in TERMINATE state.

2007-02-15 Thread Steve Wise
From: Steve Wise <[EMAIL PROTECTED]> Fail posts synchronously when in TERMINATE state. For T3B devices, mark user qp in error once we transition to TERMINATE. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_qp.c |2 ++ 1 files changed, 2 inse

[PATCH] cxgb3 Fix copyrights in the cxgb3 driver.

2007-02-15 Thread Steve Wise
Fix copyrights in the cxgb3 driver. Remove the Open Grid Computing copyright. It shouldn't be there. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_defs.h|1 - drivers/net/cxgb3/cxgb3_offload.c |1 - drivers/net/cxgb3/cxgb3_offload.h |1 - drivers/net

[PATCH] 2.6.21 iw_cxgb3 Fail posts synchronously when in TERMINATE state.

2007-02-15 Thread Steve Wise
From: Steve Wise [EMAIL PROTECTED] Fail posts synchronously when in TERMINATE state. For T3B devices, mark user qp in error once we transition to TERMINATE. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_qp.c |2 ++ 1 files changed, 2 insertions(+), 0

[PATCH] iw_cxgb3 Fix copyrights in the iw_cxgb3 driver.

2007-02-15 Thread Steve Wise
Fix copyrights in the iw_cxgb3 driver. Remove the Open Grid Computing copyright. It shouldn't be there. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/cxio_dbg.c |1 - drivers/infiniband/hw/cxgb3/cxio_hal.c |1 - drivers/infiniband/hw/cxgb3

Re: [Fwd: Re: [PATCH 1/10] cxgb3 - main header files]

2007-02-02 Thread Steve Wise
On Thu, 2007-02-01 at 20:48 -0800, Roland Dreier wrote: > > Have you had a chance to review this? > > Still on my list. > > Can we trade? Can you look at the IPoIB connected mode stuff in the > ipoib-cm branch in > > git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git > >

Re: [Fwd: Re: [PATCH 1/10] cxgb3 - main header files]

2007-02-02 Thread Steve Wise
On Thu, 2007-02-01 at 20:48 -0800, Roland Dreier wrote: Have you had a chance to review this? Still on my list. Can we trade? Can you look at the IPoIB connected mode stuff in the ipoib-cm branch in git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git and let me

Re: [Fwd: Re: [PATCH 1/10] cxgb3 - main header files]

2007-02-01 Thread Steve Wise
On Fri, 2007-01-19 at 09:07 -0800, Roland Dreier wrote: > > Jeff has pulled in the Chelsio Ethernet driver. If you are ready to > > merge in the RDMA driver, you can pull it from > > Yes, I saw that... OK, I'll get serious about reviewing the RDMA stuff. Hey Roland, Have you had a chance to

Re: [Fwd: Re: [PATCH 1/10] cxgb3 - main header files]

2007-02-01 Thread Steve Wise
On Fri, 2007-01-19 at 09:07 -0800, Roland Dreier wrote: Jeff has pulled in the Chelsio Ethernet driver. If you are ready to merge in the RDMA driver, you can pull it from Yes, I saw that... OK, I'll get serious about reviewing the RDMA stuff. Hey Roland, Have you had a chance to

[Fwd: Re: [PATCH 1/10] cxgb3 - main header files]

2007-01-19 Thread Steve Wise
Hey Roland, Jeff has pulled in the Chelsio Ethernet driver. If you are ready to merge in the RDMA driver, you can pull it from git://staging.openfabrics.org/~swise/cxgb3.git for-roland Thanks, Steve. Forwarded Message From: Jeff Garzik <[EMAIL PROTECTED]> To: Divy Le Ray

[Fwd: Re: [PATCH 1/10] cxgb3 - main header files]

2007-01-19 Thread Steve Wise
Hey Roland, Jeff has pulled in the Chelsio Ethernet driver. If you are ready to merge in the RDMA driver, you can pull it from git://staging.openfabrics.org/~swise/cxgb3.git for-roland Thanks, Steve. Forwarded Message From: Jeff Garzik [EMAIL PROTECTED] To: Divy Le Ray

<    1   2   3   4   5   6   7   >