[ANNOUNCE] 5.10.27-rt36

2021-04-07 Thread Steven Rostedt
Dear RT Folks, I'm pleased to announce the 5.10.27-rt36 stable release. This release is just an update to the new stable 5.10.27 version and no RT specific changes have been made. You can get this release via the git tree at:

Re: [PATCH -next] arm: patch: FUNCTION_GRAPH_TRACER depends on CPU_ENDIAN_BE8 or !CPU_ENDIAN_BE32

2021-04-06 Thread Steven Rostedt
On Tue, 6 Apr 2021 18:23:51 +0800 Zhang Jianhua wrote: > If CONFIG_FUNCTION_GRAPH_TRACER=y, the following errors will be seen > while compiling patch.c > > arch/arm/kernel/patch.c: In function ‘__patch_text_real’: > arch/arm/kernel/patch.c:94:11: error: implicit declaration of function >

Re: [PATCH] ftrace: Check if pages were allocated before calling free_pages()

2021-04-06 Thread Steven Rostedt
On Tue, 6 Apr 2021 14:51:45 +0800 Jiapeng Chong wrote: > It is possible that on error pg->size can be zero when getting its > order,which would return a -1 value. It is dangerous to pass in an > order of -1 to free_pages(). Check if order is greater than or equal > to zero before calling

Re: [PATCH v4] sched/debug: Use sched_debug_lock to serialize use of cgroup_path[] only

2021-04-05 Thread Steven Rostedt
On Mon, 5 Apr 2021 19:42:03 -0400 Waiman Long wrote: > +/* > + * All the print_cpu() callers from sched_debug_show() will be allowed > + * to contend for sched_debug_lock and use group_path[] as their SEQ_printf() > + * calls will be much faster. However only one print_cpu() caller from > + *

Re: [PATCH v2 5/5] tracing: Add "func_no_repeats" option for function tracing

2021-04-05 Thread Steven Rostedt
On Mon, 29 Mar 2021 16:05:33 +0300 "Yordan Karadzhov (VMware)" wrote: > If the option is activated the function tracing record gets > consolidated in the cases when a single function is called number > of times consecutively. Instead of having an identical record for > each call of the function

Re: [PATCH v2 4/5] tracing: Unify the logic for function tracing options

2021-04-05 Thread Steven Rostedt
On Mon, 29 Mar 2021 16:05:32 +0300 "Yordan Karadzhov (VMware)" wrote: > Currently the logic for dealing with the options for function tracing > has two different implementations. One is used when we set the flags > (in "static int func_set_flag()") and another used when we initialize > the

Re: [PATCH v2 1/5] tracing: Define new ftrace event "func_repeats"

2021-04-05 Thread Steven Rostedt
On Mon, 29 Mar 2021 16:05:29 +0300 "Yordan Karadzhov (VMware)" wrote: > The event aims to consolidate the function tracing record in the cases > when a single function is called number of times consecutively. > > while (cond) > do_func(); > > This may happen in various

Re: [PATCH v3] sched/debug: Use sched_debug_lock to serialize use of cgroup_path[] only

2021-04-05 Thread Steven Rostedt
On Sun, 4 Apr 2021 21:27:00 -0400 Waiman Long wrote: > Thanks for the suggestion, but it also sound complicated. It's not that complicated. Similar tricks have been used elsewhere in the kernel. > > I think we can fix this lockup problem if we are willing to lose some It's not a lockup

Re: [PATCH v3] sched/debug: Use sched_debug_lock to serialize use of cgroup_path[] only

2021-04-04 Thread Steven Rostedt
On Fri, 2 Apr 2021 23:09:09 -0400 Waiman Long wrote: > The main problem with sched_debug_lock is that under certain > circumstances, a lock waiter may wait a long time to acquire the lock > (in seconds). We can't insert touch_nmi_watchdog() while the cpu is > waiting for the spinlock. The

[for-next][PATCH 4/4] ftrace: Simplify the calculation of page number for ftrace_page->records some more

2021-04-03 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Commit b40c6eabfcd40 ("ftrace: Simplify the calculation of page number for ftrace_page->records") simplified the calculation of the number of pages needed for each page group without having any empty pages, but it can be simplified even

[for-next][PATCH 3/4] ftrace: Store the order of pages allocated in ftrace_page

2021-04-03 Thread Steven Rostedt
-=whyMxheOqXAORt9a7JK9gc9eHTgCJ55Pgs4p=x3rrq...@mail.gmail.com/ Signed-off-by: Linus Torvalds [ change log written by Steven Rostedt ] Signed-off-by: Steven Rostedt (VMware) --- kernel/trace/ftrace.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/kernel/trace/ftrace.c

[for-next][PATCH 1/4] tracing: Remove duplicate struct declaration in trace_events.h

2021-04-03 Thread Steven Rostedt
From: Wan Jiabing struct trace_array is declared twice. One has been declared at forward declaration. Remove the duplicate. Link: https://lkml.kernel.org/r/20210330034056.2266969-1-wanjiab...@vivo.com Signed-off-by: Wan Jiabing Signed-off-by: Steven Rostedt (VMware) --- include/linux

[for-next][PATCH 2/4] tracing: Remove unused argument from "ring_buffer_time_stamp()

2021-04-03 Thread Steven Rostedt
From: "Yordan Karadzhov (VMware)" The "cpu" parameter is not being used by the function. Link: https://lkml.kernel.org/r/20210329130331.199402-1-y.kar...@gmail.com Signed-off-by: Yordan Karadzhov (VMware) Signed-off-by: Steven Rostedt (VMware) --- include/linux/ring_buf

[for-next][PATCH 0/4] tracing: More updates for 5.13

2021-04-03 Thread Steven Rostedt
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next Head SHA1: ceaaa12904df07d07ea8975abbf04c4d60e46956 Linus Torvalds (1): ftrace: Store the order of pages allocated in ftrace_page Steven Rostedt (VMware) (1): ftrace: Simplify the calculation of page

Re: [PATCH v3] sched/debug: Use sched_debug_lock to serialize use of cgroup_path[] only

2021-04-02 Thread Steven Rostedt
On Thu, 1 Apr 2021 14:10:30 -0400 Waiman Long wrote: > The handling of sysrq key can be activated by echoing the key to > /proc/sysrq-trigger or via the magic key sequence typed into a terminal > that is connected to the system in some way (serial, USB or other mean). > In the former case, the

[GIT PULL] tracing: Fix stack trace event size

2021-04-02 Thread Steven Rostedt
which can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git trace-v5.12-rc5-2 Tag SHA1: cb39aeb904fb1dc0fff7e13799d9ad287fb4697f Head SHA1: 9deb193af69d3fd6dd8e47f292b67c805a787010 Steven Rostedt (VMware) (1): tracing: Fix stack trace event size ke

Re: [GIT PULL] ftrace: Check if pages were allocated before calling free_pages()

2021-04-01 Thread Steven Rostedt
On Thu, 1 Apr 2021 13:18:59 -0700 Linus Torvalds wrote: > On Thu, Apr 1, 2021 at 1:07 PM Steven Rostedt wrote: > > > > On Wed, 31 Mar 2021 11:03:21 -0700 > > Linus Torvalds wrote: > > > > > @@ -6231,7 +6231,8 @@ static int ftrace_process_locs(struct module

Re: [GIT PULL] ftrace: Check if pages were allocated before calling free_pages()

2021-04-01 Thread Steven Rostedt
On Thu, 1 Apr 2021 16:07:10 -0400 Steven Rostedt wrote: > > @@ -6231,7 +6231,8 @@ static int ftrace_process_locs(struct module *mod, > > if (!addr) > > continue; > > > > - if (pg->index == pg->size) { > > +

Re: [GIT PULL] ftrace: Check if pages were allocated before calling free_pages()

2021-04-01 Thread Steven Rostedt
On Wed, 31 Mar 2021 11:03:21 -0700 Linus Torvalds wrote: > @@ -6231,7 +6231,8 @@ static int ftrace_process_locs(struct module *mod, > if (!addr) > continue; > > - if (pg->index == pg->size) { > + end_offset = (pg->index+1) *

Re: [PATCH] kernel: initialize cpumask before parsing

2021-04-01 Thread Steven Rostedt
nd_next_bit() accesses uninitialized cpu mask variable. Fix this > problem by replacing alloc_cpumask_var() with zalloc_cpumask_var(). > > Signed-off-by: Tetsuo Handa > --- > kernel/irq/proc.c| 4 ++-- > kernel/profile.c | 2 +- > kernel/trace/trace.c | 2 +- Acked-by: Steven Rostedt (VMware) -- Steve

Re: User stacktrace garbage when USER_STACKTRACE_SUPPORT is not enabled

2021-03-31 Thread Steven Rostedt
On Thu, 1 Apr 2021 00:02:57 +0200 Vasily Gorbik wrote: > I only tested it on s390 (manually + ftrace selftest), quite frankly. > If it qualifies: You reported the bug, thus tested-by from the reporter always qualifies ;-) > > Tested-by: Vasily Gorbik # s390 only Thanks, -- Steve

Re: User stacktrace garbage when USER_STACKTRACE_SUPPORT is not enabled

2021-03-31 Thread Steven Rostedt
On Wed, 31 Mar 2021 22:51:15 +0200 Vasily Gorbik wrote: > It does! Thanks for the explanation and for the fix. I wonder why nobody > noticed and complained about that since v5.6. Because it didn't lose data, just added extra junk. > > Acked-by: Vasily Gorbik Want to give a "tested-by" too?

Re: [GIT PULL] ftrace: Check if pages were allocated before calling free_pages()

2021-03-31 Thread Steven Rostedt
On Wed, 31 Mar 2021 11:03:21 -0700 Linus Torvalds wrote: > I found another bug in there, for example: > > ftrace_number_of_pages -= 1 << order; > > is also wrong if order is negative. True, but ftrace_number_of_pages is only used for accounting (used to display the number of

Re: [GIT PULL] ftrace: Check if pages were allocated before calling free_pages()

2021-03-31 Thread Steven Rostedt
On Wed, 31 Mar 2021 10:45:01 -0700 Linus Torvalds wrote: > On Wed, Mar 31, 2021 at 6:27 AM Steven Rostedt wrote: > > > > order = get_count_order(pg->size / ENTRIES_PER_PAGE); > > - free_pages((unsigned long)pg->records, order); > &g

Re: User stacktrace garbage when USER_STACKTRACE_SUPPORT is not enabled

2021-03-31 Thread Steven Rostedt
On Wed, 31 Mar 2021 13:52:45 +0200 Vasily Gorbik wrote: > Hi Steven, > > At least on s390 since commit cbc3b92ce037 ("tracing: Set kernel_stack's > caller size properly") kernel stack trace contains 8 garbage values in the > end. > I assume those are supposed to be filled by

Re: [PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages

2021-03-31 Thread Steven Rostedt
On Wed, 31 Mar 2021 11:31:03 +0200 Geert Uytterhoeven wrote: > This reduces kernel size by ca. 0.5 KiB. If you are worried about size, disable tracing and it will go away entirely. 0.5KiB is a drop in the bucket compared to what tracing adds in size overhead. Sorry, but NAK. This has been

[GIT PULL] ftrace: Check if pages were allocated before calling free_pages()

2021-03-31 Thread Steven Rostedt
pub/scm/linux/kernel/git/rostedt/linux-trace.git trace-v5.12-rc5 Tag SHA1: 30ee29d701d2b6848cfa1c7a163745fb68aabd36 Head SHA1: 59300b36f85f254260c81d9dd09195fa49eb0f98 Steven Rostedt (VMware) (1): ftrace: Check if pages were allocated before calling free_pages() kernel/trace/ftrace.c

Re: [PATCH] riscv: kprobes/ftrace: Add recursion protection to the ftrace callback

2021-03-30 Thread Steven Rostedt
recursion protection to the > ftrace callback"), so do similar modifications as the commit does. > > Fixes: 829adda597fe ("riscv: Add KPROBES_ON_FTRACE supported") > Signed-off-by: Jisheng Zhang Looks fine to me. Reviewed-by: Steven Rostedt (VMware) -- Steve

Re: [PATCH] ftrace: Modify parameter transfer type

2021-03-30 Thread Steven Rostedt
On Tue, 30 Mar 2021 18:02:26 +0800 Jiapeng Chong wrote: > Fix the following whitescan warning: > > "order" is passed to a parameter that cannot be negative. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > kernel/trace/ftrace.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] linux/trace_events.h: Remove duplicate struct declaration

2021-03-29 Thread Steven Rostedt
On Tue, 30 Mar 2021 09:55:17 +0800 Wan Jiabing wrote: > struct trace_array is declared twice. One has been declared > at forward struct declaration. Remove the duplicate. > And sort these forward declarations alphabetically. Um, no that's not how we sort things. > > Signed-off-by: Wan Jiabing

Re: [PATCH 6/9] debugfs: Implement debugfs_create_str()

2021-03-27 Thread Steven Rostedt
On Sat, 27 Mar 2021 22:24:45 + Al Viro wrote: > On Fri, Mar 26, 2021 at 11:33:58AM +0100, Peter Zijlstra wrote: > > > +again: > > + rcu_read_lock(); > > + str = rcu_dereference(*(char **)file->private_data); > > + len = strlen(str) + 1; > > + > > + if (!copy || copy_len < len) { > >

[for-next][PATCH 3/6] tracing: Fix various typos in comments

2021-03-26 Thread Steven Rostedt
-by: Ingo Molnar Signed-off-by: Steven Rostedt (VMware) --- arch/microblaze/include/asm/ftrace.h | 2 +- arch/nds32/kernel/ftrace.c | 2 +- arch/powerpc/include/asm/ftrace.h| 4 ++-- arch/sh/kernel/ftrace.c | 2 +- arch/sparc/include/asm/ftrace.h | 2 +- fs/tracefs

[for-next][PATCH 0/6] tracing: More updates for 5.13

2021-03-26 Thread Steven Rostedt
Qiujun Huang (2): tracing: A minor cleanup for create_system_filter() tracing: Update create_system_filter() kernel-doc comment Steven Rostedt (VMware) (2): scripts/recordmcount.pl: Make indent spacing consistent scripts/recordmcount.pl: Make vim and emacs indent the same

[for-next][PATCH 1/6] scripts/recordmcount.pl: Make indent spacing consistent

2021-03-26 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Emacs by default will have perl files have 4 space indents, where 8 spaces are represented with a single tab. There are some places in recordmcount.pl that has 8 spaces where a tab should be used. Replace them to make the file consistent. No function

[for-next][PATCH 2/6] scripts/recordmcount.pl: Make vim and emacs indent the same

2021-03-26 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" By default, emacs indents Perl files with 4 spaces, but will use tabs where 8 spaces are used. Add a vim command of softtabstop=4, to make vim behave the same. This should remove the issue of developers using vim having causing different indentati

[for-next][PATCH 4/6] kernel: trace: Mundane typo fixes in the file trace_events_filter.c

2021-03-26 Thread Steven Rostedt
From: Bhaskar Chowdhury s/callin/calling/ Link: https://lkml.kernel.org/r/20210317095401.1854544-1-unixbhas...@gmail.com Acked-by: Randy Dunlap Signed-off-by: Bhaskar Chowdhury [ Other fixes already done by Ingo Molnar ] Signed-off-by: Steven Rostedt (VMware) --- kernel/trace

[for-next][PATCH 5/6] tracing: A minor cleanup for create_system_filter()

2021-03-26 Thread Steven Rostedt
From: Qiujun Huang The first two parameters should be reduced to one, as @tr is simply @dir->tr. Link: https://lkml.kernel.org/r/20210324205642.65e03...@oasis.local.home Link: https://lkml.kernel.org/r/20210325163752.128407-1-hqjag...@gmail.com Suggested-by: Steven Rostedt (VMware) Signed-

[for-next][PATCH 6/6] tracing: Update create_system_filter() kernel-doc comment

2021-03-26 Thread Steven Rostedt
er from @system to @dir. Link: https://lkml.kernel.org/r/20210325161911.123452-1-hqjag...@gmail.com Signed-off-by: Qiujun Huang Signed-off-by: Steven Rostedt (VMware) --- kernel/trace/trace_events_filter.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_ev

Re: [PATCH -tip v4 10/12] x86/kprobes: Push a fake return address at kretprobe_trampoline

2021-03-26 Thread Steven Rostedt
On Fri, 26 Mar 2021 21:03:49 +0900 Masami Hiramatsu wrote: > I confirmed this is not related to this series, but occurs when I build > kernels with different > configs without cleanup. > > Once I build kernel with CONFIG_UNWIND_GUESS=y (for testing), and after that, > I build kernel again with

[ANNOUNCE] KernelShark 1.3

2021-03-25 Thread Steven Rostedt
I'm happy to announce KernelShark Version 1.3 *** NOTICE *** KernelShark is now in its own repository (and will depend on libtracecmd). This is the last version that will home KernelShark in the trace-cmd.git repo. New development of KernelShark now lives here:

[ANNOUNCE] trace-cmd 2.9.2

2021-03-25 Thread Steven Rostedt
I'm happy to announce trace-cmd version 2.9.2! *** NOTICE *** This is the last version that is self contained for interacting with the tracefs directory and parsing the events. The parsing of events is now a separate repository: https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/

Re: [RFC][PATCH] task_struct::state frobbing

2021-03-25 Thread Steven Rostedt
On Thu, 25 Mar 2021 19:11:37 +0100 Peter Zijlstra wrote: > diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c > b/drivers/net/ethernet/qualcomm/qca_spi.c > index 5a3b65a6eb4f..17ee771e0051 100644 > --- a/drivers/net/ethernet/qualcomm/qca_spi.c > +++ b/drivers/net/ethernet/qualcomm/qca_spi.c >

Re: [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users

2021-03-25 Thread Steven Rostedt
On Thu, 25 Mar 2021 23:09:38 +0900 Masahiro Yamada wrote: > > > Not all people use vim. > > > > I don't use it either. I was trying to make vim match emacs. Of course for > > those that use something else, it wont help. I'm curious, what's your main > > editor that you use? > > > I use

Re: [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users

2021-03-25 Thread Steven Rostedt
On Thu, 25 Mar 2021 15:20:13 +0900 Masahiro Yamada wrote: > > The root cause of inconsistency is that > you mix up space-indentation and tab-indentation. > I do not know if it is a standard way either. This is the default way emacs has edited perl files for as long as I can remember (back to

Re: [PATCH] kernel/sched: remove duplicate include in sched.h sched.h

2021-03-24 Thread Steven Rostedt
HED conditional. Reviewed-by: Steven Rostedt (VMware) -- Steve > Signed-off-by: Xiong Zhenwu > --- > kernel/sched/sched.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h > index 10a1522b1e30..235d8381f142 100644 > --

Re: [PATCH 1/2] ftrace: Update ftrace_ops->next pointer with rcu_assign_pointer()

2021-03-24 Thread Steven Rostedt
On Wed, 17 Mar 2021 18:25:28 +0800 Li Huafei wrote: > The unregistered ftrace_ops may be freed by the caller, so we should use > rcu_assign_pointer() in remove_ftrace_ops() to remove the ftrace_ops, > which ensures that no more users will reference the ftrace_ops after > synchronize_rcu() is

Re: [PATCH 2/2] perf, ftrace: Fix use-after-free in __ftrace_ops_list_func()

2021-03-24 Thread Steven Rostedt
On Wed, 24 Mar 2021 21:11:23 -0400 Steven Rostedt wrote: > And what you are saying is that we are not getting there, where the > dynamically allocated perf ops is not set to be DYNAMIC? > > That should be set as DYNAMIC if the ops was allocated, and can later > be freed. This c

Re: [PATCH 2/2] perf, ftrace: Fix use-after-free in __ftrace_ops_list_func()

2021-03-24 Thread Steven Rostedt
On Wed, 17 Mar 2021 18:25:29 +0800 Li Huafei wrote: > We see the comment of ftrace_ops in include/linux/ftrace.h, which > actually mentions that for dynamically allocated ftrace_ops, after > unregistering it should be guaranteed that no user will reference that > ftrace_ops again, but the

Re: [PATCH] tracing: Update create_system_filter() kernel-doc comment

2021-03-24 Thread Steven Rostedt
On Sat, 20 Mar 2021 11:39:16 + Qiujun Huang wrote: > commit f306cc82a93d ("tracing: Update event filters for multibuffer") > added the parameter @tr for create_system_filter(). > > commit bb9ef1cb7d86 ("tracing: Change apply_subsystem_event_filter() paths to > check file->system == dir") >

Re: [PATCH] printk: rename vprintk_func to vprintk

2021-03-24 Thread Steven Rostedt
xt, which one must assume are rather precious to > anyone disabling PRINTK. I'm guessing that at commit: 42a0bb3f7138 ("printk/nmi: generic solution for safe printk in NMI"), the special name for vprintk_func() became obsolete. Reviewed-by: Steven Rostedt (VMware) -- Steve > > $

Re: [PATCH -tip v4 10/12] x86/kprobes: Push a fake return address at kretprobe_trampoline

2021-03-24 Thread Steven Rostedt
On Thu, 25 Mar 2021 08:47:41 +0900 Masami Hiramatsu wrote: > > I think the REGS and REGS_PARTIAL cases can also be affected by function > > graph tracing. So should they use the generic unwind_recover_ret_addr() > > instead of unwind_recover_kretprobe()? > > Yes, but I'm not sure this

Re: [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users

2021-03-24 Thread Steven Rostedt
On Wed, 24 Mar 2021 09:54:17 -0400 Steven Rostedt wrote: > This code doesn't change much, so I'm fine with that. But for ktest.pl, I'm > adding it. Anyway, I'm not going to ask you to take the second patch if you don't like it, but would you take the first patch? -- Steve

[ANNOUNCE] 5.10.25-rt35

2021-03-24 Thread Steven Rostedt
Dear RT Folks, I'm pleased to announce the 5.10.25-rt35 stable release. This release is just an update to the new stable 5.10.25 version and no RT specific changes have been made. You can get this release via the git tree at:

Re: [PATCH] mm: cma: add trace events for CMA alloc perf testing

2021-03-24 Thread Steven Rostedt
trace/events/cma.h | 39 +- > include/trace/events/migrate.h | 22 +++ > mm/cma.c | 4 > mm/migrate.c | 2 ++ > 4 files changed, 66 insertions(+), 1 deletion(-) >From a tracing perspec

Re: [PATCH] tee: optee: add invoke_fn tracepoints

2021-03-24 Thread Steven Rostedt
On Wed, 24 Mar 2021 07:48:53 -0700 Guenter Roeck wrote: > On Wed, Mar 24, 2021 at 07:34:07AM -0700, Guenter Roeck wrote: > > On Wed, Feb 10, 2021 at 02:44:09PM +0800, Jisheng Zhang wrote: > > > Add tracepoints to retrieve information about the invoke_fn. This would > > > help to measure how

Re: [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users

2021-03-24 Thread Steven Rostedt
On Wed, 24 Mar 2021 15:01:13 +0900 Masahiro Yamada wrote: > On Tue, Mar 23, 2021 at 6:40 AM Steven Rostedt wrote: > > > > From: "Steven Rostedt (VMware)" > > > > The tab stop for Perl files is by default (at least in emacs) to be 4 > > spaces, where

Re: [PATCH v3] tracing: Fix various typos in comments

2021-03-23 Thread Steven Rostedt
On Tue, 23 Mar 2021 18:49:35 +0100 Ingo Molnar wrote: > Fix ~59 single-word typos in the tracing code comments, and fix > the grammar in a handful of places. > > Signed-off-by: Ingo Molnar > Reviewed-by: Randy Dunlap > Link: https://lore.kernel.org/r/2021034546.ga1981...@gmail.com > ---

[ANNOUNCE] 5.4.106-rt54

2021-03-23 Thread Steven Rostedt
Dear RT Folks, I'm pleased to announce the 5.4.106-rt54 stable release. This release is just an update to the new stable 5.4.106 version and no RT specific changes have been made. You can get this release via the git tree at:

Re: RFC: create mailing list "linux-issues" focussed on issues/bugs and regressions

2021-03-23 Thread Steven Rostedt
On Mon, 22 Mar 2021 20:25:15 +0100 Thorsten Leemhuis wrote: > I agree to the last point and yeah, maybe regressions are the more > important problem we should work on – at least from the perspective of > kernel development. But from the users perspective (and > reporting-issues.rst is written

Re: [PATCH] ftrace: shut up -Wcast-function-type warning for ftrace_ops_no_ops

2021-03-23 Thread Steven Rostedt
On Tue, 23 Mar 2021 08:39:08 +0100 Peter Zijlstra wrote: > > index 4d8e35575549..d8fc87a17421 100644 > > --- a/kernel/trace/ftrace.c > > +++ b/kernel/trace/ftrace.c > > @@ -125,7 +125,7 @@ static void ftrace_ops_list_func(unsigned long ip, > > unsigned long parent_ip, > > #else > > /* See

Re: [PATCH, -v2] tracing: Fix various typos in comments

2021-03-23 Thread Steven Rostedt
On Tue, 23 Mar 2021 12:11:50 +0100 Ingo Molnar wrote: > -v2 attached - I preemptively added your Reviewed-by as well, if > that's fine. :-) > > Thanks, > > Ingo > > => > From: Ingo Molnar > Date: Mon, 22 Mar 2021 23:45:46 +0100 > Subject: [PATCH] tracing: Fix

Re: [PATCH] ftrace: shut up -Wcast-function-type warning for ftrace_ops_no_ops

2021-03-22 Thread Steven Rostedt
On Mon, 22 Mar 2021 22:49:58 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > With 'make W=1', gcc warns about casts between incompatible function > types: > > kernel/trace/ftrace.c:128:31: error: cast between incompatible function types > from 'void (*)(long unsigned int, long unsigned

[PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users

2021-03-22 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The tab stop for Perl files is by default (at least in emacs) to be 4 spaces, where a tab is used for all 8 spaces. Add a local variable comment to make vim do the same by default, and this will help keep the file consistent in the future when others e

[PATCH 0/2] streamline_config.pl: Fix Perl spacing

2021-03-22 Thread Steven Rostedt
variable to make vim act like emacs by default. Steven Rostedt (VMware) (2): streamline_config.pl: Make spacing consistent streamline_config.pl: Add softtabstop=4 for vim users scripts/kconfig/streamline_config.pl | 80 ++-- 1 file changed, 41 insertions

[PATCH 1/2] streamline_config.pl: Make spacing consistent

2021-03-22 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" As Perl code tends to have 4 space indentation, but uses tabs for every 8 spaces, make that consistent in the streamline_config.pl code. Replace all 8 spaces with a single tab. Signed-off-by: Steven Rostedt (VMware) --- scripts/kconfig/streamline_conf

Re: your mail

2021-03-22 Thread Steven Rostedt
On Mon, Mar 22, 2021 at 05:36:44PM -0400, Steven Rostedt wrote: $@#@#$%%% Bah! There was another typo in the email list! Take 3 -- Steve

[no subject]

2021-03-22 Thread Steven Rostedt

[no subject]

2021-03-22 Thread Steven Rostedt

Re: your mail

2021-03-22 Thread Steven Rostedt
On Mon, Mar 22, 2021 at 05:21:56PM -0400, Steven Rostedt wrote: Bah! John 'Warthog' Hawley email had those single quotes in it that I cut and pasted into the Cc list, causing the quilt mail parsing to fail, but as LKML was in the "To" part, it still sent! Take 2 -- Steve

Re: [PATCH] static_call: fix function type mismatch

2021-03-22 Thread Steven Rostedt
On Mon, 22 Mar 2021 22:18:17 +0100 Arnd Bergmann wrote: > I think the code works correctly on all architectures we support because > both 'int' and 'long' are returned in a register with any unused bits cleared. > It is however undefined behavior in C because 'int' and 'long' are not >

[no subject]

2021-03-22 Thread Steven Rostedt

[no subject]

2021-03-22 Thread Steven Rostedt

Re: [PATCH] static_call: fix function type mismatch

2021-03-22 Thread Steven Rostedt
On Mon, 22 Mar 2021 18:06:37 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > The __static_call_return0() function is declared to return a 'long', > while it aliases a couple of functions that all return 'int'. When > building with 'make W=1', gcc warns about this: > >

Re: [PATCH RFC 0/3] drivers/char: remove /dev/kmem for good

2021-03-22 Thread Steven Rostedt
On Mon, 22 Mar 2021 11:08:47 +0100 David Hildenbrand wrote: > > Wonder if "echo c > /proc/sysrq-trigger" already existed and would have > worked back then. :) > > Looks like sysrq-c was added in 2005: commit 86b1ae38c0a62 ("kdump: sysrq trigger mechanism for kexec based crashdumps") Thus

Re: [PATCH -tip v4 12/12] tracing: Show kretprobe unknown indicator only for kretprobe_trampoline

2021-03-22 Thread Steven Rostedt
On Mon, 22 Mar 2021 15:42:02 +0900 Masami Hiramatsu wrote: > ftrace shows "[unknown/kretprobe'd]" indicator all addresses in the > kretprobe_trampoline, but the modified address by kretprobe should > be only kretprobe_trampoline+0. > > Signed-off-by: Masami Hiramatsu

Re: [PATCH 2/3] cpumask: Introduce DYING mask

2021-03-22 Thread Steven Rostedt
On Sun, 21 Mar 2021 19:30:37 + Qais Yousef wrote: > On 03/10/21 15:53, Peter Zijlstra wrote: > > --- a/kernel/cpu.c > > +++ b/kernel/cpu.c > > @@ -160,6 +160,9 @@ static int cpuhp_invoke_callback(unsigne > > int (*cb)(unsigned int cpu); > > int ret, cnt; > > > > + if (bringup !=

Re: [PATCH v7 2/2] ARM: ftrace: Add MODULE_PLTS support

2021-03-22 Thread Steven Rostedt
On Sun, 21 Mar 2021 19:06:11 + Qais Yousef wrote: > #ifdef CONFIG_DYNAMIC_FTRACE > struct dyn_arch_ftrace { > -#ifdef CONFIG_ARM_MODULE_PLTS > struct module *mod; > -#endif > }; > I know you want to reduce the "ifdefery", but please note that the dyn_arch_ftrace is defined once

Re: [PATCH 3/3] static_call: Fix static_call_update() sanity check

2021-03-19 Thread Steven Rostedt
On Fri, 19 Mar 2021 20:34:24 +0100 Peter Zijlstra wrote: > On Fri, Mar 19, 2021 at 02:00:05PM -0400, Steven Rostedt wrote: > > Would making __exit code the same as init code work? That is, load it just > > like module init code is loaded, and free it when the init code is freed

[for-next][PATCH 10/13] ftrace: Fix spelling mistake "disabed" -> "disabled"

2021-03-19 Thread Steven Rostedt
From: Colin Ian King There is a spelling mistake in a comment, fix it. Link: https://lkml.kernel.org/r/20210311094022.5978-1-colin.k...@canonical.com Signed-off-by: Colin Ian King Signed-off-by: Steven Rostedt (VMware) --- arch/csky/kernel/probes/ftrace.c | 2 +- arch/riscv/kernel/probes

[for-next][PATCH 12/13] seq_buf: Add seq_buf_terminate() API

2021-03-19 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" In the case that the seq_buf buffer needs to be printed directly, add a way to make sure that the buffer is safe to read by forcing a nul terminating character at the end of the string, or the last byte of the buffer if the string has overflowed.

[for-next][PATCH 13/13] tracing: Add a verifier to check string pointers for trace events

2021-03-19 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" It is a common mistake for someone writing a trace event to save a pointer to a string in the TP_fast_assign() and then display that string pointer in the TP_printk() with %s. The problem is that those two events may happen a long time apart, where

[for-next][PATCH 11/13] tracing: Add check of trace event print fmts for dereferencing pointers

2021-03-19 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Trace events record data into the ring buffer at the time of the event. The trace event has a printf logic to display the recorded data at a much later time when the user reads the trace file. This makes using dereferencing pointers unsafe if the de

[for-next][PATCH 00/13] tracing: Updates for 5.13

2021-03-19 Thread Steven Rostedt
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next Head SHA1: 9a6944fee68e25084130386c608c5ac8db487581 Cao jin (1): bootconfig: Update prototype of setup_boot_config() Colin Ian King (1): ftrace: Fix spelling mistake "disabed" -> "

[for-next][PATCH 02/13] ring-buffer: Add a event_stamp to cpu_buffer for each level of nesting

2021-03-19 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Add a place to save the current event time stamp for each level of nesting. This will be used to retrieve the time stamp of the current event before it is committed. Link: https://lkml.kernel.org/r/20210316164113.399089...@goodmis.org Reviewed-by: T

[for-next][PATCH 01/13] ring-buffer: Separate out internal use of ring_buffer_event_time_stamp()

2021-03-19 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The exported use of ring_buffer_event_time_stamp() is going to become different than how it is used internally. Move the internal logic out into a static function called rb_event_time_stamp(), and have the internal callers call that instead. L

[for-next][PATCH 03/13] tracing: Pass buffer of event to trigger operations

2021-03-19 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The ring_buffer_event_time_stamp() is going to be updated to extract the time stamp for the event without needing it to be set to have absolute values for all events. But to do so, it needs the buffer that the event is on as the buffer saves i

[for-next][PATCH 04/13] ring-buffer: Allow ring_buffer_event_time_stamp() to return time stamp of all events

2021-03-19 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Currently, ring_buffer_event_time_stamp() only returns an accurate time stamp of the event if it has an absolute extended time stamp attached to it. To make it more robust, use the event_stamp() in case the event does not have an absolute valu

[for-next][PATCH 05/13] tracing: Use a no_filter_buffering_ref to stop using the filter buffer

2021-03-19 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Currently, the trace histograms relies on it using absolute time stamps to trigger the tracing to not use the temp buffer if filters are set. That's because the histograms need the full timestamp that is saved in the ring buffer. That is no longe

[for-next][PATCH 06/13] ring-buffer: Add verifier for using ring_buffer_event_time_stamp()

2021-03-19 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The ring_buffer_event_time_stamp() must be only called by an event that has not been committed yet, and is on the buffer that is passed in. This was used to help debug converting the histogram logic over to using the new time stamp code, and was proven

[for-next][PATCH 07/13] tracing: Add tracing_event_time_stamp() API

2021-03-19 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Add a tracing_event_time_stamp() API that checks if the event passed in is not on the ring buffer but a pointer to the per CPU trace_buffered_event which does not have its time stamp set yet. If it is a pointer to the trace_buffered_event, then j

[for-next][PATCH 08/13] bootconfig: Update prototype of setup_boot_config()

2021-03-19 Thread Steven Rostedt
From: Cao jin Parameter "cmdline" has no use, drop it. Link: https://lkml.kernel.org/r/20210311085213.27680-1-jojin...@gmail.com Acked-by: Masami Hiramatsu Signed-off-by: Cao jin Signed-off-by: Steven Rostedt (VMware) --- init/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[for-next][PATCH 09/13] tools/latency-collector: Remove unneeded semicolon

2021-03-19 Thread Steven Rostedt
From: Xu Wang Fix semicolon.cocci warning: tools/tracing/latency/latency-collector.c:1021:2-3: Unneeded semicolon Link: https://lkml.kernel.org/r/20210308022459.59881-1-vu...@iscas.ac.cn Reviewed-by: Viktor Rosendahl Signed-off-by: Xu Wang Signed-off-by: Steven Rostedt (VMware) --- tools

Re: [PATCH RFC 0/3] drivers/char: remove /dev/kmem for good

2021-03-19 Thread Steven Rostedt
On Fri, 19 Mar 2021 15:34:49 +0100 David Hildenbrand wrote: > Let's start a discussion if /dev/kmem is worth keeping around and > fixing/maintaining or if we should just remove it now for good. The last time I used /dev/kmem was in 2003. While in Germany, my home firewall (in the US) got

Re: [PATCH 3/3] static_call: Fix static_call_update() sanity check

2021-03-19 Thread Steven Rostedt
On Fri, 19 Mar 2021 13:57:38 +0100 Peter Zijlstra wrote: > Jessica, can you explain how !MODULE_UNLOAD is supposed to work? > Alternatives, jump_labels and static_call all can have relocations into > __exit code. Not loading it at all would be BAD. According to the description: " Without this

[GIT PULL] workqueue/tracing: Copy workqueue name to buffer in trace event

2021-03-19 Thread Steven Rostedt
: 83b62687a05205847d627f29126a8fee3c644335 Steven Rostedt (VMware) (1): workqueue/tracing: Copy workqueue name to buffer in trace event include/trace/events/workqueue.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- commit

[PATCH] workqueue/tracing: Copy workqueue name to buffer in trace event

2021-03-18 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The trace event "workqueue_queue_work" references an unsafe string in dereferencing the name of the workqueue. As the name is allocated, it could later be freed, and the pointer to that string could stay on the tracing buffer. If the trace

Re: [PATCH] ftrace: Fix spelling mistake "disabed" -> "disabled"

2021-03-17 Thread Steven Rostedt
On Tue, 16 Mar 2021 21:21:08 -0700 (PDT) Palmer Dabbelt wrote: > Thanks, this is on fixes. What does this mean? Is there a tree that spelling fixes go through now? I had already pulled this patch into my queue for the next merge window (and it's still in the testing phase with other patches

Re: [PATCH 0/7 v2] tracing: Have ring_buffer_event_time_stamp() work for all events

2021-03-16 Thread Steven Rostedt
On Tue, 16 Mar 2021 16:16:03 -0500 Tom Zanussi wrote: > This all looks fine to me. > > Reviewed-by: Tom Zanussi > Thanks! -- Steve

[PATCH 1/7 v2] ring-buffer: Separate out internal use of ring_buffer_event_time_stamp()

2021-03-16 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The exported use of ring_buffer_event_time_stamp() is going to become different than how it is used internally. Move the internal logic out into a static function called rb_event_time_stamp(), and have the internal callers call that instead. Signed-off-

[PATCH 2/7 v2] ring-buffer: Add a event_stamp to cpu_buffer for each level of nesting

2021-03-16 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Add a place to save the current event time stamp for each level of nesting. This will be used to retrieve the time stamp of the current event before it is committed. Signed-off-by: Steven Rostedt (VMware) --- kernel/trace/ring_buffer.c | 11 +

<    5   6   7   8   9   10   11   12   13   14   >