[PATCHv5 04/15] hwspinlock/core: add common OF helpers

2014-04-30 Thread Suman Anna
lock using the phandle + args specifier. This function relies on the implementation providing back a relative hwlock id within the bank from the args specifier. Signed-off-by: Suman Anna --- Documentation/hwspinlock.txt | 34 ++- drivers/hwspinlock/hwspinlock_core.c

[PATCHv5 02/15] Documentation: dt: add the omap hwspinlock bindings document

2014-04-30 Thread Suman Anna
HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the DT bindings information for OMAP hwspinlock module. Cc: Rob Herring Signed-off-by: Suman Anna --- .../devicetree/bindings/hwlock/omap-hwspinlock.txt | 24

[PATCHv5 07/15] hwspinlock/omap: enable build for AM33xx, AM43xx & DRA7xx

2014-04-30 Thread Suman Anna
. Signed-off-by: Suman Anna --- drivers/hwspinlock/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig index 70637d2..3612cb5 100644 --- a/drivers/hwspinlock/Kconfig +++ b/drivers/hwspinlock/Kconfig @@ -10,7 +10,7

[PATCHv5 06/15] hwspinlock/omap: enable module before reading SYSSTATUS register

2014-04-30 Thread Suman Anna
tware controlled, and it is disabled out of reset. Make sure the module is enabled and clocked before reading the SYSSTATUS register. Signed-off-by: Suman Anna --- drivers/hwspinlock/omap_hwspinlock.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/dr

[PATCHv5 RFC 09/15] hwspinlock/core: prepare unregister code to support reserved locks

2014-04-30 Thread Suman Anna
Rearrange the code between hwspin_lock_unregister() and the underlying hwspin_lock_unregister_single() functions so that the semantics are similar to the _register_ functions. This change prepares the hwspinlock driver core to support unregistration of reserved locks better. Signed-off-by: Suman

[PATCHv5 RFC 08/15] hwspinlock/core: add support for base id in DT

2014-04-30 Thread Suman Anna
'hwlock-base-id', and retrieve the value through a core OF helper function, of_hwspin_lock_get_base_id(). The representation in DT provides a uniform way of assigning a fixed base value for a hwspinlock device across different SoCs. Signed-off-by: Suman Anna --- Documentation/devicetre

[PATCHv5 RFC 10/15] hwspinlock/core: prepare core to support reserved locks

2014-04-30 Thread Suman Anna
reserved locks. A new element is added to struct hwlock to identify whether it is reserved to be allocated using the hwspin_lock_request_specific() variants or available for dynamic allocation. A new tag name, HWSPINLOCK_RESERVED, is introduced to mark the reserved locks as such. Signed-off-by: Suman

[PATCHv5 RFC 12/15] hwspinlock/core: add OF helper to parse reserved locks

2014-04-30 Thread Suman Anna
t platform implementations. The function will return a value of 0 if the property is not defined, so as to support a default behavior of marking all locks as unused and open for anonymous allocations. Signed-off-by: Suman Anna --- .../devicetree/bindings/hwlock/hwlock.txt | 3 +++ drivers/

[PATCHv5 RFC 13/15] hwspinlock/omap: use OF helper to get reserved locks

2014-04-30 Thread Suman Anna
Retrieve the number of reserved locks for OMAP by using the of_hwspin_lock_get_num_reserved_locks() OF helper function provided by the hwspinlock core. The range sanity check will be performed by the hwspinlock core during the registration. Signed-off-by: Suman Anna --- drivers/hwspinlock

[PATCHv5 RFC 14/15] hwspinlock/core: return ERR_PTRs on failure in _request_ api

2014-04-30 Thread Suman Anna
client api functions are also modified to check for an invalid hwlock handle. The consumers MUST check using IS_ERR() when requesting hwlocks going forward to determine a valid hwlock. Signed-off-by: Suman Anna --- TODO: Move this patch before the Patch4, "hwspinlock/core: add comm

[PATCHv5 RFC 15/15] hwspinlock/core: change return codes of_hwspin_lock_request_specific

2014-04-30 Thread Suman Anna
Changed the return statements to return an ERR_PTR instead of NULL in case of an error. This patch helps with deferred probing of any client users if the corresponding hwspinlock bank is not yet registered with the hwspinlock core. Signed-off-by: Suman Anna --- TODO: Collapse into Patch4

[PATCHv5 05/15] hwspinlock/omap: add support for dt nodes

2014-04-30 Thread Suman Anna
HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the base support for parsing the DT nodes, and removes the code dealing with the traditional platform device instantiation. Signed-off-by: Suman Anna [t...@atomide.com: ack for

[PATCHv5 RFC 11/15] hwspinlock/core: add support for reserved locks

2014-04-30 Thread Suman Anna
tions have also been updated to adjust for the change of the registration API. Signed-off-by: Suman Anna --- drivers/hwspinlock/hwspinlock_core.c | 20 drivers/hwspinlock/hwspinlock_internal.h | 3 +++ drivers/hwspinlock/omap_hwspinlock.c | 4 ++-- drivers/

Re: [PATCHv5 01/15] Documentation: dt: add common bindings for hwspinlock

2014-05-02 Thread Suman Anna
Hi Rob, On 05/02/2014 09:58 AM, Rob Herring wrote: > On Wed, Apr 30, 2014 at 7:34 PM, Suman Anna wrote: >> This patch adds the generic common bindings used to represent >> a hwlock device and use/request locks in a device-tree build. >> >> All the platform-specific hw

Re: [PATCHv5 RFC 12/15] hwspinlock/core: add OF helper to parse reserved locks

2014-05-09 Thread Suman Anna
Hi Josh, On 05/05/2014 04:54 PM, Josh Cartwright wrote: > On Mon, May 05, 2014 at 04:44:25PM -0500, Suman Anna wrote: >> Hi Rob, >> >> On 04/30/2014 07:34 PM, Suman Anna wrote: >>> The property 'hwlock-reserved-locks' will be used to represent >>&g

[PATCHv2 0/5] OMAP Mailbox framework adoption & DT support

2014-07-11 Thread Suman Anna
tp://www.spinics.net/lists/linux-omap/msg108574.html Suman Anna (5): Documentation: dt: add omap mailbox bindings mailbox/omap: add support for parsing dt devices ARM: dts: OMAP2+: Add sub mailboxes device node information mailbox/omap: adapt to the new mailbox framework ARM: dts: O

[PATCHv2 2/5] mailbox/omap: add support for parsing dt devices

2014-07-11 Thread Suman Anna
driver compatible match data. The non-DT support has to be maintained for now to not break OMAP3 legacy boot, and the legacy-style code will be cleaned up once OMAP3 is also converted to DT-boot only. Cc: Jassi Brar Cc: Rob Herring Signed-off-by: Suman Anna --- drivers/mailbox/omap-mailbox.c | 156

[PATCHv2 1/5] Documentation: dt: add omap mailbox bindings

2014-07-11 Thread Suman Anna
Add the device tree bindings document for OMAP2+ mailbox. Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Signed-off-by: Suman Anna --- .../devicetree/bindings/mailbox/omap-mailbox.txt | 111 + 1 file changed, 111 insertions(+) create

[PATCHv2 3/5] ARM: dts: OMAP2+: Add sub mailboxes device node information

2014-07-11 Thread Suman Anna
omap_mbox_dev_info structure used in the hwmod data. Cc: "Benoît Cousson" Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Signed-off-by: Suman Anna --- arch/arm/boot/dts/am33xx.dtsi | 4 arch/arm/boot/dts/am4372.dtsi | 4 arch/arm/boot/dt

[PATCHv2 5/5] ARM: dts: OMAP2+: Add #mbox-cells property to all mailbox nodes

2014-07-11 Thread Suman Anna
The '#mbox-cells' property is added to all the OMAP mailbox nodes. This property is mandatory with the new mailbox framework. Cc: "Benoît Cousson" Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Signed-off-by: Suman Anna --- arch/arm/

[PATCHv2 4/5] mailbox/omap: adapt to the new mailbox framework

2014-07-11 Thread Suman Anna
Omar Ramirez Luna Cc: Greg Kroah-Hartman Signed-off-by: Suman Anna --- .../devicetree/bindings/mailbox/omap-mailbox.txt | 24 ++ drivers/mailbox/omap-mailbox.c | 343 - drivers/remoteproc/omap_remoteproc.c | 54 ++-- drivers/staging/tidspbr

Re: [PATCHv2 0/5] OMAP Mailbox framework adoption & DT support

2014-07-14 Thread Suman Anna
Hi Markus, On 07/11/2014 06:15 PM, Markus Mayer wrote: > On 11 July 2014 15:04, Suman Anna wrote: >> Hi, >> >> This is a refresh of the OMAP Mailbox framework adoption & DT support >> series [1], to work with the revised OMAP mailbox DT/hwmod cleanup >> seri

Re: [PATCHv2 0/5] OMAP Mailbox framework adoption & DT support

2014-07-14 Thread Suman Anna
Hi Markus, > >> There are couple of dependent preparatory series. You probably missed >> the following in the cover letter. >>> The series depends on the OMAP mailbox cleanup series [5] and the >>> refreshed OMAP mailbox DT/hwmod cleanup series [2]. >> >> As long as you pick the two dependent seri

Re: [PATCH 2/6] mailbox/omap: add support for parsing dt devices

2014-06-30 Thread Suman Anna
Hi Pavel, > The non-DT support has to be maintained for now to not break OMAP3 legacy boot, and the legacy-style code will be cleaned up once OMAP3 is also converted to DT-boot only. >>> @@ -587,24 +606,157 @@ static int omap_mbox_unregister(struct omap_mbox_device *mdev)

Re: [PATCHv5 06/15] hwspinlock/omap: enable module before reading SYSSTATUS register

2014-07-02 Thread Suman Anna
Hi Ohad, On 07/01/2014 07:51 AM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Thu, May 1, 2014 at 3:34 AM, Suman Anna wrote: >> The number of hwspinlocks are determined based on the value read >> from the IP block's SYSSTATUS register. However, the module may >> not

Re: [PATCHv5 05/15] hwspinlock/omap: add support for dt nodes

2014-07-02 Thread Suman Anna
Hi Ohad, On 07/01/2014 07:48 AM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Thu, May 1, 2014 at 3:34 AM, Suman Anna wrote: >> static int omap_hwspinlock_probe(struct platform_device *pdev) >> { >> - struct hwspinlock_pdata *pdata = pdev->dev.platform_data;

Re: [PATCHv5 04/15] hwspinlock/core: add common OF helpers

2014-07-02 Thread Suman Anna
Hi Ohad, > > On Thu, May 1, 2014 at 3:34 AM, Suman Anna wrote: >> 2. The of_hwspin_lock_simple_xlate() is a simple default >>translator function for hwspinlock provider implementations >>that use a single cell number for requesting a specific lock >>

Re: [PATCHv5 03/15] hwspinlock/core: maintain a list of registered hwspinlock banks

2014-07-02 Thread Suman Anna
Hi Ohad, On 07/01/2014 07:26 AM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Thu, May 1, 2014 at 3:34 AM, Suman Anna wrote: >> >> The hwspinlock_device structure is used for registering a bank of >> locks with the driver core. The structure already contains the >>

Re: [PATCHv5 03/15] hwspinlock/core: maintain a list of registered hwspinlock banks

2014-07-03 Thread Suman Anna
Hi Ohad, On 07/03/2014 02:00 AM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Thu, Jul 3, 2014 at 12:14 AM, Suman Anna wrote: >>> I'm not sure we need this patch. >> >> This patch is needed if we use the controller-phandle + args specifier >> for requ

Re: [PATCHv5 04/15] hwspinlock/core: add common OF helpers

2014-07-03 Thread Suman Anna
Hi Ohad, On 07/03/2014 02:15 AM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Thu, Jul 3, 2014 at 12:14 AM, Suman Anna wrote: >>> Do we have a use case today that require the xlate() method? >>> >>> If not, let's remove it as we could always add it back if

[PATCH] rpmsg: compute number of buffers to allocate from vrings

2014-07-03 Thread Suman Anna
ff-by: Suman Anna --- drivers/rpmsg/virtio_rpmsg_bus.c | 41 +--- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c index b6135d4..e9866a6 100644 --- a/drivers/rpmsg/virtio_rpmsg_

Re: [PATCH 2/6] mailbox/omap: add support for parsing dt devices

2014-06-30 Thread Suman Anna
Hi Pavel, On 06/28/2014 12:07 PM, Pavel Machek wrote: > Hi! > >> The non-DT support has to be maintained for now to not break >> OMAP3 legacy boot, and the legacy-style code will be cleaned >> up once OMAP3 is also converted to DT-boot only. > >> @@ -587,24 +606,157 @@ static int omap_mbox_unreg

Re: [PATCHv5 03/15] hwspinlock/core: maintain a list of registered hwspinlock banks

2014-07-08 Thread Suman Anna
Hi Ohad, On 07/04/2014 12:01 AM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Thu, Jul 3, 2014 at 8:28 PM, Suman Anna wrote: >> OK, but we would still require this function to lookup the registered >> device from the controller-phandle to retrieve the base_id. > > Can w

Re: [PATCHv5 04/15] hwspinlock/core: add common OF helpers

2014-07-08 Thread Suman Anna
Hi Ohad, On 07/03/2014 11:58 PM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Thu, Jul 3, 2014 at 8:35 PM, Suman Anna wrote: >> Not at the moment, with the existing platform implementations. So, if I >> understand you correctly, you are asking to leave out the xlat

[PATCH 1/2] remoteproc: use a flag to detect the presence of IOMMU

2014-07-08 Thread Suman Anna
patch. Cc: Sjur Brændeland Cc: Robert Tivy Signed-off-by: Suman Anna --- drivers/remoteproc/omap_remoteproc.c | 6 ++ drivers/remoteproc/remoteproc_core.c | 15 ++- include/linux/remoteproc.h | 2 ++ 3 files changed, 10 insertions(+), 13 deletions(-) diff --git a/dr

[PATCH 2/2] remoteproc: add support to handle internal memories

2014-07-08 Thread Suman Anna
nstead. Signed-off-by: Robert Tivy Signed-off-by: Suman Anna --- drivers/remoteproc/remoteproc_core.c | 85 +++- include/linux/remoteproc.h | 43 +- 2 files changed, 126 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/remot

[PATCH 0/2] couple of generic remoteproc enhancements

2014-07-08 Thread Suman Anna
submit soon. The two patches are based on 3.16-rc4 and are technically independent of each other, but submitting them together as the WkupM3 remoteproc driver would need both of them. regards Suman Suman Anna (2): remoteproc: use a flag to detect the presence of IOMMU remoteproc: add support to

Re: [PATCH 2/6] mailbox/omap: add support for parsing dt devices

2014-07-08 Thread Suman Anna
Hi Tony, Pavel, On 07/04/2014 03:23 AM, Tony Lindgren wrote: > * Pavel Machek [140704 01:07]: >> Hi! >> > The non-DT support has to be maintained for now to not break > OMAP3 legacy boot, and the legacy-style code will be cleaned > up once OMAP3 is also converted to DT-boo

Re: [PATCH 2/6] mailbox/omap: add support for parsing dt devices

2014-07-09 Thread Suman Anna
On 07/09/2014 03:29 AM, Tony Lindgren wrote: > * Suman Anna [140708 10:57]: >> Hi Tony, Pavel, >> >> On 07/04/2014 03:23 AM, Tony Lindgren wrote: >>> * Pavel Machek [140704 01:07]: >>>> Hi! >>>> >>>>>>>>>>>

Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox

2014-07-16 Thread Suman Anna
Hi, On 07/16/2014 09:18 AM, Jassi Brar wrote: > On 16 July 2014 19:38, Arnd Bergmann wrote: >> On Wednesday 16 July 2014 18:42:22 Jassi Brar wrote: >>> On 16 July 2014 18:39, Arnd Bergmann wrote: On Wednesday 16 July 2014 18:35:33 Jassi Brar wrote: > On 16 July 2014 18:15, Arnd Bergmann

Re: [PATCHv2 2/5] mailbox/omap: add support for parsing dt devices

2014-07-16 Thread Suman Anna
Hi Markus, On 07/16/2014 03:50 PM, Markus Mayer wrote: > If I may nit-pick here for a minute... > > On 11 July 2014 15:04, Suman Anna wrote: >> Logic has been added to the OMAP2+ mailbox code to parse the >> mailbox dt nodes and construct the different sub-mailboxes &

Re: [PATCH] mailbox/omap: Use module_platform_driver

2014-07-22 Thread Suman Anna
Hi Tobias, On 07/22/2014 07:13 AM, Tobias Klauser wrote: > Use the module_platform_driver to omit module init/exit boilerplate code. > > Signed-off-by: Tobias Klauser > --- > drivers/mailbox/mailbox-omap1.c | 13 + > drivers/mailbox/mailbox-omap2.c | 13 + > 2 files chan

Re: [PATCH] mailbox/omap: Use module_platform_driver

2014-07-22 Thread Suman Anna
On 07/22/2014 07:57 PM, Jingoo Han wrote: > On Wednesday, July 23, 2014 12:01 AM, Suman Anna wrote: >> On 07/22/2014 07:13 AM, Tobias Klauser wrote: >>> Use the module_platform_driver to omit module init/exit boilerplate code. >>> >>> Signed-off-by: Tobias K

Re: [PATCH 0/2] ARM: DRA7: hwmod: Add dra74x and dra72x specific ocp interface lists

2014-07-23 Thread Suman Anna
Hi Lokesh, On 07/22/2014 11:06 PM, Vutla, Lokesh wrote: > Hi Nishanth, > On Tuesday 22 July 2014 10:15 PM, Nishanth Menon wrote: >> On 07/16/2014 03:36 AM, Lokesh Vutla wrote: >>> This series add seperate ocp interface lists that are specific to dra74x >>> and dra72x, and moving USB OTG SS4 to dra

Re: [PATCH 1/2] ARM: DRA7: Add support for soc_is_dra74x() and soc_is_dra72x() varients

2014-07-23 Thread Suman Anna
On 07/16/2014 03:36 AM, Vutla, Lokesh wrote: > From: Rajendra Nayak > > Use the corresponding compatibles to identify the devices. > > Signed-off-by: Rajendra Nayak > Signed-off-by: Lokesh Vutla > --- > arch/arm/mach-omap2/soc.h |7 +++ > 1 file changed, 7 insertions(+) > > diff --gi

Re: [PATCH v1] gpio: keystone: add dsp gpio controller driver

2014-07-24 Thread Suman Anna
Hi, On 07/24/2014 01:12 PM, Jassi Brar wrote: > On 24 July 2014 22:52, Santosh Shilimkar wrote: >> On Thursday 24 July 2014 01:19 PM, Jassi Brar wrote: >>> On 23 July 2014 20:40, Linus Walleij wrote: On Wed, Jul 16, 2014 at 12:43 PM, Grygorii Strashko wrote: > From: Murali Ka

Re: [PATCH v2] gpio: keystone: add dsp gpio controller driver

2014-07-24 Thread Suman Anna
Grygorii, On 07/23/2014 09:44 AM, Strashko, Grygorii wrote: > From: Murali Karicheri > > On Keystone SOCs, ARM host can send interrupts to DSP cores using the > DSP GPIO controller IP. Each DSP GPIO controller provides 28 IRQ signals for > each DSP core. This is one of the component used by the

Re: [PATCHv4 0/7] omap hwspinlock dt support

2014-03-31 Thread Suman Anna
On 03/18/2014 08:35 AM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Tue, Mar 18, 2014 at 1:46 AM, Suman Anna wrote: >> So far, we have not come across multiple controllers. I see your point, >> and I think this also depends on the semantics of how you exchange the >> lo

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-28 Thread Suman Anna
On 05/27/2014 11:20 PM, Jassi Brar wrote: > On Wed, May 21, 2014 at 10:57 PM, Mark Brown wrote: >> On Thu, May 15, 2014 at 11:41:00AM +0530, Jassi Brar wrote: >>> Introduce common framework for client/protocol drivers and >>> controller drivers of Inter-Processor-Communication (IPC). >> >> This lo

Re: [PATCHv5 RFC 08/15] hwspinlock/core: add support for base id in DT

2014-05-05 Thread Suman Anna
Hi Rob, On 05/05/2014 03:37 PM, Rob Herring wrote: > On Wed, Apr 30, 2014 at 7:34 PM, Suman Anna wrote: >> The HwSpinlock core requires a base id for registering a bank >> of hwspinlocks. This base id needs to be unique across multiple >> IP instances of a hwspinlock device

Re: [PATCHv5 RFC 12/15] hwspinlock/core: add OF helper to parse reserved locks

2014-05-05 Thread Suman Anna
Hi Rob, On 04/30/2014 07:34 PM, Suman Anna wrote: > The property 'hwlock-reserved-locks' will be used to represent > the number of locks to be reserved for clients that would need > to request/operate on specific locks. A new OF helper function, > of_hwspin_lock_get_num_rese

[PATCH 0/6] OMAP Mailbox framework adoption & DT support

2014-06-24 Thread Suman Anna
65705821115&w=2 [4] http://marc.info/?l=linux-omap&m=140365833121612&w=2 Suman Anna (6): Documentation: dt: add omap mailbox bindings mailbox/omap: add support for parsing dt devices ARM: dts: OMAP2+: Add sub mailboxes device node information mailbox/omap: adapt to the new mailbox frame

[PATCH 2/6] mailbox/omap: add support for parsing dt devices

2014-06-24 Thread Suman Anna
driver compatible match data. The non-DT support has to be maintained for now to not break OMAP3 legacy boot, and the legacy-style code will be cleaned up once OMAP3 is also converted to DT-boot only. Cc: Jassi Brar Cc: Rob Herring Signed-off-by: Suman Anna --- drivers/mailbox/omap-mailbox.c | 201

[PATCH 3/6] ARM: dts: OMAP2+: Add sub mailboxes device node information

2014-06-24 Thread Suman Anna
omap_mbox_dev_info structure used in the hwmod data. Cc: "Benoît Cousson" Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Signed-off-by: Suman Anna --- arch/arm/boot/dts/am33xx.dtsi | 4 arch/arm/boot/dts/am4372.dtsi | 4 arch/arm/boot/dt

[PATCH 1/6] Documentation: dt: add omap mailbox bindings

2014-06-24 Thread Suman Anna
Add the device tree bindings document for OMAP2+ mailbox. Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Signed-off-by: Suman Anna --- .../devicetree/bindings/mailbox/omap-mailbox.txt | 104 + 1 file changed, 104 insertions(+) create

[PATCH 6/6] mailbox/omap: add a custom of_xlate function

2014-06-24 Thread Suman Anna
phandles for the pargs specifier instead of indexing to avoid any channel registration order dependencies. Cc: Jassi Brar Signed-off-by: Suman Anna --- drivers/mailbox/omap-mailbox.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/mailbox/omap-mailbox.c b

[PATCH 5/6] ARM: dts: OMAP2+: Add #mbox-cells property to all mailbox nodes

2014-06-24 Thread Suman Anna
The '#mbox-cells' property is added to all the OMAP mailbox nodes. This property is mandatory with the new mailbox framework. Cc: "Benoît Cousson" Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Signed-off-by: Suman Anna --- arch/arm/

[PATCH 4/6] mailbox/omap: adapt to the new mailbox framework

2014-06-24 Thread Suman Anna
API mbox_request_channel, and will be removed once OMAP3 becomes DT-boot only. Cc: Jassi Brar Cc: Ohad Ben-Cohen Cc: Omar Ramirez Luna Cc: Greg Kroah-Hartman Signed-off-by: Suman Anna --- drivers/mailbox/omap-mailbox.c | 320 +++-- drivers/remoteproc/omap_remotepr

Re: [PATCH 6/6] mailbox/omap: add a custom of_xlate function

2014-06-25 Thread Suman Anna
Hi Arnd, On 06/25/2014 03:39 AM, Arnd Bergmann wrote: > On Tuesday 24 June 2014 20:47:58 Suman Anna wrote: >> +static struct mbox_chan *omap_mbox_of_xlate(struct mbox_controller >> *controller, >> + const struc

Re: [PATCHv3 0/5] OMAP Mailbox framework adoption & DT support

2014-09-09 Thread Suman Anna
Hi Tony, On 09/08/2014 09:52 PM, Tony Lindgren wrote: > * Tony Lindgren [140908 16:21]: >> * Suman Anna [140729 17:37]: >>> Hi, >>> >>> This is an updated version of the OMAP Mailbox framework adoption & >>> DT support series, refreshed to work

Re: [PATCHv10 0/4] Common Mailbox Framework

2014-09-09 Thread Suman Anna
Jassi, On 08/02/2014 02:48 AM, Jassi Brar wrote: > On 1 August 2014 23:56, Mark Brown wrote: >> On Fri, Aug 01, 2014 at 05:59:54PM +0530, Jassi Brar wrote: >>> Hello, >>> Here's v10. Not much different from v9. The code and the generic >>> bindings looked good enough to relevant gods, but the pa

Re: [PATCH] rpmsg: compute number of buffers to allocate from vrings

2014-08-12 Thread Suman Anna
Hi Ohad, On 08/12/2014 10:30 AM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Thu, Jul 3, 2014 at 11:53 PM, Suman Anna wrote: >> The buffers to be used for communication are allocated during >> the rpmsg virtio driver's probe, and the number of buffers is >> currentl

Re: [PATCH] rpmsg: compute number of buffers to allocate from vrings

2014-08-13 Thread Suman Anna
Hi Ohad, On 08/13/2014 08:40 AM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Tue, Aug 12, 2014 at 7:19 PM, Suman Anna wrote: >> Yes, I was playing around with using less buffers in the remoteproc >> resource table for the vrings. The remoteproc virtio code creates the >>

Re: [PATCH 1/2] remoteproc: use a flag to detect the presence of IOMMU

2014-08-04 Thread Suman Anna
On 08/04/2014 06:50 AM, Ohad Ben-Cohen wrote: > On Tue, Jul 29, 2014 at 7:10 PM, Suman Anna wrote: >> We are trying to add a remoteproc driver for a small Cortex M3 called >> the WkupM3 used for suspend/resume management on TI AM335/AM437x SoCs. >> This processor does not hav

Re: [GIT PULL] New Mailbox framework for 3.18

2014-10-21 Thread Suman Anna
Hi, On 10/21/2014 02:43 AM, Arnd Bergmann wrote: > On Monday 20 October 2014 15:23:38 Jassi Brar wrote: >> On 8 October 2014 11:09, Jassi Brar wrote: >>> Hi Linus, >>> >>> A framework for Mailbox controllers and clients have been cooking for >>> more than a year now. Everybody in the CC list had

Re: [PATCHv4 4/7] hwspinlock/core: add common OF helpers

2014-11-06 Thread Suman Anna
Hi Ohad, On 10/06/2014 04:44 AM, Ohad Ben-Cohen wrote: > On Fri, Sep 26, 2014 at 7:25 PM, Suman Anna wrote: >> I am yet to receive any comments on v6, but that series should address >> both your need for a probe deferral and Ohad's request to not change any >> return t

[PATCH v4] mailbox/omap: adapt to the new mailbox framework

2014-11-03 Thread Suman Anna
d to runtime_pm. The other exported API omap_mbox_request_channel will be removed once existing legacy users are converted to DT. Cc: Jassi Brar Cc: Ohad Ben-Cohen Signed-off-by: Suman Anna --- v3->v4: No code changes, switched the example to use the DSP node instead of WkupM3 in the b

Re: [PATCH v2 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to fix AM33xx CPU Idle

2015-08-05 Thread Suman Anna
Hi Tony, On 08/05/2015 05:28 AM, Tony Lindgren wrote: > * Dave Gerlach [150717 13:59]: >> --- a/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt >> +++ b/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt >> @@ -75,6 +75,14 @@ data that represent the following: >> Cell #3 (

Re: [PATCH] rpmsg: Make rpmsg sample selectable

2016-05-06 Thread Suman Anna
Hi Bjorn, On 05/06/2016 01:06 PM, Bjorn Andersson wrote: > rpmsg is not user selectable so the rpmsg sample should not depend on > it, as this limits the possibility of compiling the sample client > without any other clients. > > Signed-off-by: Bjorn Andersson > --- > samples/Kconfig | 3 ++- >

Re: [PATCH 3/4] rpmsg: add helper macro module_rpmsg_driver

2016-05-04 Thread Suman Anna
Hi Andrew, On 05/04/2016 01:34 PM, Andrew F. Davis wrote: > This patch introduces the module_rpmsg_driver macro which is a > convenience macro for rpmsg driver modules similar to > module_platform_driver. It is intended to be used by drivers which > init/exit section does nothing but register/unre

Re: [PATCH 2/4] rpmsg: drop owner assignment from spi_drivers

2016-05-04 Thread Suman Anna
On 05/04/2016 01:34 PM, Andrew F. Davis wrote: > An rpmsg_driver does not need to set an owner, it will be populated by > the driver core. spi_drivers in patch subject?? regards Suman > > Signed-off-by: Andrew F. Davis > --- > Documentation/rpmsg.txt | 1 - > samples/rpmsg/rpmsg_c

Re: [PATCH 1/4] rpmsg: add THIS_MODULE to rpmsg_driver in rpmsg core

2016-05-04 Thread Suman Anna
i-trace comment from patch 3 squashed here properly, Acked-by: Suman Anna > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 8 +--- > include/linux/rpmsg.h| 8 +++- > 2 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/rpmsg/virt

Re: [PATCH] rpmsg: Make rpmsg sample selectable

2016-05-11 Thread Suman Anna
On 05/06/2016 05:15 PM, Bjorn Andersson wrote: > On Fri 06 May 12:25 PDT 2016, Suman Anna wrote: > >> Hi Bjorn, >> >> On 05/06/2016 01:06 PM, Bjorn Andersson wrote: >>> rpmsg is not user selectable so the rpmsg sample should not depend on >>> it, as th

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-18 Thread Suman Anna
On 02/18/2016 11:23 AM, Paul Walmsley wrote: > > On Thu, 18 Feb 2016, Sekhar Nori wrote: > >> On Friday 12 February 2016 10:50 PM, Suman Anna wrote: >>> Sekhar, >>> Will you be following up with above suggestion since Kishon is gonna be out? >> >>

Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager

2016-02-08 Thread Suman Anna
Hi Rob, On 02/08/2016 01:37 PM, Rob Herring wrote: > On Fri, Feb 05, 2016 at 10:34:03AM -0600, Nishanth Menon wrote: >> Message Manager is a hardware block used to communicate with various >> processor systems within certain Texas Instrument's Keystone >> generation SoCs. >> >> This hardware engin

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-08 Thread Suman Anna
Hi Paul, On 02/07/2016 08:48 PM, Paul Walmsley wrote: > On Tue, 2 Feb 2016, Kishon Vijay Abraham I wrote: > >> Paul, what do you think is the best way forward to perform reset? > > Many of the IP blocks with PRM hardreset lines are processor IP blocks. > Those often need special reset handling

Re: [PATCH 0/3] omap: hwmod: add default reset handling support

2016-02-08 Thread Suman Anna
On 02/08/2016 05:12 AM, Kishon Vijay Abraham I wrote: > Add a new hwmod flag to indicate custom reset handling and use it > for devices that require custom reset handling (like dsp, ipu, iva). > > Tested PCIe on dra7-evm and dra72-evm. > I need help in testing DSP, IPU, IVA, PRU, GFX, M3 in other

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-09 Thread Suman Anna
Hi Paul, On 02/09/2016 02:49 AM, Paul Walmsley wrote: > On Mon, 8 Feb 2016, Suman Anna wrote: > >> On 02/07/2016 08:48 PM, Paul Walmsley wrote: >>> On Tue, 2 Feb 2016, Kishon Vijay Abraham I wrote: >>> >>>> Paul, what do you think is the best way forwar

Re: [PATCH 0/3] omap: hwmod: add default reset handling support

2016-02-09 Thread Suman Anna
On 02/08/2016 11:17 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 09 February 2016 02:37 AM, Suman Anna wrote: >> On 02/08/2016 05:12 AM, Kishon Vijay Abraham I wrote: >>> Add a new hwmod flag to indicate custom reset handling and use it >>> for devices t

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-09 Thread Suman Anna
Hi Paul, On 02/09/2016 01:36 PM, Paul Walmsley wrote: > Hi Suman > > On Tue, 9 Feb 2016, Suman Anna wrote: > >> On 02/09/2016 02:49 AM, Paul Walmsley wrote: >>> On Mon, 8 Feb 2016, Suman Anna wrote: >>>> On 02/07/2016 08:48 PM, Paul Walmsley wrote:

Re: [PATCHv6 1/5] Documentation: dt: add common bindings for hwspinlock

2014-11-12 Thread Suman Anna
Kumar, Mark, Rob, On 11/12/2014 09:14 AM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Fri, Sep 12, 2014 at 11:24 PM, Suman Anna wrote: >> This patch adds the generic common bindings used to represent >> a hwlock device and use/request locks in a device-tree build. >>

Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-12 Thread Suman Anna
Hi Ohad, Thanks for the review. On 11/12/2014 01:08 PM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Fri, Sep 12, 2014 at 11:24 PM, Suman Anna wrote: >> +int of_hwspin_lock_get_id(struct device_node *np, int index) >> +{ >> + struct hwspinlock_device *bank; >&g

Re: [PATCHv6 5/5] hwspinlock/omap: add support for dt nodes

2014-11-12 Thread Suman Anna
Hi Ohad, On 11/12/2014 01:14 PM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Fri, Sep 12, 2014 at 11:24 PM, Suman Anna wrote: >> static int omap_hwspinlock_probe(struct platform_device *pdev) >> { >> - struct hwspinlock_pdata *pdata = pdev->dev.platform_data;

Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-13 Thread Suman Anna
Hi Ohad, On 11/13/2014 04:03 AM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Wed, Nov 12, 2014 at 9:32 PM, Suman Anna wrote: >>> Is this the validation you mentioned which requires the existence of >>> "hwspinlock/core: maintain a list of registered hwspinlock banks

Re: [PATCHv2] rpmsg: compute number of buffers to allocate from vrings

2014-11-13 Thread Suman Anna
Hi Ohad, On 09/16/2014 01:33 PM, Suman Anna wrote: > The buffers to be used for communication are allocated during the > rpmsg virtio driver's probe, and the total number of buffers is > currently hard-coded to 512. The vring configuration can vary from > one platform to a

Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-13 Thread Suman Anna
Hi Ohad, On 11/13/2014 01:45 PM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Thu, Nov 13, 2014 at 7:38 PM, Suman Anna wrote: >> No, not always, because, either of them can be optional between >> different platform implementations. For example, on OMAP, the number of >&g

Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-14 Thread Suman Anna
Hi Ohad, On 11/14/2014 01:11 AM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Thu, Nov 13, 2014 at 11:02 PM, Suman Anna wrote: >> OK, lets take an example. I have say 2 device instances, say >> hwlock1: hwlock@0 { >> hwlock-num-locks = <32>

Re: [PATCH v4] mailbox/omap: adapt to the new mailbox framework

2014-11-24 Thread Suman Anna
Hi Jassi, On 11/24/2014 03:54 AM, Jassi Brar wrote: > On 4 November 2014 at 04:35, Suman Anna wrote: >> The OMAP mailbox driver and its existing clients (remoteproc >> for OMAP4+) are adapted to use the generic mailbox framework. >> >> The main changes for the adaptat

Re: [PATCHv2] rpmsg: compute number of buffers to allocate from vrings

2014-11-26 Thread Suman Anna
Hi Ohad, > > On Thu, Nov 13, 2014 at 7:46 PM, Suman Anna wrote: >> Hi Ohad, >> >> On 09/16/2014 01:33 PM, Suman Anna wrote: >>> The buffers to be used for communication are allocated during the >>> rpmsg virtio driver's probe, and the total numbe

Re: [GIT PULL] New Mailbox framework for 3.18

2014-10-08 Thread Suman Anna
e framework for mailbox > doc: add documentation for mailbox framework > dt: mailbox: add generic bindings > > Suman Anna (1): > mailbox: rename pl320-ipc specific mailbox.h > > .../devicetree/bindings/mailbox/mailbox.txt| 38 ++ > Documentation/mailbo

Re: [PATCH 2/3 v3] Documentation: dt: add the CSR atlas7 hwspinlock bindings document

2015-05-22 Thread Suman Anna
ds the DT bindings information for this hwspinlock > module. > > Cc: Suman Anna > Cc: Bjorn Andersson > Signed-off-by: Wei Chen > Signed-off-by: Barry Song > --- > .../devicetree/bindings/hwlock/sirf,hwspinlock.txt | 25 > ++ > 1 file

Re: [PATCH 1/3 v3] drivers: hwspinlock: add CSR atlas7 implementation

2015-05-22 Thread Suman Anna
ex-A7, CAN bus Cortex-M3 and audio DSP). > > Cc: Suman Anna > Cc: Bjorn Andersson > Signed-off-by: Wei Chen > Signed-off-by: Barry Song > --- > -v3: > use #hwlock-cells and general hwspinlock dt-binding; > drop relax(); > drop num-spinlocks in dts; > re-o

Re: [PATCH 2/3 v3] Documentation: dt: add the CSR atlas7 hwspinlock bindings document

2015-05-26 Thread Suman Anna
On 05/25/2015 12:33 AM, Barry Song wrote: > 2015-05-23 6:44 GMT+08:00 Suman Anna : >> Hi Barry, >> >> On 05/19/2015 01:41 AM, Barry Song wrote: >>> From: Wei Chen >>> >>> The Hardware Spinlock device on atlas7 provides hardware assistance >>&g

Re: [PATCH 1/3 v3] drivers: hwspinlock: add CSR atlas7 implementation

2015-05-26 Thread Suman Anna
On 05/25/2015 12:37 AM, Barry Song wrote: > 2015-05-23 6:51 GMT+08:00 Suman Anna : >> Hi Barry, >> >> On 05/19/2015 01:41 AM, Barry Song wrote: >>> From: Wei Chen >>> >>> Add hwspinlock support for the CSR atlas7 SoC. >>> >>> T

Re: [PATCH v8 2/9] mailbox: Make mbox_chan_ops const

2015-05-04 Thread Suman Anna
On 05/04/2015 12:36 PM, Andrew Bresticker wrote: > The mailbox controller's channel ops ought to be read-only. Update > all the mailbox drivers to make their mbox_chan_ops const as well. > > Signed-off-by: Andrew Bresticker > Cc: Jassi Brar > Cc: Suman Anna > Cc:

Re: [PATCH v3 2/4] remoteproc: add a rproc ops for performing address translation

2015-05-11 Thread Suman Anna
Hi Ohad, On 05/09/2015 02:54 AM, Ohad Ben-Cohen wrote: > Hi Dave, > > On Wed, Apr 1, 2015 at 10:37 PM, Dave Gerlach wrote: >> From: Suman Anna >> >> The rproc_da_to_va API is currently used to perform any device to >> kernel address translations to meet the

Re: [PATCH v3 4/4] remoteproc/wkup_m3: add a remoteproc driver for TI Wakeup M3

2015-05-11 Thread Suman Anna
Hi Ohad, On 05/09/2015 03:42 AM, Ohad Ben-Cohen wrote: > Hi Dave, > > On Wed, Apr 1, 2015 at 10:37 PM, Dave Gerlach wrote: >> Add a remoteproc driver to load the firmware and boot a small >> Wakeup M3 processor present on TI AM33xx and AM43xx SoCs. This >> Wakeup M3 remote processor is an integr

Re: [PATCH v3 1/4] remoteproc: introduce rproc_get_by_phandle API

2015-05-11 Thread Suman Anna
Hi Ohad, On 05/09/2015 02:39 AM, Ohad Ben-Cohen wrote: > Hi Dave, > > On Wed, Apr 1, 2015 at 10:37 PM, Dave Gerlach wrote: >> Allow users of remoteproc the ability to get a handle to an rproc by >> passing a phandle supplied in the user's device tree node. This is >> useful in situations that re

Re: [PATCH v2 2/2] ARM: dts: am33xx: Move wkup_m3 node to soc node and add ranges

2015-03-09 Thread Suman Anna
Tony, On 03/05/2015 10:57 AM, Tony Lindgren wrote: > * Suman Anna [150305 08:47]: >> On 03/05/2015 09:40 AM, Tony Lindgren wrote: >>> * Dave Gerlach [150304 20:14]: >> Dave, >> >> Looks like the commit message disappeared during your patch preparatio

Re: [PATCH v2 2/2] ARM: dts: am33xx: Move wkup_m3 node to soc node and add ranges

2015-03-11 Thread Suman Anna
Hi Tony, On 03/11/2015 11:26 AM, Tony Lindgren wrote: > * Dave Gerlach [150310 12:55]: >> Tony, >> On 03/10/2015 11:09 AM, Tony Lindgren wrote: >>> * Suman Anna [150309 16:59]: >>>> On 03/05/2015 10:57 AM, Tony Lindgren wrote: >>>>> * Suman

<    1   2   3   4   5   6   7   8   9   10   >