Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

On Saturday 03 November 2012 00:02:06 Shan Wei wrote: From: Shan Wei davids...@tencent.com As Christoph Lameter said: In addition, following usage of per_cpu_ptr can be replaced by this_cpu_read. cpu=get_cpu() *per_cpu_ptr(p,cpu) put_cpu() Right.

Re: Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

On Saturday 03 November 2012 12:58:45 Shan Wei wrote: Sven Eckelmann said, at 2012/11/3 1:55: On Saturday 03 November 2012 00:02:06 Shan Wei wrote: From: Shan Wei davids...@tencent.com As Christoph Lameter said: In addition, following usage of per_cpu_ptr can be replaced

Re: [PATCH 3.16 046/114] batman-adv: Fix broadcast/ogm queue limit on a removed interface

pposed to fix this issue. > > Fixes: 6d5808d4ae1b ("batman-adv: Add missing hardif_free_ref in > forw_packet_free") Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> > [s...@narfation.org: fix conflicts with current version] > Signed-off-by: Sven Eckelmann <s...@nar

Re: [PATCH 3.16 046/114] batman-adv: Fix broadcast/ogm queue limit on a removed interface

Hi, looks like the patch is broken (at least it does something different than the non-stable patch does). On Monday 13 June 2016 19:36:37 Ben Hutchings wrote: > 3.16.36-rc1 review patch. If anyone has any objections, please let me know. [...] > --- a/net/batman-adv/send.c > +++

Re: [PATCH v2] ALSA: hda/realtek - Enable the ALC292 dock fixup on the Thinkpad T460s

On Monday 11 April 2016 16:05:49 Takashi Iwai wrote: > On Mon, 11 Apr 2016 11:21:38 +0200, > Sven Eckelmann wrote: > > > > The Lenovo Thinkpad T460s requires the alc_fixup_tpt440_dock as well in > > order to get working sound output on the docking stations headphone jac

[PATCH] ALSA: hda/realtek - Enable the ALC292 dock fixup on the Thinkpad T460s

The Lenovo Thinkpad T460s requires the alc_fixup_tpt440_dock as well in order to get working sound output on the docking stations headphone jack. Patch tested on a Thinkpad T460s (20F9CT01WW) using a ThinkPad Ultradock on kernel 4.4.6. Signed-off-by: Sven Eckelmann <s...@narfation.org>

[PATCH v2] ALSA: hda/realtek - Enable the ALC292 dock fixup on the Thinkpad T460s

The Lenovo Thinkpad T460s requires the alc_fixup_tpt440_dock as well in order to get working sound output on the docking stations headphone jack. Patch tested on a Thinkpad T460s (20F9CT01WW) using a ThinkPad Ultradock on kernel 4.4.6. Signed-off-by: Sven Eckelmann <s...@narfation.org>

[PATCH] ALSA: hda/realtek - Enable the ALC292 dock fixup on the Thinkpad T460s

The Lenovo Thinkpad T460s requires the alc_fixup_tpt440_dock as well in order to get working sound output on the docking stations headphone jack. Patch tested on a Thinkpad T460s (20F9CT01WW) using a ThinkPad Ultradock on kernel 4.4.6. Signed-off-by: Sven Eckelmann <s...@narfation.org>

Re: [PATCH] batman-adv: Deinline batadv_orig_hash_find, save 9024 bytes

152746082 91ab862 vmlinux > > Signed-off-by: Denys Vlasenko <dvlas...@redhat.com> > CC: Marek Lindner <mareklind...@neomailbox.ch> > CC: Simon Wunderlich <s...@simonwunderlich.de> > CC: Antonio Quartulli <a...@unstable.cc> > CC: Sven Eckelmann <s...@narfatio

Re: [B.A.T.M.A.N.] [PATCH 1086/1285] Replace numeric parameter like 0444 with macro

On Dienstag, 2. August 2016 20:15:13 CEST Baole Ni wrote: [...] > diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c > index 5f2974b..25759b9 100644 > --- a/net/batman-adv/main.c > +++ b/net/batman-adv/main.c > @@ -1313,7 +1313,7 @@ static struct kparam_string batadv_param_string_ra = { >

Re: [PATCH 3.16 149/306] batman-adv: fix splat on disabling an interface

On Mittwoch, 15. Februar 2017 22:41:40 CET Ben Hutchings wrote: > 3.16.40-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: Linus Lüssing > > commit 9799c50372b23ed774791bdb87d700f1286ee8a9 upstream. Same objections

[PATCH] checkpatch: remove false unbalanced braces warning

456c26 ("checkpatch: notice unbalanced else braces in a patch") Signed-off-by: Sven Eckelmann <s...@narfation.org> --- scripts/checkpatch.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index ad5ea5c545b2..baa3c7be0

Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

On Samstag, 22. Oktober 2016 21:08:26 CEST Jarod Wilson wrote: [...] > You're going to > need more than just this revert though, since batman-adv calls > ether_setup, which will set min_mtu = 68, max_mtu = 1500, unless > batadv_hardif_min_mtu() always returns something 1500 or less. It does only

Re: [net-next,v2,7/9] net: use core MTU range checking in misc drivers

On Donnerstag, 20. Oktober 2016 13:55:22 CEST Jarod Wilson wrote: [...] > batman-adv: > - set max_mtu > - remove batadv_interface_change_mtu > - initialization is a little async, not 100% certain that max_mtu is set > in the optimal place, don't have hardware to test with batman-adv is creating

[PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

("net: use core MTU range checking in misc drivers") Signed-off-by: Sven Eckelmann <s...@narfation.org> --- Original patch + my comment: https://patchwork.ozlabs.org/patch/684722/ I just got informed about this patch when it was already applied in net-next. So I can only ask for

Re: [PATCH 4.8 78/92] batman-adv: fix splat on disabling an interface

On Donnerstag, 17. November 2016 11:32:51 CET Greg Kroah-Hartman wrote: > 4.8-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Linus Lüssing > > commit 9799c50372b23ed774791bdb87d700f1286ee8a9 upstream. > > As

Re: [B.A.T.M.A.N.] [PATCH] net: batman-adv: use new api ethtool_{get|set}_link_ksettings

On Samstag, 1. April 2017 08:40:54 CEST Sven Eckelmann wrote: [...] > Btw. the code you are modifying will most likely be dropped. Your patch will > get rejected because of this. But thanks for submitting the api conversion > patch (even when it will be rejected). The patch was n

Re: [B.A.T.M.A.N.] [PATCH] net: batman-adv: use new api ethtool_{get|set}_link_ksettings

On Freitag, 31. März 2017 22:33:34 CEST Philippe Reynes wrote: > > Do you know if anyone already prepared the get_link_ksettings support for > > kernels older than 4.6 for backports.git? > > Sorry, I don't know this repo. Do you have an url please ? > But I suppose that nobody works on such

Re: [B.A.T.M.A.N.] [PATCH] net: batman-adv: use new api ethtool_{get|set}_link_ksettings

On Donnerstag, 30. März 2017 23:01:27 CEST Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > I've only compiled this change. If someone may test it, > it would be very nice. > > Signed-off-by: Philippe Reynes

Re: [B.A.T.M.A.N.] [PATCH][V2] batman-adv: fix various spelling mistakes

On Montag, 26. Juni 2017 11:26:44 CEST Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes in batadv_dbg debug messages and > also in a comment and ensure comment line is not wider than 80 > characters > > "ourselve" -> "ourselves" >

Re: [B.A.T.M.A.N.] [PATCH 0/2] batman-adv: Fine-tuning for three function implementations

On Samstag, 6. Mai 2017 18:12:46 CEST SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 6 May 2017 18:03:45 +0200 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Replace a seq_puts()

Re: [PATCH 3.16 144/212] batman-adv: Fix double free during fragment merge error

ems. > -- > > From: Sven Eckelmann <s...@narfation.org> > > commit 248e23b50e2da0753f3b5faa068939cbe9f8a75a upstream. > > The function batadv_frag_skb_buffer was supposed not to consume the skbuff > on errors. This was followed in the helper function > ba

Re: [PATCH] batman-adv: Remove unnecessary length qualifier in %14pM

On Mittwoch, 14. Juni 2017 02:33:52 CEST Joe Perches wrote: > It's misleading and unnecessary. > > Signed-off-by: Joe Perches > --- > net/batman-adv/distributed-arp-table.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The patch was applied and is currently queued

Re: [B.A.T.M.A.N.] Odd use of %14pM in net/batman-adv/distributed-arp-table.c

On Dienstag, 13. Juni 2017 14:51:41 CEST Joe Perches wrote: > An output mac address is 17 bytes [...] > but in net/batman-adv/distributed-arp-table.c [...] > %14pM is odd as this should not emit the last byte of the > mac address. So given the example above, it would output > 00:11:22:33:44 [...]

[RFC v2 0/6] flow_dissector: Provide basic batman-adv unicast handling

und to provide the correct definitions to flow_dissector.c Kind regards, Sven [1] https://patchwork.open-mesh.org/patch/17162/ [2] https://git.open-mesh.org/linux-merge.git/shortlog/refs/heads/batadv/net-next Sven Eckelmann (6): batman-adv: Change nl references to genl batman-adv: Rename batman-

[RFC v2 1/6] batman-adv: Change nl references to genl

The batman-adv netlink functionality is actually not pure netlink but is using NETLINK_GENERIC and related API. The code should therefore also use this "genl" instead of "nl" to make this more clear. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- inclu

[RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers

the same neighbor to different cores. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/core/flow_dissector.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 15ce30063765..784cc0

[RFC v2 3/6] batman-adv: Let packet.h include its headers directly

The headers used by packet.h should also be included by it directly. main.h is currently dealing with it in batman-adv, but this will no longer work when this header is moved to include/uapi/linux/. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/batman-adv/main.h

[RFC v2 5/6] batman-adv: Convert packet.h to uapi header

ETH_P_BATMAN ethernet packets. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- MAINTAINERS| 1 + net/batman-adv/packet.h => include/uapi/linux/batadv.h | 9 + net/batman-adv/bat_iv_ogm.c| 2 +- net/b

[RFC v2 4/6] batman-adv: Remove usage of BIT(x) in packet.h

The BIT(x) macro is no longer available for uapi headers because it is defined outside of it (linux/bitops.h). The use of it must therefore be avoided and replaced by an appropriate other representation. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/batman-adv/packet.

[RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

with the file which will contain the packet format definitions. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- MAINTAINERS| 2 +- include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++--- net/batman-adv/bat_algo.c

Re: [B.A.T.M.A.N.] [RFC v3 0/4] flow_dissector: Provide basic batman-adv unicast handling

On Freitag, 15. Dezember 2017 17:51:19 CET Willem de Bruijn wrote: [] > Thanks for making these changes. The flow dissection looks good to me. > > One possible issue is that this exposes kernel fixed width types u8/u16/.. > to userspace. For posix compatibility reasons, uapi headers use the >

Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

On Mittwoch, 6. Dezember 2017 11:58:14 CET Willem de Bruijn wrote: [...] > >> > --- > >> > MAINTAINERS| 2 +- > >> > include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++--- > >> > >> This and the previous patch changes uapi. That might break userspace

Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

On Freitag, 15. Dezember 2017 11:32:05 CET Sven Eckelmann wrote: > On Mittwoch, 6. Dezember 2017 11:58:14 CET Willem de Bruijn wrote: > [...] > > >> > --- > > >> > MAINTAINERS| 2 +- > > >> > inc

[RFC v3 0/4] flow_dissector: Provide basic batman-adv unicast handling

et.h/uapi headers around to provide the correct definitions to flow_dissector.c Kind regards, Sven [1] https://patchwork.open-mesh.org/patch/17162/ Sven Eckelmann (4): batman-adv: Let packet.h include its headers directly batman-adv: Remove usage of BIT(x) in packet.h batman-adv: Convert

Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

On Freitag, 15. Dezember 2017 11:57:55 CET Willem de Bruijn wrote: > > No, this is also bad because batman_adv.h is MIT license and packet.h is > > GPL-2. So what other name would you suggest for packet.h? > > batman_adv_packet.h? > > Sure, that sounds great. Thanks. Really? Isn't

[RFC v3 2/4] batman-adv: Remove usage of BIT(x) in packet.h

The BIT(x) macro is no longer available for uapi headers because it is defined outside of it (linux/bitops.h). The use of it must therefore be avoided and replaced by an appropriate other representation. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/batman-adv/packet.

[RFC v3 1/4] batman-adv: Let packet.h include its headers directly

The headers used by packet.h should also be included by it directly. main.h is currently dealing with it in batman-adv, but this will no longer work when this header is moved to include/uapi/linux/. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/batman-adv/main.h

[RFC v3 3/4] batman-adv: Convert packet.h to uapi header

ETH_P_BATMAN ethernet packets. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- MAINTAINERS | 1 + net/batman-adv/packet.h => include/uapi/linux/batadv_packet.h | 8 net/batman-adv/bat_iv_ogm.c

[RFC v3 4/4] flow_dissector: Parse batman-adv unicast headers

the same neighbor to different cores. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/core/flow_dissector.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c

Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

On Mittwoch, 6. Dezember 2017 11:42:33 CET Willem de Bruijn wrote: > On Tue, Dec 5, 2017 at 9:35 AM, Sven Eckelmann > <sven.eckelm...@openmesh.com> wrote: > > This file contains the relevant information to let userspace communicate > > with batman-adv over generic netlink.

Re: [RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers

On Mittwoch, 6. Dezember 2017 11:54:13 CET Willem de Bruijn wrote: > Perhaps it can even be behind a static key depending on whether any > devices are active, adjusted in batadv_hardif_(en|dis)able_interface. I don't like that because we don't need batman-adv loaded to simply forward (bridge)

Re: [RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers

On Dienstag, 5. Dezember 2017 09:19:45 CET Tom Herbert wrote: [...] > Switch statements with cases having many LOC is hard to read and > __skb_flow_dissect is aleady quite convoluted to begin with. > > I suggest putting this in a static function similar to how MPLS and > GRE are handled. Thanks

[PATCH v4 3/5] batman-adv: Remove kernel fixed width types in packet.h

The uapi headers use the __u8/__u16/... version of the fixed width types instead of u8/u16/... The use of the latter must be avoided before packet.h is copied to include/uapi/linux/. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/batman-adv/packet.h

[PATCH v4 5/5] flow_dissector: Parse batman-adv unicast headers

the same neighbor to different cores. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/core/flow_dissector.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c

[PATCH v4 2/5] batman-adv: Remove usage of BIT(x) in packet.h

The BIT(x) macro is no longer available for uapi headers because it is defined outside of it (linux/bitops.h). The use of it must therefore be avoided and replaced by an appropriate other representation. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/batman-adv/packet.

[PATCH v4 4/5] batman-adv: Convert packet.h to uapi header

ETH_P_BATMAN ethernet packets. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- MAINTAINERS | 1 + net/batman-adv/packet.h => include/uapi/linux/batadv_packet.h | 8 net/batman-adv/bat_iv_ogm.c

[PATCH v4 1/5] batman-adv: Let packet.h include its headers directly

The headers used by packet.h should also be included by it directly. main.h is currently dealing with it in batman-adv, but this will no longer work when this header is moved to include/uapi/linux/. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/batman-adv/main.h

[PATCH v4 0/5] flow_dissector: Provide basic batman-adv unicast handling

vide the correct definitions to flow_dissector.c Kind regards, Sven Sven Eckelmann (5): batman-adv: Let packet.h include its headers directly batman-adv: Remove usage of BIT(x) in packet.h batman-adv: Remove kernel fixed width types in packet.h batman-adv: Convert packet.h to uapi header fl

Re: [PATCH] batman-adv: Deinline batadv_orig_hash_find, save 9024 bytes

On Montag, 25. April 2016 21:39:50 CEST Antonio Quartulli wrote: > On Mon, Apr 25, 2016 at 03:25:22PM +0200, Denys Vlasenko wrote: > > This function compiles to 473 bytes of machine code. > > 21 callsites. > > > > text data bss dec hex filename > > 95903266 20860288

Re: [B.A.T.M.A.N.] checkpatch: Add test for keywords not starting on tabstops

On Freitag, 5. Januar 2018 09:30:27 CET Sven Eckelmann wrote: > On Donnerstag, 21. April 2016 12:41:37 CET Joe Perches wrote: > > It's somewhat common and in general a defect for c90 keywords to > > not start on a tabstop. > > > > Add a test for this condit

Re: checkpatch: Add test for keywords not starting on tabstops

On Donnerstag, 21. April 2016 12:41:37 CET Joe Perches wrote: > It's somewhat common and in general a defect for c90 keywords to > not start on a tabstop. > > Add a test for this condition and warn when it occurs. This seems to create some new false positives: WARNING: Statements should

Re: [v5,08/13] ARM: dts: ipq4019: Add ipq4019-ap.dk07.1 common data

On Freitag, 23. März 2018 15:48:51 CEST Sricharan R wrote: > Add the common data for all dk07 based boards. > > Reviewed-by: Abhishek Sahu > Signed-off-by: Sricharan R > --- > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi | 69 >

Re: [v5,05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi

On Freitag, 23. März 2018 15:48:48 CEST Sricharan R wrote: > Add the common parts for the dk04 boards. > > Reviewed-by: Abhishek Sahu > Signed-off-by: Sricharan R > --- > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi | 115 >

Re: [v5,05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi

Hi, On Mittwoch, 18. April 2018 12:45:20 CEST Sricharan R wrote: > Right, will add the above change to soc.dtsi in V6. Does that sound ok for > you ? I have submitted a patch for this now [1] because I need this for OpenWrt (sooner rather than later). And I am not sure whether it is good to

Re: [v5,05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi

On Mittwoch, 18. April 2018 08:59:46 CEST Sven Eckelmann wrote: [...] > I would not know how to disable QSEE on these boards and thus would assume > that it should be part of this dtsi. Just did some reviews of the reserved-memory regions in other QCA devices and it looks like this tz an

Re: [PATCH] batman-adv: fix batadv_interface_tx()'s return type

On Dienstag, 24. April 2018 15:18:46 CEST Luc Van Oostenryck wrote: [...] > -static int batadv_interface_tx(struct sk_buff *skb, > +static netdev_tx_t batadv_interface_tx(struct sk_buff *skb, > struct net_device *soft_iface) > { > struct ethhdr *ethhdr; >

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix batadv_interface_tx()'s return type

On Dienstag, 24. April 2018 15:18:46 CEST Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too.

Re: [B.A.T.M.A.N.] [PATCH][next] batman-adv: don't pass a NULL hard_iface to batadv_hardif_put

On Freitag, 23. März 2018 23:53:50 CET Colin King wrote: > From: Colin Ian King > > In the case where hard_iface is NULL, the error path may pass a null > pointer to batadv_hardif_put causing a null pointer dereference error. > Avoid this by only calling the function if

Re: [B.A.T.M.A.N.] [PATCH][next] batman-adv: don't pass a NULL hard_iface to batadv_hardif_put

On Freitag, 23. März 2018 23:53:50 CET Colin King wrote: > From: Colin Ian King > > In the case where hard_iface is NULL, the error path may pass a null > pointer to batadv_hardif_put causing a null pointer dereference error. > Avoid this by only calling the function if hard_iface not null. >

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix batadv_interface_tx()'s return type

On Dienstag, 24. April 2018 15:18:46 CEST Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too.

Re: [B.A.T.M.A.N.] [PATCH][V2] batman-adv: fix various spelling mistakes

On Montag, 26. Juni 2017 11:26:44 CEST Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes in batadv_dbg debug messages and > also in a comment and ensure comment line is not wider than 80 > characters > > "ourselve" -> "ourselves" > "surpressed" -> "suppressed" >

Re: checkpatch: Add test for keywords not starting on tabstops

On Donnerstag, 21. April 2016 12:41:37 CET Joe Perches wrote: > It's somewhat common and in general a defect for c90 keywords to > not start on a tabstop. > > Add a test for this condition and warn when it occurs. This seems to create some new false positives: WARNING: Statements should

Re: [B.A.T.M.A.N.] checkpatch: Add test for keywords not starting on tabstops

On Freitag, 5. Januar 2018 09:30:27 CET Sven Eckelmann wrote: > On Donnerstag, 21. April 2016 12:41:37 CET Joe Perches wrote: > > It's somewhat common and in general a defect for c90 keywords to > > not start on a tabstop. > > > > Add a test for this condit

[RFC v2 0/6] flow_dissector: Provide basic batman-adv unicast handling

und to provide the correct definitions to flow_dissector.c Kind regards, Sven [1] https://patchwork.open-mesh.org/patch/17162/ [2] https://git.open-mesh.org/linux-merge.git/shortlog/refs/heads/batadv/net-next Sven Eckelmann (6): batman-adv: Change nl references to genl batman-adv: Rename batman-

[RFC v2 1/6] batman-adv: Change nl references to genl

The batman-adv netlink functionality is actually not pure netlink but is using NETLINK_GENERIC and related API. The code should therefore also use this "genl" instead of "nl" to make this more clear. Signed-off-by: Sven Eckelmann --- include/uapi/linux/batman_adv.h | 14

[RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers

the same neighbor to different cores. Signed-off-by: Sven Eckelmann --- net/core/flow_dissector.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 15ce30063765..784cc07fc58e 100644 --- a/net/core

[RFC v2 3/6] batman-adv: Let packet.h include its headers directly

The headers used by packet.h should also be included by it directly. main.h is currently dealing with it in batman-adv, but this will no longer work when this header is moved to include/uapi/linux/. Signed-off-by: Sven Eckelmann --- net/batman-adv/main.h | 2 -- net/batman-adv/packet.h | 2

[RFC v2 5/6] batman-adv: Convert packet.h to uapi header

ETH_P_BATMAN ethernet packets. Signed-off-by: Sven Eckelmann --- MAINTAINERS| 1 + net/batman-adv/packet.h => include/uapi/linux/batadv.h | 9 + net/batman-adv/bat_iv_ogm.c| 2 +- net/batman-adv/bat_

[RFC v2 4/6] batman-adv: Remove usage of BIT(x) in packet.h

The BIT(x) macro is no longer available for uapi headers because it is defined outside of it (linux/bitops.h). The use of it must therefore be avoided and replaced by an appropriate other representation. Signed-off-by: Sven Eckelmann --- net/batman-adv/packet.h | 23 +++ 1

[RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

with the file which will contain the packet format definitions. Signed-off-by: Sven Eckelmann --- MAINTAINERS| 2 +- include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++--- net/batman-adv/bat_algo.c | 2 +- net/batman-adv/bat_iv_og

Re: [RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers

On Dienstag, 5. Dezember 2017 09:19:45 CET Tom Herbert wrote: [...] > Switch statements with cases having many LOC is hard to read and > __skb_flow_dissect is aleady quite convoluted to begin with. > > I suggest putting this in a static function similar to how MPLS and > GRE are handled. Thanks

Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

On Mittwoch, 6. Dezember 2017 11:58:14 CET Willem de Bruijn wrote: [...] > >> > --- > >> > MAINTAINERS| 2 +- > >> > include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++--- > >> > >> This and the previous patch changes uapi. That might break userspace

Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

On Freitag, 15. Dezember 2017 11:32:05 CET Sven Eckelmann wrote: > On Mittwoch, 6. Dezember 2017 11:58:14 CET Willem de Bruijn wrote: > [...] > > >> > --- > > >> > MAINTAINERS| 2 +- > > >> > inc

Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

On Freitag, 15. Dezember 2017 11:57:55 CET Willem de Bruijn wrote: > > No, this is also bad because batman_adv.h is MIT license and packet.h is > > GPL-2. So what other name would you suggest for packet.h? > > batman_adv_packet.h? > > Sure, that sounds great. Thanks. Really? Isn't

[RFC v3 0/4] flow_dissector: Provide basic batman-adv unicast handling

/17162/ Sven Eckelmann (4): batman-adv: Let packet.h include its headers directly batman-adv: Remove usage of BIT(x) in packet.h batman-adv: Convert packet.h to uapi header flow_dissector: Parse batman-adv unicast headers MAINTAINERS| 1

[RFC v3 1/4] batman-adv: Let packet.h include its headers directly

The headers used by packet.h should also be included by it directly. main.h is currently dealing with it in batman-adv, but this will no longer work when this header is moved to include/uapi/linux/. Signed-off-by: Sven Eckelmann --- net/batman-adv/main.h | 2 -- net/batman-adv/packet.h | 2

[RFC v3 3/4] batman-adv: Convert packet.h to uapi header

ETH_P_BATMAN ethernet packets. Signed-off-by: Sven Eckelmann --- MAINTAINERS | 1 + net/batman-adv/packet.h => include/uapi/linux/batadv_packet.h | 8 net/batman-adv/bat_iv_ogm.c | 2 +- net/batman-adv/bat_

[RFC v3 4/4] flow_dissector: Parse batman-adv unicast headers

the same neighbor to different cores. Signed-off-by: Sven Eckelmann --- net/core/flow_dissector.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 15ce30063765..fa0a4879fb9d 100644

[RFC v3 2/4] batman-adv: Remove usage of BIT(x) in packet.h

The BIT(x) macro is no longer available for uapi headers because it is defined outside of it (linux/bitops.h). The use of it must therefore be avoided and replaced by an appropriate other representation. Signed-off-by: Sven Eckelmann --- net/batman-adv/packet.h | 23 +++ 1

[PATCH v4 0/5] flow_dissector: Provide basic batman-adv unicast handling

header definition from flow_dissector.c * moved the batman-adv packet.h/uapi headers around to provide the correct definitions to flow_dissector.c Kind regards, Sven Sven Eckelmann (5): batman-adv: Let packet.h include its headers directly batman-adv: Remove usage of BIT(x

[PATCH v4 3/5] batman-adv: Remove kernel fixed width types in packet.h

The uapi headers use the __u8/__u16/... version of the fixed width types instead of u8/u16/... The use of the latter must be avoided before packet.h is copied to include/uapi/linux/. Signed-off-by: Sven Eckelmann --- net/batman-adv/packet.h | 214

[PATCH v4 5/5] flow_dissector: Parse batman-adv unicast headers

the same neighbor to different cores. Signed-off-by: Sven Eckelmann --- net/core/flow_dissector.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 15ce30063765..fa0a4879fb9d 100644

[PATCH v4 2/5] batman-adv: Remove usage of BIT(x) in packet.h

The BIT(x) macro is no longer available for uapi headers because it is defined outside of it (linux/bitops.h). The use of it must therefore be avoided and replaced by an appropriate other representation. Signed-off-by: Sven Eckelmann --- net/batman-adv/packet.h | 23 +++ 1

[PATCH v4 1/5] batman-adv: Let packet.h include its headers directly

The headers used by packet.h should also be included by it directly. main.h is currently dealing with it in batman-adv, but this will no longer work when this header is moved to include/uapi/linux/. Signed-off-by: Sven Eckelmann --- net/batman-adv/main.h | 2 -- net/batman-adv/packet.h | 2

[PATCH v4 4/5] batman-adv: Convert packet.h to uapi header

ETH_P_BATMAN ethernet packets. Signed-off-by: Sven Eckelmann --- MAINTAINERS | 1 + net/batman-adv/packet.h => include/uapi/linux/batadv_packet.h | 8 net/batman-adv/bat_iv_ogm.c | 2 +- net/batman-adv/bat_

Re: [B.A.T.M.A.N.] [RFC v3 0/4] flow_dissector: Provide basic batman-adv unicast handling

On Freitag, 15. Dezember 2017 17:51:19 CET Willem de Bruijn wrote: [] > Thanks for making these changes. The flow dissection looks good to me. > > One possible issue is that this exposes kernel fixed width types u8/u16/.. > to userspace. For posix compatibility reasons, uapi headers use the >

Re: [PATCH] batman-adv: fix batadv_interface_tx()'s return type

On Dienstag, 24. April 2018 15:18:46 CEST Luc Van Oostenryck wrote: [...] > -static int batadv_interface_tx(struct sk_buff *skb, > +static netdev_tx_t batadv_interface_tx(struct sk_buff *skb, > struct net_device *soft_iface) > { > struct ethhdr *ethhdr; >

Re: [v5,08/13] ARM: dts: ipq4019: Add ipq4019-ap.dk07.1 common data

On Freitag, 23. März 2018 15:48:51 CEST Sricharan R wrote: > Add the common data for all dk07 based boards. > > Reviewed-by: Abhishek Sahu > Signed-off-by: Sricharan R > --- > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi | 69 > +++ > 1 file changed, 69 insertions(+)

Re: [v5,05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi

On Freitag, 23. März 2018 15:48:48 CEST Sricharan R wrote: > Add the common parts for the dk04 boards. > > Reviewed-by: Abhishek Sahu > Signed-off-by: Sricharan R > --- > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi | 115 > ++ > arch/arm/boot/dts/qcom-ipq4019.dtsi

Re: [v5,05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi

On Mittwoch, 18. April 2018 08:59:46 CEST Sven Eckelmann wrote: [...] > I would not know how to disable QSEE on these boards and thus would assume > that it should be part of this dtsi. Just did some reviews of the reserved-memory regions in other QCA devices and it looks like this tz an

Re: [v5,05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi

Hi, On Mittwoch, 18. April 2018 12:45:20 CEST Sricharan R wrote: > Right, will add the above change to soc.dtsi in V6. Does that sound ok for > you ? I have submitted a patch for this now [1] because I need this for OpenWrt (sooner rather than later). And I am not sure whether it is good to

Re: [PATCH 3.16 144/212] batman-adv: Fix double free during fragment merge error

ems. > -- > > From: Sven Eckelmann > > commit 248e23b50e2da0753f3b5faa068939cbe9f8a75a upstream. > > The function batadv_frag_skb_buffer was supposed not to consume the skbuff > on errors. This was followed in the helper function > batadv_frag_insert_packet

Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

On Mittwoch, 6. Dezember 2017 11:42:33 CET Willem de Bruijn wrote: > On Tue, Dec 5, 2017 at 9:35 AM, Sven Eckelmann > wrote: > > This file contains the relevant information to let userspace communicate > > with batman-adv over generic netlink. The relevant genl enums for

Re: [RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers

On Mittwoch, 6. Dezember 2017 11:54:13 CET Willem de Bruijn wrote: > Perhaps it can even be behind a static key depending on whether any > devices are active, adjusted in batadv_hardif_(en|dis)able_interface. I don't like that because we don't need batman-adv loaded to simply forward (bridge)

Re: linux-next: Fixes tag needs some work in the net tree

On Sunday, 20 September 2020 21:59:19 CEST Stephen Rothwell wrote: > Hi all, Yes, I've accidentally swapped the IDs while adding them to the various patches. The correct ones should have been: * 097930e85f90 ("batman-adv: bla: fix type misuse for backbone_gw hash indexing") Fixes:

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

tly, this is also affecting the kernel (4.14) for the OpenWrt 18.06.x + 19.07.x branch because it can also be found in there as part of the v4.14.200 release. Another workaround is to replace the first "(" with a NULL too. See the attached patch for the one which I used to fix the OpenWrt

Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage

On Wednesday, 2 December 2020 13:49:54 CET Enrico Weigelt, metux IT consult wrote: > Remove MODULE_VERSION(), as it isn't needed at all: the only version > making sense is the kernel version. Is there some explanation besides an opinion? Some kind goal which you want to achieve with it maybe?

[PATCH 2/2] vxlan: Copy needed_tailroom from lowerdev

While vxlan doesn't need any extra tailroom, the lowerdev might need it. In that case, copy it over to reduce the chance for additional (re)allocations in the transmit path. Signed-off-by: Sven Eckelmann --- drivers/net/vxlan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net

[PATCH 1/2] vxlan: Add needed_headroom for lower device

er device. The first caller of net_dev_xmit could therefore never make sure that enough headroom was allocated for the rest of the transmit path. Cc: Annika Wickert Signed-off-by: Sven Eckelmann --- drivers/net/vxlan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/vxlan.c b/dr

  1   2   >