Re: [PATCH v5 0/2] Reset PCIe devices to address DMA problem on kdump with iommu

2012-10-31 Thread Takao Indoh
(2012/10/17 15:23), Takao Indoh wrote: These patches reset PCIe devices at boot time to address DMA problem on kdump with iommu. When reset_devices is specified, a hot reset is triggered on each PCIe root port and downstream port to reset its downstream endpoint. Background: A kdump problem

Re: [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu

2012-09-24 Thread Takao Indoh
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html a DMI quirk for a PCIe switch? pci-quirk maybe? there is a hook in per-device pci reset code path, which could be setup for such a case. Yep, I think early-quirk is better. Thanks, Takao Indoh -- To unsubscribe

Re: [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu

2012-09-24 Thread Takao Indoh
(2012/09/15 0:48), Vivek Goyal wrote: On Wed, Sep 12, 2012 at 06:00:55PM +0900, Takao Indoh wrote: (2012/09/11 23:43), Vivek Goyal wrote: On Tue, Sep 11, 2012 at 07:32:35PM +0900, Takao Indoh wrote: [..] I'll post new patch which clears bus master bit and resets devices in second kernel

Re: [PATCH v4 1/2] x86, pci: Reset PCIe devices at boot time

2012-11-06 Thread Takao Indoh
(2012/10/16 13:23), Takao Indoh wrote: (2012/10/16 3:36), Yinghai Lu wrote: On Mon, Oct 15, 2012 at 12:00 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: This patch resets PCIe devices at boot time by hot reset when reset_devices is specified. how about pci devices that domain_nr

Re: [PATCH v5 1/2] x86, pci: Reset PCIe devices at boot time

2012-10-19 Thread Takao Indoh
(2012/10/19 0:32), Khalid Aziz wrote: On Wed, 2012-10-17 at 15:23 +0900, Takao Indoh wrote: This patch resets PCIe devices at boot time by hot reset when reset_devices is specified. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/include/asm/pci-direct.h |1 arch

Re: [PATCH v2 0/2] Reset PCIe devices to address DMA problem on kdump with iommu

2012-10-09 Thread Takao Indoh
(2012/10/03 22:23), Don Dutile wrote: On 10/02/2012 03:49 AM, Takao Indoh wrote: These patches reset PCIe devices at boot time to address DMA problem on kdump with iommu. When reset_devices is specified, a hot reset is triggered on each PCIe root port and downstream port to reset its downstream

Re: [PATCH v2 0/2] Reset PCIe devices to address DMA problem on kdump with iommu

2012-10-09 Thread Takao Indoh
(2012/10/10 1:05), Don Dutile wrote: On 10/09/2012 05:03 AM, Takao Indoh wrote: (2012/10/03 22:23), Don Dutile wrote: On 10/02/2012 03:49 AM, Takao Indoh wrote: These patches reset PCIe devices at boot time to address DMA problem on kdump with iommu. When reset_devices is specified, a hot

[PATCH v3 0/2] Reset PCIe devices to address DMA problem on kdump with iommu

2012-10-10 Thread Takao Indoh
in setup_arch() because reset need to be done before interrupt remapping is initialized. https://lkml.org/lkml/2012/10/2/54 v1: Add fixup_final quirk to reset PCIe devices https://lkml.org/lkml/2012/8/3/160 Thanks, Takao Indoh -- To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH v3 1/2] x86, pci: Reset PCIe devices at boot time

2012-10-10 Thread Takao Indoh
This patch resets PCIe devices at boot time by hot reset when reset_devices is specified. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/include/asm/pci-direct.h |1 arch/x86/kernel/setup.c |3 arch/x86/pci/early.c | 299

[PATCH v3 2/2] x86, pci: Enable PCI INTx when MSI is disabled

2012-10-10 Thread Takao Indoh
. This patch fix this problem. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/pci/common.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index 720e973..2bb7ecc 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86

Re: [PATCH v3 1/2] x86, pci: Reset PCIe devices at boot time

2012-10-11 Thread Takao Indoh
(2012/10/11 5:08), Khalid Aziz wrote: Please see comments inline: On Wed, 2012-10-10 at 16:51 +0900, Takao Indoh wrote: This patch resets PCIe devices at boot time by hot reset when reset_devices is specified. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/include/asm

Re: [PATCH v3 1/2] x86, pci: Reset PCIe devices at boot time

2012-10-12 Thread Takao Indoh
(2012/10/12 2:28), Khalid Aziz wrote: On Thu, 2012-10-11 at 15:16 +0900, Takao Indoh wrote: (2012/10/11 5:08), Khalid Aziz wrote: . +static void __init do_reset(u8 bus, u8 slot, u8 func) +{ + u16 ctrl; + + printk(KERN_INFO pci :%02x:%02x.%d reset\n, bus, slot, func

[PATCH v6 1/5] x86, pci: add dummy pci device for early stage

2012-11-13 Thread Takao Indoh
From: Yinghai Lu ying...@kernel.org So we can pass pci_dev *dev to reuse some generic pci functions. Signed-off-by: Yinghai Lu ying...@kernel.org Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/include/asm/pci-direct.h |2 + arch/x86/pci/early.c | 75

[PATCH v6 2/5] PCI: Define the maximum number of PCI function

2012-11-13 Thread Takao Indoh
Define the maximum number of PCI function so that PCI functions can be enumerated without using 8. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- include/linux/pci.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/pci.h b/include/linux/pci.h

[PATCH v6 3/5] Make reset_devices available at early stage

2012-11-13 Thread Takao Indoh
Change reset_devices from __setup to early_param so this parameter is available at early stage. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- init/main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/init/main.c b/init/main.c index e33e09d..f2b24cb

[PATCH v6 4/5] x86, pci: Reset PCIe devices at boot time

2012-11-13 Thread Takao Indoh
devices by hot reset and its DMA is stopped when reset_devices is specified. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/include/asm/pci-direct.h |1 + arch/x86/kernel/setup.c |3 + arch/x86/pci/early.c | 228

[PATCH v6 5/5] x86, pci: Enable PCI INTx when MSI is disabled

2012-11-13 Thread Takao Indoh
. This patch fix this problem. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/pci/common.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index 720e973..2bb7ecc 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86

[PATCH v6 0/5] Reset PCIe devices to address DMA problem on kdump with iommu

2012-11-13 Thread Takao Indoh
before interrupt remapping is initialized. https://lkml.org/lkml/2012/10/2/54 v1: Add fixup_final quirk to reset PCIe devices https://lkml.org/lkml/2012/8/3/160 Takao Indoh (4): PCI: Define the maximum number of PCI function Make reset_devices available at early stage x86, pci: Reset PCIe

Re: [PATCH v6 1/5] x86, pci: add dummy pci device for early stage

2012-11-13 Thread Takao Indoh
(2012/11/13 19:01), Andrew Murray wrote: Hello, Some comments inline... On 13 November 2012 09:07, Takao Indoh indou.ta...@jp.fujitsu.com wrote: From: Yinghai Lu ying...@kernel.org So we can pass pci_dev *dev to reuse some generic pci functions. Signed-off-by: Yinghai Lu ying...@kernel.org

[PATCH v4 0/2] Reset PCIe devices to address DMA problem on kdump with iommu

2012-10-15 Thread Takao Indoh
to be done before interrupt remapping is initialized. https://lkml.org/lkml/2012/10/2/54 v1: Add fixup_final quirk to reset PCIe devices https://lkml.org/lkml/2012/8/3/160 Thanks, Takao Indoh -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

[PATCH v4 1/2] x86, pci: Reset PCIe devices at boot time

2012-10-15 Thread Takao Indoh
This patch resets PCIe devices at boot time by hot reset when reset_devices is specified. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/include/asm/pci-direct.h |1 arch/x86/kernel/setup.c |3 arch/x86/pci/early.c | 344

[PATCH v4 2/2] x86, pci: Enable PCI INTx when MSI is disabled

2012-10-15 Thread Takao Indoh
. This patch fix this problem. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/pci/common.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index 720e973..2bb7ecc 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86

Re: [PATCH v4 1/2] x86, pci: Reset PCIe devices at boot time

2012-10-15 Thread Takao Indoh
(2012/10/16 3:36), Yinghai Lu wrote: On Mon, Oct 15, 2012 at 12:00 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: This patch resets PCIe devices at boot time by hot reset when reset_devices is specified. how about pci devices that domain_nr is not zero ? This patch does not support

Re: [PATCH v4 1/2] x86, pci: Reset PCIe devices at boot time

2012-10-16 Thread Takao Indoh
(2012/10/16 2:17), Khalid Aziz wrote: On Mon, 2012-10-15 at 16:00 +0900, Takao Indoh wrote: This patch resets PCIe devices at boot time by hot reset when reset_devices is specified. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/include/asm/pci-direct.h |1 arch

[PATCH v5 0/2] Reset PCIe devices to address DMA problem on kdump with iommu

2012-10-17 Thread Takao Indoh
fixup_final quirk to reset PCIe devices https://lkml.org/lkml/2012/8/3/160 Thanks, Takao Indoh -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

[PATCH v5 2/2] x86, pci: Enable PCI INTx when MSI is disabled

2012-10-17 Thread Takao Indoh
. This patch fix this problem. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/pci/common.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index 720e973..2bb7ecc 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86

[PATCH v5 1/2] x86, pci: Reset PCIe devices at boot time

2012-10-17 Thread Takao Indoh
This patch resets PCIe devices at boot time by hot reset when reset_devices is specified. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/include/asm/pci-direct.h |1 arch/x86/kernel/setup.c |3 arch/x86/pci/early.c | 353

Re: [PATCH] x86: revert x86: Fix S4 regression

2012-07-16 Thread Takao Indoh
gets merged. Thanks, Takao Indoh (2012/06/12 14:21), Cong Wang wrote: From: Cong Wang xiyou.wangc...@gmail.com This reverts the following commit: commit 8548c84da2f47e71bbbe300f55edb768492575f7 Author: Takashi Iwai ti...@suse.de Date: Sun Oct 23 23:19:12 2011 +0200

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-04-15 Thread Takao Indoh
(2013/04/10 13:47), Takao Indoh wrote: (2013/04/05 20:06), Joerg Roedel wrote: On Wed, Apr 03, 2013 at 09:24:39AM +0100, David Woodhouse wrote: On Wed, 2013-04-03 at 16:11 +0900, Takao Indoh wrote: Yeah, you are right. I forgot such a case. If you disable translation and there's some device

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-04-17 Thread Takao Indoh
(2013/04/15 19:18), Joerg Roedel wrote: On Mon, Apr 15, 2013 at 06:00:13PM +0900, Takao Indoh wrote: On DMAR initialization during kdump boot, do you guys agree to change order like this? Current order: (1) Disable translation (2) PCI initialization (3) Make pgtable and enable translation

Re: [PATCH 1/1] intel-iommu: Disable DMA Remapping when intel_iommu=off

2013-04-21 Thread Takao Indoh
above code and fix your patch like this, you need additinal fix to set iommu-gcmd flag sinse gcmd is always zero here. See first hunk of this patch. https://lkml.org/lkml/2013/3/20/707 Thanks, Takao Indoh Signed-off-by: Wei Hu w...@aristanetworks.com --- drivers/iommu/intel-iommu.c |6

Re: [PATCH 1/1] intel-iommu: Disable DMA Remapping when intel_iommu=off

2013-04-22 Thread Takao Indoh
(2013/04/22 15:50), Wei Hu wrote: On Sun, Apr 21, 2013 at 10:31 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/04/20 15:58), Wei Hu wrote: On a VT-d capable machine Linux will enable IOMMU by default. If it then kexec's a second kernel with intel_iommu=off, this second kernel

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-04-03 Thread Takao Indoh
(2013/04/03 17:24), David Woodhouse wrote: On Wed, 2013-04-03 at 16:11 +0900, Takao Indoh wrote: (2013/04/02 23:05), Joerg Roedel wrote: On Mon, Apr 01, 2013 at 02:45:18PM +0900, Takao Indoh wrote: Current flow on kdump boot enable_IR intel_enable_irq_remapping

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-04-08 Thread Takao Indoh
(2013/04/04 23:24), David Woodhouse wrote: On Thu, 2013-04-04 at 14:48 +0900, Takao Indoh wrote: - DMAR fault messages floods and second kernel does not boot. Recently I saw similar report. https://lkml.org/lkml/2013/3/8/120 Right. So the fix for that is to make the subsequent errors

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-04-09 Thread Takao Indoh
(2013/04/05 20:06), Joerg Roedel wrote: On Wed, Apr 03, 2013 at 09:24:39AM +0100, David Woodhouse wrote: On Wed, 2013-04-03 at 16:11 +0900, Takao Indoh wrote: Yeah, you are right. I forgot such a case. If you disable translation and there's some device still doing DMA, it's going to scribble

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-03-31 Thread Takao Indoh
(2013/03/27 19:31), Joerg Roedel wrote: On Wed, Mar 27, 2013 at 02:02:44PM +0900, Takao Indoh wrote: The root cause of this problem is mismatch between iommu-gcmd and global command register in the case of kdump. At boot time, initial value of iommu-gcmd is zero as I wrote above, but actual

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-04-03 Thread Takao Indoh
(2013/04/02 23:05), Joerg Roedel wrote: On Mon, Apr 01, 2013 at 02:45:18PM +0900, Takao Indoh wrote: Current flow on kdump boot enable_IR intel_enable_irq_remapping iommu_disable_irq_remapping == IRES/QIES/TES disabled here dmar_disable_qi == do nothing

[PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-03-20 Thread Takao Indoh
() to disable DMAR before initializing it if already enabled. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- drivers/iommu/dmar.c| 11 ++- drivers/iommu/intel-iommu.c | 12 2 files changed, 22 insertions(+), 1 deletions(-) diff --git a/drivers/iommu/dmar.c b

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-03-26 Thread Takao Indoh
(2013/03/26 23:46), Joerg Roedel wrote: On Thu, Mar 21, 2013 at 10:32:36AM +0900, Takao Indoh wrote: In this function, clearing IRE bit in iommu-gcmd and writing it to global command register. But initial value of iommu-gcmd is zero, so this writel means clearing all bits in global command

Re: 3.9-rc1: crash kernel panic - not syncing: Can not allocate SWIOTLB buffer earlier and can't now provide you with the DMA bounce buffer

2013-03-07 Thread Takao Indoh
[2.213618] dmar: DRHD: handling fault status reg 3 [..] This is the problem I'm working on. https://lkml.org/lkml/2012/11/26/814 Thansk, Takao Indoh -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu

2013-03-03 Thread Takao Indoh
(2013/01/23 9:47), Thomas Renninger wrote: On Monday, January 21, 2013 10:11:04 AM Takao Indoh wrote: (2013/01/08 4:09), Thomas Renninger wrote: ... I tried the provided patches first on 2.6.32, then I verfied with 3.8-rc2 and in both cases the disk is not detected anymore in reset_devices

Re: [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu

2013-03-04 Thread Takao Indoh
(2013/03/05 7:00), Don Dutile wrote: On 03/03/2013 07:56 PM, Takao Indoh wrote: (2013/01/23 9:47), Thomas Renninger wrote: On Monday, January 21, 2013 10:11:04 AM Takao Indoh wrote: (2013/01/08 4:09), Thomas Renninger wrote: ... I tried the provided patches first on 2.6.32, then I verfied

Re: [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu

2013-01-29 Thread Takao Indoh
(2013/01/29 10:14), Thomas Renninger wrote: On Thursday, January 24, 2013 09:23:14 AM Takao Indoh wrote: (2013/01/23 9:47), Thomas Renninger wrote: On Monday, January 21, 2013 10:11:04 AM Takao Indoh wrote: (2013/01/08 4:09), Thomas Renninger wrote: ... I tried the provided patches first

Re: [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu

2013-01-20 Thread Takao Indoh
(2013/01/08 4:09), Thomas Renninger wrote: On Friday, December 21, 2012 08:19:05 AM Yinghai Lu wrote: On Fri, Nov 30, 2012 at 7:49 AM, MUNEDA Takahiro muneda.takah...@jp.fujitsu.com wrote: On Tue, 27 Nov 2012 09:42:20 +0900 (JST), Takao Indoh indou.ta...@jp.fujitsu.com wrote: These patches

Re: [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu

2013-01-23 Thread Takao Indoh
(2013/01/23 9:47), Thomas Renninger wrote: On Monday, January 21, 2013 10:11:04 AM Takao Indoh wrote: (2013/01/08 4:09), Thomas Renninger wrote: ... I tried the provided patches first on 2.6.32, then I verfied with 3.8-rc2 and in both cases the disk is not detected anymore in reset_devices

Re: [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu

2012-09-10 Thread Takao Indoh
(2012/09/10 11:34), Kaneshige, Kenji wrote: -Original Message- From: linux-pci-ow...@vger.kernel.org [mailto:linux-pci-ow...@vger.kernel.org] On Behalf Of Takao Indoh Sent: Wednesday, September 05, 2012 8:10 PM To: vgo...@redhat.com Cc: ke...@lists.infradead.org; linux-kernel

Re: [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu

2012-09-11 Thread Takao Indoh
(2012/09/10 23:36), Vivek Goyal wrote: On Wed, Sep 05, 2012 at 08:09:58PM +0900, Takao Indoh wrote: (2012/08/07 5:39), Vivek Goyal wrote: On Mon, Aug 06, 2012 at 01:30:47PM +0900, Takao Indoh wrote: Hi Vivek, (2012/08/03 20:46), Vivek Goyal wrote: On Fri, Aug 03, 2012 at 08:24:31PM +0900

Re: [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu

2012-09-18 Thread Takao Indoh
to disable this function on such a machine. Wouldn't a DMI quirk be better for this? That way the second kernel internally would know not to do this. That sounds good. I'll try it, thanks. Thanks, Takao Indoh -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu

2012-09-12 Thread Takao Indoh
(2012/09/11 23:43), Vivek Goyal wrote: On Tue, Sep 11, 2012 at 07:32:35PM +0900, Takao Indoh wrote: [..] I'll post new patch which clears bus master bit and resets devices in second kernel. As to the boot parameter to enable this function, you suggested using reset_devices. I found

Re: [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu

2012-09-05 Thread Takao Indoh
(2012/08/07 5:39), Vivek Goyal wrote: On Mon, Aug 06, 2012 at 01:30:47PM +0900, Takao Indoh wrote: Hi Vivek, (2012/08/03 20:46), Vivek Goyal wrote: On Fri, Aug 03, 2012 at 08:24:31PM +0900, Takao Indoh wrote: Hi all, This patch adds kernel parameter reset_pcie_devices which resets PCIe

Re: [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu

2012-08-07 Thread Takao Indoh
(2012/08/07 5:39), Vivek Goyal wrote: On Mon, Aug 06, 2012 at 01:30:47PM +0900, Takao Indoh wrote: Hi Vivek, (2012/08/03 20:46), Vivek Goyal wrote: On Fri, Aug 03, 2012 at 08:24:31PM +0900, Takao Indoh wrote: Hi all, This patch adds kernel parameter reset_pcie_devices which resets PCIe

[RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu

2012-08-03 Thread Takao Indoh
out when the link between the port and VGA controller was reset. So this patch does not reset the port whose child endpoint is VGA device. Any comments would be appreciated. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- Documentation/kernel-parameters.txt |4 + drivers/pci/quirks.c

Re: [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu

2012-08-05 Thread Takao Indoh
Hi Vivek, (2012/08/03 20:46), Vivek Goyal wrote: On Fri, Aug 03, 2012 at 08:24:31PM +0900, Takao Indoh wrote: Hi all, This patch adds kernel parameter reset_pcie_devices which resets PCIe devices at boot time to address DMA problem on kdump with iommu. When this parameter is specified

Re: [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu

2012-08-05 Thread Takao Indoh
Hi Don, (2012/08/06 13:09), Don Dutile wrote: On 08/03/2012 07:24 AM, Takao Indoh wrote: Hi all, This patch adds kernel parameter reset_pcie_devices which resets PCIe devices at boot time to address DMA problem on kdump with iommu. When this parameter is specified, a hot reset is triggered

Re: [PATCH] x86: revert x86: Fix S4 regression

2012-07-23 Thread Takao Indoh
(2012/07/23 19:00), Dave Young wrote: On 07/17/2012 11:15 AM, Takao Indoh wrote: Hi Cong, When I tested kdump with 3.5.0-rc6 kernel, I found a problem of kdump kernel's panic in find_early_table_space(). init_memory_mapping: [mem 0x-0x36ffafff] Kernel panic - not syncing: Cannot

Re: [PATCH] x86: revert x86: Fix S4 regression

2012-07-24 Thread Takao Indoh
(2012/07/25 0:55), Cong Wang wrote: On Mon, 2012-07-23 at 20:22 +0900, Takao Indoh wrote: (2012/07/23 19:00), Dave Young wrote: On 07/17/2012 11:15 AM, Takao Indoh wrote: Hi Cong, When I tested kdump with 3.5.0-rc6 kernel, I found a problem of kdump kernel's panic in find_early_table_space

[PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu

2012-11-26 Thread Takao Indoh
that they are called only once. https://lkml.org/lkml/2012/10/10/57 v2: Reset devices in setup_arch() because reset need to be done before interrupt remapping is initialized. https://lkml.org/lkml/2012/10/2/54 v1: Add fixup_final quirk to reset PCIe devices https://lkml.org/lkml/2012/8/3/160 Takao Indoh (5

[PATCH v7 1/5] x86, pci: add dummy pci device for early stage

2012-11-26 Thread Takao Indoh
So we can pass pci_dev *dev to reuse some generic pci functions. The original patch was written by Yinghai Lu. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/include/asm/pci-direct.h |2 + arch/x86/pci/early.c | 74 + 2

[PATCH v7 2/5] PCI: Define the maximum number of PCI function

2012-11-26 Thread Takao Indoh
Define the maximum number of PCI function so that PCI functions can be enumerated without using 8. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- include/linux/pci.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/pci.h b/include/linux/pci.h

[PATCH v7 3/5] Make reset_devices available at early stage

2012-11-26 Thread Takao Indoh
Change reset_devices from __setup to early_param so this parameter is available at early stage. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- init/main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/init/main.c b/init/main.c index e33e09d..f2b24cb

[PATCH v7 4/5] x86, pci: Reset PCIe devices at boot time

2012-11-26 Thread Takao Indoh
during boot to stop its DMA. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/include/asm/pci-direct.h |1 + arch/x86/kernel/setup.c |3 + arch/x86/pci/early.c | 241 + 3 files changed, 245 insertions(+), 0 deletions

[PATCH v7 5/5] x86, pci: Enable PCI INTx when MSI is disabled

2012-11-26 Thread Takao Indoh
. This patch fix this problem. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/pci/common.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index 720e973..2bb7ecc 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86

Re: [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu

2012-12-21 Thread Takao Indoh
. Thanks, Takao Indoh 2012/11/27 Takao Indoh indou.ta...@jp.fujitsu.com mailto:indou.ta...@jp.fujitsu.com These patches reset PCIe devices at boot time to address DMA problem on kdump with iommu. When reset_devices is specified, a hot reset is triggered on each PCIe root port

[PATCH v2 0/2] Reset PCIe devices to address DMA problem on kdump with iommu

2012-10-02 Thread Takao Indoh
whose child endpoint is VGA device. v2: Reset devices in setup_arch() because reset need to be done before interrupt remapping is initialized. v1: https://lkml.org/lkml/2012/8/3/160 Thanks, Takao Indoh -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

[PATCH v2 1/2] x86, pci: Reset PCIe devices at boot time

2012-10-02 Thread Takao Indoh
This patch resets PCIe devices at boot time by hot reset when reset_devices is specified. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/include/asm/pci-direct.h |1 arch/x86/kernel/setup.c |3 arch/x86/pci/early.c | 302

[PATCH v2 2/2] x86, pci: Enable PCI INTx when MSI is disabled

2012-10-02 Thread Takao Indoh
. This patch fix this problem. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/pci/common.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index 720e973..2bb7ecc 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86

Re: [PATCH v2 0/2] Reset PCIe devices to address DMA problem on kdump with iommu

2012-10-02 Thread Takao Indoh
(2012/10/03 4:37), Andi Kleen wrote: Takao Indoh indou.ta...@jp.fujitsu.com writes: These patches reset PCIe devices at boot time to address DMA problem on kdump with iommu. When reset_devices is specified, a hot reset is triggered on each PCIe root port and downstream port to reset its

Re: [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu

2013-01-08 Thread Takao Indoh
PCI(e) error handlers get active?)? Or AER framework may be able to handle this. Actually it has a function to reset endpoint when error is detected. Thanks, Takao Indoh If this does not help the next step could be to stop DMAR error interrupt handling or other iommu commands to keep

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-28 Thread Takao Indoh
(2013/07/25 23:24), Vivek Goyal wrote: On Wed, Jul 24, 2013 at 03:29:58PM +0900, Takao Indoh wrote: Sorry for letting this discussion slide, I was busy on other works:-( Anyway, the summary of previous discussion is: - My patch adds new initcall(fs_initcall) to reset all PCIe endpoints

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-28 Thread Takao Indoh
(2013/07/26 2:00), Bjorn Helgaas wrote: On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: Sorry for letting this discussion slide, I was busy on other works:-( Anyway, the summary of previous discussion is: - My patch adds new initcall(fs_initcall) to reset all

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Takao Indoh
(2013/07/29 23:17), Bjorn Helgaas wrote: On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/07/26 2:00), Bjorn Helgaas wrote: On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: Sorry for letting this discussion slide, I was busy

[PATCH] intel-iommu: Quiesce devices before disabling IOMMU

2013-08-21 Thread Takao Indoh
, at last kdump fails. This patch fixes this problem. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com NOTE: To reset devices this patch uses bus reset interface introduced by following commits in PCI next branch. 64e8674fbe6bc848333a9b7e19f8cc019dde9eab 5c32b35b004f5ef70dcf62bbc42b8bed1e50b471

Re: PCIE resetting graphic card

2013-07-11 Thread Takao Indoh
back legacy VGA mode after reset. It seems not to be easy:-( Maybe this document is helpful to do this. http://www.coreboot.org/images/2/2b/Vgabios.pdf Thanks, Takao Indoh We have problems, if 1st kernel is in kms mode kdump kernel will have no chance to switch back to VGA console. There's

Re: [PATCH] intel-iommu: Quiesce devices before disabling IOMMU

2013-09-09 Thread Takao Indoh
(2013/09/09 18:07), David Woodhouse wrote: On Wed, 2013-08-21 at 16:15 +0900, Takao Indoh wrote: This causes problem on kdump. Devices are working in first kernel, and after switching to second kernel and initializing IOMMU, many DMAR faults occur and it causes problems like driver error

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Takao Indoh
(2013/07/31 0:59), Bjorn Helgaas wrote: On Tue, Jul 30, 2013 at 12:09 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/07/29 23:17), Bjorn Helgaas wrote: On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/07/26 2:00), Bjorn Helgaas wrote: My point

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Takao Indoh
(2013/07/31 12:11), Alex Williamson wrote: On Wed, 2013-07-31 at 09:35 +0900, Takao Indoh wrote: diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index e37fea6..c595997 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -3392,6 +3392,59 @@ int pci_reset_function(struct pci_dev *dev

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-08-01 Thread Takao Indoh
(2013/08/01 6:23), Rafael J. Wysocki wrote: On Wednesday, July 31, 2013 03:08:03 PM Bjorn Helgaas wrote: [+cc Rafael, linux-acpi] On Tue, Jul 30, 2013 at 6:35 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: On x86, currently IOMMU initialization run *after* PCI enumeration, but what you

[PATCH v2] intel-iommu: Quiesce devices before disabling IOMMU

2013-09-18 Thread Takao Indoh
, at last kdump fails. This patch fixes this problem. Changelog: v2: - Add CONTEXT_ENTRY_NR v1: https://lkml.org/lkml/2013/8/21/71 Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- drivers/iommu/intel-iommu.c | 56 ++- 1 files changed, 55 insertions

Re: [RFC PATCH] Crashdump Accepting Active IOMMU

2013-11-19 Thread Takao Indoh
. Ok, I'll wait for new patches! Thanks, Takao Indoh Bill -Original Message- From: Takao Indoh [mailto:indou.ta...@jp.fujitsu.com] Sent: Tuesday, November 12, 2013 12:45 AM To: Sumner, William; bhelg...@google.com; alex.william...@redhat.com; ddut...@redhat.com Cc: linux

Re: [PATCH] Reset PCIe devices to stop ongoing DMA

2013-05-08 Thread Takao Indoh
(2013/05/07 21:50), Don Dutile wrote: On 05/07/2013 03:09 AM, Takao Indoh wrote: Sorry for the delayed response. (2013/04/30 23:54), Sumner, William wrote: I have installed your original patch set (from last November) and tested with three platforms, each with a different IO configuration

Re: [PATCH] Reset PCIe devices to stop ongoing DMA

2013-05-08 Thread Takao Indoh
(2013/05/08 7:04), Alex Williamson wrote: On Tue, 2013-05-07 at 16:10 -0400, Don Dutile wrote: On 05/07/2013 12:39 PM, Alex Williamson wrote: On Wed, 2013-04-24 at 13:58 +0900, Takao Indoh wrote: This patch resets PCIe devices on boot to stop ongoing DMA. When pci=pcie_reset_devices

Re: [PATCH] Reset PCIe devices to stop ongoing DMA

2013-05-08 Thread Takao Indoh
(2013/04/26 3:01), Don Dutile wrote: On 04/25/2013 01:11 AM, Takao Indoh wrote: (2013/04/25 4:59), Don Dutile wrote: On 04/24/2013 12:58 AM, Takao Indoh wrote: This patch resets PCIe devices on boot to stop ongoing DMA. When pci=pcie_reset_devices is specified, a hot reset is triggered

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-11 Thread Takao Indoh
(2013/06/11 11:20), Bjorn Helgaas wrote: On Fri, Jun 7, 2013 at 2:46 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/06/07 13:14), Bjorn Helgaas wrote: One thing I'm not sure about is that you are only resetting PCIe devices, but I don't think the problem is actually specific

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-12 Thread Takao Indoh
(2013/06/12 13:45), Bjorn Helgaas wrote: [+cc Vivek, Haren; sorry I didn't think to add you earlier] On Tue, Jun 11, 2013 at 12:08 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/06/11 11:20), Bjorn Helgaas wrote: I'm not sure you need to reset legacy devices (or non-PCI devices

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-12 Thread Takao Indoh
sensitive in them. It'd be nice if they could be made public if there's not. I really appreciate your comments! I'll confirm I can make it public. I would greatly appreciate being able to see the bugzillas relating to this patch. Thanks, Takao Indoh Thinking out of the box: Much

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-13 Thread Takao Indoh
(2013/06/13 12:41), Bjorn Helgaas wrote: On Wed, Jun 12, 2013 at 8:44 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/06/12 13:45), Bjorn Helgaas wrote: [+cc Vivek, Haren; sorry I didn't think to add you earlier] On Tue, Jun 11, 2013 at 12:08 AM, Takao Indoh indou.ta

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-06 Thread Takao Indoh
. Thanks, Takao Indoh (2013/05/14 14:29), Takao Indoh wrote: This patch resets PCIe devices on boot to stop ongoing DMA. When pci=pcie_reset_endpoint_devices is specified, a hot reset is triggered on each PCIe root port and downstream port to reset its downstream endpoint. Problem: This patch

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-07 Thread Takao Indoh
, so please pardon (and help me with) any silly questions or assumptions below. On Mon, May 13, 2013 at 11:29 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: This patch resets PCIe devices on boot to stop ongoing DMA. When pci=pcie_reset_endpoint_devices is specified, a hot reset

[PATCH v2] intel-iommu: Disable translation if already enabled

2013-04-23 Thread Takao Indoh
-by: Takao Indoh indou.ta...@jp.fujitsu.com --- drivers/iommu/dmar.c| 11 ++- drivers/iommu/intel-iommu.c | 15 +++ 2 files changed, 25 insertions(+), 1 deletions(-) diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c index e5cdaf8..9f69352 100644 --- a/drivers

[PATCH] Reset PCIe devices to stop ongoing DMA

2013-04-23 Thread Takao Indoh
-by: Takao Indoh indou.ta...@jp.fujitsu.com --- Documentation/kernel-parameters.txt |2 + drivers/pci/pci.c | 103 +++ 2 files changed, 105 insertions(+), 0 deletions(-) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel

Re: [PATCH] Reset PCIe devices to stop ongoing DMA

2013-04-24 Thread Takao Indoh
(2013/04/25 4:59), Don Dutile wrote: On 04/24/2013 12:58 AM, Takao Indoh wrote: This patch resets PCIe devices on boot to stop ongoing DMA. When pci=pcie_reset_devices is specified, a hot reset is triggered on each PCIe root port and downstream port to reset its downstream endpoint. Problem

Re: [PATCH] Reset PCIe devices to stop ongoing DMA

2013-04-25 Thread Takao Indoh
(2013/04/26 3:01), Don Dutile wrote: On 04/25/2013 01:11 AM, Takao Indoh wrote: (2013/04/25 4:59), Don Dutile wrote: On 04/24/2013 12:58 AM, Takao Indoh wrote: This patch resets PCIe devices on boot to stop ongoing DMA. When pci=pcie_reset_devices is specified, a hot reset is triggered

Re: [PATCH] Reset PCIe devices to stop ongoing DMA

2013-05-15 Thread Takao Indoh
, pcie_flr() is called in __pci_dev_reset() and it returned true, but DMAR error occurred after its driver was loaded. One of ideas is adding boot parameter so user can choose appropriate method: just clearing bus master, FLR, hot-reset, etc. Thanks, Takao Indoh Bill Sumner -Original

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-05-21 Thread Takao Indoh
Hi Bjorn, Any comments, ack/nack? Thanks, Takao Indoh (2013/05/15 7:04), Eric W. Biederman wrote: Takao Indoh indou.ta...@jp.fujitsu.com writes: This patch resets PCIe devices on boot to stop ongoing DMA. When pci=pcie_reset_endpoint_devices is specified, a hot reset is triggered on each

[PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-05-13 Thread Takao Indoh
because the monitor blacks out if VGA controller is reset. Changelog: v2: - Read pci config before de-assert secondary bus reset to flush previous write - Change function/variable name - Make a list of devices to be reset v1: https://patchwork.kernel.org/patch/2482291/ Signed-off-by: Takao Indoh

Re: [PATCH] intel-iommu: Quiesce devices before disabling IOMMU

2013-09-08 Thread Takao Indoh
(2013/09/08 20:47), Baoquan He wrote: Hi, Patch is great and works on my HP-z420. Thank you for your test! There are several small concerns, please see inline comments. On 08/21/13 at 04:15pm, Takao Indoh wrote: This patch quiesces devices before disabling IOMMU on boot to stop ongoing

Re: [PATCH] intel-iommu: Quiesce devices before disabling IOMMU

2013-09-08 Thread Takao Indoh
(2013/09/09 13:28), Takao Indoh wrote: BTW, what's the status of Alex's PCI patchset which this patch depends on? It is merged to Bjorn's tree, will be in v3.12. This was wrong. Alex's patchset is already in Linus tree, v3.11. Thanks, Takao Indoh -- To unsubscribe from this list: send

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-24 Thread Takao Indoh
boot parameter seems to be unpopular for maintainers. Any ideas? Thanks, Takao Indoh (2013/06/14 11:11), Takao Indoh wrote: (2013/06/13 12:41), Bjorn Helgaas wrote: On Wed, Jun 12, 2013 at 8:44 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/06/12 13:45), Bjorn Helgaas wrote: [+cc

ftrace/kprobes: Warning when insmod two modules

2014-03-23 Thread Takao Indoh
to rewrite its text at (5), but it fails because it is already changed to RO at (2) by modules A. The ftrace waring message is outputted. I'm not familiar with ftrace/kprobe, so any comments/suggestions would be appreciatd to fix this. Thanks, Takao Indoh -- To unsubscribe from this list: send

Re: ftrace/kprobes: Warning when insmod two modules

2014-03-24 Thread Takao Indoh
it? Yep, I tested using my reproducer and confirmed that this patch fixed this issue, thanks! Thanks, Takao Indoh In-review-off-by: Steven Rostedt rost...@goodmis.org diff --git a/include/linux/module.h b/include/linux/module.h index 5a50539..a1acabf 100644 --- a/include/linux/module.h

  1   2   3   4   >