Re: [PATCH resend] sound: Convert strlcpy to strscpy when return value is unused

2021-01-05 Thread Takashi Iwai
gt; sound/usb/mixer.c: return strlcpy(buf, p->names[index], > buflen); > > Miscellenea: > > o Remove trailing whitespace in conversion of sound/core/hwdep.c > > Link: > https://lore.kernel.org/lkml/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=v6a6g1ouzcprm

[GIT PULL] sound fixes for 5.11-rc3

2021-01-05 Thread Takashi Iwai
: Add two "Intel Reference board" SSID in the ALC256. Takashi Iwai (4): ALSA: usb-audio: Fix UBSAN warnings for MIDI jacks ALSA: usb-audio: Add quirk for BOSS AD-10 ALSA: hda/hdmi: Fix incorrect mutex unlock in silent_stream_disable() ALSA: hda/via: Fix runtime PM

Re: [PATCH] sound: Convert strlcpy to strscpy when return value is unused

2021-01-04 Thread Takashi Iwai
On Thu, 31 Dec 2020 20:04:50 +0100, Joe Perches wrote: > > strlcpy is deprecated. see: Documentation/process/deprecated.rst > > Change the calls that do not use the strlcpy return value to the > preferred strscpy. > > Done with cocci script: > > @@ > expression e1, e2, e3; > @@ > > - strl

Re: [PATCH] ALSA: hda: fix SND_INTEL_DSP_CONFIG dependency

2021-01-04 Thread Takashi Iwai
On Mon, 04 Jan 2021 16:00:05 +0100, Jaroslav Kysela wrote: > > Dne 03. 01. 21 v 14:52 Arnd Bergmann napsal(a): > > From: Arnd Bergmann > > > > The sof-pci-dev driver fails to link when built into the kernel > > and CONFIG_SND_INTEL_DSP_CONFIG is set to =m: > > > > arm-linux-gnueabi-ld: sound/so

Re: [PATCH 0/2] fix tegra-hda on tegra30 devices

2021-01-04 Thread Takashi Iwai
On Fri, 25 Dec 2020 02:20:24 +0100, Peter Geis wrote: > > The following patches fix tegra-hda on legacy tegra devices. > Two issues were discovered preventing tegra-hda from functioning: > The hda clocks on tegra30 were assigned to clk_m and running at too low of a > rate to function. > The tegra

Re: [PATCH] ALSA: hda: fix SND_INTEL_DSP_CONFIG dependency

2021-01-04 Thread Takashi Iwai
On Sun, 03 Jan 2021 14:52:32 +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > The sof-pci-dev driver fails to link when built into the kernel > and CONFIG_SND_INTEL_DSP_CONFIG is set to =m: > > arm-linux-gnueabi-ld: sound/soc/sof/sof-pci-dev.o: in function > `sof_pci_probe': > sof-pci-d

Re: [PATCH 2/2] ASoC: SOF: Intel: hda: Avoid checking jack on system suspend

2021-01-01 Thread Takashi Iwai
On Thu, 31 Dec 2020 19:06:43 +0100, Kai-Heng Feng wrote: > > On Thu, Dec 31, 2020 at 6:55 PM Takashi Iwai wrote: > > > > On Tue, 29 Dec 2020 14:38:15 +0100, > > Kai-Heng Feng wrote: > > > > > > System takes a very long time to suspend after commit 215a

Re: [PATCH 4.19 267/346] ALSA: hda/ca0132 - Change Input Source enum strings.

2021-01-01 Thread Takashi Iwai
On Thu, 31 Dec 2020 19:15:42 +0100, Pavel Machek wrote: > > Hi! > > > From: Connor McAdams > > > > commit 7079f785b50055a32b72eddcb7d9ba5688db24d0 upstream. > > > > Change the Input Source enumerated control's strings to make it play > > nice with pulseaudio. > > > +++ b/sound/pci/hda/patch_c

Re: [PATCH] ALSA: hda/realtek: Enable mute and micmute LED on HP EliteBook 850 G7

2020-12-31 Thread Takashi Iwai
On Wed, 30 Dec 2020 13:56:35 +0100, Kai-Heng Feng wrote: > > HP EliteBook 850 G7 uses the same GPIO pins as ALC285_FIXUP_HP_GPIO_LED > to enable mute and micmute LED. So apply the quirk to enable the LEDs. > > Signed-off-by: Kai-Heng Feng Thanks, applied now. Takashi

Re: [PATCH] ALSA: hda/realtek: Add mute LED quirk for more HP laptops

2020-12-31 Thread Takashi Iwai
On Tue, 29 Dec 2020 15:38:56 +0100, Manuel Jiménez wrote: > > HP Pavilion 13-bb (SSID 103c:87c8) needs the same > quirk as other models with ALC287. > > Signed-off-by: Manuel Jiménez Applied now. Thanks. Takashi

Re: [PATCH 2/2] ASoC: SOF: Intel: hda: Avoid checking jack on system suspend

2020-12-31 Thread Takashi Iwai
On Tue, 29 Dec 2020 14:38:15 +0100, Kai-Heng Feng wrote: > > System takes a very long time to suspend after commit 215a22ed31a1 > ("ALSA: hda: Refactor codec PM to use direct-complete optimization"): > [ 90.065964] PM: suspend entry (s2idle) > [ 90.067337] Filesystems sync: 0.001 seconds > [

Re: [PATCH 1/2] ASoC: SOF: Intel: hda: Modify existing helper to disable WAKEEN

2020-12-31 Thread Takashi Iwai
On Tue, 29 Dec 2020 14:38:14 +0100, Kai-Heng Feng wrote: > > Modify hda_codec_jack_wake_enable() to also support disable WAKEEN. > This is a preparation for next patch. > > No functional change intended. Maybe it's better to mention that this patch moves the WAKEEN disablement call out of hda_co

Re: [PATCH] sound: pci: hda: add a new hda codec

2020-12-31 Thread Takashi Iwai
On Tue, 29 Dec 2020 04:52:26 +0100, bo@senarytech.com wrote: > > From: bo liu > > The current kernel does not support the cx11970 codec chip. > Add a codec configuration item to kernel. > > Signed-off-by: bo liu Thanks, applied with a minor coding style fix now. Takashi

Re: [PATCH] ALSA:usb-audio:check urb before kill it

2020-12-29 Thread Takashi Iwai
On Sun, 27 Dec 2020 14:04:59 +0100, Defang Bo wrote: > > Similar to commit<124751d5e>, there should be a check for urb before kill it. > > Signed-off-by: Defang Bo usb_kill_urb() accepts the NULL urb pointer, so the NULL check in the caller side is basically superfluous. thanks, Takashi > -

Re: [PATCH] ASoC: amd:Replacing MSI with Legacy IRQ model

2020-12-27 Thread Takashi Iwai
On Sun, 27 Dec 2020 19:03:28 +0100, Jaroslav Kysela wrote: > > Dne 22. 12. 20 v 12:59 Ravulapati Vishnu vardhan rao napsal(a): > > When we try to play and capture simultaneously we see that > > interrupts are genrated but our handler is not being acknowledged, > > After investigating further more

Re: [PATCH] ALSA: hda: Resume codec for system suspend if LED is controlled by codec

2020-12-25 Thread Takashi Iwai
On Fri, 25 Dec 2020 17:47:23 +0100, Kai-Heng Feng wrote: > > Laptop with codec controlled LEDs takes a very long time to suspend > after commit 215a22ed31a1 ("ALSA: hda: Refactor codec PM to use > direct-complete optimization"): > [ 90.065964] PM: suspend entry (s2idle) > [ 90.067337] Filesyst

[GIT PULL] sound fixes for 5.11-rc1

2020-12-23 Thread Takashi Iwai
): ALSA: core: memalloc: add page alignment for iram Takashi Iwai (6): ALSA: usb-audio: Disable sample read check if firmware doesn't give back ALSA: memalloc: Align buffer allocations in page size ALSA: pcm: Clear the full allocated memory at hw_params ALSA: pcm: oss: Fix

Re: [PATCH AUTOSEL 5.4 057/130] ALSA: usb-audio: Check valid altsetting at parsing rates for UAC2/3

2020-12-22 Thread Takashi Iwai
On Wed, 23 Dec 2020 03:17:00 +0100, Sasha Levin wrote: > > From: Takashi Iwai > > [ Upstream commit 93db51d06b32227319dae2ac289029ccf1b33181 ] > > The current driver code assumes blindly that all found sample rates for > the same endpoint from the UAC2 and UAC3 descr

Re: [PATCH 2/2] ALSA/hda: apply jack fixup for the Acer Veriton N4640G/N6640G/N2510G

2020-12-22 Thread Takashi Iwai
On Tue, 22 Dec 2020 16:04:59 +0100, Chris Chiu wrote: > > This Acer Veriton N4640G/N6640G/N2510G desktops have 2 headphone > jacks(front and rear), and a separate Mic In jack. > > The rear headphone jack is actually a line out jack but always silent > while playing audio. The front 'Mic In' also

Re: [PATCH 1/2] ALSA: hda/realtek: Apply jack fixup for Quanta NL3

2020-12-22 Thread Takashi Iwai
On Tue, 22 Dec 2020 16:04:58 +0100, Chris Chiu wrote: > > The Quanta NL3 laptop has both a headphone output jack and a headset > jack, on the right edge of the chassis. > > The pin information suggests that both of these are at the Front. > The PulseAudio is confused to differentiate them so one

Re: [PATCH] ASoC: amd:Replacing MSI with Legacy IRQ model

2020-12-22 Thread Takashi Iwai
On Tue, 22 Dec 2020 12:59:18 +0100, Ravulapati Vishnu vardhan rao wrote: > > When we try to play and capture simultaneously we see that > interrupts are genrated but our handler is not being acknowledged, > After investigating further more in detail on this issue we found > that IRQ delivery via M

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-21 Thread Takashi Iwai
On Mon, 21 Dec 2020 17:33:20 +0100, Kai-Heng Feng wrote: > > [+Cc nouveau] > > On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai wrote: > [snip] > > > Quite possibly the system doesn't power up HDA controller when there's > > > no external monitor. >

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-18 Thread Takashi Iwai
On Fri, 18 Dec 2020 06:09:38 +0100, Kai-Heng Feng wrote: > > [+Cc Bjorn, Alan and linux-pci] > > On Thu, Dec 17, 2020 at 12:57 AM Takashi Iwai wrote: > > > > On Wed, 16 Dec 2020 17:22:17 +0100, > > Takashi Iwai wrote: > > > > > > On Wed, 16 De

Re: [PATCH v1 ] ALSA: core: memalloc: add page alignment for iram

2020-12-17 Thread Takashi Iwai
On Thu, 17 Dec 2020 16:38:22 +0100, Lars-Peter Clausen wrote: > > >> Maybe what we need is a check that runtime->dma_area is page aligned > >> and runtime->dma_bytes is a multiple of PAGE_SIZE. With a warning at > >> first and then turn this into a error a year later or so. > > OK, how about the f

Re: [PATCH v1 ] ALSA: core: memalloc: add page alignment for iram

2020-12-17 Thread Takashi Iwai
On Thu, 17 Dec 2020 15:57:02 +0100, Lars-Peter Clausen wrote: > > On 12/17/20 3:24 PM, Takashi Iwai wrote: > > On Thu, 17 Dec 2020 14:16:48 +0100, > > Lars-Peter Clausen wrote: > >> On 12/17/20 12:06 PM, Takashi Iwai wrote: > >>> On Thu, 17 Dec 2020 11:59:2

Re: [PATCH v1 ] ALSA: core: memalloc: add page alignment for iram

2020-12-17 Thread Takashi Iwai
On Thu, 17 Dec 2020 14:16:48 +0100, Lars-Peter Clausen wrote: > > On 12/17/20 12:06 PM, Takashi Iwai wrote: > > On Thu, 17 Dec 2020 11:59:23 +0100, > > Lars-Peter Clausen wrote: > >> On 12/17/20 10:55 AM, Takashi Iwai wrote: > >>> On Thu, 17 Dec 2020 10:43:4

Re: [PATCH v1 ] ALSA: core: memalloc: add page alignment for iram

2020-12-17 Thread Takashi Iwai
On Thu, 17 Dec 2020 11:59:23 +0100, Lars-Peter Clausen wrote: > > On 12/17/20 10:55 AM, Takashi Iwai wrote: > > On Thu, 17 Dec 2020 10:43:45 +0100, > > Lars-Peter Clausen wrote: > >> On 12/17/20 5:15 PM, Robin Gong wrote: > >>> Since mmap for userspa

Re: [PATCH v1 ] ALSA: core: memalloc: add page alignment for iram

2020-12-17 Thread Takashi Iwai
On Thu, 17 Dec 2020 10:55:42 +0100, Takashi Iwai wrote: > > On Thu, 17 Dec 2020 10:43:45 +0100, > Lars-Peter Clausen wrote: > > > > On 12/17/20 5:15 PM, Robin Gong wrote: > > > Since mmap for userspace is based on page alignment, add page alignment > > > fo

Re: [PATCH v1 ] ALSA: core: memalloc: add page alignment for iram

2020-12-17 Thread Takashi Iwai
On Thu, 17 Dec 2020 10:43:45 +0100, Lars-Peter Clausen wrote: > > On 12/17/20 5:15 PM, Robin Gong wrote: > > Since mmap for userspace is based on page alignment, add page alignment > > for iram alloc from pool, otherwise, some good data located in the same > > page of dmab->area maybe touched wron

Re: [PATCH 01/01] Add VID to support native DSD reproduction on FiiO devices.

2020-12-17 Thread Takashi Iwai
On Wed, 16 Dec 2020 19:29:09 +0100, Amadej Kastelic wrote: > > On Wed, Dec 16, 2020 at 04:38:07PM +0100, Takashi Iwai wrote: > > On Tue, 15 Dec 2020 19:09:05 +0100, > > Amadej Kastelic wrote: > > > > > > Message-Id: > > > > > > Add

Re: [PATCH v1 ] ALSA: core: memalloc: add page alignment for iram

2020-12-17 Thread Takashi Iwai
On Thu, 17 Dec 2020 17:15:47 +0100, Robin Gong wrote: > > Since mmap for userspace is based on page alignment, add page alignment > for iram alloc from pool, otherwise, some good data located in the same > page of dmab->area maybe touched wrongly by userspace like pulseaudio. > > Signed-off-by: R

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-16 Thread Takashi Iwai
On Wed, 16 Dec 2020 17:22:17 +0100, Takashi Iwai wrote: > > On Wed, 16 Dec 2020 17:07:45 +0100, > Kai-Heng Feng wrote: > > > > On Wed, Dec 16, 2020 at 11:58 PM Takashi Iwai wrote: > > > > > > On Wed, 16 Dec 2020 16:50:20 +0100, > > > Kai-Heng Fen

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-16 Thread Takashi Iwai
On Wed, 16 Dec 2020 17:07:45 +0100, Kai-Heng Feng wrote: > > On Wed, Dec 16, 2020 at 11:58 PM Takashi Iwai wrote: > > > > On Wed, 16 Dec 2020 16:50:20 +0100, > > Kai-Heng Feng wrote: > > > > > > On Wed, Dec 16, 2020 at 11:41 PM Takashi Iwai wrote: &g

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-16 Thread Takashi Iwai
On Wed, 16 Dec 2020 16:50:20 +0100, Kai-Heng Feng wrote: > > On Wed, Dec 16, 2020 at 11:41 PM Takashi Iwai wrote: > > > > On Wed, 16 Dec 2020 13:47:24 +0100, > > Kai-Heng Feng wrote: > > > > > > Similar to commit 9479e75fca37 ("ALSA: hda: Keep

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-16 Thread Takashi Iwai
On Wed, 16 Dec 2020 13:47:24 +0100, Kai-Heng Feng wrote: > > Similar to commit 9479e75fca37 ("ALSA: hda: Keep the controller > initialization even if no codecs found"), when codec probe fails, it > doesn't enable runtime suspend, and can prevent graphics card from > getting powered down: > [4.

Re: [PATCH 01/01] Add VID to support native DSD reproduction on FiiO devices.

2020-12-16 Thread Takashi Iwai
On Tue, 15 Dec 2020 19:09:05 +0100, Amadej Kastelic wrote: > > Message-Id: > > Add VID to support native DSD reproduction on FiiO devices. > > Tested-by: Amadej Kastelic > Signed-off-by: Emilio Moretti Could you give your own sign-off, too? Each person who submits the patch needs the sign-o

Re: [PATCH] ALSA: hda/realtek: Remove dummy lineout on Acer TravelMate P648/P658

2020-12-16 Thread Takashi Iwai
On Wed, 16 Dec 2020 13:52:00 +0100, Chris Chiu wrote: > > Acer TravelMate laptops P648/P658 series with codec ALC282 only have > one physical jack for headset but there's a confusing lineout pin on > NID 0x1b reported. Audio applications hence misunderstand that there > are a speaker and a lineout

[GIT PULL] sound updates for 5.11-rc1

2020-12-15 Thread Takashi Iwai
x DEBUG_LOCKS_WARN_ON for uninitialized attribute ASoC: q6afe-clocks: Add missing parent clock rate Sudip Mukherjee (1): ASoC: mediatek: mt8192: Fix build failure Takashi Iwai (52): ALSA: usb-audio: Handle discrete rates properly in hw constraints ALSA: usb-audio: Don

Re: [PATCH] ALSA: hda: Enable runtime PM when codec probe fails

2020-12-14 Thread Takashi Iwai
On Mon, 14 Dec 2020 07:06:20 +0100, Kai-Heng Feng wrote: > > When codec probe fails, it doesn't enable runtime suspend, and can > prevent graphics card from getting powered down: > [4.280991] snd_hda_intel :01:00.1: no codecs initialized > > $ cat /sys/bus/pci/devices/:01:00.1/power/r

Re: [PATCH 1/2] ALSA: hda/ca0132 - Add 8051 PLL write helper functions.

2020-12-12 Thread Takashi Iwai
On Fri, 11 Dec 2020 23:55:02 +0100, Connor McAdams wrote: > > Add helper functions for the 8051 PLL PMU write verbs. > > Signed-off-by: Connor McAdams Applied both patches now. Thanks. Takashi

Re: [PATCH 4.19 15/39] ALSA: hda/generic: Add option to enforce preferred_dacs pairs

2020-12-11 Thread Takashi Iwai
On Fri, 11 Dec 2020 23:38:22 +0100, Pavel Machek wrote: > > Hi! > > > > > From: Takashi Iwai > > > > > > > > commit 242d990c158d5b1dabd166516e21992baef5f26a upstream. > > > > > > > > The generic parser accepts the preferre

Re: [PATCH 4.19 15/39] ALSA: hda/generic: Add option to enforce preferred_dacs pairs

2020-12-11 Thread Takashi Iwai
On Fri, 11 Dec 2020 09:36:21 +0100, Pavel Machek wrote: > > Hi! > > > From: Takashi Iwai > > > > commit 242d990c158d5b1dabd166516e21992baef5f26a upstream. > > > > The generic parser accepts the preferred_dacs[] pairs as a hint for > > assigning

Re: [PATCH v3 1/2] ALSA: hda/ca0132 - Fix AE-5 rear headphone pincfg.

2020-12-10 Thread Takashi Iwai
> set it to be a headphone. > > Fixes: a6b0961b39896 ("ALSA: hda/ca0132 - fix AE-5 pincfg") > Cc: > Signed-off-by: Connor McAdams > Link: https://lore.kernel.org/r/20201208195223.424753-1-conmanx...@gmail.com > Signed-off-by: Takashi Iwai Now replaced with those two patches. Thanks. Takashi

Re: [PATCH v2 3/3] ALSA: hda/ca0132 - Unmute surround when speaker output is selected.

2020-12-10 Thread Takashi Iwai
On Thu, 10 Dec 2020 18:16:00 +0100, Connor McAdams wrote: > > Woops, sent previous email on the first version of this patch. > > This patch is a mistake. Not sure why I did this. OK, then could you resubmit v3? Now I reverted the v2 patches. Takashi

Re: [PATCH v2 0/5] ALSA: hda/ca0132 - Fix no-audio issues and add documentation.

2020-12-10 Thread Takashi Iwai
On Thu, 10 Dec 2020 17:06:52 +0100, Connor McAdams wrote: > > This patch series attempts to fix the no audio at startup issues that > have been occurring for some users, using information gained through > reverse engineering the ca0132's onboard 8051 processor. > > The issue of no audio on startu

Re: [PATCH 3/5] ALSA: hda/ca0132 - Add 8051 exram helper functions.

2020-12-09 Thread Takashi Iwai
On Tue, 08 Dec 2020 22:25:43 +0100, Connor McAdams wrote: > > +static void chipio_8051_write_exram(struct hda_codec *codec, > + unsigned int addr, unsigned int data, bool use_mutex) > +{ > + struct ca0132_spec *spec = codec->spec; > + unsigned int tmp; > + > + if (use_mutex

Re: [PATCH] ALSA: hda/realtek - Enable headset mic of ASUS Q524UQK with ALC255

2020-12-09 Thread Takashi Iwai
On Wed, 09 Dec 2020 05:57:30 +0100, Chris Chiu wrote: > > The ASUS laptop Q524UQK with ALC255 codec can't detect the headset > microphone until ALC255_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. > > Signed-off-by: Chris Chiu > Signed-off-by: Jian-Hong Pan Applied now. Thanks. Takashi

[PATCH] driver: core: Fix list corruption after device_del()

2020-12-08 Thread Takashi Iwai
t() in order to make the list intact after the device_del() call. Fixes: e2ae9bcc4aaa ("driver core: Add support for linking devices during device addition") Cc: BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=209207 Signed-off-by: Takashi Iwai --- drivers/base/core.c | 2 +- 1

Re: [PATCH v2 1/3] ALSA: hda/ca0132 - Fix AE-5 rear headphone pincfg.

2020-12-08 Thread Takashi Iwai
On Tue, 08 Dec 2020 21:27:45 +0100, Takashi Iwai wrote: > > On Tue, 08 Dec 2020 20:52:20 +0100, > Connor McAdams wrote: > > > > The Windows driver sets the pincfg for the AE-5's rear-headphone to > > report as a microphone. This causes issues with Pulseaudio mist

Re: [PATCH v2 1/3] ALSA: hda/ca0132 - Fix AE-5 rear headphone pincfg.

2020-12-08 Thread Takashi Iwai
On Tue, 08 Dec 2020 20:52:20 +0100, Connor McAdams wrote: > > The Windows driver sets the pincfg for the AE-5's rear-headphone to > report as a microphone. This causes issues with Pulseaudio mistakenly > believing there is no headphone plugged in. In Linux, we should instead > set it to be a headp

Re: [PATCH] driver: core: Fix list corruption after device_del()

2020-12-08 Thread Takashi Iwai
On Tue, 08 Dec 2020 20:52:34 +0100, Greg Kroah-Hartman wrote: > > On Tue, Dec 08, 2020 at 08:03:26PM +0100, Takashi Iwai wrote: > > The device_links_purge() function (called from device_del()) tries to > > remove the links.needs_suppliers list entry, but it's using &

Re: [PATCH 1/3] ALSA: hda/ca0132 - Fix AE-5 rear headphone pincfg.

2020-12-07 Thread Takashi Iwai
On Mon, 07 Dec 2020 09:46:13 +0100, Connor McAdams wrote: > > The Windows driver sets the pincfg for the AE-5's rear-headphone to > report as a microphone. This causes issues with Pulseaudio mistakenly > believing there is no headphone plugged in. In Linux, we should instead > set it to be a headp

Re: [PATCH] ALSA: hda/realtek - Add support for Memeza EDL03 headset mic

2020-12-07 Thread Takashi Iwai
On Mon, 07 Dec 2020 08:33:46 +0100, Chris Chiu wrote: > > The Memeza laptop EDL03 with codec ALC256 can't detect the headset > microphone. The headphone jack sensing works after we add a pin > definition for it by ALC256_FIXUP_ASUS_MIC_NO_PRESENCE. > > Signed-off-by: Chris Chiu > Signed-off-by:

Re: [PATCH] ALSA: hda/realtek - Enable headset mic of ASUS X430UN with ALC256

2020-12-07 Thread Takashi Iwai
On Mon, 07 Dec 2020 08:27:55 +0100, Chris Chiu wrote: > > The ASUS laptop X430UN with ALC256 can't detect the headset microphone > until ALC256_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. > > Signed-off-by: Chris Chiu > Signed-off-by: Jian-Hong Pan Applied now. Thanks. Takashi

[GIT PULL] sound fixes for 5.10-rc7

2020-12-02 Thread Takashi Iwai
Luo Meng (1): ASoC: wm_adsp: fix error return code in wm_adsp_load() Shuming Fan (1): ASoC: rt5682: change SAR voltage threshold Srinivasa Rao Mandadapu (1): ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state Takashi Iwai (3): ALSA: hda/generic: Add optio

Re: [PATCH] ALSA: remove trailing semicolon in macro definition

2020-11-28 Thread Takashi Iwai
On Fri, 27 Nov 2020 20:23:12 +0100, t...@redhat.com wrote: > > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix Thanks, applied now. Takashi

Re: [PATCH] ALSA: hda/realtek: Enable headset of ASUS UX482EG & B9400CEA with ALC294

2020-11-24 Thread Takashi Iwai
On Tue, 24 Nov 2020 10:20:25 +0100, Jian-Hong Pan wrote: > > Some laptops like ASUS UX482EG & B9400CEA's headset audio does not work > until the quirk ALC294_FIXUP_ASUS_HPE is applied. > > Signed-off-by: Jian-Hong Pan Thanks, applied now. Takashi

Re: [PATCH V2] ALSA: emu10k1: Use dma_set_mask_and_coherent to simplify code

2020-11-21 Thread Takashi Iwai
On Sat, 21 Nov 2020 09:37:47 +0100, Christophe JAILLET wrote: > > 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by > an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. > > Signed-off-by: Christophe JAILLET > --- > v2: do not update the dev_err messag

Re: [PATCH] ALSA: aloop: Constify ops structs

2020-11-21 Thread Takashi Iwai
On Sat, 21 Nov 2020 00:10:46 +0100, Rikard Falkeborn wrote: > > The only usage of the ops field in the loopback_cable struct is to call > its members, the field it self is never changed. Make it a pointer to > const. This allows us to constify two static loopback_ops structs to > allow the compile

Re: [PATCH 067/141] ALSA: pcsp: Fix fall-through warnings for Clang

2020-11-21 Thread Takashi Iwai
On Fri, 20 Nov 2020 19:34:01 +0100, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Si

Re: [PATCH 066/141] ALSA: hdspm: Fix fall-through warnings for Clang

2020-11-21 Thread Takashi Iwai
On Fri, 20 Nov 2020 19:33:52 +0100, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Si

Re: [PATCH 068/141] ALSA: sb: Fix fall-through warnings for Clang

2020-11-21 Thread Takashi Iwai
On Fri, 20 Nov 2020 19:34:12 +0100, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Si

Re: [PATCH] ALSA: emu10k1: Use dma_set_mask_and_coherent to simplify code

2020-11-21 Thread Takashi Iwai
On Sat, 21 Nov 2020 09:16:32 +0100, Christophe JAILLET wrote: > > 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by > an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. It's a good cleanup, but ... > With at it replace the 'card->dev' parameter passed

[GIT PULL] sound fixes for 5.10-rc5

2020-11-20 Thread Takashi Iwai
emory leak Takashi Iwai (2): ALSA: hda/ca0132: Fix compile warning without PCI ALSA: mixart: Fix mutex deadlock Takashi Sakamoto (1): ALSA: ctl: fix error path at adding user-defined element set --- Documentation/devicetree/bindings/sound/rt1015.txt | 6 ++ include/sound/rt1

Re: [PATCH] ALSA: usb-audio : Add support for the Pioneer DJ DDJ-RR controller.

2020-11-19 Thread Takashi Iwai
On Tue, 10 Nov 2020 07:17:40 +0100, Daniel wrote: > > --- > sound/usb/quirks-table.h | 56 +++- > 1 file changed, 55 insertions(+), 1 deletion(-) > > diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h > index 3c1697f6b60c..a39233cb4d72 100644 > -

Re: [PATCH v3] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET

2020-11-17 Thread Takashi Iwai
On Wed, 18 Nov 2020 06:26:06 +0100, Macpaul Lin wrote: > > On Tue, 2020-11-10 at 17:04 +0800, Macpaul Lin wrote: > > The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports > > 96khz. However there will be some random issue under 96khz. > > Not sure if there is any alternate setting

Re: [PATCH] ALSA: usb-audio: Use ALC1220-VB-DT mapping for ASUS ROG Strix TRX40 mobo

2020-11-16 Thread Takashi Iwai
On Sun, 15 Nov 2020 16:38:42 +0100, Kai-Heng Feng wrote: > > ASUS ROG Strix also uses ALC1220-VB-DT, so adjust the mapping and add > profile name to let userspace pick correct UCM profile. > > BugLink: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/1031 > Signed-off-by: Kai-Heng Fe

Re: [PATCH] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET

2020-11-10 Thread Takashi Iwai
On Tue, 10 Nov 2020 09:17:46 +0100, Macpaul Lin wrote: > > On Tue, 2020-11-10 at 09:12 +0100, Takashi Iwai wrote: > > On Tue, 10 Nov 2020 09:04:03 +0100, > > Macpaul Lin wrote: > > > > > > The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it support

Re: [PATCH] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET

2020-11-10 Thread Takashi Iwai
On Tue, 10 Nov 2020 09:04:03 +0100, Macpaul Lin wrote: > > The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports > 96khz. However there will be some random issue under 96khz. > Not sure if there is any alternate setting could be applied. > Hence 48khz is suggested to be applied at

Re: [PATCH] ALSA: firewire: fix comparison to bool warning

2020-11-10 Thread Takashi Iwai
On Sat, 07 Nov 2020 17:13:31 +0100, xiakaixu1...@gmail.com wrote: > > From: Kaixu Xia > > Fix the following coccicheck warning: > > ./sound/firewire/amdtp-stream.h:273:6-19: WARNING: Comparison to bool > > Reported-by: Tosk Robot > Signed-off-by: Kaixu Xia Thanks, applied. Takashi > ---

[GIT PULL] sound fixes for 5.10-rc3

2020-11-06 Thread Takashi Iwai
Linus, please pull sound fixes for v5.10-rc3 from: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/sound-5.10-rc3 The topmost commit is a6c96672a64f4f0e1bac9f37b5bb57d8ab551b4b sound fixes for 5.10-rc3 Quit

Re: [PATCH] sound/core/seq: remove useless function

2020-11-04 Thread Takashi Iwai
On Tue, 03 Nov 2020 23:33:35 +0100, Yu Hao wrote: > > The function snd_seq_queue_client_termination() is only called from > the function seq_free_client1(). The function seq_free_client1() calls > the function snd_seq_queue_client_leave() and the function > snd_seq_queue_client_termination() toget

Re: [PATCH] sound/core/seq: remove dead code

2020-11-03 Thread Takashi Iwai
t; On Tue, Nov 3, 2020 at 5:09 AM Takashi Iwai wrote: > > On Mon, 02 Nov 2020 08:11:54 +0100, > Yu Hao wrote: > > > > The function snd_seq_queue_client_termination() is only called from > > function seq_free_client1(). The seq_free_client1() call

Re: [PATCH] sound/core/seq: remove dead code

2020-11-03 Thread Takashi Iwai
On Mon, 02 Nov 2020 08:11:54 +0100, Yu Hao wrote: > > The function snd_seq_queue_client_termination() is only called from > function seq_free_client1(). The seq_free_client1() calls function > snd_seq_queue_client_leave(), which deletes all objects whose owner > equals to client->number in global

Re: [PATCH v3] soundwire: SDCA: add helper macro to access controls

2020-10-30 Thread Takashi Iwai
On Fri, 30 Oct 2020 16:52:24 +0100, Pierre-Louis Bossart wrote: > > > > +#define SDW_SDCA_CTL(fun, ent, ctl, ch) (BIT(30) | > >>> \ > + (((fun) & 0x7) << 22) > |\ > +

[PATCH] KVM: x86: Fix NULL dereference at kvm_msr_ignored_check()

2020-10-30 Thread Takashi Iwai
in the function, but I didn't touch it to make the fix as small as possible. A clean up may be applied later.) Fixes: 12bc2132b15e ("KVM: X86: Do the same ignore_msrs check for feature msrs") BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1178280 Cc: Signed-off-b

Re: [PATCH v3] soundwire: SDCA: add helper macro to access controls

2020-10-30 Thread Takashi Iwai
On Fri, 30 Oct 2020 12:24:35 +0100, Liao, Bard wrote: > > > > > -Original Message- > > From: Greg KH > > Sent: Friday, October 30, 2020 5:37 PM > > To: Bard Liao > > Cc: alsa-de...@alsa-project.org; vk...@kernel.org; vinod.k...@linaro.org; > > linux-kernel@vger.kernel.org; j...@cadence

Re: [PATCH 5.9 733/757] ALSA: hda/ca0132 - Add new quirk ID for SoundBlaster AE-7.

2020-10-30 Thread Takashi Iwai
: https://lore.kernel.org/r/20200825201040.30339-11-conmanx...@gmail.com > Signed-off-by: Takashi Iwai > Signed-off-by: Sasha Levin Sorry to be delayed for reviewing. This patch and the commit ed93f9750c6c lookl wrong to be picked up for stable. AE-7 won't work without the full backport, an

Re: [PATCH 01/25] ALSA: core: pcm: remove unnecessary CONFIG_PM_SLEEP

2020-10-29 Thread Takashi Iwai
On Thu, 29 Oct 2020 08:42:37 +0100, Coiby Xu wrote: > > SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG. > > Signed-off-by: Coiby Xu It caused compile warnings. Was it already addressed in general? Or we may use __maybe_unused attribute instead, but it's just a matter o

Re: [PATCH v3 0/3] HDA controller PM and codec PM cleanups

2020-10-28 Thread Takashi Iwai
On Tue, 27 Oct 2020 14:00:35 +0100, Kai-Heng Feng wrote: > > While working on the issue "ALSA: hda: fix jack detection with Realtek > codecs when in D3", I've found using pm_runtime_force_{suspend,resume}() > have surprising behavior, specifically, pm_runtime_need_not_resume() > uses pm_runtime_ne

Re: [PATCH 2/8] ALSA: pcm: use krealloc_array()

2020-10-27 Thread Takashi Iwai
On Tue, 27 Oct 2020 13:17:19 +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > Use the helper that checks for overflows internally instead of manually > calculating the size of the new array. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: T

Re: [PATCH] drm/vc4: hdmi: Avoid sleeping in atomic context

2020-10-27 Thread Takashi Iwai
sense. > > Fixes: bb7d78568814 ("drm/vc4: Add HDMI audio support") > Suggested-by: Mark Brown > Signed-off-by: Maxime Ripard Reviewed-by: Takashi Iwai thanks, Takashi > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 del

Re: [PATCH v2 3/4] ALSA: hda: Separate runtime and system suspend

2020-10-27 Thread Takashi Iwai
On Tue, 27 Oct 2020 09:12:07 +0100, Takashi Iwai wrote: > > On Tue, 27 Oct 2020 08:46:05 +0100, > Takashi Iwai wrote: > > > @@ -1103,10 +1115,8 @@ static int azx_runtime_suspend(struct device *dev) > > > chip = card->private_data; > > > > > >

Re: [PATCH v2 3/4] ALSA: hda: Separate runtime and system suspend

2020-10-27 Thread Takashi Iwai
On Tue, 27 Oct 2020 08:46:05 +0100, Takashi Iwai wrote: > > @@ -1103,10 +1115,8 @@ static int azx_runtime_suspend(struct device *dev) > > chip = card->private_data; > > > > /* enable controller wake up event */ > > - if (snd_power_get_

Re: [PATCH v2 3/4] ALSA: hda: Separate runtime and system suspend

2020-10-27 Thread Takashi Iwai
On Tue, 27 Oct 2020 06:40:00 +0100, Kai-Heng Feng wrote: > @@ -1002,7 +1001,8 @@ static void __azx_runtime_resume(struct azx *chip, bool > from_rt) > azx_init_pci(chip); > hda_intel_init_chip(chip, true); > > - if (from_rt) { > + /* Avoid codec resume if runtime resume is for

Re: [PATCH v2 2/4] ALSA: hda: Stop mangling PCI IRQ

2020-10-27 Thread Takashi Iwai
On Tue, 27 Oct 2020 06:39:59 +0100, Kai-Heng Feng wrote: > > The code predates 2005, it should be unnecessary now as PCI core handles > IRQ much better nowadays. > > So stop PCI IRQ mangling in suspend/resume callbacks. > > Takashi Iwai mentioned that IRQ number can ch

Re: [PATCH] ALSA: make snd_kcontrol_new name a normal string

2020-10-26 Thread Takashi Iwai
On Mon, 26 Oct 2020 20:03:39 +0100, Arnd Bergmann wrote: > > On Mon, Oct 26, 2020 at 6:03 PM Takashi Iwai wrote: > > On Mon, 26 Oct 2020 17:52:18 +0100, > > Arnd Bergmann wrote: > > > > > > From: Arnd Bergmann > > > > > > When b

Re: [PATCH] ALSA: make snd_kcontrol_new name a normal string

2020-10-26 Thread Takashi Iwai
On Mon, 26 Oct 2020 17:52:18 +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > When building with W=2, there are lots of warnings about the > snd_kcontrol_new name field being an array of 'unsigned char' > but initialized to a string: > > include/sound/soc.h:93:48: warning: pointer target

Re: Patch "ASoC: topology: disable size checks for bytes_ext controls if needed" has been added to the 4.9-stable tree

2020-10-26 Thread Takashi Iwai
On Mon, 26 Oct 2020 16:01:09 +0100, Pierre-Louis Bossart wrote: > > > > On 10/26/20 7:11 AM, Greg KH wrote: > > On Mon, Oct 26, 2020 at 01:53:46AM -0400, Sasha Levin wrote: > >> This is a note to let you know that I've just added the patch titled > >> > >> ASoC: topology: disable size check

Re: [PATCH v3 48/56] sound: fix kernel-doc markups

2020-10-26 Thread Takashi Iwai
On Mon, 26 Oct 2020 15:14:23 +0100, Mauro Carvalho Chehab wrote: > > Em Mon, 26 Oct 2020 14:46:03 +0100 > Takashi Iwai escreveu: > > > On Fri, 23 Oct 2020 18:33:35 +0200, > > Mauro Carvalho Chehab wrote: > > > > > > Kernel-doc markups should

Re: [PATCH] sound: remove unneeded break

2020-10-26 Thread Takashi Iwai
On Mon, 19 Oct 2020 18:48:57 +0200, t...@redhat.com wrote: > > From: Tom Rix > > A break is not needed if it is preceded by a return, goto > or break > > Signed-off-by: Tom Rix Applied now. Thanks. Takashi

Re: [PATCH v3 48/56] sound: fix kernel-doc markups

2020-10-26 Thread Takashi Iwai
n their prototypes > and the kernel-doc markup. > > Signed-off-by: Mauro Carvalho Chehab Shall I merge this through sound git tree? Or if this goes via doc tree, feel free to take my ack Reviewed-by: Takashi Iwai thanks, Takashi

Re: [PATCH 1/4] ALSA: hda: Refactor codec PM to use direct-complete optimization

2020-10-23 Thread Takashi Iwai
On Fri, 23 Oct 2020 14:44:18 +0200, Kai-Heng Feng wrote: > > > > > On Oct 23, 2020, at 19:32, Takashi Iwai wrote: > > > > On Fri, 23 Oct 2020 12:23:35 +0200, > > Kai-Heng Feng wrote: > >> > >> +static void hda_codec_pm_complete(struct

Re: [PATCH 2/4] ALSA: hda: Stop mangling PCI MSI

2020-10-23 Thread Takashi Iwai
On Fri, 23 Oct 2020 14:53:08 +0200, Kai-Heng Feng wrote: > > > > > On Oct 23, 2020, at 19:34, Takashi Iwai wrote: > > > > On Fri, 23 Oct 2020 12:23:36 +0200, > > Kai-Heng Feng wrote: > >> > >> @@ -1038,14 +

Re: [PATCH 3/4] ALSA: hda: Refactor controller PM to use direct-complete optimization

2020-10-23 Thread Takashi Iwai
On Fri, 23 Oct 2020 12:23:37 +0200, Kai-Heng Feng wrote: > @@ -1103,10 +1096,8 @@ static int azx_runtime_suspend(struct device *dev) > chip = card->private_data; > > /* enable controller wake up event */ > - if (snd_power_get_state(card) == SNDRV_CTL_POWER_D0) { > - az

Re: [PATCH 2/4] ALSA: hda: Stop mangling PCI MSI

2020-10-23 Thread Takashi Iwai
On Fri, 23 Oct 2020 12:23:36 +0200, Kai-Heng Feng wrote: > > @@ -1038,14 +1036,6 @@ static int azx_suspend(struct device *dev) > __azx_runtime_suspend(chip); > else > pm_runtime_force_suspend(dev); > - if (bus->irq >= 0) { > - free_irq(bus->irq, ch

Re: [PATCH 1/4] ALSA: hda: Refactor codec PM to use direct-complete optimization

2020-10-23 Thread Takashi Iwai
On Fri, 23 Oct 2020 12:23:35 +0200, Kai-Heng Feng wrote: > > +static void hda_codec_pm_complete(struct device *dev) > { > struct hda_codec *codec = dev_to_hda_codec(dev); > - int ret; > > - ret = pm_runtime_force_resume(dev); > - /* schedule jackpoll work for jack detection up

[GIT PULL] sound fixes for 5.10-rc1

2020-10-23 Thread Takashi Iwai
Linus, please pull sound fixes for v5.10-rc1 from: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/sound-fix-5.10-rc1 The topmost commit is 033e4040d453f1f7111e5957a54f3019eb089cc6 sound fixes for 5.10-rc1

[PATCH 0/3] drm/amd/display: Fix kernel panic by breakpoint

2020-10-23 Thread Takashi Iwai
Hi, the amdgpu driver's ASSERT_CRITICAL() macro calls the kgdb_breakpoing() even if no debug option is set, and this leads to a kernel panic on distro kernels. The first two patches are the oneliner fixes for those, while the last one is the cleanup of those debug macros. Takashi === Ta

[PATCH 3/3] drm/amd/display: Clean up debug macros

2020-10-23 Thread Takashi Iwai
. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/amd/display/Kconfig | 1 + drivers/gpu/drm/amd/display/dc/os_types.h | 33 +++ 2 files changed, 13 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/display/Kconfig b/drivers/gpu/drm/amd/display

<    1   2   3   4   5   6   7   8   9   10   >