[PATCH 4/5] firmware: Factor out the paged buffer handling code

2019-05-20 Thread Takashi Iwai
This is merely a preparation for the upcoming compressed firmware support and no functional changes. It moves the code to handle the paged buffer allocation and mapping out of fallback.c into the main code, so that they can be used commonly. Signed-off-by: Takashi Iwai --- drivers/base

[PATCH 2/5] firmware: Unify the paged buffer release helper

2019-05-20 Thread Takashi Iwai
Use a common helper to release the paged buffer resources. This is rather a preparation for the upcoming decompression support. Signed-off-by: Takashi Iwai --- drivers/base/firmware_loader/fallback.c | 8 +--- drivers/base/firmware_loader/firmware.h | 6 ++ drivers/base

[PATCH 1/5] firmware: Free temporary page table after vmapping

2019-05-20 Thread Takashi Iwai
Once after performing vmap() to map the S/G pages, our own page table becomes superfluous since the pages can be released via vfree() automatically. Let's change the buffer release code and discard the page table array for saving some memory. Signed-off-by: Takashi Iwai --- drivers

Re: [PATCH] sound: open brace should be on the previous line

2019-05-17 Thread Takashi Iwai
On Fri, 17 May 2019 08:33:28 +0200, wrote: > > From: Naveen Kumar Parna > > Resolved open brace { should be on the previous line checkpatch.pl > error. While addressing this error, also corrected the affected code > for below mentioned checkpatch errors. > > ERROR: spaces required around that

[GIT PULL] sound fixes for 5.2-rc1

2019-05-17 Thread Takashi Iwai
System76 Gazelle (gaze14) Kailang Yang (1): ALSA: hda/realtek - Fixup headphone noise via runtime suspend Michał Wadowski (1): ALSA: hda/realtek - Fix for Lenovo B50-70 inverted internal microphone bug Takashi Iwai (1): ALSA: hda/realtek - Avoid superfluous COEF EAPD setups

Re: [Patch] hdac_sysfs: Fix a memory leaking bug in sound/hda/hdac_sysfs.c file of Linux 5.1

2019-05-16 Thread Takashi Iwai
On Thu, 16 May 2019 10:40:03 +0200, Gen Zhang wrote: > > tree->root and tree->nodes are allocated by memory allocation > functions. And tree is also an allocated memory. When allocation of > tree->root and tree->nodes fails, not freeing tree will leak memory. > Thus we should free tree in this

Re: [PATCH v1 2/2] sound: Enable micmute led for Huawei laptops

2019-05-15 Thread Takashi Iwai
On Mon, 13 May 2019 22:30:06 +0200, Ayman Bagabas wrote: > > Since this LED is found on huawei laptops, we can hook it to > huawei-wmi platform driver which uses the common WMI interface present > in these laptops to control the LED. > > I've also made some renames and used product name instead o

Re: [PATCH v1 1/2] platform/x86: Huawei WMI laptop extras driver update

2019-05-15 Thread Takashi Iwai
On Mon, 13 May 2019 22:30:05 +0200, Ayman Bagabas wrote: > > This update brings on the use of WMI BIOS management interface found on > Huawei laptops. This interface can control the micmute LED found on most > of these laptops, control charging thresholds values, and control > fn-lock feature. >

Re: [PATCH v2] ALSA: hda: Fix race between creating and refreshing sysfs entries

2019-05-13 Thread Takashi Iwai
On Mon, 13 May 2019 11:18:01 +0200, Amadeusz Sławiński wrote: > > hda_widget_sysfs_reinit() can free underlying codec->widgets structure > on which widget_tree_create() operates. Add locking to prevent such > issues from happening. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110382

Re: [alsa-devel] [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Takashi Iwai
On Fri, 10 May 2019 19:56:51 +0200, Pierre-Louis Bossart wrote: > > > Yes, that would work. OTOH, I see no merit to build an extra module > for nocodec. nocodec.c can be built together with sof-core stuff. > >> > >> the module has its benefits. Today nocodec includes all possible DAIs

Re: [alsa-devel] [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Takashi Iwai
On Fri, 10 May 2019 17:29:58 +0200, Pierre-Louis Bossart wrote: > > > > On 5/10/19 8:56 AM, Takashi Iwai wrote: > > On Fri, 10 May 2019 15:41:10 +0200, > > Takashi Iwai wrote: > >> > >> On Fri, 10 May 2019 15:34:03 +0200, > >> Pierre-Louis Bos

Re: [alsa-devel] [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Takashi Iwai
On Fri, 10 May 2019 15:41:10 +0200, Takashi Iwai wrote: > > On Fri, 10 May 2019 15:34:03 +0200, > Pierre-Louis Bossart wrote: > > > > On 5/10/19 8:04 AM, Takashi Iwai wrote: > > > On Fri, 10 May 2019 14:56:29 +0200, > > > Pierre-Louis Bossart wrote: > &g

Re: [alsa-devel] [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Takashi Iwai
On Fri, 10 May 2019 15:34:03 +0200, Pierre-Louis Bossart wrote: > > On 5/10/19 8:04 AM, Takashi Iwai wrote: > > On Fri, 10 May 2019 14:56:29 +0200, > > Pierre-Louis Bossart wrote: > >> > >> On 5/10/19 2:12 AM, Takashi Iwai wrote: > >>> On Fri, 10

Re: [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Takashi Iwai
On Fri, 10 May 2019 14:56:29 +0200, Pierre-Louis Bossart wrote: > > On 5/10/19 2:12 AM, Takashi Iwai wrote: > > On Fri, 10 May 2019 04:36:57 +0200, > > YueHaibing wrote: > >> > >> Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m > &g

Re: [PATCH] ALSA: hda: Fix race between creating and refreshing sysfs entries

2019-05-10 Thread Takashi Iwai
On Fri, 10 May 2019 14:21:41 +0200, Amadeusz Sławiński wrote: > > hda_widget_sysfs_reinit() can free underlying codec->widgets structure > on which widget_tree_create() operates. Add locking to prevent such > issues from happening. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110382

Re: [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Takashi Iwai
On Fri, 10 May 2019 04:36:57 +0200, YueHaibing wrote: > > Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m > > sound/soc/sof/core.o: In function `snd_sof_device_probe': > core.c:(.text+0x4af): undefined reference to `sof_nocodec_setup' > > Change SND_SOC_SOF_NOCODEC to bool to fix this. >

[GIT PULL] sound updates for 5.2-rc1

2019-05-09 Thread Takashi Iwai
samsung: speyside: Convert to SPDX License Identifier ASoC: samsung: tm2_wm5110: Convert to SPDX License Identifier ASoC: samsung: tobermory: Convert to SPDX License Identifier Takashi Iwai (32): ALSA: emux: Add support of loading GUS-patch ALSA: timer: Unify timer callback pro

Re: [PATCH] ASoC: Intel: bytcr_rt5651.c: remove string buffers 'byt_rt5651_cpu_dai_name' and 'byt_rt5651_cpu_dai_name'

2019-05-05 Thread Takashi Iwai
On Sat, 04 May 2019 17:16:52 +0200, Nariman wrote: > > From: Jordy Ubink > > The snprintf calls filling byt_rt5651_cpu_dai_name / byt_rt5651_cpu_dai_name > always fill them with the same string (ssp0-port" resp "rt5651-aif2"). So > instead of keeping these buffers around and making the cpu_dai

Re: [PATCH] MAINTAINERS: update git tree for sound entries

2019-05-03 Thread Takashi Iwai
On Fri, 03 May 2019 16:06:40 +0200, Ross Zwisler wrote: > > On Fri, May 3, 2019 at 2:17 AM Takashi Iwai wrote: > > > > On Thu, 02 May 2019 19:27:00 +0200, > > Ross Zwisler wrote: > > > > > > Several sound related entries in MAINTAINERS refer to

Re: [PATCH] MAINTAINERS: update git tree for sound entries

2019-05-03 Thread Takashi Iwai
On Thu, 02 May 2019 19:27:00 +0200, Ross Zwisler wrote: > > Several sound related entries in MAINTAINERS refer to the old git tree > at "git://git.alsa-project.org/alsa-kernel.git". This is no longer used > for development, and Takashi Iwai's kernel.org tree is used instead. > > Signed-off-by: R

[GIT PULL] sound fixes for 5.1

2019-05-02 Thread Takashi Iwai
): ALSA: line6: use dynamic buffers Kailang Yang (2): ALSA: hda/realtek - Add new Dell platform for headset mode ALSA: hda/realtek - Fixed Dell AIO speaker noise Takashi Iwai (1): ALSA: hda/realtek - Apply the fixup for ASUS Q325UAR --- sound/pci/hda/patch_realtek.c | 13

Re: [PATCH] ALSA: hda: check RIRB to avoid use NULL pointer

2019-04-30 Thread Takashi Iwai
On Tue, 30 Apr 2019 11:29:19 +0200, Liwei Song wrote: > > > > On 04/30/2019 04:53 PM, Takashi Iwai wrote: > > On Tue, 30 Apr 2019 10:32:47 +0200, > > Liwei Song wrote: > >> > >> > >> > >> On 04/30/2019 03:31 PM, Takashi Iwai wrote

Re: [PATCH] ALSA: hda: check RIRB to avoid use NULL pointer

2019-04-30 Thread Takashi Iwai
On Tue, 30 Apr 2019 10:32:47 +0200, Liwei Song wrote: > > > > On 04/30/2019 03:31 PM, Takashi Iwai wrote: > > On Tue, 30 Apr 2019 08:10:53 +0200, > > Song liwei wrote: > >> > >> From: Liwei Song > >> > >> Fix the following BUG: > &

Re: [PATCH] ALSA: hda: check RIRB to avoid use NULL pointer

2019-04-30 Thread Takashi Iwai
On Tue, 30 Apr 2019 08:10:53 +0200, Song liwei wrote: > > From: Liwei Song > > Fix the following BUG: > > BUG: unable to handle kernel NULL pointer dereference at 000c > Workqueue: events azx_probe_work [snd_hda_intel] > RIP: 0010:snd_hdac_bus_update_rirb+0x80/0x160 [snd_hda_core] >

Re: [REGRESSION 5.0.8] Dell thunderbolt dock broken (xhci_hcd and thunderbolt)

2019-04-29 Thread Takashi Iwai
On Mon, 29 Apr 2019 22:36:30 +0200, Mika Westerberg wrote: > > On Mon, Apr 29, 2019 at 11:13:47PM +0300, Mika Westerberg wrote: > > On Mon, Apr 29, 2019 at 10:03:00PM +0200, Michael Hirmke wrote: > > > Hi all, > > > > > > >On Mon, Apr 29, 2019 at 09:47:1

[REGRESSION 5.0.8] Dell thunderbolt dock broken (xhci_hcd and thunderbolt)

2019-04-29 Thread Takashi Iwai
Hi, we've got a regression report wrt xhci_hcd and thunderbolt on a Dell machine. 5.0.7 is confirmed to work, so it must be a regression introduced by 5.0.8. The details are found in openSUSE Bugzilla entry: https://bugzilla.opensuse.org/show_bug.cgi?id=1132943 The probe of xhci_hcd on the do

Re: [PATCH v2] ALSA: usx2y: fix a double free bug

2019-04-29 Thread Takashi Iwai
On Mon, 29 Apr 2019 19:45:40 +0200, Wenwen Wang wrote: > > In usX2Y_In04_init(), a new urb is firstly created through usb_alloc_urb() > and saved to 'usX2Y->In04urb'. Then, a buffer is allocated through > kmalloc() and saved to 'usX2Y->In04Buf'. If the allocation of the buffer > fails, the error c

Re: [PATCH] ALSA: usx2y: fix a memory leak bug

2019-04-28 Thread Takashi Iwai
On Mon, 29 Apr 2019 07:50:11 +0200, Wenwen Wang wrote: > > On Mon, Apr 29, 2019 at 12:36 AM Takashi Iwai wrote: > > > > On Sun, 28 Apr 2019 09:18:40 +0200, > > Takashi Iwai wrote: > > > > > > On Sun, 28 Apr 2019 08:42:32 +0200, > > > Wenwen Wang

Re: [PATCH] ALSA: usx2y: fix a memory leak bug

2019-04-28 Thread Takashi Iwai
On Sun, 28 Apr 2019 09:18:40 +0200, Takashi Iwai wrote: > > On Sun, 28 Apr 2019 08:42:32 +0200, > Wenwen Wang wrote: > > > > In usX2Y_In04_init(), a new urb is firstly created through usb_alloc_urb() > > and saved to 'usX2Y->In04urb'. Then, a buffer is a

Re: [PATCH] ALSA: usx2y: fix a memory leak bug

2019-04-28 Thread Takashi Iwai
On Sun, 28 Apr 2019 08:42:32 +0200, Wenwen Wang wrote: > > In usX2Y_In04_init(), a new urb is firstly created through usb_alloc_urb() > and saved to 'usX2Y->In04urb'. Then, a buffer is allocated through > kmalloc() and saved to 'usX2Y->In04Buf'. After the urb is initialized, a > sanity check is pe

Re: [PATCH] ALSA: usb-audio: Fix a memory leak bug

2019-04-28 Thread Takashi Iwai
On Sat, 27 Apr 2019 08:06:46 +0200, Wenwen Wang wrote: > > In parse_audio_selector_unit(), the string array 'namelist' is allocated > through kmalloc_array(), and each string pointer in this array, i.e., > 'namelist[]', is allocated through kmalloc() in the following for loop. > Then, a control in

Re: [PATCH v3] sound: isa: gus: fix misuse of %x

2019-04-27 Thread Takashi Iwai
On Fri, 26 Apr 2019 05:16:24 +0200, Fuqian Huang wrote: > > Pointers should be printed with %p or %px rather than > cast to long type and printed with %lx. > Drop the address printing. > > Signed-off-by: Fuqian Huang Applied now. Thanks. Takashi

Re: [REGRESSION 5.0.x] Windows XP broken on KVM

2019-04-23 Thread Takashi Iwai
On Thu, 18 Apr 2019 10:05:34 +0200, Takashi Iwai wrote: > > On Thu, 18 Apr 2019 09:53:28 +0200, > Greg Kroah-Hartman wrote: > > > > On Thu, Apr 18, 2019 at 09:38:52AM +0200, Takashi Iwai wrote: > > > Hi, > > > > > > we've got a regression r

Re: [PATCH v2 06/06] sound: isa: gus: fix misuse of %x

2019-04-23 Thread Takashi Iwai
On Sun, 21 Apr 2019 13:48:44 +0200, Fuqian Huang wrote: > > Pointers should be printed with %p or %px rather than > cast to long type and printed with %lx. > Change %lx to %p to print the pointer. > > Signed-off-by: Fuqian Huang IMO, it's better to drop the address printing itself. We don't wan

[GIT PULL] sound fixes for 5.1-rc6

2019-04-20 Thread Takashi Iwai
- add two more pin configuration sets to quirk table Takashi Iwai (3): ALSA: hda: Initialize power_state field properly ALSA: info: Fix racy addition/deletion of nodes ALSA: core: Fix card races between register and disconnect --- sound/core/info.c | 12

Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace

2019-04-18 Thread Takashi Iwai
On Thu, 18 Apr 2019 14:21:35 +0200, Pavel Machek wrote: > > On Thu 2019-04-18 07:17:54, Takashi Iwai wrote: > > On Wed, 17 Apr 2019 22:54:14 +0200, > > Jacek Anaszewski wrote: > > > > > > led_colors clashes with the array of the same name being added >

Re: [REGRESSION 5.0.x] Windows XP broken on KVM

2019-04-18 Thread Takashi Iwai
On Thu, 18 Apr 2019 09:53:28 +0200, Greg Kroah-Hartman wrote: > > On Thu, Apr 18, 2019 at 09:38:52AM +0200, Takashi Iwai wrote: > > Hi, > > > > we've got a regression report on the recent 5.0.x kernel, starting > > from 5.0.6, where Windows XP can't boot

[REGRESSION 5.0.x] Windows XP broken on KVM

2019-04-18 Thread Takashi Iwai
Hi, we've got a regression report on the recent 5.0.x kernel, starting from 5.0.6, where Windows XP can't boot on KVM any longer. The culprit seems to be the patch KVM: x86: update %rip after emulating IO with the upstream commit 45def77ebf79e2e8942b89ed79294d97ce914fa0. Reverting this alone f

Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace

2019-04-17 Thread Takashi Iwai
olors > led_init_vals -> toneport_led_init_vals > > Fixes: f44edd7b2bbed ("ALSA: line6/toneport: Implement LED controls via LED > class") > Signed-off-by: Jacek Anaszewski > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Arnd Bergmann Looks good. Feel free to ta

Re: [ALSA] feb689025f: WARNING:possible_recursive_locking_detected

2019-04-17 Thread Takashi Iwai
On Thu, 18 Apr 2019 02:22:57 +0200, kernel test robot wrote: > > > FYI, we noticed the following commit (built with gcc-5): > > commit: feb689025fbb6f0aa6297d3ddf97de945ea4ad32 ("ALSA: seq: Protect > in-kernel ioctl calls with mutex") > https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.g

Re: [ALSA patch] [PATCH] ALSA: pcm: Enable MMAP status and control for ARMv7 and ARMv8

2019-04-17 Thread Takashi Iwai
On Wed, 17 Apr 2019 11:30:10 +0200, Timo Wischer wrote: > > On 4/17/19 11:21, Takashi Iwai wrote: > > On Wed, 17 Apr 2019 10:46:11 +0200, > > wrote: > >> From: Timo Wischer > >> > >> Since ARMv7 hardware cache coherence is supported. > >> &q

Re: [ALSA patch] [PATCH] ALSA: pcm: Enable MMAP status and control for ARMv7 and ARMv8

2019-04-17 Thread Takashi Iwai
On Wed, 17 Apr 2019 10:46:11 +0200, wrote: > > From: Timo Wischer > > Since ARMv7 hardware cache coherence is supported. > "The SCU maintains coherency between the individual data caches in the > Cortex-A5 MPCore processor using a variation of the MOESI protocol" [1]. > > Therefore this patch

Re: [PATCH] ALSA: isa/wavefront: Fix potential Spectre v1 vulnerabilities

2019-04-15 Thread Takashi Iwai
On Mon, 15 Apr 2019 21:35:17 +0200, Gustavo A. R. Silva wrote: > > Hi all, > > Friendly ping: > > Who can take this? All platforms that support ISA boards are so old and they don't suffer from Spectre at all. thanks, Takashi > > Thanks > -- > Gustavo > > On 3/26/19 1:32 PM, Gustavo A.

Re: [alsa-devel] [PATCH 1/2] regmap: soundwire: fix Kconfig select/depend issue

2019-04-12 Thread Takashi Iwai
On Fri, 12 Apr 2019 16:18:41 +0200, Mark Brown wrote: > > On Fri, Apr 12, 2019 at 09:07:41AM -0500, Pierre-Louis Bossart wrote: > > > config CODEC_XYX_SDW > > tristate "XYZ SDW Codec" > > depends on SOUNDWIRE > > select REGMAP_SOUNDWIRE > > That looks good. > > > config

Re: [PATCH 1/2] regmap: soundwire: fix Kconfig select/depend issue

2019-04-12 Thread Takashi Iwai
On Thu, 11 Apr 2019 21:28:13 +0200, Pierre-Louis Bossart wrote: > > The mechanism should be > > config CODEC_XYX_SDW >depends on SOUNDWIRE >select REGMAP_SOUNDWIRE > > config REGMAP_SOUNDWIRE >depends on SOUNDWIRE >select SOUNDWIRE_BUS To be noted, in general you

[GIT PULL] sound fixes for 5.1-rc5

2019-04-12 Thread Takashi Iwai
): ASoC: samsung: i2s: Fix DAPM routes for capture stream ASoC: samsung: odroid: Fix clock configuration for 44100 sample rate Takashi Iwai (1): ALSA: hda: Fix racy display power access Tzung-Bi Shih (2): ASoC: mediatek: mt8183: skip for i2s5 in mck_disable ASoC: Inte

Re: [PATCH v3 1/5] soundwire: intel: fix inversion in devm_kcalloc parameters

2019-04-11 Thread Takashi Iwai
On Thu, 11 Apr 2019 05:16:57 +0200, Pierre-Louis Bossart wrote: > > the number of elements and size are inverted, fix. > > This probably only worked because the number of properties is > hard-coded to 1. Well, both are mathematically equivalent :) Takashi > > Fixes: 71bb8a1b059e ('soundwire:

Re: [PATCH v3 0/5] soundwire: code cleanup

2019-04-11 Thread Takashi Iwai
ebug logs All looked fine, for the series: Reviewed-by: Takashi Iwai thanks, Takashi

Re: [PATCH 09/10] ALSA: pcm: Add snd_pcm_ops for snd_pcm_link()

2019-04-05 Thread Takashi Iwai
On Thu, 04 Apr 2019 12:18:33 +0200, Timo Wischer wrote: > > >>> In principle, the PCM ops is supposed to be safe for operating a > >>> certain stuff. If a state change may happen during the operation, > >>> this should be called inside PCM stream lock. So the design of the > >>> new callback its

Re: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer TravelMate B114-21 with ALC233

2019-04-02 Thread Takashi Iwai
On Tue, 02 Apr 2019 08:45:32 +0200, Kailang wrote: > > > Reviewed-by: Kailang Yang Thanks, applied the patch now. Takashi > > -Original Message- > From: Takashi Iwai > Sent: Tuesday, April 2, 2019 2:43 PM > To: Kailang > Cc: Jian-Hong Pan ; alsa-de...@

Re: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer TravelMate B114-21 with ALC233

2019-04-01 Thread Takashi Iwai
On Tue, 02 Apr 2019 08:38:32 +0200, Kailang wrote: > > Hi Takashi, > > This COEF value was modified by me. OK, then could you give your Acked-by or Reviewed-by tag? thanks, Takashi > > BR, > Kailang > > -Original Message- > From: Takashi Iwai >

Re: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer TravelMate B114-21 with ALC233

2019-04-01 Thread Takashi Iwai
On Mon, 01 Apr 2019 05:25:05 +0200, Jian-Hong Pan wrote: > > The Acer TravelMate B114-21 laptop cannot detect and record sound from > headset MIC. This patch adds the ALC233_FIXUP_ACER_HEADSET_MIC HDA verb > quirk chained with ALC233_FIXUP_ASUS_MIC_NO_PRESENCE pin quirk to fix > this issue. > >

[GIT PULL] sound fixes for 5.1-rc2

2019-03-29 Thread Takashi Iwai
re v1 vulnerability Jian-Hong Pan (3): ALSA: hda/realtek: Enable headset MIC of Acer Aspire Z24-890 with ALC286 ALSA: hda/realtek: Enable ASUS X441MB and X705FD headset MIC with ALC256 ALSA: hda/realtek: Enable headset MIC of ASUS X430UN and X512DK with ALC256 Takashi Iwai (3):

Re: [PATCH 09/10] ALSA: pcm: Add snd_pcm_ops for snd_pcm_link()

2019-03-27 Thread Takashi Iwai
On Wed, 27 Mar 2019 10:26:56 +0100, Timo Wischer wrote: > > On 3/27/19 10:11, Takashi Iwai wrote: > > On Wed, 27 Mar 2019 09:34:40 +0100, > > Timo Wischer wrote: > >> On 3/26/19 17:00, Takashi Iwai wrote: > >>> On Tue, 26 Mar 2019 16:16:54 +0100, > >&

Re: [PATCH 09/10] ALSA: pcm: Add snd_pcm_ops for snd_pcm_link()

2019-03-27 Thread Takashi Iwai
On Wed, 27 Mar 2019 09:34:40 +0100, Timo Wischer wrote: > > On 3/26/19 17:00, Takashi Iwai wrote: > > On Tue, 26 Mar 2019 16:16:54 +0100, > > Timo Wischer wrote: > >> On 3/26/19 15:23, Takashi Iwai wrote: > >>> On Tue, 26 Mar 2019 12:25:37 +0100, > >&

Re: [PATCH] efi: Downgrade "EFI_MEMMAP is not enabled" message

2019-03-26 Thread Takashi Iwai
On Tue, 26 Mar 2019 17:04:30 +0100, Ard Biesheuvel wrote: > > On Tue, 26 Mar 2019 at 16:25, Takashi Iwai wrote: > > > > On Fri, 01 Mar 2019 16:27:24 +0100, > > Takashi Iwai wrote: > > > > > > On Fri, 01 Mar 2019 15:57:03 +0100, > > > Ard Biesheu

Re: [PATCH 09/10] ALSA: pcm: Add snd_pcm_ops for snd_pcm_link()

2019-03-26 Thread Takashi Iwai
On Tue, 26 Mar 2019 16:16:54 +0100, Timo Wischer wrote: > > On 3/26/19 15:23, Takashi Iwai wrote: > > On Tue, 26 Mar 2019 12:25:37 +0100, > > Timo Wischer wrote: > >> On 3/26/19 09:35, Takashi Iwai wrote: > >> > >> On Tue, 26 Mar 2019 08:49:33 +01

Re: [PATCH 09/10] ALSA: pcm: Add snd_pcm_ops for snd_pcm_link()

2019-03-26 Thread Takashi Iwai
On Tue, 26 Mar 2019 12:25:37 +0100, Timo Wischer wrote: > > On 3/26/19 09:35, Takashi Iwai wrote: > > On Tue, 26 Mar 2019 08:49:33 +0100, > wrote: > > From: Timo Wischer > > snd_pcm_link() can be called by the user a

Re: [PATCH 09/10] ALSA: pcm: Add snd_pcm_ops for snd_pcm_link()

2019-03-26 Thread Takashi Iwai
On Tue, 26 Mar 2019 08:49:33 +0100, wrote: > > From: Timo Wischer > > snd_pcm_link() can be called by the user as long as the device is not > yet started. Therefore currently a driver which wants to iterate over > the linked substreams has to do this at the start trigger. But the start > trigge

Re: [PATCH 04/10] ALSA: aloop: Use always spin_lock_irqsave() for cable->lock

2019-03-25 Thread Takashi Iwai
On Mon, 25 Mar 2019 17:40:23 +0100, Timo Wischer wrote: > > Best regards > Timo Wischer > Engineering Software Base (ADITG/ESB) > > Tel. +49 5121 49 6938 > On 3/25/19 17:07, Takashi Iwai wrote: > > On Mon, 25 Mar 2019 17:00:38 +0100, > wrote: >

Re: [PATCH 04/10] ALSA: aloop: Use always spin_lock_irqsave() for cable->lock

2019-03-25 Thread Takashi Iwai
On Mon, 25 Mar 2019 17:00:38 +0100, wrote: > > From: Timo Wischer > > to allow the usage of timer callbacks from interrupt context. > For example the sound timer. The trigger callback is already irq-disabled. And, open/close must not be irq-disabled OTOH. So these changes must be superfluous

Re: [ALSA patch] [PATCH] ALSA: aloop: Support S24 sample formats

2019-03-25 Thread Takashi Iwai
On Mon, 25 Mar 2019 16:35:20 +0100, Jaroslav Kysela wrote: > > Dne 25. 03. 19 v 16:14 twisc...@de.adit-jv.com napsal(a): > > From: Timo Wischer > > > > Currently snd_aloop supports only S16 and S32 audio sample formats. With > > this patch the S24 formats are also supported. > > Reviewed-by: Ja

Re: [PATCH] ALSA: hda/ca0132: work around clang -Wuninitialized warning

2019-03-22 Thread Takashi Iwai
On Fri, 22 Mar 2019 15:06:28 +0100, Arnd Bergmann wrote: > > When CONFIG_PCI is disabled, clang gets confused about the > control flow of the switch() statement always ending up > in the default case, and warns: > > sound/pci/hda/patch_ca0132.c:7558:6: error: variable 'fw_entry' is used > uninit

Re: [PATCH 3/3] ALSA: hda/realtek: Enable headset MIC of ASUS X430UN and X512DK with ALC256

2019-03-22 Thread Takashi Iwai
On Fri, 22 Mar 2019 04:37:22 +0100, Jian-Hong Pan wrote: > > The ASUS X430UN and X512DK with ALC256 cannot detect the headset MIC > until ALC256_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. > > Signed-off-by: Jian-Hong Pan > Signed-off-by: Daniel Drake Applied, thanks. Takashi

Re: [PATCH 2/3] ALSA: hda/realtek: Enable headset mic of ASUS P5440FF with ALC256

2019-03-22 Thread Takashi Iwai
On Fri, 22 Mar 2019 04:37:20 +0100, Jian-Hong Pan wrote: > > From: Chris Chiu > > The ASUS laptop P5440FF with ALC256 can't detect the headset microphone > until ALC256_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. > > Signed-off-by: Chris Chiu > Signed-off-by: Daniel Drake > Signed-off-by: Jian-

Re: [PATCH 1/3] ALSA: hda/realtek: Enable ASUS X441MB and X705FD headset MIC with ALC256

2019-03-22 Thread Takashi Iwai
On Fri, 22 Mar 2019 04:37:18 +0100, Jian-Hong Pan wrote: > > The ASUS laptop X441MB and X705FD with ALC256 cannot detect the headset > MIC until ALC256_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. > > Signed-off-by: Chris Chiu > Signed-off-by: Daniel Drake > Signed-off-by: Jian-Hong Pan Applied,

[GIT PULL] sound fixes for 5.1-rc2

2019-03-22 Thread Takashi Iwai
Linus, please pull sound fixes for v5.1-rc2 from: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/sound-5.1-rc2 The topmost commit is 667a8f73753908c4d0171e52b71774f9be5d6713 sound fixes for 5.1-rc2 The onl

Re: [PATCH] ALSA: hda/realtek - Add support for Acer Aspire E5-523G/ES1-432 headset mic

2019-03-21 Thread Takashi Iwai
On Thu, 21 Mar 2019 10:17:31 +0100, Jian-Hong Pan wrote: > > From: Chris Chiu > > The Acer laptop Aspire E5-523G and ES1-432 with ALC255 can't detect > the headset microphone until ALC255_FIXUP_ACER_MIC_NO_PRESENCE quirk > applied. > > Signed-off-by: Chris Chiu > Signed-off-by: Daniel Drake >

Re: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer Aspire Z24-890 with ALC286

2019-03-21 Thread Takashi Iwai
On Thu, 21 Mar 2019 09:39:04 +0100, Jian-Hong Pan wrote: > > The Acer Aspire Z24-890 cannot detect the headset MIC until > ALC286_FIXUP_ACER_AIO_HEADSET_MIC quirk applied. > > Signed-off-by: Jian-Hong Pan > Signed-off-by: Daniel Drake Applied, thanks. Takashi

Re: [PATCH] ALSA: seq: oss: Fix Spectre v1 vulnerability

2019-03-21 Thread Takashi Iwai
On Thu, 21 Mar 2019 00:42:01 +0100, Gustavo A. R. Silva wrote: > > dev is indirectly controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > > sound/core/seq/oss/seq_oss_synth.c:626 snd

Re: [PATCH] ALSA: rawmidi: Fix potential Spectre v1 vulnerability

2019-03-21 Thread Takashi Iwai
On Wed, 20 Mar 2019 22:15:24 +0100, Gustavo A. R. Silva wrote: > > info->stream is indirectly controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > > sound/core/rawmidi.c:604 __snd_ra

Re: [PATCH v2] ALSA: hda/realtek: Enable headset MIC of Acer AIO with ALC286

2019-03-20 Thread Takashi Iwai
On Thu, 21 Mar 2019 03:37:33 +0100, Kailang wrote: > > Yes, you could use Reviewed-by. OK, applied now. Thanks. Takashi > > -Original Message- > From: Jian-Hong Pan > Sent: Wednesday, March 20, 2019 1:06 PM > To: Takashi Iwai > Cc: Kailang ; alsa-de...

Re: KASAN: slab-out-of-bounds Write in default_read_copy_kernel

2019-03-19 Thread Takashi Iwai
On Sat, 16 Mar 2019 15:49:02 +0100, syzbot wrote: > > syzbot has bisected this bug to: > > commit 65766ee0bf7fe8b3be80e2e1c3ef54ad59b29476 > Author: Takashi Iwai > Date: Fri Nov 9 10:59:45 2018 + > > ALSA: oss: Use kvzalloc() for local buffer allocations &g

Re: [PATCH] ALSA: opl3: fix mismatch between snd_opl3_drum_switch definition and declaration

2019-03-18 Thread Takashi Iwai
On Mon, 18 Mar 2019 00:21:24 +0100, Colin King wrote: > > From: Colin Ian King > > The function snd_opl3_drum_switch declaration in the header file > has the order of the two arguments on_off and vel swapped when > compared to the definition arguments of vel and on_off. Fix this > by swapping t

Re: [PATCH] sound: sb8: add a check for request_region

2019-03-16 Thread Takashi Iwai
On Fri, 15 Mar 2019 05:04:14 +0100, Kangjie Lu wrote: > > In case request_region fails, the fix returns an error code to > avoid NULL pointer dereference. > > Signed-off-by: Kangjie Lu Applied, thanks. Takashi

Re: [PATCH] sound: echoaudio: add a check for ioremap_nocache

2019-03-16 Thread Takashi Iwai
On Fri, 15 Mar 2019 04:58:29 +0100, Kangjie Lu wrote: > > In case ioremap_nocache fails, the fix releases chip and returns > an error code upstream to avoid NULL pointer dereference. > > Signed-off-by: Kangjie Lu Applied, thanks. Takashi

Re: [PATCH v2] ALSA: hda/realtek: Enable headset MIC of Acer AIO with ALC286

2019-03-15 Thread Takashi Iwai
On Fri, 15 Mar 2019 10:51:09 +0100, Jian-Hong Pan wrote: > > Some Acer AIO desktops like Veriton Z6860G, Z4860G and Z4660G cannot > record sound from headset MIC. This patch adds the > ALC286_FIXUP_ACER_AIO_HEADSET_MIC quirk to fix this issue. > > Signed-off-by: Jian-Hong Pan > --- > v2: Accord

[GIT PULL] sound fixes for 5.1-rc1

2019-03-15 Thread Takashi Iwai
Linus, please pull sound fixes for v5.1-rc1 from: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/sound-fix-5.1-rc1 The topmost commit is da484d00f020af3dd7cfcc6c4b69a7f856832883 sound fixes for 5.1-rc1 Som

Re: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer TravelMate X514-51T with ALC255

2019-03-13 Thread Takashi Iwai
On Wed, 13 Mar 2019 10:33:24 +0100, Jian-Hong Pan wrote: > > The Acer TravelMate X514-51T with ALC255 cannot detect the headset MIC > until ALC255_FIXUP_ACER_HEADSET_MIC quirk applied. Although, the > internal DMIC uses another module - snd_soc_skl as the driver. We still > need the NID 0x1a in

Re: [PATCH] Fix speakers on Acer Predator Helios 500 Ryzen laptops

2019-03-13 Thread Takashi Iwai
On Wed, 13 Mar 2019 11:30:48 +0100, Takashi Iwai wrote: > > On Tue, 05 Mar 2019 00:38:19 +0100, > Bernhard Rosenkraenzer wrote: > > > > On an Acer Predator Helios 500 (Ryzen version), the laptop's speakers > > don't work out of the box. > >

Re: [PATCH] Fix speakers on Acer Predator Helios 500 Ryzen laptops

2019-03-13 Thread Takashi Iwai
On Tue, 05 Mar 2019 00:38:19 +0100, Bernhard Rosenkraenzer wrote: > > On an Acer Predator Helios 500 (Ryzen version), the laptop's speakers > don't work out of the box. > > The problem can be worked around with hdajackretask, remapping the > "Black Headphone, Right side" pin (0x21) to the Interna

Re: [PATCH] ALSA: hda/tegra: avoid build error without CONFIG_PM

2019-03-13 Thread Takashi Iwai
On Mon, 04 Mar 2019 21:33:25 +0100, Arnd Bergmann wrote: > > The #ifdef protection around the PM functions is wrong, leading to > a failed reference in some configurations: > > sound/pci/hda/hda_tegra.c: In function 'hda_tegra_runtime_suspend': > sound/pci/hda/hda_tegra.c:273:2: error: implicit d

Re: [PATCH] ALSA: usx2y: Fix potential NULL pointer dereference

2019-03-13 Thread Takashi Iwai
On Tue, 05 Mar 2019 00:00:02 +0100, Aditya Pakki wrote: > > usb_alloc_urb can fail due to kmalloc failure and push the error > upstream. Further this can cause a NULL pointer dereference in > init_pipe_urbs. This patch avoids such a scenario. > > Signed-off-by: Aditya Pakki Applied, thanks.

Re: [PATCH 1/1] sound/hda/hdac_stream: Avoid NULL pointer dereference

2019-03-13 Thread Takashi Iwai
On Mon, 11 Mar 2019 21:53:57 +0100, Mariusz Ceier wrote: > > For ca0132 codec, azx_dev->stream is NULL during firmware loading. > Calling snd_hdac_get_stream_stripe_ctl unconditionally causes NULL > pointer dereference in that function. > > Signed-off-by: Mariusz Ceier Applied now (with a prope

[GIT PULL] sound updates for 5.1

2019-03-02 Thread Takashi Iwai
: samsung: i2s: Fix secondary platform device unregistration ASoC: samsung: i2s: Fix multiple "IIS multi" devices initialization ASoC: samsung: odroid: Fix of_node refcount unbalance ASoC: samsung: odroid: Prevent uninitialized variable use Takashi Iwai (87): ALSA: pcm

Re: [PATCH] efi: Downgrade "EFI_MEMMAP is not enabled" message

2019-03-01 Thread Takashi Iwai
On Fri, 01 Mar 2019 15:57:03 +0100, Ard Biesheuvel wrote: > > On Fri, 1 Mar 2019 at 15:14, Takashi Iwai wrote: > > > > On Fri, 01 Mar 2019 15:02:23 +0100, > > Ard Biesheuvel wrote: > > > > > > On Fri, 1 Mar 2019 at 15:01, Takashi Iwai wrote: > >

Re: [PATCH] efi: Downgrade "EFI_MEMMAP is not enabled" message

2019-03-01 Thread Takashi Iwai
On Fri, 01 Mar 2019 15:02:23 +0100, Ard Biesheuvel wrote: > > On Fri, 1 Mar 2019 at 15:01, Takashi Iwai wrote: > > > > On Fri, 01 Mar 2019 14:53:39 +0100, > > Ard Biesheuvel wrote: > > > > > > On Fri, 1 Mar 2019 at 14:40, Takashi Iwai wrote: > &

Re: [PATCH] efi: Downgrade "EFI_MEMMAP is not enabled" message

2019-03-01 Thread Takashi Iwai
On Fri, 01 Mar 2019 14:53:39 +0100, Ard Biesheuvel wrote: > > On Fri, 1 Mar 2019 at 14:40, Takashi Iwai wrote: > > > > Since 38ac0287b7f4 ("fbdev/efifb: Honour UEFI memory map attributes > > when mapping the FB"), efifb_probe() checks its memory range via &

[PATCH] efi: Downgrade "EFI_MEMMAP is not enabled" message

2019-03-01 Thread Takashi Iwai
tion is more or less moot. So let's downgrade the error message for stop annoying users. Fixes: 38ac0287b7f4 ("fbdev/efifb: Honour UEFI memory map attributes when mapping the FB") Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1127339 Signed-off-by: Takashi Iwai --- drivers

Re: linux-next: manual merge of the sound tree with the arm-soc tree

2019-02-25 Thread Takashi Iwai
On Mon, 25 Feb 2019 10:19:15 +0100, Arnd Bergmann wrote: > > On Mon, Feb 25, 2019 at 2:36 AM Stephen Rothwell > wrote: > > > > Hi Takashi, > > > > Today's linux-next merge of the sound tree got conflicts in: > > > > arch/arm64/boot/dts/nvidia/tegra194-p2972-.dts > > arch/arm64/boot/dts/n

Re: [PATCH 1/3] ALSA: hda/tegra: property for card name

2019-02-22 Thread Takashi Iwai
On Wed, 20 Feb 2019 16:13:22 +0100, Sameer Pujar wrote: > > An optional property "nvidia,model" is introduced for hda to pass custom > name for the sound card. The suffix "-hda" in the name passed is useful > to distinguish between multiple cards available for a platform. > When the property is no

Re: [PATCH 3/3] ALSA: hda/tegra: sound card name from device tree

2019-02-22 Thread Takashi Iwai
On Wed, 20 Feb 2019 16:13:24 +0100, Sameer Pujar wrote: > > A platform can have multiple sound cards for different audio paths. > Following is the print seen duirng device boot for jetson-xavier, > ALSA device list: > #0: nvidia,p2972- at 0x3518000 irq 17 > By looking at above, it is not

Re: [PATCH 2/3] arm64: tegra: custom name for hda sound card

2019-02-22 Thread Takashi Iwai
On Wed, 20 Feb 2019 16:13:23 +0100, Sameer Pujar wrote: > > "nvidia,model" property is added to pass custom name for hda sound card. > This is parsed in hda driver and used for card name. This aligns with the > way with which sound cards are named in general. > > This patch populates above for je

Re: linux-next: Fixes tag needs some work in the sound tree

2019-02-21 Thread Takashi Iwai
On Thu, 21 Feb 2019 14:10:29 +0100, Stephen Rothwell wrote: > > Hi Takashi, > > In commit > > de73e99af971 ("ALSA: hda/realtek: Enable audio jacks of ASUS UX362FA with > ALC294") > > Fixes tag > > Fixes: 4e0511067 ("ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD > with ALC294") >

Re: [PATCH] ALSA: hda/realtek: Enable audio jacks of ASUS UX362FA with ALC294

2019-02-21 Thread Takashi Iwai
On Thu, 21 Feb 2019 10:00:18 +0100, Jian-Hong Pan wrote: > > The ASUS UX362FA with ALC294 cannot detect the headset MIC and outputs > through the internal speaker and the headphone. This issue can be fixed > by the quirk in the commit 4e0511067 ALSA: hda/realtek: Enable audio > jacks of ASUS UX53

[GIT PULL] sound fixes for 5.0

2019-02-20 Thread Takashi Iwai
Linus, please pull sound fixes for v5.0 from: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/sound-5.0 The topmost commit is 268836649c07e0d38866006b5e94294b5bbc9806 sound fixes for 5.0 Here are a few last-

Re: snd_hda_codec_hdmi: `hdaudio hdaudioC0D2: Unable to bind the codec`

2019-02-18 Thread Takashi Iwai
On Mon, 18 Feb 2019 16:17:30 +0100, Paul Menzel wrote: > > >> Then, I built the HDA subsystem as a module, but that also did not help. > >> The DRM subsystem is started after the HD-audio subsystem. > >> > >> ``` > >> $ grep -e SND_HDA= -e SND_HDA_INTEL /boot/config-4.20.8.mx64.245 > >> CONFIG_SN

Re: [PATCH] ASoC: simple-card: Fix refcount underflow

2019-02-17 Thread Takashi Iwai
On Mon, 18 Feb 2019 08:06:19 +0100, Daniel Baluta wrote: > > On Mon, 2019-02-18 at 10:37 +0900, Kuninori Morimoto wrote: > > Hi Daniel, Mark, again > > > > > > of_get_child_by_name() takes a reference we'll need to drop > > > > later so when we substitute in top we need to take a reference > > >

Re: snd_hda_codec_hdmi: `hdaudio hdaudioC0D2: Unable to bind the codec`

2019-02-14 Thread Takashi Iwai
On Thu, 14 Feb 2019 17:00:29 +0100, Paul Menzel wrote: > > Dear Takashi, > > > On 02/13/19 16:56, Takashi Iwai wrote: > > On Wed, 13 Feb 2019 16:42:19 +0100, > > Paul Menzel wrote: > > >> On 02/13/19 16:12, Takashi Iwai wrote: > >>> On Wed,

Re: [PATCH -next] ALSA: es1688: Remove set but not used variable 'hw'

2019-02-13 Thread Takashi Iwai
On Thu, 14 Feb 2019 03:10:33 +0100, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > sound/isa/es1688/es1688_lib.c: In function 'snd_es1688_probe': > sound/isa/es1688/es1688_lib.c:124:31: warning: > variable 'hw' set but not used [-Wunused-but-set-variable] > unsigned s

<    4   5   6   7   8   9   10   11   12   13   >