Tony Vroon wrote:
The first user of ata_ac_issue_prot_with_ledtrigger, the ServerWorks Frodo/
Apple K2 driver. Used by the IDE LED trigger on G5 towers.
Respin of an earlier patch, based on comments by Tejun Heo Alan Cox.
Just two comments.
1. IMHO, ata_qc_issue_prot_ledtrigger() without
, and the function name shortened as requested.
Signed-off-by: Tony Vroon [EMAIL PROTECTED]
Acked-by: Tejun Heo [EMAIL PROTECTED]
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
Jeff Garzik wrote:
Robert Hancock wrote:
This patch adds in some NCQ blacklist entries taken from the Silicon
Image Windows drivers' .inf files for the 3124 and 3132 controllers.
These entries were marked as DisableSataQueueing. Assume these are
in their blacklist for a reason and disable NCQ
Christian wrote:
I've tested multiple kernels (including -mm series) in the range of 2.6.19.7
(before sata_nv adma support went in) up to 2.6.20-rc4.
Every NCQ enabled kernel I've tested showed ata errors in dmesg. So I came to
the conclusion that my system was faulty. I ran memtest86+ for a
Lukas Hejtmanek wrote:
Subject: ata_piix: PATA UDMA/100 configured as UDMA/33
References : http://lkml.org/lkml/2007/2/20/294
Submitter : Fabio Comolli [EMAIL PROTECTED]
Status : unknown
ata_piix :00:1f.1: version 2.10ac1
ACPI: PCI Interrupt :00:1f.1[A] - GSI 18 (level,
Adrian Bunk wrote:
Subject: NCQ problem with ahci and Hitachi drive (ACPI related)
References : http://lkml.org/lkml/2007/3/4/178
http://lkml.org/lkml/2007/3/9/475
Submitter : Mathieu Bérard [EMAIL PROTECTED]
Handled-By : Tejun Heo [EMAIL PROTECTED]
Status : problem
J.A. Magallón wrote:
Libata seems to misdetect my cable.
I have double-checked and the cable is 80 pin...
Does the following patch fix your problem?
http://article.gmane.org/gmane.linux.ide/17444
(You can get the raw message by appending /raw to the URL).
--
tejun
-
To unsubscribe from
Jeff Garzik wrote:
Linus Torvalds wrote:
There's various fixes here, ranging from some architecture updates
(ia64, ARM, MIPS, SH, Sparc64) to KVM, networking and network drivers.
And random one-liners.
But probably more important, and likely much more visible to most
people is the fixes for
Justin Piszcz wrote:
Checking the benchmarks on various hardware websites, anandtech,
hothardware and others, they generally all come to the same conclusion
if there is only 1 thread using I/O (single user system) then NCQ off is
the best.
Are they testing using Linux? I/O performance is
tag 0 cdb 0x43 data 12 in
res 51/24:03:00:00:00/00:00:00:00:00/a0 Emask 0x40 (internal error)
end cut -
Signed-off-by: Conke Hu [EMAIL PROTECTED]
Acked-by: Tejun Heo [EMAIL PROTECTED]
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-kernel
devres should be deallocated with devres_free() not kfree(). This bug
corrupts slab on IRQ request failure. Fix it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
Sorry about the bug, please apply before 2.6.21 release. Thanks.
diff --git a/kernel/irq/devres.c b/kernel/irq/devres.c
index
to be
deleted.
This patch makes sysfs report the pointer to sysfs_dirent as ino.
ino_t is always as big as or larger than unsigned long sysfs_dirent
hierarchy is the internal representation of the sysfs tree, so it
makes sense and simple to implement.
Signed-off-by: Tejun Heo [EMAIL PROTECTED
Error handling in fs/sysfs/bin.c:write() was wrong because size_t
count is used to receive return value from flush_write() which is
negative on failure.
This patch updates write() such that int variable is used instead.
read() is updated the same way for consistency.
Signed-off-by: Tejun Heo
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/base/class.c|2 --
drivers/base/core.c |4
drivers/base/firmware_class.c |2 +-
drivers/block/pktcdvd.c |3 +--
drivers/char/ipmi
reference simplification.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/bin.c | 18 +++---
fs/sysfs/dir.c | 40 ++--
fs/sysfs/file.c| 19 ++-
fs/sysfs/inode.c |2 +-
fs/sysfs/mount.c |1 -
fs
of object reference simplification.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/dir.c | 82
fs/sysfs/file.c| 21 ++---
fs/sysfs/symlink.c |7 ++--
fs/sysfs/sysfs.h |7 +++-
4 files changed, 50 insertions(+), 67
Implement bin_buffer which contains a mutex and pointer to PAGE_SIZE
buffer to properly synchronize accesses to per-openfile buffer and
prepare for immediate-kobj-disconnect.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/bin.c | 64
-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/dir.c | 27 ---
fs/sysfs/mount.c |1 +
fs/sysfs/sysfs.h |1 +
3 files changed, 22 insertions(+), 7 deletions(-)
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
index 653c23c..ef45c3e 100644
--- a/fs/sysfs/dir.c
+++ b
.
Please read the following message for more info.
http://article.gmane.org/gmane.linux.kernel/510293
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/bin.c | 97 ++-
fs/sysfs/dir.c | 39 +++-
fs/sysfs/file.c | 133
that this lock belongs to kobject/driver-model not sysfs. Once
sysfs is converted to not use kobject in its interface, this can be
removed from sysfs.
This is in preparation of object reference simplification.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/dir.c |8 +++-
fs
and
removed.
This change allows symlink to be implemented using sysfs_dirent tree
proper, which is the last remaining dentry-dependent sysfs walk.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/dir.c| 33 +
fs/sysfs/file.c |2 +-
fs/sysfs/inode.c
Flatten cleanup paths in sysfs_add_link() and create_dir() to improve
readability and ease further changes to these functions. This is in
preparation of object reference simplification.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/dir.c | 73
There is no reason these functions should be inlined and soon to
follow sysfs object reference simplification will make these functions
heavier. Move them to dir.c.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/dir.c | 30 ++
fs/sysfs/sysfs.h | 32
Hello, all.
This patchset is result of the following thread.
http://thread.gmane.org/gmane.linux.kernel/510293
This patchset takes sysfs out of device driver lifetime equation which
not not only fixes several race conditions caused by sysfs not holding
onto the proper module when referencing
Now that sysfs_dirent can be disconnected from kobject on deletion,
there is no need to orphan each attribute files. All [bin_]attribute
nodes are automatically orphaned when the parent node is deleted.
Kill attribute file orphaning.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs
the following message for more info.
http://article.gmane.org/gmane.linux.kernel/510293
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/dir.c |9 +++--
fs/sysfs/symlink.c | 88 +++
fs/sysfs/sysfs.h |2 +-
3 files changed, 53 insertions
Hello, Maneesh.
Maneesh Soni wrote:
o sysfs_d_iput() is invoked in dentry reclaim path under memory pressure. This
happens without i_mutex. It also nullifies s_dentry to indicate that
the associated dentry is evicted. sysfs_readdir() accesses the s_dentry,
and gets the inode number from
Tejun Heo wrote:
Now that sysfs_dirent can be disconnected from kobject on deletion,
there is no need to orphan each attribute files. All [bin_]attribute
nodes are automatically orphaned when the parent node is deleted.
Kill attribute file orphaning.
Signed-off-by: Tejun Heo [EMAIL
Hello,
Alan Stern wrote:
The problem here is that kobjec_get() in sysfs_schedule_callback()
doesn't grab the module backing the kobject it's grabbing. By the
time (ss-func)(ss-kobj) runs, scsi_mod is already gone.
As the author of this routine, I wish you had included my name in your
There is no reason this function should be inlined and soon to follow
sysfs object reference simplification will make it heavier. Move it
to dir.c.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/dir.c | 12
fs/sysfs/sysfs.h | 13 +
2 files changed, 13
Hello, all.
This is the second take of sysfs-immediate-disconnct patchset.
In the last take, rwsem was added to s_elem.dir to protect kobj only.
This wasn't enough because attr and bin_attr need to hold onto not
only the kobject of their parents but also the module backing
themselves and ops
Flatten cleanup paths in sysfs_add_link() and create_dir() to improve
readability and ease further changes to these functions. This is in
preparation of object reference simplification.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/dir.c | 73
Now that sysfs_dirent can be disconnected from kobject on deletion,
there is no need to orphan each attribute files. All [bin_]attribute
nodes are automatically orphaned when the parent node is deleted.
Kill attribute file orphaning.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs
and
removed.
This change allows symlink to be implemented using sysfs_dirent tree
proper, which is the last remaining dentry-dependent sysfs walk.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/dir.c| 33 +
fs/sysfs/file.c |2 +-
fs/sysfs/inode.c
the following message for more info.
http://article.gmane.org/gmane.linux.kernel/510293
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/dir.c |2 +-
fs/sysfs/symlink.c | 88 +++
fs/sysfs/sysfs.h |9 +++--
3 files changed, 53 insertions
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/base/class.c|2 --
drivers/base/core.c |4
drivers/base/firmware_class.c |2 +-
drivers/block/pktcdvd.c |3 +--
drivers/char/ipmi
onto the proper module when referencing kobject, but
also helps fixing and simplifying lifetime management in driver model
and drivers by taking sysfs out of the equation.
Please read the following message for more info.
http://article.gmane.org/gmane.linux.kernel/510293
Signed-off-by: Tejun
Implement bin_buffer which contains a mutex and pointer to PAGE_SIZE
buffer to properly synchronize accesses to per-openfile buffer and
prepare for immediate-kobj-disconnect.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/bin.c | 64
that this lock belongs to kobject/driver-model not sysfs. Once
sysfs is converted to not use kobject in its interface, this can be
removed from sysfs.
This is in preparation of object reference simplification.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/dir.c |8 +++-
fs
reference simplification.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/bin.c | 18 ++--
fs/sysfs/dir.c | 31 +---
fs/sysfs/file.c| 19 +
fs/sysfs/inode.c |2 +-
fs/sysfs/mount.c |1 -
fs/sysfs/symlink.c
of object reference simplification.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/dir.c | 82
fs/sysfs/file.c| 21 ++---
fs/sysfs/symlink.c |7 ++--
fs/sysfs/sysfs.h |7 +++-
4 files changed, 50 insertions(+), 67
to be
deleted.
This patch makes sysfs report the pointer to sysfs_dirent as ino.
ino_t is always as big as or larger than unsigned long sysfs_dirent
hierarchy is the internal representation of the sysfs tree, so it
makes sense and simple to implement.
Signed-off-by: Tejun Heo [EMAIL PROTECTED
Error handling in fs/sysfs/bin.c:write() was wrong because size_t
count is used to receive return value from flush_write() which is
negative on failure.
This patch updates write() such that int variable is used instead.
read() is updated the same way for consistency.
Signed-off-by: Tejun Heo
-off-by: Tejun Heo [EMAIL PROTECTED]
---
fs/sysfs/dir.c | 27 ---
fs/sysfs/mount.c |1 +
fs/sysfs/sysfs.h |1 +
3 files changed, 22 insertions(+), 7 deletions(-)
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
index 3e460f7..8c35a60 100644
--- a/fs/sysfs/dir.c
+++ b
Justin Piszcz wrote:
On Thu, 5 Apr 2007, Justin Piszcz wrote:
Had a quick question, this is the first time I have seen this happen,
and it was not even under during heavy I/O, hardly anything was going
on with the box at the time.
.. snip ..
# /usr/bin/time badblocks -b 512 -s -v
for more info.
http://article.gmane.org/gmane.linux.kernel/510293
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
Cornelia, this should fix the problem you reported. It's caused by
doing up_write() on sysfs_dirent which is used for readdir cursor
which is not deactivated before being released
Cornelia Huck wrote:
On Mon, 9 Apr 2007 13:18:46 +0900,
Tejun Heo [EMAIL PROTECTED] wrote:
With all the patches applied, the same test used in the last take ran
9+hrs without any problem.
I get the following on startup:
=
[ BUG: bad unlock balance
Cornelia Huck wrote:
On Tue, 10 Apr 2007 16:17:06 +0200,
Cornelia Huck [EMAIL PROTECTED] wrote:
You missed some s390 attributes :)
Yeap, I used allyesconfig on x86 to do the patch, so attrs on other
archs are not there. I'll merge this patch and post the updated version.
Thanks.
--
tejun
s390 attributes changes are from Cornelia Huck.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Cc: Cornelia Huck [EMAIL PROTECTED]
---
Andrew, please use this patch instead of the original one.
Thanks.
arch/s390/kernel/ipl.c |2 --
drivers/base/class.c
Hello,
Cornelia Huck wrote:
===
[ INFO: possible circular locking dependency detected ]
2.6.21-rc6-ge666c753-dirty #54
---
kslowcrw/64 is trying to acquire lock:
(sch-reg_mutex){--..},
Tejun Heo wrote:
Hello,
Cornelia Huck wrote:
===
[ INFO: possible circular locking dependency detected ]
2.6.21-rc6-ge666c753-dirty #54
---
kslowcrw/64 is trying to acquire lock:
(sch
Conke Hu wrote:
SB600 RAID and SB600 SATA is the same controller and share the
same PCI ID 0x4380. There is such PCI ID 0x4381.
I assume 'no' is missing in the last sentence. :-)
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
On Wed, Apr 11, 2007 at 06:26:42PM +0900, Tejun Heo wrote:
Hello,
Cornelia Huck wrote:
===
[ INFO: possible circular locking dependency detected ]
2.6.21-rc6-ge666c753-dirty #54
Conke Hu wrote:
On 4/11/07, Tejun Heo [EMAIL PROTECTED] wrote:
Conke Hu wrote:
SB600 RAID and SB600 SATA is the same controller and share the
same PCI ID 0x4380. There is such PCI ID 0x4381.
I assume 'no' is missing in the last sentence. :-)
--
tejun
Oh, sorry :(
so, should I
s_active is released by the thread doing the final sysfs_put() which
can be different from the thread which did sysfs_deactivate(). Make
lockdep think that s_active is unlocked immediately after it's write
locked.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
Greg, this patch fixes lockdep
[EMAIL PROTECTED] wrote:
Hello,
I have been running 2.6.18 for two months and the last couple of days these
error messages have appeared in my logs
(sata_promise kernel module, sda:SATA sdb:PATA disks):
ata1: command timeout
Feb 17
Rafael J. Wysocki wrote:
Update:
I get the same BUG with 2.6.20-git13 100% of the time during the resume.
The system seems to be fully functional nonetheless.
Known bug, will be fixed soon.
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
Sanity check in pcim_pin_device() was too restrictive in that it
didn't allow multiple calls to the function, which is against the
devres philosohpy of fire-and-forget. Track pinned status separately
and allow pinning multiple times.
Signed-off-by: Tejun Heo [EMAIL PROTECTED
Joel Soete wrote:
Ok comparing the content of the original image:
# mount -t iso9660 -o ro -o loop /MultiCd/cd060213.iso /mnt/cd
# find /mnt/cd -type f -exec md5sum {} \;
37149d4961c0484f2cceb1a1614b253d /mnt/cd/boot.cat
4ab996554b0e7ade115a3f284b876612 /mnt/cd/boot.msg
* Pablo, the bug you saw was bad interaction between blacklisted NCQ
device and dynamic queue depth adjustment. Patches are submitted to fix
the problem. Just drop the blacklist patch. Your drives should work
fine in NCQ mode. My gut feeling is that your problem is power related
from the
Conversion to resource-managed iomap was buggy causing init failures
on both vt6420 and 6421 - BAR5 wasn't mapped for both controllers
while on vt6420 sata_via tried to map BAR0-4 twice. Fix it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
I thought I have a vt6421 but mine too was a vt6420
Pablo Sebastian Greco wrote:
Tejun Heo wrote:
* Pablo, the bug you saw was bad interaction between blacklisted NCQ
device and dynamic queue depth adjustment. Patches are submitted to fix
the problem. Just drop the blacklist patch. Your drives should work
fine in NCQ mode. My gut feeling
Marcus Haebler wrote:
thanks for the patches! I am on an Intel P965/ICH8R.
I see. That can happen too. There was a race window where in-flight
r/w command which left SCSI midlayer but pending on libata gets executed
in the wrong mode. If possible, please verify that it doesn't happen
with the
Jeff Garzik wrote:
Mark Lord wrote:
I don't believe that. Command timeouts never happen on healthy systems,
unless we have a driver bug. Okay, so I can imagine a pathological case
of a full queue (NCQ) with all 32 commands taking longer than usual due
to ECC retries in the firmware..
Robert Hancock wrote:
This updates libata FUA support to be more more in line with reality.
FUA support remains off by default.
Add a setting for the fua command-line parameter on libata which enables
FUA only on NCQ-supporting disks.
Update the ata_dev_supports_fua function to remove the
[cc'ing Ric, Hannes and Dongjun, Hello. Feel free to drag other people in.]
Robert Hancock wrote:
Jens Axboe wrote:
But we can't really change that, since you need the cache flushed before
issuing the FUA write. I've been advocating for an ordered bit for
years, so that we could just do:
Jens Axboe wrote:
On Wed, Feb 21 2007, Tejun Heo wrote:
[cc'ing Ric, Hannes and Dongjun, Hello. Feel free to drag other people in.]
Robert Hancock wrote:
Jens Axboe wrote:
But we can't really change that, since you need the cache flushed before
issuing the FUA write. I've been advocating
-by: Frederik Deweerdt [EMAIL PROTECTED]
Cc: Al Viro [EMAIL PROTECTED]
Cc: Tejun Heo [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
Signed-off-by: Linus Torvalds [EMAIL PROTECTED]
--
tejun
-
To unsubscribe from this list: send
Does it work if you give 'irqpoll' kernel parameter?
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Test major version in ata_id_is_sata() not separately.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
diff --git a/include/linux/ata.h b/include/linux/ata.h
index 272736e..c331da2 100644
--- a/include/linux/ata.h
+++ b/include/linux/ata.h
@@ -282,7 +282,6 @@ struct ata_taskfile {
};
#define
Leopold Palomo-Avellaneda wrote:
A Dimarts 13 Febrer 2007 17:19, Jean Delvare va escriure:
Le Mardi 13 Février 2007 17:11, Leopold Palomo-Avellaneda a écrit :
A Dimarts 13 Febrer 2007 12:20, Jean Delvare va escriure:
(...)
*If* the VT8251 needs the VIA IRQ quirk, then the attached patch
may
, but we don't run that code on normal
shutdown, do we?
Tejun Heo had a patch for sd that could (optionally) trigger a START
STOP UNIT command to spin the disk down after synchronizing the cache
before shutdown, but I haven't heard anything of it lately..
I just came back from LSF and lunar new
a notifier tag that isn't
outstanding, since the drive may be issuing spurious completions.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
Acked-by: Tejun Heo [EMAIL PROTECTED]
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL
Rafael J. Wysocki wrote:
Hi,
On Friday, 23 February 2007 00:04, Lukas Hejtmanek wrote:
Hello,
after some time I've tried to suspend to disk. It basically works but it
complains into log with the following message:
Tejun says it is known and he's going to fix it.
Patch went into
Manuel Metz wrote:
Tejun Heo wrote:
Does it work if you give 'irqpoll' kernel parameter?
Yes this works with irqpoll. But as you can see in the attached dmesg
output, now I get a bunch of APIC errors ... ?
Manuel, Stefan, please try the attached patch over 2.6.20 and report the
result
Hello, Adrian.
Adrian Bunk wrote:
On Tue, Feb 20, 2007 at 12:43:41PM +0900, Tejun Heo wrote:
Rafael J. Wysocki wrote:
Update:
I get the same BUG with 2.6.20-git13 100% of the time during the resume.
The system seems to be fully functional nonetheless.
Known bug, will be fixed soon
Adrian Bunk wrote:
On Sun, Feb 25, 2007 at 01:28:42PM +0900, Tejun Heo wrote:
Hello, Adrian.
Adrian Bunk wrote:
On Tue, Feb 20, 2007 at 12:43:41PM +0900, Tejun Heo wrote:
Rafael J. Wysocki wrote:
Update:
I get the same BUG with 2.6.20-git13 100% of the time during the resume.
The system
Clearing drvdata in -remove_one causes NULL pointer deference. Clear
drvdata only in ata_host_release() after all resources are freed.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
pata_pcmcia is fixed by Alan's patch. This fixes other drivers and
make libata always clear drvdata after detach
Some LLDs were missing scsi device PM callbacks while having host/port
suspend support. Add missing ones.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
This should fix the problem you're seeing on sil680. These patches
are against 2.6.20.1. Patches for libata-dev#upstream is separately
posted
Add missing #ifdef CONFIG_PM conditionals around all PM related parts
in libata LLDs.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/ahci.c | 14 ++
drivers/ata/ata_generic.c |4
drivers/ata/ata_piix.c |4
drivers/ata
[cc'ing Pavel and linux-kernel, hello]
Original thread can be read from
http://thread.gmane.org/gmane.linux.ide/16475
Jeff Garzik wrote:
Tejun Heo wrote:
Some LLDs were missing scsi device PM callbacks while having host/port
suspend support. Add missing ones.
Signed-off-by: Tejun Heo
Hello, Nigel.
Nigel Cunningham wrote:
Index: work1/drivers/ata/ahci.c
===
--- work1.orig/drivers/ata/ahci.c
+++ work1/drivers/ata/ahci.c
@@ -225,10 +225,12 @@ static void ahci_thaw(struct ata_port *a
static void
Hello, Mathieu.
Mathieu Bérard wrote:
Hello,
I have and laptop with an ICH6M SATA Controller and an Hitachi hard drive.
While it worked well using the ahci module and with NCQ enabled using
Linux 2.6.20, it does not work anymore (hang at boot) with 2.6.21-rc*
My drive is among those that
Hello, all.
This patch is the result from the following discussion.
http://thread.gmane.org/gmane.linux.ide/16475
The problem is that CONFIG_PM affects a lot of low level drivers and
scattering CONFIG_PM all over the place is too ugly. This patch...
* implements __attribute_discard_text__
Philipp Matthias Hahn wrote:
Hello!
As reported by John Williams and others like in
http://www.mail-archive.com/linux-ide@vger.kernel.org/msg03088.html
I too have a problem with 2.6.20.1 using ata_piix not detecting the
CD-ROM any more. Applying the patch from
Dale Blount wrote:
On Tue, 2007-02-27 at 13:54 -0500, Dale Blount wrote:
On Fri, 2007-02-23 at 12:00 -0500, Dale Blount wrote:
Hi,
Excuse me if this has been covered or fixed, I couldn't find anything in
the archives.
I upgraded from 2.6.11.7 to 2.6.20.1 today and found all the drives
[cc'ing Eric D. Mudama. Hi!]
Paul Rolland wrote:
ata1.00: exception Emask 0x2 SAct 0xffe0 SErr 0x0 action 0x2 frozen
ata1.00: (spurious completions during NCQ issue=0x0 SAct=0xffe0
FIS=004040a1:0010)
ata1.00: cmd 60/02:28:52:ec:c4/00:00:0e:00:00/40 tag 5 cdb 0x0 data 1024 in
res
Hello,
Paul Rolland wrote:
Hello,
Applied this on top of 2.6.21-rc1 and your previous patch (see my previous
mail).
Still booting, no more the weird error I've reported minutes ago.
pata_jmicron still unable to detect my DVD-RW :
scsi8 : pata_jmicron
ata9.00: ATAPI, max UDMA/66
Paul Rolland wrote:
Hello,
Your drive has some issues with NCQ and is scheduled to be blacklisted
such that it isn't enabled. libata used to ignore the
condition but now
considers it NCQ protocol violation and fails all pending commands.
OK, do you need an hdparm report to fully
Philipp Matthias Hahn wrote:
On Mon, Mar 05, 2007 at 01:10:10PM +0900, Tejun Heo wrote:
Philipp Matthias Hahn wrote:
As reported by John Williams and others like in
http://www.mail-archive.com/linux-ide@vger.kernel.org/msg03088.html
I too have a problem with 2.6.20.1 using ata_piix
Hello, Catalin.
Catalin Marinas wrote:
Commit 9ac7849e35f705830f7b016ff272b0ff1f7ff759 adds the devres
structure containing a flexible unsigned long long array, with a
comment about the guaranteed alignment. According to the gcc manual,
flexible arrays are considered incomplete types and it
Catalin Marinas wrote:
Chapter 5.31 (http://gcc.gnu.org/onlinedocs/gcc/Alignment.html) states
that it is an error to ask for the alignment of an incomplete type
and flexible array members have incomplete type (according to ISO C99
as described in
Pavel Machek wrote:
Much complexity for little gain. Who is running _without_ CONFIG_PM
these days?
Embedded people, I guess. The problem here is that if we are gonna
support !CONFIG_PM configuration and try to reduce the kernel/module
images size for such case, we end up sprinkling #ifdef's
Conke Hu wrote:
On 3/7/07, Conke Hu [EMAIL PROTECTED] wrote:
Hi,
Do you ever noticed that the ATAPI command TEST_UNIT_READY always
fails to execute !?
I debugged in the following environments:
piix + Intel ICH6/ICH7 PATA
atiixp + ATI SB600 PATA
libata +
Pavel Machek wrote:
Hi!
So if you have reported a regression in the 2.6.21-rc
series, please check 2.6.21-rc5, and update your
report as appropriate (whether fixed or still
problems with xyzzy).
[just got back from vacation, or would have sent this
earlier]
FWIW, I'm still leaning
Kristen Carlson Accardi wrote:
Check to see if an ATAPI device supports Asynchronous Notification.
If so, enable it.
As supporting AN needs host interrupt handler change. I think we need
host-supports-AN flag; otherwise, we might end up with screaming
interrupts in the worst case.
--
Kristen Carlson Accardi wrote:
Allow user space to determine if an ATAPI device supports
async notification (AN) of media changes. This is done by
adding a new sysfs file async_notification to genhd.
If the file reads 1, then the device supports async
notification. If the file reads 0, it
Jeff Garzik wrote:
Kristen Carlson Accardi wrote:
Allow user space to determine if an ATAPI device supports
async notification (AN) of media changes. This is done by
adding a new sysfs file async_notification to genhd.
If the file reads 1, then the device supports async notification. If
the
Kristen Carlson Accardi wrote:
When we get an SDB FIS with the 'N' bit set, we should send
an event to user space to indicate that there has been a
media change. The ahci host controller will send the
event via KOBJ_CHANGE uevent.
Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED]
Jeff Garzik wrote:
AN is a generic concept that I feel will propagate elsewhere.
I think SCSI already has it or am I imagining things again? :-)
Though perhaps it should be in a 'capability_flags' file rather than a
'media_change_event' file.
IMHO, if it's genhd.capability_flags then the
101 - 200 of 22291 matches
Mail list logo
