Re: [PATCH 01/11] powerpc/kvm: Reserve capabilities and ioctls for HPT resizing

2016-12-16 Thread Thomas Huth
On 15.12.2016 06:53, David Gibson wrote: > This adds a new powerpc-specific KVM_CAP_SPAPR_RESIZE_HPT capability to > advertise whether KVM is capable of handling the PAPR extensions for > resizing the hashed page table during guest runtime. > > At present, HPT resizing is possible with KVM PR

Re: [PATCH 08/11] powerpc/kvm: KVM-HV HPT resizing stub implementation

2016-12-16 Thread Thomas Huth
On 15.12.2016 06:54, David Gibson wrote: > This patch adds a stub (always failing) implementation of the ioctl()s > for the HPT resizing PAPR extension. > > Signed-off-by: David Gibson > --- > arch/powerpc/include/asm/kvm_ppc.h | 4 > arch/powerpc/kvm/book3s_64_mmu_hv.c | 16

Re: [PATCH 06/11] powerpc/kvm: Allow KVM_PPC_ALLOCATE_HTAB ioctl() to change HPT size

2016-12-18 Thread Thomas Huth
On 19.12.2016 01:48, David Gibson wrote: > On Fri, Dec 16, 2016 at 01:44:57PM +0100, Thomas Huth wrote: >> On 15.12.2016 06:53, David Gibson wrote: >>> The KVM_PPC_ALLOCATE_HTAB ioctl() is used to set the size of hashed page >>> table (HPT) that userspace expects a gu

Re: [PATCH 05/11] KVM: PPC: Book3S HV: Adjust nine checks for null pointers

2017-01-23 Thread Thomas Huth
On 20.01.2017 19:23, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 20 Jan 2017 11:25:48 +0100 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script "checkpatch.pl" pointed information out like the following. > > Comparison

Re: [PATCH] kvm-pr: manage illegal instructions

2016-05-09 Thread Thomas Huth
On 21.04.2016 11:25, Thomas Huth wrote: > On 15.03.2016 21:18, Laurent Vivier wrote: >> While writing some instruction tests for kvm-unit-tests for powerpc, >> I've found that illegal instructions are not managed correctly with kvm-pr, >> while it is fine with kvm-hv.

Re: [PATCH] kvm-pr: manage illegal instructions

2016-04-21 Thread Thomas Huth
kvmppc_set_gpr(vcpu, 3, EV_UNIMPLEMENTED); > kvmppc_set_pc(vcpu, kvmppc_get_pc(vcpu) + 4); > emulated = EMULATE_DONE; > + } else { > + kvmppc_core_queue_program(vcpu, SRR1_PROGILL); > + emulated = EMULATE_AGAIN; > } > break; > case 19: > Tested-by: Thomas Huth

Re: [PATCH] kvm-pr: manage illegal instructions

2016-05-18 Thread Thomas Huth
On 17.05.2016 19:49, Laurent Vivier wrote: > > > On 17/05/2016 10:37, Alexander Graf wrote: >> On 05/17/2016 10:35 AM, Laurent Vivier wrote: >>> >>> On 12/05/2016 16:23, Laurent Vivier wrote: On 12/05/2016 11:27, Alexander Graf wrote: > On 05/12/2016 11:10 AM, Laurent Vivier wrote:

Re: [PATCH] kvm-pr: manage illegal instructions

2016-05-18 Thread Thomas Huth
On 18.05.2016 12:18, Thomas Huth wrote: > On 17.05.2016 19:49, Laurent Vivier wrote: >> >> >> On 17/05/2016 10:37, Alexander Graf wrote: >>> On 05/17/2016 10:35 AM, Laurent Vivier wrote: >>>> >>>> On 12/05/2016 16:23, Laurent Vivier wrote:

Re: [PATCH] kvm-pr: manage illegal instructions

2016-05-18 Thread Thomas Huth
On 18.05.2016 12:53, Thomas Huth wrote: > On 18.05.2016 12:18, Thomas Huth wrote: >> On 17.05.2016 19:49, Laurent Vivier wrote: >>> >>> >>> On 17/05/2016 10:37, Alexander Graf wrote: >>>> On 05/17/2016 10:35 AM, Laurent Vivier wrote: >&

Re: [PATCH v2] kvm-pr: manage single-step mode

2016-04-11 Thread Thomas Huth
OK3S_INTERRUPT_TRACE > > arch/powerpc/kvm/book3s_pr.c | 32 +++- > 1 file changed, 31 insertions(+), 1 deletion(-) Reviewed-by: Thomas Huth

Re: [PATCH] kvm-pr: manage single-step mode

2016-04-08 Thread Thomas Huth
On 22.03.2016 15:53, Laurent Vivier wrote: > Until now, when we connect gdb to the QEMU gdb-server, the > single-step mode is not managed. > > This patch adds this, only for kvm-pr: > > If KVM_GUESTDBG_SINGLESTEP is set, we enable single-step trace bit in the > MSR (MSR_SE) just before the

Re: [PATCH] kvm-pr: manage single-step mode

2016-04-08 Thread Thomas Huth
On 08.04.2016 08:58, Laurent Vivier wrote: > > > On 08/04/2016 08:23, Thomas Huth wrote: >> On 22.03.2016 15:53, Laurent Vivier wrote: >>> Until now, when we connect gdb to the QEMU gdb-server, the >>> single-step mode is not managed. >>>

Re: powerpc/pseries: start rtasd before PCI probing

2016-05-23 Thread Thomas Huth
> 1 file changed, 14 insertions(+), 5 deletions(-) By the way, same is true for device UNplugging: When unplugging devices in QEMU while the firmware is still running, they are never properly removed from the guest. I've checked it, and your patch fixes this problem as well! Great :-) Tested-by: Thomas Huth

Re: [PATCH v1 1/2] s390/kvm: split kvm_s390_real_to_abs

2021-03-19 Thread Thomas Huth
_kvm_s390_real_to_abs(u32 prefix, unsigned long gra) Just a matter of taste, but maybe this could be named differently? kvm_s390_real2abs_prefix() ? kvm_s390_prefix_real_to_abs()? Anyway: Reviewed-by: Thomas Huth

<    1   2   3