[PATCH] watchdog: bcm_kona_wdt: Use correct return value for bcm_kona_wdt_probe()

2020-05-25 Thread Tiezhu Yang
When call function devm_platform_ioremap_resource(), we should use IS_ERR() to check the return value and return PTR_ERR() if failed. Signed-off-by: Tiezhu Yang --- drivers/watchdog/bcm_kona_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog

Re: [PATCH 2/2] phy: Remove CONFIG_ARCH_ROCKCHIP check for subdir rockchip

2020-05-25 Thread Tiezhu Yang
On 05/25/2020 06:48 PM, Heiko Stübner wrote: Am Montag, 25. Mai 2020, 06:08:59 CEST schrieb Tiezhu Yang: If CONFIG_ARCH_ROCKCHIP is not set but COMPILE_TEST is set, the file in the subdir rockchip can not be built due to CONFIG_ARCH_ROCKCHIP check in drivers/phy/Makefile. Since the related

[PATCH v2 2/2] phy: Remove CONFIG_ARCH_* check for related subdir in Makefile

2020-05-25 Thread Tiezhu Yang
for subdir rockchip in drivers/phy/Makefile. The other CONFIG_ARCH_* about allwinner, amlogic, mediatek, renesas and tegra have the same situation, so remove them too. Signed-off-by: Tiezhu Yang --- v2: - Remove all the CONFIG_ARCH_* check for related subdir in Makefile - Modify the patch subject

[PATCH v2 1/2] phy: rockchip: Fix return value of inno_dsidphy_probe()

2020-05-25 Thread Tiezhu Yang
When call function devm_platform_ioremap_resource(), we should use IS_ERR() to check the return value and return PTR_ERR() if failed. Fixes: b7535a3bc0ba ("phy/rockchip: Add support for Innosilicon MIPI/LVDS/TTL PHY") Signed-off-by: Tiezhu Yang Reviewed-by: Heiko Stuebne

Re: [PATCH v4 2/2] clk: Allow COMPILE_TEST for subdir hisilicon in Makefile

2020-06-01 Thread Tiezhu Yang
the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Tiezhu-Yang/clk-hisilicon-Use-correct-return-value-about-hisi_reset_init/20200527-233606 base: https

[PATCH 2/2] perf tools: Remove some duplicated includes

2020-06-01 Thread Tiezhu Yang
There exists some duplicated includes in tools/perf, remove them. Signed-off-by: Tiezhu Yang --- tools/perf/builtin-report.c | 1 - tools/perf/util/annotate.c | 1 - tools/perf/util/auxtrace.c | 1 - tools/perf/util/config.c| 1 - tools/perf/util/session.c | 1 - 5 files changed, 5

[PATCH 1/2] perf tools: check libasan and libubsan in Makefile.config

2020-06-01 Thread Tiezhu Yang
an error log to reflect the reality. Signed-off-by: Tiezhu Yang --- tools/perf/Makefile.config | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index 12a8204..b699d21 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf

[PATCH 1/2] kernel/panic.c: Make oops_may_print() return bool

2020-06-02 Thread Tiezhu Yang
The return value of oops_may_print() is true or false, so change its type to reflect that. Signed-off-by: Tiezhu Yang --- include/linux/kernel.h | 2 +- kernel/panic.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/kernel.h b/include/linux/kernel.h

[PATCH 2/2] lib/Kconfig.debug: Fix typo in the help text of CONFIG_PANIC_TIMEOUT

2020-06-02 Thread Tiezhu Yang
There exists duplicated "the" in the help text of CONFIG_PANIC_TIMEOUT, remove it. Signed-off-by: Tiezhu Yang --- lib/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index b3b05ad..d33627a 100644 --- a/lib/Kco

Re: [PATCH 1/2] clk: hisilicon: Use correct return value about hisi_reset_init()

2020-05-26 Thread Tiezhu Yang
On 05/27/2020 07:02 AM, Stephen Boyd wrote: Quoting Tiezhu Yang (2020-05-24 20:31:55) The return value about hisi_reset_init() is not correct, fix it. Signed-off-by: Tiezhu Yang --- drivers/clk/hisilicon/clk-hi3519.c | 4 ++-- drivers/clk/hisilicon/crg-hi3516cv300.c | 4 ++-- drivers

Re: [PATCH 2/2] clk: Remove CONFIG_ARCH_HISI check for subdir hisilicon

2020-05-26 Thread Tiezhu Yang
the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Tiezhu-Yang/clk-hisilicon-Use-correct-return-value-about-hisi_reset_init/20200525-113342 base: https

[PATCH v2 1/2] clk: hisilicon: Use correct return value about hisi_reset_init()

2020-05-27 Thread Tiezhu Yang
The return value about hisi_reset_init() is not correct, fix it. Fixes: e9a2310fb689 ("reset: hisilicon: fix potential NULL pointer dereference") Signed-off-by: Tiezhu Yang --- v2: - No changes, just add "Fixes:" tag drivers/clk/hisilicon/clk-hi3519.c | 4 ++-- d

[PATCH v2 2/2] clk: Remove CONFIG_ARCH_HISI check for subdir hisilicon in Makefile

2020-05-27 Thread Tiezhu Yang
/hyperkitty/list/kbuild-...@lists.01.org/thread/AVXZQX33S7ZVVK7D5VKLTTH7MOBEEBNB/ Reported-by: kbuild test robot Signed-off-by: Tiezhu Yang --- v2: - Fix the build failure reported by kbuild test robot drivers/clk/Makefile | 2 +- drivers/clk/hisilicon/Makefile | 2 +- 2 files changed, 2

Re: [PATCH v4 1/2] clk: hisilicon: Use correct return value about hisi_reset_init()

2020-05-28 Thread Tiezhu Yang
On 05/29/2020 07:15 AM, Stephen Boyd wrote: Quoting Tiezhu Yang (2020-05-27 19:27:42) On 05/28/2020 03:06 AM, Stephen Boyd wrote: Quoting Tiezhu Yang (2020-05-27 07:39:21) The return value about hisi_reset_init() is not correct, fix it. Fixes: e9a2310fb689 ("reset: hisilicon: fix pote

Re: [PATCH v4 1/2] clk: hisilicon: Use correct return value about hisi_reset_init()

2020-05-28 Thread Tiezhu Yang
On 05/29/2020 11:58 AM, Stephen Boyd wrote: Quoting Tiezhu Yang (2020-05-28 19:03:54) On 05/29/2020 07:15 AM, Stephen Boyd wrote: Quoting Tiezhu Yang (2020-05-27 19:27:42) On 05/28/2020 03:06 AM, Stephen Boyd wrote: Quoting Tiezhu Yang (2020-05-27 07:39:21) The return value about

Re: [PATCH v4 1/2] clk: hisilicon: Use correct return value about hisi_reset_init()

2020-05-29 Thread Tiezhu Yang
On 05/29/2020 12:31 PM, Stephen Boyd wrote: Quoting Tiezhu Yang (2020-05-28 21:02:05) On 05/29/2020 11:58 AM, Stephen Boyd wrote: Quoting Tiezhu Yang (2020-05-28 19:03:54) On 05/29/2020 07:15 AM, Stephen Boyd wrote: Quoting Tiezhu Yang (2020-05-27 19:27:42) On 05/28/2020 03:06 AM, Stephen

Re: [PATCH v4 1/2] clk: hisilicon: Use correct return value about hisi_reset_init()

2020-05-29 Thread Tiezhu Yang
On 05/29/2020 05:36 PM, Stephen Boyd wrote: Quoting Tiezhu Yang (2020-05-28 23:44:20) On 05/29/2020 12:31 PM, Stephen Boyd wrote: Quoting Tiezhu Yang (2020-05-28 21:02:05) I think you didn't understand my question. I'm asking where is this patch applied to the kernel and what commit is it? I

[PATCH 2/3] fs: Introduce cmdline argument exceed_file_max_panic

2020-06-06 Thread Tiezhu Yang
p pipe: Too many open files in system bash: /usr/sbin/reboot: Too many open files in system Signed-off-by: Tiezhu Yang --- fs/file_table.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/fs/file_table.c b/fs/file_table.c index 26516d0..6943945 100644 --- a/fs/file_table.c +

[PATCH 1/3] fs: Use get_max_files() instead of files_stat.max_files in alloc_empty_file()

2020-06-06 Thread Tiezhu Yang
It is better to use get_max_files() instead of files_stat.max_files to improve readability. Signed-off-by: Tiezhu Yang --- fs/file_table.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/file_table.c b/fs/file_table.c index 656647f..26516d0 100644 --- a/fs

[PATCH 3/3] docs: admin-guide: Explain cmdline argument exceed_file_max_panic in fs.rst

2020-06-06 Thread Tiezhu Yang
Explain the cmdline argument exceed_file_max_panic in the file Documentation/admin-guide/sysctl/fs.rst Signed-off-by: Tiezhu Yang --- Documentation/admin-guide/sysctl/fs.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/admin-guide/sysctl/fs.rst b/Documentation/admin

[PATCH 3/3] irqchip/ti-sci-inta: Fix typo about MODULE_AUTHOR

2020-06-06 Thread Tiezhu Yang
It should be "ti.com" instead of "ticom". Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-ti-sci-inta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH 1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type()

2020-06-06 Thread Tiezhu Yang
In the function ti_sci_inta_set_type(), the statement "return -EINVAL;" out of switch case is dead code, remove it. Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-ti-sci-inta.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqc

[PATCH 2/3] irqchip/ti-sci-inta: Fix return value about devm_ioremap_resource()

2020-06-06 Thread Tiezhu Yang
When call function devm_ioremap_resource(), we should use IS_ERR() to check the return value and return PTR_ERR() if failed. Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-ti-sci-inta.c | 2

[PATCH] PCI: Add Loongson vendor ID and device IDs

2019-09-29 Thread Tiezhu Yang
Add the Loongson vendor ID and device IDs to pci_ids.h to be used in the future. The Loongson IDs can be found at the following link: https://git.kernel.org/pub/scm/utils/pciutils/pciutils.git/tree/pci.ids Co-developed-by: Lu Zeng Signed-off-by: Lu Zeng Signed-off-by: Tiezhu Yang

Re: [PATCH] PCI: Add Loongson vendor ID and device IDs

2019-09-30 Thread Tiezhu Yang
On 09/30/2019 10:02 PM, Andrew Murray wrote: On Mon, Sep 30, 2019 at 12:55:20PM +0800, Tiezhu Yang wrote: Add the Loongson vendor ID and device IDs to pci_ids.h to be used in the future. The Loongson IDs can be found at the following link: https://git.kernel.org/pub/scm/utils/pciutils

Re: [PATCH] PCI: Add Loongson vendor ID and device IDs

2019-10-01 Thread Tiezhu Yang
On 10/01/2019 08:50 PM, Bjorn Helgaas wrote: On Tue, Oct 01, 2019 at 10:53:44AM +0800, Tiezhu Yang wrote: On 09/30/2019 10:02 PM, Andrew Murray wrote: On Mon, Sep 30, 2019 at 12:55:20PM +0800, Tiezhu Yang wrote: Add the Loongson vendor ID and device IDs to pci_ids.h to be used in the future

[PATCH] MIPS: generic: Use __initconst for const init data

2019-10-08 Thread Tiezhu Yang
*mach; ERROR: Use of const init definition must use __initconst +static __initdata const void *mach_match_data; Signed-off-by: Tiezhu Yang --- arch/mips/generic/init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/mips/generic/init.c b/arch/mips/generic/init.c

[PATCH v2] MIPS: generic: Use __initconst for const init data

2019-10-08 Thread Tiezhu Yang
based board support") Signed-off-by: Tiezhu Yang --- v2: update the commit message and use the 'Fixes:' tag arch/mips/generic/init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/mips/generic/init.c b/arch/mips/generic/init.c index d5b8c47..1de215b 100644 --- a

[PATCH] net: stmmac: Remove break after a return

2019-10-09 Thread Tiezhu Yang
Since break is not useful after a return, remove it. Fixes: 3b57de958e2a ("net: stmmac: Support devicetree configs for mcast and ucast filter entries") Signed-off-by: Tiezhu Yang --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 2 -- 1 file changed, 2 deletions(-)

Re: [PATCH] MIPS: tools: Show result for loongson3-llsc-check

2020-05-01 Thread Tiezhu Yang
On 05/01/2020 05:48 PM, Sergei Shtylyov wrote: Hello! On 30.04.2020 15:36, Tiezhu Yang wrote: It is better to show the result before loongson3-llsc-check exit, otherwise we can see nothing if the return status is EXIT_SUCCESS, it seems confusing. E.g. without this patch: [loongson

[PATCH v2] MIPS: tools: Show result for loongson3-llsc-check

2020-05-01 Thread Tiezhu Yang
: [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux loongson3-llsc-check returns success [loongson@localhost tools]$ Signed-off-by: Tiezhu Yang --- v2: - move "returns" after "loongson3-llsc-check" suggested by Sergei arch/mips/tools/loongson3-llsc-check.c |

[PATCH] MIPS: tools: Move "returns" after "loongson3-llsc-check"

2020-05-02 Thread Tiezhu Yang
Just move "returns" after "loongson3-llsc-check", no function changes. Signed-off-by: Tiezhu Yang --- arch/mips/tools/loongson3-llsc-check.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/tools/loongson3-llsc-check.c b/arch/mips/tools/lo

[PATCH v5] MIPS: Loongson: Add DMA support for LS7A

2020-04-29 Thread Tiezhu Yang
and then set the bus's DMA limit to 36 bit for RS780E to maintain downward compatibility. Signed-off-by: Tiezhu Yang --- Hi Christoph and Jiaxun, Thank you very much for your suggestions. v5: - use the default implementation of __phys_to_dma() and __dma_to_phys() in dma-direct.h arch

Re: [PATCH v5] MIPS: Loongson: Add DMA support for LS7A

2020-04-29 Thread Tiezhu Yang
Sorry, I can not receive email today due to some unknown reason, so I use the "mailto: link" in the Linux-MIPS Archive to reply. > Please use alpha-betical order here, which means put ls7a things > before rs780 things. OK, thanks. I will modify it and send v6. > Why use a hardcoded 37? LS7A's

[PATCH v6] MIPS: Loongson: Add DMA support for LS7A

2020-04-29 Thread Tiezhu Yang
and then set the bus's DMA limit to 36 bit for RS780E to maintain downward compatibility. Signed-off-by: Tiezhu Yang --- Hi Christoph and Jiaxun, Thank you very much for your suggestions. v5: - use the default implementation of __phys_to_dma() and __dma_to_phys() in dma-direct.h v6

[PATCH] MIPS: tools: Show result for loongson3-llsc-check

2020-04-30 Thread Tiezhu Yang
: [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux loongson3-llsc-check returns success [loongson@localhost tools]$ Signed-off-by: Tiezhu Yang --- arch/mips/tools/loongson3-llsc-check.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/tools/loongson3-llsc-check.c b

[PATCH] MIPS: Loongson: Make default kernel log buffer size as 128KB for Loongson3

2019-10-14 Thread Tiezhu Yang
. Signed-off-by: Tiezhu Yang --- arch/mips/configs/loongson3_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/configs/loongson3_defconfig b/arch/mips/configs/loongson3_defconfig index 90ee008..3aa2201 100644 --- a/arch/mips/configs/loongson3_defconfig +++ b

Re: [PATCH] MIPS: Loongson: Make default kernel log buffer size as 128KB for Loongson3

2019-10-14 Thread Tiezhu Yang
On 10/15/2019 11:36 AM, Huacai Chen wrote: On Tue, Oct 15, 2019 at 10:12 AM Tiezhu Yang wrote: When I update kernel with loongson3_defconfig based on the Loongson 3A3000 platform, then using dmesg command to show kernel ring buffer, the initial kernel messages have disappeared due to the log

[PATCH v2] MIPS: Loongson: Make default kernel log buffer size as 256KB for Loongson3

2019-10-14 Thread Tiezhu Yang
. Signed-off-by: Tiezhu Yang --- v2: modify the default kernel log buffer size to 256KB suggested by Huacai arch/mips/configs/loongson3_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/configs/loongson3_defconfig b/arch/mips/configs/loongson3_defconfig index

Re: [PATCH] MIPS: Loongson: Make default kernel log buffer size as 128KB for Loongson3

2019-10-15 Thread Tiezhu Yang
On 10/16/2019 02:53 AM, Paul Burton wrote: Hi Tiezhu & Huacai, On Tue, Oct 15, 2019 at 12:00:25PM +0800, Tiezhu Yang wrote: On 10/15/2019 11:36 AM, Huacai Chen wrote: On Tue, Oct 15, 2019 at 10:12 AM Tiezhu Yang wrote: When I update kernel with loongson3_defconfig based on the Loon

[PATCH v3] MIPS: Loongson: Make default kernel log buffer size as 128KB for Loongson3

2019-10-16 Thread Tiezhu Yang
is enough to save the boot messages. Since the default LOG_BUF_SHIFT value is 17, the default kernel log buffer size is 128KB, just delete the CONFIG_LOG_BUF_SHIFT line. Signed-off-by: Tiezhu Yang --- v3: use the default LOG_BUF_SHIFT value 17 and update the commit message arch/mips/configs

Re: [PATCH bpf-next v2] Documentation/bpf: Use valid and new links in index.rst

2020-07-29 Thread Tiezhu Yang
On 07/30/2020 05:06 AM, Song Liu wrote: On Wed, Jul 29, 2020 at 6:17 AM Tiezhu Yang wrote: There exists an error "404 Not Found" when I click the html link of "Documentation/networking/filter.rst" in the BPF documentation [1], fix it. Additionally, use the new link

[PATCH bpf-next v3] Documentation/bpf: Use valid and new links in index.rst

2020-07-31 Thread Tiezhu Yang
tps://www.kernel.org/doc/html/latest/bpf/ Fixes: d9b9170a2653 ("docs: bpf: Rename README.rst to index.rst") Fixes: cb3f0d56e153 ("docs: networking: convert filter.txt to ReST") Signed-off-by: Tiezhu Yang --- Documentation/bpf/index.rst | 12 ++-- Documentation/

Re: [PATCH 1/7] irqchip: Fix potential resource leaks

2020-06-23 Thread Tiezhu Yang
On 06/23/2020 11:55 PM, Markus Elfring wrote: There exists some potential resource leaks in the error path, fix them. Will the tag “Fixes” become relevant for the commit message? Hi Markus, Thanks for your reply and suggestion. This patch contains many files in drivers/irqchip, maybe I

[PATCH v2 11/14] irqchip/omap-intc: Fix potential resource leak

2020-06-24 Thread Tiezhu Yang
There exists potential resource leak in the error path, fix it. Fixes: 8598066cddd1 ("arm: omap: irq: move irq.c to drivers/irqchip/") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-omap-intc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/irqchi

[PATCH v2 08/14] irqchip/ls1x: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-ls1x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i

[PATCH v2 02/14] irqchip/csky-apb-intc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: edff1b4835b7 ("irqchip: add C-SKY APB bus interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-csky-apb-intc.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[PATCH v2 04/14] irqchip/davinci-aintc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 0145beed9d26 ("irqchip: davinci-aintc: move the driver to drivers/irqchip") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-davinci-aintc.c | 17 + 1 file changed, 13 insertions(+), 4

[PATCH v2 07/14] irqchip/dw-apb-ictl: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 350d71b94fc9 ("irqchip: add DesignWare APB ICTL interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-dw-apb-ictl.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-)

[PATCH v2 13/14] irqchip/s3c24xx: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: f0774d41da0e ("irqchip: s3c24xx: add devicetree support") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-s3c24xx.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git

[PATCH v2 10/14] irqchip/nvic: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 292ec080491d ("irqchip: Add support for ARMv7-M NVIC") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-nvic.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/

[PATCH v2 12/14] irqchip/riscv-intc: Fix potential resource leak

2020-06-24 Thread Tiezhu Yang
There exists potential resource leak in the error path, fix it. Fixes: 6b7ce8927b5a ("irqchip: RISC-V per-HART local interrupt controller driver") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-riscv-intc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip

[PATCH v2 14/14] irqchip/xilinx-intc: Fix potential resource leak

2020-06-24 Thread Tiezhu Yang
There exists potential resource leak in the error path, fix it. Fixes: 9689c99e4950 ("irqchip/xilinx: Add support for parent intc") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-xilinx-intc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/

[PATCH v2 09/14] irqchip/mscc-ocelot: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 19d99164480a ("irqchip: Add a driver for the Microsemi Ocelot controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-mscc-ocelot.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[PATCH v2 01/14] irqchip/ath79-misc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 07ba4b061a79 ("irqchip/ath79-misc: Move the MISC driver from arch/mips/ath79/") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-ath79-misc.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletion

[PATCH v2 00/14] irqchip: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
Fixes" tag - Use "goto" label to handle error path in some patches Tiezhu Yang (14): irqchip/ath79-misc: Fix potential resource leaks irqchip/csky-apb-intc: Fix potential resource leaks irqchip/csky-mpintc: Fix potential resource leaks irqchip/davinci-aintc: Fix pote

[PATCH v2 2/7] irqchip/loongson-htpic: Remove unneeded select of I8259

2020-06-24 Thread Tiezhu Yang
LOONGSON_HTPIC depends on MACH_LOONGSON64 and MACH_LOONGSON64 already selects I8259 in arch/mips/Kconfig, so no need to select I8259 again when config LOONGSON_HTPIC. Signed-off-by: Tiezhu Yang --- drivers/irqchip/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/irqchip

[PATCH v2 3/7] irqchip/loongson-htvec: Fix potential resource leak

2020-06-24 Thread Tiezhu Yang
There exists potential resource leak in the error path, fix it. Fixes: 818e915fbac5 ("irqchip: Add Loongson HyperTransport Vector support") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-loongson-htvec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH v2 0/7] irqchip: Fix some issues and do some code cleanups about Loongson

2020-06-24 Thread Tiezhu Yang
Fixes" tag Tiezhu Yang (7): irqchip/loongson-htpic: Remove redundant kfree operation irqchip/loongson-htpic: Remove unneeded select of I8259 irqchip/loongson-htvec: Fix potential resource leak irqchip/loongson-htvec: Check return value of irq_domain_translate_onecell() irqchip/lo

[PATCH v2 1/7] irqchip/loongson-htpic: Remove redundant kfree operation

2020-06-24 Thread Tiezhu Yang
In the function htpic_of_init(), when kzalloc htpic fails, it should return -ENOMEM directly, no need to execute "goto" to kfree. Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-loongson-htpic.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i

[PATCH v2 06/14] irqchip/digicolor: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 8041dfbd31cf ("irqchip: Conexant CX92755 interrupts controller driver") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-digicolor.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-)

[PATCH v2 05/14] irqchip/davinci-cp-intc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 0fc3d74cf946 ("irqchip: davinci-cp-intc: move the driver to drivers/irqchip") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-davinci-cp-intc.c | 17 ++--- 1 file changed, 14 insertions(+), 3

[PATCH v2 03/14] irqchip/csky-mpintc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: d8a5f5f79122 ("irqchip: add C-SKY SMP interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-csky-mpintc.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-)

[PATCH v2 0/7 RESEND] irqchip: Fix some issues and do some code cleanups about Loongson

2020-06-24 Thread Tiezhu Yang
about Loongson into a new patch series and add "Fixes" tag Tiezhu Yang (7): irqchip/loongson-htpic: Remove redundant kfree operation irqchip/loongson-htpic: Remove unneeded select of I8259 irqchip/loongson-htvec: Fix potential resource leak irqchip/loongson-htvec: Check re

[PATCH v2 4/7 RESEND] irqchip/loongson-htvec: Check return value of irq_domain_translate_onecell()

2020-06-24 Thread Tiezhu Yang
Check the return value of irq_domain_translate_onecell() due to it may returns -EINVAL if failed. Fixes: 818e915fbac5 ("irqchip: Add Loongson HyperTransport Vector support") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-loongson-htvec.c | 5 - 1 file changed, 4 insert

[PATCH v2 6/7 RESEND] irqchip/loongson-pch-msi: Remove unneeded variable

2020-06-24 Thread Tiezhu Yang
irq_domain_alloc_irqs_parent() returns 0 on success and non-zero value on failure, it is redudant to check its non-zero return value and then return it, so just remove the variable "ret" and return directly in the function pch_msi_parent_domain_alloc(). Signed-off-by: Tiezhu Yang --

[PATCH v2 5/7 RESEND] irqchip/loongson-pch-pic: Check return value of irq_domain_translate_twocell()

2020-06-24 Thread Tiezhu Yang
t;) Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-loongson-pch-pic.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/irqchip/irq-loongson-pch-pic.c b/drivers/irqchip/irq-loongson-pch-pic.c index 2a05b93..016f32c 100644 --- a/drivers/irqchip/irq-lo

[PATCH v2 7/7 RESEND] dt-bindings: interrupt-controller: Fix typos in loongson,liointc.yaml

2020-06-24 Thread Tiezhu Yang
Fix the following two typos in loongson,liointc.yaml: fron -> from it's -> its Fixes: b6280c8bb6f5 ("dt-bindings: interrupt-controller: Add Loongson LIOINTC") Signed-off-by: Tiezhu Yang --- .../devicetree/bindings/interrupt-controller/loongson,liointc.yaml| 4 ++-- 1

[PATCH v2 2/7 RESEND] irqchip/loongson-htpic: Remove unneeded select of I8259

2020-06-24 Thread Tiezhu Yang
LOONGSON_HTPIC depends on MACH_LOONGSON64 and MACH_LOONGSON64 already selects I8259 in arch/mips/Kconfig, so no need to select I8259 again when config LOONGSON_HTPIC. Signed-off-by: Tiezhu Yang --- drivers/irqchip/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/irqchip

[PATCH v2 1/7 RESEND] irqchip/loongson-htpic: Remove redundant kfree operation

2020-06-24 Thread Tiezhu Yang
In the function htpic_of_init(), when kzalloc htpic fails, it should return -ENOMEM directly, no need to execute "goto" to kfree. Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-loongson-htpic.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i

[PATCH v2 3/7 RESEND] irqchip/loongson-htvec: Fix potential resource leak

2020-06-24 Thread Tiezhu Yang
There exists potential resource leak in the error path, fix it. Fixes: 818e915fbac5 ("irqchip: Add Loongson HyperTransport Vector support") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-loongson-htvec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH v3 09/14] irqchip/mscc-ocelot: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 19d99164480a ("irqchip: Add a driver for the Microsemi Ocelot controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-mscc-ocelot.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[PATCH v3 02/14] irqchip/csky-apb-intc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: edff1b4835b7 ("irqchip: add C-SKY APB bus interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-csky-apb-intc.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[PATCH v3 03/14] irqchip/csky-mpintc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: d8a5f5f79122 ("irqchip: add C-SKY SMP interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-csky-mpintc.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-)

[PATCH v3 05/14] irqchip/davinci-cp-intc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 0fc3d74cf946 ("irqchip: davinci-cp-intc: move the driver to drivers/irqchip") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-davinci-cp-intc.c | 18 +++--- 1 file changed, 15 insertions(+), 3

[PATCH v3 00/14] irqchip: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
Fixes" tag - Use "goto" label to handle error path in some patches v3: - Add missed variable "ret" in the patch #5 and #13, sorry for that Tiezhu Yang (14): irqchip/ath79-misc: Fix potential resource leaks irqchip/csky-apb-intc: Fix potential resource le

[PATCH v3 04/14] irqchip/davinci-aintc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 0145beed9d26 ("irqchip: davinci-aintc: move the driver to drivers/irqchip") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-davinci-aintc.c | 17 + 1 file changed, 13 insertions(+), 4

[PATCH v3 01/14] irqchip/ath79-misc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 07ba4b061a79 ("irqchip/ath79-misc: Move the MISC driver from arch/mips/ath79/") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-ath79-misc.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletion

[PATCH v3 07/14] irqchip/dw-apb-ictl: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 350d71b94fc9 ("irqchip: add DesignWare APB ICTL interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-dw-apb-ictl.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-)

[PATCH v3 10/14] irqchip/nvic: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 292ec080491d ("irqchip: Add support for ARMv7-M NVIC") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-nvic.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/

[PATCH v3 08/14] irqchip/ls1x: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-ls1x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i

[PATCH v3 11/14] irqchip/omap-intc: Fix potential resource leak

2020-06-24 Thread Tiezhu Yang
There exists potential resource leak in the error path, fix it. Fixes: 8598066cddd1 ("arm: omap: irq: move irq.c to drivers/irqchip/") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-omap-intc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/irqchi

[PATCH v3 06/14] irqchip/digicolor: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 8041dfbd31cf ("irqchip: Conexant CX92755 interrupts controller driver") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-digicolor.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-)

[PATCH v3 02/14 RESEND] irqchip/csky-apb-intc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: edff1b4835b7 ("irqchip: add C-SKY APB bus interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-csky-apb-intc.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[PATCH v3 01/14 RESEND] irqchip/ath79-misc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 07ba4b061a79 ("irqchip/ath79-misc: Move the MISC driver from arch/mips/ath79/") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-ath79-misc.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletion

[PATCH v3 03/14 RESEND] irqchip/csky-mpintc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: d8a5f5f79122 ("irqchip: add C-SKY SMP interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-csky-mpintc.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-)

[PATCH v3 09/14 RESEND] irqchip/mscc-ocelot: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 19d99164480a ("irqchip: Add a driver for the Microsemi Ocelot controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-mscc-ocelot.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
to fix them. v2: - Split the first patch into a new patch series which includes small patches and add "Fixes" tag - Use "goto" label to handle error path in some patches v3: - Add missed variable "ret" in the patch #5 and #13, sorry for that Tiezhu Y

[PATCH v3 07/14 RESEND] irqchip/dw-apb-ictl: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 350d71b94fc9 ("irqchip: add DesignWare APB ICTL interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-dw-apb-ictl.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-)

[PATCH v3 10/14 RESEND] irqchip/nvic: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 292ec080491d ("irqchip: Add support for ARMv7-M NVIC") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-nvic.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/

[PATCH v3 11/14 RESEND] irqchip/omap-intc: Fix potential resource leak

2020-06-24 Thread Tiezhu Yang
There exists potential resource leak in the error path, fix it. Fixes: 8598066cddd1 ("arm: omap: irq: move irq.c to drivers/irqchip/") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-omap-intc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/irqchi

[PATCH v3 08/14 RESEND] irqchip/ls1x: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-ls1x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i

[PATCH v3 05/14 RESEND] irqchip/davinci-cp-intc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 0fc3d74cf946 ("irqchip: davinci-cp-intc: move the driver to drivers/irqchip") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-davinci-cp-intc.c | 18 +++--- 1 file changed, 15 insertions(+), 3

[PATCH v3 06/14 RESEND] irqchip/digicolor: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 8041dfbd31cf ("irqchip: Conexant CX92755 interrupts controller driver") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-digicolor.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-)

[PATCH v3 04/14 RESEND] irqchip/davinci-aintc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 0145beed9d26 ("irqchip: davinci-aintc: move the driver to drivers/irqchip") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-davinci-aintc.c | 17 + 1 file changed, 13 insertions(+), 4

Re: [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
On 06/24/2020 04:30 PM, Marc Zyngier wrote: On 2020-06-24 08:44, Tiezhu Yang wrote: [git send-email failed due to too many commands, so only cc the major related email and resend it, sorry for that] This is becoming majorly annoying. Please fix your git setup *before* dumping 57 emails

Re: [PATCH v2 7/7 RESEND] dt-bindings: interrupt-controller: Fix typos in loongson,liointc.yaml

2020-06-24 Thread Tiezhu Yang
On 06/24/2020 04:42 PM, Sergei Shtylyov wrote: Hello! On 24.06.2020 9:45, Tiezhu Yang wrote: Fix the following two typos in loongson,liointc.yaml: fron -> from it's -> its Fixes: b6280c8bb6f5 ("dt-bindings: interrupt-controller: Add Loongson LIOINTC") Signed-off

Re: [1/7] irqchip: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
On 06/24/2020 04:42 PM, Markus Elfring wrote: Can it helpful to add jump targets so that a bit of exception handling can be better reused at the end of this function? OK, no problem, I will do it in the v2. It seems that the software evolution will be continued with another update suggestion

Re: [PATCH 1/7] irqchip: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
On 06/24/2020 05:15 PM, Krzysztof Kozlowski wrote: On Tue, 23 Jun 2020 at 10:51, Tiezhu Yang wrote: There exists some potential resource leaks in the error path, fix them. This should be split per driver and per bug (although mostly in driver it's just one bug). Otherwise it is difficult

Re: [1/7] irqchip: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
On 06/24/2020 05:23 PM, Markus Elfring wrote: [PATCH v3 10/14 RESEND] irqchip/nvic: Fix potential resource leaks https://lore.kernel.org/linux-mips/1592984711-3130-11-git-send-email-yangtie...@loongson.cn/ https://lore.kernel.org/patchwork/patch/1263191/ Can it matter to omit the word

<    1   2   3   4   5   6   >