On 06/24/2020 06:06 PM, Markus Elfring wrote:
Were any known software analysis tools involved for the detection of
questionable source code places?
kmemleak can detect memory leak,
but I do not know how to detect other kind of leaks.
How do you think about to extend source code analysis tools
On 06/24/2020 05:02 PM, Tiezhu Yang wrote:
On 06/24/2020 04:30 PM, Marc Zyngier wrote:
On 2020-06-24 08:44, Tiezhu Yang wrote:
[git send-email failed due to too many commands,
so only cc the major related email and resend it,
sorry for that]
This is becoming majorly annoying. Please fix
On 06/24/2020 07:43 PM, Markus Elfring wrote:
There exists potential resource leaks in the error path, fix them.
I suggest to improve this change description.
How do you think about another wording variant?
Specific system resources were not released in a few error cases.
Thus add jump
In the current code, we can not see the PCI info after fixup which is
correct to reflect the reality, it is better to move pci_info() after
pci_fixup_device() in pci_setup_device().
Signed-off-by: Tiezhu Yang
---
drivers/pci/probe.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
Currently, acpi.info is an invalid link to access ACPI specification,
the new valid link is https://uefi.org/specifications.
Signed-off-by: Tiezhu Yang
---
Documentation/hwmon/acpi_power_meter.rst | 2 +-
drivers/acpi/Kconfig | 3 +--
include/linux/tboot.h
tps://www.kernel.org/doc/html/latest/bpf/
Fixes: d9b9170a2653 ("docs: bpf: Rename README.rst to index.rst")
Fixes: cb3f0d56e153 ("docs: networking: convert filter.txt to ReST")
Signed-off-by: Tiezhu Yang
---
Documentation/bpf/index.rst | 6 +++---
1 file changed, 3 insertions(+)
tps://www.kernel.org/doc/html/latest/bpf/
Fixes: d9b9170a2653 ("docs: bpf: Rename README.rst to index.rst")
Fixes: cb3f0d56e153 ("docs: networking: convert filter.txt to ReST")
Signed-off-by: Tiezhu Yang
---
v2:
- Fix a typo "clik" to "click" in the commit mes
On 07/14/2020 11:08 PM, Lorenzo Pieralisi wrote:
On Tue, Jul 14, 2020 at 03:37:51PM +0800, Tiezhu Yang wrote:
On 06/12/2020 09:30 AM, Tiezhu Yang wrote:
Use DECLARE_PCI_FIXUP_EARLY instead of DECLARE_PCI_FIXUP_HEADER
for bridge_class_quirk() in pci-loongson.c, otherwise the fixup
has no effect
ixup_class);
Fixes: 1f58cca5cf2b ("PCI: Add Loongson PCI Controller support")
Signed-off-by: Tiezhu Yang
---
v2: Modify the patch subject used with lower case "loongson"
v3: Update the commit message
drivers/pci/controller/pci-loongson.c | 6 +++---
1 file changed, 3 insertio
EARLY(PCI_VENDOR_ID_BROADCOM,
0x8012, bcma_pcie2_fixup_class);
Fixes: 1f58cca5cf2b ("PCI: Add Loongson PCI Controller support")
Signed-off-by: Tiezhu Yang
---
v2: Modify the patch subject used with lower case "loongson"
v3: Update the commit message
drivers/pci/controller/pc
irq_domain_alloc_irqs_parent() returns 0 on success and non-zero value
on failure, it is redudant to check its non-zero return value and then
return it, so just remove the variable "ret" and return directly in the
function pch_msi_parent_domain_alloc().
Signed-off-by: Tiezhu Yang
--
Fix the following typos in loongson,liointc.yaml:
children -> child
fron -> from
connected -> connect
it's -> its
Fixes: b6280c8bb6f5 ("dt-bindings: interrupt-controller: Add Loongson LIOINTC")
Signed-off-by: Tiezhu Yang
Cc: Rob Herring
Cc: devicet...@vger.kernel.o
In the function htvec_of_init(), system resource "parent_irq"
was not released in an error case. Thus add a jump target for
the completion of the desired exception handling.
Fixes: 818e915fbac5 ("irqchip: Add Loongson HyperTransport Vector support")
Signed-off-by: Tiezh
LOONGSON_HTPIC depends on MACH_LOONGSON64 and MACH_LOONGSON64 already
selects I8259 in arch/mips/Kconfig, so no need to select I8259 again
when config LOONGSON_HTPIC.
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/irqchip
Check the return value of irq_domain_translate_onecell() due to
it may returns -EINVAL if failed.
Fixes: 818e915fbac5 ("irqchip: Add Loongson HyperTransport Vector support")
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-loongson-htvec.c | 5 -
1 file changed, 4 insert
In the function htpic_of_init(), when kzalloc htpic fails, it should
return -ENOMEM directly, no need to execute "goto" to kfree.
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-loongson-htpic.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/i
Loongson into a new patch series and add "Fixes" tag
v3:
- Add a new patch "irqchip/loongson-liointc: Fix potential dead lock"
- Fix another typo in loongson,liointc.yaml
v4:
- Fix another typo in loongson,liointc.yaml reviewed by Rob
Tiezhu Yang (8):
irqchip/loongson-htp
In the function liointc_set_type(), we need to call the function
irq_gc_unlock_irqrestore() before returning.
Fixes: dbb152267908 ("irqchip: Add driver for Loongson I/O Local Interrupt
Controller")
Reported-by: Jianmin Lv
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-loongson
t;)
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-loongson-pch-pic.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/irqchip/irq-loongson-pch-pic.c
b/drivers/irqchip/irq-loongson-pch-pic.c
index 2a05b93..016f32c 100644
--- a/drivers/irqchip/irq-lo
On 07/18/2020 08:04 AM, YunQiang Su wrote:
Maciej W. Rozycki 于2020年7月17日周五 下午6:00写道：
On Wed, 8 Jul 2020, Tiezhu Yang wrote:
In the MIPS architecture, we should clear the security-relevant
flag READ_IMPLIES_EXEC in the function SET_PERSONALITY2() of the
file arch/mips/include/asm/elf.h
on pci_setup_device(), the related code about
"dev->class" such as "class = dev->class >> 8;" and "dev->transparent
= ((dev->class & 0xff) == 1);" maybe get wrong value due to without
EARLY fixup.
Fixes: 1f58cca5cf2b ("PCI: Add Loongson PCI Controller
on pci_setup_device(), the related code about
"dev->class" such as "class = dev->class >> 8;" and "dev->transparent
= ((dev->class & 0xff) == 1);" maybe get wrong value without EARLY fixup.
Fixes: 1f58cca5cf2b ("PCI: Add Loongson PCI Controller
Since test_lockup is a test module to generate lockups, it is better to
limit TEST_LOCKUP to module (=m) or disabled (=n) because we can not use
the module parameters when CONFIG_TEST_LOCKUP=y.
Signed-off-by: Tiezhu Yang
---
lib/Kconfig.debug | 1 +
1 file changed, 1 insertion(+)
diff --git
parameter (see dmesg)
[root@localhost loongson]# dmesg | tail -1
[ 95.134362] test_lockup: failed to open no_such_file: -2
Fixes: aecd42df6d39 ("lib/test_lockup.c: add parameters for locking generic vfs
locks")
Signed-off-by: Tiezhu Yang
---
lib/test_lockup.c | 4 ++--
1 file
At 2019-06-21 00:39:00, "Borislav Petkov" wrote:
>On Sat, Jun 15, 2019 at 07:18:20AM +0800, Tiezhu Yang wrote:
>> This patch fixes the following sparse warning:
>
>Avoid having "This patch" or "This commit" in the commit message. It is
>t
call")
Signed-off-by: Tiezhu Yang
Cc: Vivek Goyal
---
arch/x86/kernel/crash.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
index 576b2e1..f13480e 100644
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -
At 2019-06-24 09:53:59, "Dave Young" wrote:
>On 06/24/19 at 09:35am, Dave Young wrote:
>> On 06/23/19 at 06:24am, Tiezhu Yang wrote:
>> > Fix the following sparse warning:
>> >
>> > arch/x86/kernel/crash.c:59:15:
>> > warning: symbol '
,
if CONFIG_KEXEC_FILE is not set, the following warning will appear:
arch/x86/kernel/crash.c:59:22:
warning: ‘crash_zero_bytes’ defined but not used [-Wunused-variable]
Fixes: dd5f726076cc ("kexec: support for kexec on panic using new system call")
Signed-off-by: Tiezhu Yang
Cc: Vivek Goyal
---
"mips: remove needless include of module.h from core
kernel files.")
Signed-off-by: Tiezhu Yang
---
arch/mips/kernel/8250-platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/kernel/8250-platform.c b/arch/mips/kernel/8250-platform.c
index 5c6b2ab..cbf3fe2 100644
---
1.920405] [drm:r600_init] *ERROR* Failed to load firmware!
[1.926069] radeon :01:05.0: Fatal error during GPU init
[1.931729] [drm] radeon: finishing device.
Fixes: 024e6a8b5bb1 ("MIPS: Loongson: Add a Loongson-3 default config file")
Signed-off-by: Tiezhu Yang
---
arch/mips/configs
On 05/15/2020 10:33 AM, Jiaxun Yang wrote:
于 2020年5月15日 GMT+08:00 上午10:15:00, Tiezhu Yang 写到:
When ATI Radeon graphics card has been compiled directly into the kernel
instead of as a module, we should make sure the firmware for the model
(check available ones in /lib/firmware/radeon) is built
1.920405] [drm:r600_init] *ERROR* Failed to load firmware!
[1.926069] radeon :01:05.0: Fatal error during GPU init
[1.931729] [drm] radeon: finishing device.
Fixes: 024e6a8b5bb1 ("MIPS: Loongson: Add a Loongson-3 default config file")
Signed-off-by: Tiezhu Yang
---
v2:
- Modi
"mips: remove needless include of module.h from core
kernel files.")
Signed-off-by: Tiezhu Yang
---
v2:
- No changes
arch/mips/kernel/8250-platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/kernel/8250-platform.c b/arch/mips/kernel/8250-platform.c
index 5c6b2a
On 05/15/2020 03:39 PM, Thomas Bogendoerfer wrote:
On Fri, May 15, 2020 at 11:23:05AM +0800, Tiezhu Yang wrote:
When CONFIG_HAVE_STD_PC_SERIAL_PORT is set, include linux/module.h to fix
the following build errors:
how are you doing this ? To me it looks like this CONFIG option isn't
used
On 05/15/2020 04:19 PM, Jiaxun Yang wrote:
于 2020年5月15日 GMT+08:00 下午3:54:46, Tiezhu Yang 写到:
On 05/15/2020 03:39 PM, Thomas Bogendoerfer wrote:
On Fri, May 15, 2020 at 11:23:05AM +0800, Tiezhu Yang wrote:
When CONFIG_HAVE_STD_PC_SERIAL_PORT is set, include linux/module.h to fix
On 05/15/2020 04:51 PM, Sergei Shtylyov wrote:
Hello!
On 15.05.2020 5:15, Tiezhu Yang wrote:
When ATI Radeon graphics card has been compiled directly into the kernel
^ driver
Hi Sergei,
Thanks for your review, I have been sent v2 with the updated commit
remove the not used file 8250-platform.c and
the related code in Kconfig and Makefile.
Signed-off-by: Tiezhu Yang
---
v2:
- No changes
v3:
- Remove not used 8250-platform.c
arch/mips/Kconfig| 3 ---
arch/mips/kernel/8250-platform.c | 46
1.920405] [drm:r600_init] *ERROR* Failed to load firmware!
[1.926069] radeon :01:05.0: Fatal error during GPU init
[1.931729] [drm] radeon: finishing device.
Fixes: 024e6a8b5bb1 ("MIPS: Loongson: Add a Loongson-3 default config file")
Signed-off-by: Tiezhu Yang
---
v2:
- Modi
e the following boot message:
[1.877745] printk: console [ttyS0] disabled
[1.881979] 1fe001e0.serial: ttyS0 at MMIO 0x1fe001e0 (irq = 16, base_baud =
2062500) is a 16550A
[1.890838] printk: console [ttyS0] enabled
And also, we can login normally from the serial console.
Signed-off-by:
On 05/08/2020 08:51 PM, WANG Xuerui wrote:
On 2020/5/8 19:55, Tiezhu Yang wrote:
Add PRID_IMP_LOONGSON_64G case to enable hwmon support for Loongson
generic CPU such as 3A4000 and newer CPU.
Signed-off-by: Tiezhu Yang
---
drivers/platform/mips/cpu_hwmon.c | 1 +
1 file changed, 1
v2:
- Drop the patch "MIPS: Loongson: Add hwmon support for generic CPU"
- Reduce possible loop times in do_thermal_timer()
Tiezhu Yang (2):
MIPS: Loongson: Cleanup cpu_hwmon.c
MIPS: Loongson: Reduce possible loop times and add log in
do_thermal_timer()
drivers/pla
Once the temperature of any CPUs is too high, it can power off immediately,
no need to check the rest of CPUs, and it is better to print a log before
power off, this is useful when analysis the abnormal issues.
Signed-off-by: Tiezhu Yang
---
v2:
- Reduce possible loop times
Fix the following checkpatch warnings and errors:
ERROR: do not initialise statics to 0
#14: FILE: drivers/platform/mips/cpu_hwmon.c:14:
+static int csr_temp_enable = 0;
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal
permissions '0444'.
#60: FILE:
On 05/09/2020 05:52 PM, Huacai Chen wrote:
Hi, Tiezhu,
On Sat, May 9, 2020 at 3:13 PM Tiezhu Yang wrote:
Fix the following checkpatch warnings and errors:
ERROR: do not initialise statics to 0
#14: FILE: drivers/platform/mips/cpu_hwmon.c:14:
+static int csr_temp_enable = 0;
I know you
test_kmod: Avoid potential double free in trigger_config_run_type()
https://lore.kernel.org/patchwork/patch/1227978/
Thanks,
Tiezhu Yang
On 04/30/2020 02:19 PM, Huacai Chen wrote:
Hi Christoph,
On Thu, Apr 30, 2020 at 10:31 AM Tiezhu Yang wrote:
In the current market, the most used bridge chip on the Loongson
platform are RS780E and LS7A, the RS780E bridge chip is already
supported by the mainline kernel.
In order to use
will make a slight
modification based on the v4 patch [1] to put ls7a things
before rs780e things, and then send v7 as soon as possible.
If anyone has any objections, please let me know.
[1] https://lore.kernel.org/patchwork/patch/1220010/
Thanks,
Tiezhu Yang
There exists the same macro definition of port type from 0 to 13
in include/uapi/linux/serial.h, remove these duplicated code in
include/uapi/linux/serial_core.h which includes the former header.
Signed-off-by: Tiezhu Yang
---
include/uapi/linux/serial_core.h | 14 --
1 file changed
disk-io.h is included more than once in block-group.c, remove it.
Signed-off-by: Tiezhu Yang
---
fs/btrfs/block-group.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c
index 696f471..d3d5cf4 100644
--- a/fs/btrfs/block-group.c
+++ b/fs/btrfs
the RS780E bridge chip, it is better to use the platform
dependent implementation of __phys_to_dma() and __dma_to_phys().
Signed-off-by: Tiezhu Yang
---
v7:
- According to the discussion of the v6 patch [1],
use the platform dependent implementation of
__phys_to_dma() and __dma_to_phys
Fix the following checkpatch warnings and errors:
ERROR: do not initialise statics to 0
#14: FILE: drivers/platform/mips/cpu_hwmon.c:14:
+static int csr_temp_enable = 0;
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal
permissions '0444'.
#60: FILE:
When the CPU temperature is too high, it is better to print a log before
power off, this is useful when analysis the abnormal issues.
Signed-off-by: Tiezhu Yang
---
drivers/platform/mips/cpu_hwmon.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/mips
Tiezhu Yang (3):
MIPS: Loongson: Cleanup cpu_hwmon.c
MIPS: Loongson: Add hwmon support for generic CPU
MIPS: Loongson: Add log before power off due to high temperature
drivers/platform/mips/cpu_hwmon.c | 38 ++
1 file changed, 22 insertions(+), 16
Add PRID_IMP_LOONGSON_64G case to enable hwmon support for Loongson
generic CPU such as 3A4000 and newer CPU.
Signed-off-by: Tiezhu Yang
---
drivers/platform/mips/cpu_hwmon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/mips/cpu_hwmon.c
b/drivers/platform/mips
On 05/16/2020 07:09 PM, WANG Xuerui wrote:
On 5/16/20 3:03 PM, Tiezhu Yang wrote:
After commit 87fcfa7b7fe6 ("MIPS: Loongson64: Add generic dts"),
there already exists the node and property of Loongson CPU UART0
in loongson3-package.dtsi:
cpu_uart0: serial@1fe001e0 {
the following boot messages:
[1.877745] printk: console [ttyS0] disabled
[1.881979] 1fe001e0.serial: ttyS0 at MMIO 0x1fe001e0 (irq = 16, base_baud =
2062500) is a 16550A
[1.890838] printk: console [ttyS0] enabled
And also, we can login normally from the serial console.
Signed-off-by: Ti
)
have this similar issue, fix them.
[1.872600] radeon :01:05.0: fence driver on ring 0 use gpu addr
0x48000c00 and cpu addr 0x(ptrval)
[1.879095] radeon :01:05.0: fence driver on ring 5 use gpu addr
0x40056038 and cpu addr 0x(____ptrval____)
Signed-off-by:
On 06/30/2020 04:05 PM, Christian König wrote:
Am 30.06.20 um 09:36 schrieb Tiezhu Yang:
When I update the latest kernel, I see the following "ptrval"
boot
messages. Use "%pK" instead of "%p" so that the cpu address can be
printed
when the kptr_rest
Use DECLARE_PCI_FIXUP_EARLY instead of DECLARE_PCI_FIXUP_HEADER
for bridge_class_quirk() in pci-loongson.c, otherwise the fixup
has no effect.
Fixes: 1f58cca5cf2b ("PCI: Add Loongson PCI Controller support")
Signed-off-by: Tiezhu Yang
---
This patch is based on mips-next tree.
d
On 07/01/2020 09:04 PM, Markus Elfring wrote:
If remove the local variable "ret", it will look like this:
…
+++ b/drivers/irqchip/irq-csky-apb-intc.c
…
@@ -118,18 +116,23 @@ ck_intc_init_comm(struct device_node *node, struct
device_node *parent)
…
- ret =
about
CPU address.
Signed-off-by: Tiezhu Yang
---
v2:
- Just remove the debug info about CPU address suggested by Christian
- Modify the patch subject and update the commit message
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 5 ++---
drivers/gpu/drm/radeon/radeon_fence.c | 4 ++--
2 fil
On 07/02/2020 03:19 PM, Markus Elfring wrote:
+++ b/drivers/irqchip/irq-csky-apb-intc.c
…
I suggest to recheck the parameter alignment for such a function call.
On 07/02/2020 04:27 PM, Christian König wrote:
Am 02.07.20 um 04:27 schrieb Tiezhu Yang:
When I update the latest kernel, I see the following "ptrval"
boot
messages.
[1.872600] radeon :01:05.0: fence driver on ring 0 use gpu
addr 0x48000c00 and c
On 07/02/2020 04:39 PM, Christian König wrote:
Am 02.07.20 um 10:35 schrieb Tiezhu Yang:
On 07/02/2020 04:27 PM, Christian König wrote:
Am 02.07.20 um 04:27 schrieb Tiezhu Yang:
When I update the latest kernel, I see the following
"ptrval" boot
messages.
[1.872600] r
On 07/02/2020 04:05 PM, Tiezhu Yang wrote:
On 07/02/2020 03:19 PM, Markus Elfring wrote:
+++ b/drivers/irqchip/irq-csky-apb-intc.c
…
I suggest to recheck the parameter alignment for such a function call.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation
On 07/02/2020 08:24 PM, Markus Elfring wrote:
+++ b/drivers/irqchip/irq-csky-apb-intc.c
…
Let us keep it as it is
I propose to reconsider also this view.
to make the code clear and to avoid the alignment issue:
ret = foo();
if (ret) {
ret = -ENOMEM;
How do you think about to
On 07/14/2020 05:41 AM, Rob Herring wrote:
On Tue, Jul 07, 2020 at 10:12:52AM +0800, Tiezhu Yang wrote:
Fix the following two typos in loongson,liointc.yaml:
fron -> from
connected -> connect
it's -> its
Fixes: b6280c8bb6f5 ("dt-bindings: interrupt-controller: Add Loongson LIOINT
On 06/12/2020 09:30 AM, Tiezhu Yang wrote:
Use DECLARE_PCI_FIXUP_EARLY instead of DECLARE_PCI_FIXUP_HEADER
for bridge_class_quirk() in pci-loongson.c, otherwise the fixup
has no effect.
Fixes: 1f58cca5cf2b ("PCI: Add Loongson PCI Controller support")
Signed-off-by: Tiezhu Yan
efile")
Reported-by: kernel test robot
Signed-off-by: Tiezhu Yang
---
This patch is based on linux-phy.git:
https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git/?h=next
drivers/phy/allwinner/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy
\
clear_thread_flag(TIF_32BIT); \
current->personality &= ~READ_IMPLIES_EXEC; \
})
[1]
https://insights.sei.cmu.edu/cert/2014/02/feeling-insecure-blame-your-parent.html
Reported-by: Juxin Gao
Co-developed-by:
On 07/08/2020 03:45 AM, Maciej W. Rozycki wrote:
On Tue, 7 Jul 2020, Tiezhu Yang wrote:
In the MIPS architecture, we should clear the security-relevant
flag READ_IMPLIES_EXEC in the function SET_PERSONALITY2() of the
file arch/mips/include/asm/elf.h.
Otherwise, with this flag set, PROT_READ
/mips/ath79/")
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-ath79-misc.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-ath79-misc.c b/drivers/irqchip/irq-ath79-misc.c
index 3d641bb..53e0c50 100644
--- a/drivers/irqchip/irq-ath79-mi
In the function omap_init_irq_of(), system resource "omap_irq_base"
was not released in the error case, fix it.
Fixes: 8598066cddd1 ("arm: omap: irq: move irq.c to drivers/irqchip/")
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-omap-intc.c | 4 +++-
1 file changed
P in patch #3
- Add a return statement before goto label in patch #4
Tiezhu Yang (14):
irqchip/ath79-misc: Fix potential resource leaks
irqchip/csky-apb-intc: Fix potential resource leaks
irqchip/csky-mpintc: Fix potential resource leaks
irqchip/davinci-aintc: Fix potential resource leaks
("irqchip: davinci-cp-intc: move the driver to
drivers/irqchip")
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-davinci-cp-intc.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-davinci-cp-intc.c
b/drivers/irqchip/irq-davin
In the function xilinx_intc_of_init(), system resource "irqc->root_domain"
was not released in the error case. Thus add jump target for the completion
of the desired exception handling.
Fixes: 9689c99e4950 ("irqchip/xilinx: Add support for parent intc")
Signed-off-by: Ti
oller driver")
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-digicolor.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-digicolor.c b/drivers/irqchip/irq-digicolor.c
index fc38d2d..18c6e77 100644
--- a/drivers/irqchip/irq-digicol
In the function riscv_intc_init(), system resource "intc_domain"
was not released in the error case, fix it.
Fixes: 6b7ce8927b5a ("irqchip: RISC-V per-HART local interrupt controller
driver")
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-riscv-intc.c | 1 +
1 file
ng.
Fixes: 0145beed9d26 ("irqchip: davinci-aintc: move the driver to
drivers/irqchip")
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-davinci-aintc.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-davinci-aintc.c
b/drive
In the function dw_apb_ictl_init(), system resources "irq" and "domain"
were not released in a few error cases. Thus add jump targets for the
completion of the desired exception handling.
Fixes: 350d71b94fc9 ("irqchip: add DesignWare APB ICTL interrupt controller&quo
In the function ls1x_intc_of_init(), system resource "parent_irq"
was not released in a few error cases. Thus add jump target for
the completion of the desired exception handling.
Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller")
Signed
In the function nvic_of_init(), system resource "nvic_base" and
"nvic_irq_domain" were not released in a few error cases. Thus add
jump targets for the completion of the desired exception handling.
Fixes: 292ec080491d ("irqchip: Add support for ARMv7-M NVIC&quo
In the function ocelot_irq_init(), system resource "parent_irq"
was not released in a few error cases. Thus add jump target for
the completion of the desired exception handling.
Fixes: 19d99164480a ("irqchip: Add a driver for the Microsemi Ocelot
controller")
Signed
y Markus.
Fixes: d8a5f5f79122 ("irqchip: add C-SKY SMP interrupt controller")
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-csky-mpintc.c | 34 +-
1 file changed, 25 insertions(+), 9 deletions(-)
diff --git a/drivers/irqchip/irq-csky-mpintc.c
b
In the function ck_intc_init_comm(), system resources "reg_base" and
"root_domain" were not released in a few error cases. Thus add jump
targets for the completion of the desired exception handling.
Fixes: edff1b4835b7 ("irqchip: add C-SKY APB bus interrupt controller&quo
In the function s3c_init_intc_of(), system resource "reg_base", "domain"
and "intc" were not released in a few error cases. Thus add jump targets
for the completion of the desired exception handling.
Fixes: f0774d41da0e ("irqchip: s3c24xx: add devicetree s
On 07/01/2020 04:15 PM, Markus Elfring wrote:
…
+++ b/drivers/irqchip/irq-davinci-aintc.c
@@ -96,7 +96,7 @@ void __init davinci_aintc_init(const struct
davinci_aintc_config *config)
resource_size(>reg));
if (!davinci_aintc_base) {
On 07/01/2020 03:49 PM, Markus Elfring wrote:
exception handling. By the way, do some coding-style cleanups
I propose to consider another bit of fine-tuning.
…
+++ b/drivers/irqchip/irq-csky-mpintc.c
…
@@ -270,12 +274,24 @@ csky_mpintc_init(struct device_node *node, struct
device_node
On 07/01/2020 04:40 PM, Markus Elfring wrote:
… were not released in a few error cases. …
Another small wording adjustment:
… in two error cases. …
OK
…
+++ b/drivers/irqchip/irq-csky-apb-intc.c
…
@@ -126,10 +127,17 @@ ck_intc_init_comm(struct device_node *node, struct
device_node
On 07/01/2020 05:14 PM, Markus Elfring wrote:
In the function omap_init_irq_of(), system resource "omap_irq_base"
was not released in the error case, fix it.
Another small wording adjustment:
… in an error case. Thus add a call of the function “iounmap”
in the if branch.
OK, thank you,
On 07/01/2020 05:42 PM, Markus Elfring wrote:
In the function xilinx_intc_of_init(), system resource "irqc->root_domain"
was not released in the error case. Thus add jump target for the completion
of the desired exception handling.
Another small wording adjustment:
… Thus add a jump target …
In the function nvic_of_init(), system resource "nvic_base" and
"nvic_irq_domain" were not released in two error cases. Thus add
jump targets for the completion of the desired exception handling.
Fixes: 292ec080491d ("irqchip: Add support for ARMv7-M NVIC&quo
("irqchip: davinci-cp-intc: move the driver to
drivers/irqchip")
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-davinci-cp-intc.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-davinci-cp-intc.c
b/drivers/irqchip/irq-davin
P in patch #3
- Add a return statement before goto label in patch #4
v5:
- Modify the commit messages and do some code cleanups
Tiezhu Yang (14):
irqchip/ath79-misc: Fix potential resource leaks
irqchip/csky-apb-intc: Fix potential resource leaks
irqchip/csky-mpintc: Fix potential res
ng.
Fixes: 0145beed9d26 ("irqchip: davinci-aintc: move the driver to
drivers/irqchip")
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-davinci-aintc.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-davinci-aintc.c
b/drive
In the function ocelot_irq_init(), system resource "parent_irq"
was not released in a few error cases. Thus add a jump target
for the completion of the desired exception handling.
Fixes: 19d99164480a ("irqchip: Add a driver for the Microsemi Ocelot
controller")
Signed
In the function ls1x_intc_of_init(), system resource "parent_irq"
was not released in two error cases. Thus add a jump target for
the completion of the desired exception handling.
Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller")
Signed
y Markus.
Fixes: d8a5f5f79122 ("irqchip: add C-SKY SMP interrupt controller")
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-csky-mpintc.c | 31 ++-
1 file changed, 22 insertions(+), 9 deletions(-)
diff --git a/drivers/irqchip/irq-csky-mpintc.c
b/drivers
/mips/ath79/")
Signed-off-by: Tiezhu Yang
---
drivers/irqchip/irq-ath79-misc.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-ath79-misc.c b/drivers/irqchip/irq-ath79-misc.c
index 3d641bb..53e0c50 100644
--- a/drivers/irqchip/irq-ath79-mi
In the function ck_intc_init_comm(), system resources "reg_base" and
"root_domain" were not released in two error cases. Thus add jump
targets for the completion of the desired exception handling.
Fixes: edff1b4835b7 ("irqchip: add C-SKY APB bus interrupt controller&quo
301 - 400 of 518 matches
Mail list logo
