Subdevices of bpmp, such as bpmp-i2c, require the bpmp device's
drvdata to be set during their probe. Currently this is not always the
case. Fix this by calling platform_set_drvdata() earlier during bpmp's
probe.
Signed-off-by: Timo Alho <ta...@nvidia.com>
---
drivers/firmware/tegra/bpmp
-by: Timo Alho <ta...@nvidia.com>
---
drivers/mmc/host/sdhci-tegra.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index f668a6f..cdde9ff 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host
e and data to firmware via DRAM.
Signed-off-by: Timo Alho <ta...@nvidia.com>
---
drivers/firmware/tegra/Makefile | 4 +-
drivers/firmware/tegra/bpmp.c | 2 +
drivers/firmware/tegra/bpmp_debugfs.c | 446 ++
include/soc/tegra/bpmp.h |
e and data to firmware via DRAM.
Signed-off-by: Timo Alho <ta...@nvidia.com>
---
Changes in v2:
- Address Jonathan's review feedback
* restructure error printing and what error codes passed to higher
layers
* don't use IS_ERR_OR_NULL()
* avoid overwriting last-character of filename in
out when the clock id is unused.
Signed-off-by: Timo Alho <ta...@nvidia.com>
---
drivers/clk/tegra/clk-bpmp.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/clk/tegra/clk-bpmp.c b/drivers/clk/tegra/clk-bpmp.c
index 638ace6..a896692 100644
--- a/d
this code and does not pass it to
caller. Fix this by adding an extra struct member to
tegra_bpmp_message and populate that with return code.
Signed-off-by: Timo Alho <ta...@nvidia.com>
---
drivers/firmware/tegra/bpmp.c | 22 --
include/soc/tegra/bpmp.h | 1 +
2
,
Timo
Timo Alho (4):
firmware: tegra: propagate error code to caller
clk: tegra: check BPMP response return code
reset: tegra: check BPMP response return code
soc/tegra: bpmp: check BPMP response return code
drivers/clk/tegra/clk-bpmp.c | 15 ++-
drivers/firmware/tegra
Add checks for return code in BPMP response message.
Signed-off-by: Timo Alho <ta...@nvidia.com>
---
drivers/soc/tegra/powergate-bpmp.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/tegra/powergate-bpmp.c
b/drivers/soc/tegra/powergate-
Add checks for return code in BPMP response message.
Signed-off-by: Timo Alho <ta...@nvidia.com>
---
drivers/reset/tegra/reset-bpmp.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/tegra/reset-bpmp.c b/drivers/reset/tegra/reset-bpmp.c
index 5
On 29.09.2017 17:53, Jonathan Hunter wrote:
On 29/09/17 14:46, Timo Alho wrote:
Hi Jon,
On 21.09.2017 14:21, Jonathan Hunter wrote:
On 07/09/17 10:31, Timo Alho wrote:
Check return code in BPMP response message(s). The typical error case
is when clock operation is attempted with invalid
On 29.09.2017 17:58, Jonathan Hunter wrote:
+static int bpmp_populate_dir(struct tegra_bpmp *bpmp, struct seqbuf
*seqbuf,
+ struct dentry *parent, uint32_t depth)
Do we need to use uint32_t here?
+{
+ int err;
+ uint32_t d, t;
And here?
It's part of the BPMP ABI
Jon,
Thanks for reviewing this!
On 21.09.2017 14:10, Jonathan Hunter wrote:
--- a/drivers/firmware/tegra/bpmp.c
+++ b/drivers/firmware/tegra/bpmp.c
@@ -824,6 +824,8 @@ static int tegra_bpmp_probe(struct platform_device *pdev)
if (err < 0)
goto free_mrq;
+
Hi Jon,
On 21.09.2017 14:21, Jonathan Hunter wrote:
On 07/09/17 10:31, Timo Alho wrote:
Check return code in BPMP response message(s). The typical error case
is when clock operation is attempted with invalid clock identifier.
Also remove error print from call to clk_get_info
Jon, thanks for reviewing
On 03.10.2017 13:55, Jonathan Hunter wrote:
+static int create_debugfs_mirror(struct tegra_bpmp *bpmp, void *buf,
+size_t bufsize, struct dentry *root)
+{
+ struct seqbuf seqbuf;
+ int err;
+
+ bpmp->debugfs_mirror =
On 03.10.2018 11:26, Jonathan Hunter wrote:
On 02/10/18 22:21, Arnd Bergmann wrote:
The newly added tegra_bpmp_resume function is unused when CONFIG_PM
is disabled:
drivers/firmware/tegra/bpmp.c:847:12: error: 'tegra_bpmp_resume' defined but
not used [-Werror=unused-function]
static int
Subdevices of bpmp, such as bpmp-i2c, require the bpmp device's
drvdata to be set during their probe. Currently this is not always the
case. Fix this by calling platform_set_drvdata() earlier during bpmp's
probe.
Signed-off-by: Timo Alho
---
drivers/firmware/tegra/bpmp.c | 4 ++--
1 file
-by: Timo Alho
---
drivers/mmc/host/sdhci-tegra.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index f668a6f..cdde9ff 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -501,8
e and data to firmware via DRAM.
Signed-off-by: Timo Alho
---
Changes in v2:
- Address Jonathan's review feedback
* restructure error printing and what error codes passed to higher
layers
* don't use IS_ERR_OR_NULL()
* avoid overwriting last-character of filename in one corner case
(n
Jon, thanks for reviewing
On 03.10.2017 13:55, Jonathan Hunter wrote:
+static int create_debugfs_mirror(struct tegra_bpmp *bpmp, void *buf,
+size_t bufsize, struct dentry *root)
+{
+ struct seqbuf seqbuf;
+ int err;
+
+ bpmp->debugfs_mirror =
Jon,
Thanks for reviewing this!
On 21.09.2017 14:10, Jonathan Hunter wrote:
--- a/drivers/firmware/tegra/bpmp.c
+++ b/drivers/firmware/tegra/bpmp.c
@@ -824,6 +824,8 @@ static int tegra_bpmp_probe(struct platform_device *pdev)
if (err < 0)
goto free_mrq;
+
Hi Jon,
On 21.09.2017 14:21, Jonathan Hunter wrote:
On 07/09/17 10:31, Timo Alho wrote:
Check return code in BPMP response message(s). The typical error case
is when clock operation is attempted with invalid clock identifier.
Also remove error print from call to clk_get_info
On 29.09.2017 17:58, Jonathan Hunter wrote:
+static int bpmp_populate_dir(struct tegra_bpmp *bpmp, struct seqbuf
*seqbuf,
+ struct dentry *parent, uint32_t depth)
Do we need to use uint32_t here?
+{
+ int err;
+ uint32_t d, t;
And here?
It's part of the BPMP ABI
On 29.09.2017 17:53, Jonathan Hunter wrote:
On 29/09/17 14:46, Timo Alho wrote:
Hi Jon,
On 21.09.2017 14:21, Jonathan Hunter wrote:
On 07/09/17 10:31, Timo Alho wrote:
Check return code in BPMP response message(s). The typical error case
is when clock operation is attempted with invalid
,
Timo
Timo Alho (4):
firmware: tegra: propagate error code to caller
clk: tegra: check BPMP response return code
reset: tegra: check BPMP response return code
soc/tegra: bpmp: check BPMP response return code
drivers/clk/tegra/clk-bpmp.c | 15 ++-
drivers/firmware/tegra
Add checks for return code in BPMP response message.
Signed-off-by: Timo Alho
---
drivers/soc/tegra/powergate-bpmp.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/tegra/powergate-bpmp.c
b/drivers/soc/tegra/powergate-bpmp.c
index 8fc3560
out when the clock id is unused.
Signed-off-by: Timo Alho
---
drivers/clk/tegra/clk-bpmp.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/clk/tegra/clk-bpmp.c b/drivers/clk/tegra/clk-bpmp.c
index 638ace6..a896692 100644
--- a/drivers/clk/tegra/clk
this code and does not pass it to
caller. Fix this by adding an extra struct member to
tegra_bpmp_message and populate that with return code.
Signed-off-by: Timo Alho
---
drivers/firmware/tegra/bpmp.c | 22 --
include/soc/tegra/bpmp.h | 1 +
2 files changed, 17
Add checks for return code in BPMP response message.
Signed-off-by: Timo Alho
---
drivers/reset/tegra/reset-bpmp.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/tegra/reset-bpmp.c b/drivers/reset/tegra/reset-bpmp.c
index 5daf2ee..fac2db6 100644
e and data to firmware via DRAM.
Signed-off-by: Timo Alho
---
drivers/firmware/tegra/Makefile | 4 +-
drivers/firmware/tegra/bpmp.c | 2 +
drivers/firmware/tegra/bpmp_debugfs.c | 446 ++
include/soc/tegra/bpmp.h | 14 ++
4 files ch
On 03.10.2018 11:26, Jonathan Hunter wrote:
On 02/10/18 22:21, Arnd Bergmann wrote:
The newly added tegra_bpmp_resume function is unused when CONFIG_PM
is disabled:
drivers/firmware/tegra/bpmp.c:847:12: error: 'tegra_bpmp_resume' defined but
not used [-Werror=unused-function]
static int
hm tegra_bpmp_i2c_algo = {
.master_xfer = tegra_bpmp_i2c_xfer,
+ .master_xfer_atomic = tegra_bpmp_i2c_xfer_atomic,
.functionality = tegra_bpmp_i2c_func,
};
Looks good to me.
Reviewed-by: Timo Alho
31 matches
Mail list logo
