[PATCH v2 0/4] drivers: staging: checkpatch fixes

drivers/staging/android/ion/ion.c produces 2 warnings and 29 checks. This patch set fixes both warnings and all but 4 of the checks. All except the last patch are trivial. Signed-off-by: Tobin C Harding <m...@tobin.cc> --- Patch 1/4 is whitespace only. This is my first Linux kernel

[PATCH v2 1/4] drivers: staging: fix parameter alignment

drivers/staging/android/ion/ion.c checkpatch produces alignment checks. This patch is whitespace only and fixes these checks. Signed-off-by: Tobin C Harding <m...@tobin.cc> --- drivers/staging/android/ion/ion.c | 64 +++ 1 file changed, 32 insertions(

[PATCH v2 4/4] drivers: staging: remove BUG_ON

drivers/staging/android/ion/ion.c calls BUG_ON in places where WARN_ON will suffice. This patch replaces two such occurences. Two other occurences remain. Signed-off-by: Tobin C Harding <m...@tobin.cc> --- Changing the remaining two BUG_ON's causes changes to the programm logic. This

[PATCH v2 3/4] drivers: staging: remove comparison to NULL

drivers/staging/android/ion/ion.c checkpatch produces 'Comparison to NULL could be written ...' checks. This patch replaces comparison to NULL with !var as suggested by checkpatch. Signed-off-by: Tobin C Harding <m...@tobin.cc> --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file c

[PATCH v2 2/4] drivers: staging: fix line length

drivers/staging/android/ion/ion.c checkpatch produces line over 80 character warnings. This patch is whitespace only and fixes these warnings. Signed-off-by: Tobin C Harding <m...@tobin.cc> --- drivers/staging/android/ion/ion.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[PATCH 1/4] mm: Fix sparse, use plain integer as NULL pointer

From: Tobin C Harding <m...@tobin.cc> Patch fixes sparse warning: Using plain integer as NULL pointer. Replaces assignment of 0 to pointer with NULL assignment. Signed-off-by: Tobin C Harding <m...@tobin.cc> --- mm/memory.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 2/4] mm: Fix checkpatch warnings, whitespace

From: Tobin C Harding <m...@tobin.cc> Patch fixes whitespace checkpatch warnings. Signed-off-by: Tobin C Harding <m...@tobin.cc> --- mm/memory.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index cc5fa12..3562314 100

[PATCH 3/4] mm: Fix checkpatch errors, whitespace errors

From: Tobin C Harding <m...@tobin.cc> Patch fixes whitespace checkpatch errors. Signed-off-by: Tobin C Harding <m...@tobin.cc> --- mm/memory.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/mm/memory.c b/mm/memory.c i

[PATCH 0/4] mm: trivial sparse and checkpatch fixes

From: Tobin C Harding <m...@tobin.cc> This patchset fixes trivial sparse and checkpatch errors/warnings. The majority of the changes are whitespace only. The only code changes are replace 0 with NULL, and remove extraneous braces around single statement. Patchset aims to only make change

[PATCH 4/4] mm: Fix checkpatch warning, extraneous braces

From: Tobin C Harding <m...@tobin.cc> Patch fixes checkpatch warning on use of braces around a single statement. Signed-off-by: Tobin C Harding <m...@tobin.cc> --- mm/memory.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 35fb

[PATCH] ALSA: emu10k1: Remove cast from memory allocation

Coccinelle emits multiple WARNING: casting value returned by memory allocation function to (u_int32_t __user *) is useless. Remove unnecessary cast. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- sound/pci/emu10k1/emufx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH] fs/9p: Remove cast from memory allocation

Coccinelle emits WARNING: casting value returned by memory allocation function to (struct v9fs_inode *) is useless. Remove unnecessary cast. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- fs/9p/vfs_inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a

[PATCH] ncpfs: Remove cast from memory allocation

Coccinelle emits WARNING: casting value returned by memory allocation function to (struct ncp_inode_info *) is useless. Remove unnecessary cast. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- fs/ncpfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs

[PATCH] proc: Remove cast from memory allocation

Coccinelle emits WARNING: casting value returned by memory allocation function to (struct proc_inode *) is useless. Remove unnecessary cast. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- fs/proc/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/ino

Re: [PATCH] ALSA: emu10k1: Remove cast from memory allocation

On Wed, Feb 22, 2017 at 07:59:57AM +0100, Takashi Iwai wrote: > On Wed, 22 Feb 2017 07:47:16 +0100, > Tobin C. Harding wrote: > > > > Coccinelle emits multiple WARNING: casting value returned by memory > > allocation > > function to (u_int32_t __user *) is useles

checkpatch suspected false positive

Checkpatch may be giving a false positive of type CONST_STRUCT when parsing files in drivers/staging/comedi/drivers. $ pwd build/kernel/linux-trees/gregKH/staging/ $ cd drivers/staging/comedi/drivers $ checkpatch --terse --show-types *.c | grep CONST_STRUCT addi_apci_3501.c:97:

[PATCH v3] ncpfs: Remove cast from memory allocation

Coccinelle emits WARNING: casting value returned by memory allocation function to (struct ncp_inode_info *) is useless. Remove unnecessary cast. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- Changes since v2: - Put version amendment comments in correct place within patch email. C

[PATCH v2] ncpfs: Remove cast from memory allocation

Coccinelle emits WARNING: casting value returned by memory allocation function to (struct ncp_inode_info *) is useless. Remove unnecessary cast. Changes since v1: - Fix up typo Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- Kernel built successfully with patch applied. fs/ncpfs/i

[PATCH v4 2/2] x86/purgatory: Fix sparse warning, symbol not declared

the sparse warning. Include the header file in ASM file containing the call site to document the usage. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- arch/x86/purgatory/purgatory.c| 1 + arch/x86/purgatory/purgatory.h| 12 arch/x86/purgatory/setup-x86_64.S | 4 ++-- 3

[PATCH v4 1/2] x86/purgatory: Fix sparse warning, symbol not declared

Sparse emits several 'symbol not declared' warnings for various functions and variables. Add static keyword to functions and variables which have file scope only. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- arch/x86/purgatory/purgatory.c | 10 +- 1 file changed, 5 inse

[PATCH v4 0/2] x86/purgatory: Fix sparse warning, symbol not declared

contianing function definition. Changes since v3: - Put preprocessor directives in correct order. Changes since v2: - Add preprocessor guard. Changes since v1: - Add header file. Tobin C. Harding (2): x86/purgatory: Fix sparse warning, symbol not declared x86/purgatory: Fix sparse warning, symbol

Re: checkpatch suspected false positive

On Tue, Feb 21, 2017 at 03:19:22PM -0800, Joe Perches wrote: > On Wed, 2017-02-22 at 10:01 +1100, Tobin C. Harding wrote: > > Checkpatch may be giving a false positive of type CONST_STRUCT when > > parsing files in drivers/staging/comedi/drivers. > > > > $ pwd > >

Re: [PATCH v3] staging: xgifb: function prototype argument should also have an identifier name

Please use the imperative mood in the subject line i.e the short form of git commit log. A couple of example Subjects:: Subject: [PATCH 2/5] ext2: improve scalability of bitmap searching Subject: [PATCH v2 01/27] x86: fix eflags tracking Awesome work on you patches! thanks, Tobin.

[PATCH 0/2] net: Replace custom page based bitmap with IDA

;root=/dev/sda console=ttyS0" --enable-kvm --nographic -m 12G Current implementation #define NDEVICES 3 [ 134.376741] tm: Total milliseconds: 127152 Patched version #define NDEVICES 3 [ 226.960212] tm: Total milliseconds: 220756 #define NDEVICES 35000 [ 276.590994] tm:

[PATCH 2/2] net: Replace custom page based bitmap with IDA

to the page based bitmap. This has the effect of simplifying the code and removing the upper limit. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- net/core/dev.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 2

[PATCH 1/2] include: Fix checkpatch whitespace error and warning

This patch fixes two trivial whitespace messages (ERROR/WARNING). Fixes trailing whitespace ERROR and fixes space before tabs WARNING. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- include/linux/idr.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include

[PATCH 1/2] arch/x86: Fix sparse warning symbol not declared

This patch adds static declaration to a number of variables. Fixes sparse symbol was not declared warnings. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- arch/x86/purgatory/purgatory.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/x86/pur

[PATCH 2/2] arch/x86: Fix sparse warning symbol not declared

This patch adds function declaration in order to quiet sparse symbol not declared warning. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- Unsure why adding declaration quiets sparse. This may not be the correct solution. Only testing done is building and booting kernel. Since 'pur

[PATCH 0/2] arch/x86: Fix sparse warning

This series fixes multiple occurences of sparse warning, 'symbol is not declared. Should it be static?'. Initial patch adds 'static' keyword to variable declarations. Second patch declares function in order to clear same warning. Tobin C. Harding (2): arch/x86: Fix sparse warning symbol

[PATCH v3 2/2] x86/purgatory: Fix sparse warning, symbol not declared

warning. Include the header file in ASM file to document the usage. Use preprocessor guard to enable C header file to be included in ASM. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- arch/x86/purgatory/purgatory.c| 1 + arch/x86/purgatory/purgatory.h| 10 ++ ar

[PATCH v3 0/2] x86/purgatory: Fix sparse warning, symbol not declared

contianing function definition. V3: * Add preprocessor guard. V2: * Add header file. Tobin C. Harding (2): x86/purgatory: Fix sparse warning, symbol not declared x86/purgatory: Fix sparse warning, symbol not declared arch/x86/purgatory/purgatory.c| 11 ++- arch/x86/purgatory

[PATCH v3 1/2] x86/purgatory: Fix sparse warning, symbol not declared

Sparse emits several 'symbol not declared' warnings for various functions and variables. Add static keyword to functions and variables which have file scope only. Remove definition to zero for each variable declared static in accord with kernel standard. Signed-off-by: Tobin C. Harding &l

[PATCH 0/4] Whitespace checkpatch fixes

This patch set fixes various whitespace checkpatch errors and warnings. Tobin C. Harding (4): net: Fix checkpatch WARNING: please, no space before tabs net: Fix checkpatch whitespace errors net: Fix checkpatch block comments warnings net: Fix checkpatch, Missing a blank line after

[PATCH 3/4] net: Fix checkpatch block comments warnings

Fix multiple occurrences of checkpatch warning. WARNING: Block comments use * on subsequent lines. Also make comment blocks more uniform. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- net/core/dev.c | 65 +- 1 file chang

[PATCH 2/4] net: Fix checkpatch whitespace errors

This patch fixes two trivial whitespace errors. Brace should be on the previous line and trailing statements should be on next line. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- net/core/dev.c | 39 --- 1 file changed, 20 insertions(+), 19 del

[PATCH 4/4] net: Fix checkpatch, Missing a blank line after declarations

This patch fixes multiple occurrences of checkpatch WARNING: Missing a blank line after declarations. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- net/core/dev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index 6a076a1..f

[PATCH 1/4] net: Fix checkpatch WARNING: please, no space before tabs

This patch fixes multiple occurrences of space before tabs warnings. More lines of code were moved than required to keep kernel-doc comments uniform. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- net/core/dev.c | 142 - 1 file c

[PATCH] greybus: fw-management: Replace strncpy with strlcpy

checks with checks for truncated string. Add log message if string is truncated but do not return an error code. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- drivers/staging/greybus/fw-management.c | 59 +++-- 1 file changed, 19 insertions(+), 40 deletions(-)

[PATCH v2 3/3] staging: fbtft: Add check on strlcpy() return value

return value from call to strlcpy(). If source string is truncated call pr_warn() to notify user. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- drivers/staging/fbtft/fbtft_device.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft_de

[PATCH v2 1/3] staging: fbtft: Fix buffer overflow vulnerability

Module copies a user supplied string (module parameter) into a buffer using strncpy() and does not check that the buffer is null terminated. Replace call to strncpy() with call to strlcpy() ensuring that the buffer is null terminated. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- d

[PATCH v2 2/3] staging: fbtft: Replace magic number with constant

Current call to strncmp() uses a magic number. There is a compile time constant defined for this buffer, included and used already at other sites in the file. Remove magic number. Replace with pre-existing compile time constant. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- d

[PATCH v2 0/3] staging: fbtft: Fix buffer overflow vulnerability

. Check return value of call to strlcpy() and throw warning if source string is truncated. v1 was a single patch. v2 adds 2 extra patches while retaining the original v1 patch as the first of the series. v2: - Replace magic number - Check return value of call to strlcpy() Tobin C. Harding (3

[PATCH] staging: fbtft: Fix buffer overflow vulnerability

Module copies a user supplied string (module parameter) into a buffer using strncpy() and does not check that the buffer is null terminated. Replace call to strncpy() with call to strlcpy() ensuring that the buffer is null terminated. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- d

[PATCH v2 0/2] x86/purgatory: Fix sparse warnings

file defining the function in order to fix the sparse warning. Include the header file in ASM file containing the call site thereby adding documentation of usage. Tobin C. Harding (2): x86/purgatory: Fix sparse warning, symbol not declared x86/purgatory: Fix sparse warning, symbol not declared

[PATCH v2 1/2] x86/purgatory: Fix sparse warning, symbol not declared

Sparse emits several 'symbol not declared' warnings for various functions and variables. Add static keyword to functions and variables which have file scope only. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- arch/x86/purgatory/purgatory.c | 10 +- 1 file changed, 5 inse

[PATCH v2 2/2] x86/purgatory: Fix sparse warning, symbol not declared

the sparse warning. Include the header file in ASM file containing the call site thereby adding documentation of usage. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- arch/x86/purgatory/purgatory.c| 1 + arch/x86/purgatory/purgatory.h| 7 +++ arch/x86/purgatory/setup-x86_64.S | 3

Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code in comments.

On Mon, Feb 27, 2017 at 04:07:27PM +0100, Julia Lawall wrote: > > > On Mon, 27 Feb 2017, Arushi Singhal wrote: > > > > > > > On Mon, Feb 27, 2017 at 8:18 PM, Greg KH wrote: > > On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote: > > >

Re: [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses.

On Sun, Feb 26, 2017 at 06:00:19PM -0800, Matthew Giassa wrote: > --- > drivers/staging/ks7010/ks_wlan_ioctl.h | 64 > +- > 1 file changed, 32 insertions(+), 32 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h >

Re: [PATCH RFC] remove custom Michael MIC implementation

On Fri, Mar 31, 2017 at 09:58:51AM +0200, Wolfram Sang wrote: > > > The code is untested, I have hardware in the mail. > > Cool! The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is a SDW-823 and should use the ks7010 driver. I am going to attempt to get it running on a

Re: [PATCH RFC] staging: ks7010: remove custom Michael MIC implementation

On Thu, Mar 30, 2017 at 10:16:05PM -0700, Joe Perches wrote: > On Fri, 2017-03-31 at 15:47 +1100, Tobin C. Harding wrote: > > ks7010 currently uses a custom implementation of the Michael MIC > > algorithm. The kernel has an implementation of this algorithm > > already, we s

[PATCH 2/2] mmc: core: simplify return code

-by: Tobin C. Harding <m...@tobin.cc> --- drivers/mmc/core/sdio_io.c | 42 +- 1 file changed, 13 insertions(+), 29 deletions(-) diff --git a/drivers/mmc/core/sdio_io.c b/drivers/mmc/core/sdio_io.c index 3482314..d40744b 100644 --- a/drivers/mmc/core/sdi

[PATCH 1/2] mmc: core: guard dereference of optional parameter

Various functions take as parameter an optional pointer. Pointer should be guarded with non-NULL check before dereferencing. Add non-NULL check before dereference of pointer. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- drivers/mmc/core/sdio_io.c | 12 1 file chan

[PATCH 0/2] mmc: core: null pointer dereference bug

applied and built on x86_64 and PowerPC Tobin C. Harding (2): mmc: core: guard dereference of optional parameter mmc: core: simplify return code drivers/mmc/core/sdio_io.c | 54 ++ 1 file changed, 21 insertions(+), 33 deletions(-) -- 2.7.4

Re: [PATCH 1/3] Staging: ks7010: ks_*: Use preferred 'u8' kernel type over 'uint8_t'

On Tue, Mar 14, 2017 at 04:12:31PM +0100, Shiva Kerdel wrote: > Hello Tobin, > > I missed the other files because they did not show up using the checkpatch > script. > Next time I will do a recursive search through the files before committing > the changes to avoid this situation. > > Before I

Re: [PATCH] Staging: ks7010 - fixed style block comments

On Wed, Mar 22, 2017 at 07:29:50AM +1300, Derek Robson wrote: > On Tue, Mar 21, 2017 at 08:56:25AM +0100, Greg KH wrote: > > On Sun, Mar 19, 2017 at 01:07:17PM +1300, Derek Robson wrote: > > > Fixed style of all block comments across whole driver > > > Found by checkpatch > > > > > >

Re: [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses

On Tue, Mar 14, 2017 at 07:25:54PM -0700, Matthew Giassa wrote: > Wrapping all complex macros with parentheses to resolve checkpatch > errors. This change, along with the preceding changes in this change > set, resolves all checkpatch warnings and errors for the file. > > Signed-off-by: Matthew

Re: [PATCH RFC] remove custom Michael MIC implementation

On Mon, Apr 03, 2017 at 08:19:40AM +0300, Kalle Valo wrote: > + linux-wireless > > "Tobin C. Harding" <m...@tobin.cc> writes: > > > On Fri, Mar 31, 2017 at 09:58:51AM +0200, Wolfram Sang wrote: > >> > >> > The code is untested, I have ha

Re: [PATCH RFC] remove custom Michael MIC implementation

On Tue, Apr 04, 2017 at 11:31:14PM +0200, Arend Van Spriel wrote: > >> On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote: > >>> "Tobin C. Harding" <m...@tobin.cc> writes: > >>> > >>>> Except one: do you know off the top of your hea

[PATCH RFC] staging: ks7010: remove custom Michael MIC implementation

. Replace driver calls to the custom implementation with calls to the newly defined helper functions. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- drivers/staging/ks7010/Makefile | 2 +- drivers/staging/ks7010/ks_hostif.c | 48 +++- drivers/staging/ks7010/ks_wlan.h

[PATCH RFC] remove custom Michael MIC implementation

like to hear them. I am open to all suggestions (even down to trivial coding style issues). Thank you for taking the time to read this and for any tips you may be able to give me. thanks, Tobin. Tobin C. Harding (1): staging: ks7010: remove custom Michael MIC implementation drivers/staging

Re: [PATCH RFC] remove custom Michael MIC implementation

On Fri, Mar 31, 2017 at 12:42:22PM +0200, Wolfram Sang wrote: > Hi, > > > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is > > a SDW-823 and should use the ks7010 driver. > > Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for > which no driver is

Re: [PATCH] staging: ks7010: Adjust dev_err() calls in ks7010_sdio_probe()

On Tue, Apr 11, 2017 at 03:15:32PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 11 Apr 2017 14:54:35 +0200 > > The use of the logging function "dev_err" was introduced here on 2016-09-26. > > I find the following implementation details worth

Re: [PATCH] staging: ks7010: Adjust dev_err() calls in ks7010_sdio_probe()

On Wed, Apr 12, 2017 at 12:27:10PM +0200, Greg Kroah-Hartman wrote: > On Wed, Apr 12, 2017 at 08:39:15AM +1000, Tobin C. Harding wrote: > > On Tue, Apr 11, 2017 at 03:15:32PM +0200, SF Markus Elfring wrote: > > > From: Markus Elfring <elfr...@users.sourceforge.net> > &g

Re: [PATCH] powerpc: asm: convert directive .llong to .8byte

.llong -> .8byte > > > > Signed-off-by: Tobin C. Harding <m...@tobin.cc> > > --- > > > > Fixes: issue #33 (github) > > Thanks for tackling these! > > I have applied your patch to my local tree. I ran `git grep '\.llong'`, > and found: > >

Re: [PATCH] powerpc: asm: convert directive .llong to .8byte

cause it's self describing) is > >> .8byte. > >> > >> Convert directives .llong -> .8byte > >> > >> Signed-off-by: Tobin C. Harding <m...@tobin.cc> > >> --- > >> > >> Fixes: issue #33 (github) > > > > Thanks for tacklin

Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static

On Thu, Mar 09, 2017 at 08:11:03PM +0100, Thomas Gleixner wrote: > On Thu, 9 Mar 2017, Mike Galbraith wrote: > > On Thu, 2017-03-09 at 18:50 +0100, Thomas Gleixner wrote: > > > On Thu, 9 Mar 2017, Mike Galbraith wrote: > > > > > > > Greetings, > > > > > > > > I bisected kdump breakage to

[PATCH] powerpc: asm: convert directive .llong to .8byte

.llong is an undocumented PPC specific directive. The generic equivalent is .quad, but even better (because it's self describing) is .8byte. Convert directives .llong -> .8byte Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- Fixes: issue #33 (github) Patch is not tested. Has b

Re: [PATCH 1/3] Staging: ks7010: ks_*: Use preferred 'u8' kernel type over 'uint8_t'

On Sun, Mar 12, 2017 at 03:29:59AM +0100, Shiva Kerdel wrote: > Fix prefer kernel type 'u8' over 'uint8_t' checks. > > Signed-off-by: Shiva Kerdel > --- > drivers/staging/ks7010/ks_hostif.c | 4 +- > drivers/staging/ks7010/ks_hostif.h | 114 >

Re: [PATCH RFC] remove custom Michael MIC implementation

On Mon, Apr 03, 2017 at 12:15:15PM +0200, Arend Van Spriel wrote: > seems we are missing out again? Sorry, I don't understand what this comment means? > On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote: > > "Tobin C. Harding" <m...@tobin.cc> writes: > > > &

[no subject]

unsubscribe

Re: [PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c

On Tue, Apr 25, 2017 at 10:59:25PM +0200, Ilia Sergachev wrote: > This is a patch to the ks_wlan_net.c file that fixes up the following warning > found by the checkpatch.pl tool: > WARNING: Block comments use a trailing */ on a separate line Good work resubmitting this following Greg's comments.

Re: [PATCH v2] Staging: ks7010: style fix

On Wed, Apr 26, 2017 at 10:38:54AM +0200, Ilia Sergachev wrote: > Fix the style of block comments. > Move trailing */ to a separate line. > Checkpatch was showing: > WARNING: Block comments use a trailing */ on a separate line. You are doing well Ilia. A few nitpicks - Your first subject was

Re: [PATCH v3] staging: ks7010: fix block comment style

On Wed, Apr 26, 2017 at 01:00:23PM +0200, Ilia Sergachev wrote: > Checkpatch was showing: > WARNING: Block comments use a trailing */ on a separate line. > > Move trailing */ to a separate line. > > Signed-off-by: Ilia Sergachev <ilia.sergac...@unibas.ch> Reviewed

Re: [PATCH RFC] remove custom Michael MIC implementation

On Fri, Mar 31, 2017 at 12:42:22PM +0200, Wolfram Sang wrote: > Hi, > > > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is > > a SDW-823 and should use the ks7010 driver. > > Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for > which no driver is

Re: [PATCH] staging: ks7010: remove line continuations in quoted strings

On Fri, Apr 28, 2017 at 05:26:17PM +0300, Dan Carpenter wrote: > On Fri, Apr 28, 2017 at 04:19:28PM +0200, Ilia Sergachev wrote: > > Checkpatch emits WARNING: Avoid line continuations in quoted strings. > > > > Remove line continuations - split strings using quotes. > > > > Signed-off-by: Ilia

Re: [PATCH] staging/ks7010: Fix type assignment for struct hostif_hdr

On Sat, Apr 29, 2017 at 07:54:30PM +0200, Cezary Gapinski wrote: > Sparse spits out a warnings about __le16 and unsigned short assignment. > Change the type of size and event members of struct hostif_hdr > to __le16 and correct conversion to the proper cpu type. I believe that this patch is

Re: [PATCH v4] staging: ks7010: fix block comment style

On Fri, Apr 28, 2017 at 03:01:32PM +0200, Ilia Sergachev wrote: > On Fri, 28 Apr 2017 14:20:21 +0200 > Greg Kroah-Hartman wrote: > > > > > Nope, the whole thing still doesn't apply: > > > > checking file drivers/staging/ks7010/ks_wlan_net.c > > Hunk #1 FAILED at

Re: [PATCH] staging/ks7010: Fix type assignment for struct hostif_hdr

On Mon, May 01, 2017 at 04:11:30PM +0200, gapalinux wrote: > On Mon, 1 May 2017 19:59:44 +1000 > "Tobin C. Harding" <m...@tobin.cc> wrote: > > > On Sat, Apr 29, 2017 at 07:54:30PM +0200, Cezary Gapinski wrote: > > > Sparse spits out a warnings about __

Re: [PATCH V2] staging: unisys: visorhba - style fix

On Mon, Jun 19, 2017 at 03:28:19PM +, Kershner, David A wrote: > > > -Original Message- > > From: Derek Robson [mailto:robso...@gmail.com] > > Sent: Friday, June 16, 2017 11:13 PM > > To: Kershner, David A ; > > gre...@linuxfoundation.org; Sell, Timothy C

Re: [PATCH 01/27] Drivers: ccree: ssi_sysfs.h - align block comments

On Wed, May 24, 2017 at 04:40:32PM +1200, Derek Robson wrote: > Fixed block comment alignment, Style fix only > Found using checkpatch It's 'one thing per patch', this whole set does one thing. You may like to submit it as a single patch. You won't need the file name in the commit summary then

Re: staging: sm750fb: removed hungarian prfx and replace CamelCase variables

On Wed, May 24, 2017 at 01:24:14PM +0530, Richa Jha wrote: [snip] Nice work so far. I'm having trouble with your patches. Here are a few nitpicks to help you on your way. There are 4 emails in the last few days with similar subjects but they are not linked together. Also your email subject does

Re: staging: sm750fb: removed hungarian prfx and replace CamelCase variables

On Tue, May 23, 2017 at 06:37:39PM +0530, Richa Jha wrote: > Replace CamelCase variable names with underscores and remove > hungarian prefixes to comply with the standard kernel coding style Hi Richa, Nice work. You may like to do all the camel case at the same time. You could limit yourself to

Re: [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue.

On Wed, May 24, 2017 at 08:03:14PM +0530, srishti sharma wrote: This driver is not in Greg KH's staging tree. You may like to work off of that tree when doing staging patches. https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ To aid you future patches here are a couple of

Re: [PATCH] fix multiple blank lines coding style problem

On Thu, May 25, 2017 at 12:22:15PM +0300, Aliza Minkov wrote: > Signed-off-by: Aliza Minkov > --- > drivers/staging/dgnc/dgnc_driver.c | 2 -- > 1 file changed, 2 deletions(-) Hi Aliza, Well done getting your patch together. I think you might get an automated message from

Re: [PATCH V2 00/27] Drivers: ccree - align block comments

On Tue, May 30, 2017 at 08:49:41AM +0200, Antoine Tenart wrote: > Hello Derek, > > On Tue, May 30, 2017 at 06:09:37PM +1200, Derek Robson wrote: > > Fixed block comments across whole ccree driver > > Since all these commits are doing the same logical change across a > single driver, you could

[RFC 2/3] staging: ks7010: add cfg80211 files

for most of the rest of the driver at the same time. Add cfg80211 driver skeleton. Implement FIL. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- drivers/staging/ks7010/Makefile|6 + drivers/staging/ks7010/README.rst | 73 ++ drivers/staging/ks7010/TODO.rst| 17 + d

[RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

Driver ks7010 does not currently have a maintainer. Add maintainers entry for ks7010. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9e98464..75250ee 100644 --- a/MAINTAINERS

[RFC 0/3] staging: ks7010: cfg80211 conversion, add FIL

for taking the time to read this and thank you in advance for any time that you spend on this RFC. All feedback very much appreciated. Regards, Tobin. Tobin C. Harding (3): staging: ks7010: move WEXT files to sub directory staging: ks7010: Add cfg80211 files MAINTAINERS: add maintainer entry

Re: [RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

On Thu, Jun 01, 2017 at 12:46:30PM +0900, Greg KH wrote: > On Thu, Jun 01, 2017 at 01:27:08PM +1000, Tobin C. Harding wrote: > > Driver ks7010 does not currently have a maintainer. > > > > Add maintainers entry for ks7010. > > > > Signed-off-by

Re: [RFC 1/3] staging: ks7010: move WEXT files to sub directory

On Thu, Jun 01, 2017 at 12:45:37PM +0900, Greg KH wrote: > On Thu, Jun 01, 2017 at 01:27:06PM +1000, Tobin C. Harding wrote: > > Current driver implements the WEXT interface. WEXT is in maintenance > > mode, we need to re-write the driver using cfg80211. The current >

Re: [PATCH] staging: ks7010: use little-endian types

in variables > that do not have a specified endianness. > > Signed-off-by: Perry Hooker <perry.hoo...@gmail.com> For what it's worth Reviewed-By: Tobin C. Harding <m...@tobin.cc> > --- > drivers/staging/ks7010/ks_hostif.c | 24 +--- > 1 fi

Re: [PATCH] staging/ks7010: Fix type assignment for struct hostif_hdr

. If I am wrong, I'll be here to fix it up :) Reviewed-by: Tobin C. Harding <m...@tobin.cc> Good work Cezsary, apologies for the wish-washy replies. I'm learning also ;) Good luck, Tobin. > --- > drivers/staging/ks7010/ks7010_sdio.c | 10 ++ > drivers/staging/ks7010/ks_hostif

Re: [kernel-hardening] [RFC V2 2/6] lib: vsprintf: whitelist stack traces

On Mon, Oct 02, 2017 at 11:42:05AM +0100, Will Deacon wrote: > On Sun, Oct 01, 2017 at 11:06:46AM +1100, Tobin C. Harding wrote: > > Use the %pP functionality to explicitly allow kernel > > pointers to be logged for stack traces. > > > > Signed-off-by: Tobi

Re: [kernel-hardening] [RFC V2 2/6] lib: vsprintf: whitelist stack traces

t 01, 2017 at 11:06:46AM +1100, Tobin C. Harding wrote: > > > > > Use the %pP functionality to explicitly allow kernel > > > > > pointers to be logged for stack traces. > > > > > > > > > > Signed-off-by: Tobin C. Harding <m...@tobin.cc&g

Re: [kernel-hardening] [RFC V2 0/6] add more kernel pointer filter options

On Wed, Oct 04, 2017 at 10:58:50AM +0200, Greg KH wrote: > On Sun, Oct 01, 2017 at 11:06:44AM +1100, Tobin C. Harding wrote: > > Version 2 of Greg's patch series with changes made as suggested by comments > > to V1. > > > > Applies on top of Linu

Re: [kernel-hardening] [RFC V2 0/6] add more kernel pointer filter options

On Wed, Oct 04, 2017 at 10:57:56AM +0200, Greg KH wrote: > On Sun, Oct 01, 2017 at 11:11:05AM +1100, Tobin C. Harding wrote: > > On Sun, Oct 01, 2017 at 11:06:44AM +1100, Tobin C. Harding wrote: > > > Version 2 of Greg's patch series with changes made as suggested by &g

Re: [PATCH] lib/vsprintf: add default case to 'i' specifier

On Tue, Oct 10, 2017 at 12:09:35AM -0700, Joe Perches wrote: > On Mon, 2017-10-09 at 13:59 +1100, Tobin C. Harding wrote: > > %pi leaks kernel addresses if incorrectly specified. > > Are there any uses that are incorrectly specified? > grep doesn't show any. You are corre

Re: [PATCH] KVM: remove printing of token address

On Tue, Oct 10, 2017 at 10:31:11AM +0200, Paolo Bonzini wrote: > On 10/10/2017 01:51, Tobin C. Harding wrote: > > On Mon, Oct 09, 2017 at 12:58:12PM +0200, Paolo Bonzini wrote: > >> On 09/10/2017 12:04, Tobin C. Harding wrote: > >>> On Mon, Oct 09, 2017 at 03:49:3

Re: [PATCH] staging: ccree: fix boolreturn.cocci warning

On Mon, Oct 16, 2017 at 03:39:57PM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > This fixes the following coccinelle warning: > WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool. Perhaps Coccinelle emits WARNING: return of 0/1 in

Re: [PATCH] staging: ccree: Fix bool comparison

On Mon, Oct 16, 2017 at 03:38:11PM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > Bool tests don't need comparisons. This commit log could be a bit longer. You may like to read Documentation/process/submitting-patches.rst (section 2). > This fixes the

  1   2   3   4   5   6   7   8   9   10   >