Re: [PATCH RFC 01/10] ARM: s3c64xx: pm: Use name field of generic_pm_domain

2014-01-12 Thread Tomasz Figa
On 12.01.2014 19:53, Pavel Machek wrote: Hi! Could we get some more descriptive names for the domains? They are listed like this in user's manual, e.g. DOMAIN_F, DOMAIN_I, DOMAIN_G, etc. I guessed so. So the manual sucks. Would it be feasible to get it more descriptive (like Domain_G

Re: [PATCH RFC 01/10] ARM: s3c64xx: pm: Use name field of generic_pm_domain

2014-01-12 Thread Tomasz Figa
On 12.01.2014 20:20, Mark Brown wrote: On Sat, Jan 11, 2014 at 08:42:43PM +0100, Tomasz Figa wrote: static struct s3c64xx_pm_domain s3c64xx_pm_irom = { - .name = IROM, .ena = S3C64XX_NORMALCFG_IROM_ON, .pd = { + .name = domain_irom, This is nitpicking

Re: [PATCH RFC 06/10] ARM: s3c64xx: pm: Add device tree based power domain instantiation

2014-01-12 Thread Tomasz Figa
On 12.01.2014 20:29, Mark Brown wrote: On Sat, Jan 11, 2014 at 08:42:48PM +0100, Tomasz Figa wrote: This patch adds support for registering power domains of S3C64xx SoCs and binding devices to them using device tree. +#ifdef CONFIG_OF +static struct of_device_id s3c64xx_pd_matches

Re: [PATCH RFC 06/10] ARM: s3c64xx: pm: Add device tree based power domain instantiation

2014-01-13 Thread Tomasz Figa
On 13.01.2014 12:09, Mark Brown wrote: On Sun, Jan 12, 2014 at 08:34:10PM +0100, Tomasz Figa wrote: On 12.01.2014 20:29, Mark Brown wrote: On Sat, Jan 11, 2014 at 08:42:48PM +0100, Tomasz Figa wrote: This patch adds support for registering power domains of S3C64xx SoCs and binding devices

Re: [RFC] dt: bindings: add bindings for Broadcom bcm43xx sdio devices

2014-02-13 Thread Tomasz Figa
to be expressed in the devicetree. Cc: Chen-Yu Tsai w...@csie.org Cc: Tomasz Figa tomasz.f...@gmail.com Reviewed-by: Hante Meuleman meule...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Arend van Spriel ar...@broadcom.com --- This devicetree binding proposal

Re: [PATCH v2 4/6] ARM: firmware: add prepare_idle() operation

2014-02-13 Thread Tomasz Figa
Hi Alexandre, On 07.02.2014 05:35, Alexandre Courbot wrote: Some firmwares do not put the CPU into idle mode themselves, but still need to be informed that the CPU is about to enter idle mode before this happens. Add a prepare_idle() operation to the firmware_ops structure to handle such cases.

Re: [RFC] dt: bindings: add bindings for Broadcom bcm43xx sdio devices

2014-02-13 Thread Tomasz Figa
On 13.02.2014 13:07, Arend van Spriel wrote: On 02/13/2014 10:13 AM, Tomasz Figa wrote: Hi Arend, On 10.02.2014 20:17, Arend van Spriel wrote: The Broadcom bcm43xx sdio devices are fullmac devices that may be integrated in ARM platforms. Currently, the brcmfmac driver for these devices

Re: [PATCH v1 0/2] exynos_mct driver: fix irq allocation and cleanup

2014-02-13 Thread Tomasz Figa
Hi Tarek, On 13.02.2014 04:08, Tarek Dakhran wrote: exynos4_local_timer_setup called on the secondary cpu before irqs are enabled. request_irq can sleep, which produces next warning: on boot: [0.37] CPU0: thread -1, cpu 0, socket 0, mpidr 8000 [0.37] Setting up static

Re: [PATCH v2 10/14] Documentation: mfd: s2mps11: Document support for S2MPS14

2014-02-13 Thread Tomasz Figa
Hi, On 13.02.2014 10:14, Krzysztof Kozlowski wrote: Add bindings documentation for S2MPS14 device to the s2mps11 driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Mark Brown broo...@kernel.org Cc: Liam Girdwood lgirdw...@gmail.com Cc: Tomasz Figa t.f...@samsung.com Cc

Re: [PATCH v2 4/6] ARM: firmware: add prepare_idle() operation

2014-02-14 Thread Tomasz Figa
On 14.02.2014 06:16, Alexandre Courbot wrote: On 02/13/2014 08:01 PM, Tomasz Figa wrote: Hi Alexandre, On 07.02.2014 05:35, Alexandre Courbot wrote: Some firmwares do not put the CPU into idle mode themselves, but still need to be informed that the CPU is about to enter idle mode before

Re: [PATCH 6/9 v6] ARM: dts: exynos5250/5420: add dt node for sss module

2014-02-14 Thread Tomasz Figa
Hi Kukjin, On 14.02.2014 00:28, Kukjin Kim wrote: On 02/07/14 14:24, Naveen Krishna Chatradhi wrote: This patch adds the device tree node for SSS module found on Exynos5420 and Exynos5250 Signed-off-by: Naveen Krishna Chatradhich.nav...@samsung.com Reviewed-by: Tomasz Figat.f...@samsung.com

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-02-14 Thread Tomasz Figa
Hi Vivek, On 14.02.2014 14:53, Vivek Gautam wrote: Changes from v2: 1) Added support for multiple PHYs (UTMI+ and PIPE3) and related changes in the driver structuring. I'm a bit skeptical about this separation. Can the PHY operate with just the UTMI+ or PIPE3 part enabled alone without

Re: [PATCH v3 15/15] mfd: max14577: Add device tree bindings document

2014-02-19 Thread Tomasz Figa
kyungmin.p...@samsung.com Cc: Tomasz Figa t.f...@samsung.com Cc: Marek Szyprowski m.szyprow...@samsung.com Cc: devicet...@vger.kernel.org Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com --- Documentation/devicetree/bindings/mfd/max14577

Re: [PATCH v3 15/15] mfd: max14577: Add device tree bindings document

2014-02-19 Thread Tomasz Figa
kyungmin.p...@samsung.com Cc: Tomasz Figa t.f...@samsung.com Cc: Marek Szyprowski m.szyprow...@samsung.com Cc: devicet...@vger.kernel.org Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com --- Documentation/devicetree/bindings/mfd/max14577

Re: [PATCH v2 1/5] drivers: of: add initialization code for reserved memory

2014-02-11 Thread Tomasz Figa
Hi, On 11.02.2014 13:13, Grant Likely wrote: On Tue, 11 Feb 2014 12:45:50 +0100, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 2014-02-05 12:05, Grant Likely wrote: On Tue, 04 Feb 2014 13:09:29 +0100, Marek Szyprowski m.szyprow...@samsung.com wrote: This patch adds device

Re: [PATCH v2 1/5] drivers: of: add initialization code for reserved memory

2014-02-11 Thread Tomasz Figa
On 11.02.2014 21:02, Benjamin Herrenschmidt wrote: On Tue, 2014-02-11 at 19:01 +, Grant Likely wrote: except that the former IMHO better suits the definition of memory region, which I see as a single contiguous range of memory and can be simplified to have a single reg entry per region.

Re: [PATCH v2 1/5] drivers: of: add initialization code for reserved memory

2014-02-11 Thread Tomasz Figa
On 11.02.2014 21:19, Josh Cartwright wrote: On Tue, Feb 11, 2014 at 09:04:21PM +0100, Tomasz Figa wrote: On 11.02.2014 21:02, Benjamin Herrenschmidt wrote: On Tue, 2014-02-11 at 19:01 +, Grant Likely wrote: except that the former IMHO better suits the definition of memory region

Re: [PATCH v11 19/27] iommu/exynos: add support for power management subsystems.

2014-03-18 Thread Tomasz Figa
On 18.03.2014 12:23, Cho KyongHo wrote: On Fri, 14 Mar 2014 17:07:53 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: [snip] @@ -677,11 +679,40 @@ static int __init exynos_sysmmu_probe(struct platform_device *pdev) platform_set_drvdata(pdev, data

Re: [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12

2014-03-18 Thread Tomasz Figa
On 17.03.2014 06:19, Chanwoo Choi wrote: Hi Tomasz, On 03/15/2014 02:35 AM, Tomasz Figa wrote: Hi Chanwoo, Mark, On 14.03.2014 11:56, Chanwoo Choi wrote: Hi Mark, On 03/14/2014 07:35 PM, Mark Rutland wrote: On Fri, Mar 14, 2014 at 07:14:37AM +, Chanwoo Choi wrote: Hi Mark, On 03/14

Re: [PATCHv2 0/8] devfreq: exynos4: Support dt and use common ppmu driver

2014-03-18 Thread Tomasz Figa
On 17.03.2014 02:58, Chanwoo Choi wrote: Hi Tomasz, On 03/15/2014 02:58 AM, Tomasz Figa wrote: Hi Chanwoo, On 13.03.2014 09:17, Chanwoo Choi wrote: This patchset support devicetree and use common ppmu driver instead of individual code of exynos4_bus.c to remove duplicate code. Also

Re: [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12

2014-03-19 Thread Tomasz Figa
Hi Chanwoo, On 19.03.2014 10:47, Chanwoo Choi wrote: Hi Tomasz, On 03/19/2014 12:46 AM, Tomasz Figa wrote: On 17.03.2014 06:19, Chanwoo Choi wrote: Hi Tomasz, On 03/15/2014 02:35 AM, Tomasz Figa wrote: Hi Chanwoo, Mark, On 14.03.2014 11:56, Chanwoo Choi wrote: Hi Mark, On 03/14/2014 07

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-19 Thread Tomasz Figa
On 19.03.2014 10:01, Sachin Kamat wrote: On 19 March 2014 14:29, Cho KyongHo pullip@samsung.com wrote: On Tue, 18 Mar 2014 16:14:53 +0100, Tomasz Figa wrote: On 18.03.2014 12:09, Cho KyongHo wrote: On Fri, 14 Mar 2014 20:52:43 +0530, Sachin Kamat wrote: Hi KyongHo, On 14 March 2014 10

Re: [PATCH v2 2/4] drivers: clk: use CONFIG_COMMON_CLK_SAMSUNG for Samsung clock support

2014-03-19 Thread Tomasz Figa
Hi Pankaj, On 12.03.2014 05:32, Pankaj Dubey wrote: This patch includes Samsung clock Kconfig file, and replaces PLAT_SAMSUNG with COMMON_CLK_SAMSUNG for Samsung common clock support. Any Samsung SoC want to use Samsung common clock infrastructure can simply select COMMON_CLK_SAMSUNG.

Re: [PATCH v2 1/4] clk: samsung: add new Kconfig for Samsung common clock options

2014-03-19 Thread Tomasz Figa
Hi Pankaj, On 12.03.2014 05:32, Pankaj Dubey wrote: This patch adds new Kconfig file for adding new config option as COMMON_CLK_SAMSUNG for Samsung common clock. This patch also moves S3C24XX specific clock options here in this file. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com ---

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-19 Thread Tomasz Figa
On 19.03.2014 02:03, Cho KyongHo wrote: On Tue, 18 Mar 2014 16:09:50 +0100, Tomasz Figa wrote: On 18.03.2014 10:56, Cho KyongHo wrote: On Fri, 14 Mar 2014 13:59:00 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:08, Cho KyongHo wrote: [snip] @@ -637,11 +708,14 @@ static void

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-19 Thread Tomasz Figa
On 19.03.2014 01:39, Cho KyongHo wrote: On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Figa wrote: On 18.03.2014 14:01, Cho KyongHo wrote: On Fri, 14 Mar 2014 17:12:03 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: Some master device descriptor like fimc

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-19 Thread Tomasz Figa
On 19.03.2014 14:20, Tomasz Figa wrote: On 19.03.2014 01:39, Cho KyongHo wrote: On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Figa wrote: On 18.03.2014 14:01, Cho KyongHo wrote: On Fri, 14 Mar 2014 17:12:03 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: Some

Re: [PATCH v11 0/4] thermal: samsung: Clean up and add support for Exynos5420

2014-03-19 Thread Tomasz Figa
Hi Leela, On 19.03.2014 12:19, Leela Krishna Amudala wrote: Hi All, I didn't see this series in mainline, Any comments for this ? Naveen had posted v12 of this series and I believe all the patches got my Reviewed-by. Best regards, Tomasz -- To unsubscribe from this list: send the line

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-19 Thread Tomasz Figa
Hi Grant, On 19.03.2014 18:03, Grant Grundler wrote: On Wed, Mar 19, 2014 at 6:12 AM, Tomasz Figa t.f...@samsung.com wrote: ... No. Proper Linux drivers must support deferred probing mechanism and there should be no assumptions about probing orders. Using other initcall level than

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-19 Thread Tomasz Figa
On 19.03.2014 19:37, Grant Grundler wrote: On Wed, Mar 19, 2014 at 10:30 AM, Tomasz Figa t.f...@samsung.com wrote: ... As I said, AFAIK the trend is to get rid of ordering by initcalls and make sure that drivers can handle missing dependencies properly, even for services such as DMA, GPIO

Re: [PATCH v2 01/11] base: power: Add generic OF-based power domain look-up

2014-03-19 Thread Tomasz Figa
Hi Sören, On 20.03.2014 00:13, Sören Brinkmann wrote: On Mon, 2014-03-03 at 05:02PM +0100, Tomasz Figa wrote: This patch introduces generic code to perform power domain look-up using device tree and automatically bind devices to their power domains. Generic device tree binding is introduced

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-20 Thread Tomasz Figa
On 20.03.2014 11:03, Cho KyongHo wrote: On Wed, 19 Mar 2014 13:08:42 +0100, Tomasz Figa wrote: On 19.03.2014 10:01, Sachin Kamat wrote: On 19 March 2014 14:29, Cho KyongHo pullip@samsung.com wrote: On Tue, 18 Mar 2014 16:14:53 +0100, Tomasz Figa wrote: On 18.03.2014 12:09, Cho KyongHo

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-20 Thread Tomasz Figa
On 20.03.2014 11:22, Cho KyongHo wrote: On Wed, 19 Mar 2014 16:14:57 +0100, Tomasz Figa wrote: On 19.03.2014 14:20, Tomasz Figa wrote: On 19.03.2014 01:39, Cho KyongHo wrote: On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Figa wrote: On 18.03.2014 14:01, Cho KyongHo wrote: On Fri, 14 Mar 2014

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-21 Thread Tomasz Figa
On 21.03.2014 06:21, Cho KyongHo wrote: On Thu, 20 Mar 2014 11:54:58 +0100, Tomasz Figa wrote: On 20.03.2014 11:22, Cho KyongHo wrote: On Wed, 19 Mar 2014 16:14:57 +0100, Tomasz Figa wrote: On 19.03.2014 14:20, Tomasz Figa wrote: On 19.03.2014 01:39, Cho KyongHo wrote: On Tue, 18 Mar 2014

Re: [PATCHv4 0/5] devfreq: exynos: Fix minor issue and code clean to remove legacy method

2014-03-22 Thread Tomasz Figa
CONFIG_PM_OPP dependency to fix probe fail drivers/devfreq/Kconfig | 2 ++ drivers/devfreq/exynos/exynos4_bus.c | 43 ++-- drivers/devfreq/exynos/exynos5_bus.c | 7 -- 3 files changed, 34 insertions(+), 18 deletions(-) Reviewed-by: Tomasz Figa t.f

Re: [PATCH V2 01/20] thermal: exynos: Moving exynos thermal files into samsung directory

2013-05-07 Thread Tomasz Figa
On Tuesday 07 of May 2013 18:48:46 amit daniel kachhap wrote: Hi Tomasz Figa, On Tue, May 7, 2013 at 3:51 PM, Tomasz Figa t.f...@samsung.com wrote: On Monday 06 of May 2013 23:05:06 Zhang Rui wrote: On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: This movement of files

Re: [PATCH] ARM: exynos: Select PINCTRL_EXYNOS for exynos5

2013-05-09 Thread Tomasz Figa
extended with driver data for S5PV210 as well. I'd say that CPU_EXYNOS4210, SOC_EXYNOS4212, SOC_EXYNOS4412 and SOC_EXYNOS5250 should select PINCTRL_EXYNOS and SOC_EXYNOS5440 should be left as is, selecting PINCTRL_EXYNOS5440. Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution

Re: [PATCH v2 1/2] mmc: dw_mmc: Handle late vmmc regulators with EPROBE_DEFER

2013-06-07 Thread Tomasz Figa
On Friday 07 of June 2013 10:28:29 Doug Anderson wrote: It is possible to specify a regulator that should be turned on when dw_mmc is probed. At the moment dw_mmc will fail to use the regulator properly if the regulator probes after dw_mmc. Fix this problem by honoring EPROBE_DEFER. At

Re: [Arm-netbook] getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-07 Thread Tomasz Figa
On Friday 07 of June 2013 20:02:03 luke.leighton wrote: On Fri, Jun 7, 2013 at 9:57 AM, Tomasz Figa tomasz.f...@gmail.com wrote: Seeing from your posts you don't have any knowledge on how Linux kernel development works check back to 2004. $ git log --oneline --author=Luke Kenneth

Re: [Arm-netbook] getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-08 Thread Tomasz Figa
Luke, On Friday 07 of June 2013 22:29:34 luke.leighton wrote: On Fri, Jun 7, 2013 at 7:59 PM, Thomas Petazzoni thomas.petazz...@free-electrons.com wrote: Maxime will reply to this in more details, but I believe the status is: * Interrupt controller is working. * Clock drivers are

Re: [PATCH 1/3] ARM: dts: exynos4210: Add LCD related pinctrl entries

2013-06-08 Thread Tomasz Figa
Hi Tushar, Sachin, On Friday 07 of June 2013 16:37:13 Tushar Behera wrote: From: Sachin Kamat sachin.ka...@linaro.org Adds pinctrl entries required by FIMD. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org ---

Re: [PATCH 2/3] ARM: dts: Add FIMD node to Origen4210 board

2013-06-08 Thread Tomasz Figa
On Friday 07 of June 2013 16:37:14 Tushar Behera wrote: From: Sachin Kamat sachin.ka...@linaro.org Added FIMD and display timing node to Origen4210 board. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org ---

Re: [PATCH 2/2] clk: exynos4: Add alias for cpufreq related clocks

2013-06-08 Thread Tomasz Figa
On Thursday 06 of June 2013 16:52:28 Tushar Behera wrote: cpufreq driver for EXYNOS4 based SoCs are not platform drivers, hence we cannot currently pass the clock names through a device tree node. Instead, we need to make them available through a global alias. 'armclk', 'moutcore',

Re: [PATCH 1/3] ARM: dts: exynos4210: Add LCD related pinctrl entries

2013-06-10 Thread Tomasz Figa
On Monday 10 of June 2013 09:40:43 Tushar Behera wrote: On 06/08/2013 04:16 PM, Tomasz Figa wrote: Hi Tushar, Sachin, On Friday 07 of June 2013 16:37:13 Tushar Behera wrote: From: Sachin Kamat sachin.ka...@linaro.org Adds pinctrl entries required by FIMD. Signed-off-by: Sachin

Re: [PATCH 2/3] ARM: dts: Add FIMD node to Origen4210 board

2013-06-10 Thread Tomasz Figa
On Monday 10 of June 2013 09:44:14 Tushar Behera wrote: On 06/08/2013 04:19 PM, Tomasz Figa wrote: On Friday 07 of June 2013 16:37:14 Tushar Behera wrote: From: Sachin Kamat sachin.ka...@linaro.org Added FIMD and display timing node to Origen4210 board. Signed-off-by: Sachin Kamat

Re: [PATCH 2/2] clk: exynos4: Add alias for cpufreq related clocks

2013-06-10 Thread Tomasz Figa
On Monday 10 of June 2013 09:13:11 Tushar Behera wrote: On 06/08/2013 05:20 PM, Tomasz Figa wrote: On Thursday 06 of June 2013 16:52:28 Tushar Behera wrote: cpufreq driver for EXYNOS4 based SoCs are not platform drivers, hence we cannot currently pass the clock names through a device tree

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Tomasz Figa
Hi Doug, On Wednesday 12 of June 2013 10:33:19 Doug Anderson wrote: A level-triggered interrupt should be acked after the interrupt line becomes inactive and before it is unmasked, or else another interrupt will be immediately triggered. Acking before or after calling the handler is not

Re: [PATCH 1/3] pinctrl: exynos: Add spinlocks to irq_mask and irq_unmask

2013-06-13 Thread Tomasz Figa
the spinlock there. Right, that's correct. I always thought that the IRQ core already does some irqchip level locking, but it seems like I got confused by irq_desc spinlock. Thanks for spotting this. Acked-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz Signed-off-by: Doug Anderson diand

Re: [PATCH 2/3] pinctrl: exynos: reorder xyz_irq_unmask() so future patch can ack

2013-06-13 Thread Tomasz Figa
1 file changed, 26 insertions(+), 26 deletions(-) IMHO just moving _ack() above _mask() (or _unmask()) would be enough, without touching _mask() and _unmask() in this patch, but have my Acked-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz P.S. I think you might have missed linux-arm

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Tomasz Figa
On Thursday 13 of June 2013 09:34:43 Doug Anderson wrote: Tomasz, On Thu, Jun 13, 2013 at 3:54 AM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Doug, On Wednesday 12 of June 2013 10:33:19 Doug Anderson wrote: A level-triggered interrupt should be acked after the interrupt line

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Tomasz Figa
On Thursday 13 of June 2013 09:38:33 Doug Anderson wrote: Kukjin, On Thu, Jun 13, 2013 at 5:04 AM, Kukjin Kim kgene@samsung.com wrote: Doug Anderson wrote: A level-triggered interrupt should be acked after the interrupt line becomes inactive and before it is unmasked, or else

Re: [PATCH v2 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Tomasz Figa
parts 1 and 2, so not resending. drivers/pinctrl/pinctrl-exynos.c | 22 ++ 1 file changed, 22 insertions(+) Looks good. Thanks. Acked-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers/pinctrl/pinctrl-exynos.c

Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

2013-06-13 Thread Tomasz Figa
- SAMSUNG +M: Linus Walleij linus.wall...@linaro.org +M: Kukjin Kim kgene@samsung.com So actually this would be: M: Thomas Abraham thomas.abra...@linaro.org M: Tomasz Figa t.f...@samsung.com Thomas, do you agree on this? Best regards, Tomasz +L: linux-arm-ker

Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

2013-06-13 Thread Tomasz Figa
On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote: Tomasz, On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: It's convenient if get_maintainer suggests sending samsung/exynos pinctrl changes

Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

2013-06-13 Thread Tomasz Figa
On Friday 14 of June 2013 07:22:53 Kukjin Kim wrote: Tomasz Figa wrote: On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote: Tomasz, On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote

Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

2013-06-13 Thread Tomasz Figa
On Friday 14 of June 2013 07:22:53 Kukjin Kim wrote: Tomasz Figa wrote: On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote: Tomasz, On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote

Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

2013-06-13 Thread Tomasz Figa
On Friday 14 of June 2013 07:47:15 Kukjin Kim wrote: Tomasz Figa wrote: On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: It's convenient if get_maintainer suggests sending samsung/exynos pinctrl changes to linux-samsung-soc and to Kukjin. Add an entry for that. Well

Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

2013-06-13 Thread Tomasz Figa
On Friday 14 of June 2013 00:49:08 Tomasz Figa wrote: On Friday 14 of June 2013 07:22:53 Kukjin Kim wrote: Tomasz Figa wrote: On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote: Tomasz, On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa tomasz.f...@gmail.com wrote

Re: [PATCH 1/2] Initial support for Allwinner's Security ID fuses

2013-06-15 Thread Tomasz Figa
Hi, Some comments inline. On Saturday 15 of June 2013 01:16:20 Oliver Schinagl wrote: From: Oliver Schinagl oli...@schinagl.nl Allwinner has electric fuses (efuse) on their line of chips. This driver reads those fuses, seeds the kernel entropy and exports them as a sysfs node. These

[RFC PATCH] ARM: Add .init_platform() callback to machine descriptor

2013-06-15 Thread Tomasz Figa
, this problem has become a bit more inconvenient. This patch tries to solve this issue by introducing new callback called .init_platform(), where any custom low level initialization of platform can be done safely. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/include/asm/mach

[RFC PATCH 01/11] dma: amba-pl08x: Use bitmap to pass variant specific quirks

2013-06-16 Thread Tomasz Figa
Instead of defining new bool field in vendor_data struct for each quirk, it is more reasonable to use a single flags field and make each quirk use single bits. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/dma/amba-pl08x.c | 31 +-- 1 file changed, 17

[RFC PATCH 07/11] dmaengine: PL08x: Fix reading the byte count in cctl

2013-06-16 Thread Tomasz Figa
From: Alban Bedel alban.be...@avionic-design.de There are more fields than just SWIDTH in CH_CONTROL register, so read register value must be masked in addition to shifting. Signed-off-by: Alban Bedel alban.be...@avionic-design.de Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/dma

[RFC PATCH 08/11] dmaengine: PL08x: Add cyclic transfer support

2013-06-16 Thread Tomasz Figa
Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/dma/amba-pl08x.c | 181 +++ 1 file changed, 136 insertions(+), 45 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index bb3b36b..210a893 100644 --- a/drivers/dma

[RFC PATCH 11/11] ARM: s3c64xx: Add support for DMA using generic amba-pl08x driver

2013-06-16 Thread Tomasz Figa
through DMA resource, casted to unsigned long, but this is how Samsung DMA wrappers (used to support both s3c-dma and DMA engine in drivers) is designed. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/Kconfig | 1 + arch/arm/mach-s3c64xx/Kconfig

[RFC PATCH 10/11] ASoC: samsung: Do not require legacy DMA API in case of S3C64XX

2013-06-16 Thread Tomasz Figa
With support for amba-pl08x driver, on S3C64xx the generic DMA engine API can be used instead of the private s3c-dma interface. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- sound/soc/samsung/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/samsung

[RFC PATCH 09/11] spi: s3c64xx: Do not require legacy DMA API in case of S3C64XX

2013-06-16 Thread Tomasz Figa
With support for amba-pl08x driver, on S3C64xx the generic DMA engine API can be used instead of the private s3c-dma interface. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/Kconfig b

[RFC PATCH 06/11] dma: amba-pl08x: Keep LLIs aligned to 4-word boundary

2013-06-16 Thread Tomasz Figa
PL080 reference manual states that to LLI entries should be aligned to 4-word boundary to make LLI fetches more efficient. This patch adds a 3-word padding to the LLi struct to make this condition true. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/dma/amba-pl08x.c | 1 + 1 file

[RFC PATCH 03/11] dma: amba-pl08x: Add support for different offset of CONFIG register

2013-06-16 Thread Tomasz Figa
Some variants of PL08x (namely PL080S, found in Samsung S3C64xx SoCs) have CONFIG register at different offset. This patch makes the driver use offset from vendor data struct. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/dma/amba-pl08x.c | 51

[RFC PATCH 05/11] dma: amba-pl08x: Add support for different maximum transfer size

2013-06-16 Thread Tomasz Figa
transfer sizes fitting the original bitfield of PL080, but now would overwrite other fields. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/dma/amba-pl08x.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma

[RFC PATCH 04/11] dma: amba-pl08x: Add support for PL080S variant

2013-06-16 Thread Tomasz Figa
PL080S is a modified version of PL080 that can be found on Samsung SoCs, such as S3C6400 and S3C6410. It has different offset of CONFIG register, separate CONTROL1 register that holds transfer size and larger maximum transfer size. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers

[RFC PATCH 02/11] dma: amba-pl08x: Refactor pl08x_getbytes_chan() to lower indentation

2013-06-16 Thread Tomasz Figa
wherever possible. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/dma/amba-pl08x.c | 51 ++-- 1 file changed, 28 insertions(+), 23 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index d443a68..1e57ded 100644

[RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-16 Thread Tomasz Figa
: PL08x: Fix reading the byte count in cctl dmaengine: PL08x: Add cyclic transfer support Tomasz Figa (9): dma: amba-pl08x: Use bitmap to pass variant specific quirks dma: amba-pl08x: Refactor pl08x_getbytes_chan() to lower indentation dma: amba-pl08x: Add support for different offset

Re: [PATCH Resend] pinctrl: exynos: Fix build breakage

2013-06-17 Thread Tomasz Figa
Hi Sachin, On Monday 17 of June 2013 15:08:12 Sachin Kamat wrote: 'exynos_wkup_irq_ack' should be defined ahead of its call. Fixes the following error: drivers/pinctrl/pinctrl-exynos.c: In function ‘exynos_wkup_irq_mask’: drivers/pinctrl/pinctrl-exynos.c:299:3: error: implicit declaration

Re: [PATCH 1/2] Initial support for Allwinner's Security ID fuses

2013-06-17 Thread Tomasz Figa
On Monday 17 of June 2013 12:36:47 Oliver Schinagl wrote: On 15-06-13 12:28, Tomasz Figa wrote: Hi, Some comments inline. Thank you You're welcome. :) On Saturday 15 of June 2013 01:16:20 Oliver Schinagl wrote: From: Oliver Schinagl oli...@schinagl.nl Allwinner has electric

Re: [PATCH 1/2] Initial support for Allwinner's Security ID fuses

2013-06-17 Thread Tomasz Figa
On Monday 17 of June 2013 15:10:47 Oliver Schinagl wrote: On 17-06-13 14:51, Tomasz Figa wrote: On Monday 17 of June 2013 12:36:47 Oliver Schinagl wrote: On 15-06-13 12:28, Tomasz Figa wrote: Hi, Some comments inline. Thank you You're welcome. :) On Saturday 15 of June

Re: [RFC PATCH 01/11] dma: amba-pl08x: Use bitmap to pass variant specific quirks

2013-06-17 Thread Tomasz Figa
On Monday 17 of June 2013 19:48:56 Russell King - ARM Linux wrote: On Sun, Jun 16, 2013 at 10:54:08PM +0200, Tomasz Figa wrote: Instead of defining new bool field in vendor_data struct for each quirk, it is more reasonable to use a single flags field and make each quirk use single bits

Re: [RFC PATCH 03/11] dma: amba-pl08x: Add support for different offset of CONFIG register

2013-06-17 Thread Tomasz Figa
On Monday 17 of June 2013 19:52:23 Russell King - ARM Linux wrote: On Sun, Jun 16, 2013 at 10:54:10PM +0200, Tomasz Figa wrote: Some variants of PL08x (namely PL080S, found in Samsung S3C64xx SoCs) have CONFIG register at different offset. This patch makes the driver use offset from vendor

Re: [PATCH 1/2] Initial support for Allwinner's Security ID fuses

2013-06-17 Thread Tomasz Figa
drivers/misc/eeprom/sunxi_sid.c Looks good to me. Have my Reviewed-by: Tomasz Figa tomasz.f...@gmail.com Best regards, Tomasz diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig index 04f2e1f..c7bc6ed 100644 --- a/drivers/misc/eeprom/Kconfig +++ b/drivers/misc/eeprom/Kconfig

Re: [PATCH] of: irq: Pass trigger type in IRQ resource flags

2013-06-05 Thread Tomasz Figa
Hi, On Sunday 19 of May 2013 00:56:30 Tomasz Figa wrote: Some drivers might rely on availability of trigger flags in IRQ resource, for example to configure the hardware for particular interrupt type. However current code creating IRQ resources from data in device tree does not configure

Re: getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-05 Thread Tomasz Figa
Hi Luke, On Wednesday 05 of June 2013 22:15:08 Luke Kenneth Casson Leighton wrote: [i've just received word, please remove debian-release from discussions!] On Wed, Jun 5, 2013 at 9:46 PM, jonsm...@gmail.com jonsm...@gmail.com wrote: Why don't you try converting the sunxi code over to

Re: getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-05 Thread Tomasz Figa
On Wednesday 05 of June 2013 16:48:27 jonsm...@gmail.com wrote: On Wed, Jun 5, 2013 at 3:46 PM, Luke Kenneth Casson Leighton l...@lkcl.net wrote: On Fri, May 31, 2013 at 3:52 AM, Ben Hutchings b...@decadent.org.uk wrote: The 3.8.y branch is over, so I think we have to move to 3.9, ready

Re: getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-05 Thread Tomasz Figa
On Wednesday 05 of June 2013 22:16:37 Russell King - ARM Linux wrote: On Wed, Jun 05, 2013 at 03:00:13PM -0600, Stephen Warren wrote: 2) Having U-Boot itself read a DT and configure itself, just like the kernel does. This is relatively new, and only supported by a few boards (all Tegra to

Re: getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-05 Thread Tomasz Figa
On Wednesday 05 of June 2013 23:38:52 Luke Kenneth Casson Leighton wrote: On Wed, Jun 5, 2013 at 10:52 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Luke, allo tomasz :) ok - much of what you say is duplicated by what russell said, so in effect the same reply is relevant

Re: [Arm-netbook] getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-05 Thread Tomasz Figa
On Thursday 06 of June 2013 00:54:02 luke.leighton wrote: On Thu, Jun 6, 2013 at 12:40 AM, Henrik Nordström hen...@henriknordstrom.net wrote: tor 2013-06-06 klockan 00:26 +0100 skrev luke.leighton: no john - they've only added it to the multiplexed sections of the drivers which they

Re: [Arm-netbook] getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-06 Thread Tomasz Figa
Hi Thomas, On Thursday 06 of June 2013 11:27:23 Thomas Petazzoni wrote: Dear Tomasz Figa, On Thu, 06 Jun 2013 02:01:14 +0200, Tomasz Figa wrote: I don't see any other solution here than moving all the Allwinner code to DT (as it has been suggested in this thread several times already

Re: [PATCH] ARM: tegra: add basic SecureOS support

2013-06-06 Thread Tomasz Figa
Hi Alex, On Thursday 06 of June 2013 16:28:07 Alexandre Courbot wrote: Boot loaders on some Tegra devices can be unlocked but do not let the system operate without SecureOS. SecureOS prevents access to some registers and requires the operating system to perform certain operations through

Re: [Arm-netbook] getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-06 Thread Tomasz Figa
Luke, On Thursday 06 of June 2013 13:24:57 luke.leighton wrote: On Thu, Jun 6, 2013 at 1:01 AM, Tomasz Figa tomasz.f...@gmail.com wrote: I don't see any other solution here than moving all the Allwinner code to DT (as it has been suggested in this thread several times already

Re: [Arm-netbook] getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-06 Thread Tomasz Figa
On Thursday 06 of June 2013 13:49:38 luke.leighton wrote: On Thu, Jun 6, 2013 at 1:43 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Luke, On Thursday 06 of June 2013 13:24:57 luke.leighton wrote: On Thu, Jun 6, 2013 at 1:01 AM, Tomasz Figa tomasz.f...@gmail.com wrote: I don't see

Re: [Arm-netbook] getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-07 Thread Tomasz Figa
On Friday 07 of June 2013 08:52:43 luke.leighton wrote: On Thu, Jun 6, 2013 at 2:02 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On Thursday 06 of June 2013 13:49:38 luke.leighton wrote: On Thu, Jun 6, 2013 at 1:43 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Luke, On Thursday

Re: [PATCH 1/2] mmc: dw_mmc: Handle late vmmc regulator with EPROBE_DEFER

2013-06-07 Thread Tomasz Figa
Hi Doug, On Thursday 06 of June 2013 21:46:45 Doug Anderson wrote: It is possible to specify a regulator that should be turned on when dw_mmc is probed. This regulator is optional, though a warning will be printed if it's missing. The fact that the regulator is optional means that (at the

Re: [PATCH 1/2] mmc: dw_mmc: Handle late vmmc regulator with EPROBE_DEFER

2013-06-07 Thread Tomasz Figa
On Friday 07 of June 2013 11:24:04 Mark Brown wrote: On Fri, Jun 07, 2013 at 12:19:58PM +0200, Tomasz Figa wrote: On Thursday 06 of June 2013 21:46:45 Doug Anderson wrote: dw_mmc is probed. This regulator is optional, though a warning will be printed if it's missing. The fact

Re: [PATCH v6 4/8] ARM: Add .init_platform() callback to machine descriptor

2013-06-22 Thread Tomasz Figa
On Friday 21 of June 2013 16:12:15 Arnd Bergmann wrote: On Friday 21 June 2013, Tomasz Figa wrote: To me, this new hook is strictly equivalent to init_irq. What do we gain exactly? I didn't think init_irq was going away... I know init_irq is not pretty, and we tend to overload

Re: [PATCH v2 0/2] Clock update for EXYNOS4210-CPUFREQ driver

2013-06-22 Thread Tomasz Figa
global alias. The patches are based on next-20130618. Patch 1 has not been modified. Patch 2 has been updated to include EXYNOS4X12 releated clocks. Looks fine to me. Reviewed-by: Tomasz Figa t.f...@samsung.com Patch and changelogs look good to me now. Tomasz, any comments? I am

[PATCH v7 5/8] ARM: s3c64xx: Add board file for boot using Device Tree

2013-06-22 Thread Tomasz Figa
This patch adds board file that will be used to boot S3C64xx-based boards using Device Tree. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/mach-s3c64xx/Kconfig | 16 +++ arch/arm/mach-s3c64xx/Makefile | 1 + arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c | 85

Re: [PATCH v6 4/8] ARM: Add .init_platform() callback to machine descriptor

2013-06-22 Thread Tomasz Figa
Hi Kukjin, On Friday 21 of June 2013 02:35:20 Tomasz Figa wrote: Most ARM platforms have parts that should be initialized as early as possible, which usually means as soon as memory management (kmalloc, ioremap) starts to work, However, currently there is no appropriate callback

[RFC PATCH v2 00/12] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-22 Thread Tomasz Figa
dmaengine: PL08x: Add cyclic transfer support Tomasz Figa (10): dmaengine: PL08x: Refactor pl08x_getbytes_chan() to lower indentation dmaengine: PL08x: Add support for different offset of CONFIG register dmaengine: PL08x: Rework LLI handling to be less fragile dmaengine: PL08x: Add

[RFC PATCH v2 01/12] dmaengine: PL08x: Refactor pl08x_getbytes_chan() to lower indentation

2013-06-22 Thread Tomasz Figa
wherever possible. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/dma/amba-pl08x.c | 53 ++-- 1 file changed, 29 insertions(+), 24 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 06fe45c..6a12392 100644

[RFC PATCH v2 08/12] ASoC: Samsung: Do not queue cyclic buffers multiple times

2013-06-22 Thread Tomasz Figa
to the offset. This patch fixes this problem by making the legacy S3C-DMA API use the same semantics as DMA engine (the whole cyclic buffer is enqueued at once) and modifying users of Samsung DMA wrappers in cyclic mode to behave appropriately. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm

[RFC PATCH v2 07/12] dmaengine: PL08x: Add cyclic transfer support

2013-06-22 Thread Tomasz Figa
[tfiga: Rebase and slightly beautify the original patch.] Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/dma/amba-pl08x.c | 147 +-- 1 file changed, 118 insertions(+), 29 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma

[RFC PATCH v2 06/12] dmaengine: PL08x: Fix reading the byte count in cctl

2013-06-22 Thread Tomasz Figa
From: Alban Bedel alban.be...@avionic-design.de There are more fields than just SWIDTH in CH_CONTROL register, so read register value must be masked in addition to shifting. Signed-off-by: Alban Bedel alban.be...@avionic-design.de Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/dma

<    1   2   3   4   5   6   7   8   9   10   >