Re: [PATCH v9 22/22] uvc: use vb2 ioctl and fop helpers

2021-04-01 Thread Tomasz Figa
Hi Ricardo, On Fri, Mar 26, 2021 at 7:00 PM Ricardo Ribalda wrote: > > From: Hans Verkuil > > When uvc was written the vb2 ioctl and file operation helpers didn't exist. > > This patch switches uvc over to those helpers, which removes a lot of > boilerplate > code and simplifies VIDIOC_G/S_PRIO

Re: [PATCH v5 09/12] media: uvcvideo: Implement UVC_QUIRK_PRIVACY_DURING_STREAM

2021-04-19 Thread Tomasz Figa
On Wed, Dec 23, 2020 at 9:56 PM Ricardo Ribalda wrote: > > Hi again > > On Wed, Dec 23, 2020 at 9:31 AM Ricardo Ribalda wrote: > > > > Hi Laurent > > > > On Wed, Dec 23, 2020 at 9:05 AM Laurent Pinchart > > wrote: > > > > > > Hi Ricardo, > > > > > > On Tue, Dec 22, 2020 at 09:04:19PM +0100, Rica

Re: [PATCH v5 1/7] media: v4l2: Extend pixel formats to unify single/multi-planar handling (and more)

2020-11-18 Thread Tomasz Figa
On Sat, Nov 14, 2020 at 11:21:26AM -0300, Helen Koike wrote: > Hi Tomasz, > > On 10/2/20 4:49 PM, Tomasz Figa wrote: > > Hi Helen, > > > > On Tue, Aug 04, 2020 at 04:29:33PM -0300, Helen Koike wrote: [snip] > >> +static void v4l_print_ext_pix_for

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-12-08 Thread Tomasz Figa
#x27;ve seen still suggest that only the middle 3264x2448 are active pixels to be output, so this warrants double checking this with Omnivision. Let me see what we can do about this. Best regards, Tomasz > > On Fri, 27 Nov 2020 at 11:26, Tomasz Figa wrote: > > > > O

Re: [PATCH v3 5/6] media: uvcvideo: Use dma_alloc_noncontiguos API

2020-12-09 Thread Tomasz Figa
On Wed, Dec 9, 2020 at 10:05 PM Robin Murphy wrote: > > On 2020-12-09 11:12, Christoph Hellwig wrote: > > On Tue, Dec 08, 2020 at 01:54:00PM +0900, Tomasz Figa wrote: > >> >From the media perspective, it would be good to have the vmap > >> optional, similarly

Re: [PATCH v6 09/17] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-11-20 Thread Tomasz Figa
VM_IO | VM_PFNMAP mappings and > >> tell everyone to cut over to dma-buf memory sharing for zerocopy. > >> > >> userptr for normal memory will keep working as-is, this only affects > >> the zerocopy userptr usage enabled in 50ac952d2263 ("[media] > >&g

Re: [PATCH v5 7/7] media: docs: add documentation for the Extended API

2020-11-20 Thread Tomasz Figa
Hi Helen, On Tue, Aug 04, 2020 at 04:29:39PM -0300, Helen Koike wrote: > Add documentation and update references in current documentation for the > Extended API. > Thank you for the patch. Please see my comments inline. > Signed-off-by: Helen Koike > --- > Changes in v5: > - new patch > > ..

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-11-20 Thread Tomasz Figa
Hi Helen, On Tue, Aug 04, 2020 at 04:29:34PM -0300, Helen Koike wrote: > From: Hans Verkuil > > Those extended buffer ops have several purpose: > 1/ Fix y2038 issues by converting the timestamp into an u64 counting >the number of ns elapsed since 1970 > 2/ Unify single/multiplanar handling >

Re: [PATCH v6 09/17] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-11-20 Thread Tomasz Figa
t; mmu_notifier, without breaking how this all works. The only real fix > >>>>>> is to deprecate userptr support for VM_IO | VM_PFNMAP mappings and > >>>>>> tell everyone to cut over to dma-buf memory sharing for zerocopy. > >>>>>> > >>>

Re: [PATCH v5 7/7] media: docs: add documentation for the Extended API

2020-11-20 Thread Tomasz Figa
On Fri, Nov 20, 2020 at 9:24 PM Hans Verkuil wrote: > > On 20/11/2020 12:06, Tomasz Figa wrote:z > > Hi Helen, > > > > On Tue, Aug 04, 2020 at 04:29:39PM -0300, Helen Koike wrote: > >> Add documentation and update references in current documentation for the >

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-11-23 Thread Tomasz Figa
On Tue, Nov 24, 2020 at 12:08 AM Helen Koike wrote: > > Hi Hans, > > Thank you for your review. > > On 9/9/20 9:27 AM, Hans Verkuil wrote: > > Hi Helen, > > > > Again I'm just reviewing the uAPI. > > > > On 04/08/2020 21:29, Helen Koike wrote: > >> From: Hans Verkuil > >> > >> Those extended buff

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-24 Thread Tomasz Figa
Hi Robert, On Tue, Nov 17, 2020 at 12:52 AM Robert Foss wrote: > > Remove the 3280x2464 mode as it can't be reproduced and yields > an output resolution of 3264x2448 instead of the desired one. > > Furthermore the 3264x2448 resolution is the highest resolution > that the product brief lists. > >

Re: media: i2c: add OV02A10 image sensor driver

2020-12-03 Thread Tomasz Figa
On Fri, Dec 4, 2020 at 11:47 AM Dongchun Zhu wrote: > > Hi Andy, > > On Thu, 2020-12-03 at 20:10 +0200, Andy Shevchenko wrote: > > On Thu, Dec 3, 2020 at 8:03 PM Colin Ian King > > wrote: > > > > > Static analysis on linux-next with Coverity has detected an issue with > > > the following commit:

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-24 Thread Tomasz Figa
Hi Bingbu, On Wed, Nov 25, 2020 at 1:15 PM Bingbu Cao wrote: > > > > On 11/24/20 6:20 PM, Robert Foss wrote: > > On Tue, 24 Nov 2020 at 10:42, Bingbu Cao wrote: > >> > >> Hi, Robert > >> > >> I remember that the full size of ov8856 image sensor is 3296x2480 and we > >> can get the 3280x2464 > >

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-20 Thread Tomasz Figa
On Thu, Dec 17, 2020 at 10:20 PM Helen Koike wrote: > > Hi Tomasz, > > Thanks for your comments, I have a few questions below. > > On 12/16/20 12:13 AM, Tomasz Figa wrote: > > On Tue, Dec 15, 2020 at 11:37 PM Helen Koike > > wrote: > >> > >> Hi To

Re: [PATCH] media: venus: use contig vb2 ops

2021-03-01 Thread Tomasz Figa
Hi Alex, Stanimir, On Wed, Dec 16, 2020 at 12:15 PM Tomasz Figa wrote: > > On Wed, Dec 16, 2020 at 4:21 AM Nicolas Dufresne wrote: > > > > Le mardi 15 décembre 2020 à 15:54 +0200, Stanimir Varbanov a écrit : > > > Hi Tomasz, > > > > > > On 12/15/

Re: [PATCH] media: venus: use contig vb2 ops

2021-03-01 Thread Tomasz Figa
On Mon, Mar 1, 2021 at 7:22 PM Stanimir Varbanov wrote: > > > > On 3/1/21 11:23 AM, Tomasz Figa wrote: > > Hi Alex, Stanimir, > > > > On Wed, Dec 16, 2020 at 12:15 PM Tomasz Figa wrote: > >> > >> On Wed, Dec 16, 2020 at 4:21 AM Nicolas Dufresne &

Re: add a new dma_alloc_noncontiguous API v2

2021-02-08 Thread Tomasz Figa
Hi Christoph, On Mon, Feb 8, 2021 at 3:49 AM Christoph Hellwig wrote: > > Any comments? > Sorry for the delay. The whole series looks very good to me. Thanks a lot. Reviewed-by: Tomasz Figa Best regards, Tomasz > On Tue, Feb 02, 2021 at 10:51:03AM +0100, Christoph Hellwig wrote

Re: [PATCH v5 06/27] dt-bindings: mediatek: Add binding for mt8192 IOMMU

2021-01-24 Thread Tomasz Figa
On Wed, Jan 20, 2021 at 4:08 PM Yong Wu wrote: > > On Wed, 2021-01-20 at 13:15 +0900, Tomasz Figa wrote: > > On Wed, Jan 13, 2021 at 3:45 PM Yong Wu wrote: > > > > > > On Wed, 2021-01-13 at 14:30 +0900, Tomasz Figa wrote: > > > > On T

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-15 Thread Tomasz Figa
On Tue, Dec 15, 2020 at 11:37 PM Helen Koike wrote: > > Hi Tomasz, > > On 12/14/20 7:46 AM, Tomasz Figa wrote: > > On Fri, Dec 4, 2020 at 4:52 AM Helen Koike > > wrote: > >> > >> Hi, > >> > >> Please see my 2 points below (about v4l2

Re: [PATCH] media: venus: use contig vb2 ops

2020-12-15 Thread Tomasz Figa
On Wed, Dec 16, 2020 at 4:21 AM Nicolas Dufresne wrote: > > Le mardi 15 décembre 2020 à 15:54 +0200, Stanimir Varbanov a écrit : > > Hi Tomasz, > > > > On 12/15/20 1:47 PM, Tomasz Figa wrote: > > > On Tue, Dec 15, 2020 at 8:16 PM Stanimir Varbanov

Re: [PATCH v5 3/7] media: videobuf2: Expose helpers to implement the _ext_fmt and _ext_buf hooks

2020-12-14 Thread Tomasz Figa
Hi Helen, On Tue, Aug 04, 2020 at 04:29:35PM -0300, Helen Koike wrote: > The VB2 layer is used by a lot of drivers. Patch it to support the > _EXT_PIX_FMT and _EXT_BUF ioctls in order to ease conversion of existing > drivers to these new APIs. > > Note that internally, the VB2 core is now only us

Re: [PATCH v5 1/7] media: v4l2: Extend pixel formats to unify single/multi-planar handling (and more)

2020-12-14 Thread Tomasz Figa
On Thu, Nov 19, 2020 at 10:43 PM Helen Koike wrote: > > > > On 11/19/20 7:08 AM, Helen Koike wrote: > > Hi Tomasz, > > > > On 11/19/20 2:45 AM, Tomasz Figa wrote: > >> On Sat, Nov 14, 2020 at 11:21:26AM -0300, Helen Koike wrote: > >>> Hi Tomasz

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-14 Thread Tomasz Figa
On Tue, Nov 24, 2020 at 5:33 AM Helen Koike wrote: > > Hi Tomasz, > > > On 11/20/20 8:14 AM, Tomasz Figa wrote: > > Hi Helen, > > > > On Tue, Aug 04, 2020 at 04:29:34PM -0300, Helen Koike wrote: > >> From: Hans Verkuil > >> > >> Those

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-14 Thread Tomasz Figa
On Fri, Dec 4, 2020 at 12:11 AM Hans Verkuil wrote: > > On 23/11/2020 18:40, Helen Koike wrote: > > > > > > On 11/23/20 12:46 PM, Tomasz Figa wrote: > >> On Tue, Nov 24, 2020 at 12:08 AM Helen Koike > >> wrote: > >>> > >>> Hi Ha

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-14 Thread Tomasz Figa
On Fri, Dec 4, 2020 at 4:52 AM Helen Koike wrote: > > Hi, > > Please see my 2 points below (about v4l2_ext_buffer and another about > timestamp). > > On 12/3/20 12:11 PM, Hans Verkuil wrote: > > On 23/11/2020 18:40, Helen Koike wrote: > >> > >>

Re: [PATCH] media: venus: use contig vb2 ops

2020-12-15 Thread Tomasz Figa
> is always enforced. Since the device is supposed to be behind an IOMMU > this should have little to none practical consequences beyond making the > driver not rely on a particular behavior of the SG implementation. > > Reported-by: Tomasz Figa > Signed-off-by: Alexandre Courbo

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-15 Thread Tomasz Figa
On Mon, Dec 14, 2020 at 10:24 PM Helen Koike wrote: > > Hi Tomasz, > > Thank you for your comments, > > On 12/14/20 7:36 AM, Tomasz Figa wrote: > > On Tue, Nov 24, 2020 at 5:33 AM Helen Koike > > wrote: > >> > >> Hi Tomasz, > >> > &g

Re: [PATCH] media: venus: use contig vb2 ops

2020-12-15 Thread Tomasz Figa
//elixir.bootlin.com/linux/v5.10.1/source/drivers/iommu/dma-iommu.c#L782 > > > is always enforced. Since the device is supposed to be behind an IOMMU > > this should have little to none practical consequences beyond making the > > driver not rely on a particular behavior of the S

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-27 Thread Tomasz Figa
On Thu, Nov 26, 2020 at 7:00 PM Robert Foss wrote: > > On Wed, 25 Nov 2020 at 08:32, Tomasz Figa wrote: > > > > Hi Bingbu, > > > > On Wed, Nov 25, 2020 at 1:15 PM Bingbu Cao > > wrote: > > > > > > > > > > > > On 11/24/20

Re: [PATCH] media: vb2: always set buffer cache sync hints

2020-11-27 Thread Tomasz Figa
On Sat, Nov 28, 2020 at 1:35 AM Sergey Senozhatsky wrote: > > On (20/11/27 15:56), Hans Verkuil wrote: > > Yes. > > > > BTW, wouldn't it be sufficient to change this code to: > > > > if (!q->allow_cache_hints && q->memory != VB2_MEMORY_DMABUF) { > > vb->need_cache_sync_on_prepa

Re: [PATCH RFC 04/10] base: power: Add generic OF-based power domain look-up

2014-02-23 Thread Tomasz Figa
Hi Philipp, On 19.02.2014 17:53, Philipp Zabel wrote: Am Samstag, den 11.01.2014, 20:42 +0100 schrieb Tomasz Figa: [snip] + pd = of_genpd_get_from_provider(&pd_args); + if (IS_ERR(pd)) + return PTR_ERR(pd); + + dev_dbg(dev, "adding to power domain

Re: [PATCH v2] clk: respect the clock dependencies in of_clk_init

2014-02-23 Thread Tomasz Figa
Hi Gregory, On 10.02.2014 18:42, Gregory CLEMENT wrote: Until now the clock providers were initialized in the order found in the device tree. This led to have the dependencies between the clocks not respected: children clocks could be initialized before their parent clocks. Instead of forcing e

Re: [PATCH v2 1/4] ARM: EXYNOS: Add support for EXYNOS5410 SoC

2013-11-01 Thread Tomasz Figa
Hi Rob, On Friday 01 of November 2013 16:52:44 Rob Herring wrote: > On 10/14/2013 10:08 AM, Vyacheslav Tyrtov wrote: > > From: Tarek Dakhran > > > > EXYNOS5410 is SoC in Samsung's Exynos5 SoC series. > > Add initial support for this SoC. > > I think this entire patch is mostly unnecessary and t

Re: [PATCH v2 5/9] usb: gadget: s3c-hsotg: enable generic phy support

2013-11-02 Thread Tomasz Figa
Hi Matt. On Friday 01 of November 2013 15:45:54 Matt Porter wrote: > Adds support for the generic PHY subsystem. Generic PHY > support is probed and then the driver falls back to checking > for an old style USB PHY and pdata if not found. > > Signed-off-by: Matt Porter > --- > drivers/usb/gadge

Re: [PATCH v2 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls

2013-11-02 Thread Tomasz Figa
Hi Matt, On Friday 01 of November 2013 15:45:50 Matt Porter wrote: > This adds a pair of APIs that allows the generic PHY subsystem to > provide information on the PHY bus width. The PHY provider driver may > use phy_set_bus_width() to set the bus width that the PHY supports. > The controller driv

Re: [PATCH v2 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls

2013-11-02 Thread Tomasz Figa
On Saturday 02 of November 2013 13:47:09 Matt Porter wrote: > On Sat, Nov 02, 2013 at 10:46:55PM +0530, Kishon Vijay Abraham I wrote: > > Hi Tomasz, > > > > On Saturday 02 November 2013 06:44 PM, Tomasz Figa wrote: > > >Hi Matt, > > > > > >On Frida

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-04 Thread Tomasz Figa
Hi Kishon, On Monday 04 of November 2013 12:24:42 Kishon Vijay Abraham I wrote: > Hi Vivek, > > On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote: > > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > > The new driver uses the generic PHY framework and will interact > > wit

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-05 Thread Tomasz Figa
On Tuesday 05 of November 2013 12:50:18 Vivek Gautam wrote: > Hi Kishon, > > On Mon, Nov 4, 2013 at 6:42 PM, Kishon Vijay Abraham I wrote: > > Hi, > > > > On Monday 04 November 2013 03:45 PM, Kamil Debski wrote: > >> Hi Kishon, > >> > >>> From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > >

Re: [RFC 4/9] of/irq: Refactor interrupt-map parsing

2013-11-05 Thread Tomasz Figa
Following two patches seem to fully fix interrupt parsing issues, at least on Exynos 4210 Trats board. They must be applied without Grant's fixup patch, as it doesn't seem to fully solve the problem. Tomasz Figa (2): of: irq: Fix interrupt-map entry matching of: irq: Check for re

[PATCH 2/2] of: irq: Check for reg property presence only when parsing interrupt-map

2013-11-05 Thread Tomasz Figa
This patch fixes the of_irq_parse_raw() function to check for reg property only when really parsing interrupt map property, as it is not required otherwise and breaks existing device trees. Signed-off-by: Tomasz Figa --- drivers/of/irq.c | 21 +++-- 1 file changed, 11 insertions

[PATCH 1/2] of: irq: Fix interrupt-map entry matching

2013-11-05 Thread Tomasz Figa
This patch fixes interrupt-map entry matching code to properly match all specifier cells with interrupt map entries. Signed-off-by: Tomasz Figa --- drivers/of/irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/irq.c b/drivers/of/irq.c index 0ed5ed4..717eed4

Re: Boot failure on Arndale with next-20131105

2013-11-05 Thread Tomasz Figa
Hi, On Tuesday 05 of November 2013 17:19:00 Tushar Behera wrote: > Hi, > > We are having a boot-time kernel panic on Samsung's Exynos5250-based > Arndale board with next-20131105. Bisect points to following commit. > > <<< > commit febca1baea1cfe2d7a0271385d89b03d5fb34f94 > Author: Chris Mason

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Tomasz Figa
Hi Kishon On Wednesday 06 of November 2013 13:48:13 Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote: > > Add a new driver for the Exynos USB PHY. The new driver uses the generic > > PHY framework. The driver includes support for the Exynos 4x10 and

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Tomasz Figa
On Wednesday 06 of November 2013 18:20:36 Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 06 November 2013 05:08 PM, Tomasz Figa wrote: > > Hi Kishon > > > > On Wednesday 06 of November 2013 13:48:13 Kishon Vijay Abraham I wrote: > >> Hi, > >> >

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Tomasz Figa
Hi David, On Wednesday 06 of November 2013 13:03:45 David Laight wrote: > > > I just did a diff of registers in exynos 4210 and 4212 PHY drivers [1] > > > and couldn't find that big a difference in register layout. Of course > > > there are a few changes in HSIC bit fields and PHYFSEL but that's o

Re: Boot failure on Origen with next-20131107

2013-11-07 Thread Tomasz Figa
Hi Sachin, On Thursday 07 of November 2013 16:25:15 Sachin Kamat wrote: > Hi, > > Today's linux next fails to boot Origen (Exynos4210) board. However, > Arndale (Exynos5250) board boots fine. Git bisect points to the > following as bad commit: > > 2361613206e66ce59cc0e08efa8d98ec15b84ed1 is the

Re: [PATCH 1/2] of: irq: Fix interrupt-map entry matching

2013-11-07 Thread Tomasz Figa
November 2013 16:21:18 Tomasz Figa wrote: > This patch fixes interrupt-map entry matching code to properly match all > specifier cells with interrupt map entries. > > Signed-off-by: Tomasz Figa > --- > drivers/of/irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH 2/2] of: irq: Check for reg property presence only when parsing interrupt-map

2013-11-07 Thread Tomasz Figa
Hi, On Tuesday 05 of November 2013 16:21:36 Tomasz Figa wrote: > This patch fixes the of_irq_parse_raw() function to check for reg > property only when really parsing interrupt map property, as it is not > required otherwise and breaks existing device trees. > > Signed-off-

Re: [PATCH] thermal: exynos: handle gate clock for misplaced TRIMINFO register

2013-11-07 Thread Tomasz Figa
Hi Naveen, On Thursday 07 of November 2013 18:12:34 Naveen Krishna Chatradhi wrote: > On Exynos5420 the TMU(4) for GPU has a seperate clock enable bit from > the other TMU channels(0 ~ 3). Hence, accessing TRIMINFO for base_second > should be acompanied by enabling the respective clock. > > This

Re: [PATCH 1/3 v8] thermal: samsung: add intclr_fall_shift bit in exynos_tmu_register struct

2013-11-07 Thread Tomasz Figa
Hi Naveen, On Thursday 07 of November 2013 11:22:42 Naveen Krishna Chatradhi wrote: > On Exynos5250, the FALL interrupt related en, status and clear bits are > available at an offset of > 16 in INTEN, INTSTAT registers and at an offset of > 12 in INTCLEAR register. > > On Exynos5420, the FALL int

Re: [PATCH 3/3 v8] thermal: samsung: Add TMU support for Exynos5420 SoCs

2013-11-07 Thread Tomasz Figa
Hi Naveen, On Thursday 07 of November 2013 11:23:32 Naveen Krishna Chatradhi wrote: > This patch adds the neccessary register changes and arch information > to support Exynos5420 SoCs > Exynos5420 has 5 TMU channels one for each CPU 0, 1, 2 and 3 and GPU > > Also updated the Documentation at > Do

Re: [PATCHv2 0/5] ARM: dts: exynos: Add missing dt data to bring kernel of Exynos4x12

2014-03-12 Thread Tomasz Figa
xynos4412-trats2.dts | 21 + arch/arm/boot/dts/exynos4412.dtsi | 14 -- arch/arm/boot/dts/exynos4x12.dtsi | 26 ++ 5 files changed, 60 insertions(+), 19 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz -- To unsubscribe

Re: [RFC] dt: bindings: add bindings for Broadcom bcm43xx sdio devices

2014-03-13 Thread Tomasz Figa
Hi Arend, On 13.03.2014 11:16, Arend van Spriel wrote: On 02/25/2014 11:51 PM, Stephen Warren wrote: On 02/10/2014 12:17 PM, Arend van Spriel wrote: The Broadcom bcm43xx sdio devices are fullmac devices that may be integrated in ARM platforms. Currently, the brcmfmac driver for these devices s

Re: [PATCH v2 2/3] mfd: sec-core: Add of_compatible strings for MFD cells

2014-03-13 Thread Tomasz Figa
Hi Krzysztof, On 13.03.2014 10:37, Krzysztof Kozlowski wrote: Add of_compatible strings for MFD cells for regulator, clock and RTC drivers in S5M8767, S2MPS11 and S2MPS14 PMIC-s. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/sec-core.c |8 1 file changed, 8 insertions(+)

Re: [PATCH v2 2/3] mfd: sec-core: Add of_compatible strings for MFD cells

2014-03-13 Thread Tomasz Figa
On 13.03.2014 13:16, Krzysztof Kozlowski wrote: On Thu, 2014-03-13 at 13:07 +0100, Tomasz Figa wrote: Hi Krzysztof, On 13.03.2014 10:37, Krzysztof Kozlowski wrote: Add of_compatible strings for MFD cells for regulator, clock and RTC drivers in S5M8767, S2MPS11 and S2MPS14 PMIC-s. Signed-off

Re: [PATCH v2 3/3] Documentation: mfd: s2mps11: Describe S5M8767 and S2MPS14 clocks

2014-03-13 Thread Tomasz Figa
Hi Krzysztof, On 13.03.2014 10:37, Krzysztof Kozlowski wrote: Add bindings documentation for clocks on S5M8767 and S2MPS14 devices. Signed-off-by: Krzysztof Kozlowski Cc: Tomasz Figa Cc: devicet...@vger.kernel.org Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar

Re: [PATCH v2 1/3] clk: s2mps11: Add support for S2MPS14 clocks

2014-03-13 Thread Tomasz Figa
.c | 61 ++--- 2 files changed, 50 insertions(+), 19 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kerne

Re: [PATCH v11 11/27] clk: exynos: add gate clock descriptions of System MMU

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:06, Cho KyongHo wrote: This adds gate clocks of all System MMUs and their master IPs that are not apeared in clk-exynos5250.c and clk-exynos5420.c Also fixes GATE_IP_ACP to 0x18800 and changed GATE_DA to GATE for System MMU clocks in clk-exynos4.c Signed-off-by: Cho

Re: [PATCH v11 12/27] ARM: dts: Add description of System MMU of Exynos SoCs

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:06, Cho KyongHo wrote: This patch adds dts entries for the System MMU devices found on Exynos4 and Exynos5 SoC series and the System MMU binding documentation. CC: Rob Herring CC: Sylwester Nawrocki Signed-off-by: Cho KyongHo --- .../bindings/iommu/samsung,exyn

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:08, Cho KyongHo wrote: Runtime power management by exynos-iommu driver independently from master H/W's runtime pm is not useful for power saving since attaching master H/W in probing time turns on its local power endlessly. Thus this removes runtime pm API calls. Run

Re: [PATCH v11 08/27] iommu/exynos: always use a single clock descriptor

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:05, Cho KyongHo wrote: System MMU driver is changed to control only a single instance of System MMU at a time. Since a single instance of System MMU has only a single clock descriptor for its clock gating, there is no need to obtain two or more clock descriptors.

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:05, Cho KyongHo wrote: This patch uses managed device helper functions in the probe(). Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 64 +- 1 file changed, 26 insertions(+), 38 deletions(-) diff --git a/

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:09, Cho KyongHo wrote: This commit adds device tree support for System MMU. Signed-off-by: Cho KyongHo --- drivers/iommu/Kconfig|5 ++--- drivers/iommu/exynos-iommu.c | 21 + 2 files changed, 19 insertions(+), 7 deletions(-) d

Re: [PATCH v11 15/27] iommu/exynos: use convenient macro to handle gate clocks

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:09, Cho KyongHo wrote: exynos-iommu driver must care about master H/W's gate clock as well as System MMU's gate clock. To enhance readability of the source code, macros to gate/ungate those clocks are defined. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-i

Re: [PATCH v11 19/27] iommu/exynos: add support for power management subsystems.

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: This adds support for Suspend to RAM and Runtime Power Management. Since System MMU is located in the same local power domain of its master H/W, System MMU must be initialized before it is working if its power domain was ever turned off. TLB i

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: Some master device descriptor like fimc-is which is an abstraction of very complex H/W may have multiple System MMUs. For those devices, the design of the link between System MMU and its master H/W is needed to be reconsidered. A link structur

Re: RESEND [PATCH V9 2/2] ARM: dts: exynos5250: Enable ahci sata and sata phy

2014-03-14 Thread Tomasz Figa
Hi Yuvaraj, On 14.03.2014 09:25, Yuvaraj Kumar wrote: kgene, Please pick this patch. On Tue, Mar 4, 2014 at 7:02 PM, Kishon Vijay Abraham I wrote: On Tuesday 04 March 2014 04:40 PM, Yuvaraj Kumar C D wrote: This patch adds dt entry for ahci sata controller and its corresponding phy contro

Re: [PATCH] ARM: dts: exynos5250: turn on the LDO10 on SMDK5250

2014-03-14 Thread Tomasz Figa
Hi Yuvaraj, On 14.03.2014 09:26, Yuvaraj Kumar wrote: Any comments on this? On Mon, Mar 3, 2014 at 4:45 PM, Yuvaraj Kumar C D wrote: Commit 275dcd2 "ARM: dts: add max77686 pmic node for smdk5250" added required LDO's for SMDK5250 boards.Currently LDO10 is turned off.As LDO10, enable/disable t

Re: [PATCH] ARM: dts: exynos4210-trats: add max8997 IRQ

2014-03-14 Thread Tomasz Figa
ength of the pin". Also it would be nice to mention a reason for this change, e.g. what can be achieved after applying this patch. Otherwise looks good. Reviewed-by: Tomasz Figa -- Best regards, Tomasz Signed-off-by: Robert Baldyga --- arch/arm/boot/dts/exynos4210-trats.

Re: [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12

2014-03-14 Thread Tomasz Figa
Hi Chanwoo, Mark, On 14.03.2014 11:56, Chanwoo Choi wrote: Hi Mark, On 03/14/2014 07:35 PM, Mark Rutland wrote: On Fri, Mar 14, 2014 at 07:14:37AM +, Chanwoo Choi wrote: Hi Mark, On 03/14/2014 02:53 AM, Mark Rutland wrote: On Thu, Mar 13, 2014 at 08:17:29AM +, Chanwoo Choi wrote: T

Re: [PATCHv2 3/8] devfreq: exynos4: Add ppmu's clock control and code clean about regulator control

2014-03-14 Thread Tomasz Figa
Hi Chanwoo, On 13.03.2014 09:17, Chanwoo Choi wrote: There are not the clock controller of ppmudmc0/1. This patch control the clock of ppmudmc0/1 which is used for monitoring memory bus utilization. Also, this patch code clean about regulator control and free resource when calling exit/remove f

Re: [PATCHv2 4/8] devfreq: exynos4: Fix bug of resource leak and code clean on probe()

2014-03-14 Thread Tomasz Figa
Hi Chanwoo, On 13.03.2014 09:17, Chanwoo Choi wrote: This patch fix bug about resource leak when happening probe fail and code clean to add debug message. Signed-off-by: Chanwoo Choi --- drivers/devfreq/exynos/exynos4_bus.c | 32 ++-- 1 file changed, 26 insertion

Re: [PATCHv2 6/8] devfreq: exynos4: Fix power-leakage of clock on suspend state

2014-03-14 Thread Tomasz Figa
Hi Chanwoo, On 13.03.2014 09:17, Chanwoo Choi wrote: This patch disable ppmu clocks before entering suspend state to remove power-leakage and enable ppmu clocks on resume function. I don't think there is any need for this, because all the clocks are stopped anyway in SLEEP mode. Best regard

Re: [PATCHv2 0/8] devfreq: exynos4: Support dt and use common ppmu driver

2014-03-14 Thread Tomasz Figa
Hi Chanwoo, On 13.03.2014 09:17, Chanwoo Choi wrote: This patchset support devicetree and use common ppmu driver instead of individual code of exynos4_bus.c to remove duplicate code. Also this patchset get the resources for busfreq from dt data by using DT helper function. - PPMU register addres

Re: [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12

2014-03-15 Thread Tomasz Figa
On 15.03.2014 12:36, Kyungmin Park wrote: On Sat, Mar 15, 2014 at 2:35 AM, Tomasz Figa wrote: Hi Chanwoo, Mark, On 14.03.2014 11:56, Chanwoo Choi wrote: Hi Mark, On 03/14/2014 07:35 PM, Mark Rutland wrote: On Fri, Mar 14, 2014 at 07:14:37AM +, Chanwoo Choi wrote: Hi Mark, On 03

Re: [PATCH] clk: samsung: fixed compiler warning [-Wpointer-to-int-cast]

2014-03-17 Thread Tomasz Figa
Hi Pankaj, On 17.03.2014 02:22, Pankaj Dubey wrote: On 02/26/2014 11:42 AM, Pankaj Dubey wrote: When compiled using ARM64 cross compiler, gcc complains as drivers/clk/samsung/clk.c:293:18: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] Signed-off-by: Pankaj Du

Re: [PATCH v2 01/11] base: power: Add generic OF-based power domain look-up

2014-03-05 Thread Tomasz Figa
Hi Ulf, On 05.03.2014 08:19, Ulf Hansson wrote: @@ -2177,3 +2181,297 @@ void pm_genpd_init(struct generic_pm_domain *genpd, list_add(&genpd->gpd_list_node, &gpd_list); mutex_unlock(&gpd_list_lock); } + +#ifdef CONFIG_PM_GENERIC_DOMAINS_OF Do we need a new config for this? C

Re: [PATCH v2 01/11] base: power: Add generic OF-based power domain look-up

2014-03-05 Thread Tomasz Figa
On 04.03.2014 19:23, Stephen Boyd wrote: On 03/03, Tomasz Figa wrote: diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index dc127e5..006b455 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -3,12 +3,16 @@ * * Copyright (C) 2011 Rafael J

Re: [PATCH v2 01/11] base: power: Add generic OF-based power domain look-up

2014-03-05 Thread Tomasz Figa
On 05.03.2014 12:47, Tomasz Figa wrote: Hi Ulf, On 05.03.2014 08:19, Ulf Hansson wrote: @@ -2177,3 +2181,297 @@ void pm_genpd_init(struct generic_pm_domain *genpd, list_add(&genpd->gpd_list_node, &gpd_list); mutex_unlock(&gpd_list_lock)

Re: [PATCH v9 1/4] phy: core: Add an exported of_phy_get function

2014-03-05 Thread Tomasz Figa
changed, 42 insertions(+), 9 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Pleas

Re: [PATCH v9 2/4] phy: core: Add devm_of_phy_get to phy-core

2014-03-05 Thread Tomasz Figa
2 files changed, 39 insertions(+) Reviewed-by: Tomasz Figa Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html P

Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-05 Thread Tomasz Figa
mode 100644 drivers/phy/phy-exynos4210-usb2.c create mode 100644 drivers/phy/phy-exynos4x12-usb2.c create mode 100644 drivers/phy/phy-samsung-usb2.c create mode 100644 drivers/phy/phy-samsung-usb2.h Reviewed-by: Tomasz Figa Best regards, Tomasz -- To unsubscribe from this list: send the

Re: [PATCH v2 03/11] ARM: exynos: Move to generic power domain bindings

2014-03-05 Thread Tomasz Figa
Hi Bartek, On 05.03.2014 17:15, Bartlomiej Zolnierkiewicz wrote: Hi Tomek, On Monday, March 03, 2014 05:02:08 PM Tomasz Figa wrote: This patch moves Exynos power domain code to use the new generic power domain look-up framework introduced by previous patch, allowing the new code to be

Re: [PATCH v5 01/11] of: document bindings for reserved-memory nodes

2014-02-28 Thread Tomasz Figa
On 28.02.2014 10:54, Marek Szyprowski wrote: Hello, On 2014-02-26 12:51, Grant Likely wrote: On Fri, 21 Feb 2014 13:25:17 +0100, Marek Szyprowski wrote: > From: Grant Likely > > Reserved memory nodes allow for the reservation of static (fixed > address) regions, or dynamically allocated regio

Re: [PATCH v6 8/8] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-03-03 Thread Tomasz Figa
On 05.02.2014 18:30, Olof Johansson wrote: On Wed, Feb 5, 2014 at 7:57 AM, Kamil Debski wrote: Hi Olof, Thank you for your review. From: Olof Johansson [mailto:o...@lixom.net] Sent: Wednesday, January 29, 2014 9:55 PM Hi, On Wed, Jan 29, 2014 at 9:29 AM, Kamil Debski wrote: Change the

[PATCH v2 00/11] Generic Device Tree based power domain look-up

2014-03-03 Thread Tomasz Figa
e and allow error handling. Tomasz Figa (11): base: power: Add generic OF-based power domain look-up drivercore: Bind/unbind power domain on probe/remove ARM: exynos: Move to generic power domain bindings ARM: s3c64xx: pm: Use name field of generic_pm_domain ARM: s3c64xx: pm: Add alwa

[PATCH v2 11/11] ARM: dts: s3c6410-mini6410: Add support for LCD screen

2014-03-03 Thread Tomasz Figa
This patch adds necessary device tree nodes and properties to enable LCD screen on mini6410 board. Signed-off-by: Tomasz Figa --- arch/arm/boot/dts/s3c6410-mini6410.dts | 33 + 1 file changed, 33 insertions(+) diff --git a/arch/arm/boot/dts/s3c6410-mini6410.dts

[PATCH v2 09/11] ARM: dts: s3c64xx: Add nodes for power domains

2014-03-03 Thread Tomasz Figa
This patch adds device tree nodes for power domains available on S3C64xx SoCs. Signed-off-by: Tomasz Figa --- arch/arm/boot/dts/s3c6400.dtsi | 1 + arch/arm/boot/dts/s3c6410.dtsi | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/s3c6400.dtsi b/arch/arm/boot/dts/s3c6400

[PATCH v2 08/11] ARM: s3c64xx: dt: Enable SoC-level power management

2014-03-03 Thread Tomasz Figa
This patch adds call to s3c64xx_pm_init() from init_machine() callback of mach-s3c64xx-dt to enable SoC-level power management features, such as power domain management and sleep support. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c | 8 1 file changed, 8

[PATCH v2 07/11] ARM: s3c64xx: pm: Add device tree based power domain instantiation

2014-03-03 Thread Tomasz Figa
This patch adds support for registering power domains of S3C64xx SoCs and binding devices to them using device tree. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/pm.c | 71 + include/dt-bindings/arm/s3c64xx-power-domains.h | 26 + 2

[PATCH v2 05/11] ARM: s3c64xx: pm: Add always_on field to s3c64xx_pm_domain struct

2014-03-03 Thread Tomasz Figa
This patch adds always_on field to s3c64xx_pm_domain struct to allow handling registration of all domains in the same way, without the need to have separate arrays for normal and always on domains. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/pm.c | 21 - 1 file

[PATCH v2 10/11] ARM: dts: s3c64xx: Add node for display controller

2014-03-03 Thread Tomasz Figa
This patch adds device tree node for the display controller present on S3C64xx SoCs. Signed-off-by: Tomasz Figa --- arch/arm/boot/dts/s3c64xx.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/s3c64xx.dtsi b/arch/arm/boot/dts/s3c64xx.dtsi index 4e3be4d

[PATCH v2 03/11] ARM: exynos: Move to generic power domain bindings

2014-03-03 Thread Tomasz Figa
This patch moves Exynos power domain code to use the new generic power domain look-up framework introduced by previous patch, allowing the new code to be compiled with CONFIG_ARCH_EXYNOS selected as well. Signed-off-by: Tomasz Figa --- .../bindings/arm/exynos/power_domain.txt | 12

[PATCH v2 04/11] ARM: s3c64xx: pm: Use name field of generic_pm_domain

2014-03-03 Thread Tomasz Figa
This patch removes name field from private s3c64xx_pm_domain struct and moves domain name to dedicated field of generic_pm_domain struct. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/pm.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/arch/arm

[PATCH v2 02/11] drivercore: Bind/unbind power domain on probe/remove

2014-03-03 Thread Tomasz Figa
a driver. Signed-off-by: Tomasz Figa --- drivers/base/dd.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 0605176..78e5b36 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -23,6 +23,7 @@ #include #include

[PATCH v2 06/11] ARM: s3c64xx: pm: Add pwr_stat bit for domain G

2014-03-03 Thread Tomasz Figa
There is a status bit for domain G present in BLK_PWR_STAT register, but it is currently not specified in the driver. This patch adds the status bit of domain G to structure describing it. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/pm.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v2 01/11] base: power: Add generic OF-based power domain look-up

2014-03-03 Thread Tomasz Figa
-specific power domain bindings is provided, but for now the new code is not compiled when CONFIG_ARCH_EXYNOS is selected to avoid collision with legacy code. This will change as soon as Exynos power domain code gets converted to use the generic framework in further patch. Signed-off-by: Tomasz Figa

Re: [PATCHv2 3/8] devfreq: exynos4: Add ppmu's clock control and code clean about regulator control

2014-03-18 Thread Tomasz Figa
Hi Chanwoo, On 17.03.2014 06:59, Chanwoo Choi wrote: Hi Tomasz, On 03/17/2014 11:51 AM, Chanwoo Choi wrote: Hi Tomasz, On 03/15/2014 02:42 AM, Tomasz Figa wrote: Hi Chanwoo, On 13.03.2014 09:17, Chanwoo Choi wrote: There are not the clock controller of ppmudmc0/1. This patch control the

Re: [PATCHv2 4/8] devfreq: exynos4: Fix bug of resource leak and code clean on probe()

2014-03-18 Thread Tomasz Figa
On 17.03.2014 06:05, Chanwoo Choi wrote: Hi Tomasz, On 03/15/2014 02:49 AM, Tomasz Figa wrote: Hi Chanwoo, On 13.03.2014 09:17, Chanwoo Choi wrote: This patch fix bug about resource leak when happening probe fail and code clean to add debug message. Signed-off-by: Chanwoo Choi

<    2   3   4   5   6   7   8   9   10   11   >