Re: [PATCH] omap2-clk: Add missing lcdc clock definition

2012-10-30 Thread Tony Lindgren
* Pantelis Antoniou [121030 11:04]: > Looks like the lcdc clock definition got dropped. > It is required for the LCD controller to work. Reintroduce. This looks like a regression, can you also add the commit causing it? Regards, Tony > Signed-off-by: Pantelis Antoniou > --- > arch/arm/mach-

Re: [PATCH] omap: Export various omap_hwmod related functions

2012-10-30 Thread Tony Lindgren
* Pantelis Antoniou [121030 11:05]: > omap_hwmod_lookup / omap_device_build / omap_device_build_ss; > these functions can be used just fine by modules, there's no need not > to have them exported. Just curious, where do you plan to use these? These will be private to arch/arm/mach-omap2 and won'

Re: [PATCH] gpio-keys: Pinctrl-fy

2012-10-30 Thread Tony Lindgren
* Pantelis Antoniou [121030 11:23]: > Enable pinctrl support for gpio-keys. There's some discussion going on regarding doing the pinctrl boilerplate things somewhere else started by Dmitry, but meanwhile: Acked-by: Tony Lindgren > Signed-off-by: Pantelis Antoniou > --- &g

Re: [PATCH] w1-gpio: Pinctrl-fy

2012-10-30 Thread Tony Lindgren
* Pantelis Antoniou [121030 11:17]: > Enable pinctrl for w1-gpio. > > Signed-off-by: Pantelis Antoniou Acked-by: Tony Lindgren > --- > drivers/w1/masters/w1-gpio.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/w1/masters/w1-gpio.c b/driv

Re: [RFC 2/7] capebus: Add beaglebone board support

2012-10-30 Thread Tony Lindgren
* Pantelis Antoniou [121030 12:00]: > +#include > +#include We already have queued patches to make omap_device.h private to arch/arm/mach-omap2. Then plat/clock.h will be gone with the common clock framework patches. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe l

Re: [RFC 2/7] capebus: Add beaglebone board support

2012-10-30 Thread Tony Lindgren
* Pantelis Antoniou [121030 12:00]: > + > + priv->lcdc_oh = omap_hwmod_lookup("lcdc"); > + if (priv->lcdc_oh == NULL) { > + dev_err(&pdev->dev, "Failed to lookup omap_hwmod lcdc\n"); > + return -ENODEV; > + } > + > + priv->lcdc_pdev = omap_device_build("da8x

Re: [RFC 2/7] capebus: Add beaglebone board support

2012-10-30 Thread Tony Lindgren
* Pantelis Antoniou [121030 13:18]: > On Oct 30, 2012, at 9:39 PM, Tony Lindgren wrote: > > > * Pantelis Antoniou [121030 12:00]: > >> + > >> + priv->lcdc_oh = omap_hwmod_lookup("lcdc"); > >> + if (priv->lcdc_oh == NULL) { > >>

Re: [PATCH 3/3] ARM: OMAP2+: Add SSI driver configuration

2013-08-26 Thread Tony Lindgren
* Sebastian Reichel [130823 11:27]: > On Fri, Aug 23, 2013 at 03:58:30PM +0200, Linus Walleij wrote: > > On Mon, Aug 12, 2013 at 10:30 AM, Tony Lindgren wrote: > > > * Sebastian Reichel [130811 09:25]: > > >> From: Sebastian Reichel > > >> > >

Re: [PATCH v3 03/10] ARM: OMAP2+: omap-usb-host: Get rid of platform_data from struct usbhs_phy_data

2013-10-02 Thread Tony Lindgren
nch against -rc3 that we can all merge in as needed. For this patch: Acked-by: Tony Lindgren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 04/10] ARM: OMAP2+: usb-host: Adapt to USB phy-nop RESET line changes

2013-10-02 Thread Tony Lindgren
> > Need your Ack on this one as well. Acked-by: Tony Lindgren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 3/6] pinctrl: single: Prepare for supporting SoC specific features

2013-10-02 Thread Tony Lindgren
linux-kernel@vger.kernel.org Signed-off-by: Roger Quadros Signed-off-by: Tony Lindgren --- drivers/pinctrl/pinctrl-single.c | 38 +- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c

[PATCH 4/6] pinctrl: single: Add support for wake-up interrupts

2013-10-02 Thread Tony Lindgren
er Ujfalusi Cc: Grygorii Strashko Cc: Prakash Manjunathappa Cc: Roger Quadros Cc: Haojian Zhuang Cc: Linus Walleij Cc: linux-kernel@vger.kernel.org Cc: Benoît Cousson Cc: devicet...@vger.kernel.org Signed-off-by: Tony Lindgren --- .../devicetree/bindings/pinctrl/pinctrl-single.txt | 11 +

[PATCH 5/6] pinctrl: single: Add support for auxdata

2013-10-02 Thread Tony Lindgren
a Cc: Roger Quadros Cc: Haojian Zhuang Cc: Linus Walleij Cc: linux-kernel@vger.kernel.org Signed-off-by: Tony Lindgren --- drivers/pinctrl/pinctrl-single.c | 23 +++ include/linux/platform_data/pinctrl-single.h | 12 2 files changed, 35 inser

Re: [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts

2013-10-03 Thread Tony Lindgren
* Tony Lindgren [131002 22:51]: > --- a/drivers/pinctrl/pinctrl-single.c > +++ b/drivers/pinctrl/pinctrl-single.c > +/** > + * pcs_irq_set() - enables or disables an interrupt > + * > + * Note that this currently assumes one interrupt per pinctrl > + * register that is typic

Re: [PATCH 1/2] hwspinlock/omap: add support for dt nodes

2013-10-03 Thread Tony Lindgren
is should be safe for Ohad to queue: Acked-by: Tony Lindgren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] ARM: OMAP: remove deprecated IRQF_DISABLED

2013-10-03 Thread Tony Lindgren
* Michael Opdenacker [130907 00:27]: > This patch proposes to remove the IRQF_DISABLED flag from OMAP code > It's a NOOP since 2.6.35, and will be removed one day. Thanks, applying into omap-for-v3.13/fixes-not-urgent. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCH 1/2] hwspinlock/omap: add support for dt nodes

2013-10-03 Thread Tony Lindgren
* Suman Anna [131003 11:25]: > Tony, > > On 10/03/2013 01:05 PM, Tony Lindgren wrote: > > * Suman Anna [130903 11:00]: > >> HwSpinlock IP is present only on OMAP4 and other newer SoCs, > >> which are all device-tree boot only. This patch adds the > >>

Re: [PATCH] ARM: omap1: fix incorrect placement of __initdata tag

2013-10-03 Thread Tony Lindgren
* Bartlomiej Zolnierkiewicz [130930 06:13]: > __initdata tag should be placed between the variable name and equal > sign for the variable to be placed in the intended .init.data section. Thanks applying into omap-for-v3.13/fixes-not-urgent. Tony -- To unsubscribe from this list: send the line "u

Re: [PATCH 4/8] ARM: OMAP: build mach-omap code only if needed

2013-07-08 Thread Tony Lindgren
reference to > `pwrdm_can_ever_lose_context' > > We can avoid this if we make CONFIG_ARCH_OMAP2PLUS a silent option that > gets enabled any time that one of the SoC versions is enabled. > > Cc: Tony Lindgren > Signed-off-by: Arnd Bergmann Sounds like there's some

Re: [PATCH 6/8] ARM: OMAP: omap_common_late_init may be unused

2013-07-08 Thread Tony Lindgren
igned-off-by: Arnd Bergmann Acked-by: Tony Lindgren > --- > arch/arm/mach-omap2/io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c > index fe3253a..4a3f06f 100644 > --- a/arch/arm/mach-omap2/io.c >

Re: [PATCH 2/8] ARM: omap5: omap5 has SCU and TWD

2013-07-08 Thread Tony Lindgren
* Arnd Bergmann [130705 09:28]: > These are selected by omap4 but used in common omap4/5 > SMP code, so building an omap5-only kernel is actually > broken without this patch. > > Signed-off-by: Arnd Bergmann Acked-by: Tony Lindgren > arch/arm/mach-omap2/Kconfig | 2 ++ &g

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-07-10 Thread Tony Lindgren
* Linus Walleij [130710 13:42]: > On Thu, Jun 27, 2013 at 4:01 PM, Grygorii Strashko > wrote: > > > I think, In the future the OMAP pinctrl configurations would be manged in > > more flexible way then now (thanks to "pinctrl PM helpers" and you;)) > > - "Idle" state will be splitted to "Idle"/"s

Re: [PATCH v4 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1

2013-09-17 Thread Tony Lindgren
* Dave Martin [130916 10:18]: > On Sat, Sep 14, 2013 at 10:37:12AM +0100, Pali Rohár wrote: > > On Sunday 08 September 2013 09:43:29 Pali Rohár wrote: > > > + */ > > > +ENTRY(omap_smc3) > > > + stmfd sp!, {r4-r11, lr} > > > + mov r12, r0 @ Copy the secure service ID > > > + mov r

Re: [PATCH v4 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1

2013-09-17 Thread Tony Lindgren
* Pali Rohár [130917 09:01]: > On Tuesday 17 September 2013 17:43:31 Tony Lindgren wrote: > > Have you guys checked how this works with the recently posted > > "[PATCH v6 0/5] ARM: support for Trusted Foundations secure > > monitor" series? > > this co

Re: [PATCH v2 2/2] RX-51: ARM errata 430973 workaround

2013-09-17 Thread Tony Lindgren
* Pali Rohár [130710 06:06]: > --- a/arch/arm/mach-omap2/board-rx51.c > +++ b/arch/arm/mach-omap2/board-rx51.c This file will be gone as soon as we're moving to device tree based booting. So let's do this in more future proof way. > +/** > + * rx51_secure_dispatcher: Routine to dispatch secure P

Re: ARM: OMAP2: Make MACH_OMAP3EVM select NOP_USB_XCEIV

2013-09-17 Thread Tony Lindgren
* Josh Boyer [130904 06:46]: > The board-omap3evm.c file unconditionally calls usb_nop_xceiv_register but > doesn't ensure this is built-in. This can lead to build failures like: > > arch/arm/mach-omap2/built-in.o: In function `omap3_evm_init': > linux-3.12.0-0.rc0.git2.1.fc21.armv7hl/arch/arm/m

Re: [PATCH] mailbox: remove unnecessary platform_set_drvdata()

2013-09-17 Thread Tony Lindgren
* Suman Anna [130823 09:50]: > + OMAP mailing list > > Tony, > Can you pick up this minor cleanup patch? > > regards > Suman > > On 08/21/2013 09:10 PM, Jingoo Han wrote: > > The driver core clears the driver data to NULL after device_release > > or on probe failure. Thus, it is not needed to m

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-17 Thread Tony Lindgren
* Aaro Koskinen [130907 16:10]: > Hi, > > On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár wrote: > > > --- /dev/null > > > +++ b/arch/arm/mach-omap2/board-rx51-camera.c > [...] > > Ping, can you review this patch v2? > > I don't think Tony will accept any new board stuff for RX-51/N900. > S

Re: [PATCH v2 2/2] RX-51: ARM errata 430973 workaround

2013-09-18 Thread Tony Lindgren
* Pali Rohár [130918 01:41]: > > I'm not very happy. I sent this patch 6 months ago and only now > you commented that needs rework again. This patch is needed > because all thumb-2 userspace binaries crashing. I want to have > working support for Nokia N900 and not always rebasing and > changi

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-18 Thread Tony Lindgren
* Pali Rohár [130918 09:08]: > On Wednesday 18 September 2013 15:16:44 Pavel Machek wrote: > > On Sun 2013-09-08 02:02:52, Aaro Koskinen wrote: > > > Hi, > > > > > > On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár wrote: > > > > > --- /dev/null > > > > > +++ b/arch/arm/mach-omap2/board-rx51-

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-18 Thread Tony Lindgren
* Javier Martinez Canillas [130918 07:20]: > > Hi Tony, > > I don't know if OMAP2+ DT will happen soon as you said. At least I > know about a big issue we had with GPIO pins not being auto-requested > when are mapped as IRQ. You can refer to [1] for the latest approach > and how this discussion

Re: [PATCH v2 2/2] RX-51: ARM errata 430973 workaround

2013-09-18 Thread Tony Lindgren
* Pali Rohár [130918 11:21]: > On Wednesday 18 September 2013 19:18:17 Tony Lindgren wrote: > > > > Hmm hasn't there been pending comments until recently on your > > patches? > > > > Since 10.07.2013 I do not have any emails for patch 2/2. If I > misse

Re: [PATCH] ARM: OMAP4 SMP: Corrected a typo fucntions to functions

2013-09-18 Thread Tony Lindgren
* Anoop Thomas Mathew [130906 20:55]: > Corrected the functions spelling mistake in the OMAP4 SMP source file. > > Signed-off-by: Anoop Thomas Mathew Thanks applying into omap-for-v3.12/fixes. Tony > --- > arch/arm/mach-omap2/omap-smp.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [RFCv2 2/3] ARM: OMAP2+: HSI: Introduce OMAP SSI driver

2013-09-18 Thread Tony Lindgren
* Sebastian Reichel [130915 13:56]: > This patch adds an OMAP SSI driver to the HSI framework. Thanks for working on this. > +config OMAP_SSI > + tristate "OMAP SSI hardware driver" > + depends on ARCH_OMAP && HSI > + default n > + ---help--- > + SSI is a legacy version of

Re: [PATCH v3 2/2] RX-51: ARM errata 430973 workaround

2013-09-18 Thread Tony Lindgren
* Pali Rohár [130918 12:29]: > Hello Tony, > > here is new v3 patch. I just only moved functions rx51_secure_dispatcher and > rx51_secure_update_aux_cr to omap-secure.c and added header to omap-secure.h > Because I only moved two functions to other source file I tested only > compilation. > It i

Re: [PATCH 2/2] RX-51: Add support for OMAP3 ROM Random Number Generator

2013-09-18 Thread Tony Lindgren
* Pali Rohár [130918 13:15]: > Signed-off-by: Pali Rohár Description please, then also add a note that this makes sense to do as a platform device at least until we have some ARM generic way to deal with SMC calls. > arch/arm/mach-omap2/board-rx51.c | 10 ++ > arch/arm/mach-omap2/om

Re: [PATCH] RX-51: Add missing max_current to rx51_lp5523_led_config

2013-09-18 Thread Tony Lindgren
* Pali Rohár [130918 15:02]: > Without max_current data in board file lp5523 driver does not change current. Hmm is this a regression or are there other reasons to merge this during the -rc cycle? Regards, Tony > Signed-off-by: Pali Rohár > --- > arch/arm/mach-omap2/board-rx51-peripherals.c

Re: [PATCH] RX-51: Add missing max_current to rx51_lp5523_led_config

2013-09-19 Thread Tony Lindgren
* Pali Rohár [130919 14:10]: > On Thursday 19 September 2013 00:26:43 Tony Lindgren wrote: > > * Pali Rohár [130918 15:02]: > > > Without max_current data in board file lp5523 driver does > > > not change current. > > > > Hmm is this a regression or ar

Re: [PATCH v2 1/3] omap2: Change clk dev id for rng to omap3-rom-rng

2013-09-20 Thread Tony Lindgren
* Pali Rohár [130920 06:33]: > Name omap_rng is already used by omap_rng driver which is for omap2 and omap4. > For omap3 HS devices there is new driver omap3-rom-rng which needs that clk. > And because there cannot be two drivers with same name, rename omap3 clk dev > id. > > Signed-off-by: Pal

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-20 Thread Tony Lindgren
* Pali Rohár [130919 15:38]: > On Wednesday 18 September 2013 19:42:12 Tony Lindgren wrote: > > * Pali Rohár [130918 09:08]: > > > On Wednesday 18 September 2013 15:16:44 Pavel Machek wrote: > > > > On Sun 2013-09-08 02:02:52, Aaro Koskinen wrote: > > > &

Re: [PATCH v2 1/3] omap2: Change clk dev id for rng to omap3-rom-rng

2013-09-20 Thread Tony Lindgren
* Pali Rohár [130920 09:49]: > On Friday 20 September 2013 18:23:43 Tony Lindgren wrote: > > * Pali Rohár [130920 06:33]: > > > Name omap_rng is already used by omap_rng driver which is > > > for omap2 and omap4. For omap3 HS devices there is new > > > drive

Re: [PATCH v2 1/3] omap2: Change clk dev id for rng to omap3-rom-rng

2013-09-20 Thread Tony Lindgren
* Pali Rohár [130920 11:32]: > On Friday 20 September 2013 19:46:41 Tony Lindgren wrote: > > Ok, then there is new patch which only adding omap3-rom-rng and not removing > omap_rng. > It is OK to have same CLK data but with different names? Yes in this case it's always eith

Re: [PATCH v4 5/5] clk: dt: binding for basic gate clock

2013-09-04 Thread Tony Lindgren
* Haojian Zhuang [130903 20:11]: > > We can see that it'll try to find static mapping. What's the static mapping? > If we define iotable in machine driver, we have the static mapping, just like > debug_ll. If we parse everything from DTS file, it'll always get a new virtual > address from vm area

Re: [PATCH v4 2/4] ARM: dts: am335x-boneblack: add eMMC DT entry

2013-09-13 Thread Tony Lindgren
* Koen Kooi [130912 11:43]: > The pinmux is specified in am335x-bone-common.dtsi to be reused by the eMMC > cape. > > Signed-off-by: Koen Kooi > --- > arch/arm/boot/dts/am335x-bone-common.dtsi | 22 ++ > arch/arm/boot/dts/am335x-boneblack.dts| 14 ++ > 2 fil

Re: [PATCH 3/6] pinctrl: single: Prepare for supporting SoC specific features

2013-10-07 Thread Tony Lindgren
Hi Linus W, Any comments on the pinctrl patches 3 - 5 in this series? These are badly needed to not break omap3 PM support when we're moving to device tree based booting. * Tony Lindgren [131002 22:50]: > Let's replace is_pinconf with flags and add struct pcs_soc_data > so we

Re: [PATCH 1/2] Documentation: dt: OMAP: standardize SoC naming definition

2013-10-07 Thread Tony Lindgren
Hi, Few comments below. * Nishanth Menon [131007 09:57]: > SoC family definitions at the moment are reactive to board needs > as a result, beagle-xm would matchup with ti,omap3 which invokes > omap3430_init_early instead of omap3630_init_early. Obviously, this is > the wrong behavior. It seems

Re: [PATCH 2/2] ARM: dts: omap3-beagle: use 3630 definitions

2013-10-07 Thread Tony Lindgren
* Nishanth Menon [131007 09:57]: > beagle-xm currently would matchup with ti,omap3 which invokes > omap3430_init_early instead of omap3630_init_early. So add > compatiblity for 3630 to allow match > > Signed-off-by: Nishanth Menon > --- > arch/arm/boot/dts/omap3-beagle-xm.dts |2 +- > 1 fil

Re: [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts

2013-10-08 Thread Tony Lindgren
* Linus Walleij [131008 05:18]: > On Thu, Oct 3, 2013 at 7:42 AM, Tony Lindgren wrote: > > > This patch adds support for interrupts in a way that > > should be pretty generic, and works for the omaps that > > support wake-up interrupts. On omaps, there's an >

Re: [PATCH 3/6] pinctrl: single: Prepare for supporting SoC specific features

2013-10-08 Thread Tony Lindgren
* Linus Walleij [131008 05:03]: > On Mon, Oct 7, 2013 at 7:35 PM, Tony Lindgren wrote: > > > Hi Linus W, > > > > Any comments on the pinctrl patches 3 - 5 in this series? > > I have no problems with this patch #3, as it is just changing syntax, > not semant

Re: [RFCv3 0/7] OMAP SSI driver

2013-10-08 Thread Tony Lindgren
* Sebastian Reichel [131006 13:36]: > Hi, > > Here is the third round of the OMAP SSI driver patches. Thanks for updating these, they look good to me now: Acked-by: Tony Lindgren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH] ARM: mach-omap2: board-generic: fix undefined symbol

2013-10-08 Thread Tony Lindgren
* Simon Barth [131008 01:58]: > Since dra7 reuses the function 'omap5_realtime_timer_init' in > arch/arm/mach-omap2/board-generic.c as timer init function, it has to be > built for this SoC as well. Thanks applying into omap-for-v3.12/fixes. Regards, Tony > Signed-off-by: Simon Barth > ---

Re: [PATCH V3] ARM: OMAP3: Fix hardware detection for omap3630 when booted with device tree

2013-10-08 Thread Tony Lindgren
dle+0xd4/0xf8() omap_hwmod: timer12: idle state can only be entered from enabled state WARNING: CPU: 0 PID: 1 at arch/arm/mach-omap2/omap_hwmod.c:2126 _enable+0x254/0x280() omap_hwmod: uart4: enabled state can only be entered from initialized, idle, or disabled state So, add specific compatiblity fo

Re: [PATCH] ARM: mach-omap1: Fix omap1510_fpga_init_irq() implicit declarations.

2013-10-08 Thread Tony Lindgren
quite a while. Regards, Tony > Signed-off-by: Manjunath Goudar > Cc: Tony Lindgren > Cc: Russell King > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-o...@vger.kernel.org > --- > arch/arm/mach-omap1/common.h |3 +++ > 1

Re: [PATCH RFC 5/6] ARM: dts: AM335x: prcm node (for reset)

2013-10-08 Thread Tony Lindgren
* Afzal Mohammed [130902 07:30]: > Add AM335x prcm node with reset binding. Please put the .dts changes into a separate series from driver changes so the driver maintainers don't accidentally queue also the .dts changes. This is to avoid pointless self-inflicted merge conflicts. Regards, Tony

Re: [PATCH RFC 4/6] ARM: OMAP2+: AM43x/AM335x: have reset controller

2013-10-08 Thread Tony Lindgren
* Afzal Mohammed [130902 07:27]: > AM43x, AM335x have reset block as part of prcm, let reset driver be > usable with these SoC's. Once the driver is ready, this can be merged along with the reset driver: Acked-by: Tony Lindgren > Signed-off-by: Afzal Mohammed > --- >

Re: [PATCH v2] RX-51: Add missing max_current to rx51_lp5523_led_config

2013-10-08 Thread Tony Lindgren
* joerg Reisenweber [130923 06:14]: > On Mon 23 September 2013 14:50:12 Pali Rohár wrote: > > Hi Tony, > > > > here is new version (v2) of patch which adding max_current values to rx51 > > board data. According to joerg safe value for max_current is 100 (10 mA). > > > > > > RX-51: Add missing m

Re: [PATCH v2 2/3] hwrng: OMAP3 ROM Random Number Generator support

2013-10-08 Thread Tony Lindgren
unction for smc calls. This one is should be merged via the hw_random patches seprately: Acked-by: Tony Lindgren > Signed-off-by: Pali Rohár > Signed-off-by: Juha Yrjola > --- > drivers/char/hw_random/Kconfig | 13 +++ > drivers/char/hw_random/Makefile|

Re: [PATCH v4 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1

2013-10-08 Thread Tony Lindgren
* Russell King - ARM Linux [131008 01:17]: > On Tue, Oct 08, 2013 at 09:13:16AM +0200, Ben Dooks wrote: > > On 08/09/13 09:43, Pali Rohár wrote: > >> Here is new version (v4) of omap secure part patch: > >> > >> Other secure functions omap_smc1() and omap_smc2() calling instruction smc > >> #0 >

Re: [PATCH v2 3/3] RX-51: Add support for OMAP3 ROM Random Number Generator

2013-10-08 Thread Tony Lindgren
* Pali Rohár [130920 06:33]: > Adding this driver as platform device and only for RX-51 until somebody test > if > it working also on other OMAP3 HS devices and until there will be generic ARM > way to deal with SMC calls. Thanks I'll apply this with the patch #1 clock alias folded in into omap-

Re: [PATCH] ARM: OMAP2+: wakeupgen: AM43x adaptation

2013-10-08 Thread Tony Lindgren
Hi, Few minor comments below. * Afzal Mohammed [130905 04:03]: > AM43x has 224 interrupts and 7 banks, make it as maximum values. Keep > default values as earlier, if am43x is detected, update interrupts and > banks to maximum. > > Also AM43x has only one cpu, ensure that clearing bitmask at wa

Re: [PATCH 3/6] pinctrl: single: Prepare for supporting SoC specific features

2013-10-09 Thread Tony Lindgren
* Linus Walleij [131009 06:51]: > On Mon, Oct 7, 2013 at 7:35 PM, Tony Lindgren wrote: > > > Hi Linus W, > > > > Any comments on the pinctrl patches 3 - 5 in this series? > > Yes, after good explanations to my whimsical questions only this: > Acked-by: Linus W

Re: [PATCH v2 5/6] Revert "ARM: OMAP2+: Provide alias to USB PHY clock"

2013-10-09 Thread Tony Lindgren
* Roger Quadros [131009 00:19]: > Hi Tony, > > On 10/08/2013 01:06 PM, Roger Quadros wrote: > > This reverts commit 741532c4a995be11815cb72d4d7a48f442a22fea. > > > > The proper clock reference is provided in device tree so we > > no longer need this. > > Could you please Ack this one? I think i

Re: [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts

2013-10-10 Thread Tony Lindgren
* Roger Quadros [131010 06:32]: > > I tried testing this with the USB EHCI driver, but I'm not getting wake up > interrupts > while the system is still running and only the EHCI controller is runtime > suspended. > > It seems we need to somehow call _reconfigure_io_chain() to update the daisy

Re: [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts

2013-10-10 Thread Tony Lindgren
* Linus Walleij [131010 08:40]: > On Thu, Oct 10, 2013 at 4:35 PM, Roger Quadros wrote: > > On 10/10/2013 05:04 PM, Linus Walleij wrote: > > >> As an innocent bystander who has no clue what the _reconfigure_io_chain() > >> is about can you tell me what this is all about? > > > > The OMAP SoC has

Re: [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts

2013-10-10 Thread Tony Lindgren
* Linus Walleij [131010 09:19]: > On Thu, Oct 10, 2013 at 6:00 PM, Tony Lindgren wrote: > > * Roger Quadros [131010 06:32]: > >> > >> I tried testing this with the USB EHCI driver, but I'm not getting wake up > >> interrupts > >> while the sy

Re: [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts

2013-10-10 Thread Tony Lindgren
* Tony Lindgren [131010 09:09]: > * Roger Quadros [131010 06:32]: > > > > I tried testing this with the USB EHCI driver, but I'm not getting wake up > > interrupts > > while the system is still running and only the EHCI controller is runtime > > suspended

Re: [PATCH] ARM: dts: omap4-panda-es: Do not reset gpio1

2013-10-10 Thread Tony Lindgren
* Nishanth Menon [131010 09:53]: > Do not reset GPIO1 at boot-up because GPIO 7 in GPIO1 block is used on > OMAP4460 PandaBoard-ES to select voltage register in TPS62361 which > supplies VDD_MPU. > > Without this, OMAP4460 PandaBoard-ES boards fail to boot-up because > MPU voltage switches over t

Re: [RFCv3 0/7] OMAP SSI driver

2013-10-10 Thread Tony Lindgren
* Sebastian Reichel [131010 10:30]: > Hi, > > On Tue, Oct 08, 2013 at 10:28:15AM -0700, Tony Lindgren wrote: > > * Sebastian Reichel [131006 13:36]: > > > Here is the third round of the OMAP SSI driver patches. > > > > Thanks for updating these, they lo

Re: [PATCH 3/6] pinctrl: single: Prepare for supporting SoC specific features

2013-10-10 Thread Tony Lindgren
* Linus Walleij [131010 08:43]: > On Wed, Oct 9, 2013 at 5:10 PM, Tony Lindgren wrote: > > > I was thinking I'll set up an immutable branch for the three > > pinctrl patches against -rc4 then both you and I can merge > > them in as needed. Does that work for you

Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-08-29 Thread Tony Lindgren
* Tero Kristo [130829 00:06]: > On 08/29/2013 04:14 AM, Mike Turquette wrote: > > > >The mux-clock binding covers a quite a few platforms that have similar > >mux-clock programming requirements. If the DT binding is verbose enough > >then the basic mux clock driver is sufficient to initialize all

Re: [PATCH 1/2] gpio/omap: maintain GPIO and IRQ usage separately

2013-09-27 Thread Tony Lindgren
move gpio_is_input() definition in preparation for the > next patch that setups the controller's irq_chip driver when > a caller requests an interrupt line. > > Signed-off-by: Javier Martinez Canillas Thanks both of these look good to me for fixing the regression: Acked-by: Tony Li

Re: [RFC] gpio/omap: auto-setup a GPIO when used as an IRQ

2013-09-23 Thread Tony Lindgren
* Javier Martinez Canillas [130922 07:49]: > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -420,6 +420,29 @@ static int _set_gpio_triggering(struct gpio_bank *bank, > int gpio, > return 0; > } > > +static void _set_gpio_mode(struct gpio_bank *bank, unsigned offset)

Re: [RFC] gpio/omap: auto-setup a GPIO when used as an IRQ

2013-09-23 Thread Tony Lindgren
* Javier Martinez Canillas [130923 10:09]: > On 09/23/2013 06:45 PM, Tony Lindgren wrote: > > > > Hmm does this still work for legacy platform data based > > drivers that are doing gpio_request() first? > > > > Yes it still work when booting using board files.

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-23 Thread Tony Lindgren
* Pavel Machek [130921 05:45]: > Hi! > > > > > > > > --- /dev/null > > > > > > > +++ b/arch/arm/mach-omap2/board-rx51-camera.c > > > > > > > > > > [...] > > > > > > > > > > > Ping, can you review this patch v2? > > > > > > > > > > I don't think Tony will accept any new board stuff for > > > >

Re: [PATCH 4/4] RX-51: Add platform function and data for bq24150a charger

2013-09-23 Thread Tony Lindgren
* Pali Rohár [130920 12:29]: > On Sunday 08 September 2013 10:50:39 Pali Rohár wrote: > > This patch will register bq24150a charger in RX-51 board data. > > Patch also adding platform function between isp1704 and > > bq2415x drivers for detecting charger type. > > > > So finally charging battery

Re: [PATCH 4/4] RX-51: Add platform function and data for bq24150a charger

2013-09-23 Thread Tony Lindgren
* Sebastian Reichel [130923 13:55]: > On Mon, Sep 23, 2013 at 10:06:46PM +0200, Pali Rohár wrote: > > On Monday 23 September 2013 22:00:09 Sebastian Reichel wrote: > > > On Mon, Sep 23, 2013 at 09:16:18PM +0200, Pali Rohár wrote: > > > > It is not as simple as it looks. This is reason why I > > >

Re: [RFC] gpio/omap: auto-setup a GPIO when used as an IRQ

2013-09-24 Thread Tony Lindgren
* Javier Martinez Canillas [130923 22:49]: > On 09/23/2013 10:15 PM, Linus Walleij wrote: > > wrote: > > - When a second caller calls omap_gpio_request() it should > > be OK as well, but only if the flags corresponds to the > > previously enabled input mode. Else it should be > > disallowed

Re: [RFC v2] gpio/omap: auto-setup a GPIO when used as an IRQ

2013-09-24 Thread Tony Lindgren
* Javier Martinez Canillas [130924 01:06]: > The OMAP GPIO controller HW requires a pin to be configured in GPIO > input mode in order to operate as an interrupt input. Since drivers > should not be aware of whether an interrupt pin is also a GPIO or not, > the HW should be fully configured/enable

Re: [RFC v2] gpio/omap: auto-setup a GPIO when used as an IRQ

2013-09-24 Thread Tony Lindgren
* Balaji T K [130924 08:54]: > On Tuesday 24 September 2013 09:10 PM, Tony Lindgren wrote: > > > >Also please mention the regression that this fixes. So far we know > >that smsc911x for tobi and igep boards in mainline, and also the > > >MMC card detect for omap

Re: [RFC v2] gpio/omap: auto-setup a GPIO when used as an IRQ

2013-09-24 Thread Tony Lindgren
* Santosh Shilimkar [130924 08:56]: > On Tuesday 24 September 2013 11:45 AM, Balaji T K wrote: > > On Tuesday 24 September 2013 09:10 PM, Tony Lindgren wrote: > >> * Javier Martinez Canillas [130924 > >> 01:06]: > >>> The OMAP GPIO controller HW

Re: [PATCH v2 2/2] RX-51: ARM errata 430973 workaround

2013-09-24 Thread Tony Lindgren
* Pavel Machek [130923 17:23]: > Hi! > > > > Tony, if you did not have time for review this patch months ago > > > or you found it only today - no problem, I understand it. But > > > what I need to know is what will happen with board-rx51-* files > > > (and when?) You can see that DT does not

Re: [RFCv2 3/3] ARM: dts: N900: Add SSI information

2013-09-24 Thread Tony Lindgren
* Stephen Warren [130924 13:03]: > On 09/23/2013 05:46 PM, Sebastian Reichel wrote: > > Hi, > > > > On Mon, Sep 23, 2013 at 02:35:35PM -0600, Stephen Warren wrote: > >> On 09/15/2013 02:44 PM, Sebastian Reichel wrote: > >>> Add SSI device tree data for OMAP34xx and Nokia N900. > > ... > >>> +- t

Re: [PATCH 0/2] pinctrl: pinctrl-single: new type: pinctrl-single,bits

2012-09-05 Thread Tony Lindgren
* Linus Walleij [120905 05:11]: > On Wed, Sep 5, 2012 at 11:01 AM, Peter Ujfalusi wrote: > > > When configuring pinmux with pinctrl-single there could be a case when one > > register is used to configure mux for more than one pin. > > In this case the use of pinctrl-single,pins is a bit problema

Re: [PATCH 1/2] pinctrl: pinctrl-single: Make sure we do not change bits outside of mask

2012-09-06 Thread Tony Lindgren
> pinctrl-0 = <&board_pins>; > > board_pins: pinmux_board_pins { > pinctrl-single,pins = < > 0x6c 0xf0f > 0x6e 0x10f > 0x70 0x23f > 0x72 0xa5f >

Re: [PATCH 2/2] pinctrl: pinctrl-single: Add pinctrl-single,bits type of mux

2012-09-06 Thread Tony Lindgren
Hi Peter, * Peter Ujfalusi [120905 02:02]: > With pinctrl-single,bits it is possible to update just part of the register > within the pinctrl-single,function-mask area. > This is useful when one register configures mmore than one pin's mux. You have a typo here: ^ >

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-06 Thread Tony Lindgren
* Felipe Balbi [120906 10:23]: > Hi, > > On Thu, Sep 06, 2012 at 08:13:03PM +0300, Felipe Balbi wrote: > > Hi, > > > > On Thu, Sep 06, 2012 at 09:04:58PM +0530, Vaibhav Hiremath wrote: > > > > > > > > > On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote: > > > > The mailbox register for usb otg

Re: [PATCH v3 10/14] ARM: OMAP/ASoC: Zoom2: Let the codec to handle the hs_extmute GPIO

2012-09-06 Thread Tony Lindgren
mach/board-zoom.h | 2 -- Here board-zoom.h will be moved to be just #include "board-zoom.h". But we can deal with that once I have an immutable header cleanup branch that you can pull in. Acked-by: Tony Lindgren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [PATCH 2/2] pinctrl: pinctrl-single: Add pinctrl-single,bits type of mux

2012-09-07 Thread Tony Lindgren
* Peter Ujfalusi [120907 08:13]: > On 09/06/2012 10:10 PM, Tony Lindgren wrote: > > > > Is it now safe to assume that we always have width of three if > > pinctrl-single,bits is specified? The reason I'm asking is.. > > > >> @@ -657,18 +664,29 @@ stat

Re: [PATCH] serial: omap: fix compile breakage

2012-09-07 Thread Tony Lindgren
OMAP Serial enabled on .config) so I ended > > up breaking the build on Greg's tty-next branch. > > > > Fix the breakage by re-adding the three missing > > members on struct uart_omap_port. > > > > Reported-by: Tony Lindgren > > Signed-off-by: Fe

Re: [PATCH 1/2] pinctrl: pinctrl-single: Make sure we do not change bits outside of mask

2012-09-07 Thread Tony Lindgren
* Linus Walleij [120907 14:13]: > On Thu, Sep 6, 2012 at 8:59 PM, Tony Lindgren wrote: > > * Peter Ujfalusi [120905 02:02]: > >> Use the pcs->fmask to make sure that the value is not changing (setting) > >> bits in areas where it should not. >

Re: [PATCH] ARM: dts: AM33XX: fix gpio node numbering to match hardware

2012-09-10 Thread Tony Lindgren
* Benoit Cousson [120910 09:35]: > + Tony > > Hi Matt, > > 30 minutes too late for my pull request :-( > > There are a couple of am33xx patches under discussion, so I'll take them > and send a for_3.7/dts-part2 pull request if this is not too late for Tony. Yes please do, it' hard to say when

Re: [PATCH 2/2] pinctrl: pinctrl-single: Add pinctrl-single,bits type of mux

2012-09-10 Thread Tony Lindgren
* Peter Ujfalusi [120910 04:55]: > On 09/07/2012 07:55 PM, Tony Lindgren wrote: > > > > I'd like to have something that specifies the controller type so > > we don't need to mix two types of controllers and test for > > non-existing properties when parsing th

Re: [PATCH 2/2] pinctrl: pinctrl-single: Add pinctrl-single,bits type of mux

2012-09-10 Thread Tony Lindgren
* Linus Walleij [120910 00:11]: > On Wed, Sep 5, 2012 at 11:01 AM, Peter Ujfalusi wrote: > > > With pinctrl-single,bits it is possible to update just part of the register > > within the pinctrl-single,function-mask area. > > This is useful when one register configures mmore than one pin's mux. >

Re: [PATCH 1/1] musb : remove generic_interrupt and have all drivers define the isr on their own. Remove some unneeded CONFIG_SOC_OMAP_3430 instances

2012-10-08 Thread Tony Lindgren
of those options that > Tony Lindgren predicted would happen at some point. Thanks looks OK to me: Acked-by: Tony Lindgren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

[PATCH 1/2] ARM: OMAP: Trivial driver changes to remove include plat/cpu.h

2012-10-08 Thread Tony Lindgren
iams Cc: Peter Ujfalusi Cc: Jarkko Nikula Cc: Liam Girdwood Cc: Mark Brown Cc: linux-cry...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: alsa-de...@alsa-project.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Tony Lindgren --- drivers/char/hw_random/omap-rng.c |2 -- drivers/cr

Re: [PATCH 1/2] ARM: OMAP: Trivial driver changes to remove include plat/cpu.h

2012-10-08 Thread Tony Lindgren
* Tony Lindgren [121008 10:37]: > Drivers should not use cpu_is_omap or cpu_class_is_omap macros, > they should be private to the platform init code. And we'll be > removing plat/cpu.h and only have a private soc.h for the > arch/arm/*omap* code. > > This patch is intended

Re: [PATCH 1/1] ARM: Add option to configure output line for McSPI driver

2012-10-08 Thread Tony Lindgren
* Stan Hu [120926 11:36]: > McSPI driver previously assumed that D0 was input (MISO) and D1 was output > (MOSI). > This forces the hardware designer to wire all SPI peripherals in this way when > it should be a software configuration option. > > Signed-off-by: Stan Hu > --- > arch/arm/plat-oma

Re: [PATCH] ARM: OMAP: rx51: Fix a section mismatch warn

2012-10-08 Thread Tony Lindgren
* Shubhrajyoti D [120912 07:38]: > rx51_si4713_dev is referenced only from rx51_init_si4713. > So the memory for rx51_si4713_dev can be safely freed after init. > Also it references rx51_si4713_board_info which is __initdata_or_module. Thanks applying into fixes. Tony -- To unsubscribe from this

Re: [PATCH] ARM: OMAP: OMAP_DEBUG_LEDS needs to select LEDS_CLASS

2012-10-08 Thread Tony Lindgren
> >>> > >> > >> Thanks for posting this. But I think Tony has already fixed it in mainline: > >> -- > >> commit 359f64f7b3997e94ee71039b5fcdc1278b9b77c4 > >> Author: Tony Lindgren > >> Date: Wed Sep 15 10:18:51 2010 -0700 > >> > >>

Re: [PATCH] arch/arm/mach-omap1/devices.c: Remove unecessary semicolon

2012-10-08 Thread Tony Lindgren
* Peter Senna Tschudin [120918 09:37]: > Found by http://coccinelle.lip6.fr/ > > Signed-off-by: Peter Senna Tschudin > --- > arch/arm/mach-omap1/devices.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap1/devices.c b/arch/arm/mach-omap1/devices.c > in

<    1   2   3   4   5   6   7   8   9   10   >