Updating index.rst and adding aspeed2600-pwm-tachometer.rst to address
the driver.
Changes since v1:
- rename to aspeed2600-pwm-tachometer.rst
- add license identifier
Signed-off-by: Troy Lee
---
.../hwmon/aspeed2600-pwm-tachometer.rst | 27 +++
Documentation/hwmon
Create a common node in aspeed-g6.dtsi and add fan nodes for ast2600-evb
dts file.
Changes since v2:
- Change property name pwm-freq to pwm-freq-hz
Changes since v1:
- rename properties name in child node
Signed-off-by: Troy Lee
---
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 152
- register hwmon driver with devm_hwmon_device_register_with_info()
Signed-off-by: Troy Lee
Reported-by: kernel test robot
---
drivers/hwmon/Kconfig| 10 +
drivers/hwmon/Makefile | 1 +
drivers/hwmon/aspeed2600-pwm-tacho.c | 756 +++
3 files
()
- moving default configurations to device tree
Troy Lee (4):
dt-bindings: hwmon: Add Aspeed AST2600 PWM/Fan
hwmon: Add Aspeed AST2600 support
ARM: dts: aspeed: Add Aspeed AST2600 PWM/Fan node in devicetree
hwmon: Support Aspeed AST2600 PWM/Fan tachometer
.../hwmon/aspeed,ast2600-pwm
We add binding for supporting a new AST2600 PWM/Fan hwmon driver.
Changes since v2:
- Fixed yamllint warnings/errors
Changes since v1:
- dt binding with DT schema format
Signed-off-by: Troy Lee
Reported-by: Rob Herring
---
.../hwmon/aspeed,ast2600-pwm-tachometer.yaml | 131
Hi Guenter,
The 01/24/2021 00:14, Guenter Roeck wrote:
> On Wed, Jan 13, 2021 at 07:08:48AM +0000, Troy Lee wrote:
> > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and
> > 16 FAN tacho channel.
> >
> > Changes since v1:
> > - fixed review c
Hi Rob,
Thanks for reviewing.
The 01/14/2021 22:13, Rob Herring wrote:
> On Wed, Jan 13, 2021 at 07:08:45AM +0000, Troy Lee wrote:
> > We add binding for supporting a new AST2600 PWM/Fan hwmon driver.
> >
> > Changes since v1:
> > - dt binding with DT schema format
&
Updating index.rst and adding aspeed2600-pwm-tachometer.rst to address
the driver.
Changes since v1:
- rename to aspeed2600-pwm-tachometer.rst
- add license identifier
Signed-off-by: Troy Lee
---
.../hwmon/aspeed2600-pwm-tachometer.rst | 27 +++
Documentation/hwmon
We add binding for supporting a new AST2600 PWM/Fan hwmon driver.
Changes since v1:
- dt binding with DT schema format
Signed-off-by: Troy Lee
---
.../hwmon/aspeed,ast2600-pwm-tachometer.yaml | 137 ++
1 file changed, 137 insertions(+)
create mode 100644
Documentation
Create a common node in aspeed-g6.dtsi and add fan nodes for
aspeed-ast2600-evb.dts file.
Changes since v1:
- rename properties name in child node
Signed-off-by: Troy Lee
---
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 152 +++
arch/arm/boot/dts/aspeed-g6.dtsi | 10
()
Signed-off-by: Troy Lee
---
drivers/hwmon/Kconfig| 10 +
drivers/hwmon/Makefile | 1 +
drivers/hwmon/aspeed2600-pwm-tacho.c | 756 +++
3 files changed, 767 insertions(+)
create mode 100644 drivers/hwmon/aspeed2600-pwm-tacho.c
diff --git
v1:
- dt-binding rewrote with dt schema format
- register hwmon driver with devm_hwmon_device_register_with_info()
- moving default configurations to device tree
*** BLURB HERE ***
Troy Lee (4):
dt-bindings: hwmon: Add Aspeed AST2600 PWM/Fan
hwmon: Add Aspeed AST2600 support
ARM: dts
Hi Rob,
The 01/13/2021 23:45, Rob Herring wrote:
> On Wed, 13 Jan 2021 07:08:45 +0000, Troy Lee wrote:
> > We add binding for supporting a new AST2600 PWM/Fan hwmon driver.
> >
> > Changes since v1:
> > - dt binding with DT schema format
> >
> > Signed-o
Aspeed AST2600 is a server management SoC which has 16 PWM channels and
16 fan tacho channel.
This series of patch provides AST2600 PWM/Fan tacho support in hwmon class.
The driver provides a sysfs interface, and user can configure PWM duty cycle
and read current FAN speed in RPM.
Troy Lee (4
Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and
16 FAN tacho channel.
Signed-off-by: Troy Lee
---
drivers/hwmon/Kconfig| 10 +
drivers/hwmon/Makefile |1 +
drivers/hwmon/aspeed2600-pwm-tacho.c | 1053 ++
3 files
Create a common node in aspeed-g6.dtsi and add fan nodes for ast2600-evb
dts file.
Signed-off-by: Troy Lee
---
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 149 +++
arch/arm/boot/dts/aspeed-g6.dtsi | 10 ++
2 files changed, 159 insertions(+)
diff --git a/arch/arm
For supporting a new AST2600 PWM/Fan hwmon driver, we add a new binding.
Signed-off-by: Troy Lee
---
.../bindings/hwmon/aspeed2600-pwm-tacho.txt | 69 +++
1 file changed, 69 insertions(+)
create mode 100644
Documentation/devicetree/bindings/hwmon/aspeed2600-pwm-tacho.txt
Updating index.rst and adding aspeed_pwm_tachometer.rst to address the
driver.
Signed-off-by: Troy Lee
---
Documentation/hwmon/aspeed_pwm_tachometer.rst | 24 +++
Documentation/hwmon/index.rst | 1 +
2 files changed, 25 insertions(+)
create mode 100644
GPIO pins can be used as IRQ indicators. When they do,
those pins should be flaged with locks to avoid kernel
warning message.
Signed-off-by: Chia-Wei, Wang
Signed-off-by: Troy Lee
---
drivers/gpio/gpio-aspeed.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpio/gpio
The 12/11/2020 11:26, Rob Herring wrote:
> On Wed, Dec 09, 2020 at 03:59:17PM +0800, Troy Lee wrote:
> > For supporting a new AST2600 PWM/Fan hwmon driver, we add a new binding.
> >
> > Signed-off-by: Troy Lee
> > ---
> > .../bindings/hwmo
The 12/11/2020 00:16, Guenter Roeck wrote:
> On Wed, Dec 09, 2020 at 03:59:20PM +0800, Troy Lee wrote:
> > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and
> > 16 FAN tacho channel.
> >
> > Signed-off-by: Troy Lee
> > ---
> > driv
Adding Aspeed AST2400 and AST2600 binding for edac driver.
Signed-off-by: Troy Lee
---
.../devicetree/bindings/edac/aspeed-sdram-edac.txt | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/edac/aspeed-sdram-edac.txt
b
Adding Aspeed AST2600 edac node into common devicetree.
Signed-off-by: Troy Lee
---
arch/arm/boot/dts/aspeed-g6.dtsi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
index 97ca743363d7..fb144515f397 100644
--- a/arch
Adding AST2400 and AST2600 edac driver support.
Signed-off-by: Troy Lee
---
drivers/edac/Kconfig | 6 +-
drivers/edac/aspeed_edac.c | 114 +
2 files changed, 94 insertions(+), 26 deletions(-)
diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
Hi Andrew,
Great suggestion, responses inline below. We'll remove build-time SoC
dependency driver code and submit an updated v2 patch.
Thanks,
Troy Lee
> -Original Message-
> From: Andrew Jeffery
> Sent: Tuesday, December 1, 2020 9:12 AM
> To: Troy Lee ; Stefan M Schaeck
Hi Stefan,
The driver was ported from latest ASPEED BSP, so I only test with ECC-on/off
from u-boot and check if driver runs correctly.
The test doc you provided is very nice and detailed, I'll try to reproduce the
injection test in v2 patch.
Thanks,
Troy Lee
> -Original Mess
Adding Aspeed AST2400 and AST2600 binding for edac driver.
Signed-off-by: Troy Lee
---
.../devicetree/bindings/edac/aspeed-sdram-edac.txt | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/edac/aspeed-sdram-edac.txt
b
Adding AST2400 and AST2600 edac driver support.
Signed-off-by: Troy Lee
---
Change since v1:
1. Removing SoC specific code
2. Changing numerical representation of memory sizing
---
drivers/edac/Kconfig | 6 +--
drivers/edac/aspeed_edac.c | 103 +
2
Adding Aspeed AST2600 edac node into common devicetree.
Signed-off-by: Troy Lee
---
arch/arm/boot/dts/aspeed-g6.dtsi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
index 97ca743363d7..fb144515f397 100644
--- a/arch
Hi Joel,
Thanks for the suggestion, I'll fix the review and create an new patch against
latest Linux branch. Those exported function will be referenced in other driver
yet
to be upstream, so should I move those exported functions out of this patch?
Thanks,
Troy Lee
> -Original Mess
Adding Aspeed AST2600 edac node into common devicetree.
Signed-off-by: Troy Lee
---
arch/arm/boot/dts/aspeed-g6.dtsi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
index b58220a49cbd..74367ee96f20 100644
--- a/arch
Adding AST2400 and AST2600 edac driver support.
Signed-off-by: Troy Lee
---
Changes since v2:
- Remove cross dependencies export functions
- Update Kconfig depends on ARCH_ASPEED
- Patch create against latest Linux kernel mainline
---
drivers/edac/Kconfig | 6 +++---
drivers/edac
Adding Aspeed AST2400 and AST2600 binding for edac driver.
Signed-off-by: Troy Lee
---
.../devicetree/bindings/edac/aspeed-sdram-edac.txt | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/edac/aspeed-sdram-edac.txt
b
Hi Broislav and Andrew,
I removed these exported function and submitted v3 PATCH.
Thanks,
Troy Lee
> -Original Message-
> From: Borislav Petkov
> Sent: Thursday, December 3, 2020 2:24 AM
> To: Andrew Jeffery
> Cc: Troy Lee ; Joel Stanley ; open
> list:OPEN FIRM
Hi Andrew,
The 01/22/2021 12:38, Andrew Jeffery wrote:
> Hi Troy,
>
> On Mon, 18 Jan 2021, at 17:20, Troy Lee wrote:
> > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and
> > 16 FAN tacho channel.
> >
> > Changes since v2:
> > - de
Adding Aspeed AST2600 edac node into common devicetree.
Signed-off-by: Troy Lee
Reviewed-by: Joel Stanley
---
arch/arm/boot/dts/aspeed-g6.dtsi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
index b58220a49cbd
Adding Aspeed AST2400 and AST2600 binding for edac driver.
Signed-off-by: Troy Lee
Acked-by: Joel Stanley
---
.../devicetree/bindings/edac/aspeed-sdram-edac.txt | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/edac/aspeed
Adding AST2400 and AST2600 edac driver support.
Signed-off-by: Troy Lee
---
drivers/edac/Kconfig | 6 +++---
drivers/edac/aspeed_edac.c | 7 +--
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 7a47680d6f07..c410331e8ee8
Aspeed AST2600 u-boot requires 600KiB+ flash space. Sharing the same
openbmc-flash-layout-64.dtsi requires to resize the flash partition.
The updated flash layout as follows:
- u-boot: 896 KiB
- u-boot-env: 128 KiB
- kernel: 9MiB
- rofs: 32 MiB
- rwfs: 22 MiB
Signed-off-by: Troy Lee
---
arch
39 matches
Mail list logo
