Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: > On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson wrote: > > On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: > >> Another case I mentioned before that I just want to make sure we don't > >> reintroduce th

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 12:44 PM, Ulf Magnusson <ulfali...@gmail.com> wrote: > On Mon, Feb 12, 2018 at 11:44 AM, Masahiro Yamada > <yamada.masah...@socionext.com> wrote: >> 2018-02-11 19:34 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: >>> Looks to me l

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 12:44 PM, Ulf Magnusson wrote: > On Mon, Feb 12, 2018 at 11:44 AM, Masahiro Yamada > wrote: >> 2018-02-11 19:34 GMT+09:00 Ulf Magnusson : >>> Looks to me like there's a few unrelated issues here: >>> >>> >>> 1. The stack p

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 11:44 AM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > 2018-02-11 19:34 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: >> Looks to me like there's a few unrelated issues here: >> >> >> 1. The stack protector su

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 11:44 AM, Masahiro Yamada wrote: > 2018-02-11 19:34 GMT+09:00 Ulf Magnusson : >> Looks to me like there's a few unrelated issues here: >> >> >> 1. The stack protector support test scripts >> >> Worthwhile IMO if they (*in practi

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:05 PM, Kees Cook <keesc...@chromium.org> wrote: > On Sun, Feb 11, 2018 at 10:34 AM, Ulf Magnusson <ulfali...@gmail.com> wrote: >> On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook <keesc...@chromium.org> wrote: >>> Old? That's not the case

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:05 PM, Kees Cook wrote: > On Sun, Feb 11, 2018 at 10:34 AM, Ulf Magnusson wrote: >> On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >>> Old? That's not the case. The check for -fno-stack-protector will >>> likely be needed forever, as s

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >> 3. Whether to implement CC_STACKPROTECTOR_AUTO in Kconfig or the Makefiles >> >> I'd just go with whatever is simplest here. I don't find the Kconfig version >> too bad, but I'm already very familiar with Kconfig, so it's

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >> 3. Whether to implement CC_STACKPROTECTOR_AUTO in Kconfig or the Makefiles >> >> I'd just go with whatever is simplest here. I don't find the Kconfig version >> too bad, but I'm already very familiar with Kconfig, so it's harder for me to >>

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson <ulfali...@gmail.com> wrote: > On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook <keesc...@chromium.org> wrote: >> Another case I mentioned before that I just want to make sure we don't >> reintroduce the problem of getting &quo

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson wrote: > On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >> Another case I mentioned before that I just want to make sure we don't >> reintroduce the problem of getting "stuck" with a bad .config file. >> While addin

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: > Another case I mentioned before that I just want to make sure we don't > reintroduce the problem of getting "stuck" with a bad .config file. > While adding _STRONG support, I discovered the two-phase Kconfig > resolution

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: > Another case I mentioned before that I just want to make sure we don't > reintroduce the problem of getting "stuck" with a bad .config file. > While adding _STRONG support, I discovered the two-phase Kconfig > resolution that happens during the

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: > Old? That's not the case. The check for -fno-stack-protector will > likely be needed forever, as some distro compilers enable > stack-protector by default. So when someone wants to explicitly build > without

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: > Old? That's not the case. The check for -fno-stack-protector will > likely be needed forever, as some distro compilers enable > stack-protector by default. So when someone wants to explicitly build > without stack-protector (or if the compiler's

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

Looks to me like there's a few unrelated issues here: 1. The stack protector support test scripts Worthwhile IMO if they (*in practice*) prevent hard-to-debug build errors or a subtly broken kernel from being built. A few questions: - How do things fail with a broken stack protector

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

Looks to me like there's a few unrelated issues here: 1. The stack protector support test scripts Worthwhile IMO if they (*in practice*) prevent hard-to-debug build errors or a subtly broken kernel from being built. A few questions: - How do things fail with a broken stack protector

Re: [PATCH 16/20] auxdisplay: img-ascii-lcd: Remove MIPS_SEAD3 dep.

On Thu, Feb 08, 2018 at 05:35:30PM +, James Hogan wrote: > On 5 February 2018 at 01:21, Ulf Magnusson <ulfali...@gmail.com> wrote: > > The MIPS_SEAD3 symbol was removed in commit 64601cb1343f ("leds: Remove > > SEAD-3 > > driver"). > > > > Re

Re: [PATCH 16/20] auxdisplay: img-ascii-lcd: Remove MIPS_SEAD3 dep.

On Thu, Feb 08, 2018 at 05:35:30PM +, James Hogan wrote: > On 5 February 2018 at 01:21, Ulf Magnusson wrote: > > The MIPS_SEAD3 symbol was removed in commit 64601cb1343f ("leds: Remove > > SEAD-3 > > driver"). > > > > Remove the MIPS_SE

[PATCH v2] auxdisplay: img-ascii-lcd: kconfig: Remove MIPS_SEAD3 reference

Discovered with the https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py script. Signed-off-by: Ulf Magnusson <ulfali...@gmail.com> --- Changes in v2: - The wrong commit was referenced in the commit message. - Mention that IMG_ASCII_LCD is now set via the board-sead-3.

[PATCH v2] auxdisplay: img-ascii-lcd: kconfig: Remove MIPS_SEAD3 reference

Discovered with the https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py script. Signed-off-by: Ulf Magnusson --- Changes in v2: - The wrong commit was referenced in the commit message. - Mention that IMG_ASCII_LCD is now set via the board-sead-3.config defconfig file.

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sat, Feb 10, 2018 at 09:55:19AM +0100, Ulf Magnusson wrote: > On Sat, Feb 10, 2018 at 09:05:56AM +0100, Ulf Magnusson wrote: > > On Sat, Feb 10, 2018 at 08:49:24AM +0100, Ulf Magnusson wrote: > > > On Sat, Feb 10, 2018 at 04:12:13PM +0900, Masahiro Yamada wrote: > > >

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sat, Feb 10, 2018 at 09:55:19AM +0100, Ulf Magnusson wrote: > On Sat, Feb 10, 2018 at 09:05:56AM +0100, Ulf Magnusson wrote: > > On Sat, Feb 10, 2018 at 08:49:24AM +0100, Ulf Magnusson wrote: > > > On Sat, Feb 10, 2018 at 04:12:13PM +0900, Masahiro Yamada wrote: > > >

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sat, Feb 10, 2018 at 09:05:56AM +0100, Ulf Magnusson wrote: > On Sat, Feb 10, 2018 at 08:49:24AM +0100, Ulf Magnusson wrote: > > On Sat, Feb 10, 2018 at 04:12:13PM +0900, Masahiro Yamada wrote: > > > 2018-02-10 14:48 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: >

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sat, Feb 10, 2018 at 09:05:56AM +0100, Ulf Magnusson wrote: > On Sat, Feb 10, 2018 at 08:49:24AM +0100, Ulf Magnusson wrote: > > On Sat, Feb 10, 2018 at 04:12:13PM +0900, Masahiro Yamada wrote: > > > 2018-02-10 14:48 GMT+09:00 Ulf Magnusson : > > > > On Fri, Fe

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sat, Feb 10, 2018 at 08:49:24AM +0100, Ulf Magnusson wrote: > On Sat, Feb 10, 2018 at 04:12:13PM +0900, Masahiro Yamada wrote: > > 2018-02-10 14:48 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: > > > On Fri, Feb 09, 2018 at 12:46:54PM -0800, Kees Cook wrote: > >

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sat, Feb 10, 2018 at 08:49:24AM +0100, Ulf Magnusson wrote: > On Sat, Feb 10, 2018 at 04:12:13PM +0900, Masahiro Yamada wrote: > > 2018-02-10 14:48 GMT+09:00 Ulf Magnusson : > > > On Fri, Feb 09, 2018 at 12:46:54PM -0800, Kees Cook wrote: > > >> On Fri, Feb 9,

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sat, Feb 10, 2018 at 04:12:13PM +0900, Masahiro Yamada wrote: > 2018-02-10 14:48 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: > > On Fri, Feb 09, 2018 at 12:46:54PM -0800, Kees Cook wrote: > >> On Fri, Feb 9, 2018 at 4:46 AM, Ulf Magnusson <ulfali...@gmail.c

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sat, Feb 10, 2018 at 04:12:13PM +0900, Masahiro Yamada wrote: > 2018-02-10 14:48 GMT+09:00 Ulf Magnusson : > > On Fri, Feb 09, 2018 at 12:46:54PM -0800, Kees Cook wrote: > >> On Fri, Feb 9, 2018 at 4:46 AM, Ulf Magnusson wrote: > >> > One thing that makes Kcon

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Fri, Feb 09, 2018 at 12:46:54PM -0800, Kees Cook wrote: > On Fri, Feb 9, 2018 at 4:46 AM, Ulf Magnusson <ulfali...@gmail.com> wrote: > > One thing that makes Kconfig confusing (though it works well enough in > > practice) is that .config files both record user

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Fri, Feb 09, 2018 at 12:46:54PM -0800, Kees Cook wrote: > On Fri, Feb 9, 2018 at 4:46 AM, Ulf Magnusson wrote: > > One thing that makes Kconfig confusing (though it works well enough in > > practice) is that .config files both record user selections (the saved > > con

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Fri, Feb 09, 2018 at 06:19:19PM +0900, Masahiro Yamada wrote: > 2018-02-09 14:30 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: > > On Fri, Feb 09, 2018 at 01:19:09AM +0900, Masahiro Yamada wrote: > >> This works with bool, int, hex, string types. > >> >

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Fri, Feb 09, 2018 at 06:19:19PM +0900, Masahiro Yamada wrote: > 2018-02-09 14:30 GMT+09:00 Ulf Magnusson : > > On Fri, Feb 09, 2018 at 01:19:09AM +0900, Masahiro Yamada wrote: > >> This works with bool, int, hex, string types. > >> > >> For bool, the s

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Fri, Feb 09, 2018 at 01:19:09AM +0900, Masahiro Yamada wrote: > This works with bool, int, hex, string types. > > For bool, the symbol is set to 'y' or 'n' depending on the exit value > of the command. > > For int, hex, string, the symbol is set to the value to the stdout > of the command.

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Fri, Feb 09, 2018 at 01:19:09AM +0900, Masahiro Yamada wrote: > This works with bool, int, hex, string types. > > For bool, the symbol is set to 'y' or 'n' depending on the exit value > of the command. > > For int, hex, string, the symbol is set to the value to the stdout > of the command.

Re: [PATCH] ALSA: ac97: kconfig: Remove select of undefined symbol AC97

On Fri, Feb 09, 2018 at 12:15:36AM +0100, Ulf Magnusson wrote: > The AC97_BUS_NEW Kconfig symbol selects the globally undefined symbol > AC97. > > Robert Jarzmik confirmed in https://lkml.org/lkml/2018/2/7/96 that the > select was put in by mistake and can be safely removed

Re: [PATCH] ALSA: ac97: kconfig: Remove select of undefined symbol AC97

On Fri, Feb 09, 2018 at 12:15:36AM +0100, Ulf Magnusson wrote: > The AC97_BUS_NEW Kconfig symbol selects the globally undefined symbol > AC97. > > Robert Jarzmik confirmed in https://lkml.org/lkml/2018/2/7/96 that the > select was put in by mistake and can be safely removed

[PATCH] ALSA: ac97: kconfig: Remove select of undefined symbol AC97

The AC97_BUS_NEW Kconfig symbol selects the globally undefined symbol AC97. Robert Jarzmik confirmed in https://lkml.org/lkml/2018/2/7/96 that the select was put in by mistake and can be safely removed, with no other changes required. Remove it. Signed-off-by: Ulf Magnusson <ulfali...@gmail.

[PATCH] ALSA: ac97: kconfig: Remove select of undefined symbol AC97

The AC97_BUS_NEW Kconfig symbol selects the globally undefined symbol AC97. Robert Jarzmik confirmed in https://lkml.org/lkml/2018/2/7/96 that the select was put in by mistake and can be safely removed, with no other changes required. Remove it. Signed-off-by: Ulf Magnusson --- sound/ac97

Re: [PATCH 07/20] riscv: Remove ARCH_WANT_OPTIONAL_GPIOLIB select

"arm64: do > > away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. > > > > Discovered with the > > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > > script. > > > > Signed-off-by: Ulf Magnusson <ulfali...@gmail.com&g

Re: [PATCH 07/20] riscv: Remove ARCH_WANT_OPTIONAL_GPIOLIB select

"arm64: do > > away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. > > > > Discovered with the > > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > > script. > > > > Signed-off-by: Ulf Magnusson > > --- > &g

[PATCH] riscv: kconfig: Remove RISCV_IRQ_INTC select

. Signed-off-by: Ulf Magnusson <ulfali...@gmail.com> --- arch/riscv/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index b6722c246d9c..2be44b6651c5 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -34,7 +34,6 @@ config

[PATCH] riscv: kconfig: Remove RISCV_IRQ_INTC select

. Signed-off-by: Ulf Magnusson --- arch/riscv/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index b6722c246d9c..2be44b6651c5 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -34,7 +34,6 @@ config RISCV select

Re: [PATCH 06/20] riscv: Remove ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE select

1244b9d ("atomic64: no need for >> CONFIG_ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE"). >> >> Remove the ARCH_HAS_ATOMIC64_DEC_IS_POSITIVE select from RISCV. >> >> Discovered with the >> >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py >> script. >> >

Re: [PATCH 06/20] riscv: Remove ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE select

_DEC_IF_POSITIVE"). >> >> Remove the ARCH_HAS_ATOMIC64_DEC_IS_POSITIVE select from RISCV. >> >> Discovered with the >> >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py >> script. >> >> Signed-off-by: Ulf

[PATCH v3] spi: kconfig: Remove AVR32 dep. from SPI_ATMEL

The AVR32 symbol was removed in commit 26202873bb51 ("avr32: remove support for AVR32 architecture"). Signed-off-by: Ulf Magnusson <ulfali...@gmail.com> --- Changes in v3: Add Signed-off-by tag Changes in v2: Remove the AVR32 reference from the help text too. drivers/spi/Kco

[PATCH v3] spi: kconfig: Remove AVR32 dep. from SPI_ATMEL

The AVR32 symbol was removed in commit 26202873bb51 ("avr32: remove support for AVR32 architecture"). Signed-off-by: Ulf Magnusson --- Changes in v3: Add Signed-off-by tag Changes in v2: Remove the AVR32 reference from the help text too. drivers/spi/Kconfig | 4 ++-- 1 file

Re: [PATCH 02/14] kconfig: do not write choice values when their dependency becomes n

On Thu, Feb 8, 2018 at 3:46 AM, Ulf Magnusson <ulfali...@gmail.com> wrote: > On Thu, Feb 8, 2018 at 3:42 AM, Masahiro Yamada > <yamada.masah...@socionext.com> wrote: >> 2018-02-08 7:55 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: >>> On Tue, Feb 06, 20

Re: [PATCH 02/14] kconfig: do not write choice values when their dependency becomes n

On Thu, Feb 8, 2018 at 3:46 AM, Ulf Magnusson wrote: > On Thu, Feb 8, 2018 at 3:42 AM, Masahiro Yamada > wrote: >> 2018-02-08 7:55 GMT+09:00 Ulf Magnusson : >>> On Tue, Feb 06, 2018 at 09:34:42AM +0900, Masahiro Yamada wrote: >>>> "# CONFIG_... is not set&

Re: [PATCH 2/2] kconfig: echo stdin to stdout if either is redirected

On Thu, Feb 8, 2018 at 7:51 AM, Ulf Magnusson <ulfali...@gmail.com> wrote: > On Thu, Feb 8, 2018 at 7:35 AM, Ulf Magnusson <ulfali...@gmail.com> wrote: >> On Thu, Feb 8, 2018 at 6:56 AM, Masahiro Yamada >> <yamada.masah...@socionext.com> wrote: >>>

Re: [PATCH 2/2] kconfig: echo stdin to stdout if either is redirected

On Thu, Feb 8, 2018 at 7:51 AM, Ulf Magnusson wrote: > On Thu, Feb 8, 2018 at 7:35 AM, Ulf Magnusson wrote: >> On Thu, Feb 8, 2018 at 6:56 AM, Masahiro Yamada >> wrote: >>> If stdio is not tty, conf_askvalue() puts additional new line to >>> prevent prompts a

Re: [PATCH 2/2] kconfig: echo stdin to stdout if either is redirected

On Thu, Feb 8, 2018 at 7:35 AM, Ulf Magnusson <ulfali...@gmail.com> wrote: > On Thu, Feb 8, 2018 at 6:56 AM, Masahiro Yamada > <yamada.masah...@socionext.com> wrote: >> If stdio is not tty, conf_askvalue() puts additional new line to >> prevent prompts are all c

Re: [PATCH 2/2] kconfig: echo stdin to stdout if either is redirected

On Thu, Feb 8, 2018 at 7:35 AM, Ulf Magnusson wrote: > On Thu, Feb 8, 2018 at 6:56 AM, Masahiro Yamada > wrote: >> If stdio is not tty, conf_askvalue() puts additional new line to >> prevent prompts are all concatenated into a single line. This care >> is missing in con

Re: [PATCH 2/2] kconfig: echo stdin to stdout if either is redirected

7 @@ int main(int ac, char **av) > bindtextdomain(PACKAGE, LOCALEDIR); > textdomain(PACKAGE); > > - tty_stdio = isatty(0) && isatty(1) && isatty(2); > + tty_stdio = isatty(0) && isatty(1); > > while ((opt = getopt_long(ac, av, "s&

Re: [PATCH 2/2] kconfig: echo stdin to stdout if either is redirected

t; textdomain(PACKAGE); > > - tty_stdio = isatty(0) && isatty(1) && isatty(2); > + tty_stdio = isatty(0) && isatty(1); > > while ((opt = getopt_long(ac, av, "s", long_opts, NULL)) != -1) { > if (opt == 's') {

Re: [PATCH 1/2] kconfig: remove check_stdin()

ugh */ > case oldaskconfig: > fflush(stdout); > @@ -650,7 +637,6 @@ int main(int ac, char **av) > return 1; > } > } > - valid_stdin = tty_stdio; > } > > switch (input_mode) { > -- > 2.7.4 > Reviewed-by: Ulf Magnusson <ulfali...@gmail.com> Lots of weird stuff indeed... Cheers, Ulf

Re: [PATCH 1/2] kconfig: remove check_stdin()

printf("%d\n", cnt); > break; > } > - check_stdin(); > /* fall through */ > case oldaskconfig: > fflu

Re: [PATCH 02/14] kconfig: do not write choice values when their dependency becomes n

On Thu, Feb 8, 2018 at 3:42 AM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > 2018-02-08 7:55 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: >> On Tue, Feb 06, 2018 at 09:34:42AM +0900, Masahiro Yamada wrote: >>> "# CONFIG_... is not set&quo

Re: [PATCH 02/14] kconfig: do not write choice values when their dependency becomes n

On Thu, Feb 8, 2018 at 3:42 AM, Masahiro Yamada wrote: > 2018-02-08 7:55 GMT+09:00 Ulf Magnusson : >> On Tue, Feb 06, 2018 at 09:34:42AM +0900, Masahiro Yamada wrote: >>> "# CONFIG_... is not set" for choice values are wrongly written into >>> the

[PATCH v2] spi: kconfig: Remove AVR32 dep. from SPI_ATMEL

The AVR32 symbol was removed in commit 26202873bb51 ("avr32: remove support for AVR32 architecture"). --- Changes in v2: Remove the AVR32 reference from the help text too. drivers/spi/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/Kconfig

[PATCH v2] spi: kconfig: Remove AVR32 dep. from SPI_ATMEL

The AVR32 symbol was removed in commit 26202873bb51 ("avr32: remove support for AVR32 architecture"). --- Changes in v2: Remove the AVR32 reference from the help text too. drivers/spi/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/Kconfig

Re: [PATCH 01/14] kconfig: send error messages to stderr

On Thu, Feb 8, 2018 at 2:49 AM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > 2018-02-08 5:24 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: >> On Tue, Feb 6, 2018 at 1:34 AM, Masahiro Yamada >> <yamada.masah...@socionext.com> wrote: >>> T

Re: [PATCH 01/14] kconfig: send error messages to stderr

On Thu, Feb 8, 2018 at 2:49 AM, Masahiro Yamada wrote: > 2018-02-08 5:24 GMT+09:00 Ulf Magnusson : >> On Tue, Feb 6, 2018 at 1:34 AM, Masahiro Yamada >> wrote: >>> These messages should be directed to stderr. >>> >>> Signed-off-by: Masahiro Yamada >

Re: [PATCH 07/14] kconfig: test: add framework for Kconfig unit-tests

tches('config', expected) > + > +def stdout_contains(self, expected): > +"""Check if resulted stdout contains expected data. > + > +Arguments: > +expected: file that contains the expected data. > + """ > +return self.__contains('stdout', expected) > + > +def stdout_matches(self, cmp_file): > +"""Check if resulted stdout exactly matches expected data. > + > +Arguments: > +expected: file that contains the expected data. > +""" > +return self.__matches('stdout', expected) > + > +def stderr_contains(self, expected): > +"""Check if resulted stderr contains expected data. > + > +Arguments: > +expected: file that contains the expected data. > +""" > +return self.__contains('stderr', expected) > + > +def stderr_matches(self, cmp_file): > +"""Check if resulted stderr exactly matches expected data. > + > +Arguments: > +expected: file that contains the expected data. > +""" > +return self.__matches('stderr', expected) > + > +@pytest.fixture(scope="module") > +def conf(request): > +return Conf(request) > diff --git a/scripts/kconfig/tests/pytest.ini > b/scripts/kconfig/tests/pytest.ini > new file mode 100644 > index 000..07b94e0 > --- /dev/null > +++ b/scripts/kconfig/tests/pytest.ini > @@ -0,0 +1,6 @@ > +[pytest] > +addopts = --verbose > +# Pytest requires that test files have unique names, because pytest imports > +# them as top-level modules. It is silly to prefix or suffix a test file > with > +# the directory name that contains it. Use __init__.py for all test files. > +python_files = __init__.py > -- > 2.7.4 > Reviewed-by: Ulf Magnusson <ulfali...@gmail.com>

Re: [PATCH 07/14] kconfig: test: add framework for Kconfig unit-tests

t;Check if resulted stdout contains expected data. > + > +Arguments: > +expected: file that contains the expected data. > +""" > +return self.__contains('stdout', expected) > + > +def stdout_matches(self, cmp_file): > +"""Check if resulted stdout exactly matches expected data. > + > +Arguments: > +expected: file that contains the expected data. > +""" > +return self.__matches('stdout', expected) > + > +def stderr_contains(self, expected): > +"""Check if resulted stderr contains expected data. > + > +Arguments: > +expected: file that contains the expected data. > +""" > +return self.__contains('stderr', expected) > + > +def stderr_matches(self, cmp_file): > +"""Check if resulted stderr exactly matches expected data. > + > +Arguments: > +expected: file that contains the expected data. > +""" > +return self.__matches('stderr', expected) > + > +@pytest.fixture(scope="module") > +def conf(request): > +return Conf(request) > diff --git a/scripts/kconfig/tests/pytest.ini > b/scripts/kconfig/tests/pytest.ini > new file mode 100644 > index 000..07b94e0 > --- /dev/null > +++ b/scripts/kconfig/tests/pytest.ini > @@ -0,0 +1,6 @@ > +[pytest] > +addopts = --verbose > +# Pytest requires that test files have unique names, because pytest imports > +# them as top-level modules. It is silly to prefix or suffix a test file > with > +# the directory name that contains it. Use __init__.py for all test files. > +python_files = __init__.py > -- > 2.7.4 > Reviewed-by: Ulf Magnusson

Re: [PATCH 14/14] kconfig: test: check if recursive inclusion is detected

t; +++ b/scripts/kconfig/tests/err_recursive_inc/expected_stderr > @@ -0,0 +1,4 @@ > +Kconfig:1: recursive inclusion detected. Inclusion path: > + current file : 'Kconfig' > + included from: 'Kconfig.inc:1' > + included from: 'Kconfig:3' > -- > 2.7.4 > Reviewed-by: Ulf Magnusson <ulfali...@gmail.com>

Re: [PATCH 14/14] kconfig: test: check if recursive inclusion is detected

derr') > diff --git a/scripts/kconfig/tests/err_recursive_inc/expected_stderr > b/scripts/kconfig/tests/err_recursive_inc/expected_stderr > new file mode 100644 > index 000..b256c91 > --- /dev/null > +++ b/scripts/kconfig/tests/err_recursive_inc/expected_stderr > @@ -0,0 +1,4 @@ > +Kconfig:1: recursive inclusion detected. Inclusion path: > + current file : 'Kconfig' > + included from: 'Kconfig.inc:1' > + included from: 'Kconfig:3' > -- > 2.7.4 > Reviewed-by: Ulf Magnusson

Re: [PATCH 13/14] kconfig: test: check if recursive dependencies are detected

ted by D1 > +Kconfig:25:symbol D1 depends on D2 > +For a resolution refer to Documentation/kbuild/kconfig-language.txt > +subsection "Kconfig recursive dependency limitations" > + > +Kconfig:59:error: recursive dependency detected! > +Kconfig:59:symbol G depends on G > +For a resolution refer to Documentation/kbuild/kconfig-language.txt > +subsection "Kconfig recursive dependency limitations" > + > +Kconfig:50:error: recursive dependency detected! > +Kconfig:50:symbol F2 depends on F1 > +Kconfig:48:symbol F1 default value contains F2 > +For a resolution refer to Documentation/kbuild/kconfig-language.txt > +subsection "Kconfig recursive dependency limitations" > -- > 2.7.4 > Besides the missing end quote: Reviewed-by: Ulf Magnusson <ulfali...@gmail.com>

Re: [PATCH 13/14] kconfig: test: check if recursive dependencies are detected

olution refer to Documentation/kbuild/kconfig-language.txt > +subsection "Kconfig recursive dependency limitations" > + > +Kconfig:59:error: recursive dependency detected! > +Kconfig:59:symbol G depends on G > +For a resolution refer to Documentation/kbuild/kconfig-language.txt > +subsection "Kconfig recursive dependency limitations" > + > +Kconfig:50:error: recursive dependency detected! > +Kconfig:50:symbol F2 depends on F1 > +Kconfig:48:symbol F1 default value contains F2 > +For a resolution refer to Documentation/kbuild/kconfig-language.txt > +subsection "Kconfig recursive dependency limitations" > -- > 2.7.4 > Besides the missing end quote: Reviewed-by: Ulf Magnusson

Re: [PATCH 12/14] kconfig: test: check visibility of tristate choice values in y choice

_DEP=m > +CONFIG_CHOICE0=y > diff --git a/scripts/kconfig/tests/choice_value_with_m_dep/expected_stdout > b/scripts/kconfig/tests/choice_value_with_m_dep/expected_stdout > new file mode 100644 > index 000..5eac85d > --- /dev/null > +++ b/scripts/kconfig/tests/choice_value_with_m_dep/expected_stdout > @@ -0,0 +1,4 @@ > +Tristate Choice [M/y/?] > +Tristate Choice > +> 1. Choice 0 (CHOICE0) > +choice[1]: 1 > -- > 2.7.4 > Reviewed-by: Ulf Magnusson <ulfali...@gmail.com>

Re: [PATCH 12/14] kconfig: test: check visibility of tristate choice values in y choice

h_m_dep/expected_config > new file mode 100644 > index 000..4d07b44 > --- /dev/null > +++ b/scripts/kconfig/tests/choice_value_with_m_dep/expected_config > @@ -0,0 +1,3 @@ > +CONFIG_MODULES=y > +CONFIG_DEP=m > +CONFIG_CHOICE0=y > diff --git a/scripts/kconfig/tests/choice_value_with_m_dep/expected_stdout > b/scripts/kconfig/tests/choice_value_with_m_dep/expected_stdout > new file mode 100644 > index 000..5eac85d > --- /dev/null > +++ b/scripts/kconfig/tests/choice_value_with_m_dep/expected_stdout > @@ -0,0 +1,4 @@ > +Tristate Choice [M/y/?] > +Tristate Choice > +> 1. Choice 0 (CHOICE0) > +choice[1]: 1 > -- > 2.7.4 > Reviewed-by: Ulf Magnusson

Re: [PATCH 11/14] kconfig: test: check .config sanity for choice values with unmet dep

ff --git a/scripts/kconfig/tests/no_write_if_dep_unmet/expected_config > b/scripts/kconfig/tests/no_write_if_dep_unmet/expected_config > new file mode 100644 > index 000..0d15e41 > --- /dev/null > +++ b/scripts/kconfig/tests/no_write_if_dep_unmet/expected_config > @@ -0,0 +1,5 @@ > +# > +# Automatically generated file; DO NOT EDIT. > +# Linux Kernel Configuration > +# > +# CONFIG_A is not set > -- > 2.7.4 > Reviewed-by: Ulf Magnusson <ulfali...@gmail.com> This indirectly tests that choices specified without a type get the type of the first choice value specified with a type too. Cheers, Ulf

Re: [PATCH 11/14] kconfig: test: check .config sanity for choice values with unmet dep

; b/scripts/kconfig/tests/no_write_if_dep_unmet/expected_config > new file mode 100644 > index 000..0d15e41 > --- /dev/null > +++ b/scripts/kconfig/tests/no_write_if_dep_unmet/expected_config > @@ -0,0 +1,5 @@ > +# > +# Automatically generated file; DO NOT EDIT. > +# Linux Kernel Configuration > +# > +# CONFIG_A is not set > -- > 2.7.4 > Reviewed-by: Ulf Magnusson This indirectly tests that choices specified without a type get the type of the first choice value specified with a type too. Cheers, Ulf

Re: [PATCH 10/14] kconfig: test: check if new symbols in choice are asked

D is not set > +CONFIG_CHOICE_E=y > diff --git a/scripts/kconfig/tests/new_choice_with_dep/expected_stdout > b/scripts/kconfig/tests/new_choice_with_dep/expected_stdout > new file mode 100644 > index 000..358d5cf > --- /dev/null > +++ b/scripts/kconfig/tests/new_choice_with_dep/expected_stdout > @@ -0,0 +1,10 @@ > +A (A) [N/y/?] (NEW) > + Choice ? > + > 1. Choice B (CHOICE_B) > +2. Choice C (CHOICE_C) (NEW) > + choice[1-2?]: > +Choice2 ? > + 1. Choice D (CHOICE_D) > +> 2. Choice E (CHOICE_E) > + 3. Choice F (CHOICE_F) (NEW) > +choice[1-3?]: > -- > 2.7.4 > Reviewed-by: Ulf Magnusson <ulfali...@gmail.com>

Re: [PATCH 10/14] kconfig: test: check if new symbols in choice are asked

s/new_choice_with_dep/expected_stdout > b/scripts/kconfig/tests/new_choice_with_dep/expected_stdout > new file mode 100644 > index 000..358d5cf > --- /dev/null > +++ b/scripts/kconfig/tests/new_choice_with_dep/expected_stdout > @@ -0,0 +1,10 @@ > +A (A) [N/y/?] (NEW) > + Choice ? > + > 1. Choice B (CHOICE_B) > +2. Choice C (CHOICE_C) (NEW) > + choice[1-2?]: > +Choice2 ? > + 1. Choice D (CHOICE_D) > +> 2. Choice E (CHOICE_E) > + 3. Choice F (CHOICE_F) (NEW) > +choice[1-3?]: > -- > 2.7.4 > Reviewed-by: Ulf Magnusson

Re: [PATCH 09/14] kconfig: test: test automatic submenu creation

assert conf.stdout_contains('expected_stdout') > diff --git a/scripts/kconfig/tests/auto_submenu_creation/expected_stdout > b/scripts/kconfig/tests/auto_submenu_creation/expected_stdout > new file mode 100644 > index 000..bf5236f > --- /dev/null > +++ b/scripts/kconfig/tests/auto_submenu_creation/expected_stdout > @@ -0,0 +1,10 @@ > +A (A) [Y/n/?] (NEW) > + A0 (A0) [Y/n/?] (NEW) > +A1_0 (A0_0) [N/y/?] (NEW) > + A1 (A1) [Y/n/?] (NEW) > +choice > +> 1. A1_0 (A1_0) (NEW) > + 2. A1_1 (A1_1) (NEW) > +choice[1-2?]: > +B (B) [N/y/?] (NEW) > +C (C) [N/y/?] (NEW) > -- > 2.7.4 > Reviewed-by: Ulf Magnusson <ulfali...@gmail.com>

Re: [PATCH 09/14] kconfig: test: test automatic submenu creation

nfig/tests/auto_submenu_creation/expected_stdout > b/scripts/kconfig/tests/auto_submenu_creation/expected_stdout > new file mode 100644 > index 000..bf5236f > --- /dev/null > +++ b/scripts/kconfig/tests/auto_submenu_creation/expected_stdout > @@ -0,0 +1,10 @@ > +A (A) [Y/n/?] (NEW) > + A0 (A0) [Y/n/?] (NEW) > +A1_0 (A0_0) [N/y/?] (NEW) > + A1 (A1) [Y/n/?] (NEW) > +choice > +> 1. A1_0 (A1_0) (NEW) > + 2. A1_1 (A1_1) (NEW) > +choice[1-2?]: > +B (B) [N/y/?] (NEW) > +C (C) [N/y/?] (NEW) > -- > 2.7.4 > Reviewed-by: Ulf Magnusson

Re: [PATCH 08/14] kconfig: test: add basic 'choice' tests

t; diff --git a/scripts/kconfig/tests/choice/oldask1_config > b/scripts/kconfig/tests/choice/oldask1_config > new file mode 100644 > index 000..b67bfe3 > --- /dev/null > +++ b/scripts/kconfig/tests/choice/oldask1_config > @@ -0,0 +1,2 @@ > +# CONFIG_MODULES is not set > +CONFIG_OPT_BOOL_CHOICE0=y > diff --git a/scripts/kconfig/tests/choice/oldask1_expected_stdout > b/scripts/kconfig/tests/choice/oldask1_expected_stdout > new file mode 100644 > index 000..c2125e9b > --- /dev/null > +++ b/scripts/kconfig/tests/choice/oldask1_expected_stdout > @@ -0,0 +1,15 @@ > +Enable loadable module support (MODULES) [N/y/?] > +boolean choice > + 1. choice 0 (BOOL_CHOICE0) (NEW) > +> 2. choice 1 (BOOL_CHOICE1) (NEW) > +choice[1-2?]: > +optional boolean choice [Y/n/?] (NEW) > +optional boolean choice > +> 1. choice 0 (OPT_BOOL_CHOICE0) > + 2. choice 1 (OPT_BOOL_CHOICE1) (NEW) > +choice[1-2?]: > +tristate choice > + 1. choice 0 (TRI_CHOICE0) (NEW) > +> 2. choice 1 (TRI_CHOICE1) (NEW) > +choice[1-2?]: > +optional tristate choice [N/y/?] > -- > 2.7.4 > Reviewed-by: Ulf Magnusson <ulfali...@gmail.com>

Re: [PATCH 08/14] kconfig: test: add basic 'choice' tests

kconfig/tests/choice/oldask1_config > new file mode 100644 > index 000..b67bfe3 > --- /dev/null > +++ b/scripts/kconfig/tests/choice/oldask1_config > @@ -0,0 +1,2 @@ > +# CONFIG_MODULES is not set > +CONFIG_OPT_BOOL_CHOICE0=y > diff --git a/scripts/kconfig/tests/choice/oldask1_expected_stdout > b/scripts/kconfig/tests/choice/oldask1_expected_stdout > new file mode 100644 > index 000..c2125e9b > --- /dev/null > +++ b/scripts/kconfig/tests/choice/oldask1_expected_stdout > @@ -0,0 +1,15 @@ > +Enable loadable module support (MODULES) [N/y/?] > +boolean choice > + 1. choice 0 (BOOL_CHOICE0) (NEW) > +> 2. choice 1 (BOOL_CHOICE1) (NEW) > +choice[1-2?]: > +optional boolean choice [Y/n/?] (NEW) > +optional boolean choice > +> 1. choice 0 (OPT_BOOL_CHOICE0) > + 2. choice 1 (OPT_BOOL_CHOICE1) (NEW) > +choice[1-2?]: > +tristate choice > + 1. choice 0 (TRI_CHOICE0) (NEW) > +> 2. choice 1 (TRI_CHOICE1) (NEW) > +choice[1-2?]: > +optional tristate choice [N/y/?] > -- > 2.7.4 > Reviewed-by: Ulf Magnusson

Re: [PATCH 05/14] kconfig: remove 'config*' pattern from .gitignnore

76856e 100644 > --- a/scripts/kconfig/.gitignore > +++ b/scripts/kconfig/.gitignore > @@ -1,7 +1,6 @@ > # > # Generated files > # > -config* > *.lex.c > *.tab.c > *.tab.h > -- > 2.7.4 > Reviewed-by: Ulf Magnusson <ulfali...@gmail.com>

Re: [PATCH 05/14] kconfig: remove 'config*' pattern from .gitignnore

fig/.gitignore > @@ -1,7 +1,6 @@ > # > # Generated files > # > -config* > *.lex.c > *.tab.c > *.tab.h > -- > 2.7.4 > Reviewed-by: Ulf Magnusson

Re: [PATCH 04/14] kconfig: print additional new line for choice for redirection

xfgets(line, sizeof(line), stdin); > + if (!tty_stdio) > + printf("\n"); > strip(line); > if (line[0] == '?') { > print_help(menu); > --

Re: [PATCH 04/14] kconfig: print additional new line for choice for redirection

if (!tty_stdio) > + printf("\n"); > strip(line); > if (line[0] == '?') { > print_help(menu); > -- > 2.7.4 > Reviewed-by: Ulf Magnusson Maybe this could be moved into the xfgets() function as well. Cheers, Ulf

Re: [PATCH 00/14] Add Kconfig unit tests

On Tue, Feb 6, 2018 at 10:38 AM, Greg Kroah-Hartman wrote: > On Tue, Feb 06, 2018 at 09:34:40AM +0900, Masahiro Yamada wrote: >> I am applying various patches to Kconfig these days. >> >> However, I fear regressions. I have been thinking of unit-tests. >> >> There are

Re: [PATCH 00/14] Add Kconfig unit tests

On Tue, Feb 6, 2018 at 10:38 AM, Greg Kroah-Hartman wrote: > On Tue, Feb 06, 2018 at 09:34:40AM +0900, Masahiro Yamada wrote: >> I am applying various patches to Kconfig these days. >> >> However, I fear regressions. I have been thinking of unit-tests. >> >> There are various cryptic parts in

Re: [PATCH 02/14] kconfig: do not write choice values when their dependency becomes n

s &= ~SYMBOL_WRITE; > > sym_calc_visibility(sym); > > @@ -385,6 +384,7 @@ void sym_calc_value(struct symbol *sym) > if (sym_is_choice_value(sym) && sym->visible == yes) { > prop = sym_get_choice_prop(sym); >

Re: [PATCH 02/14] kconfig: do not write choice values when their dependency becomes n

; sym_calc_visibility(sym); > > @@ -385,6 +384,7 @@ void sym_calc_value(struct symbol *sym) > if (sym_is_choice_value(sym) && sym->visible == yes) { > prop = sym_get_choice_prop(sym); > newval.tri = (prop_get_sym

Re: [PATCH 03/14] kconfig: show '?' prompt even if no help text is available

goto conf_childs; > } > - printf("[1-%d", cnt); > - if (menu_has_help(menu)) > - printf("?"); > - printf("]: "); > + printf("[1-%d?]: ", cnt); > switch (input_mode) { > case oldconfig: > case silentoldconfig: > -- > 2.7.4 > Reviewed-by: Ulf Magnusson <ulfali...@gmail.com>

Re: [PATCH 03/14] kconfig: show '?' prompt even if no help text is available

f("[1-%d", cnt); > - if (menu_has_help(menu)) > - printf("?"); > - printf("]: "); > + printf("[1-%d?]: ", cnt); > switch (input_mode) { > case oldconfig: > case silentoldconfig: > -- > 2.7.4 > Reviewed-by: Ulf Magnusson

Re: [PATCH 01/14] kconfig: send error messages to stderr

t;lineno-1); > + fprintf(stderr, " included from: '%s:%d'\n", > + iter->name, iter->lineno-1); > iter = iter->parent; > } > if (iter) > - printf(" included from: '%s:%d'\n", > - iter->name, iter->lineno+1); > + fprintf(stderr, " included from: '%s:%d'\n", > + iter->name, iter->lineno+1); > exit(1); > } > } > -- > 2.7.4 > The unrelated gettext stuff aside: Reviewed-by: Ulf Magnusson <ulfali...@gmail.com> Cheers, Ulf

Re: [PATCH 01/14] kconfig: send error messages to stderr

&& \ >strcmp(iter->name,current_file->name)) { > - printf(" included from: '%s:%d'\n", > - iter->name, iter->lineno-1); > + fprintf(stderr, " included from: '%s:%d'\n", > + iter->name, iter->lineno-1); > iter = iter->parent; > } > if (iter) > - printf(" included from: '%s:%d'\n", > - iter->name, iter->lineno+1); > + fprintf(stderr, " included from: '%s:%d'\n", > + iter->name, iter->lineno+1); > exit(1); > } > } > -- > 2.7.4 > The unrelated gettext stuff aside: Reviewed-by: Ulf Magnusson Cheers, Ulf

Re: [PATCH v3 03/20] kconfig: Remove leftover references to AVR32 symbol

On Tue, Feb 6, 2018 at 1:08 PM, Mark Brown <broo...@kernel.org> wrote: > On Mon, Feb 05, 2018 at 08:05:39PM +0100, Ulf Magnusson wrote: >> The AVR32 symbol was removed in commit 26202873bb51 ("avr32: remove >> support for AVR32 architecture"). Remove the rem

Re: [PATCH v3 03/20] kconfig: Remove leftover references to AVR32 symbol

On Tue, Feb 6, 2018 at 1:08 PM, Mark Brown wrote: > On Mon, Feb 05, 2018 at 08:05:39PM +0100, Ulf Magnusson wrote: >> The AVR32 symbol was removed in commit 26202873bb51 ("avr32: remove >> support for AVR32 architecture"). Remove the remaining references to it

Re: [PATCH v3 03/20] kconfig: Remove leftover references to AVR32 symbol

On Mon, Feb 5, 2018 at 8:05 PM, Ulf Magnusson <ulfali...@gmail.com> wrote: > The AVR32 symbol was removed in commit 26202873bb51 ("avr32: remove > support for AVR32 architecture"). Remove the remaining references to it > from the Kconfig files. > > Signed-off-by: Ulf

Re: [PATCH v3 03/20] kconfig: Remove leftover references to AVR32 symbol

On Mon, Feb 5, 2018 at 8:05 PM, Ulf Magnusson wrote: > The AVR32 symbol was removed in commit 26202873bb51 ("avr32: remove > support for AVR32 architecture"). Remove the remaining references to it > from the Kconfig files. > > Signed-off-by: Ulf Magnusson > --

[PATCH] spi: kconfig: Remove AVR32 dep. from SPI_ATMEL

The AVR32 symbol was removed in commit 26202873bb51 ("avr32: remove support for AVR32 architecture"). Signed-off-by: Ulf Magnusson <ulfali...@gmail.com> --- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/Kconfig b/drivers/s

[PATCH] spi: kconfig: Remove AVR32 dep. from SPI_ATMEL

The AVR32 symbol was removed in commit 26202873bb51 ("avr32: remove support for AVR32 architecture"). Signed-off-by: Ulf Magnusson --- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 60

[PATCH] video: console: kconfig: Remove AVR32 dep. from VGA_CONSOLE

The AVR32 symbol was removed in commit 26202873bb51 ("avr32: remove support for AVR32 architecture"). Signed-off-by: Ulf Magnusson <ulfali...@gmail.com> --- drivers/video/console/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/console/K

[PATCH] video: console: kconfig: Remove AVR32 dep. from VGA_CONSOLE

The AVR32 symbol was removed in commit 26202873bb51 ("avr32: remove support for AVR32 architecture"). Signed-off-by: Ulf Magnusson --- drivers/video/console/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/console/Kconfig b/drivers/video/conso

Re: [PATCH 20/20] x86/PCI: VMD: Fix malformed default

On Tue, Feb 6, 2018 at 8:11 PM, Bjorn Helgaas <helg...@kernel.org> wrote: >> x86/PCI: VMD: Fix malformed default > > In the title, please include a clue about what default you're talking > about, e.g., mention Kconfig somehow. > > On Mon, Feb 05, 2018 at 02:21:32AM

<    1   2   3   4   5   6   7   >