[PATCH v2] irqchip: Add support for ARMv7-M's NVIC

2013-03-18 Thread Uwe Kleine-König
This interrupt controller is found on Cortex-M3 and Cortex-M4 machines. Support for this controller appeared in Catalin's Cortex tree based on 2.6.33 but was nearly completely rewritten. Signed-off-by: Catalin Marinas Signed-off-by: Uwe Kleine-König --- Hello, changes since v1: - fixed

Re: [PATCH] clk: divider: Use DIV_ROUND_CLOSEST

2013-03-21 Thread Uwe Kleine-König
long upper_limit = clk_round_rate(clk, rate + (rate - lower_limit)); if (rate - lower_limit < upper_limit - rate) return lower_limit; else return upper_limit; } Best regards Uwe -- Pengutron

[PATCH] irqchip: Add support for ARMv7-M's NVIC

2013-03-12 Thread Uwe Kleine-König
From: Catalin Marinas This interrupt controller is found on Cortex-M3 and Cortex-M4 machines. [ukleinek: drop locking, switch to fasteoi handler, add irqdomain and dt support, move to drivers/irq] Signed-off-by: Catalin Marinas Signed-off-by: Uwe Kleine-König --- drivers/irqchip/Kconfig

Re: [PATCH] irqchip: Add support for ARMv7-M's NVIC

2013-03-12 Thread Uwe Kleine-König
On Tue, Mar 12, 2013 at 04:01:01PM +, Russell King - ARM Linux wrote: > On Tue, Mar 12, 2013 at 04:54:33PM +0100, Uwe Kleine-König wrote: > > +#include > > +#include > > linux/io.h > > > + unsigned int irqs, i, irq_base; > > + > > + ir

Re: [PATCH] irqchip: Add support for ARMv7-M's NVIC

2013-03-12 Thread Uwe Kleine-König
Hello Thomas, On Tue, Mar 12, 2013 at 08:57:34PM +0100, Thomas Gleixner wrote: > On Tue, 12 Mar 2013, Uwe Kleine-König wrote: > > +static struct nvic_chip_data nvic_data __read_mostly; > > What the heck is this? You have a static struct which you set in > irqdata.chip_data?

Re: [PATCH] dma: tegra: add const to of_device_id.data's structure

2012-08-28 Thread Uwe Kleine-König
lation warning like > > drivers/dma/tegra20-apb-dma.c:1217:9: warning: assignment discards 'const' > > qualifier from > > pointer target type [enabled by default] > > > > This warning came after the change > > ----- > > commit 98d7bbb9929b

Re: [PATCH RESEND] dma: tegra: add const to of_device_id.data's structure

2012-08-29 Thread Uwe Kleine-König
-dma.c:1217:9: warning: assignment discards 'const' > qualifier from > pointer target type [enabled by default] > > This warning came after the change > - > commit 98d7bbb9929bcc14e11ac8a55245a4f2dc174e17 > Author: Uwe Kleine-König > of: add const to struct *

[PATCH 2/2] dma: tegra: make data used as *of_device_id.data const

2012-08-29 Thread Uwe Kleine-König
dewan...@nvidia.com] Signed-off-by: Laxman Dewangan Acked-by: Stephen Warren Acked-by: Vinod Koul Signed-off-by: Uwe Kleine-König --- drivers/dma/tegra20-apb-dma.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c

[PATCH 1/2] dma: tegra: make tegra_dma.chip_data a pointer to const data

2012-08-29 Thread Uwe Kleine-König
y: Vinod Koul Signed-off-by: Uwe Kleine-König --- drivers/dma/tegra20-apb-dma.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index d52dbc6..29a39b8 100644 --- a/drivers/dma/tegra20-apb-dma.c +++ b/driv

[PATCH] MAINTAINERS: add defconfig file to TEGRA section

2012-08-29 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 94b823f..39d8a59 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6779,6 +6779,7 @@ Q: http://patchwork.ozlabs.org/project/linux-tegra/list/ T: git

Re: [PATCH] Revert "spi/doc: spi_master_put must be followed up by kfree"

2012-09-04 Thread Uwe Kleine-König
struct spi_master *spi_alloc_master(struct device *dev, unsigned size) > { -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: [PATCH 1/2] dma: tegra: make tegra_dma.chip_data a pointer to const data

2012-09-10 Thread Uwe Kleine-König
On Mon, Sep 10, 2012 at 12:21:09PM -0600, Stephen Warren wrote: > On 08/29/2012 02:51 AM, Uwe Kleine-König wrote: > > From: Laxman Dewangan > > > > This prepares *of_device_id.data becoming const. Without this change > > the following warning would occur: > >

[PATCH] at24: make module parameters changeable via sysfs

2012-09-12 Thread Uwe Kleine-König
The respective values are evaluated at each read/write, so no further action is required than to change the perm argument to module_param. Note there is no sanity check so root can make the driver effectively unusable but that's what root is for :-) Signed-off-by: Uwe Kleine-König --- dr

Re: linux-next: manual merge of the arm-soc tree with the i2c-embedded tree

2012-09-13 Thread Uwe Kleine-König
and commit 07baca6f8fc2 > ("i2c/i2c-omap: add a const qualifier") from the arm-soc tree. > > I fixed it up (see below) and can carry the fix as necessary (no action > is required). looks correct. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine

Re: [PATCH] gpiolib: add another might_sleep

2012-09-13 Thread Uwe Kleine-König
Hello, On Mon, Aug 29, 2011 at 01:01:42PM -0600, Grant Likely wrote: > On Thu, Feb 17, 2011 at 10:18:53PM +0100, Uwe Kleine-König wrote: > > Signed-off-by: Uwe Kleine-König > > Applied, thanks. I cannot see it in Linus' tree?! > > --- > > drivers/gpio/gpiolib

rcu_process_callbacks pending in tick_nohz_stop_sched_tick (Was: NOHZ: local_softirq_pending 20)

2008-02-02 Thread Uwe Kleine-König
Hello, Thomas Gleixner wrote: > On Fri, 23 Nov 2007, Uwe Kleine-König wrote: > > my kernel reported: > > > > NOHZ: local_softirq_pending 20 > > Thats TASKLET_SOFTIRQ > > > I cannot interpret it, but probably this is bad, because before > > bc5

Re: [PATCH 0/7] Add support for Freescale's mc34708 to mc13xxx driver

2012-10-04 Thread Uwe Kleine-König
27 Author: Samuel Ortiz 4 Cc: Samuel Ortiz 1 Signed-off-by: Samuel Ortiz 50 Signed-off-by: Samuel Ortiz and one of these just happend to be the first I looked at. hmm, *shrug* Uwe -- Pengutronix e.K. | Uwe Kleine-König

pwm pin stays on 1 on mxs after pwm_config(pwm, 0, period); pwm_disable(pwm);

2012-10-24 Thread Uwe Kleine-König
r something different I didn't think of? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-ke

[PATCH] RFC: leds-pwm: don't disable pwm when setting brightness to 0

2012-10-24 Thread Uwe Kleine-König
d PWM block the period never ends. It's unclear if the mxs-pwm driver doesn't implement the API as expected (i.e. it should block until the newly set config is effective) or if the leds-pwm driver makes wrong assumptions. This patch assumes the latter. Signed-off-by: Uwe Kleine-König

[PATCH] trivial: fix alignment of IP-Config output

2008-02-12 Thread Uwe Kleine-König
make the intended lines aligned in the output (not in the code) Signed-off-by: Uwe Kleine-König <[EMAIL PROTECTED]> --- net/ipv4/ipconfig.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c index a52b585..10013cc 100644 --- a/net/

[PATCH] call gpio_cansleep only after gpio_request succeeded

2008-02-14 Thread Uwe Kleine-König
If you have GPIO_LIB gpio_cansleep oopses on an invalid gpio. So better gpio_request your pin first. Signed-off-by: Uwe Kleine-König <[EMAIL PROTECTED]> Cc: David Brownell <[EMAIL PROTECTED]> Cc: Raphael Assenat <[EMAIL PROTECTED]> Cc: Richard Purdie <[EMAIL PROTECTED]>

Re: [PATCH] call gpio_cansleep only after gpio_request succeeded

2008-02-14 Thread Uwe Kleine-König
Hello, Uwe Kleine-König wrote: > diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c > index 6c0a9c4..76ddcf3 100644 > --- a/drivers/leds/leds-gpio.c > +++ b/drivers/leds/leds-gpio.c > @@ -79,6 +79,10 @@ static int gpio_led_probe(struct platform_device *pdev) >

Re: linux-next: manual merge of the signal tree with the cortex tree

2012-11-05 Thread Uwe Kleine-König
f > } else { > memset(childregs, 0, sizeof(struct pt_regs)); > thread->cpu_context.r4 = stk_sz; looks good and works for me Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solut

Re: [dm-crypt] cryptsetup not working under 3.6 - RT patch set seem to break it

2012-10-30 Thread Uwe Kleine-König
experienced that problem, too. This is on a laptop with encrypted rootfs, so debugging is a bit harder here. I am just setting up another machine to debug that. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions

Re: [PATCH] Fix crypto api init for 3.6.4-rt10

2012-10-30 Thread Uwe Kleine-König
Thanks for spotting! This patch fixes booting my laptop. But now it hangs after login. thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line &

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-05 Thread Uwe Kleine-König
what you want to do with the return value. When doing if (clk_is_enabled(someclk)) do_something(); you cannot in general know if the clock is still on when you start to do_something. Best regards Uwe -- Pengutronix e.K. | Uwe Kle

Re: [PATCH V5 0/5] Queue work on power efficient wq

2013-07-08 Thread Uwe Kleine-König
2 - big.LITTLE CPU > - Core 0-1: A15, 2-4: A7 > - rootfs: linaro-ubuntu-devel This patch set hit my tree now. I wonder if it makes sense to make WQ_POWER_EFFICIENT_DEFAULT depend on SMP. (Oh wait, big.LITTLE isn't SMP, so probably there is a better symbol to depend on?) Just my 2 cent Uwe

Re: [PATCH V5 0/5] Queue work on power efficient wq

2013-07-08 Thread Uwe Kleine-König
On Mon, Jul 08, 2013 at 09:17:01PM +0530, Viresh Kumar wrote: > On 8 July 2013 21:07, Uwe Kleine-König wrote: > > This patch set hit my tree now. I wonder if it makes sense to make > > WQ_POWER_EFFICIENT_DEFAULT depend on SMP. (Oh wait, big.LITTLE isn't > > SMP, so

Re: [PATCH V5 0/5] Queue work on power efficient wq

2013-07-08 Thread Uwe Kleine-König
Hello, On Mon, Jul 08, 2013 at 10:18:08PM +0530, Viresh Kumar wrote: > On 8 July 2013 21:27, Uwe Kleine-König wrote: > > On Mon, Jul 08, 2013 at 09:17:01PM +0530, Viresh Kumar wrote: > > >> Well, big LITTLE still runs an SMP kernel :) and so has this flag set. > > T

[RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-09-16 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König --- Hello, I'm not sure that the way I implemented if a given timer is used as clock_source or clock_event_device is robust. Does it need locking? The reason to create a timer device for each timer instead of a single device of all of them is that it mak

Re: [PATCH] clockevents: Sanitize ticks to nsec conversion

2013-09-18 Thread Uwe Kleine-König
rrection) exceeded the 64 bit boundary. > + */ > + if ((clc >> evt->shift) != (u64)latch) > + clc = ((u64)1 << 63) - 1; > + > do_div(clc, evt->mult); > - if (clc < 1000) > - clc = 1000; > - if (clc > KTIME_M

Re: [PATCH] clockevents: Sanitize ticks to nsec conversion

2013-09-18 Thread Uwe Kleine-König
Hello Thomas, On Wed, Sep 18, 2013 at 11:38:07AM +0200, Thomas Gleixner wrote: > On Wed, 18 Sep 2013, Uwe Kleine-König wrote: > > > Now we can easily verify whether the whole equation fits into the > > > 64bit boundary. Shifting the "clc" result back by evt->shif

Re: [PATCH] clockevents: Sanitize ticks to nsec conversion

2013-09-19 Thread Uwe Kleine-König
Hello Thomas, On Thu, Sep 19, 2013 at 12:01:25AM +0200, Thomas Gleixner wrote: > On Wed, 18 Sep 2013, Uwe Kleine-König wrote: > > On Wed, Sep 18, 2013 at 11:38:07AM +0200, Thomas Gleixner wrote: > > > On Wed, 18 Sep 2013, Uwe Kleine-König wrote: > > > > Anothe

Re: [PATCH] clockevents: Sanitize ticks to nsec conversion

2013-09-19 Thread Uwe Kleine-König
Hello Thomas, On Thu, Sep 19, 2013 at 12:15:10PM +0200, Thomas Gleixner wrote: > On Thu, 19 Sep 2013, Uwe Kleine-König wrote: > > On Thu, Sep 19, 2013 at 12:01:25AM +0200, Thomas Gleixner wrote: > > > Versus the 64bit overflow check, we need to be even more careful. We >

Re: [PATCH] clockevents: Sanitize ticks to nsec conversion

2013-09-19 Thread Uwe Kleine-König
elta_ticks, dev); > - dev->max_delta_ns = clockevent_delta2ns(dev->max_delta_ticks, dev); > + dev->min_delta_ns = cev_delta2ns(dev->min_delta_ticks, dev, false); > + dev->max_delta_ns = cev_delta2ns(dev->max_delta_ticks, dev, true); Another impro

[GIT PULL] fixes for integer rounding in timer core (Was: [PATCH v2] clockevents: Sanitize ticks to nsec conversion)

2013-10-08 Thread Uwe Kleine-König
- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH 2/9] i2c: i2c-imx: replace platform_driver_probe to support deferred probing

2013-10-09 Thread Uwe Kleine-König
er to have that, so the > devices it supports won't get lost in a deferred probe. > > Signed-off-by: Wolfram Sang > Cc: ker...@pengutronix.de Acked-by: Uwe Kleine-König Thanks Uwe > --- > drivers/i2c/busses/i2c-imx.c | 11 ++- > 1 file changed, 6 insertions(+),

Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-09-26 Thread Uwe Kleine-König
On Wed, Sep 25, 2013 at 04:55:15PM -0700, John Stultz wrote: > On 09/25/2013 04:49 PM, Daniel Lezcano wrote: > > On 09/25/2013 05:32 PM, Uwe Kleine-König wrote: > >> Hello Daniel, > >> > >> On Wed, Sep 25, 2013 at 04:33:24PM +0200, Daniel Lezcano wrote: >

Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-09-26 Thread Uwe Kleine-König
Hello Daniel, On Thu, Sep 26, 2013 at 01:49:52AM +0200, Daniel Lezcano wrote: > On 09/25/2013 05:32 PM, Uwe Kleine-König wrote: > >>> +static void __init efm32_timer_init(struct device_node *np) > >>> +{ > >>> + static int has_clocksource, has_clockeve

Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-09-26 Thread Uwe Kleine-König
Hello Daniel, On Thu, Sep 26, 2013 at 10:52:29AM +0200, Daniel Lezcano wrote: > On 09/26/2013 10:20 AM, Uwe Kleine-König wrote: > >Hello Daniel, > > > >On Thu, Sep 26, 2013 at 01:49:52AM +0200, Daniel Lezcano wrote: > >>On 09/25/2013 05:32 PM, Uwe Kleine-König wro

Re: [PATCH] ARC: Use clockevents_config_and_register over clockevents_register_device

2013-09-27 Thread Uwe Kleine-König
On Thu, Sep 26, 2013 at 12:01:49PM +, Vineet Gupta wrote: > On 09/25/2013 02:35 AM, Uwe Kleine-König wrote: > > clockevents_config_and_register is more clever and correct than doing it > > by hand; so use it. > > > > Signed-off-by: Uwe Kleine-König > > Acked

Re: [PATCH] ARC: Use clockevents_config_and_register over clockevents_register_device

2013-09-27 Thread Uwe Kleine-König
Hello, On Fri, Sep 27, 2013 at 08:26:58AM +, Vineet Gupta wrote: > On 09/27/2013 01:47 PM, Uwe Kleine-König wrote: > > On Thu, Sep 26, 2013 at 12:01:49PM +, Vineet Gupta wrote: > >> On 09/25/2013 02:35 AM, Uwe Kleine-König wrote: > >>> clockevents_config_a

Re: [GIT PULL] ARC fixes for 3.12

2013-09-30 Thread Uwe Kleine-König
Hello Vineet, On Mon, Sep 30, 2013 at 04:33:16AM +, Vineet Gupta wrote: > Uwe Kleine-König (1): Your mailer ist broken here, but you probably know that :-) The commit looks ok, though. Best regards Uwe Kleine-König -- Pengutronix e.K. | Uwe Kleine-Kö

Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-10-01 Thread Uwe Kleine-König
On Wed, Sep 25, 2013 at 04:33:24PM +0200, Daniel Lezcano wrote: > On 09/16/2013 11:44 AM, Uwe Kleine-König wrote: > > Signed-off-by: Uwe Kleine-König > > --- > > Hello, > > > > I'm not sure that the way I implemented if a given timer is used as > >

Re: [PATCH] clockevents: Sanitize ticks to nsec conversion

2013-09-20 Thread Uwe Kleine-König
Hi Thomas, On Fri, Sep 20, 2013 at 11:56:27AM +0200, Thomas Gleixner wrote: > On Thu, 19 Sep 2013, Uwe Kleine-König wrote: > > > + * For mult <= (1 << shift) we can safely add mult - 1 to > > > + * prevent integer rounding loss. So the backwards conversion > &g

Re: [PATCH 1/3] Add smp support for Allwinner A20(sunxi 7i).

2013-09-23 Thread Uwe Kleine-König
the prefix to PATCHv3 (you can > use the --subject-prefix option of git format-patch to do so). git >= 1.8.2 also support --reroll-count 3 which also changes the filenames of the patches. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König|

[PATCH] [RFC] devm: drop devm_clk_put

2013-09-24 Thread Uwe Kleine-König
devm_clk_put isn't really necessary as a driver usually keeps the reference during its lifetime and there are no in-tree users. So drop it. Signed-off-by: Uwe Kleine-König --- The "no in-tree users" part of the commit log isn't true yet, as there is no agreed-on patch fo

[PATCH v2] clockevents: Sanitize ticks to nsec conversion

2013-09-24 Thread Uwe Kleine-König
e u64 boundary. Signed-off-by: Thomas Gleixner Cc: Russell King - ARM Linux Cc: Marc Kleine-Budde Cc: nicolas.fe...@atmel.com Cc: Marc Pignat Cc: john.stu...@linaro.org Cc: ker...@pengutronix.de Cc: Ronald Wahl Cc: LAK Cc: Ludovic Desroches [ukl: move assignment to rnd after eventually

[PATCH] ARC: Use clockevents_config_and_register over clockevents_register_device

2013-09-24 Thread Uwe Kleine-König
clockevents_config_and_register is more clever and correct than doing it by hand; so use it. Signed-off-by: Uwe Kleine-König --- arch/arc/kernel/time.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/arc/kernel/time.c b/arch/arc/kernel/time.c index 0e51e69

Timekeeping on at91rm9200 [Was: [PATCH v2] clockevents: Sanitize ticks to nsec conversion]

2013-09-24 Thread Uwe Kleine-König
please test that? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH v2] clockevents: Sanitize ticks to nsec conversion

2013-09-24 Thread Uwe Kleine-König
Hello Thomas, just found another little issue ... On Tue, Sep 24, 2013 at 09:50:23PM +0200, Uwe Kleine-König wrote: > +/** > + * clockevents_delta2ns - Convert a latch value (device ticks) to nanoseconds > + * @latch: value to convert > + * @evt: pointer to clock event devic

Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-09-25 Thread Uwe Kleine-König
Hello Daniel, On Wed, Sep 25, 2013 at 04:33:24PM +0200, Daniel Lezcano wrote: > On 09/16/2013 11:44 AM, Uwe Kleine-König wrote: > > Signed-off-by: Uwe Kleine-König > > --- > > I'm not sure that the way I implemented if a given timer is used as > > clock_source

Re: [PATCH] serial/imx: fix IMX UART macro usage to reflect correct

2012-09-10 Thread Uwe Kleine-König
x it to use the right macros instead. Acked-by: Uwe Kleine-König Thanks Uwe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the F

Re: [PATCH] video: imxfb: Do not crash on reboot

2012-10-09 Thread Uwe Kleine-König
clk_ahb; > struct clk *clk_per; > + int enabled; I didn't really know the driver, but I wonder if the name "enabled" is a tad too generic. Maybe better "clks_enabled"? Uwe -- Pengutronix e.K. | Uwe Kleine-König

Re: [PATCH] nommu: Enable the strict alignment (CR_A) bit only if ARCH < v6

2012-12-05 Thread Uwe Kleine-König
igned > accesses to strongly-ordered memory because that results in good ol' > UNPREDICTABLE behaviour. > > I think Uwe also requires some of the stuff there for his M3 port. I didn't check more context than available in the patch and I also didn't double-check the M3-docs

Re: [PATCH] RFC: leds-pwm: don't disable pwm when setting brightness to 0

2013-01-03 Thread Uwe Kleine-König
Hi Thierry, On Thu, Jan 03, 2013 at 10:01:18AM +0100, Thierry Reding wrote: > On Thu, Oct 25, 2012 at 04:03:49PM +0800, Shawn Guo wrote: > > On Wed, Oct 24, 2012 at 03:52:46PM +0200, Uwe Kleine-König wrote: > > > This fixes disabling the LED on i.MX28. The PWM hardware dela

[PATCH v3] irqchip: Add support for ARMv7-M's NVIC

2013-04-17 Thread Uwe Kleine-König
This interrupt controller is found on Cortex-M3 and Cortex-M4 machines. Support for this controller appeared in Catalin's Cortex tree based on 2.6.33 but was nearly completely rewritten. Signed-off-by: Catalin Marinas Signed-off-by: Uwe Kleine-König --- Notes: Changes since v2, sent

Re: [PATCH v3] irqchip: Add support for ARMv7-M's NVIC

2013-04-18 Thread Uwe Kleine-König
On Wed, Apr 17, 2013 at 10:23:43PM +0200, Arnd Bergmann wrote: > On Wednesday 17 April 2013, Uwe Kleine-König wrote: > > > This patch triggers two checkpatch warnings: > > > > WARNING: Avoid CamelCase: > > WARNING: Avoid CamelCase: > > > &g

Re: [PATCHv2 2/3] ARM: Detect support for SDIV/UDIV from ISAR0 register

2013-04-18 Thread Uwe Kleine-König
return; > + > + divide_instrs = (read_cpuid_ext(CPUID_EXT_ISAR0) & 0x0f00) >> 24; The problem is that read_cpuid_ext is called which doesn't map to something useful for v7-m. So maybe add a check: if (!IS_ENABLED(CONFIG_CPU_CP15)) return;

Re: [PATCH v3] irqchip: Add support for ARMv7-M's NVIC

2013-04-18 Thread Uwe Kleine-König
On Thu, Apr 18, 2013 at 11:01:13AM +0200, Arnd Bergmann wrote: > On Thursday 18 April 2013, Uwe Kleine-König wrote: > > > > + * Each bank handles 32 irqs. Only the 16th (= last) bank handles only > > > > + * 16 irqs. > > > > + */ > > > > +#def

Re: [PATCH v3] irqchip: Add support for ARMv7-M's NVIC

2013-04-19 Thread Uwe Kleine-König
On Thu, Apr 18, 2013 at 11:38:13AM +0200, Arnd Bergmann wrote: > On Thursday 18 April 2013, Uwe Kleine-König wrote: > > That is, there are (INTLINESNUM + 1) * 32 irqs for INTLINESNUM < 15. For > > INTLINESNUM == 15 there are only 496 and not 16 * 32 == 512. That's the &g

Re: [PATCH v3] irqchip: Add support for ARMv7-M's NVIC

2013-04-19 Thread Uwe Kleine-König
On Thu, Apr 18, 2013 at 11:35:22AM +0200, Thomas Gleixner wrote: > On Wed, 17 Apr 2013, Uwe Kleine-König wrote: > > +struct nvic_bank_data { > > + /* > > +* For irq i base holds nvic_base + 4 * i / 32. So you can access the > > +* right ISER register (i.e I

Re: [PATCH v3] irqchip: Add support for ARMv7-M's NVIC

2013-04-22 Thread Uwe Kleine-König
Hello, (for the new readers of this thread: This is about using u32 mask = 1 << (d->hwirq % 32); instead of u32 mask = 1 << (d->irq - gc->irq_base); in the callbacks for the irq generic chip.) On Fri, Apr 19, 2013 at 05:09:27PM +0200, Uwe Kleine-König wr

[PATCH v4] irqchip: Add support for ARMv7-M's NVIC

2013-06-12 Thread Uwe Kleine-König
This interrupt controller is found on Cortex-M3 and Cortex-M4 machines. Support for this controller appeared in Catalin's Cortex tree based on 2.6.33 but was nearly completely rewritten. Signed-off-by: Catalin Marinas Signed-off-by: Uwe Kleine-König --- Notes: Changes since v3, sent

Re: [PATCH v4] irqchip: Add support for ARMv7-M's NVIC

2013-06-12 Thread Uwe Kleine-König
Hello, On Wed, Jun 12, 2013 at 11:50:35PM +0200, Uwe Kleine-König wrote: > This interrupt controller is found on Cortex-M3 and Cortex-M4 machines. > > Support for this controller appeared in Catalin's Cortex tree based on > 2.6.33 but was nearly completely rewritten. > >

Re: [PATCH v4] irqchip: Add support for ARMv7-M's NVIC

2013-06-16 Thread Uwe Kleine-König
On Sat, Jun 15, 2013 at 01:41:49AM +0100, Grant Likely wrote: > On Wed, 12 Jun 2013 23:50:35 +0200, Uwe Kleine-König > wrote: > > This interrupt controller is found on Cortex-M3 and Cortex-M4 machines. > > > > Support for this controller appeared in Catalin's Co

Re: [PATCH v2] arch/*/asm/include/bitops.h: api issue, find_*_bit() defination are different with each other

2013-06-05 Thread Uwe Kleine-König
t; +++ b/arch/arm/lib/findbit.S > @@ -19,7 +19,8 @@ > > /* > * Purpose : Find a 'zero' bit > - * Prototype: int find_first_zero_bit(void *addr, unsigned int maxbit); > + * Prototype: unsigned long find_first_zero_bit(const void *p, here is another one. Best regards

Re: [PATCH v2] arch/*/asm/include/bitops.h: api issue, find_*_bit() defination are different with each other

2013-06-05 Thread Uwe Kleine-König
ld you tell me how > do you find it ?) :-) I have no tool for that, it just catched my eye. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this lis

Re: [RFC] PTR_ERR: return 0 if ptr isn't an error value.

2013-06-03 Thread Uwe Kleine-König
Hello Rusty, [added akpm to Cc: who took the patch back then and Julia for the coccinelle part below] On Mon, Jun 03, 2013 at 11:59:15AM +0930, Rusty Russell wrote: > > Back in 2011, Uwe Kleine-König added the nonsensically-named > PTR_RET(), providing a means to avoid if() statement

Re: [PATCH v4] irqchip: Add support for ARMv7-M's NVIC

2013-06-25 Thread Uwe Kleine-König
Hello Thomas, hello Grant, On Wed, Jun 12, 2013 at 11:50:35PM +0200, Uwe Kleine-König wrote: > This interrupt controller is found on Cortex-M3 and Cortex-M4 machines. > > Support for this controller appeared in Catalin's Cortex tree based on > 2.6.33 but was nearly com

[PATCH v5] irqchip: Add support for ARMv7-M's NVIC

2013-06-26 Thread Uwe Kleine-König
This interrupt controller is integrated in all Cortex-M3 and Cortex-M4 machines. Support for this controller appeared in Catalin's Cortex tree based on 2.6.33 but was nearly completely rewritten. Signed-off-by: Uwe Kleine-König Acked-by: Catalin Marinas Acked-by: Arnd Bergmann Acked-by:

Re: [PATCH 0/2] some uio patches

2013-06-26 Thread Uwe Kleine-König
Hello, On Fri, Apr 26, 2013 at 12:02:27PM +0200, Uwe Kleine-König wrote: > these two patches are not really related, I only sent them in a series because > they touch the same file and fail to apply in reversed order. > > Patch 1 is useful for debugging with gdb, patch 2 is a cleanu

[PATCH] irq/generic-chip: fix a few kernel-doc entries

2013-06-12 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König --- Hello, this is a resend, because I messed up lkml's email address in the first submission. Please ignore the first mail. Thanks Uwe kernel/irq/generic-chip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/irq/ge

Re: [PATCH 0/2] some uio patches

2013-06-26 Thread Uwe Kleine-König
On Wed, Jun 26, 2013 at 07:38:57AM -0700, Greg Kroah-Hartman wrote: > On Wed, Jun 26, 2013 at 12:00:38PM +0200, Uwe Kleine-König wrote: > > Hello, > > > > On Fri, Apr 26, 2013 at 12:02:27PM +0200, Uwe Kleine-König wrote: > > > these two patches are not really related

Re: [PATCH v2] ARM: clocksource: add support for MOXA ART SoCs

2013-06-26 Thread Uwe Kleine-König
| > + TIMEREG_CR_COUNT_DOWN, timer_base + TIMER_CR); > + > + if (clocksource_mmio_init(timer_base + TIMER2_COUNT, "moxart_timer", > + clock_frequency, 200, 32, clocksource_mmio_readl_down)) > + pr_err("%s: clocksource_mmio_init failed\n&qu

Re: [PATCH v3] ARM: irqchip: add support for MOXA ART SoCs

2013-06-27 Thread Uwe Kleine-König
p_types[0].chip.irq_mask = irq_gc_mask_clr_bit; > + gc->chip_types[0].chip.irq_unmask = irq_gc_mask_set_bit; > + > + writel(0, moxart_irq_base + IRQ_MASK_REG); > + writel(0x, moxart_irq_base + IRQ_CLEAR_REG); > + > + writel(interrupt_mask, m

Re: [PATCH 1/5] imx-drm: imx-drm-core: Export imx_drm_encoder_get_mux_id

2013-06-28 Thread Uwe Kleine-König
r - remove an encoder > -- > 1.8.1.2 > > -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCH 5/5] imx-drm: ipu-dp: Adjust the maximum number of flows

2013-06-28 Thread Uwe Kleine-König
f (flow > 5) > + if (flow > IPUV3_NUM_FLOWS << 1) > return ERR_PTR(-EINVAL); > > if (flow & 1) > -- > 1.8.1.2 > > -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions

[PATCH 1/2] uio: provide vm access to UIO_MEM_PHYS maps

2013-07-16 Thread Uwe Kleine-König
This makes it possible to let gdb access mappings of the process that is being debugged. uio_mmap_logical was moved and uio_vm_ops renamed to group related code and differentiate to new stuff. Signed-off-by: Uwe Kleine-König --- drivers/uio/uio.c | 24 +++- 1 file changed

[PATCH 2/2] uio: drop unused vma_count member in uio_device struct

2013-07-16 Thread Uwe Kleine-König
vma_count is used write-only and so fails to be useful. So remove it. Signed-off-by: Uwe Kleine-König --- drivers/uio/uio.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index 159cfb3..af24bda 100644 --- a/drivers/uio/uio.c +++ b

[PATCH 0/2] Resend of two uio patches

2013-07-16 Thread Uwe Kleine-König
don't have an uio driver that uses a non-physical map. Best regards Uwe Uwe Kleine-König (2): uio: provide vm access to UIO_MEM_PHYS maps uio: drop unused vma_count m

configurable partial slab support on UP

2013-07-16 Thread Uwe Kleine-König
SMP and treat the !SMP case as CONFIG_SLUB_CPU_PARTIAL=n. This was introduced in commit 345c905 (slub: Make cpu partial slab support configurable) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions

[PATCH] extable: Skip sorting if the table is empty

2013-07-17 Thread Uwe Kleine-König
At least on ARM no-MMU the extable is empty and so there is nothing to sort. So add a check for the table to be empty which effectively only changes that the misleading pr_notice is suppressed. Signed-off-by: Uwe Kleine-König --- Hello, I first tried to select BUILDTIME_EXTABLE_SORT for ARM no

[PATCH] slub: don't use cpu partial pages on UP

2013-07-17 Thread Uwe Kleine-König
cpu partial pages are used to avoid contention which does not exist in the UP case. So let SLUB_CPU_PARTIAL depend on SMP. Signed-off-by: Uwe Kleine-König --- init/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/Kconfig b/init/Kconfig index 247084b..63c67de

Re: [PATCH 1/2] uio: provide vm access to UIO_MEM_PHYS maps

2013-07-27 Thread Uwe Kleine-König
On Fri, Jul 26, 2013 at 05:58:10PM -0700, Greg Kroah-Hartman wrote: > On Tue, Jul 16, 2013 at 07:21:03PM +0200, Uwe Kleine-König wrote: > > This makes it possible to let gdb access mappings of the process that is > > being debugged. > > > > uio_mmap_logical was move

[PATCH v2 1/2] uio: provide vm access to UIO_MEM_PHYS maps

2013-07-27 Thread Uwe Kleine-König
This makes it possible to let gdb access mappings of the process that is being debugged. uio_mmap_logical was moved and uio_vm_ops renamed to group related code and differentiate to new stuff. Signed-off-by: Uwe Kleine-König --- Changes since v1: - only use generic_access_phys ifdef

[PATCH v2 2/2] uio: drop unused vma_count member in uio_device struct

2013-07-27 Thread Uwe Kleine-König
vma_count is used write-only and so fails to be useful. So remove it. Signed-off-by: Uwe Kleine-König --- changes since v1: - adapt to changes in patch 1 drivers/uio/uio.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index

Re: [PATCH v2 1/2] uio: provide vm access to UIO_MEM_PHYS maps

2013-07-30 Thread Uwe Kleine-König
[expanding Cc: to also include akpm and linux-mm] Hello, On Mon, Jul 29, 2013 at 01:09:14PM -0700, Greg Kroah-Hartman wrote: > On Sun, Jul 28, 2013 at 12:09:37AM +0200, Uwe Kleine-König wrote: > > This makes it possible to let gdb access mappings of the process that is > >

Re: [PATCH v2 1/2] uio: provide vm access to UIO_MEM_PHYS maps

2013-07-30 Thread Uwe Kleine-König
Hello Greg, On Tue, Jul 30, 2013 at 06:49:50AM -0700, Greg Kroah-Hartman wrote: > On Tue, Jul 30, 2013 at 09:52:39AM +0200, Uwe Kleine-König wrote: > > [expanding Cc: to also include akpm and linux-mm] > > > > Hello, > > > > On Mon, Jul 29, 2013 at 01:09:14P

Re: [PATCH 2/2] chipidea: Use devm_request_irq()

2013-07-31 Thread Uwe Kleine-König
[Expanded Cc: a bit] Hello, On Wed, Jul 31, 2013 at 10:05:12AM +0100, Mark Brown wrote: > On Wed, Jul 31, 2013 at 10:46:45AM +0200, Uwe Kleine-König wrote: We're discussing about devm_request_irq and wonder what happens at remove time when the irq is still active. > > OK, s

Re: [PATCH 2/2] chipidea: Use devm_request_irq()

2013-07-31 Thread Uwe Kleine-König
On Wed, Jul 31, 2013 at 05:54:11AM -0400, Tejun Heo wrote: > Hello, > > On Wed, Jul 31, 2013 at 11:44:34AM +0200, Uwe Kleine-König wrote: > > > > OK, so the possible problem is that remove is called while the irq is > > > > still active. That means you have to

Re: Build breakage due to latest ARM fixes

2013-08-04 Thread Uwe Kleine-König
er than that I didn't notice any no-mmu problems. Also Jonathan Austin does some no-MMU work. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list

[PATCH v3 3/3] uio: drop unused vma_count member in uio_device struct

2013-08-07 Thread Uwe Kleine-König
vma_count is used write-only and so fails to be useful. So remove it. Signed-off-by: Uwe Kleine-König --- drivers/uio/uio.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index c4279b2..8abe78c 100644 --- a/drivers/uio/uio.c +++ b

[PATCH v3 1/3] mm: make generic_access_phys available for modules

2013-08-07 Thread Uwe Kleine-König
In the next commit this function will be used in the uio subsystem Signed-off-by: Uwe Kleine-König --- Hello, Greg suggested to take this patch together with the next one via his uio tree with the appropriate acks. Best regards Uwe mm/memory.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v3 2/3] uio: provide vm access to UIO_MEM_PHYS maps

2013-08-07 Thread Uwe Kleine-König
This makes it possible to let gdb access mappings of the process that is being debugged. uio_mmap_logical was moved and uio_vm_ops renamed to group related code and differentiate to new stuff. Signed-off-by: Uwe Kleine-König --- drivers/uio/uio.c | 26 +- 1 file changed

Re: PREEMPT_RT vs bcache

2013-08-07 Thread Uwe Kleine-König
wner] #endif So Ben's question was how (if at all) we should implement {down,up}_read_non_owner for PREEMPT_RT_FULL. Is it save to just use the vanilla implementation on RT? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial

Re: [PATCH] extable: Skip sorting if the table is empty

2013-08-08 Thread Uwe Kleine-König
Hello, [adding akpm to Cc:] On Wed, Jul 17, 2013 at 09:55:11AM +0200, Uwe Kleine-König wrote: > At least on ARM no-MMU the extable is empty and so there is nothing to > sort. So add a check for the table to be empty which effectively only > changes that the misleading pr_notice is s

Re: [PATCH 1/1] arm: remove extra semicolon in if statement

2013-03-01 Thread Uwe Kleine-König
up(event) != 0) > return -EINVAL; > } > > -- > 1.7.9.5 > > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >

Re: [RFC patch 0/8] genirq: Support for irq domains in generic irq chip

2013-05-06 Thread Uwe Kleine-König
le work and merging different approaches. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: How does commit 47ec340c not introduce a bug?

2013-05-07 Thread Uwe Kleine-König
*pdev) > ret = max8925_set_bits(chip->i2c, data->reg_mode_cntl, 0xfe, value); > if (ret < 0) > goto out_brt; > - > backlight_update_status(bl); > return 0; > out_brt: > > ___

  1   2   3   4   5   6   7   8   9   10   >