Re: [PATCH 32/32] pwm: atmel: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:06:10AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 14/32] pwm: meson: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:52AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 25/32] pwm: brcmstb: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:06:03AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 15/32] pwm: rockchip: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:53AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 02/32] pwm: fsl-ftm: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:40AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 03/32] pwm: rcar: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:41AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 05/32] pwm: ep93xx: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:43AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 07/32] pwm: mediatek: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:45AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 06/32] pwm: tegra: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:44AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 11/32] pwm: spear: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:49AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 08/32] pwm: sti: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:46AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 10/32] pwm: zx: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:48AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 20/32] pwm: imx: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:58AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 18/32] pwm: tiehrpwm: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:56AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 16/32] pwm: bcm-iproc: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:54AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 17/32] pwm: samsung: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:55AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 12/32] pwm: bcm-kona: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:50AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 13/32] pwm: lpc32xx: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:51AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 09/32] pwm: pxa: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:47AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 19/32] pwm: puv3: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:57AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 21/32] pwm: tiecap: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:05:59AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 22/32] pwm: bcm2835: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:06:00AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 23/32] pwm: berlin: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:06:01AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 27/32] pwm: clps711x: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:06:05AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 28/32] pwm: img: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:06:06AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 31/32] pwm: sifive: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:06:09AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 24/32] pwm: vt8500: convert to devm_platform_ioremap_resource

On Sun, Dec 29, 2019 at 08:06:02AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 29/32] pwm: lpc18xx-sct: convert to devm_platform_ioremap_resource

Hello, On Sun, Dec 29, 2019 at 08:06:07AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industr

Re: [PATCH 04/32] pwm: renesas-tpu: convert to devm_platform_ioremap_resource

On Sun, Dec 29, 2019 at 08:05:42AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux

Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource

On Sun, Dec 29, 2019 at 08:05:39AM +, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Uwe Kleine-König -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux

Re: [PATCH v13 11/11] pwm: core: Convert period and duty cycle to u64

robot > Signed-off-by: Guru Das Srinagesh I like this change in general. I didn't check all the prepatory patches in detail but the few I glanced over looked ok. I think we have to prepare for having to fix a few fallouts but consider it ok to expose this in next (but wouldn't send

Re: [PATCH v1 2/2] Add PWM driver for LGM

Hello Andy, On Fri, May 22, 2020 at 12:18:24PM +0300, Andy Shevchenko wrote: > On Fri, May 22, 2020 at 10:56:13AM +0200, Uwe Kleine-König wrote: > > On Fri, May 22, 2020 at 03:41:59PM +0800, Rahul Tanwar wrote: > > > > + io_base = devm_platform_ioremap_resource(pdev, 0

Re: [PATCH v1 2/2] Add PWM driver for LGM

dev_err(dev, "failed to get clock: %d\n", ret); > + return ret; > + } > + > + pc->rst = devm_reset_control_get(dev, NULL); > + if (IS_ERR(pc->rst)) { > + ret = PTR_ERR(pc->rst); > + dev_err(dev, "failed to get reset con

Re: Failure to shutdown/reboot with intel_iommu=on

Hello again, On Mon, May 11, 2020 at 09:59:31PM +0200, Uwe Kleine-König wrote: > On 5/9/20 3:58 AM, Lu Baolu wrote: > > Hi Uwe, > > > > Have you tried commenting out intel_disable_iommus() in > > intel_iommu_shutdowan()? > > > > diff --git a/drivers/io

Re: Failure to shutdown/reboot with intel_iommu=on

On 5/9/20 3:58 AM, Lu Baolu wrote: > Hi Uwe, > > Have you tried commenting out intel_disable_iommus() in > intel_iommu_shutdowan()? > > diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c > index 0182cff2c7ac..532e62600f95 100644 > --- a/drivers/iommu/intel-iommu.c > +++ b/driv

Re: Failure to shutdown/reboot with intel_iommu=on

Hello Lenny, On 5/11/20 3:43 PM, Lenny Szubowicz wrote: > I suspect that you have TPM 2.x functionality enabled in the BIOS/firmware. Indeed. > Unless you are actually using the TPM, try setting it to TPM 1.2 mode. > I've seen an incompatiblity on other Lenovo laptops between using the > IOMMU,

Re: [PATCH] tty: serial: imx: Add return value check for platform_get_irq()

platform_get_irq() is bogus. But if we decide this construct is good enough, the error reporting needs some love as currently it emits two error messages which is confusing. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | https://www.pengutronix.de/ |

Failure to shutdown/reboot with intel_iommu=on

Hello, On my Lenovo T460p I cannot shutdown and reboot when the iommu is enabled. This is using linux 5.2.7 as provided by Debian, 5.6.4 has the same problem. Suspend/resume also fails; I suspect this is the same issue. When requesting power off the kernel messages just end with: sd 0:0:

Re: [PATCH V2] pwm: tegra: dynamic clk freq configuration by PWM driver

WM_SCALE_SHIFT; > + val |= pfm << PWM_SCALE_SHIFT; > > /* >* If the PWM channel is disabled, make sure to turn on the clock > @@ -205,6 +278,10 @@ static int tegra_pwm_probe(struct platform_device *pdev) >*/ > pwm->clk_rate = clk_get_rate(pwm->clk); > > + /* Set minimum limit of PWM period for the IP */ > + pwm->min_period_ns = > + (NSEC_PER_SEC / (pwm->soc->max_frequency >> PWM_DUTY_WIDTH)) + 1; With my suggestion above, you can drop the min_period_ns field. > + > pwm->rst = devm_reset_control_get_exclusive(&pdev->dev, "pwm"); > if (IS_ERR(pwm->rst)) { > ret = PTR_ERR(pwm->rst); > @@ -313,4 +390,5 @@ module_platform_driver(tegra_pwm_driver); > > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("NVIDIA Corporation"); > +MODULE_AUTHOR("Sandipan Patra "); > MODULE_ALIAS("platform:tegra-pwm"); Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | https://www.pengutronix.de/ |

Re: [PATCH] docs: dt: fix broken links due to txt->yaml renames

h would broke a link I would > have it fixed before it hits any tree. What about adding a check to check_patch? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | https://www.pengutronix.de/ |

Re: [PATCH v6] gpio: pca953x: Add Maxim MAX7313 PWM support

must then be active when the pin is changed to PWM mode. (And vice versa: The GPIO setting must not influence the PWM output ...) I didn't check the hardware manual (or the patch), but if this needs caching of pwm and gpio parameters I would take that as a strong hint that the abstraction is wr

Re: [RESEND PATCH V11 3/3] Input: new da7280 haptic driver

+{ > + struct da7280_haptic *haptics = dev_get_drvdata(dev); > + int error; > +

Re: [PATCH v2] pwm: sun4i: direct clock output support for Allwinner A64

On Tue, Apr 28, 2020 at 06:41:50PM +0200, Peter Vasil wrote: > Allwinner A64 is capable of a direct clock output on PWM (see A64 > User Manual chapter 3.10). Add support for this in the sun4i PWM > driver. > > Signed-off-by: Peter Vasil LGTM Acked-by: Uwe Kleine-König B

Re: [PATCH 11/36] ARM: s5pv210: split from plat-samsung

think. fine for me. The background of my question was me wondering if builds for PLAT_S3C24XX=y (before your patch series) don't need plat-samsung. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: pwm_bl on i.MX6Q broken on 5.4-RC1+

uot; here on this list. In this thread the problem is analysed and it's a bit different than for sun4i. I assume we don't need to follow up on this report given the discussion is already ongoing elsewhere. Best regards Uwe -- Pengutronix e.K. | Uwe

Re: [PATCH] pwm: cros-ec: Let cros_ec_pwm_get_state() return the last applied state

00011bc98c8 x18: 0003 > [ 10.287150] x17: 0007 x16: 000e > [ 10.293088] x15: 00000001 x14: 0019 > [ 10.299024] x13: 0033 x12: 0018 > [ 10.304962] x11: 071c71c71c71c71c x10: 09d0 > [ 10.310379] atmel_mxt_ts 5-004a: Family: 164 Variant: 17 Firmware V2.0.AA > Objects: 31 > [ 10.310901] x9 : 800012433490 x8 : edb81830 > [ 10.310905] x7 : 011b x6 : 0001 > [ 10.310908] x5 : x4 : > [ 10.310911] x3 : edb80e00 x2 : 0002 > [ 10.310914] x1 : x0 : > [ 10.310918] Call trace: > [ 10.310931] cros_ec_pwm_get_state+0xcc/0xf8 [pwm_cros_ec] > [ 10.310944] pwmchip_add_with_polarity+0x134/0x290 The problem is that .get_state is called from the core without requesting the pwm and so .request wasn't called before. I still think it's wrong to cache the duty-cycle in the driver, but if you still want to do it, .duty_cycle must go into the driver struct which however is very inefficient given that probably most of the machines don't actually have 255 PWMs. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH 1/1] pwm: Convert period and duty cycle to u64

; may be set. > > Signed-off-by: Guru Das Srinagesh Acked-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH] pwm: sun4i: Fix incorrect calculation of duty_cycle/period

od depending on how the registers are set would be helpful to understand the implemented algorithm. - If there is a publically available datasheet adding a link to it in the header of the driver would be great. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH v4 1/1] printf: add support for printing symbolic error names

; | xargs grep -E 'define\s*E' > > In the cases where some common aliasing exists > (e.g. EAGAIN=EWOULDBLOCK on all platforms, EDEADLOCK=EDEADLK on most), > I've moved the more popular one (in terms of 'git grep -w Efoo | wc) > to the bottom so that one takes prec

Re: [for-linus][PATCH 08/11] recordmcount: Fix nop_mcount() function

the build if ftrace > function tracing was enabled. > > Link: http://lkml.kernel.org/r/20191009110538.5909f...@gandalf.local.home > > Reported-by: Uwe Kleine-önig > Tested-by: Uwe Kleine-König And now it seems to have problems with plain ASCII-K,

Re: [RESEND PATCH] ARM/hw_breakpoint: add ARMv8.1/ARMv8.2 debug architecutre versions support in enable_monitor_mode()

Hello, just noticed a typo in the subject line while going through my lakml mailbox: s/architecutre/architecture/ Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH 11/36] ARM: s5pv210: split from plat-samsung

)? Hmm, it seems there is no plat-y for PLAT_S3C24XX=y builds. Is this intended? If yes, the directory name containing "samsung" suggests something that seems untrue. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH v4 4/8] recordmcount: Rewrite error/success handling

On Thu, Oct 10, 2019 at 12:23:21PM -0400, Steven Rostedt wrote: > On Wed, 9 Oct 2019 17:22:18 +0200 > Uwe Kleine-König wrote: > > > > diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h > > > index 3796eb37fb12..6dbec46b7703 100644 > > > --- a/script

Re: [PATCH] pwm: stm32: add comment to better describe breakinput feature

On Wed, Oct 09, 2019 at 11:51:05AM +0200, Fabrice Gasnier wrote: > On 10/8/19 4:45 PM, Uwe Kleine-König wrote: > > On Tue, Oct 08, 2019 at 01:41:27PM +0200, Fabrice Gasnier wrote: > >> Add a comment to better describe the purpose of breakinput feature that > >> can b

Re: [PATCH v4 4/8] recordmcount: Rewrite error/success handling

On Wed, Oct 09, 2019 at 11:05:38AM -0400, Steven Rostedt wrote: > On Wed, 9 Oct 2019 12:46:26 +0200 > Uwe Kleine-König wrote: > > > > uwe@taurus:~/arietta/kbuild$ ./scripts/recordmcount > > "arch/arm/crypto/aes-cipher-glue.o" > > arch/arm/crypto/aes-c

Re: [PATCH] pwm: cros-ec: Let cros_ec_pwm_get_state() return the last applied state

On Wed, Oct 09, 2019 at 03:47:43PM +0200, Enric Balletbo i Serra wrote: > Hi Uwe, Daniel, > > On 9/10/19 13:35, Daniel Thompson wrote: > > On Wed, Oct 09, 2019 at 01:21:26PM +0200, Uwe Kleine-König wrote: > >> On Wed, Oct 09, 2019 at 11:42:36AM +0100, Daniel Thompson wro

Re: [PATCH] pwm: cros-ec: Let cros_ec_pwm_get_state() return the last applied state

On Wed, Oct 09, 2019 at 11:42:36AM +0100, Daniel Thompson wrote: > On Wed, Oct 09, 2019 at 12:16:37PM +0200, Uwe Kleine-König wrote: > > On Wed, Oct 09, 2019 at 10:56:35AM +0100, Daniel Thompson wrote: > > > On Wed, Oct 09, 2019 at 11:27:13AM +0200, Enric Balletbo i Serra wro

Re: [PATCH v4 4/8] recordmcount: Rewrite error/success handling

her-glue.o: failed I didn't debug this further, if you have problems reproducing or need more infos tell me. The defconfig I'm using is attached. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions

Re: [PATCH] pwm: cros-ec: Let cros_ec_pwm_get_state() return the last applied state

On Wed, Oct 09, 2019 at 10:56:35AM +0100, Daniel Thompson wrote: > On Wed, Oct 09, 2019 at 11:27:13AM +0200, Enric Balletbo i Serra wrote: > > Hi Uwe, > > > > Adding Daniel and Lee to the discussion ... > > Thanks! > > > On 8/10/19 22:31, Uwe Kleine-König wro

[PATCH] driver core: simplify definitions of platform_get_irq*

: Uwe Kleine-König --- drivers/base/platform.c | 47 ++--- 1 file changed, 21 insertions(+), 26 deletions(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index b6c6c7d97d5b..60ff536b46f1 100644 --- a/drivers/base/platform.c +++ b/drivers

Re: [PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

On Wed, Oct 09, 2019 at 11:12:20AM +0300, Andy Shevchenko wrote: > On Wed, Oct 9, 2019 at 9:53 AM Uwe Kleine-König > wrote: > > > The patch is fine given the changed behaviour of platform_get_irq. I > > wonder if it is sensible to introduce a variant of

Re: [PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

? Having a patch (or a set of patches) is probably helpful to get forward here, yes. You have my blessing to create a suggestion. (Not that you actually need that :-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

vailable irqs first. > > Agreed, it would be nice if we can fix this from the API level, this > is to save many patches from various drivers side, let me know if > agreement is reached and I will do the patch. I wouldn't expect that most callers actually want an error message and so these need a different patch (i.e. dropping the error message by the caller). This type of patch is fine and the normal load when something is consolidated. Which other drivers do you have on your radar that don't want an error message if platform_get_irq() fails? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

just call platform_get_irq_nowarn without having to check the number of available irqs first. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH] pwm: cros-ec: Let cros_ec_pwm_get_state() return the last applied state

On Tue, Oct 08, 2019 at 06:33:15PM +0200, Enric Balletbo i Serra wrote: > Hi Uwe, > > Thanks for the quick reply. > > On 8/10/19 16:34, Uwe Kleine-König wrote: > > Hello Enric, > > > > On Tue, Oct 08, 2019 at 12:54:17PM +0200, Enric Balletbo i Serra wrote: >

Re: [PATCH] pwm: stm32: add comment to better describe breakinput feature

x27;t exist. > + * failed if it doesn't exist. The pinctrl handle must hold the BRK > + * pin(s) when using "st,breakinput" property. Is this a comment that has a better place in the binding doc? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH] pwm: cros-ec: Let cros_ec_pwm_get_state() return the last applied state

s unreliable and cache that for callers? Unrelated to the patch in question I noticed that the cros-ec-pwm driver doesn't handle polarity. We need state->polarity = PWM_POLARITY_NORMAL; in cros_ec_pwm_get_state() and if (state->polarity != PWM_POL

Re: [PATCH] pwm: Fix kerneldoc for apply operation

23d1812ac ("pwm: Ensure pwm_apply_state() doesn't modify the state > argument") > Signed-off-by: Bjorn Andersson This is a duplicate of https://patchwork.ozlabs.org/patch/1171851/. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

turn NULL? From a quick look, it cannot. rule of thumb: IS_ERR_OR_NULL is wrong as it is a sign of poor return value semantics. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [Linux-stm32] [PATCH] pwm: stm32: Fix the usage of uninitialized variable in stm32_pwm_config()

Hello, Cc += Mark Brown who maintains regmap On Fri, Oct 04, 2019 at 09:09:51AM +, Benjamin GAIGNARD wrote: > > On 10/4/19 8:23 AM, Uwe Kleine-König wrote: > > Hello, > > > > On Thu, Oct 03, 2019 at 09:46:49PM -0700, Yizhuo wrote: > >> Inside function stm32

Re: [PATCH v2 4/6] dt-bindings: pwm: mxs-pwm: Increase #pwm-cells

On Fri, Oct 04, 2019 at 03:32:05PM +0200, Rasmus Villemoes wrote: > We need to increase the pwm-cells for the optional flags parameter, in > order to implement support for polarity setting via DT. > > Acked-by: Rob Herring Acked-by: Uwe Kleine-König Thanks Uwe -- Pen

Re: [PATCH v2 3/6] pwm: mxs: add support for inverse polarity

;hwpwm * 0x20); > - writel(PERIOD_PERIOD(period_cycles) | PERIOD_POLARITY_NORMAL | > PERIOD_CDIV(div), > + writel(PERIOD_PERIOD(period_cycles) | pol_bits | PERIOD_CDIV(div), > mxs->base + PWM_PERIOD0 + pwm->hwpwm * 0x20); Is the avoidance of glitches still

Re: [PATCH v2 2/6] pwm: mxs: remove legacy methods

On Fri, Oct 04, 2019 at 03:32:03PM +0200, Rasmus Villemoes wrote: > Since we now have ->apply, these are no longer relevant. > > Signed-off-by: Rasmus Villemoes nice and easy, Reviewed-by: Uwe Kleine-König Best regards Uwe -- Pengutronix e.K. | Uwe

Re: [PATCH v2 1/6] pwm: mxs: implement ->apply

it would be beneficial to stop the calculation of register contents if !state->enabled here. The only drawback (I'm aware) is that pwm_get_state won't return the previously set .period and .duty_cycle. (I also wonder if we should return (e.g.) .duty = 0, .period = 1 in pw

Re: [PATCH v2 6/6] pwm: update comment on struct pwm_ops::apply

config. The state argument > - * should be adjusted with the real hardware config (if the > - * approximate the period or duty_cycle value, state should > - * reflect it) > + * @apply: atomically apply a new PWM config Reviewed-by: Uwe Kleine-König

Re: [PATCH v2 5/6] pwm: mxs: avoid a division in mxs_pwm_apply()

cdiv[PERIOD_CDIV_MAX] = { > - 1, 2, 4, 8, 16, 64, 256, 1024 > +static const u8 cdiv_shift[PERIOD_CDIV_MAX] = { > + 0, 1, 2, 3, 4, 6, 8, 10 One small nitpick: I would like to see this name have a mxs_pwm_ prefix. But even without this change: Reviewed-by: Uwe Kleine-Kön

Re: [PATCH] pwm: stm32: Fix the usage of uninitialized variable in stm32_pwm_config()

ould have their return values checked. While a patch to fix these all is not trivial it is certainly possible and I would prefer to fix the problem completely. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH] pwm: sun4i: redundant assignment to variable pval

second for loop. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH] pwm: pwm-imx27: Use 'dev' instead of dereferencing it repeatedly

shorten any lines enough to remove line-wrap > and using &pdev->dev is really one less variable to mentally track > when reading the code. On the other hand having a variable named "dev" is so usual that I personally slightly prefer using it instead of &pdev->dev. So I think (given there is no effect on the compiled result) this is really just about personal taste and so to actually switch from one preference to the other needs a better justification IMHO. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH 2/2] pwm: stm32: add power management support

Hello Fabrice, On Tue, Oct 01, 2019 at 10:18:31AM +0200, Fabrice Gasnier wrote: > On 10/1/19 9:04 AM, Uwe Kleine-König wrote: > > On Mon, Sep 30, 2019 at 05:39:11PM +0200, Fabrice Gasnier wrote: > >> Add suspend/resume PM sleep ops. When going to low power, enforce the PWM

Re: [PATCH 2/2] pwm: stm32: add power management support

ret; > > @@ -647,6 +656,38 @@ static int stm32_pwm_remove(struct platform_device *pdev) > return 0; > } > > +static int __maybe_unused stm32_pwm_suspend(struct device *dev) > +{ > + struct stm32_pwm *priv = dev_get_drvdata(dev); > + struct pwm_state state;

Re: [PATCH v9 03/11] pwm: mediatek: remove a property "has-clks"

982af47ffe36df3e31bc9e11be5a067ddd18. Thierry, any chance to repair that? Something like git filter-branch --msg-filter 'sed "s/Kleine-Kö /Kleine-König /"' linus/master.. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König

Re: [PATCH] clk: at91: avoid sleeping early

nd dump stack on the AriettaG25: >bad: scheduling from the idle thread! > > Ensure it is possible to sleep, else simply have a delay. > > Reported-by: Uwe Kleine-König > Signed-off-by: Alexandre Belloni Tested-by: Uwe Kleine-König See below for a comment. > Note that this w

Re: [PATCH 1/2] pwm: Add different PWM output types support

for generating the pattern are performed > in the driver only if the output type is read as "pattern" and not otherwise. Up to now I'm not convinced that this extension is a good one that can be supported by several PWM implementations. I'd say we should collect first some details about different implementations and what these could implement to get a picture what kind of API is sensible. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH 1/4] pwm: mxs: implement ->apply

Hello, [expanded the recipents to include RMK and the clk list] On Mon, Sep 23, 2019 at 11:04:39AM +0200, Rasmus Villemoes wrote: > On 23/09/2019 10.24, Uwe Kleine-König wrote: > > Also there is a bug already in .config: You are not supposed to call > > clk_get_rate if the c

Re: [PATCH 3/4] pwm: mxs: add support for inverse polarity

On Mon, Sep 23, 2019 at 10:45:56AM +0200, Rasmus Villemoes wrote: > On 23/09/2019 10.27, Uwe Kleine-König wrote: > > On Mon, Sep 23, 2019 at 10:13:47AM +0200, Rasmus Villemoes wrote: > >> > >> > >> + pol_bits = state->polarity == PWM_POLARITY_NORMAL ?

Re: [PATCH 3/4] pwm: mxs: add support for inverse polarity

CDIV(div), > + writel(PERIOD_PERIOD(period_cycles) | pol_bits | PERIOD_CDIV(div), When will this affect the output? Only on the next start of a period, or immediatly? Can it happen that this results in a mixed output (i.e. a period that has already the new duty cycle from the line above but not the new polarity (or period)? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH 1/4] pwm: mxs: implement ->apply

clk_disable_unprepare(mxs->clk); > + } > + return 0; > +} Maybe it would be easier to review when converting from .config + .enable + .disable to .apply in a single step. (Note this "maybe" is honest, I'm not entirely sure.) There is a bug: If the PWM

Re: [PATCH] dimlib: make DIMLIB a hidden symbol

Hello Jakub, On 9/22/19 5:06 AM, Jakub Kicinski wrote: > On Fri, 20 Sep 2019 15:31:15 +0200, Uwe Kleine-König wrote: >> According to Tal Gilboa the only benefit from DIM comes from a driver >> that uses it. So it doesn't make sense to make this symbol user visible, >> in

Re: [PATCH] dimlib: make DIMLIB a hidden symbol

Hello, On 9/20/19 7:02 PM, Tal Gilboa wrote: > On 9/20/2019 4:31 PM, Uwe Kleine-König wrote: >> diff --git a/lib/Kconfig b/lib/Kconfig >> index cc04124ed8f7..9fe8a21fd183 100644 >> --- a/lib/Kconfig >> +++ b/lib/Kconfig >> @@ -555,8 +555,7 @@ config SIGNATURE

[PATCH] dimlib: make DIMLIB a hidden symbol

According to Tal Gilboa the only benefit from DIM comes from a driver that uses it. So it doesn't make sense to make this symbol user visible, instead all drivers that use it should select it (as is already the case AFAICT). Signed-off-by: Uwe Kleine-König --- lib/Kconfig | 3 +-- 1

dimlib: should it really be enabled by default? [Was: [PATCH] trivial: lib/Kconfig: typo modertion -> moderation]

On 9/19/19 11:03 PM, Uwe Kleine-König wrote: > Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files") > Signed-off-by: Uwe Kleine-König > --- > lib/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/Kconfig b/l

[PATCH] trivial: lib/Kconfig: typo modertion -> moderation

Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files") Signed-off-by: Uwe Kleine-König --- lib/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Kconfig b/lib/Kconfig index 4e6b1c3e4c98..cc04124ed8f7 100644 --- a/lib/Kconfig +++ b/lib/Kconfig

Re: [PATCH v2] serial: imx: adapt rx buffer and dma periods

On Thu, Sep 19, 2019 at 01:40:03PM +0200, Philipp Puschmann wrote: > Hi Uwe > > Am 19.09.19 um 13:22 schrieb Uwe Kleine-König: > > On Thu, Sep 19, 2019 at 12:26:28PM +0200, Philipp Puschmann wrote: > >> Using only 4 DMA periods for UART RX is very few if we have a high

Re: [PATCH v2] serial: imx: adapt rx buffer and dma periods

e have an influence if I do fewer but bigger transfers? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH v2] pwm: atmel: Remove platform_device_id and use only dt bindings

On Wed, Sep 18, 2019 at 04:57:16PM +0200, Kamel Bouhara wrote: > Since commit 26202873bb51 ("avr32: remove support for AVR32 > architecture") there is no more user of platform_device_id and we > should only use dt bindings > > Signed-off-by: Kamel Bouhara Acked-by: Uwe

Re: [PATCH v8 03/11] pwm: mediatek: remove a property "has-clks"

n remove has-clock property, and directly > use devm_clk_get and clk_get_rate. > > Signed-off-by: Ryder Lee > Signed-off-by: Sam Shih Acked-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solution

Re: [PATCH v2] of: restore old handling of cells_name=NULL in of_*_phandle_with_args()

On Wed, Sep 18, 2019 at 10:19:54PM +0200, Uwe Kleine-König wrote: > On Wed, Sep 18, 2019 at 03:09:06PM -0500, Rob Herring wrote: > > Can I get a proper patch please. > > I don't understand what is wrong with my patch. Can you please expand > what you are missing? I just tri

Re: [PATCH v2] of: restore old handling of cells_name=NULL in of_*_phandle_with_args()

On Wed, Sep 18, 2019 at 03:09:06PM -0500, Rob Herring wrote: > On Wed, Sep 18, 2019 at 3:47 AM Uwe Kleine-König > wrote: > > > > Before commit e42ee61017f5 ("of: Let of_for_each_phandle fallback to > > non-negative cell_count") the iterator functions calling >

Re: [PATCH v2] pwm: stm32-lp: add check in case requested period cannot be achieved

Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

<    1   2   3   4   5   6   7   8   9   10   >