On Wed, Oct 8, 2014 at 3:39 PM, Michal Marek mma...@suse.cz wrote:
On 2014-10-04 11:29, Valentin Rothberg wrote:
On Wed, Oct 1, 2014 at 4:58 PM, Michal Marek mma...@suse.cz wrote:
On 2014-09-29 19:05, Valentin Rothberg wrote:
The scripts/checkkconfigsymbols.sh script searches Kconfig features
On Wed, Oct 1, 2014 at 4:58 PM, Michal Marek mma...@suse.cz wrote:
On 2014-09-29 19:05, Valentin Rothberg wrote:
The scripts/checkkconfigsymbols.sh script searches Kconfig features
in the source code that are not defined in Kconfig. Such identifiers
always evaluate to false and are the source
/* CONFIG_MPC52xx */´´).
These references can be misleading and should be removed or replaced.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
Signed-off-by: Stefan Hengelein stefan.hengel...@fau.de
---
scripts/checkkconfigsymbols.py | 134
/* CONFIG_MPC52xx */´´).
These references can be misleading and should be removed or replaced.
Changelog:
v2: Fix of regural expressions
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
Signed-off-by: Stefan Hengelein stefan.hengel...@fau.de
---
scripts/checkkconfigsymbols.py | 134
/* CONFIG_MPC52xx */´´).
These references can be misleading and should be removed or replaced.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
Signed-off-by: Stefan Hengelein stefan.hengel...@fau.de
---
Changelog:
v2: Fix of regural expressions
v3: Changelog replacement, and add changes of v2
On dim., 2014-09-21 at 23:28 +0200, Paul Bolle wrote:
Valentin Rothberg schreef op zo 21-09-2014 om 21:53 [+0200]:
The scripts/checkkconfigsymbols.sh script searches Kconfig features
in the source code that are not defined in Kconfig. Such identifiers
always evaluate to false
On lun., 2014-09-22 at 10:24 +0200, Paul Bolle wrote:
Hi Valentin,
On Mon, 2014-09-22 at 09:43 +0200, Valentin Rothberg wrote:
On dim., 2014-09-21 at 23:28 +0200, Paul Bolle wrote:
Valentin Rothberg schreef op zo 21-09-2014 om 21:53 [+0200]:
Furthermore, it generates false positives
tab file list) as it simplifies the detection of the Kconfig
feature for long file lists.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
Signed-off-by: Stefan Hengelein stefan.hengel...@fau.de
---
Changelog:
v2: Fix of regular expressions
v3: Changelog replacement, and add changes
still expresses the test of a LKM.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
lib/Kconfig.debug | 2 +-
lib/Makefile | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 07c2832..db91c97 100644
--- a/lib
linux-next (and mainline) release.
Very cool.
(I think Valentin Rothberg is trying to automate this properly. See
http://www.linuxplumbersconf.org/2014/ocw/sessions/1863 .)
Have either of you guys thought about asking for this to be included
with the 0-day kbuild bot or submitted under scripts
tab feature) to
(feature tab file list) as it simplifies the detection of the Kconfig
feature for long file lists.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
Signed-off-by: Stefan Hengelein stefan.hengel...@fau.de
---
Changelog:
v2: Fix of regular expressions
v3: Changelog
tab feature) to
(feature tab file list) as it simplifies the detection of the Kconfig
feature for long file lists.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
Signed-off-by: Stefan Hengelein stefan.hengel...@fau.de
---
Changelog:
v2: Fix of regular expressions
v3: Changelog
from (file list tab feature) to
(feature tab file list) as it simplifies the detection of the Kconfig
feature for long file lists.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
Signed-off-by: Stefan Hengelein stefan.hengel...@fau.de
---
Changelog:
v2: Fix of regular expressions
v3
On Mon, Sep 29, 2014 at 12:28 PM, Paul Bolle pebo...@tiscali.nl wrote:
[Added linux-kbu...@vger.kernel.org.]
On Sun, 2014-09-28 at 17:55 +0200, Valentin Rothberg wrote:
The scripts/checkkconfigsymbols.sh script searches Kconfig features
in the source code that are not defined in Kconfig
from (file list tab feature) to
(feature tab file list) as it simplifies the detection of the Kconfig
feature for long file lists.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
Signed-off-by: Stefan Hengelein stefan.hengel...@fau.de
Acked-by: Paul Bolle pebo...@tiscali.nl
---
Changelog
On Mon, Sep 29, 2014 at 10:18 PM, Paul Bolle pebo...@tiscali.nl wrote:
[Perhaps Kees hasn't seen this yet.]
On Tue, 2014-09-23 at 20:27 +0200, Valentin Rothberg wrote:
On mar., 2014-09-23 at 10:11 -0700, Randy Dunlap wrote:
On 09/23/14 10:10, Valentin Rothberg wrote:
On mar., 2014-09-23
On Mon, Nov 10, 2014 at 12:42 PM, Paul Bolle pebo...@tiscali.nl wrote:
On Sat, 2014-11-08 at 20:56 +0100, Valentin Rothberg wrote:
This patch improves the detection of defects by updating the
regular expression to find Kconfig identifiers in the source
code, and fixes some cases of false
On mar., 2014-09-23 at 09:49 -0700, Randy Dunlap wrote:
On 09/22/14 23:58, Valentin Rothberg wrote:
The _MODULE suffix is reserved for tristates compiled as
loadable kernel modules (LKM). The TEST_MODULE feature thereby
Is that documented anywhere?
Sadly this is not made explicit
On mar., 2014-09-23 at 10:11 -0700, Randy Dunlap wrote:
On 09/23/14 10:10, Valentin Rothberg wrote:
On mar., 2014-09-23 at 09:49 -0700, Randy Dunlap wrote:
On 09/22/14 23:58, Valentin Rothberg wrote:
The _MODULE suffix is reserved for tristates compiled as
loadable kernel modules (LKM
- improve filtering of false positives (e.g, CONFIG_XXX)
- change output format from (feature:\tlist) to (feature\tlist)
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
Changelog:
This patch bases on version 6 (https://lkml.org/lkml/2014/9/27/93)
of a patch which has been picked up
On Tue, Feb 3, 2015 at 10:09 PM, NeilBrown ne...@suse.de wrote:
On Tue, 03 Feb 2015 22:03:35 +0100 Paul Bolle pebo...@tiscali.nl wrote:
On Wed, 2015-02-04 at 07:50 +1100, NeilBrown wrote:
Actually the prefix of this macro is CONFIG_AS_, not CONFIG_ :-)
CONFIG_AS_ is reserved for assembly
From: Valentin Rothberg valentinrothb...@gmail.com
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 (genirq: Reject
bogus threaded irq requests) threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.
The %irq_flags flag is used
of the caller. Hence, we cannot be sure that IRQF_ONESHOT is
set. This change avoids the potentially missing flag by setting
IRQF_ONESHOT when requesting the threaded IRQ.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Signed-off-by: Valentin Rothberg valentin.rothb...@lip6.fr
---
Changelog
another kernel thread (workqueue).
This change splits up the 5 interrupt handlers into top halves (_th) and
bottom halves (_bh) and resolves the aforementioned overhead by only
requesting threaded interrupts (i.e., bottom halves) when necessary.
Signed-off-by: Valentin Rothberg valentin.rothb
The comment for the current_pwq member in the worker struct has
not been tab aligned, which is inconsistent with the rest of the
code.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
I am currently studying interrupt code. While reading, my eyes stopped at this
line to figure out
checkpatch.pl complained about two single statement macros in
do while (0) loops. The loops and the trailing semicolons are
now removed, which makes checkpatch happy and the two macros
consistent with the rest of the file.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
include
Hi James,
your commit d358f1abbf71 (crypto: img-hash - Add Imagination
Technologies hw hash accelerator) adds two selects on undefined
Kconfig symbols, namely CRYPTO_ALG_API and CRYPTO_SHA224.
The first symbols looks like a typo since there is an option
CRYPTO_ALGAPI defined in crypto/Kconfig.
. Hence, the script aborts in
case it is executed in a dirty tree. It won't abort if '--force' is
passed.
If neither -c nor -d is specified, the script defaults to check the
entire local tree (i.e., the previous behavior).
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
Changelog for v2
. Hence, the script aborts in
case it is executed in a dirty tree. It won't abort if '--force' is
passed.
If neither -c nor -d is specified, the script defaults to check the
entire local tree (i.e., the previous behavior).
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
Changelog for v2
On Fri, Mar 20, 2015 at 11:52 AM, Paul Bolle pebo...@tiscali.nl wrote:
On Fri, 2015-03-20 at 10:39 +, Vladimir Murzin wrote:
I should have tested it before...
Valentin proposed an update to scripts/checkkconfigsymbols.py in
https://lkml.org/lkml/2015/3/16/190 . It (or something like it)
On Mon, Mar 9, 2015 at 5:52 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Thu, Mar 05, 2015 at 03:23:08PM +0100, Valentin Rothberg wrote:
The IRQF_DISABLED is a NOOP and has been scheduled for removal since
Linux v2.6.36 by commit 6932bf37bed4 (genirq: Remove IRQF_DISABLED from
core code
On Fri, Mar 6, 2015 at 8:41 PM, Dmitry Torokhov
dmitry.torok...@gmail.com wrote:
On Thu, Mar 5, 2015 at 5:11 AM, Hannes Reinecke h...@suse.de wrote:
On 03/05/2015 01:59 PM, Valentin Rothberg wrote:
The IRQF_DISABLED is a NOOP and has been scheduled for removal since
Linux v2.6.36 by commit
11, 2015 at 3:33 PM, Valentin Rothberg
valentinrothb...@gmail.com wrote:
On Wed, Mar 11, 2015 at 3:19 PM, Valentin Rothberg
valentinrothb...@gmail.com wrote:
On Wed, Mar 11, 2015 at 1:04 PM, Paul Bolle pebo...@tiscali.nl wrote:
On Wed, 2015-03-11 at 12:16 +0100, Valentin Rothberg wrote:
Note
On Fri, Mar 13, 2015 at 9:20 PM, Paul Bolle pebo...@tiscali.nl wrote:
On Wed, 2015-03-11 at 16:04 +0100, Valentin Rothberg wrote:
Paul, how long does your monster run? Maybe I just call it wrong or
mess up with caches.
Even longer, I presume. Because an update for just a new linux next
On 03/11/2015 12:32 AM, Valentin Rothberg wrote:
Hi Chanwoo,
your commit 96bd6224f07b (clk: samsung: exynos5433: Add clocks using
common clock framework) is included in today's linux-next tree (i.e.,
next-20150310).
This patch conditionally compiles clk-exynos5433.c depending on the
Kconfig
Hi Chanwoo,
your commit 96bd6224f07b (clk: samsung: exynos5433: Add clocks using
common clock framework) is included in today's linux-next tree (i.e.,
next-20150310).
This patch conditionally compiles clk-exynos5433.c depending on the
Kconfig option ARCH_EXYNOS5433. However, this option is not
that both options require to 'git reset --hard' the user's Git
tree, which can lead to the loss of uncommitted data.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
There are still some performance improvements possible (e.g., only parse Kconfig
files for a 2nd time when needed
On Wed, Mar 11, 2015 at 3:19 PM, Valentin Rothberg
valentinrothb...@gmail.com wrote:
On Wed, Mar 11, 2015 at 1:04 PM, Paul Bolle pebo...@tiscali.nl wrote:
On Wed, 2015-03-11 at 12:16 +0100, Valentin Rothberg wrote:
Note that both options require to 'git reset --hard' the user's Git
tree, which
On Wed, Mar 11, 2015 at 1:04 PM, Paul Bolle pebo...@tiscali.nl wrote:
On Wed, 2015-03-11 at 12:16 +0100, Valentin Rothberg wrote:
Note that both options require to 'git reset --hard' the user's Git
tree, which can lead to the loss of uncommitted data.
My local 800 line perl monster basically
Hi David,
your commit 9861908f081f (MIPS: OCTEON: Enable little endian kernel.)
adds the following conditional select to arch/mips/Kconfig:
+ select SYS_SUPPORTS_HOTPLUG_CPU if CONFIG_CPU_BIG_ENDIAN
The problem is the 'CONFIG_' prefix for 'CPU_BIG_ENDIAN'. The item is
always off since
Hi Kevin,
your commit dd6d84812b1a (MIPS: BMIPS: Enable additional peripheral
and CPU support in defconfig) adds a select on the Kconfig symbol
RAW_IRQ_ACCESORS. However, this symbol is not defined in Kconfig so
that the select turns out to be a NOOP.
Is there a patch scheduled somewhere to
Hi Suzuki,
your commit c9966c98697a (arm-cci: Split the code for PMU vs driver
support) renames the Kconfig option ARM_CCI to ARM_CCI400_PORT_CTRL.
However, the commit does not rename all references on ARM_CCI:
drivers/bus/Kconfig:29: select ARM_CCI
drivers/bus/Makefile:6:obj-$(CONFIG_ARM_CCI)
Hi Paul,
thanks for your answer.
On Tue, Mar 3, 2015 at 1:57 AM, Paul Bolle pebo...@tiscali.nl wrote:
On Wed, 2015-02-25 at 15:15 +0100, Valentin Rothberg wrote:
@@ -46,8 +46,9 @@ def main():
stdout = stdout[:-1]
for gitfile in stdout.rsplit(\n):
-if .git in gitfile
On Mon, Mar 2, 2015 at 10:56 PM, Andrew Morton
a...@linux-foundation.org wrote:
On Fri, 27 Feb 2015 13:32:55 +0100 Valentin Rothberg
valentin.rothb...@lip6.fr wrote:
The IRQF_DISABLED is a NOOP and scheduled to be removed. According to
Ingo Molnar (e58aa3d2d0cc01ad8d6f7f640a0670433f794922
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 (genirq: Reject
bogus threaded irq requests) threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Signed-off-by: Valentin
-by: Valentin Rothberg valentin.rothb...@lip6.fr
---
drivers/bus/omap_l3_noc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
index 029bc73..11f7982 100644
--- a/drivers/bus/omap_l3_noc.c
+++ b/drivers/bus/omap_l3_noc.c
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 (genirq: Reject
bogus threaded irq requests) threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request may fail.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Signed-off-by: Valentin
-by: Valentin Rothberg valentin.rothb...@lip6.fr
---
drivers/bus/omap_l3_smx.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/bus/omap_l3_smx.c b/drivers/bus/omap_l3_smx.c
index 597fdae..360a5c0 100644
--- a/drivers/bus/omap_l3_smx.c
+++ b/drivers/bus
the ONESHOT flag directly in request_threaded_irq() to
enforce the flag without being affected by future changes to
plat-irqtype.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Signed-off-by: Valentin Rothberg valentin.rothb...@lip6.fr
---
drivers/input/keyboard/tc3589x-keypad.c | 6 +++---
1
The IRQF_DISABLED is a NOOP and scheduled to be removed. According to
Ingo Molnar (e58aa3d2d0cc01ad8d6f7f640a0670433f794922) running IRQ
handlers with interrupts enabled can cause stack overflows when the
interrupt line of the issuing device is still active.
Signed-off-by: Valentin Rothberg
using this deprecated flag and additionally removes
redundantly setting IRQF_SHARED.
Signed-off-by: Valentin Rothberg valentin.rothb...@lip6.fr
---
drivers/usb/isp1760/isp1760-core.c | 5 ++---
drivers/usb/isp1760/isp1760-udc.c | 4 ++--
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git
-by: Valentin Rothberg valentin.rothb...@lip6.fr
---
v2: Add commit summary of referenced commit.
---
arch/mips/loongson/loongson-3/hpet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/loongson/loongson-3/hpet.c
b/arch/mips/loongson/loongson-3/hpet.c
index e898d68..5c21cd3
On Fri, Feb 27, 2015 at 4:24 PM, Felipe Balbi ba...@ti.com wrote:
On Fri, Feb 27, 2015 at 02:29:40PM +0100, Valentin Rothberg wrote:
The IRQF_DISABLED is a NOOP and scheduled to be removed. According to
commit e58aa3d2d0cc (genirq: Run irq handlers with interrupts disabled)
running IRQ
Hi,
Andrew asked me to prepare one big patch that removes the
IRQF_DISABLED flag entirely. I already sent a few small patches that
remove the usage of this flag, two of them [1, 2] have been applied
by Tony to omap-for-v4.1/l3. Hence, I cannot remove the definition
now and leave the files of
of the redundant setting of IRQF_SHARED for
isp1760_udc_register().
Kind regards,
Valentin
On Mon, Mar 2, 2015 at 4:30 PM, laurent.pinch...@ideasonboard.com wrote:
Hi Valentin,
Thank you for the patch.
On Sun Mar 01 2015 17:54:32 GMT+0200 (EET), Valentin Rothberg wrote:
The IRQF_DISABLED
, the counterpart devm function (see kernel/irq/devres.c) is also
affected by the missing flag which can be detected with this patch.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
scripts/coccinelle/misc/irqf_oneshot.cocci | 24
Hi Javi,
your commit 8754d5115693 (thermal: introduce the Power Allocator
governor) is included in today's linux-next tree (i.e.,
next-20150304).
This patch adds a select on the Kconfig symbol THERMAL_POWER_ACTOR.
However, THERMAL_POWER_ACTOR is not defined so that this select is a
NOOP.
@@
using this deprecated flag and additionally removes
redundantly setting IRQF_SHARED for isp1760_udc_register().
Signed-off-by: Valentin Rothberg valentin.rothb...@lip6.fr
---
v2: Reverted change that removed IRQF_SHARED in the call of
isp1760_hcd_register().
---
drivers/usb/isp1760/isp1760
On Fri, Feb 27, 2015 at 11:17 PM, Jonathan Corbet cor...@lwn.net wrote:
On Fri, 27 Feb 2015 12:55:16 +0100
Valentin Rothberg valentin.rothb...@lip6.fr wrote:
The IRQF_DISABLED is a NOOP and scheduled to be removed. According to
Ingo Molnar (e58aa3d2d0cc01ad8d6f7f640a0670433f794922) running
this documentation. It was
mentioned to be a solution to avoid deadlocks when a device uses
multiple interrupts. As the flag is a NOOP this solution does not work
anymore.
Signed-off-by: Valentin Rothberg valentin.rothb...@lip6.fr
---
Documentation/PCI/MSI-HOWTO.txt | 10 +++---
1 file
this documentation. It was
mentioned to be a solution to avoid deadlocks when a device uses
multiple interrupts. As the flag is a NOOP this solution does not work
anymore.
Signed-off-by: Valentin Rothberg valentin.rothb...@lip6.fr
---
v2: Remove following paragraph (If your MSI [...]) since
The IRQF_DISABLED is a NOOP and scheduled to be removed. According to Ingo
Molnar (e58aa3d2d0cc01ad8d6f7f640a0670433f794922) running IRQ handlers with
interrupts enabled can cause stack overflows when the interrupt line of the
issuing device is still active.
Signed-off-by: Valentin Rothberg
stack overflows when the interrupt line of the issuing device is
still active.
This patch ends the grace period for IRQF_DISABLED (i.e., SA_INTERRUPT
in older versions of Linux) and removes the definition and all remaining
usages of this flag.
Signed-off-by: Valentin Rothberg valentinrothb
stack overflows when the interrupt line of the issuing device is
still active.
This patch ends the grace period for IRQF_DISABLED (i.e., SA_INTERRUPT
in older versions of Linux) and removes the definition and all remaining
usages of this flag.
Signed-off-by: Valentin Rothberg valentinrothb
On Thu, Mar 5, 2015 at 2:08 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Thu, Mar 05, 2015 at 01:59:39PM +0100, Valentin Rothberg wrote:
diff --git a/drivers/mtd/nand/hisi504_nand.c
b/drivers/mtd/nand/hisi504_nand.c
index 289ad3ac3e80..7f9f9c827c1d 100644
--- a/drivers/mtd/nand
On Thu, Mar 5, 2015 at 2:11 PM, Hannes Reinecke h...@suse.de wrote:
On 03/05/2015 01:59 PM, Valentin Rothberg wrote:
The IRQF_DISABLED is a NOOP and has been scheduled for removal since
Linux v2.6.36 by commit 6932bf37bed4 (genirq: Remove IRQF_DISABLED from
core code).
According to commit
On Tue, Mar 3, 2015 at 9:37 AM, Ingo Molnar mi...@kernel.org wrote:
* Andrew Morton a...@linux-foundation.org wrote:
On Fri, 27 Feb 2015 13:32:55 +0100 Valentin Rothberg
valentin.rothb...@lip6.fr wrote:
The IRQF_DISABLED is a NOOP and scheduled to be removed. According to
Ingo Molnar
, the counterpart devm function (see kernel/irq/devres.c) is also
affected by the missing flag which can be detected with this patch.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
scripts/coccinelle/misc/irqf_oneshot.cocci | 24
tools (i.e., scripts/checkkconfigsymbols.py) since the CONFIG_
prefix and the _MODULE suffix is reserved for Kconfig features in CPP
and Make syntax.
Signed-off-by: Valentin Rothberg valentin.rothb...@lip6.fr
---
scripts/checkkconfigsymbols.py | 7 ---
1 file changed, 4 insertions(+), 3
On Mon, Mar 23, 2015 at 5:04 PM, Suzuki K. Poulose
suzuki.poul...@arm.com wrote:
On 23/03/15 15:17, Suzuki K. Poulose wrote:
On 23/03/15 15:10, Valentin Rothberg wrote:
Hi Suzuki,
your commit c9966c98697a (arm-cci: Split the code for PMU vs driver
support) renames the Kconfig option
output and adds the missing print for the
default case. Additionally, the file lists are now sorted as well which
(a) makes it easier to read and (b) makes the output deterministic.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
This patch is written against the char-misc-next
Hi Alex,
your commit (memory: jz4780-nemc: driver for the NEMC on JZ4780
SoCs) sets MACH_JZ4780 as Kconfig dependency for the JZ4780_NEMC
driver.
+config JZ4780_NEMC
[...]
+ depends on MACH_JZ4780
MACH_JZ4780 is not defined in Kconfig, so that JZ4780_NEMC is always
false and the driver
,
ZubairLK
On 02/04/15 10:09, Valentin Rothberg wrote:
Hi Alex,
your commit (memory: jz4780-nemc: driver for the NEMC on JZ4780
SoCs) sets MACH_JZ4780 as Kconfig dependency for the JZ4780_NEMC
driver.
+config JZ4780_NEMC
[...]
+ depends on MACH_JZ4780
MACH_JZ4780 is not defined
Hi Jassi,
your commit 1ccdd04f5365 (clk: Add clock driver for mb86s7x) is in
today's Linux next tree. The clock driver clk-mb86s7x.c is
conditionally compiled depending on CONFIG_ARCH_MB86S7X. This option is
nowhere defined in Kconfig, so that the driver cannot be compiled at its
current tate.
Hi Scott,
your commit b3df664b85c7 (bf609: add resources for lcd nl8048) is in
today's Linux next tree and adds the following #ifdef block:
+#if defined(CONFIG_FB_BF609_NL8048) \
+ || defined(CONFIG_FB_BF609_NL8048_MODULE)
[...]
At the current state, the ifdef guarded code cannot be
tools happy.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
I detected this issue with ./scripts/checkkconfigsymbols.py
---
drivers/scsi/arm/acornscsi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/arm/acornscsi.c b/drivers/scsi/arm
On Tue, Apr 28, 2015 at 9:34 PM, Paul Bolle pebo...@tiscali.nl wrote:
Hi Valentin,
On Tue, 2015-04-28 at 21:26 +0200, Valentin Rothberg wrote:
On Tue, Apr 28, 2015 at 9:10 PM, Paul Bolle pebo...@tiscali.nl wrote:
Will the Erlangen bot still spot ACORNSCSI_CONSTANTS as a potential
issue
Hi Paul,
On Wed, Apr 29, 2015 at 10:27 AM, Paul Bolle pebo...@tiscali.nl wrote:
[Added Joe.]
On Tue, 2015-04-28 at 11:08 +0200, Valentin Rothberg wrote:
The CPP identifier 'DEBUG' is not used in the source code of nfc at all,
so we can safely remove setting it in both Makefiles.
Signed-off
Hi Geert,
I am cleaning up some Kconfig issues in ARM
(./scripts/checkkconfgisymbols.py) at the moment and came across
CONFIG_ARCH_R8A7793:
arch/arm/Kconfig.debug: depends on ARCH_R8A7790 ||
ARCH_R8A7791 || ARCH_R8A7793
drivers/clk/shmobile/Makefile:obj-$(CONFIG_ARCH_R8A7793)
+=
ARM_ERRATA_753970 is not defined in Kconfig, so that both selects turn
out to be nops. Hence, we can safely remove them.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
I detected this issue with scripts/checkkconfigsymbols.py
---
arch/arm/mach-mvebu/Kconfig | 2 --
1 file
The block could never be compiled; CPU_ICACHE_STREAMING_DISABLE has not
been defined in Kconfig since the very first Git commit. Hence, we can
safely remove the entire block.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
There is a similar looking option 'CPU_ICACHE_DISABLE
Hi Gregory,
thanks for your reply.
On Tue, Apr 28, 2015 at 6:41 PM, Gregory CLEMENT
gregory.clem...@free-electrons.com wrote:
Hi Valentin,
On 28/04/2015 18:02, Valentin Rothberg wrote:
ARM_ERRATA_753970 is not defined in Kconfig, so that both selects turn
out to be nops. Hence, we can
CPU_ARM1020_CPU_IDLE is not defined in Kconfig. The last reference on
LKML dates back to 2001, so we can safely remove the comments to make
static analysis tools happy.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
I detected this issue with scripts/checkkconfigsymbols.py
Hi Kevin,
this is just a kind reminder that the issue below is still present and
made its way to v4.1-rc1.
Kind regards,
Valentin
On Thu, Mar 26, 2015 at 11:47 AM, Valentin Rothberg
valentinrothb...@gmail.com wrote:
Hi Kevin,
your commit dd6d84812b1a (MIPS: BMIPS: Enable additional
-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o
Regards,
Chanwoo Choi
On 03/11/2015 12:32 AM, Valentin Rothberg wrote:
Hi Chanwoo,
your commit 96bd6224f07b (clk: samsung: exynos5433: Add clocks using
common clock framework) is included in today's linux-next tree (i.e.,
next-20150310).
This patch
Hi Clément,
your commit dece45855a8b (NFC: nxp-nci: Add support for NXP NCI
chips) adds the Makefile drivers/nfc/nxp-nci/Makefile with the
following line:
+ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
The Kconfig option NFC_DEBUG is not defined so the line turns out to
be a nop. There is another
Hi Stephen,
this is just a kind reminder that the issue below is still present and
made its way to v4.1-rc1. Any news from the maintainers' side?
Kind regards,
Valentin
On Wed, Apr 8, 2015 at 12:57 AM, Stephen Boyd sb...@codeaurora.org wrote:
On 04/07/15 07:12, Valentin Rothberg wrote
I took the email from the author field of the commit, which does not
exists anymore. Now I added Clément's correct email address.
On Mon, Apr 27, 2015 at 9:03 AM, Valentin Rothberg
valentinrothb...@gmail.com wrote:
Hi Clément,
your commit dece45855a8b (NFC: nxp-nci: Add support for NXP NCI
Hi Scott,
your commit 374feb1f049b (bf609: use new SND_BF6XX_PCM to choose
audio pcm driver) made its way to Linux v4.1-rc1. It replaces
CONFIG_SND_BF5XX_I2S with CONFIG_SND_BF6XX_PCM, which is not defined
Kconfig. Hence the affected #ifdef blocks cannot be compiled at the
current state.
Is
Hi Clément,
thanks for your answer.
On Tue, Apr 28, 2015 at 10:23 AM, Clément Perrochaud
clement.perroch...@effinnov.com wrote:
On Mon, Apr 27, 2015 at 9:03 AM, Valentin Rothberg wrote:
Hi Clément,
your commit dece45855a8b (NFC: nxp-nci: Add support for NXP NCI
chips) adds the Makefile
you apply a patch? Besides having fun doing such things, I also
have some research interest in it and I archive Kconfig related
emails; a notification mail would make it easier.
Kind regards,
Valentin
-- Forwarded message --
From: Valentin Rothberg valentinrothb...@gmail.com
Date
Some more recent distributions set the default interpreter to python3,
causing the script to break since it's written for python2.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
scripts/checkkconfigsymbols.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Fri, May 1, 2015 at 9:31 PM, Paul Bolle pebo...@tiscali.nl wrote:
Valentin Rothberg schreef op wo 29-04-2015 om 16:58 [+0200]:
Sometimes a user might be interested to filter certain reports (e.g.,
the many defconfigs).
Is this actually useful outside of filtering out defconfigs?
It's
On Fri, May 1, 2015 at 10:49 PM, Paul Bolle pebo...@tiscali.nl wrote:
[Added Russell, because I, sort, of drop his name.]
Valentin Rothberg schreef op vr 01-05-2015 om 22:13 [+0200]:
On Fri, May 1, 2015 at 9:31 PM, Paul Bolle pebo...@tiscali.nl wrote:
Valentin Rothberg schreef op wo 29-04
CPU_S3C2413 is not defined in Kconfig, so that all references on it turn
out to be 0. Since CPU_S3C2412 supports both, S3C2412 and S3C2413 SoCs
from the S3C24XX line, we can safely remove all dead references on
CPU_S3C2413.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
I
The previous #ifdef block depends on ARCH_DAVINCI_DA8XX, not
on DAVINCI_DA8XX.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
I detected this issue with scripts/checkkconfigsymbols.py
---
arch/arm/mach-davinci/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Sometimes a user might be interested to filter certain reports (e.g.,
the many defconfigs). Now, this can be achieved by specifying a Python
regex with -i / --ignore.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
scripts/checkkconfigsymbols.py | 32
The CPP identifier 'DEBUG' is not used in the source code of nfc at all,
so we can safely remove setting it in both Makefiles.
Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com
---
I detected this issue with ./scripts/checkkconfigsymbols.py since
CONFIG_NFC_DEBUG is not defined
On Tue, Apr 28, 2015 at 9:24 PM, Paul Bolle pebo...@tiscali.nl wrote:
On Tue, 2015-04-28 at 18:45 +0200, Valentin Rothberg wrote:
The block could never be compiled; CPU_ICACHE_STREAMING_DISABLE has not
been defined in Kconfig since the very first Git commit.
Actually, this goes back
Hi Paul,
On Tue, Apr 28, 2015 at 9:10 PM, Paul Bolle pebo...@tiscali.nl wrote:
On Tue, 2015-04-28 at 16:15 +0200, Valentin Rothberg wrote:
CONFIG_ACORNSCSI_CONSTANTS is a file local CPP identifier and thereby
violates the naming convention of Kconfig options in Make and CPP
syntax; only
1 - 100 of 556 matches
Mail list logo
