[GIT PULL] dmaengine fixes

2015-01-17 Thread Vinod Koul
) Andy Shevchenko (1): dmaengine: dw: balance PM runtime calls Vinod Koul (1): MAINTAINERS: dmaengine: fix the header file for dmaengine MAINTAINERS |2 +- drivers/dma/dw/core.c |2 -- drivers/dma/dw/platform.c |5 + 3 files

Re: [PATCH] dmaengine: Move dma_get_slave_caps() implementation to dmaengine.c

2015-01-18 Thread Vinod Koul
On Wed, Oct 29, 2014 at 12:30:58AM +0200, Laurent Pinchart wrote: > The function is too big to be a static inline. > Applied thanks -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] dma: coh901318: fix function return types build warnings

2015-01-18 Thread Vinod Koul
On Tue, Jan 13, 2015 at 10:17:03PM +0100, Arnd Bergmann wrote: > A recent patch that removed coh901318_control() replaced it > with a number of pointers to existing functions, but those > unfortunately have the wrong return type and need to be > changed to return an 'int' with an error value rathe

Re: [PATCH v8 0/3] dmaengine: APM X-Gene SoC DMA engine driver support

2015-04-02 Thread Vinod Koul
On Wed, Mar 18, 2015 at 07:17:33PM +0530, Rameshwar Prasad Sahu wrote: > This patch set implements the APM X-Gene SoC DMA driver support to offload > the DMA operations such as memory copy(memcpy), scatter gather memory copy, > raid5 xor and raid6 p+q. Applied, now Thanks -- ~Vinod -- To unsubscr

Re: [PATCH slave-dma] dmaengine: xgene_dma_init_ring_mngr() can be static

2015-04-02 Thread Vinod Koul
On Thu, Apr 02, 2015 at 05:50:56PM +0800, kbuild test robot wrote: > > Signed-off-by: Fengguang Wu > --- > xgene-dma.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/xgene-dma.c b/drivers/dma/xgene-dma.c > index 2383528..aa61935 100755 > --- a/drivers/dm

Re: [PATCH 3/5] dmaengine: pxa: add pxa dmaengine driver

2015-04-02 Thread Vinod Koul
On Thu, Apr 02, 2015 at 11:06:32AM +0200, Robert Jarzmik wrote: > Robert Jarzmik writes: > > > This is a new driver for pxa SoCs, which is also compatible with the former > > mmp_pdma. > > All right, I have a v2 for this patch, with a minor change for muxed interrupt > probe case (1 interrupt fo

Re: [GIT PULL] TTY/Serial patches for 4.1-rc1

2015-04-21 Thread Vinod Koul
ld be selected the HSU_PCI driver (which has a help text) and this already done by HSU_PCI Linus, Please apply this for fixing it. I have noticed few other places as well, will add them on my dmaengine pull request and send. Thanks ~Vinod --><8--><8 From: Vinod

Re: [PATCH v2] dma: vdma: Fix compilation warnings

2015-03-30 Thread Vinod Koul
On Mon, Mar 30, 2015 at 06:48:29PM +0530, Kedareswara rao Appana wrote: > This patch fixes the following compilation warnings. > In file included from drivers/dma/xilinx/xilinx_vdma.c:26:0: > include/linux/dmapool.h:18:4: warning: 'struct device' declared inside > parameter list > size_t size,

Re: [PATCH v2 1/7] dmaengine: of_dma: Support for DMA routers

2015-03-30 Thread Vinod Koul
On Fri, Mar 27, 2015 at 02:25:29PM +0200, Peter Ujfalusi wrote: > On 03/26/2015 05:32 PM, Vinod Koul wrote: > >> I have added the DT binding document since this series adds support for > >> routers for platforms booting with DT: > >> > >> Documentati

Re: [PATCH] dmaengine: pl330: fix the race condition in pl330 driver.

2015-03-30 Thread Vinod Koul
On Mon, Mar 30, 2015 at 10:17:17PM +0530, Jassi Brar wrote: > On Fri, Mar 27, 2015 at 5:25 AM, Scott Branden wrote: > > From: ismail > > > > Update the thread running index before issuing the > > GO command to the DMAC. > > > > Tested-by: Mohamed Ismail Abdul Packir Mohamed > > Reviewed-by: Ray

Re: [PATCH 4/5] dmaengine: hsu: Fix memory leak when stopping a running transfer

2015-03-30 Thread Vinod Koul
> > > > Acked-by: Andy Shevchenko Acked-by: Vinod Koul Greg, Please apply this in your queue for next -- Vinod > > Though this one would go via Greg's tty tree (Cc'ed) I think. > It becomes to regular work flow after 4.1-rc1. > > >

Re: [PATCH 1/5] dmaengine: edma: fix memory leak when terminating running transfers

2015-03-30 Thread Vinod Koul
On Fri, Mar 27, 2015 at 01:35:51PM +0200, Peter Ujfalusi wrote: > From: Petr Kulhavy > > If edma_terminate_all() was called while a transfer was running (i.e. after > edma_execute() but before edma_callback()) the echan->edesc was not freed. > > This was due to the fact that a running transfer i

Re: [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer

2015-03-30 Thread Vinod Koul
On Fri, Mar 27, 2015 at 01:35:53PM +0200, Peter Ujfalusi wrote: > The vd->node is removed from the lists when the transfer started so the > vchan_get_all_descriptors() will not find it. This results memory leak. > > Signed-off-by: Peter Ujfalusi > CC: Stephen Warren > CC: Lee Jones Applied, tha

Re: [PATCH 2/5] dmaengine: omap-dma: Fix memory leak when terminating running transfer

2015-03-30 Thread Vinod Koul
On Fri, Mar 27, 2015 at 01:35:52PM +0200, Peter Ujfalusi wrote: > In omap_dma_start_desc the vdesc->node is removed from the virt-dma > framework managed lists (to be precise from the desc_issued list). > If a terminate_all comes before the transfer finishes the omap_desc will > not be freed up bec

Re: [PATCH 5/5] dmaengine: moxart-dma: Fix memory leak when stopping a running transfer

2015-03-30 Thread Vinod Koul
On Fri, Mar 27, 2015 at 01:35:55PM +0200, Peter Ujfalusi wrote: > The vd->node is removed from the lists when the transfer started so the > vchan_get_all_descriptors() will not find it. This results memory leak. > > Signed-off-by: Peter Ujfalusi > CC: Jonas Jensen Applied, thanks -- ~Vinod >

Re: [PATCH v2] dma: vdma: Fix compilation warnings

2015-03-30 Thread Vinod Koul
On Tue, Mar 31, 2015 at 07:35:43AM +1100, Stephen Rothwell wrote: Hi Stephen, > > On Mon, 30 Mar 2015 22:48:46 +0530 Vinod Koul wrote: > > > > On Mon, Mar 30, 2015 at 06:48:29PM +0530, Kedareswara rao Appana wrote: > > > This patch fixes the following compilation warni

Re: [PATCH_V4 0/3] dma: dt: Add DMA driver for jz4780

2015-03-31 Thread Vinod Koul
On Wed, Mar 18, 2015 at 04:16:34PM +, Zubair Lutfullah Kakakhel wrote: > Hi, > > Here we have three patches that add a DMA driver for the Ingenic JZ4780 SoC. > > JZ4780 support is still in-flight. > > These are based on 4.0-rc4. Applied, thanks Please ensure you use the right subsystem nam

Re: [PATCH 1/2] dma: Add Freescale qDMA engine driver support

2015-03-31 Thread Vinod Koul
On Tue, Mar 17, 2015 at 01:28:38PM +0800, Yuan Yao wrote: > +static int fsl_qdma_alloc_chan_resources(struct dma_chan *chan) > +{ > + /* > + * In QDMA mode, We don't need to do anything. > + */ > + return 0; > +} Pls remove this > +static struct fsl_qdma_comp *fsl_qdma_request_en

Re: [Patch v6 2/2] dmaengine: Add ADM driver

2015-03-31 Thread Vinod Koul
On Tue, Mar 17, 2015 at 12:46:12AM -0500, Andy Gross wrote: > +static enum dma_status adm_tx_status(struct dma_chan *chan, dma_cookie_t > cookie, > + struct dma_tx_state *txstate) > +{ > + struct adm_chan *achan = to_adm_chan(chan); > + struct virt_dma_desc *vd; > + enum dma_statu

Re: [PATCH] dmaengine: ste_dma40: fix implicit conversion

2015-03-31 Thread Vinod Koul
On Sun, Mar 22, 2015 at 12:51:08AM +0100, Stefan Agner wrote: > The function d40_prep_sg takes the type enum dma_transfer_direction > as second last parameter. However, the memcpy calls pass DMA_NONE > which is of type enum dma_data_direction. Fix this by passing the > actual transfer direction DMA

Re: [PATCH 2/2] EDMA: TI: fixed wrongly initialized data parameter to the edma callback

2015-03-31 Thread Vinod Koul
On Mon, Mar 23, 2015 at 09:35:01PM +0100, Petr Kulhavy wrote: > The "data" parameter passed indirectly to the edma_callback() should be > edma_chan and not the dma_chan. > > This bug was so far harmless since the offset of struct dma_chan within struct > edma_chan is 0. However as soon as someone

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-26 Thread Vinod Koul
On Mon, Apr 20, 2015 at 08:38:18AM +0530, Rameshwar Sahu wrote: > Hi Vinod, >> >> @@ -2085,6 +2043,5 @@ module_platform_driver(xgene_dma_driver); > >> > >> MODULE_DESCRIPTION("APM X-Gene SoC DMA driver"); > >> MODULE_AUTHOR("Rameshwar Prasad Sahu "); > >> -MODULE_AUTHOR("Loc Ho "); > > And why th

Re: [PATCH] dmaengine: dw: add Intel Broxton LPSS Integrated DMA support

2015-04-26 Thread Vinod Koul
On Tue, Apr 21, 2015 at 05:41:50AM +, Zha, Qipeng wrote: > + dma maillist Pls CC maintainer, or your patch will be missed!! > > > > > Best wishes > Qipeng > > -Original Message- > From: Zha, Qipeng > Sent: Tuesday, April 21, 2015 7:34 AM > To: linux-kernel@vger.kernel.org > Cc: v

Re: [PATCH v2] dma: vdma: Fix compilation warnings

2015-04-17 Thread Vinod Koul
On Mon, Mar 30, 2015 at 06:48:29PM +0530, Kedareswara rao Appana wrote: > This patch fixes the following compilation warnings. > In file included from drivers/dma/xilinx/xilinx_vdma.c:26:0: > include/linux/dmapool.h:18:4: warning: 'struct device' declared inside > parameter list > size_t size,

Re: [PATCH] dmaengine: at_xdmac: unlock spin lock before return

2015-04-17 Thread Vinod Koul
On Tue, Apr 07, 2015 at 04:42:45PM +0200, Niklas Cassel wrote: > Signed-off-by: Niklas Cassel > --- > drivers/dma/at_xdmac.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index d9891d3..933e4b3 100644 > --- a/drivers

Re: [PATCH] dmaengine: pch_dma: fix memory leak on failure path in pch_dma_probe()

2015-04-17 Thread Vinod Koul
On Sat, Apr 11, 2015 at 01:28:41AM +0300, Alexey Khoroshilov wrote: > Memory allocated for pch_dma is not deallocated in case of failure > in pch_dma_probe(). > > Found by Linux Driver Verification project (linuxtesting.org). > Applied, thanks -- ~Vinod -- To unsubscribe from this list: send t

Re: [PATCH] dmaengine: fix platform_no_drv_owner.cocci warnings

2015-04-17 Thread Vinod Koul
On Sun, Apr 12, 2015 at 02:18:34AM +0800, kbuild test robot wrote: > drivers/dma/xgene-dma.c:2079:3-8: No need to set .owner here. The core will > do it. > > Remove .owner field if calls are used which set it automatically > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci App

Re: [PATCH] dmaengine: shdmac: avoid unused variable warnings

2015-04-17 Thread Vinod Koul
On Sat, Apr 11, 2015 at 12:27:58AM +0200, Arnd Bergmann wrote: > This driver uses '#ifdef CONFIG_ARCH_SHMOBILE' and '#ifdef CONFIG_ARM' > interchangeably in its sh_dmae_probe function, which causes a build > warning when building for ARM without also enabling shmobile: > > dma/sh/shdmac.c: In func

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-17 Thread Vinod Koul
> /* Get DMA error interrupt */ > @@ -2076,7 +2035,6 @@ static struct platform_driver xgene_dma_driver = { > .remove = xgene_dma_remove, > .driver = { > .name = "X-Gene-DMA", > - .owner = THIS_MODULE, I have already applied a patch for this >

Re: [PATCH 1/9 v3] dmaengine: add an shdma-base library

2012-07-15 Thread Vinod Koul
On Mon, 2012-07-02 at 22:28 +0200, Guennadi Liakhovetski wrote: > > > > > > Let me know if you plan to fixing them or I will queue these up for 3.6 > > > > > > Please, queue these patches for the next merge window, we will work on > > > improving the driver after this split. > > > > It's been a

Re: [PATCH 5/7 v2] dma: sh: use an integer slave ID to improve API compatibility

2012-07-15 Thread Vinod Koul
On Thu, 2012-07-05 at 12:29 +0200, Guennadi Liakhovetski wrote: > diff --git a/include/linux/sh_dma.h b/include/linux/sh_dma.h > index a79f10a..4e83f3e 100644 > --- a/include/linux/sh_dma.h > +++ b/include/linux/sh_dma.h > @@ -27,10 +27,10 @@ struct sh_dmae_slave { > * a certain peripheral > */

Re: [PATCH 6/7 v2] dma: sh: provide a migration path for slave drivers to stop using .private

2012-07-15 Thread Vinod Koul
On Thu, 2012-07-05 at 12:29 +0200, Guennadi Liakhovetski wrote: > This patch extends the sh dmaengine driver to support the preferred channel > selection and configuration method, instead of using the "private" field > from struct dma_chan. We add a standard filter function to be used by > slave dr

Re: [PATCH 1/3] dw_dmac: mark dwc_dump_lli inline

2012-07-15 Thread Vinod Koul
On Fri, 2012-07-13 at 11:09 +0300, Andy Shevchenko wrote: Applied 1 & 2 only, Thanks -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Plea

Re: [PATCH 5/7 v2] dma: sh: use an integer slave ID to improve API compatibility

2012-07-15 Thread Vinod Koul
On Mon, 2012-07-16 at 08:37 +0200, Guennadi Liakhovetski wrote: > On Mon, 16 Jul 2012, Vinod Koul wrote: > > > On Thu, 2012-07-05 at 12:29 +0200, Guennadi Liakhovetski wrote: > > > diff --git a/include/linux/sh_dma.h b/include/linux/sh_dma.h > > > index a79f10a..4e83

Re: [PATCH 5/7 v2] dma: sh: use an integer slave ID to improve API compatibility

2012-07-16 Thread Vinod Koul
On Mon, 2012-07-16 at 09:13 +0200, Guennadi Liakhovetski wrote: > > > They tell the driver how the channel has to be configured to > support this > > > specific client. They are values of two specific registers. In > fact, CHCR > > > means exactly that - CHannel Control Register. > > what exactly

Re: [PATCH 5/7 v2] dma: sh: use an integer slave ID to improve API compatibility

2012-07-16 Thread Vinod Koul
On Mon, 2012-07-16 at 10:47 +0200, Guennadi Liakhovetski wrote: > > I want to know what does ccr and mid_rid mean to dmac here? > > CHCR contains a few fields, some enable various interrupt sources, some > specify repeat- and renew-modes, others yet specify transfer size, source > and destinatio

Re: [PATCH 5/7 v2] dma: sh: use an integer slave ID to improve API compatibility

2012-07-16 Thread Vinod Koul
On Mon, 2012-07-16 at 12:01 +0200, Guennadi Liakhovetski wrote: > On Mon, 16 Jul 2012, Vinod Koul wrote: > > > On Mon, 2012-07-16 at 10:47 +0200, Guennadi Liakhovetski wrote: > > > > I want to know what does ccr and mid_rid mean to dmac here? > > > > > &g

Re: [PATCH 5/7 v2] dma: sh: use an integer slave ID to improve API compatibility

2012-07-16 Thread Vinod Koul
On Mon, 2012-07-16 at 12:55 +0200, Guennadi Liakhovetski wrote: > On Mon, 16 Jul 2012, Vinod Koul wrote: > > > On Mon, 2012-07-16 at 12:01 +0200, Guennadi Liakhovetski wrote: > > > On Mon, 16 Jul 2012, Vinod Koul wrote: > > > > > > > On Mon, 2012-07-16 a

Re: [PATCH 5/7 v2] dma: sh: use an integer slave ID to improve API compatibility

2012-07-17 Thread Vinod Koul
On Mon, 2012-07-16 at 14:47 +0200, Guennadi Liakhovetski wrote: > > > Yes, that's right - these values have to be written to DMAC channel > > > configuration registers, so, we do not have to change anything, those > > > values can remain DMAC parameters and be passed to it directly from > > > pl

Re: [PATCH 0/7 v2] dma: sh: stop using .private

2012-07-19 Thread Vinod Koul
On Thu, 2012-07-05 at 12:29 +0200, Guennadi Liakhovetski wrote: > This patch series supersedes the one from yesterday with the same title. > The 4 patches from v1 are all unchanged, v2 just prepends them with 3 more > preparatory patches. From the original series description: > > Here's an attem

Re: [PATCH] dma: tegra: enable/disable dma clock

2012-07-19 Thread Vinod Koul
On Wed, 2012-07-18 at 14:26 +0530, Laxman Dewangan wrote: > Enable the DMA clock when registering DMA driver and > disable clock when removing the DMA driver. > > The failure was observed on Tegra20 based system by > Stephen Warren. However, it is working fine on tegra30 > based system and probabl

Re: [PATCH] dma: tegra: enable/disable dma clock

2012-07-19 Thread Vinod Koul
On Fri, 2012-07-20 at 11:34 +0530, Laxman Dewangan wrote: > On Friday 20 July 2012 11:32 AM, Vinod Koul wrote: > > On Wed, 2012-07-18 at 14:26 +0530, Laxman Dewangan wrote: > >> Enable the DMA clock when registering DMA driver and > >> disable clock when removing th

Re: [PATCH] dmaengine: Cleanup logging messages

2012-07-19 Thread Vinod Koul
On Wed, 2012-07-18 at 09:51 -0700, Joe Perches wrote: > Use a more current logging style. > > Add pr_fmt to prefix dmaengine: to messages. > Convert printk(KERN_ERR to pr_err(. > Convert embedded function name use to "%s: ", __func__ > Align arguments. > Applied thanks -- ~Vinod -- To unsubscr

Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information

2015-05-29 Thread Vinod Koul
On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote: > This fixes the following error: > drivers/dma/pxa_dma.c: In function ‘dbg_show_requester_chan’: > drivers/dma/pxa_dma.c:192:2: error: void value not ignored as it ought to be > pos += seq_printf(s, "DMA channel %d requester :\n", p

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-05-29 Thread Vinod Koul
On Tue, May 26, 2015 at 04:25:57PM +0300, Peter Ujfalusi wrote: > dma_request_slave_channel_compat() 'eats' up the returned error codes which > prevents drivers using the compat call to be able to do deferred probing. > > The new wrapper is identical in functionality but it will return with error

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-05-29 Thread Vinod Koul
On Fri, May 29, 2015 at 11:42:27AM +0200, Geert Uytterhoeven wrote: > On Fri, May 29, 2015 at 11:33 AM, Vinod Koul wrote: > > On Tue, May 26, 2015 at 04:25:57PM +0300, Peter Ujfalusi wrote: > >> dma_request_slave_channel_compat() 'eats' up the returned error codes

Re: [PATCH v2] ASoC: Intel: sst: use ; instead of , at the of a C statement

2015-06-12 Thread Vinod Koul
ported-by: Fernando Lopez-Lezcano > Signed-off-by: Sebastian Andrzej Siewior Acked-by: Vinod Koul -- ~Vinod > --- > * Mats Karrman | 2015-06-11 15:04:25 [+0200]: > > >>+ sst_shim_write64(shim, SST_IMRX, shim_regs->imrx): > >Don't you mean ';' and not

Re: [PATCH] ASoC: core: Pass kcontrol pointer to bytes tlv callbacks

2015-06-12 Thread Vinod Koul
ding, I need this is SKL driver.. Reviewed-by: Vinod Koul -- ~Vinod > --- > include/sound/soc.h | 6 -- > sound/soc/soc-ops.c | 4 ++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/include/sound/soc.h b/include/sound/soc.h > index fcb312b..404

Re: [PATCH 2/2] genalloc: rename of_get_named_gen_pool() to of_gen_pool_get()

2015-06-12 Thread Vinod Koul
y: Vladimir Zapolskiy > --- > drivers/dma/mmp_tdma.c | 2 +- For this: Acked-by: Vinod Koul -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http:/

Re: [RFT PATCH] dmaengine: Fix choppy sound because of unimplemented resume

2015-06-12 Thread Vinod Koul
On Wed, Jun 10, 2015 at 05:17:07PM +0900, Krzysztof Kozlowski wrote: > Some drivers implement only pause operation (no resuming). Example is > pl330 where pause is needed for getting residuum. pl330 does not support > resume operation, transfer must be stopped after pause. > > However for slaves t

Re: [PATCH 0/2] dmaengine: hdmac: Implement interleaved transfers support

2015-06-12 Thread Vinod Koul
On Wed, May 27, 2015 at 04:01:51PM +0200, Maxime Ripard wrote: > Hi everyone, > > This patchset implements the interleaved transfer capability found on > some AT91 SoCs. > > The hardware actually support a somewhat similar mode called > picture-in-picture, that allows to transfer a squared portio

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-06-12 Thread Vinod Koul
On Thu, Jun 04, 2015 at 06:58:06PM +0300, Peter Ujfalusi wrote: > Vinod, > > On 06/02/2015 03:55 PM, Vinod Koul wrote: > > On Fri, May 29, 2015 at 05:32:50PM +0300, Peter Ujfalusi wrote: > >> On 05/29/2015 01:18 PM, Vinod Koul wrote: > >>> On Fri, May

Re: [PATCH] dmaengine: fsl-edma: clear pending interrupts on initialization

2015-06-12 Thread Vinod Koul
On Sun, Jun 07, 2015 at 09:46:10PM +0200, Stefan Agner wrote: > Clear pending interrupts before requesting interrupts and move > interrupt initialization after channels have been initialized. > This avoids a NULL pointer dereference panic when using kexec > while DMA requests were running. Applied

[GIT PULL] slave dmaengine fixes

2015-06-14 Thread Vinod Koul
Hi Linus, Here are hopefully last set of fixes for 4.1. This time we have - fixing pause capability reporting on both dmaengine pause & resume support by Krzysztof - locking fix fir at_xdmac by Ludovic - slave configuration fix for at_xdmac by Ludovic The following changes since commit d4a4f75c

Re: [PATCH] ASoC: Intel: mrfld: simplify sst_fill_widget_module_info

2015-06-14 Thread Vinod Koul
tor out the common check for whether the initial part of > kctl->id.name (before the space) is identical to w->name. Acked-by: Vinod Koul -- ~Vinod > > Signed-off-by: Rasmus Villemoes > --- > sound/soc/intel/atom/sst-atom-controls.c | 20 >

Re: [PATCH RESEND 0/2] dmaengine: make transfers reusable

2015-06-17 Thread Vinod Koul
On Tue, May 26, 2015 at 11:06:32PM +0200, Robert Jarzmik wrote: > Hi Vinod and Maxime, > > This very same patch was already submitted in [1]. It enables the reuse of > transfers through their lifetime. I added to this serie the documentation > patch > Maxime has been commenting, as it is tighly l

Re: [PATCH v5 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support

2015-06-22 Thread Vinod Koul
On Tue, Jun 09, 2015 at 02:18:10PM +0530, Kedareswara rao Appana wrote: pls conform to the subsystem naming convention which git log on subsystem should have told you that it is dmaengine: xxx.. > This is the driver for the AXI Central Direct Memory Access (AXI > CDMA) core, which is a soft X

Re: [PATCH v7] dma: Add Xilinx AXI Direct Memory Access Engine driver support

2015-06-22 Thread Vinod Koul
On Tue, Jun 09, 2015 at 12:05:36PM +0530, Kedareswara rao Appana wrote: > This is the driver for the AXI Direct Memory Access (AXI DMA) > core, which is a soft Xilinx IP core that provides high- > bandwidth direct memory access between memory and AXI4-Stream > type target peripherals. > > Signed-o

Re: [PATCH 8/9] arm: twr-k70f120m: extend Freescale eDMA driver with ability to support Kinetis SoC

2015-06-24 Thread Vinod Koul
On Tue, Jun 23, 2015 at 11:19:46PM +0200, Paul Osmialowski wrote: > Surprisingly small amount of work was required in order to extend already > existing eDMA driver with the support for Kinetis SoC architecture. > > Note that is needed (which is denoted by > CONFIG_NEED_MACH_MEMORY_H) as it provi

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-06-24 Thread Vinod Koul
On Mon, Jun 22, 2015 at 02:31:00PM +0300, Peter Ujfalusi wrote: > On 06/12/2015 03:58 PM, Vinod Koul wrote: > > Sorry this slipped thru > > I was away for a week anyways ;) > > > Thinking about it again, I think we should coverge to two APIs and mark the > >

Re: [PATCH v2 3/5] dmaengine: mv_xor: add support for a38x command in descriptor mode

2015-06-08 Thread Vinod Koul
On Tue, May 26, 2015 at 03:07:34PM +0200, Maxime Ripard wrote: > From: Lior Amsalem > > The Marvell Armada 38x SoC introduce new features to the XOR engine, > especially the fact that the engine mode (MEMCPY/XOR/PQ/etc) can be part of > the descriptor and not set through the controller registers.

Re: [RFC Patch V1] ioatdma: Ignore IOAT devices under hotplug-capable PCI host bridge

2015-06-08 Thread Vinod Koul
On Tue, Jun 02, 2015 at 02:37:31PM +0800, Jiang Liu wrote: > Ccing Rafael, it's ACPI hotplug related. > > On 2015/6/2 14:36, Jiang Liu wrote: > > The dmaengine core assumes that async DMA devices will only be removed > > when they not used anymore, or it assumes dma_async_device_unregister() > > w

Re: [PATCH v2 1/3] dmaengine: at_xdmac: lock fixes

2015-06-08 Thread Vinod Koul
On Mon, Jun 08, 2015 at 10:33:14AM +0200, Ludovic Desroches wrote: > Using _bh variant for spin locks causes this kind of warning: > Starting logging: [ cut here ] > WARNING: CPU: 0 PID: 3 at /ssd_drive/linux/kernel/softirq.c:151 > __local_bh_enable_ip+0xe8/0xf4() > Modules

Re: [PATCH v2 2/3] dmaengine: at_xdmac: rework slave configuration part

2015-06-08 Thread Vinod Koul
On Mon, Jun 08, 2015 at 10:33:15AM +0200, Ludovic Desroches wrote: > Rework slave configuration part in order to more report wrong errors > about the configuration. > Only maxburst and addr width values are checked when doing the slave > configuration. The validity of the channel configuration is d

Re: [PATCH 09/11] dma: pl330: fix wording in mcbufsz message

2015-06-08 Thread Vinod Koul
On Wed, Jun 03, 2015 at 09:26:41PM +, Michal Suchanek wrote: > The kernel is not trying to increase mcbufsz. It suggests you should try > doing so. Also print the calculated required size of mcbufsz. pls use right subsystem name in the patches I have applied this now -- ~Vinod -- To unsubsc

Re: [RFT v2 11/48] ipu: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc

2015-06-08 Thread Vinod Koul
On Thu, Jun 04, 2015 at 12:13:21PM +0800, Jiang Liu wrote: > Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc while we > already have a pointer to corresponding irq_desc. > > Do the same thing to avoid pattern "irq_get_chip_data(data->irq)". And I am missing the context, it is a bad p

Re: [PATCH v6] dma: Add Xilinx AXI Direct Memory Access Engine driver support

2015-06-08 Thread Vinod Koul
On Wed, Jun 03, 2015 at 06:22:36AM +, Appana Durga Kedareswara Rao wrote: > Ping! ??? You seem to have a question from Paul pending on this and other patch posted and you have not replied to him, so these patches have been ignored the same way you seem to have ignore your reviewers -- ~Vinod

Re: [PATCH v6] dma: Add Xilinx AXI Direct Memory Access Engine driver support

2015-06-08 Thread Vinod Koul
On Mon, Jun 08, 2015 at 11:28:25AM +, Appana Durga Kedareswara Rao wrote: > Hi Vinod, > > > > -Original Message- > > From: Vinod Koul [mailto:vinod.k...@intel.com] > > Sent: Monday, June 08, 2015 4:44 PM > > To: Appana Durga Kedareswara Rao >

Re: [RFC Patch V1] ioatdma: Ignore IOAT devices under hotplug-capable PCI host bridge

2015-06-08 Thread Vinod Koul
On Mon, Jun 08, 2015 at 07:44:43PM +0800, Jiang Liu wrote: > On 2015/6/8 18:42, Vinod Koul wrote: > > On Tue, Jun 02, 2015 at 02:37:31PM +0800, Jiang Liu wrote: > >> Ccing Rafael, it's ACPI hotplug related. > >> > >> On 2015/6/2 14:36, Jiang Liu wrote: &g

Re: [PATCH v2 7/8] dmaengine: add a driver for Intel integrated DMA 64-bit

2015-06-02 Thread Vinod Koul
On Tue, May 26, 2015 at 09:49:57AM +0300, Andy Shevchenko wrote: > On Tue, May 26, 2015 at 7:06 AM, Vinod Koul wrote: > > On Mon, May 25, 2015 at 07:09:31PM +0300, Andy Shevchenko wrote: > >> Intel integrated DMA (iDMA) 64-bit is a specific IP that is used as a part > &g

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-06-02 Thread Vinod Koul
On Fri, May 29, 2015 at 05:32:50PM +0300, Peter Ujfalusi wrote: > On 05/29/2015 01:18 PM, Vinod Koul wrote: > > On Fri, May 29, 2015 at 11:42:27AM +0200, Geert Uytterhoeven wrote: > >> On Fri, May 29, 2015 at 11:33 AM, Vinod Koul wrote: > >>> On Tue, May 26, 2

Re: pl330 dma failure

2015-06-02 Thread Vinod Koul
On Sat, May 30, 2015 at 09:37:07PM +0200, Michal Suchanek wrote: > Hello, > > I was trying to read the SPI NOR flash and found that the pl330 > controller dma mysteriously fails. Adding Robert, > > There is the problem that the 256 bytes of dma program buffer does not > suffice for the whole of

Re: [PATCH v2] dmaengine: at_xdmac: rework slave configuration part

2015-06-02 Thread Vinod Koul
On Mon, Jun 01, 2015 at 05:40:48PM +0200, Ludovic Desroches wrote: > @@ -604,16 +636,18 @@ at_xdmac_prep_slave_sg(struct dma_chan *chan, struct > scatterlist *sgl, > return NULL; > } > > + if (at_xdmac_compute_chan_conf(chan, direction)) > +

Re: [PATCH] dmaengine: fix kernel-doc documentation

2015-06-02 Thread Vinod Koul
On Mon, Jun 01, 2015 at 11:53:43PM +0200, Stefan Agner wrote: > Fix function names in kernel-doc function comments. > Applied, thanks -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] dmaengine: xgene-dma: Fix "incorrect type in assignement" warnings

2015-06-02 Thread Vinod Koul
On Tue, Jun 02, 2015 at 02:33:33PM +0530, Rameshwar Prasad Sahu wrote: > This patch fixes sparse warnings like incorrect type in assignment > (different base types), cast to restricted __le64. > I am appliying this but ideally you should have split thsi into seprate patches for each fix -- ~Vino

Re: [PATCH 1/2] dmaengine: at_xdmac: lock fixes

2015-06-04 Thread Vinod Koul
On Wed, Jun 03, 2015 at 04:52:26PM +0200, Ludovic Desroches wrote: > Using _bh variant for spin locks causes this kind of warning: > Starting logging: [ cut here ] > WARNING: CPU: 0 PID: 3 at /ssd_drive/linux/kernel/softirq.c:151 > __local_bh_enable_ip+0xe8/0xf4() > Modules

Re: [PATCH 1/2] dmaengine: at_xdmac: lock fixes

2015-06-04 Thread Vinod Koul
On Thu, Jun 04, 2015 at 05:09:46PM +0200, Ludovic Desroches wrote: > > > @@ -591,11 +592,13 @@ at_xdmac_prep_slave_sg(struct dma_chan *chan, > > > struct scatterlist *sgl, > > > unsigned int sg_len, enum dma_transfer_direction > > > direction, > > > unsigned long

[PULL REQUEST] slave dmaengine fixes

2015-06-04 Thread Vinod Koul
Hey Linus, We have two small fixes on driver, please consider pulling them to receive fixes for: - pl330 termination hang fix by Krzysztof - hsu memory leak fix by Peter The following changes since commit 5ebe6afaf0057ac3eaeb98defd5456894b446d22: Linux 4.1-rc2 (2015-05-03 19:22:23 -0700) are

Re: [PATCH v2 3/5] dmaengine: mv_xor: add support for a38x command in descriptor mode

2015-06-10 Thread Vinod Koul
On Mon, Jun 08, 2015 at 10:53:51PM +0200, Maxime Ripard wrote: > Hi Vinod, > > On Mon, Jun 08, 2015 at 04:04:47PM +0530, Vinod Koul wrote: > > On Tue, May 26, 2015 at 03:07:34PM +0200, Maxime Ripard wrote: > > > From: Lior Amsalem > > > > > > The Marvel

Re: [PATCH v2 0/5] dmaengine: mv_xor: Fixes and enhancements

2015-06-10 Thread Vinod Koul
On Tue, May 26, 2015 at 03:07:31PM +0200, Maxime Ripard wrote: > Hi, > > This serie is about various fixes and enhancements that were > previously submitted as part of the "ARM: mvebu: Add support for RAID6 > PQ offloading" serie. > > Seems the RAID6 PQ stuff seems more controversial than what I

Re: [PATCH v5 2/3] dmaengine: mediatek: Add MediaTek High-Speed DMA controller for MT7622 and MT7623 SoC

2018-03-01 Thread Vinod Koul
On Sun, Feb 18, 2018 at 03:08:30AM +0800, sean.w...@mediatek.com wrote: > @@ -0,0 +1,1054 @@ > +// SPDX-License-Identifier: GPL-2.0 // Copyright ... The copyright line needs to follow SPDX tag line > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#inc

Re: [PATCH v3 0/5] dmaengine: qcom: bam_dma: fixes for remotely controlled bam

2018-03-01 Thread Vinod Koul
On Thu, Feb 15, 2018 at 12:25:06PM +, srinivas.kandaga...@linaro.org wrote: > From: Srinivas Kandagatla > > Hi Andy, > > I did hit few issues while trying out SLIMBus BAM on DB820c, this BAM instance > is remotely controlled and powered up after ADSP is booted using QMI commands. > > Firstl

Re: [PATCH v5 2/3] dmaengine: mediatek: Add MediaTek High-Speed DMA controller for MT7622 and MT7623 SoC

2018-03-01 Thread Vinod Koul
On Thu, Mar 01, 2018 at 06:27:01PM +0800, Sean Wang wrote: > On Thu, 2018-03-01 at 13:53 +0530, Vinod Koul wrote: > > On Sun, Feb 18, 2018 at 03:08:30AM +0800, sean.w...@mediatek.com wrote: > > > > > @@ -0,0 +1,1054 @@ > > > +// SPDX-License-Identifier: GPL-2.0

Re: [PATCH] dmaengine: rcar-dmac: Fix too early/late system suspend/resume callbacks

2018-04-03 Thread Vinod Koul
On Thu, Mar 29, 2018 at 06:53:32PM +0200, Geert Uytterhoeven wrote: > If serial console wake-up is enabled ("echo enabled > > /sys/.../ttySC0/power/wakeup"), and any serial input is received while > the system is suspended, serial port input no longer works after system > resume. > > Note that: >

Re: [PATCH 1/1] dmaengine:jz4740:fix memory leak

2018-04-03 Thread Vinod Koul
On Wed, Apr 04, 2018 at 11:21:58AM +0800, Xidong Wang wrote: > In function jz4740_dma_probe(), the memory allocated by > clk_get() is not released on the error path that ret, which holds > the return value of dma_async_device_register(), is not NULL. > This will result in a memory leak bug. I dont

Re: [PATCH v1 0/8] Append several fixes and improvements in STM32 DMA

2018-04-03 Thread Vinod Koul
On Tue, Mar 13, 2018 at 05:41:59PM +0100, Pierre-Yves MORDRET wrote: > This patchset appends several fixes and some improvements for STM32 DMAv2. > This includes: > * Introduce DMA features bitfield > * Threshold manages with bitfield feature > * Improve memory burst managem

Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-04-26 Thread Vinod Koul
On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote: > Request IRQ with IRQF_SHARED flag. This works since the interrupt > handler already checks if there is an actual IRQ pending and returns > IRQ_NONE otherwise. hmmm what are we trying to fix here? Is your device on a shared line or n

Re: [PATCH v2 4/5] dmaengine: sprd: Add Spreadtrum DMA configuration

2018-04-26 Thread Vinod Koul
On Thu, Apr 19, 2018 at 10:00:49AM +0800, Baolin Wang wrote: > +/* > + * struct sprd_dma_config - DMA configuration structure > + * @src_addr: the physical address where DMA slave data should be read > + * @dst_addr: the physical address where DMA slave data should be written > + * @fragment_len:

Re: [PATCH v2 1/5] dmaengine: sprd: Define the DMA transfer step type

2018-04-26 Thread Vinod Koul
On Thu, Apr 19, 2018 at 10:00:46AM +0800, Baolin Wang wrote: > From: Eric Long > > Define the DMA transfer step type to make code more readable. Applied this one, thanks -- ~Vinod

Re: [PATCH v2 2/5] dmaengine: sprd: Define the DMA data width type

2018-04-26 Thread Vinod Koul
On Thu, Apr 19, 2018 at 10:00:47AM +0800, Baolin Wang wrote: > Define the DMA data width type to make code more readable. Applied this one, thanks -- ~Vinod

Re: [PATCH v2 3/5] dmaengine: sprd: Move DMA request mode and interrupt type into head file

2018-04-26 Thread Vinod Koul
On Thu, Apr 19, 2018 at 10:00:48AM +0800, Baolin Wang wrote: > From: Eric Long > > This patch will move the Spreadtrum DMA request mode and interrupt type > into one head file for user to configure. Applied this one, thanks -- ~Vinod

Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-04-27 Thread Vinod Koul
On Fri, Apr 27, 2018 at 08:53:39AM +0200, Lars-Peter Clausen wrote: > On 04/27/2018 07:11 AM, Vinod Koul wrote: > > On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote: > >> Request IRQ with IRQF_SHARED flag. This works since the interrupt > >> handler al

Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-04-27 Thread Vinod Koul
On Fri, Apr 27, 2018 at 05:18:29PM +0200, Lars-Peter Clausen wrote: > On 04/27/2018 05:15 PM, Moritz Fischer wrote: > > Hi Vinod, > > > > On Fri, Apr 27, 2018 at 12:08 AM, Vinod Koul wrote: > >> On Fri, Apr 27, 2018 at 08:53:39AM +0200, Lars-Peter Clausen wrote

Re: [PATCH] dmaengine: stm32-mdma: fix spelling mistake: "avalaible" -> "available"

2018-04-27 Thread Vinod Koul
On Fri, Apr 27, 2018 at 08:24:31PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err error message text Applied, thanks -- ~Vinod

Re: [PATCH][V2] dmaengine: stm32-mdma: fix spelling mistake: "avalaible" -> "available"

2018-05-01 Thread Vinod Koul
On Sat, Apr 28, 2018 at 11:03:52PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err error message text and make > channel plural. Applied, thanks -- ~Vinod

Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

2018-05-01 Thread Vinod Koul
On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote: > This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > > The pl330.c pause implementation violates the dmaengine requirement > for no data loss, since it relies on the DMAKILL > instruction. However, DMAKILL discards in-f

Re: [PATCH v3] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-05-01 Thread Vinod Koul
On Sat, Apr 28, 2018 at 12:57:54PM -0700, Moritz Fischer wrote: > Request IRQ with IRQF_SHARED flag to enable setups with multiple > instances of the core sharing a single IRQ line. > This works out since the IRQ handler already checks if there is > an actual IRQ pending and returns IRQ_NONE otherw

Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

2018-05-03 Thread Vinod Koul
On Wed, May 02, 2018 at 10:37:09AM -0400, Frank Mori Hess wrote: > On Wed, May 2, 2018 at 12:32 AM, Vinod Koul wrote: > > On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote: > >> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > >> > &

Re: [PATCH V4 1/2] dmaengine: sprd: Optimize the sprd_dma_prep_dma_memcpy()

2018-05-28 Thread Vinod Koul
On 23-05-18, 17:31, Baolin Wang wrote: > From: Eric Long > > This is one preparation patch, we can use default DMA configuration to > implement the device_prep_dma_memcpy() interface instead of issuing > sprd_dma_config(). > > We will implement one new sprd_dma_config() function with introducing

Re: [PATCH] time: Fix sleeptime injection for non-stop clocksource & persistent clock

2018-05-29 Thread Vinod Koul
On 29-05-18, 13:45, Mukesh Ojha wrote: > Currently, for both non-stop clocksource and persistent clock > there is a corner case, when a driver failed to go suspend mode > rtc_resume injects the sleeptime as timekeeping_rtc_skipresume > returned 'false' due to which we can see mismatch in time with

<    5   6   7   8   9   10   11   12   13   14   >