Re: Backport request to stable of two performance related fixes for xen-blkfront (3.13 fixes to earlier trees)

2014-06-06 Thread Vitaly Kuznetsov
Jiri Slaby jsl...@suse.cz writes: On 06/04/2014 07:48 AM, Greg KH wrote: On Wed, May 14, 2014 at 03:11:22PM -0400, Konrad Rzeszutek Wilk wrote: Hey Greg This email is in regards to backporting two patches to stable that fall under the 'performance' rule:

Re: [Xen-devel] Backport request to stable of two performance related fixes for xen-blkfront (3.13 fixes to earlier trees)

2014-06-10 Thread Vitaly Kuznetsov
Vitaly Kuznetsov vkuzn...@redhat.com writes: Jiri Slaby jsl...@suse.cz writes: On 06/04/2014 07:48 AM, Greg KH wrote: On Wed, May 14, 2014 at 03:11:22PM -0400, Konrad Rzeszutek Wilk wrote: Hey Greg This email is in regards to backporting two patches to stable that fall under

Re: [Xen-devel] Backport request to stable of two performance related fixes for xen-blkfront (3.13 fixes to earlier trees)

2014-06-12 Thread Vitaly Kuznetsov
Roger Pau Monné roger@citrix.com writes: On 10/06/14 15:19, Vitaly Kuznetsov wrote: Vitaly Kuznetsov vkuzn...@redhat.com writes: Jiri Slaby jsl...@suse.cz writes: On 06/04/2014 07:48 AM, Greg KH wrote: On Wed, May 14, 2014 at 03:11:22PM -0400, Konrad Rzeszutek Wilk wrote: Hey Greg

Re: [Xen-devel] Backport request to stable of two performance related fixes for xen-blkfront (3.13 fixes to earlier trees)

2014-06-12 Thread Vitaly Kuznetsov
a difference between our test environments. You could also test Ubuntu Sancy guests with and without the patched kernels provided by Joseph Salisbury on launchpad: https://bugs.launchpad.net/bugs/1319003 Thanks, Felipe -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn

[PATCH] xenpv: don't BUG when failing to setup NMI callback

2014-06-13 Thread Vitaly Kuznetsov
: 26b0 (XEN) cr3: 00013a263000 cr2: (XEN) ds: es: fs: gs: ss: e02b cs: e033 ... However it is possible to proceed without NMI callback registered. Change BUG() with warning in case of -EINVAL. Signed-off-by: Vitaly Kuznetsov vkuzn

Re: [PATCH] xenpv: don't BUG when failing to setup NMI callback

2014-06-13 Thread Vitaly Kuznetsov
Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Fri, Jun 13, 2014 at 01:26:28PM +0200, Vitaly Kuznetsov wrote: some old Xen hypervisors (prior to 3.2) forbid DomUs to register NMI callbacks. E.g. we have the following code in xen-3.1: if ( (d-domain_id != 0) || (v-vcpu_id != 0

Re: [Xen-devel] Backport request to stable of two performance related fixes for xen-blkfront (3.13 fixes to earlier trees)

2014-05-20 Thread Vitaly Kuznetsov
Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: Hey Greg This email is in regards to backporting two patches to stable that fall under the 'performance' rule: bfe11d6de1c416cea4f3f0f35f864162063ce3fa fbe363c476afe8ec992d3baf682670a4bd1b6ce6 I've copied Jerry - the maintainer of

Re: [Xen-devel] Backport request to stable of two performance related fixes for xen-blkfront (3.13 fixes to earlier trees)

2014-05-20 Thread Vitaly Kuznetsov
Vitaly Kuznetsov vkuzn...@redhat.com writes: 1) ramdisks (/dev/ram*) (persistent grants and indirect descriptors disabled) sorry, there was a typo. persistent grants and indirect descriptors are enabled with ramdisks, otherwise such testing won't make any sense. 2) /tmp/img*.img on tmpfs

Re: [Xen-devel] Backport request to stable of two performance related fixes for xen-blkfront (3.13 fixes to earlier trees)

2014-05-20 Thread Vitaly Kuznetsov
Roger Pau Monné roger@citrix.com writes: On 20/05/14 11:54, Vitaly Kuznetsov wrote: Vitaly Kuznetsov vkuzn...@redhat.com writes: 1) ramdisks (/dev/ram*) (persistent grants and indirect descriptors disabled) sorry, there was a typo. persistent grants and indirect descriptors

Re: [Xen-devel] Backport request to stable of two performance related fixes for xen-blkfront (3.13 fixes to earlier trees)

2014-05-22 Thread Vitaly Kuznetsov
-Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: 20 May 2014 12:41 To: Roger Pau Monne Cc: Konrad Rzeszutek Wilk; ax...@kernel.dk; Felipe Franciosi; gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; sta...@vger.kernel.org; jerry.snitsel...@oracle.com

[PATCH v2] xenpv: don't BUG when failing to setup NMI callback

2014-06-16 Thread Vitaly Kuznetsov
() when running under Xen 3.2 - never BUG() in xen_enable_nmi() Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- arch/x86/xen/enlighten.c | 9 + arch/x86/xen/setup.c | 17 ++--- 2 files changed, 19 insertions(+), 7 deletions(-) diff --git a/arch/x86/xen/enlighten.c b

Re: [Xen-devel] [PATCH] mmap_vmcore: skip non-ram pages reported by hypervisors

2014-07-09 Thread Vitaly Kuznetsov
David Vrabel david.vra...@citrix.com writes: On 07/07/14 21:33, Andrew Morton wrote: On Mon, 7 Jul 2014 17:05:49 +0200 Vitaly Kuznetsov vkuzn...@redhat.com wrote: we have a special check in read_vmcore() handler to check if the page was reported as ram or not by the hypervisor

Re: [Xen-devel] [PATCH] mmap_vmcore: skip non-ram pages reported by hypervisors

2014-07-09 Thread Vitaly Kuznetsov
Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Mon, Jul 07, 2014 at 05:05:49PM +0200, Vitaly Kuznetsov wrote: we have a special check in read_vmcore() handler to check if the page was reported as ram or not by the hypervisor (pfn_is_ram()). However, when vmcore is read with mmap

Re: [PATCH] mmap_vmcore: skip non-ram pages reported by hypervisors

2014-07-09 Thread Vitaly Kuznetsov
Vivek Goyal vgo...@redhat.com writes: On Mon, Jul 07, 2014 at 05:05:49PM +0200, Vitaly Kuznetsov wrote: we have a special check in read_vmcore() handler to check if the page was reported as ram or not by the hypervisor (pfn_is_ram()). I am wondering if this name pfn_is_ram() appropriate

[PATCH v2] mmap_vmcore: skip non-ram pages reported by hypervisors

2014-07-09 Thread Vitaly Kuznetsov
of new offset Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com Reviewed-by: Andrew Jones drjo...@redhat.com --- fs/proc/vmcore.c | 89 1 file changed, 84 insertions(+), 5 deletions(-) diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c

[PATCH v3] mmap_vmcore: skip non-ram pages reported by hypervisors

2014-07-10 Thread Vitaly Kuznetsov
-by: Vitaly Kuznetsov vkuzn...@redhat.com Reviewed-by: Andrew Jones drjo...@redhat.com --- fs/proc/vmcore.c | 82 +--- 1 file changed, 79 insertions(+), 3 deletions(-) diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index 382aa89..66dac43 100644

[PATCH v4] mmap_vmcore: skip non-ram pages reported by hypervisors

2014-07-11 Thread Vitaly Kuznetsov
() for the zero page - return remapped length instead of new offset Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com Reviewed-by: Andrew Jones drjo...@redhat.com --- fs/proc/vmcore.c | 83 ++-- 1 file changed, 80 insertions(+), 3 deletions

[PATCH] mmap_vmcore: skip non-ram pages reported by hypervisors

2014-07-07 Thread Vitaly Kuznetsov
. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- fs/proc/vmcore.c | 68 +++- 1 file changed, 62 insertions(+), 6 deletions(-) diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index 382aa89..2716e19 100644 --- a/fs/proc/vmcore.c +++ b/fs/proc

Re: [PATCH] mmap_vmcore: skip non-ram pages reported by hypervisors

2014-07-08 Thread Vitaly Kuznetsov
Andrew Morton a...@linux-foundation.org writes: On Mon, 7 Jul 2014 17:05:49 +0200 Vitaly Kuznetsov vkuzn...@redhat.com wrote: we have a special check in read_vmcore() handler to check if the page was reported as ram or not by the hypervisor (pfn_is_ram()). However, when vmcore is read

[PATCH v5] mmap_vmcore: skip non-ram pages reported by hypervisors

2014-07-14 Thread Vitaly Kuznetsov
the remap_oldmem_pfn() interface - preserve formal parameters within the loop, make the loop conditions easier to understand - use my_zero_pfn() for the zero page - return remapped length instead of new offset Reviewed-by: Andrew Jones drjo...@redhat.com Signed-off-by: Vitaly Kuznetsov vkuzn

Re: [PATCH v5] mmap_vmcore: skip non-ram pages reported by hypervisors

2014-07-14 Thread Vitaly Kuznetsov
HATAYAMA, Daisuke d.hatay...@jp.fujitsu.com writes: (2014/07/14 18:16), Vitaly Kuznetsov wrote: We have a special check in read_vmcore() handler to check if the page was reported as ram or not by the hypervisor (pfn_is_ram()). However, when vmcore is read with mmap() no such check

[PATCH v6] mmap_vmcore: skip non-ram pages reported by hypervisors

2014-07-14 Thread Vitaly Kuznetsov
drjo...@redhat.com Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- fs/proc/vmcore.c | 83 ++-- 1 file changed, 80 insertions(+), 3 deletions(-) diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index 382aa89..fa45923 100644 --- a/fs/proc

[PATCH RFC 4/4] xen/pvhvm: Make MSI IRQs work after kexec

2014-07-15 Thread Vitaly Kuznetsov
. We're loosing existing PIRQ and I'm also not sure when __write_msi_msg() with new PIRQ will result in new mapping. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- arch/x86/pci/xen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/pci/xen.c b/arch/x86/pci

[PATCH RFC 0/4] xen/pvhvm: fix shared_info and pirq issues with kexec

2014-07-15 Thread Vitaly Kuznetsov
Vitaly Kuznetsov (3): xen/pvhvm: Introduce xen_pvhvm_kexec_shutdown() xen/pvhvm: Unmap all PIRQs on startup and shutdown xen/pvhvm: Make MSI IRQs work after kexec arch/x86/pci/xen.c | 3 +- arch/x86/xen/enlighten.c | 83 +++- arch/x86/xen

[PATCH RFC 1/4] xen PVonHVM: use E820_Reserved area for shared_info

2014-07-15 Thread Vitaly Kuznetsov
did not do] Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- arch/x86/xen/enlighten.c | 74 arch/x86/xen/suspend.c | 2 +- arch/x86/xen/xen-ops.h | 2 +- 3 files changed, 58 insertions(+), 20 deletions(-) diff --git a/arch/x86/xen

[PATCH RFC 2/4] xen/pvhvm: Introduce xen_pvhvm_kexec_shutdown()

2014-07-15 Thread Vitaly Kuznetsov
PVHVM guest requires special actions before kexec. Register specific xen_pvhvm_kexec_shutdown() handler for machine_ops.shutdown(). Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- arch/x86/xen/enlighten.c | 9 + arch/x86/xen/smp.c | 9 + arch/x86/xen/smp.h | 1

[PATCH RFC 3/4] xen/pvhvm: Unmap all PIRQs on startup and shutdown

2014-07-15 Thread Vitaly Kuznetsov
; - shutdown-time unmapping is required to make Qemu-emulated NICs work after kexec (event channel is being closed on shutdown but no PHYSDEVOP_unmap_pirq is being performed). Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- arch/x86/xen/smp.c | 1 + drivers/xen/events

[PATCH v7] mmap_vmcore: skip non-ram pages reported by hypervisors

2014-07-15 Thread Vitaly Kuznetsov
() for the zero page - return remapped length instead of new offset Reviewed-by: Andrew Jones drjo...@redhat.com Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- fs/proc/vmcore.c | 82 +--- 1 file changed, 79 insertions(+), 3 deletions(-) diff

Re: [PATCH RFC 1/4] xen PVonHVM: use E820_Reserved area for shared_info

2014-07-15 Thread Vitaly Kuznetsov
Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Tue, Jul 15, 2014 at 03:40:37PM +0200, Vitaly Kuznetsov wrote: From: Olaf Hering o...@aepfle.de This is a respin of 00e37bdb0113a98408de42db85be002f21dbffd3 (xen PVonHVM: move shared_info to MMIO before kexec). Currently kexec

Re: [PATCH RFC 2/4] xen/pvhvm: Introduce xen_pvhvm_kexec_shutdown()

2014-07-15 Thread Vitaly Kuznetsov
Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Tue, Jul 15, 2014 at 03:40:38PM +0200, Vitaly Kuznetsov wrote: PVHVM guest requires special actions before kexec. Register specific xen_pvhvm_kexec_shutdown() handler for machine_ops.shutdown(). This looks close to what I had sent

Re: [PATCH RFC 3/4] xen/pvhvm: Unmap all PIRQs on startup and shutdown

2014-07-29 Thread Vitaly Kuznetsov
David Vrabel david.vra...@citrix.com writes: On 15/07/14 14:40, Vitaly Kuznetsov wrote: When kexec is being run PIRQs from Qemu-emulated devices are still mapped to old event channels and new kernel has no information about that. Trying to map them twice results in the following in Xen's

Re: [Xen-devel] [PATCH RFC 3/4] xen/pvhvm: Unmap all PIRQs on startup and shutdown

2014-07-29 Thread Vitaly Kuznetsov
David Vrabel david.vra...@citrix.com writes: On 29/07/14 14:50, Vitaly Kuznetsov wrote: David Vrabel david.vra...@citrix.com writes: On 15/07/14 14:40, Vitaly Kuznetsov wrote: When kexec is being run PIRQs from Qemu-emulated devices are still mapped to old event channels and new kernel has

Re: [PATCH RFC 4/4] xen/pvhvm: Make MSI IRQs work after kexec

2014-07-16 Thread Vitaly Kuznetsov
Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Tue, Jul 15, 2014 at 03:40:40PM +0200, Vitaly Kuznetsov wrote: When kexec was peformed MSI IRQs for passthrough-ed devices were already mapped and we see non-zero pirq extracted from MSI msg. xen_irq_from_pirq() fails as we have no IRQ

Re: [PATCH RFC 3/4] xen/pvhvm: Unmap all PIRQs on startup and shutdown

2014-07-16 Thread Vitaly Kuznetsov
Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Tue, Jul 15, 2014 at 03:40:39PM +0200, Vitaly Kuznetsov wrote: When kexec is being run PIRQs from Qemu-emulated devices are still mapped to old event channels and new kernel has no information about that. Trying to map them twice results

Re: [PATCH RFC 3/4] xen/pvhvm: Unmap all PIRQs on startup and shutdown

2014-07-16 Thread Vitaly Kuznetsov
Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Wed, Jul 16, 2014 at 11:37:10AM +0200, Vitaly Kuznetsov wrote: Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Tue, Jul 15, 2014 at 03:40:39PM +0200, Vitaly Kuznetsov wrote: When kexec is being run PIRQs from Qemu-emulated

Re: [PATCH RFC 4/4] xen/pvhvm: Make MSI IRQs work after kexec

2014-07-16 Thread Vitaly Kuznetsov
Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Wed, Jul 16, 2014 at 11:01:55AM +0200, Vitaly Kuznetsov wrote: Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Tue, Jul 15, 2014 at 03:40:40PM +0200, Vitaly Kuznetsov wrote: When kexec was peformed MSI IRQs for passthrough-ed

Re: [PATCH RFC 4/4] xen/pvhvm: Make MSI IRQs work after kexec

2014-07-17 Thread Vitaly Kuznetsov
Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Wed, Jul 16, 2014 at 07:20:39PM +0200, Vitaly Kuznetsov wrote: Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Wed, Jul 16, 2014 at 11:01:55AM +0200, Vitaly Kuznetsov wrote: Konrad Rzeszutek Wilk konrad.w...@oracle.com writes

[PATCH v8] mmap_vmcore: skip non-ram pages reported by hypervisors

2014-07-17 Thread Vitaly Kuznetsov
the remap_oldmem_pfn() interface - preserve formal parameters within the loop, make the loop conditions easier to understand - use my_zero_pfn() for the zero page - return remapped length instead of new offset Reviewed-by: Andrew Jones drjo...@redhat.com Signed-off-by: Vitaly Kuznetsov vkuzn

Re: [PATCH RFC 1/4] xen PVonHVM: use E820_Reserved area for shared_info

2014-07-18 Thread Vitaly Kuznetsov
Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Tue, Jul 15, 2014 at 05:43:17PM +0200, Vitaly Kuznetsov wrote: Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Tue, Jul 15, 2014 at 03:40:37PM +0200, Vitaly Kuznetsov wrote: From: Olaf Hering o...@aepfle.de

Re: [PATCH RFC 1/4] xen PVonHVM: use E820_Reserved area for shared_info

2014-07-18 Thread Vitaly Kuznetsov
Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Fri, Jul 18, 2014 at 01:05:46PM +0200, Vitaly Kuznetsov wrote: Konrad Rzeszutek Wilk konrad.w...@oracle.com writes: On Tue, Jul 15, 2014 at 05:43:17PM +0200, Vitaly Kuznetsov wrote: Konrad Rzeszutek Wilk konrad.w...@oracle.com writes

Re: [PATCH RFC 0/4] xen/pvhvm: fix shared_info and pirq issues with kexec

2014-08-01 Thread Vitaly Kuznetsov
David Vrabel david.vra...@citrix.com writes: On 15/07/14 14:40, Vitaly Kuznetsov wrote: With this patch series I'm trying to address several issues with kexec on pvhvm: - shared_info issue (1st patch, just sending Olaf's work with Konrad's fix) - create specific pvhvm shutdown handler

Re: [PATCH RFC 0/4] xen/pvhvm: fix shared_info and pirq issues with kexec

2014-08-04 Thread Vitaly Kuznetsov
David Vrabel david.vra...@citrix.com writes: On 01/08/14 13:21, Vitaly Kuznetsov wrote: David Vrabel david.vra...@citrix.com writes: On 15/07/14 14:40, Vitaly Kuznetsov wrote: With this patch series I'm trying to address several issues with kexec on pvhvm: - shared_info issue (1st patch

[PATCH] Drivers: hv: util: make struct hv_do_fcopy match Hyper-V host messages

2014-10-24 Thread Vitaly Kuznetsov
the structure packed and add padding to match re reality. Tested both i586 and x86_64 on Hyper-V Server 2012 R2. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- include/uapi/linux/hyperv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/hyperv.h b/include/uapi/linux

[PATCH] tools: hv: introduce -n/--no-daemon option

2014-10-22 Thread Vitaly Kuznetsov
in foreground for that. Some distros already carry distro-specific patch for hv tools which switches off daemon(). Introduce -n/--no-daemon option for all 3 daemons in hv/tools. Parse options with getopt() to make this part easily expandable. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- tools/hv

[PATCH] xen/blkback: unmap all persistent grants when frontend gets disconnected

2014-09-08 Thread Vitaly Kuznetsov
, reconnect works fine. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- drivers/block/xen-blkback/xenbus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 3a8b810..54f4089 100644 --- a/drivers

[PATCH] xen/blkfront: improve protection against issuing unsupported REQ_FUA

2014-10-27 Thread Vitaly Kuznetsov
issues. This patch is based on the original patch by Laszlo Ersek and a comment by Jeff Moyer. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- drivers/block/xen-blkfront.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/block/xen-blkfront.c b

Re: [PATCH] tools: hv: ignore ENOBUFS in the KVP daemon

2014-11-19 Thread Vitaly Kuznetsov
Dexuan Cui de...@microsoft.com writes: Under high memory pressure and very high KVP R/W test pressure, the netlink recvfrom() may transiently return ENOBUFS to the daemon -- we found this during a 2-week stress test. We'd better not terminate the daemon on this failure, because a typical KVP

Re: [PATCH] tools: hv: ignore ENOBUFS in the KVP daemon

2014-11-19 Thread Vitaly Kuznetsov
Dexuan Cui de...@microsoft.com writes: -Original Message- From: Vitaly Kuznetsov Sent: Wednesday, November 19, 2014 18:50 PM To: Dexuan Cui Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev- de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com

Re: [PATCH] tools: hv: ignore ENOBUFS in the KVP daemon

2014-11-19 Thread Vitaly Kuznetsov
Dexuan Cui de...@microsoft.com writes: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Wednesday, November 19, 2014 20:41 PM To: Dexuan Cui Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev- de...@linuxdriverproject.org; o

Re: [PATCH] tools: hv: ignore ENOBUFS in the KVP daemon

2014-11-19 Thread Vitaly Kuznetsov
Dexuan Cui de...@microsoft.com writes: -Original Message- From: Vitaly Kuznetsov -- Vitaly OK, I can add this new check: (I'll send out the v2 tomorrow in case people have new comments) Thanks! --- a/tools/hv/hv_kvp_daemon.c +++ b/tools/hv/hv_kvp_daemon.c

Re: [PATCH v2] tools: hv: ignore ENOBUFS and ENOMEM in the KVP daemon

2014-11-20 Thread Vitaly Kuznetsov
user will re-try the R/W and hopefully it will succeed next time. We can also ignore the errors on sending. Cc: Vitaly Kuznetsov vkuzn...@redhat.com Cc: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Dexuan Cui de...@microsoft.com --- v2: I also ignore the errors on sending, as Vitaly

Re: [PATCH 0/3] Tools: hv: vssdaemon: freeze/thaw logic improvement for the failure case

2014-11-10 Thread Vitaly Kuznetsov
Dexuan Cui de...@microsoft.com writes: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Saturday, November 8, 2014 1:09 AM To: KY Srinivasan; Haiyang Zhang; Greg Kroah-Hartman Cc: de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; Dexuan Cui

[PATCH v2 0/2] Tools: hv: vssdaemon: freeze/thaw logic improvement for the failure case

2014-11-10 Thread Vitaly Kuznetsov
of freeze was thrown away as Dexuan's Tools: hv: vssdaemon: ignore the EBUSY on multiple freezing the same partition contains the same change; - Tools: hv: vssdaemon: consult with errno in case of failure only was replaced with Tools: hv: vssdaemon: report freeze errors. Vitaly Kuznetsov (2

[PATCH v2 2/2] Tools: hv: vssdaemon: skip all filesystems mounted readonly

2014-11-10 Thread Vitaly Kuznetsov
Instead of making a list of exceptions for readonly filesystems in addition to iso9660 we already have it is better to skip freeze operation for all readonly-mounted filesystems. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- tools/hv/hv_vss_daemon.c | 2 +- 1 file changed, 1 insertion

[PATCH v2 1/2] Tools: hv: vssdaemon: report freeze errors

2014-11-10 Thread Vitaly Kuznetsov
during freezing of '/' as it usually results in SEGSEGV. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- tools/hv/hv_vss_daemon.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c index b720d8f..ee44f0d

Re: [PATCH] hv: hv_fcopy: drop the obsolete message on transfer failure

2014-11-12 Thread Vitaly Kuznetsov
. Srinivasan k...@microsoft.com Signed-off-by: Dexuan Cui de...@microsoft.com Reviewed-by: Vitaly Kuznetsov vkuzn...@redhat.com --- drivers/hv/hv_fcopy.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/hv/hv_fcopy.c b/drivers/hv/hv_fcopy.c index 23b2ce2..177122a 100644

Re: [PATCH] xen/blkfront: improve protection against issuing unsupported REQ_FUA

2014-11-03 Thread Vitaly Kuznetsov
Boris Ostrovsky boris.ostrov...@oracle.com writes: On 11/03/2014 07:22 AM, Laszlo Ersek wrote: On 10/27/14 14:44, Vitaly Kuznetsov wrote: Guard against issuing unsupported REQ_FUA and REQ_FLUSH was introduced in d11e61583 and was factored out into blkif_request_flush_valid() in 0f1ca65ee

[PATCH] Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors

2014-11-26 Thread Vitaly Kuznetsov
on resume). Suspend still works. Tested with WS2008R2 and WS2012R2. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- drivers/hv/vmbus_drv.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 4d6b269..9a82249 100644

Re: [PATCH] Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors

2014-11-27 Thread Vitaly Kuznetsov
Dexuan Cui de...@microsoft.com writes: -Original Message- From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf Of Greg Kroah-Hartman Sent: Thursday, November 27, 2014 11:03 AM To: Vitaly Kuznetsov Cc: de...@linuxdriverproject.org; Haiyang Zhang; linux- ker

[PATCH 1/2] Drivers: hv: vss: Introduce timeout for communication with userspace

2014-11-06 Thread Vitaly Kuznetsov
schedule_delayed_work(). Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- drivers/hv/hv_snapshot.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/hv/hv_snapshot.c b/drivers/hv/hv_snapshot.c index 34f14fd..21e51be 100644 --- a/drivers/hv/hv_snapshot.c +++ b

[PATCH 0/2] Drivers: hv: kvp,vss: improve kernel-userspace communication in failure case

2014-11-06 Thread Vitaly Kuznetsov
discussing. In theory freeze/thaw ioctls should be fast. In case someone thinks 10 seconds is not enough we can easily increase it as we cover the most common failure scenario (when the daemon was stopped) with the second patch of this series. Vitaly Kuznetsov (2): Drivers: hv: vss: Introduce

[PATCH 2/2] Drivers: hv: kvp,vss: Fast propagation of userspace communication failure

2014-11-06 Thread Vitaly Kuznetsov
userspace daemon gets disconnected so we won't receive new requests. But I'm not sure it is possible. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- drivers/hv/hv_kvp.c | 9 - drivers/hv/hv_snapshot.c | 8 +++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git

[PATCH 3/3] Tools: hv: vssdaemon: thaw everything in case of freeze failure

2014-11-07 Thread Vitaly Kuznetsov
freeze/thaw requests at the same time they will collide with vss daemon. This issue can be addressed by introducing a freeze/thaw transaction and keeping track of what was actually frozen Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- tools/hv/hv_vss_daemon.c | 6 ++ 1 file changed, 6

[PATCH 0/3] Tools: hv: vssdaemon: freeze/thaw logic improvement for the failure case

2014-11-07 Thread Vitaly Kuznetsov
This patch series addresses the following issues: - Wrong error reporting for multiple filesystems case. - Skip all readonly-mounted filesystems instead of skipping iso9660. - Thaw all filesystems after an unsuccessful freeze attempt. Vitaly Kuznetsov (3): Tools: hv: vssdaemon: consult

[PATCH 1/3] Tools: hv: vssdaemon: consult with errno in case of failure only

2014-11-07 Thread Vitaly Kuznetsov
Hyper-V VSS: VSS: freeze of /: Operation not supported We should also log errors with LOG_ERR instead of LOG_INFO. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- tools/hv/hv_vss_daemon.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/hv/hv_vss_daemon.c b

[PATCH 2/3] Tools: hv: vssdaemon: skip all filesystems mounted readonly

2014-11-07 Thread Vitaly Kuznetsov
Instead of making a list of exceptions for readonly filesystems in addition to iso9660 we already have it is better to skip freeze operation for all readonly-mounted filesystems. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- tools/hv/hv_vss_daemon.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH RESEND] xen/blkfront: improve protection against issuing unsupported REQ_FUA

2014-12-03 Thread Vitaly Kuznetsov
Boris Ostrovsky boris.ostrov...@oracle.com writes: On 12/01/2014 08:01 AM, Vitaly Kuznetsov wrote: Guard against issuing unsupported REQ_FUA and REQ_FLUSH was introduced in d11e61583 and was factored out into blkif_request_flush_valid() in 0f1ca65ee. However: 1) This check in incomplete

[PATCH] Drivers: hv: vmbus: Fix a race condition when unregistering a device

2014-11-04 Thread Vitaly Kuznetsov
-device_obj)' check in vmbus_process_rescind_offer() and pr_debug() in vmbus_device_unregister() the device can disappear. Fix the issue by taking an additional reference to the device before proceeding to vmbus_device_unregister(). Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- drivers/hv

Re: [PATCH] tools: hv: introduce -n/--no-daemon option

2014-11-04 Thread Vitaly Kuznetsov
KY Srinivasan k...@microsoft.com writes: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Wednesday, October 22, 2014 9:07 AM To: KY Srinivasan; Haiyang Zhang; de...@linuxdriverproject.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] tools: hv

Re: [PATCH v3] hv: hv_fcopy: drop the obsolete message on transfer failure

2014-12-01 Thread Vitaly Kuznetsov
or fcopy_transaction.fcopy_msg will be used immediately. Cc: Jason Wang jasow...@redhat.com Cc: Vitaly Kuznetsov vkuzn...@redhat.com Cc: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Dexuan Cui de...@microsoft.com --- v2: I removed the FCP prefix as Greg

[PATCH v2] Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors

2014-12-01 Thread Vitaly Kuznetsov
on resume). Suspend still works. Tested with WS2008R2 and WS2012R2. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- Changes since v1: - introduce hv_cpu_hotplug_quirk() function to not spread #ifdefs [Greg KH] - add pr_notice() message hv_vmbus: CPU offlining is not supported by hypervisor

[PATCH RESEND] xen/blkfront: improve protection against issuing unsupported REQ_FUA

2014-12-01 Thread Vitaly Kuznetsov
issues. This patch is based on the original patch by Laszlo Ersek and a comment by Jeff Moyer. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com Reviewed-by: Laszlo Ersek ler...@redhat.com --- drivers/block/xen-blkfront.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff

[PATCH] xen/blkfront: remove redundant flush_op

2014-12-08 Thread Vitaly Kuznetsov
flush_op is unambiguously defined by feature_flush: REQ_FUA | REQ_FLUSH - BLKIF_OP_WRITE_BARRIER REQ_FLUSH - BLKIF_OP_FLUSH_DISKCACHE 0 - 0 and thus can be removed. This is just a cleanup. The patch was suggested by Boris Ostrovsky. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com

Re: [PATCH] tools: hv: kvp_daemon: make IPv6-only-injection work

2014-12-09 Thread Vitaly Kuznetsov
Dexuan Cui de...@microsoft.com writes: Currently IPv6-only-injection doesn't work because the daemon doesn't parse any IPv6 information at all once it finds the dhcp_enabled flag is true. But according to the Hyper-v host team, the flag is only for IPv4. In the case the host only injects 1

[PATCH v2] xen/blkfront: remove redundant flush_op

2014-12-09 Thread Vitaly Kuznetsov
flush_op is unambiguously defined by feature_flush: REQ_FUA | REQ_FLUSH - BLKIF_OP_WRITE_BARRIER REQ_FLUSH - BLKIF_OP_FLUSH_DISKCACHE 0 - 0 and thus can be removed. This is just a cleanup. The patch was suggested by Boris Ostrovsky. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com

[PATCH 0/5] Tools: hv: fix compiler warnings and do minor cleanup

2014-12-09 Thread Vitaly Kuznetsov
() Vitaly Kuznetsov (5): Tools: hv: add mising fcopyd to the Makefile Tools: hv: remove unused bytes_written from kvp_update_file() Tools: hv: address compiler warnings for hv_kvp_daemon.c Tools: hv: address compiler warnings for hv_fcopy_daemon.c Tools: hv: do not add redundant

[PATCH 2/5] Tools: hv: remove unused bytes_written from kvp_update_file()

2014-12-09 Thread Vitaly Kuznetsov
’ set but not used [-Wunused-but-set-variable] Remove bytes_written completely. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- tools/hv/hv_kvp_daemon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c index

[PATCH 5/5] Tools: hv: do not add redundant '/' in hv_start_fcopy()

2014-12-09 Thread Vitaly Kuznetsov
We don't need to add additional '/' to smsg-path_name as snprintf(%s/%s) does the right thing. Without the patch we get doubled '//' in the log message. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- tools/hv/hv_fcopy_daemon.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH 1/5] Tools: hv: add mising fcopyd to the Makefile

2014-12-09 Thread Vitaly Kuznetsov
fcopyd in missing in the Makefile, add it there. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- tools/hv/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/hv/Makefile b/tools/hv/Makefile index bd22f78..99ffe61 100644 --- a/tools/hv/Makefile +++ b

[PATCH 3/5] Tools: hv: address compiler warnings for hv_kvp_daemon.c

2014-12-09 Thread Vitaly Kuznetsov
This patch addresses two types of compiler warnings: ... warning: comparison between signed and unsigned integer expressions [-Wsign-compare] and ... warning: pointer targets in passing argument N of ‘kvp_...’ differ in signedness [-Wpointer-sign] Signed-off-by: Vitaly Kuznetsov vkuzn

[PATCH 4/5] Tools: hv: address compiler warnings for hv_fcopy_daemon.c

2014-12-09 Thread Vitaly Kuznetsov
This patch addresses two types of compiler warnings: ... warning: unused variable ‘fd’ [-Wunused-variable] and ... warning: format ‘%s’ expects argument of type ‘char *’, but argument 5 has type ‘__u16 *’ [-Wformat=] Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- tools/hv

Re: [PATCH] tools: hv: kvp_daemon: make IPv6-only-injection work

2014-12-10 Thread Vitaly Kuznetsov
Dexuan Cui de...@microsoft.com writes: Thanks, -- Dexuan -Original Message- From: Dexuan Cui Sent: Wednesday, December 10, 2014 15:34 PM To: 'Vitaly Kuznetsov' Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev- de...@linuxdriverproject.org; o...@aepfle.de

Re: [PATCH 0/5] Tools: hv: fix compiler warnings and do minor cleanup

2014-12-10 Thread Vitaly Kuznetsov
Dexuan Cui de...@microsoft.com writes: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Tuesday, December 9, 2014 23:48 PM To: KY Srinivasan Cc: Haiyang Zhang; de...@linuxdriverproject.org; linux- ker...@vger.kernel.org; Dexuan Cui Subject: [PATCH 0/5

Re: [PATCH] tools: hv: kvp_daemon: make IPv6-only-injection work

2014-12-10 Thread Vitaly Kuznetsov
Dexuan Cui de...@microsoft.com writes: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Tuesday, December 9, 2014 21:06 PM To: Dexuan Cui Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev- de...@linuxdriverproject.org; o...@aepfle.de

Re: [PATCH v2] tools: hv: kvp_daemon: make IPv6-only-injection work

2015-01-02 Thread Vitaly Kuznetsov
for IPv4 according to Hyper-V host team), but we still need to proceed to parse the IPv6 information. Cc: Vitaly Kuznetsov vkuzn...@redhat.com Cc: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Dexuan Cui de...@microsoft.com --- v2: removed the distro-specific logic as Vitaly suggested

Re: [PATCH 0/3] Drivers: hv: vmbus: fix crashes on hv_vmbus load/unload path

2015-01-26 Thread Vitaly Kuznetsov
Vitaly Kuznetsov vkuzn...@redhat.com writes: It is possible (since 93e5bd06a953: Drivers: hv: Make the vmbus driver unloadable) to unload hv_vmbus driver if no other devices are connected. 1aec169673d7: x86: Hyperv: Cleanup the irq mess fixed doulble interrupt gate setup. However, if we try

Re: [PATCH 1/4] Drivers: hv: vmbus: implement get/put usage workflow for vmbus channels

2015-02-04 Thread Vitaly Kuznetsov
Jason Wang jasow...@redhat.com writes: On Wed, Feb 4, 2015 at 1:00 AM, Vitaly Kuznetsov vkuzn...@redhat.com wrote: free_channel() function frees the channel unconditionally so we need to make sure nobody has any link to it. This is not trivial and there are several examples of races we

Re: [PATCH 1/4] Drivers: hv: vmbus: implement get/put usage workflow for vmbus channels

2015-02-04 Thread Vitaly Kuznetsov
Dexuan Cui de...@microsoft.com writes: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Wednesday, February 4, 2015 1:01 AM To: KY Srinivasan; de...@linuxdriverproject.org Cc: Haiyang Zhang; linux-kernel@vger.kernel.org; Dexuan Cui; Jason Wang Subject

Re: [PATCH 2/3] hv: vmbus_post_msg: retry the hypercall on HV_STATUS_INVALID_CONNECTION_ID

2015-01-30 Thread Vitaly Kuznetsov
Dexuan Cui de...@microsoft.com writes: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Thursday, January 29, 2015 21:31 PM To: Dexuan Cui Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev- de...@linuxdriverproject.org; o

[PATCH 3/4] Drivers: hv: vmbus: protect vmbus_get_outgoing_channel() against channel removal

2015-02-03 Thread Vitaly Kuznetsov
vmbus_get_outgoing_channel() search holding primary-lock as child channels are not being freed unless they're removed from parent's list. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- drivers/hv/channel_mgmt.c | 10 +++--- drivers/scsi/storvsc_drv.c | 2 ++ 2 files changed, 9 insertions

[PATCH 4/4] hyperv: netvsc: improve protection against rescind offer

2015-02-03 Thread Vitaly Kuznetsov
jasow...@redhat.com Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- drivers/net/hyperv/netvsc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index 9f49c01..d9b13a1 100644 --- a/drivers/net/hyperv

[PATCH 1/4] Drivers: hv: vmbus: implement get/put usage workflow for vmbus channels

2015-02-03 Thread Vitaly Kuznetsov
of free_channel(). Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- drivers/hv/channel_mgmt.c | 45 ++--- drivers/hv/connection.c | 7 +-- drivers/hv/hyperv_vmbus.h | 4 include/linux/hyperv.h| 13 + 4 files changed, 60

[PATCH 0/4] Drivers: hv: Further protection for the rescind path

2015-02-03 Thread Vitaly Kuznetsov
., Haiyang, I'm not sending this series to netdev@ and linux-scsi@ as it is supposed to be applied as a whole, please resend these patches with your sign-offs when (and if) we're done with reviews. Thanks! Vitaly Kuznetsov (4): Drivers: hv: vmbus: implement get/put usage workflow for vmbus channels

[PATCH 2/4] Drivers: hv: vmbus: do not lose rescind offer on failure in vmbus_process_offer()

2015-02-03 Thread Vitaly Kuznetsov
list_del in vmbus_process_rescind_offer() hitting an uninitialized list. Reported-by: Dexuan Cui de...@microsoft.com Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com --- drivers/hv/channel_mgmt.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [PATCH 0/4] Drivers: hv: Further protection for the rescind path

2015-02-05 Thread Vitaly Kuznetsov
KY Srinivasan k...@microsoft.com writes: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Tuesday, February 3, 2015 9:01 AM To: KY Srinivasan; de...@linuxdriverproject.org Cc: Haiyang Zhang; linux-kernel@vger.kernel.org; Dexuan Cui; Jason Wang Subject

Re: [PATCH v2 1/1] drivers:hv:vmbus drivers:hv:vmbus Allow for more than one MMIO range for children

2015-02-06 Thread Vitaly Kuznetsov
that contains all those ranges. Without this change, only some of the memory-mapped I/O space will be available for child devices, and only in some virtual BIOS configurations (Generation 2 VMs). This patch has been updated with feedback from Vitaly Kuznetsov. Cleanup is now driven by the acpi remove

Re: [PATCH v2 1/3] Drivers: hv: check vmbus_device_create() return value in vmbus_process_offer()

2015-01-20 Thread Vitaly Kuznetsov
Dan Carpenter dan.carpen...@oracle.com writes: On Mon, Jan 19, 2015 at 05:56:11PM +0100, Vitaly Kuznetsov wrote: vmbus_device_create() result is not being checked in vmbus_process_offer() and it can fail if kzalloc() fails. Add the check and do minor cleanup to avoid additional duplication

[PATCH v3 1/3] Drivers: hv: check vmbus_device_create() return value in vmbus_process_offer()

2015-01-20 Thread Vitaly Kuznetsov
vmbus_device_create() result is not being checked in vmbus_process_offer() and it can fail if kzalloc() fails. Add the check and do minor cleanup to avoid additional duplication of free_channel(); return; block. Reported-by: Jason Wang jasow...@redhat.com Signed-off-by: Vitaly Kuznetsov vkuzn

[PATCH v3 2/3] Drivers: hv: rename sc_lock to the more generic lock

2015-01-20 Thread Vitaly Kuznetsov
sc_lock spinlock in struct vmbus_channel is being used to not only protect the sc_list field, e.g. vmbus_open() function uses it to implement test-and-set access to the state field. Rename it to the more generic 'lock' and add the description. Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com

[PATCH v3 0/3] Drivers: hv: vmbus: protect Offer/Rescind offer processing

2015-01-20 Thread Vitaly Kuznetsov
for rescind and work fields. [K. Y. Srinivasan] Vitaly Kuznetsov (3): Drivers: hv: check vmbus_device_create() return value in vmbus_process_offer() Drivers: hv: rename sc_lock to the more generic lock Drivers: hv: vmbus: serialize Offer and Rescind offer drivers/hv/channel.c | 6

  1   2   3   4   5   6   7   8   9   10   >