Re: [-mm3 PATCH] (Retry) Check the return value of kobject_add and etc.

2007-04-05 Thread WANG Cong
On Thu, Apr 05, 2007 at 06:00:16PM +0200, Cornelia Huck wrote: On Thu, 5 Apr 2007 23:27:32 +0800, WANG Cong [EMAIL PROTECTED] wrote: Thank you very much! I know. So I should replace all kfree with kobject_put, like this one: -sysfs_create_link(p-kobj, block_subsys.kset.kobj, subsystem

Re: set up new kernel with grub

2007-04-05 Thread WANG Cong
On Thu, Apr 05, 2007 at 12:28:03PM -0500, Michael wrote: Hi, Dick, Your steps work beautifully. Thanks. If you could explain a little about what happens in each step, that would be even better. # cd /usr/src/linux-2.6.20.3 If your current kernel is 2.6.20.3, edit the Makefile to add some

Re: set up new kernel with grub

2007-04-06 Thread WANG Cong
On Fri, Apr 06, 2007 at 09:23:38AM -0500, Michael wrote: Hi, Wang, Thanks for replying. So which step is doing the compilation of each module , make oldconfig or make ? For compilation, I mean the step to compile the source code to .o file. Regards, Mike 'Make' does that. 'Make oldconfig'

Re: [-mm3 PATCH] (Retry) Check the return value of kobject_add and etc.

2007-04-10 Thread WANG Cong
On Tue, Apr 10, 2007 at 02:31:06PM +0200, Cornelia Huck wrote: On Fri, 6 Apr 2007 10:53:43 +0800, WANG Cong [EMAIL PROTECTED] wrote: OK. Then I send it again. Hopefully it can be accepted this time. ;-p Looks sane. (Note that there is still a pathological case where kobject_put() is not enough

Re: [PATCH] Add spaces on either side of case ... operator.

2007-04-10 Thread WANG Cong
On Tue, Apr 10, 2007 at 07:23:35AM -0400, Robert P. J. Day wrote: Following the programming advice laid down in the gcc manual, make sure the case ... operator has spaces on either side. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Acked-by: WANG Cong [EMAIL PROTECTED] - To unsubscribe

Re: [-mm3 PATCH] (Retry) Check the return value of kobject_add and etc.

2007-04-11 Thread WANG Cong
On Tue, Apr 10, 2007 at 03:18:15PM -0700, Andrew Morton wrote: On Tue, 10 Apr 2007 22:08:29 +0800 WANG Cong [EMAIL PROTECTED] wrote: Since kobject_add, sysfs_create_link and sysfs_create_file are marked as '__must_check', we must always check their return values. snip Your mail client

Re: [-mm3 patch]Warning fix: check the return value of kobject_add etc.

2007-04-11 Thread WANG Cong
On Wed, Apr 11, 2007 at 02:23:49PM +0800, Fengguang Wu wrote: On Sun, Apr 01, 2007 at 02:20:46PM +0800, Cong WANG wrote: 2007/4/1, Andrew Morton [EMAIL PROTECTED]: Also, please always prepare patches in `patch -p1' form, as per http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, thanks.

Re: [-mm3 PATCH] (Retry) Check the return value of kobject_add and etc.

2007-04-04 Thread WANG Cong
On Mon, Apr 02, 2007 at 01:01:28PM +0200, Cornelia Huck wrote: On Sun, 1 Apr 2007 15:32:34 +0800, Cong WANG [EMAIL PROTECTED] wrote: --- linux-2.6.21-rc5-mm3/fs/partitions/check.c.orig 2007-03-30 21:35:45.0 +0800 +++ linux-2.6.21-rc5-mm3/fs/partitions/check.c 2007-03-30

Re: [-mm3 PATCH] (Retry) Check the return value of kobject_add and etc.

2007-04-05 Thread WANG Cong
On Thu, Apr 05, 2007 at 11:11:42AM +0200, Cornelia Huck wrote: On Thu, 5 Apr 2007 12:54:11 +0800, WANG Cong [EMAIL PROTECTED] wrote: --- linux-2.6.21-rc5-mm3/fs/partitions/check.c.orig 2007-03-30 21:35:45.0 +0800 +++ linux-2.6.21-rc5-mm3/fs/partitions/check.c 2007-04-02 21:29

Re: [-mm3 PATCH] (Retry) Check the return value of kobject_add and etc.

2007-04-05 Thread WANG Cong
On Thu, Apr 05, 2007 at 05:05:14PM +0200, Cornelia Huck wrote: On Thu, 5 Apr 2007 22:44:09 +0800, WANG Cong [EMAIL PROTECTED] wrote: On Thu, Apr 05, 2007 at 11:11:42AM +0200, Cornelia Huck wrote: On Thu, 5 Apr 2007 12:54:11 +0800, WANG Cong [EMAIL PROTECTED] wrote: --- linux-2.6.21-rc5-mm3

Re: translations (Re: Kbuild update)

2008-01-08 Thread WANG Cong
I will use ... http://images.google.cz/images?svnum=100um=1hl=csclient=firefox-arls=org.mozilla%3Acs%3Aofficialq=I+will+use+Google+beforebtnG=Hledat+obr%C3%A1zky ... for making translations...

Re: Kbuild update

2008-01-08 Thread WANG Cong
only is the wrong word in this context. If someone would update the translations for one language every 3 months for the next years that would be great and disprove my concerns. After all, updates every 3 months would beat the maintainance level of at least three of our architectures...

Re: Kbuild update

2008-01-08 Thread WANG Cong
If we can make this to be an offical project for Linux kernel, I think it won't be a big problem. We don't even manage to maintain the English language texts properly, and I am therefore not overly optimistic that we'll have the translations maintained properly for many years. Italian

Re: (Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2008-01-13 Thread WANG Cong
On Fri, Jan 11, 2008 at 06:02:04PM +0100, Sam Ravnborg wrote: On Fri, Jan 11, 2008 at 02:17:54PM +, Ralf Baechle wrote: On Wed, Jan 02, 2008 at 02:21:36PM +0800, WANG Cong wrote: Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)? It would be better to use $(LINUXINCLUDE) as we

Re: [GIT PATCH] Update to Chinese documents

2008-01-13 Thread WANG Cong
to involve. The work can't be done without a large contributor base. I already got positive feedback from Bryan Wu and WANG Cong so a Chinese translation is well within reach if we get the infrastructure adapted so we have better .po files support. Thanks. As Leo said, we can host

Re: translations (Re: Kbuild update)

2008-01-14 Thread WANG Cong
ftp://flower.upol.cz/upload/Configure.help OK, please, take a look at stuff, Korean guys did 5-6 years ago. One particular ARM port (S3C2410X) along with an ARM bootloader (vivi) was done. Yet for some reason official Linux port has another developers, and, it seems, it was done some time (~1-2

Re: [PATCH] time: fix sysfs_show_{available,current}_clocksources() buffer overflow problem

2007-11-10 Thread WANG Cong
On Sun, Nov 11, 2007 at 11:29:59AM +0800, Miao Xie wrote: on 2007-11-8 20:11 WANG Cong wrote: On Thu, Nov 08, 2007 at 07:47:41PM +0800, WANG Cong wrote: Yes, snprintf is safer than sprintf. But here, the 'count' will be mis-pointed when snprintf returns no less than PAGE_SIZE (what you called

Re: [PATCH] Let 'make help' output info about includecheck

2007-11-13 Thread WANG Cong
On Mon, Nov 12, 2007 at 12:56:35AM +0100, Jesper Juhl wrote: From: Jesper Juhl [EMAIL PROTECTED] 'make includecheck' is useful and we want people to run it, so let 'make help' output information about its existence. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] I think Randy Dunlap has done

[Patch] UML: building error fix

2007-11-15 Thread WANG Cong
include/asm-um/arch points to the non-existed include/asm-i386 directory. This patch fixed it. Signed-off-by: WANG Cong [EMAIL PROTECTED] Cc: Jeff Dike [EMAIL PROTECTED] --- diff --git a/arch/um/Makefile b/arch/um/Makefile index 31999bc..ba6813a 100644 --- a/arch/um/Makefile +++ b/arch/um

[Patch] mm/sparse.c: Check the return value of sparse_index_alloc().

2007-11-15 Thread WANG Cong
Since sparse_index_alloc() can return NULL on memory allocation failure, we must deal with the failure condition when calling it. Signed-off-by: WANG Cong [EMAIL PROTECTED] Cc: Christoph Lameter [EMAIL PROTECTED] Cc: Rik van Riel [EMAIL PROTECTED] --- diff --git a/Makefile b/Makefile diff

[Patch] kernel/exit.c: Fix use-before-check in exit_mm()

2007-11-15 Thread WANG Cong
, which could well dereference mm (though it often doesn't). So, whould simply moving the !mm check up as the first in the function be an appropriate way to deal with this? I think yes. Patch below. Fix use-before-check in kernel/exit.c Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git

[Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

2007-11-15 Thread WANG Cong
, not good. I'll let Jeff handle this :) Could you please try this patch? Can it fix the error? Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/Makefile b/Makefile diff --git a/include/linux/swap.h b/include/linux/swap.h index 4f3838a..2c3ce4c 100644 --- a/include/linux/swap.h +++ b/include

Re: [Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

2007-11-16 Thread WANG Cong
On Fri, Nov 16, 2007 at 10:12:57AM -0500, Jeff Dike wrote: On Fri, Nov 16, 2007 at 11:08:32AM +0800, WANG Cong wrote: Could you please try this patch? Can it fix the error? Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/Makefile b/Makefile diff --git a/include/linux/swap.h

Re: Updated Kernel Hacker's guide to git

2007-12-23 Thread WANG Cong
On Sun, Dec 23, 2007 at 06:13:03AM -0500, Jeff Garzik wrote: Another year, another update! :) The kernel hacker's guide to git has received some updates: http://linux.yyz.us/git-howto.html This includes all the input sent to me in the past several months, as well as a few new tips and

Re: void* arithmnetic

2007-11-29 Thread WANG Cong
On Thu, Nov 29, 2007 at 09:38:46AM +0200, Benny Halevy wrote: On Nov. 29, 2007, 3:19 +0200, Ming Lei [EMAIL PROTECTED] wrote: 2007/11/29, Jan Engelhardt [EMAIL PROTECTED]: On Nov 29 2007 01:05, J.A. Magallón wrote: Since begin of the ages the build of the nvidia driver says things like this:

Re: [PATCH] kbuild: implement modules.order

2007-12-04 Thread WANG Cong
{snip} Comments on your C code below. --- /dev/null +++ b/scripts/remove-dup.c @@ -0,0 +1,98 @@ +/* + * remove-dup - Drop duplicate lines from unsorted input files + * + * Dec 2007 Tejun Heo [EMAIL PROTECTED] + * + * This software is released under GPLv2. + */ + +#include stdio.h +#include

Re: [PATCH] kbuild: implement modules.order

2007-12-04 Thread WANG Cong
I think, you forgot to free(3) the memory you calloc(3)'ed and malloc(3)'ed above. It's a simple program where whole body is in main(). Why bother? What's the benefit of adding hash-table iterating free logic? Personally, I think memory leaks are bugs. And we hate bugs. ;) Regards. -- To

Re: Patch submission question [not in the FAQ]

2007-12-05 Thread WANG Cong
On Wed, Dec 05, 2007 at 03:36:54AM -0800, Gabriele Gorla wrote: Hello, I have submitted a patch for the 3x- driver on alpha several months ago to both the driver maintainer and the linux-scsi mailing list. I have read all the FAQ and I tried to stick to the instructions to the letter. However

[Patch] net/xfrm/xfrm_policy.c: Some small improvements

2007-12-06 Thread WANG Cong
This patch contains the following changes. - Use 'bool' instead of 'int' for booleans. - Use 'size_t' instead of 'int' for 'sizeof' return value. - Some style fixes. Cc: Herbert Xu [EMAIL PROTECTED] Cc: David Miller [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL

Re: Is there any word about this bug in gcc ?

2007-11-19 Thread WANG Cong
On Tue, Nov 20, 2007 at 10:13:42AM +0800, zhengyi wrote: Is there any relevance to the kernel ? I found the folowing code here: http://linux.solidot.org/article.pl?sid=07/11/19/0512218from=rss --- int main( void ) { int i=2; if(

Re: [Patch] mm/sparse.c: Check the return value of sparse_index_alloc().

2007-11-19 Thread WANG Cong
On Mon, Nov 19, 2007 at 01:17:02PM -0800, Dave Hansen wrote: On Thu, 2007-11-15 at 21:54 +0800, WANG Cong wrote: Since sparse_index_alloc() can return NULL on memory allocation failure, we must deal with the failure condition when calling it. Signed-off-by: WANG Cong [EMAIL PROTECTED] Cc

Re: [PATCH] Keep UML Kconfig in sync with x86

2007-11-19 Thread WANG Cong
to the UML/i386 Kconfig. Signed-off-by: Jeff Dike [EMAIL PROTECTED] Tested-by: WANG Cong [EMAIL PROTECTED] Thanks, Jeff. With this and that patch[1], uml building works fine. ;) [1] http://lkml.org/lkml/2007/11/15/231 - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: Is there any word about this bug in gcc ?

2007-11-19 Thread WANG Cong
On Mon, Nov 19, 2007 at 09:10:44PM -0800, H. Peter Anvin wrote: WANG Cong wrote: On Tue, Nov 20, 2007 at 10:13:42AM +0800, zhengyi wrote: Is there any relevance to the kernel ? I found the folowing code here: http://linux.solidot.org/article.pl?sid=07/11/19/0512218from=rss

Re: Is there any word about this bug in gcc ?

2007-11-19 Thread WANG Cong
On Tue, Nov 20, 2007 at 02:03:12PM +0800, Li Zefan wrote: WANG Cong wrote: On Mon, Nov 19, 2007 at 09:10:44PM -0800, H. Peter Anvin wrote: WANG Cong wrote: On Tue, Nov 20, 2007 at 10:13:42AM +0800, zhengyi wrote: Is there any relevance to the kernel ? I found the folowing code here: http

[Patch] mm/sparse.c: Improve the error handling for sparse_add_one_section()

2007-11-22 Thread WANG Cong
for this. ;( I hope someone can help me to test it. Cc: Christoph Lameter [EMAIL PROTECTED] Cc: Dave Hansen [EMAIL PROTECTED] Cc: Rik van Riel [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- mm/sparse.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions

Re: [uml-devel] uml doesn't work on 2.6.24-rc2

2007-11-23 Thread WANG Cong
On Fri, Nov 23, 2007 at 11:54:41AM +0100, Jiri Olsa wrote: Hi, after applying following changes, the mainline is working for me. Hi, I have already mentioned this. Follow this link[1]. ;^) [1] http://lkml.org/lkml/2007/11/20/10 - To unsubscribe from this list: send the line unsubscribe

Re: [PROBLEM] uml doesn't compile on i386

2007-11-23 Thread WANG Cong
On Fri, Nov 23, 2007 at 10:52:06AM +0200, Pekka Enberg wrote: Hi, Current git head doesn't compile. Looks like fall-out from the x86 merge? [EMAIL PROTECTED]:~/src/linux/uml-2.6$ make ARCH=um SYMLINK arch/um/include/kern_constants.h SYMLINK arch/um/include/sysdep make[1]:

[Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()

2007-11-26 Thread WANG Cong
) -__kfree_section_memmap(memmap, nr_pages); + return ret; } #endif Hmm. When sparse_init_one_section() returns error, memmap and usemap should be free. Hi, Yasunori. Thanks for your comments. Is the following one fine for you? Signed-off-by: WANG Cong [EMAIL PROTECTED] --- Index: linux-2.6/mm

Re: [PATCH] [VIDEO]: Complement va_start() with va_end().

2007-11-27 Thread WANG Cong
On Tue, Nov 27, 2007 at 08:06:17AM +0100, Richard Knutsson wrote: Complement va_start() with va_end(). Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested on i386 with allyesconfig and allmodconfig. diff --git a/drivers/media/video/saa5246a.c b/drivers/media/video/saa5246a.c

Re: [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()

2007-11-28 Thread WANG Cong
On Tue, Nov 27, 2007 at 10:53:45AM -0800, Dave Hansen wrote: On Tue, 2007-11-27 at 10:26 +0800, WANG Cong wrote: @@ -414,7 +418,7 @@ int sparse_add_one_section(struct zone * out: pgdat_resize_unlock(pgdat, flags); if (ret = 0) - __kfree_section_memmap(memmap

[Patch 0/8] Remove 'TOPDIR' from Makefiles

2007-12-31 Thread WANG Cong
TOPDIR is obsolete, use srctree or objtree instead. This patch set removes all the TOPDIR use in the whole source tree and finally drops it in the top Makefile. They're against the current linus-tree. Note that Patch [8/8] should be applied _after_ all the previous patches are applied.

[Patch 1/8] UML: Remove 'TOPDIR' from Makefiles

2007-12-31 Thread WANG Cong
TOPDIR is obsolete, use objtree instead. This patch removes TOPDIR from all UML Makefiles. Cc: Jeff Dike [EMAIL PROTECTED] Cc: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/arch/um/Makefile b/arch/um/Makefile index ba6813a..57491af 100644 --- a/arch

[Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2007-12-31 Thread WANG Cong
TOPDIR is obsolete, use objtree instead. This patch removes TOPDIR from all Mips Makefiles. Cc: Ralf Baechle [EMAIL PROTECTED] Cc: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/arch/mips/lasat/image/Makefile b/arch/mips/lasat/image/Makefile index

[Patch 3/8] S390: Remove 'TOPDIR' from Makefiles

2007-12-31 Thread WANG Cong
TOPDIR is obsolete, use objtree instead. This patch removes TOPDIR from all s390 Makefiles. Cc: Martin Schwidefsky [EMAIL PROTECTED] Cc: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/arch/s390/kernel/Makefile b/arch/s390/kernel/Makefile index

[Patch 4/8] CRIS: Remove 'TOPDIR' from Makefiles

2007-12-31 Thread WANG Cong
TOPDIR is obsolete, use objtree instead. This patch removes TOPDIR from all Cris Makefiles. Cc: Mikael Starvik [EMAIL PROTECTED] Cc: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/arch/cris/arch-v32/boot/compressed/Makefile b/arch/cris/arch-v32/boot

[Patch 5/8] INFINIBAND: Remove 'TOPDIR' from Makefiles

2007-12-31 Thread WANG Cong
TOPDIR is obsolete, use objtree instead. This patch removes TOPDIR from all infiniband Makefiles. Cc: Sam Ravnborg [EMAIL PROTECTED] Cc: Roland Dreier [EMAIL PROTECTED] Cc: Sean Hefty [EMAIL PROTECTED] Cc: Hal Rosenstock [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff

[Patch 6/8] FRV: Remove 'TOPDIR' from Makefiles

2007-12-31 Thread WANG Cong
TOPDIR is obsolete, use objtree instead. This patch removes TOPDIR from all frv Makefiles. Cc: David Howells [EMAIL PROTECTED] Cc: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/arch/frv/boot/Makefile b/arch/frv/boot/Makefile index dc6f038..d93f768

[Patch 7/8] FS: Remove 'TOPDIR' from Makefiles

2007-12-31 Thread WANG Cong
TOPDIR is obsolete, use objtree instead. This patch removes TOPDIR from all fs/ Makefiles. Cc: Alexander Viro [EMAIL PROTECTED] Cc: Tim Shimmin [EMAIL PROTECTED] Cc: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/fs/smbfs/Makefile b/fs/smbfs/Makefile

[Patch 8/8] Remove 'TOPDIR' from the Top Makefile

2007-12-31 Thread WANG Cong
TOPDIR is obsolete, thus can be removed. This patch removes TOPDIR from the top Makefile. Cc: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/Makefile b/Makefile index fbb8dfc..c892d14 100644 --- a/Makefile +++ b/Makefile @@ -148,15 +148,13 @@ _all

(Try #2) [Patch 1/8] UML: Remove 'TOPDIR' from Makefiles

2008-01-01 Thread WANG Cong
On Tue, Jan 01, 2008 at 11:49:42AM +0100, Sam Ravnborg wrote: On Tue, Jan 01, 2008 at 11:33:42AM +0100, Sam Ravnborg wrote: On Tue, Jan 01, 2008 at 03:18:46PM +0800, WANG Cong wrote: TOPDIR is obsolete, use objtree instead. This patch removes TOPDIR from all UML Makefiles. I do

(Try #2) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2008-01-01 Thread WANG Cong
$(TOPDIR)/ would do it. Thank you for your explanations! The following one corrects all the mistakes as you told. --- Since TOPDIR is obsolete, this patch removes TOPDIR from the Mips Makefiles. Cc: Ralf Baechle [EMAIL PROTECTED] Cc: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL

(Try #2) [Patch 3/8] S390: Tiny fixes for Makefile

2008-01-01 Thread WANG Cong
on purpose. Thanks anyway! The following one contains the new fix. This patch removes TOPDIR and fixes a bogus prerequisite in arch/s390/kernel/Makefile. Cc: Martin Schwidefsky [EMAIL PROTECTED] Cc: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] diff --git

(Try #2) [Patch 4/8] CRIS: Remove 'TOPDIR' from Makefiles

2008-01-01 Thread WANG Cong
it. ;) - This patch removes TOPDIR from Cris Makefiles. Cc: Mikael Starvik [EMAIL PROTECTED] Cc: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/arch/cris/arch-v32/boot/compressed/Makefile b/arch/cris/arch-v32/boot/compressed/Makefile index

(Try #2) [Patch 5/8] INFINIBAND: Remove 'TOPDIR' from Makefiles

2008-01-01 Thread WANG Cong
PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/drivers/infiniband/hw/cxgb3/Makefile b/drivers/infiniband/hw/cxgb3/Makefile index 36b9898..7e7b5a6 100644 --- a/drivers/infiniband/hw/cxgb3/Makefile +++ b/drivers/infiniband/hw/cxgb3/Makefile @@ -1,5 +1,4 @@ -EXTRA_CFLAGS += -I

(Try #2) [Patch 6/8] FRV: Drop 'TOPDIR' from Makefiles

2008-01-01 Thread WANG Cong
In this file we can just drop use of $(TOPDIR) since this is our current directory anyway. Thanks! This patch drops TOPDIR from frv Makefiles. Cc: David Howells [EMAIL PROTECTED] Cc: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/arch/frv

(Try #2) [Patch 7/8] FS: Drop 'TOPDIR' from Makefiles and remove some dead code

2008-01-01 Thread WANG Cong
: Alexander Viro [EMAIL PROTECTED] Cc: Tim Shimmin [EMAIL PROTECTED] Cc: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/fs/smbfs/Makefile b/fs/smbfs/Makefile index 6673ee8..4faf8c4 100644 --- a/fs/smbfs/Makefile +++ b/fs/smbfs/Makefile @@ -16,23 +16,3

Re: linux 0.01 released

2008-01-01 Thread WANG Cong
On Tue, Jan 01, 2008 at 09:56:59PM +0100, Abdel wrote: Hello everybody and happy new year, I have ported linux 0.01 to gcc-4.x, and bach-3.2 (and few others programs) can run on it. so you will find binary Image of linux 0.01 floppy and qemu hdd here:

(Try #3) [Patch 7/8] FS: Remove dead code

2008-01-01 Thread WANG Cong
On Tue, Jan 01, 2008 at 06:37:29PM +0100, Sam Ravnborg wrote: On Tue, Jan 01, 2008 at 11:27:37AM -0600, Eric Sandeen wrote: WANG Cong wrote: TOPDIR is obsolete, use objtree instead. This patch removes TOPDIR from all fs/ Makefiles. diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile index

(Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2008-01-01 Thread WANG Cong
from the Mips Makefiles. Cc: Ralf Baechle [EMAIL PROTECTED] Cc: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/arch/mips/lasat/image/Makefile b/arch/mips/lasat/image/Makefile index 5332449..17f5266 100644 --- a/arch/mips/lasat/image/Makefile +++ b/arch

(Try #3) [Patch 4/8] CRIS: Remove 'TOPDIR' from Makefiles

2008-01-01 Thread WANG Cong
Refine it as suggested by Andreas. This patch removes TOPDIR from Cris Makefiles. Cc: Mikael Starvik [EMAIL PROTECTED] Cc: Sam Ravnborg [EMAIL PROTECTED] Cc: Andreas Schwab [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/arch/cris/arch-v32/boot

(Try #3) [Patch 3/8] S390: Remove 'TOPDIR' from Makefile

2008-01-01 Thread WANG Cong
/Makefile. Cc: Martin Schwidefsky [EMAIL PROTECTED] Cc: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/arch/s390/kernel/Makefile b/arch/s390/kernel/Makefile index 56cb710..b3b650a 100644 --- a/arch/s390/kernel/Makefile +++ b/arch/s390/kernel/Makefile @@ -31,7

Re: [Patch 0/8] Remove 'TOPDIR' from Makefiles

2008-01-02 Thread WANG Cong
Hi Wang. You a heads up. I will most likely apply the remaining of the patches tonight, except the UM stuff which I hope Jeff to take and the final removal of TOPDIR may wait a bit. I want the s390, xfs and um changes to hit -mm at least and we have several external modules that uses TOPDIR.

[Patch] xfrm_policy_destroy: rename and relative fixes

2008-01-03 Thread WANG Cong
xfrm_policy_destroy to destroy the resource, fix them. Cc: David Miller [EMAIL PROTECTED] Cc: Herbert Xu [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- diff --git a/include/net/xfrm.h b/include/net/xfrm.h index 58dfa82..6eff085 100644 --- a/include/net/xfrm.h +++ b/include/net/xfrm.h

Re: Kbuild update

2008-01-04 Thread WANG Cong
{snip} TODO items (from my mailbox - I have plenty more) = - asm-offset useable from modules (Oleg had a half backed solution) - modpost should use err(), warn() etc (suggestyed by Rusty) - less kernel hardcoding in kconfig (Rob Landley) - emit

Re: Kbuild update

2008-01-06 Thread WANG Cong
It sort of stopped at one point due to missing integration in mainline. What I refer to is mostly the mconf.c bits, but I would also like to see what lkml says to a sample of .po files included in the kernel for a number of languages. One criteria to get a .po file integrated could be at

Re: [x86 patch] Fix UML ubd_kern.c build error

2007-10-25 Thread WANG Cong
On Thu, Oct 25, 2007 at 05:20:20PM +0530, Balbir Singh wrote: Fix UML build error, include linux/scatterlist.h in arch/um/drivers/ubd_kern.c, to resolve the definition of sg_page() Signed-off-by: Balbir Singh [EMAIL PROTECTED] This is already fixed by me[1]. ;) [1]

Re: kernel 2.6.23 CFS problem?

2007-10-25 Thread WANG Cong
On Fri, Oct 26, 2007 at 10:57:45AM +0800, Wang, Baojun wrote: hi, list I've upgraded my kernel from 2.6.22.9 to 2.6.23 when it was out, After that I can't install ELDK 4.1 anymore (The one I installed was crashed), it always stopped at preparing install package XXX (or YYY sometimes), I've

Re: [PROBLEM] UM does not compile on i386

2007-10-26 Thread WANG Cong
On Fri, Oct 26, 2007 at 03:58:04PM +0300, Pekka Enberg wrote: Hi, The current Linus' git does not compile on i386 for UM defconfig: CC init/do_mounts.o In file included from init/do_mounts.c:19: init/do_mounts.h: In function 'bstat': init/do_mounts.h:25: error: storage size of 'stat'

[Git Patch]arch/um/drivers/ubd_kern.c: a warning fix

2007-10-26 Thread WANG Cong
Fix an incompatible-pointer warning. Signed-off-by: WANG Cong [EMAIL PROTECTED] --- arch/um/drivers/ubd_kern.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index e184b44..7e6cdde 100644 --- a/arch/um/drivers

[Git Patch]fs/jffs2/acl.c: Fix a may-be-uninitialized return value

2007-10-27 Thread WANG Cong
Fix a may-be-uninitialized return value. Found-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- fs/jffs2/acl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/jffs2/acl.c b/fs/jffs2/acl.c index 9728614..5b14062 100644 --- a/fs/jffs2

UML building failed in current Linus-tree

2007-10-27 Thread WANG Cong
Hi, Jeff, Sam! I just pulled from Linus-tree, and got the following error when building uml. $ make defconfig ARCH=um /home/wangcong/projects/linux-2.6/arch/um/Makefile-i386:32: /home/wangcong/projects/linux-2.6/arch/i386/Makefile.cpu: No such file or directory make: *** No rule to make

Re: UML building failed in current Linus-tree

2007-10-27 Thread WANG Cong
On Sun, Oct 28, 2007 at 03:43:43AM +, Al Viro wrote: On Sun, Oct 28, 2007 at 11:24:41AM +0800, WANG Cong wrote: Hi, Jeff, Sam! I just pulled from Linus-tree, and got the following error when building uml. $ make defconfig ARCH=um /home/wangcong/projects/linux-2.6/arch/um/Makefile

[Git Patch] arch/um/os-Linux/: varied improvements and fixes

2007-10-28 Thread WANG Cong
Hi, Jeff. This patch contains varied fixes and improvements for some files under arch/um/os-Linux/, such as a typo fix in a perror message, a missing argument fix for a printf, some constifying for pointers and so on. Signed-off-by: WANG Cong [EMAIL PROTECTED] Cc: Jeff Dike [EMAIL PROTECTED

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-21 Thread WANG Cong
On Sat, Oct 20, 2007 at 12:41:29PM +0100, Nix wrote: On 20 Oct 2007, Paolo Giarrusso told this: Guess most people are not using SMP right now, and that the error disappears without that setting It doesn't. It fails with non-SMP as well. UML still doesn't build on 2.6.23-git16. Gcc threw out

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-21 Thread WANG Cong
On Sun, Oct 21, 2007 at 09:08:48AM -0400, Jeff Dike wrote: On Sun, Oct 21, 2007 at 07:48:54PM +0800, WANG Cong wrote: UML still doesn't build on 2.6.23-git16. Gcc threw out many errors, I put them in the web: http://wangcong.org/down/errors.txt Looks like either you need to run mrproper

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-21 Thread WANG Cong
On Sun, Oct 21, 2007 at 04:43:46PM +0100, Al Viro wrote: On Sun, Oct 21, 2007 at 09:20:32PM +0800, WANG Cong wrote: On Sun, Oct 21, 2007 at 09:08:48AM -0400, Jeff Dike wrote: On Sun, Oct 21, 2007 at 07:48:54PM +0800, WANG Cong wrote: UML still doesn't build on 2.6.23-git16. Gcc threw out

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-22 Thread WANG Cong
On Mon, Oct 22, 2007 at 06:22:14AM +0100, Al Viro wrote: On Mon, Oct 22, 2007 at 12:37:46PM +0800, WANG Cong wrote: Fallout continues; I've got a preliminary patch for it. Basically, we need to stop doing -U__i386__ et.al. Hi, Al. I applied your patch and recompiled the kernel

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-22 Thread WANG Cong
On Mon, Oct 22, 2007 at 07:42:33AM +0100, Nix wrote: On 22 Oct 2007, WANG Cong uttered the following: I build UML for non-SMP x86. But I don't know about UML_NET_VDE. ;( Errors threw out by gcc (too many) are put here: http://wangcong.org/down/errors.txt It's hard to tell without LOCALE

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-22 Thread WANG Cong
On Mon, Oct 22, 2007 at 08:59:43AM +0200, Sam Ravnborg wrote: On Mon, Oct 22, 2007 at 02:52:02PM +0800, WANG Cong wrote: On Mon, Oct 22, 2007 at 07:42:33AM +0100, Nix wrote: On 22 Oct 2007, WANG Cong uttered the following: I build UML for non-SMP x86. But I don't know about UML_NET_VDE

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-22 Thread WANG Cong
On Mon, Oct 22, 2007 at 12:36:00PM +0100, Al Viro wrote: On Mon, Oct 22, 2007 at 03:48:23PM +0800, WANG Cong wrote: I just followed what Sam told me, errors are much fewer this time, but still exist. Error messages are: CC arch/um/kernel/syscall.o CC arch/um/kernel/sysrq.o

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-22 Thread WANG Cong
On Mon, Oct 22, 2007 at 02:30:41PM +0200, Ingo Molnar wrote: * WANG Cong [EMAIL PROTECTED] wrote: On Mon, Oct 22, 2007 at 12:36:00PM +0100, Al Viro wrote: On Mon, Oct 22, 2007 at 03:48:23PM +0800, WANG Cong wrote: I just followed what Sam told me, errors are much fewer this time, but still

[Git Patch] arch/um/drivers/ubd_kern.c: fix a building error

2007-10-24 Thread WANG Cong
make[1]: *** [arch/um/drivers/ubd_kern.o] Error 1 make: *** [arch/um/drivers] Error 2 Signed-off-by: WANG Cong [EMAIL PROTECTED] --- arch/um/drivers/ubd_kern.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index 3a8cd3d..440ed25

[Patch] Fix shadowed variables in kernel/posix-cpu-timers.c

2008-02-15 Thread WANG Cong
Fix sparse warnings like this: kernel/posix-cpu-timers.c:1090:25: warning: symbol 't' shadows an earlier one kernel/posix-cpu-timers.c:1058:21: originally declared here Signed-off-by: WANG Cong [EMAIL PROTECTED] Cc: Thomas Gleixner [EMAIL PROTECTED] --- diff --git a/kernel/posix-cpu-timers.c b

[Patch] Fix shadowed variables in fs/binfmt_elf.c

2008-02-15 Thread WANG Cong
Fix these sparse warings: fs/binfmt_elf.c:1749:29: warning: symbol 'tmp' shadows an earlier one fs/binfmt_elf.c:1734:28: originally declared here fs/binfmt_elf.c:2009:26: warning: symbol 'vma' shadows an earlier one fs/binfmt_elf.c:1892:24: originally declared here Signed-off-by: WANG Cong

[Patch] arch/um/kernel/um_arch.c: some small improvements

2008-02-15 Thread WANG Cong
Make some small improvements for arch/um/kernel/um_arch.c. Signed-off-by: WANG Cong [EMAIL PROTECTED] Cc: Jeff Dike [EMAIL PROTECTED] --- diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c index a6c1dd1..56deed6 100644 --- a/arch/um/kernel/um_arch.c +++ b/arch/um/kernel/um_arch.c

[-rc7 Patch] fs/isofs/namei.c: mark variables as uninitialized_var

2007-09-21 Thread WANG Cong
Fix may-be-used-uninitialized warnings. Signed-off-by: WANG Cong [EMAIL PROTECTED] --- fs/isofs/namei.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.23-rc7/fs/isofs/namei.c === --- linux-2.6.23-rc7

Re: linux 2.6.23-rc7 - 14 compile warnings

2007-09-21 Thread WANG Cong
On Fri, Sep 21, 2007 at 10:33:56AM +0100, Dave Haywood wrote: Contents: ver_linux output Summary of compile warnings Full compile log .config Linux s1 2.6.23-rc7-g335fb8fc #9 SMP Fri Sep 21 09:31:01 BST 2007 i686 Pentium III (Coppermine)

[-mm Patch] net/bluetooth/hidp/core.c: Make hidp_setup_input() return int

2007-09-22 Thread WANG Cong
This patch does the following things: - Make hidp_setup_input() return int to indicate errors. - Check its return value to handle errors. Signed-off-by: WANG Cong [EMAIL PROTECTED] --- net/bluetooth/hidp/core.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Index: linux

Re: linux 2.6.23-rc7 - 14 compile warnings

2007-09-22 Thread WANG Cong
On Sat, Sep 22, 2007 at 10:23:59PM -0400, Gerhard Mack wrote: On Sat, 22 Sep 2007, WANG Cong wrote: Summary: CC mm/slub.o mm/slub.c: In function 'kfree': mm/slub.c:2491: warning: passing argument 3 of 'slab_free' discards qualifiers from pointer target type static void __slab_free

Re: [-mm Patch] net/bluetooth/hidp/core.c: Make hidp_setup_input() return int

2007-09-23 Thread WANG Cong
On Mon, Sep 24, 2007 at 12:13:22AM +0200, roel wrote: WANG Cong wrote: This patch does the following things: - Make hidp_setup_input() return int to indicate errors. - Check its return value to handle errors. Signed-off-by: WANG Cong [EMAIL PROTECTED] --- net/bluetooth/hidp/core.c

[Resend][-mm Patch] net/bluetooth/hidp/core.c: Make hidp_setup_input() return int

2007-09-23 Thread WANG Cong
This patch does the following things: - Make hidp_setup_input() return int to indicate errors. - Check its return value to handle errors. Thanks to roel for comments. Signed-off-by: WANG Cong [EMAIL PROTECTED] --- net/bluetooth/hidp/core.c | 11 +++ 1 file changed, 7 insertions

[-mm Patch] net/bluetooth/hidp/core.c: Make hidp_setup_input() return int

2007-09-24 Thread WANG Cong
This patch: - makes hidp_setup_input() return int to indicate errors; - checks its return value to handle errors. And this time it is against -rc7-mm1 tree. Thanks to roel and Marcel Holtmann for comments. Signed-off-by: WANG Cong [EMAIL PROTECTED] --- net/bluetooth/hidp/core.c | 11

[-mm Patch] fs/udf/balloc.c: mark a variable as uninitialized_var()

2007-09-25 Thread WANG Cong
This patch kills a may-be-used-uninitialized warning. Signed-off-by: WANG Cong [EMAIL PROTECTED] --- fs/udf/balloc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.23-rc8-mm1/fs/udf/balloc.c

[-mm Patch] drivers/usb/misc/sisusbvga/sisusb.c: kill two unused variables

2007-09-25 Thread WANG Cong
Kill two unused variables in drivers/usb/misc/sisusbvga/sisusb.c. Signed-off-by: WANG Cong [EMAIL PROTECTED] --- drivers/usb/misc/sisusbvga/sisusb.c |2 -- 1 file changed, 2 deletions(-) Index: linux-2.6.23-rc8-mm1/drivers/usb/misc/sisusbvga/sisusb.c

Re: Floating Point Issue

2007-09-27 Thread WANG Cong
On Thu, Sep 27, 2007 at 05:17:44PM +0200, Jan Engelhardt wrote: On Sep 27 2007 12:41, mahamuni ashish wrote: I have small code This is not a kernel problem. (Read your C book and/or ask in a C newsgroup.) Please goto comp.lang.c for help. ;) -- Bill, look, we understand that you're

Re: [PATCH] update checkpatch.pl to version 0.10

2007-09-28 Thread WANG Cong
On Fri, Sep 28, 2007 at 12:46:45PM +0200, Christian Borntraeger wrote: Am Freitag, 28. September 2007 schrieb Andy Whitcroft: And this is not about any particular false positive. I dont mind an advanced mode non-default opt-in option for the script, if someone is interested in borderline

[Patch]Documentation/vm/slabinfo.c: clean up this code

2007-10-05 Thread WANG Cong
. And it is against 2.6.23-rc9. CC: Christoph Lameter [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- Documentation/vm/slabinfo.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) Index: linux-2.6.23-rc9/Documentation/vm/slabinfo.c

Re: [Patch]Documentation/vm/slabinfo.c: clean up this code

2007-10-05 Thread WANG Cong
On Fri, Oct 05, 2007 at 12:17:41PM -0700, Christoph Lameter wrote: On Fri, 5 Oct 2007, WANG Cong wrote: This patch does the following cleanups for Documentation/vm/slabinfo.c: - Fix two memory leaks; For user space code? Memory will be released as soon as the program terminates. Yes

[Patch]Documentation/spi/spidev_test.c: constify some variables

2007-10-05 Thread WANG Cong
Constify two char pointers and a struct in Documentation/spi/spidev_test.c. CC: David Brownell [EMAIL PROTECTED] CC: Anton Vorontsov [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- Documentation/spi/spidev_test.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[Patch]Documentation/watchdog/src/watchdog-simple.c: improve this code

2007-10-05 Thread WANG Cong
Make some improvements for Documentation/watchdog/src/watchdog-simple.c. CC: Wim Van Sebroeck [EMAIL PROTECTED] Signed-off-by: WANG Cong [EMAIL PROTECTED] --- Documentation/watchdog/src/watchdog-simple.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) Index: linux

  1   2   3   4   5   >