]
Regards!
WANG Cong
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
more Chinese to contribute to Linux kernel.
Signed-off-by: Li Yang [EMAIL PROTECTED]
Signed-off-by: TripleX Chung [EMAIL PROTECTED]
Signed-off-by: Maggie Chen [EMAIL PROTECTED]
Signed-off-by: WANG Cong [EMAIL PROTECTED]
---
Address comments from Wang Cong.
Documentation/zh_CN/HOWTO | 536
-by: WANG Cong [EMAIL PROTECTED]
Thanks! Looks nice this time.
Er, you forgot your signed-off-by?
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
describes and explains the non-technical things
needed by Linux kernel will help them _much_ to join the development soon.
Also, IMO, a translation shows Linux kernel is friendly and open to
people from all over the world.
Regards!
WANG Cong
-
To unsubscribe from this list: send the line
in HTML format), and I'll put 'em up. (I've
already got the one that started this thread.)
Thanks,
Please also send a copy of HTML format to me, I will put them to
http://www.kerneltravel.net (A Chinese website about Linux kernel).
Thanks!
WANG Cong
-
To unsubscribe from this list: send the line
a label.
I think this should be fixed manually. And it seems that there shouldn't be any
spaces before the label 'fail' in this context.
Regards!
WANG Cong
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info
in
CodingStyle. And it is
against -rc3 source tree.
Any advice or comments are more than welcome!
Regards!
Signed-off-by: WANG Cong [EMAIL PROTECTED]
---
CodingStyle |6 ++
1 file changed, 6 insertions(+)
--- linux-2.6.22-rc3/Documentation/CodingStyle.orig 2007-06-03
21:28
On Sun, Jun 03, 2007 at 11:35:43AM -0400, Jeff Garzik wrote:
Randy Dunlap wrote:
On Sun, 3 Jun 2007 15:29:39 +0100 Al Viro wrote:
On Sun, Jun 03, 2007 at 10:24:50PM +0800, WANG Cong wrote:
+Do care when you use Lindent to indent your code, since it may use
spaces
+instead of tabs before
On Sun, Jun 03, 2007 at 11:59:26PM -0700, Jeremy Fitzhardinge wrote:
WANG Cong wrote:
I just wonder, if a goto label is nested in a while/for/if/switch block,
aligning it in
the first column maybe a bit ugly. (I know mostly it is not in any
while/for/if/switch block.)
In general goto
Viro, Randy Dunlap, Jeff Garzik and Jeremy Fitzhardinge for their
comments!
Regards!
Signed-off-by: WANG Cong [EMAIL PROTECTED]
---
CodingStyle |7 +++
1 file changed, 7 insertions(+)
--- linux-2.6.22-rc3/Documentation/CodingStyle.orig 2007-06-04
15:53:58.0 +0800
+++ linux
On Mon, Jun 04, 2007 at 12:02:28PM -0700, Jeremy Fitzhardinge wrote:
Sam Ravnborg wrote:
If local(__label__) really so widely used in the kernel that it deserves
a place in coding-style?
A quick grep did not say so.
Probably not, and its use shouldn't be (even tacitly) encouraged. It's
On Mon, Jun 04, 2007 at 01:57:51PM -0400, Jeff Garzik wrote:
On Mon, Jun 04, 2007 at 10:43:51AM -0700, H. Peter Anvin wrote:
Jan Engelhardt wrote:
On Jun 4 2007 10:27, H. Peter Anvin wrote:
Jeff Garzik wrote:
Seconded. All my code contains the goto label in the first column.
IMO any
On Mon, Jun 04, 2007 at 07:31:27PM -0700, H. Peter Anvin wrote:
Jeff Garzik wrote:
So, it seems that we can reach an agreement. Any other comments or
suggestions?
Or can someone ack/merge this patch?
Honestly, I think not reaching an agreement is a good thing.
style is always ultimately
On Tue, Jun 05, 2007 at 11:16:13AM +0200, Rene Herman wrote:
On 06/05/2007 04:10 AM, WANG Cong wrote:
On Mon, Jun 04, 2007 at 01:57:51PM -0400, Jeff Garzik wrote:
A matter of opinion :) I tend to think goto is special enough to
warrant column 1 unconditionally. It is special, so it draws
#includes a head file named
../../include/linux/lguest_launcher.h.
Since mlguest.c is in the top dir, so where is
../../include/linux/lguest_launcher.h?
Regards!
WANG Cong
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More
On Wed, Jun 06, 2007 at 11:09:31AM -0700, Andrew Morton wrote:
On Thu, 7 Jun 2007 00:19:36 +0800 WANG Cong [EMAIL PROTECTED] wrote:
On Wed, Jun 06, 2007 at 02:07:37AM -0700, Andrew Morton wrote:
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm1
On Thu, Jun 07, 2007 at 12:59:13AM -0500, Matt Mackall wrote:
On Thu, Jun 07, 2007 at 10:26:09AM +0800, WANG Cong wrote:
On Wed, Jun 06, 2007 at 11:09:31AM -0700, Andrew Morton wrote:
On Thu, 7 Jun 2007 00:19:36 +0800 WANG Cong [EMAIL PROTECTED] wrote:
On Wed, Jun 06, 2007 at 02:07:37AM
On Thu, Jun 07, 2007 at 09:04:44AM -0500, Matt Mackall wrote:
On Thu, Jun 07, 2007 at 02:51:58PM +0800, WANG Cong wrote:
Maybe there's something wrong with ketchup. ;(
Can you do an 'lsdiff | grep lguest' on the patch in your ~/.ketchup
directory?
Ketchup simply applies patches, it never
On Thu, Jun 07, 2007 at 10:59:14AM -0500, Matt Mackall wrote:
On Thu, Jun 07, 2007 at 11:40:08PM +0800, WANG Cong wrote:
On Thu, Jun 07, 2007 at 09:04:44AM -0500, Matt Mackall wrote:
On Thu, Jun 07, 2007 at 02:51:58PM +0800, WANG Cong wrote:
Maybe there's something wrong with ketchup
Don't forget to check the return value of kmalloc().
Signed-off-by: WANG Cong [EMAIL PROTECTED]
---
Index: linux-2.6.22-rc6-mm1/drivers/infiniband/hw/cxgb3/iwch_provider.c
===
--- a/drivers/infiniband/hw/cxgb3/iwch_provider.c
On Thu, May 24, 2007 at 06:26:26PM +0200, Jan Engelhardt wrote:
On May 24 2007 22:47, coly wrote:
Dave,
Yes, I found all TABs gone when I received the mail. When I post next
version of the patch, I will test to send to me first :-)
Thanks for your information.
Blame Gmail.
Jan
I am
On Mon, May 28, 2007 at 06:30:38PM +0400, Cyrill Gorcunov wrote:
This patch converts UDF coding style to kernel
coding style using Lindent.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
fs/udf/balloc.c| 709 ---
fs/udf/crc.c | 19 +-
fs/udf/dir.c |
On Fri, Jul 13, 2007 at 06:09:02PM +0530, Anand Jahagirdar wrote:
Hello All
{snip}
Index: root/Desktop/a1/linux-2.6.17.tar.bz2_FILES/linux-2.6.17/kernel/fork.c
===
---
1. There's no lists in fs/romfs/inode.c, so using list_entry is
a bit confusing. Replace it with container_of.
2. It is unnecessary to cast the return value of kmem_cache_alloc,
since it returns a void* pointer.
This patch is against 2.6.22.1.
Signed-off-by: WANG Cong [EMAIL PROTECTED
to
its largest population base. Language could be the main obstacle. Hope
this document will help more Chinese to contribute to Linux kernel.
Signed-off-by: Li Yang [EMAIL PROTECTED]
Signed-off-by: TripleX Chung [EMAIL PROTECTED]
Signed-off-by: Maggie Chen [EMAIL PROTECTED]
Signed-off-by: WANG Cong
noticed these warnings yet and had tried to fix them. But these ones are
not relatively easy to fix, since they are nested in some complex contexts.
Can we leave this job to Greg? (Add some CCs below.)
CC: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]
Regards!
WANG Cong
-
To unsubscribe from
=11762433536w=2
CC: Andrew Morton [EMAIL PROTECTED]
CC: Cornelia Huck [EMAIL PROTECTED]
Regards!
WANG Cong
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
On Sun, May 20, 2007 at 05:49:06PM +0200, Elimar Riesebieter wrote:
On Sun, 20 May 2007 the mental interface of
WANG Cong told:
On Sun, May 20, 2007 at 01:11:13PM +0200, Elimar Riesebieter wrote:
Hi,
FYI, building the kernel with
gcc (GCC) 4.1.3 20070514 (prerelease) (Debian 4.1.2-7)
on my
On Mon, Apr 30, 2007 at 06:33:09PM -0700, H. Peter Anvin wrote:
Hi all,
I'm rewriting the i386 setup code in C, instead of assembly, and before
I spend a very large amount of time translating all the various
card-specific probes, I want to ask the following question...
Does *anyone* care about
On Tue, May 01, 2007 at 10:53:52PM -0700, David Rientjes wrote:
On Wed, 2 May 2007, Alexey Dobriyan wrote:
On Tue, May 01, 2007 at 09:28:18PM -0700, David Rientjes wrote:
+#define __attribute_unused__ __attribute__((unused))
Suggest __unused which is shorter and looks
Hi Rusty!
I found you forgot to check the return value of copy_from_user, and here is the
fix for drivers/lguest/interrupts_and_traps.c.
Signed-off-by: WANG Cong [EMAIL PROTECTED]
---
--- linux-2.6.21-rc7-mm2/drivers/lguest/interrupts_and_traps.c.orig
2007-05-03 03:10:44.0 +0800
On Thu, May 03, 2007 at 03:33:03AM +0800, WANG Cong wrote:
Hi Rusty!
I found you forgot to check the return value of copy_from_user, and here is
the fix for drivers/lguest/interrupts_and_traps.c.
Also this one, in drivers/lguest/hypercalls.c.
Signed-off-by: WANG Cong [EMAIL PROTECTED
On Thu, May 03, 2007 at 09:00:48AM +1000, Rusty Russell wrote:
On Thu, 2007-05-03 at 03:33 +0800, WANG Cong wrote:
Hi Rusty!
I found you forgot to check the return value of copy_from_user, and
here is the fix for drivers/lguest/interrupts_and_traps.c.
Signed-off-by: WANG Cong [EMAIL
Fix this warning:
drivers/usb/misc/sisusbvga/sisusb_con.c:1436: warning: initialization from
incompatible pointer type
Signed-off-by: WANG Cong [EMAIL PROTECTED]
---
Compiling test past.;)
--- linux-2.6.21-rc7-mm2/drivers/usb/misc/sisusbvga/sisusb_con.c.orig
2007-05-03 02:51:06.0
On Thu, May 03, 2007 at 02:20:32PM +1000, Rusty Russell wrote:
On Thu, 2007-05-03 at 11:57 +0800, WANG Cong wrote:
On Thu, May 03, 2007 at 09:00:48AM +1000, Rusty Russell wrote:
Thanks for the patch. This omission (in several places) was
deliberate. We can't really do anything sensible
On Thu, May 03, 2007 at 11:14:50PM -0700, Andrew Morton wrote:
On Sat, 28 Apr 2007 13:30:23 +0800 WANG Cong [EMAIL PROTECTED] wrote:
Since 'sysfs_create_file' is declared with attribute warn_unused_result, we
must always check its return value carefully.
Well that's not really the reason
On Fri, May 04, 2007 at 01:40:04PM +0200, Jan Engelhardt wrote:
On May 4 2007 19:00, la deng wrote:
What's you think about it?
C gives you the power to control nearly everything. You can, of course, control
the registers via inserting assembly code. That's not the fault of C.
I think the
On Fri, May 04, 2007 at 09:53:34PM +0800, la deng wrote:
On 5/4/07, WANG Cong [EMAIL PROTECTED] wrote:
On Fri, May 04, 2007 at 01:40:04PM +0200, Jan Engelhardt wrote:
On May 4 2007 19:00, la deng wrote:
C gives you the power to control nearly everything. You can, of course,
control
On Mon, Apr 02, 2007 at 01:01:28PM +0200, Cornelia Huck wrote:
>On Sun, 1 Apr 2007 15:32:34 +0800,
>"Cong WANG" <[EMAIL PROTECTED]> wrote:
>
>> --- linux-2.6.21-rc5-mm3/fs/partitions/check.c.orig 2007-03-30
>> 21:35:45.0 +0800
>> +++ linux-2.6.21-rc5-mm3/fs/partitions/check.c
On Thu, Apr 05, 2007 at 11:11:42AM +0200, Cornelia Huck wrote:
>On Thu, 5 Apr 2007 12:54:11 +0800,
>WANG Cong <[EMAIL PROTECTED]> wrote:
>
>> --- linux-2.6.21-rc5-mm3/fs/partitions/check.c.orig 2007-03-30
>> 21:35:45.0 +0800
>> +++ linux-2.6.21-rc5-mm3/fs
On Thu, Apr 05, 2007 at 05:05:14PM +0200, Cornelia Huck wrote:
>On Thu, 5 Apr 2007 22:44:09 +0800,
>WANG Cong <[EMAIL PROTECTED]> wrote:
>
>> On Thu, Apr 05, 2007 at 11:11:42AM +0200, Cornelia Huck wrote:
>> >On Thu, 5 Apr 2007 12:54:11 +0800,
>>
On Thu, Apr 05, 2007 at 06:00:16PM +0200, Cornelia Huck wrote:
>On Thu, 5 Apr 2007 23:27:32 +0800,
>WANG Cong <[EMAIL PROTECTED]> wrote:
>
>> Thank you very much! I know. So I should replace all kfree with kobject_put,
>> like this one:
>>
>> -sys
On Thu, Apr 05, 2007 at 12:28:03PM -0500, Michael wrote:
>Hi, Dick,
>
>Your steps work beautifully. Thanks.
>
>If you could explain a little about what happens in each step, that
>would be even better.
>
>> # cd /usr/src/linux-2.6.20.3
>> If your current kernel is 2.6.20.3, edit the Makefile to
On Fri, Apr 06, 2007 at 09:23:38AM -0500, Michael wrote:
>Hi, Wang,
>
>Thanks for replying. So which step is doing the compilation of each
>module , "make oldconfig" or "make" ? For compilation, I mean the step
>to compile the source code to .o file.
>
>Regards,
>
>Mike
>
'Make' does that.
On Mon, Jun 18, 2007 at 06:25:17AM -0400, Robert P. J. Day wrote:
>On Mon, 18 Jun 2007, Denis Cheng wrote:
>
>> From: Denis Cheng <[EMAIL PROTECTED]>
>>
>> the explicit memset call could be optimized out by data initialization,
>> thus all the fill working can be done by the compiler implicitly.
On Tue, Jun 19, 2007 at 10:21:03PM +0800, Li Yang wrote:
>This is a Chinese translated version of Documentation/HOWTO. Currently
>Chinese involvement in Linux kernel is very low, especially comparing to
>its largest population base. Language could be the main obstacle. Hope
>this document will
On Thu, Apr 26, 2007 at 04:13:01PM -0700, H. Peter Anvin wrote:
>Michael McConnell wrote:
>> Hi folks,
>>
>> I noticed the MAINTAINERS file still lists Riley Williams as the
>> maintainer of the i386 boot code, presumably as no-one else has taken it
>> up in his absence (though, I'm sure it's
On Thu, Apr 26, 2007 at 06:12:43PM -0700, H. Peter Anvin wrote:
>WANG Cong wrote:
>>>
>>> I have considered myself as a rather unofficial maintainer of this code,
>>> and wouldn't mind make it official now when I actually have a job which
>>> both cares abo
On Thu, Apr 26, 2007 at 10:27:47PM -0700, H. Peter Anvin wrote:
>Eric W. Biederman wrote:
>> "H. Peter Anvin" <[EMAIL PROTECTED]> writes:
>>
>>> A lot of that code (although, of course, not all) could be written in C,
>>> though. I'm thinking of taking a stab at rewriting it that way.
>>
>> Is
On Tue, Apr 10, 2007 at 02:31:06PM +0200, Cornelia Huck wrote:
>On Fri, 6 Apr 2007 10:53:43 +0800,
>WANG Cong <[EMAIL PROTECTED]> wrote:
>
>> OK. Then I send it again. Hopefully it can be accepted this time. ;-p
>
>Looks sane. (Note that there is still a pathologi
On Tue, Apr 10, 2007 at 07:23:35AM -0400, Robert P. J. Day wrote:
>
>Following the programming advice laid down in the gcc manual, make
>sure the case "..." operator has spaces on either side.
>
>Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
>
Ack
On Tue, Apr 10, 2007 at 03:18:15PM -0700, Andrew Morton wrote:
>On Tue, 10 Apr 2007 22:08:29 +0800
>WANG Cong <[EMAIL PROTECTED]> wrote:
>
>> Since kobject_add, sysfs_create_link and sysfs_create_file are marked as
>> '__must_check', we must always check their return
On Wed, Apr 11, 2007 at 02:23:49PM +0800, Fengguang Wu wrote:
>On Sun, Apr 01, 2007 at 02:20:46PM +0800, Cong WANG wrote:
>> 2007/4/1, Andrew Morton <[EMAIL PROTECTED]>:
>> >
>> >Also, please always prepare patches in `patch -p1' form, as per
>>
On Sun, Jun 03, 2007 at 11:35:43AM -0400, Jeff Garzik wrote:
>Randy Dunlap wrote:
>>On Sun, 3 Jun 2007 15:29:39 +0100 Al Viro wrote:
>>
>>>On Sun, Jun 03, 2007 at 10:24:50PM +0800, WANG Cong wrote:
>>>
>>>>+Do care when you use Lindent to i
On Sun, Jun 03, 2007 at 11:59:26PM -0700, Jeremy Fitzhardinge wrote:
>WANG Cong wrote:
>> I just wonder, if a goto label is nested in a while/for/if/switch block,
>> aligning it in
>> the first column maybe a bit ugly. (I know mostly it is not in any
>>
Viro, Randy Dunlap, Jeff Garzik and Jeremy Fitzhardinge for their
comments!
Regards!
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
CodingStyle |7 +++
1 file changed, 7 insertions(+)
--- linux-2.6.22-rc3/Documentation/CodingStyle.orig 2007-06-04
15:53:58.0
On Mon, Jun 04, 2007 at 12:02:28PM -0700, Jeremy Fitzhardinge wrote:
>Sam Ravnborg wrote:
>> If local(__label__) really so widely used in the kernel that it deserves
>> a place in coding-style?
>> A quick grep did not say so.
>>
>
>Probably not, and its use shouldn't be (even tacitly)
On Mon, Jun 04, 2007 at 01:57:51PM -0400, Jeff Garzik wrote:
>On Mon, Jun 04, 2007 at 10:43:51AM -0700, H. Peter Anvin wrote:
>> Jan Engelhardt wrote:
>> > On Jun 4 2007 10:27, H. Peter Anvin wrote:
>> >> Jeff Garzik wrote:
>> >>> Seconded. All my code contains the goto label in the first column.
On Mon, Jun 04, 2007 at 07:31:27PM -0700, H. Peter Anvin wrote:
>Jeff Garzik wrote:
>>>
>>> So, it seems that we can reach an agreement. Any other comments or
>>> suggestions?
>>> Or can someone ack/merge this patch?
>>
>> Honestly, I think not reaching an agreement is a good thing.
>>
>>
On Tue, Jun 05, 2007 at 11:16:13AM +0200, Rene Herman wrote:
>On 06/05/2007 04:10 AM, WANG Cong wrote:
>
>>On Mon, Jun 04, 2007 at 01:57:51PM -0400, Jeff Garzik wrote:
>
>>>A matter of opinion :) I tend to think goto is special enough to
>>>warrant column 1 un
Second, mlguest.c #includes a head file named
"../../include/linux/lguest_launcher.h".
Since mlguest.c is in the top dir, so where is
../../include/linux/lguest_launcher.h?
Regards!
WANG Cong
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
On Wed, Jun 06, 2007 at 11:09:31AM -0700, Andrew Morton wrote:
>On Thu, 7 Jun 2007 00:19:36 +0800 WANG Cong <[EMAIL PROTECTED]> wrote:
>
>> On Wed, Jun 06, 2007 at 02:07:37AM -0700, Andrew Morton wrote:
>> >
>> >ftp://ftp.kernel.org/pub/linux/kernel/people/ak
On Thu, Jun 07, 2007 at 12:59:13AM -0500, Matt Mackall wrote:
>On Thu, Jun 07, 2007 at 10:26:09AM +0800, WANG Cong wrote:
>> On Wed, Jun 06, 2007 at 11:09:31AM -0700, Andrew Morton wrote:
>> >On Thu, 7 Jun 2007 00:19:36 +0800 WANG Cong <[EMAIL PROTECTED]> wrote:
>>
On Thu, Jun 07, 2007 at 09:04:44AM -0500, Matt Mackall wrote:
>On Thu, Jun 07, 2007 at 02:51:58PM +0800, WANG Cong wrote:
>> >> Maybe there's something wrong with ketchup. ;(
>> >
>> >Can you do an 'lsdiff | grep lguest' on the patch in your ~/.ketchup
>&
On Thu, Jun 07, 2007 at 10:59:14AM -0500, Matt Mackall wrote:
>On Thu, Jun 07, 2007 at 11:40:08PM +0800, WANG Cong wrote:
>> On Thu, Jun 07, 2007 at 09:04:44AM -0500, Matt Mackall wrote:
>> >On Thu, Jun 07, 2007 at 02:51:58PM +0800, WANG Cong wrote:
>> >> &g
On Thu, Jun 07, 2007 at 11:59:16AM -0500, Matt Mackall wrote:
>On Fri, Jun 08, 2007 at 12:39:30AM +0800, WANG Cong wrote:
>> >Ketchup doesn't even look inside patches, and patch doesn't invent
>> >names, so something in the bzip2 -> patch(1) -> filesystem chain
.
Could you please check and try this patch?
http://marc.info/?l=linux-mm-commits=11762433536=2
CC: Andrew Morton <[EMAIL PROTECTED]>
CC: Cornelia Huck <[EMAIL PROTECTED]>
Regards!
WANG Cong
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
t
On Sun, May 20, 2007 at 05:49:06PM +0200, Elimar Riesebieter wrote:
>On Sun, 20 May 2007 the mental interface of
>WANG Cong told:
>
>> On Sun, May 20, 2007 at 01:11:13PM +0200, Elimar Riesebieter wrote:
>> >Hi,
>> >
>> >FYI, building the kernel wit
On Thu, May 24, 2007 at 06:26:26PM +0200, Jan Engelhardt wrote:
>
>On May 24 2007 22:47, coly wrote:
>>
>>Dave,
>>
>>Yes, I found all TABs gone when I received the mail. When I post next
>>version of the patch, I will test to send to me first :-)
>>
>>Thanks for your information.
>
>Blame Gmail.
>
On Mon, May 28, 2007 at 06:30:38PM +0400, Cyrill Gorcunov wrote:
>This patch converts UDF coding style to kernel
>coding style using Lindent.
>
>Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]>
>---
>
> fs/udf/balloc.c| 709 ---
> fs/udf/crc.c | 19 +-
>
if (edac_mc_add_mc(mci,0)) {
>+ if (edac_mc_add_mc(mci, 0)) {
> debugf3("%s(): failed edac_mc_add_mc()\n", __func__);
> goto fail;
> }
>@@ -272,14 +270,14 @@ static int amd76x_probe1(struct pci_dev
> debugf3("%s(): success\n", __func__);
> return 0;
>
>-fail:
>+ fail:
> edac_mc_free(mci);
> return -ENODEV;
> }
>
I wonder whether Lindent is always use whitespaces, not tabs, before a label.
I think this should be fixed manually. And it seems that there shouldn't be any
spaces before the label 'fail' in this context.
Regards!
WANG Cong
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
in
CodingStyle. And it is
against -rc3 source tree.
Any advice or comments are more than welcome!
Regards!
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
CodingStyle |6 ++
1 file changed, 6 insertions(+)
--- linux-2.6.22-rc3/Documentation/CodingStyle.orig 2007-06-03
Can we care if the core infrastructure doesn't
>propogate the error returns?
>
>Flame away, I am prepared to ignore all opinions :-)
Hi!
I had noticed these warnings yet and had tried to fix them. But these ones are
not relatively easy to fix, since they are nested in some complex contexts.
Hi Rusty!
I found you forgot to check the return value of copy_from_user, and here is the
fix for drivers/lguest/interrupts_and_traps.c.
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
--- linux-2.6.21-rc7-mm2/drivers/lguest/interrupts_and_traps.c.orig
2007-05-03 03:10:44.000
On Thu, May 03, 2007 at 03:33:03AM +0800, WANG Cong wrote:
>Hi Rusty!
>
>I found you forgot to check the return value of copy_from_user, and here is
>the fix for drivers/lguest/interrupts_and_traps.c.
>
Also this one, in drivers/lguest/hypercalls.c.
Signed-off-by: WANG Cong &l
On Thu, May 03, 2007 at 09:00:48AM +1000, Rusty Russell wrote:
>On Thu, 2007-05-03 at 03:33 +0800, WANG Cong wrote:
>> Hi Rusty!
>>
>> I found you forgot to check the return value of copy_from_user, and
>> here is the fix for drivers/lguest/interrupts_and_traps.c.
>
Fix this warning:
drivers/usb/misc/sisusbvga/sisusb_con.c:1436: warning: initialization from
incompatible pointer type
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
Compiling test past.;)
--- linux-2.6.21-rc7-mm2/drivers/usb/misc/sisusbvga/sisusb_con.c.orig
2007-05-03
On Thu, May 03, 2007 at 02:20:32PM +1000, Rusty Russell wrote:
>On Thu, 2007-05-03 at 11:57 +0800, WANG Cong wrote:
>> On Thu, May 03, 2007 at 09:00:48AM +1000, Rusty Russell wrote:
>> >Thanks for the patch. This omission (in several places) was
>> >deliberate.
On Thu, May 03, 2007 at 11:14:50PM -0700, Andrew Morton wrote:
>On Sat, 28 Apr 2007 13:30:23 +0800 WANG Cong <[EMAIL PROTECTED]> wrote:
>
>> Since 'sysfs_create_file' is declared with attribute warn_unused_result, we
>> must always check its return value carefully.
>&
On Fri, May 04, 2007 at 01:40:04PM +0200, Jan Engelhardt wrote:
>
>On May 4 2007 19:00, la deng wrote:
>>
>> What's you think about it?
C gives you the power to control nearly everything. You can, of course, control
the registers via inserting assembly code. That's not the fault of C.
>
>I
On Fri, May 04, 2007 at 09:53:34PM +0800, la deng wrote:
>On 5/4/07, WANG Cong <[EMAIL PROTECTED]> wrote:
>>On Fri, May 04, 2007 at 01:40:04PM +0200, Jan Engelhardt wrote:
>>>
>>>On May 4 2007 19:00, la deng wrote:
>>>>
>>>>
>>
Since 'sysfs_create_file' is declared with attribute warn_unused_result, we
must always check its return value carefully.
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
--- linux-2.6.21-rc7-mm2/drivers/block/nbd.c.orig 2007-04-27
17:27:47.0 +0800
+++ linux-2.6.21-r
On Sat, Apr 28, 2007 at 08:03:42AM -0700, Arjan van de Ven wrote:
>
>> >
>> >
>> > i'd always assumed that the type flags of GFP_ATOMIC and GFP_KERNEL
>> > were mutually exclusive when it came to calling kmalloc(), at least
>> > based on everything i'd read. so i'm not sure how to interpret the
On Mon, Apr 30, 2007 at 06:33:09PM -0700, H. Peter Anvin wrote:
>Hi all,
>
>I'm rewriting the i386 setup code in C, instead of assembly, and before
>I spend a very large amount of time translating all the various
>card-specific probes, I want to ask the following question...
>
>Does *anyone* care
On Tue, May 01, 2007 at 10:53:52PM -0700, David Rientjes wrote:
>On Wed, 2 May 2007, Alexey Dobriyan wrote:
>
>> On Tue, May 01, 2007 at 09:28:18PM -0700, David Rientjes wrote:
>> > +#define __attribute_unused__ __attribute__((unused))
>>
>> Suggest __unused which is shorter and
Change C++ style comments into K's.
Cut long lines into pieces.
This patch is against 2.6.22.1, and can be also applied to
the last -mm tree.
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
tqm8xxl.c | 41 +
1 file changed, 25 insertions(
On Thu, Jul 12, 2007 at 11:11:58AM -0500, Josh Boyer wrote:
>On Thu, 2007-07-12 at 23:01 +0800, WANG Cong wrote:
{snip}
>> +/* trivial struct to describe partition information*/
>
>Needs a space at the end.
>
>> struct mtd_part_def
>> {
>> int nums;
On Fri, Jul 13, 2007 at 10:56:42AM +0100, David Woodhouse wrote:
>On Fri, 2007-07-13 at 11:48 +0800, WANG Cong wrote:
>> if(map_banks[idx] == NULL) {
>> ret = -ENOMEM;
>> - /* FIXME: What if some MTD devices we
On Fri, Jul 13, 2007 at 03:24:43PM +0100, Ralf Baechle wrote:
>On Fri, Jul 13, 2007 at 02:38:03PM +0100, David Woodhouse wrote:
>
>> > drivers/mtd/maps/pmcmsp-flash.c:63: error: 'ELB_1PC_EN_REG' undeclared
>> > (first use in this function)
>> > drivers/mtd/maps/pmcmsp-flash.c:63: error:
On Fri, Jul 13, 2007 at 03:31:29PM +0100, David Woodhouse wrote:
>On Fri, 2007-07-13 at 15:24 +0100, Ralf Baechle wrote:
>> +config MTD_PMC_MSP_EVM
>> + tristate "CFI Flash device mapped on PMC-Sierra MSP"
>> + depends on PMC_MSP && MTD_CFI
>> + select MTD_PARTITIONS
>>
>>
On Fri, Jul 13, 2007 at 06:09:02PM +0530, Anand Jahagirdar wrote:
>Hello All
{snip}
>Index: root/Desktop/a1/linux-2.6.17.tar.bz2_FILES/linux-2.6.17/kernel/fork.c
>===
>---
lly and pick up
>those which are really necessary.
Yes. I just give you my comments and hope you can consider them carefully.
Making the final decisions is still your work. ;)
Thanks!
WANG Cong
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
gt;+那个人修改。保证你的驱动永远都可以编译通过，并且一直工作，你几乎不需要
>+做什么事情。
>+
>+把驱动放到内核源代码树里会有很多的好处：
>+ - 驱动的质量会提升，而维护成本（对原始作者来说）会下降。
>+ - 其他人会给驱动添加新特性。
>+ - 其他人会找到驱动中的bug并修复。
>+ - 其他人会在驱动中找到性能优化的机会。
>+ - 当外部的接口的改变需要修改驱动程序的时候，其他人会修改驱动程序
>+。
>+ - 不需要联系任何发行商，这个驱动会自动的随着所有的linux发布一起发
>+布。
s/的/
his document will help more Chinese to contribute to Linux kernel.
>
>Signed-off-by: Li Yang <[EMAIL PROTECTED]>
>Signed-off-by: TripleX Chung <[EMAIL PROTECTED]>
>Signed-off-by: Maggie Chen <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
>--
b/Documentation/zh_CN/stable_api_nonsense.txt
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
Thanks! Looks nice this time.
Er, you forgot your signed-off-by?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTEC
document which describes and explains the non-technical things
needed by Linux kernel will help them _much_ to join the development soon.
Also, IMO, a translation shows Linux kernel is friendly and open to
people from all over the world.
Regards!
WANG Cong
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
ically http://kernel.org/doc (and
>I'll be completely redoing it as soon as I've recovered from my recent laptop
>crash and OLS).
>
>Send me translations (preferably in HTML format), and I'll put 'em up. (I've
>already got the one that started this thread.)
>
>Thanks,
>
1. There's no lists in fs/romfs/inode.c, so using list_entry is
a bit confusing. Replace it with container_of.
2. It is unnecessary to cast the return value of kmem_cache_alloc,
since it returns a void* pointer.
This patch is against 2.6.22.1.
Signed-off-by: WANG Cong <[EMAIL PROTEC
-by: TripleX Chung <[EMAIL PROTECTED]>
>>Signed-off-by: Maggie Chen <[EMAIL PROTECTED]>
>>Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
>>Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
>>---
>> Documentation/zh_CN/HOWTO | 536
>>
Fix this warning:
drivers/acpi/ec.c: In function `acpi_ec_ecdt_probe':
drivers/acpi/ec.c:873: warning: passing arg 1 of `acpi_get_devices' discards
qualifiers from pointer target type
(I don't know whether this fix hits the real problem.)
Signed-off-by: WANG Cong <[EMAIL PROTEC
201 - 300 of 477 matches
Mail list logo
