Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-03-31 Thread Wolfram Sang
On Tue, Mar 11, 2014 at 09:50:12AM -0700, Soren Brinkmann wrote: Add a driver for the Cadence I2C controller. This controller is for example found in Xilinx Zynq. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com ... +static irqreturn_t cdns_i2c_isr(int irq, void *ptr) +{ +

Re: [PATCH] avr32: remove cpu_data macro to fix compiles

2014-04-01 Thread Wolfram Sang
On Mon, Feb 24, 2014 at 08:28:20AM +0100, Hans-Christian Egtvedt wrote: Around Sat 22 Feb 2014 09:28:27 +0100 or thereabout, Wolfram Sang wrote: Having cpu_data as a parameterless macro can easily cause build failures because it can be a variable name like in linux/pm_domain.h [1]. So

Re: [PATCH] avr32: remove cpu_data macro to fix compiles

2014-04-01 Thread Wolfram Sang
I sent a pull request to Torvalds some hours ago, the branch is available at https://git.kernel.org/cgit/linux/kernel/git/egtvedt/linux-avr32.git/log/?h=for-linus Thanks! signature.asc Description: Digital signature

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-04-03 Thread Wolfram Sang
Please don't quote large parts of the message f you are not referring to it. +#ifdef CONFIG_PM_SLEEP +/** + * cdns_i2c_suspend - Suspend method for the driver + * @_dev: Address of the platform_device structure + * Return: 0 always + * + * Put the driver into low power mode. +

Re: [PATCH v10] i2c: exynos5: add High Speed I2C controller driver

2013-07-01 Thread Wolfram Sang
On Wed, Jun 19, 2013 at 04:18:25PM +0530, Naveen Krishna Chatradhi wrote: Adds support for High Speed I2C driver found in Exynos5 and later SoCs from Samsung. Driver only supports Device Tree method. Changes since v1: 1. Added FIFO functionality 2. Added High speed mode functionality 3.

Re: [PATCH v3 2/4] i2c: Kontron PLD i2c bus driver

2013-07-01 Thread Wolfram Sang
On Sun, Jun 23, 2013 at 09:00:04PM -0700, Kevin Strasser wrote: Add i2c support for the on-board PLD found on some Kontron embedded modules. Originally-From: Michael Brunner michael.brun...@kontron.com Signed-off-by: Kevin Strasser kevin.stras...@linux.intel.com Acked-by: Guenter Roeck

[PATCH] i2c: scx200: drop GPIO based i2c driver

2014-07-09 Thread Wolfram Sang
This driver is marked as deprecated since the pre-git era. Any user left(?) should really have switched to i2c-gpio meanwhile. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/Kconfig | 31 -- drivers/i2c/busses/Makefile | 1 - drivers/i2c/busses

[PATCH 04/16] i2c: i2c-bfin-twi: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-bfin-twi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin

[PATCH 00/16] i2c: drop class based instantiaion for selected drivers

2014-07-10 Thread Wolfram Sang
Wolfram Sang (16): i2c: add debug info when class instantiation was dropped i2c: i2c-at91: Drop class based scanning to improve bootup time i2c: i2c-bcm2835: Drop class based scanning to improve bootup time i2c: i2c-bfin-twi: Drop class based scanning to improve bootup time i2c: i2c-davinci

[PATCH 07/16] i2c: i2c-mv64xxx: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-mv64xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c

[PATCH 13/16] i2c: i2c-sirf: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-sirf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-sirf.c b/drivers/i2c/busses/i2c-sirf.c index

[PATCH 09/16] i2c: i2c-ocores: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. While we are here, remove the indentation for the array setup because such things always break after some time. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-ocores.c | 12 ++-- 1

[PATCH 14/16] i2c: i2c-stu300: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-stu300.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c

[PATCH 16/16] i2c: i2c-xiic: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. While we are here, remove the indentation for the array setup because such things always break after some time. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-xiic.c | 12 ++-- 1 file

[PATCH 15/16] i2c: i2c-tegra: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c

[PATCH 12/16] i2c: i2c-s3c2410: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. While we are here, remove the indentation for the array setup because such things always break after some time. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-s3c2410.c | 8 1 file

[PATCH 11/16] i2c: i2c-rcar: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. While we are here, remove the indentation for the array setup because such things always break after some time. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-rcar.c | 14 +++--- 1

[PATCH 08/16] i2c: i2c-nomadik: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. While we are here, remove the indentation for the array setup because such things always break after some time. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-nomadik.c | 8 1 file

[PATCH 10/16] i2c: i2c-omap: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index

[PATCH 06/16] i2c: i2c-designware-platdrv: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-designware-platdrv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers

[PATCH 03/16] i2c: i2c-bcm2835: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835

[PATCH 05/16] i2c: i2c-davinci: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-davinci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c

[PATCH 02/16] i2c: i2c-at91: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
that the behaviour finally changed now. After another transition period, this flag can go, too. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-at91.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index

[PATCH 01/16] i2c: add debug info when class instantiation was dropped

2014-07-10 Thread Wolfram Sang
they are missing devices after the change. However, there is enough interest to get rid of class based instantiation rather sooner than later because it improves boot up time. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/i2c-core.c | 10 ++ 1 file changed, 10 insertions

Re: [PATCH v3] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc

2014-07-10 Thread Wolfram Sang
Ok then, Wolfram! Keep only: ereqirq: clk_disable_unprepare(i2c-clk); And let everyone else just return? I haven't looked at the details, but when you simply can return, do it. It is rather pointless to add something in a patch, to remove it in the next. Yup, just say in the

[PULL REQUEST] i2c for 3.16

2014-07-10 Thread Wolfram Sang
Linus, here is one buildfix for the i2c subsystem. While here, I decided to add the header cleanup as well. Please pull. Thanks, Wolfram The following changes since commit a497c3ba1d97fc69c1e78e7b96435ba8c2cb42ee: Linux 3.16-rc2 (2014-06-21 19:02:54 -1000) are available in the git

Re: [PATCH 00/16] i2c: drop class based instantiaion for selected drivers

2014-07-10 Thread Wolfram Sang
+ /* Warn that the adapter lost class based instantiation */ + if (adapter-class == I2C_CLASS_DEPRECATED) { + dev_dbg(adapter-dev, + This adapter dropped support for I2C classes and + won't auto-detect %s devices anymore. If you need

[PATCH 0/3] Remove devm_request_and_ioremap()

2014-06-19 Thread Wolfram Sang
interested in picking it up? Wolfram Tushar Behera (2): DRM: Armada: Use devm_ioremap_resource lib: devres: Remove deprecated devm_request_and_ioremap Wolfram Sang (1): bus: brcmstb_gisb: Use devm_ioremap_resource Documentation/driver-model/devres.txt | 1 - drivers/bus/brcmstb_gisb.c

[PATCH 2/3] bus: brcmstb_gisb: Use devm_ioremap_resource

2014-06-19 Thread Wolfram Sang
From: Wolfram Sang w...@sang-engineering.com devm_request_and_ioremap is deprecated. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/bus/brcmstb_gisb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c

[PATCH 3/3] lib: devres: Remove deprecated devm_request_and_ioremap

2014-06-19 Thread Wolfram Sang
From: Tushar Behera tushar.beh...@linaro.org Now that all the users of devm_request_and_ioremap have been converted to use devm_ioremap_resource, remove it. Also remove the entries from Documentation. Signed-off-by: Tushar Behera tushar.beh...@linaro.org Signed-off-by: Wolfram Sang w

[PATCH 1/3] DRM: Armada: Use devm_ioremap_resource

2014-06-19 Thread Wolfram Sang
From: Tushar Behera tushar.beh...@linaro.org While at it, propagate the error code. Signed-off-by: Tushar Behera tushar.beh...@linaro.org Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/gpu/drm/armada/armada_crtc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff

Re: [PATCH 0/3] Remove devm_request_and_ioremap()

2014-06-19 Thread Wolfram Sang
On Thu, Jun 19, 2014 at 08:48:58PM +0200, Wolfram Sang wrote: Pretty much a year ago, Tushar cleaned up a lot of deprecated uses of devm_request_and_ioremap, yet some remains are still left. Remove the last two users, and let the function rest in peace. I'd suggest that this series is picked

Re: [PATCH 0/3] Remove devm_request_and_ioremap()

2014-06-20 Thread Wolfram Sang
I already sent the same patch as one single patch to Greg Kroah-Hartman. [1] Also, it was accepted by Greg Kroah-Hartman. [2] Thank you. [1] https://lkml.org/lkml/2014/6/11/26 [2] https://lkml.org/lkml/2014/6/11/649 Yeah, I'll go apply that right now while I'm remembering it :) Yay,

Re: [PATCH 0/3] Remove devm_request_and_ioremap()

2014-06-20 Thread Wolfram Sang
On Thu, Jun 19, 2014 at 07:59:57PM -0700, 'Greg Kroah-Hartman' wrote: On Fri, Jun 20, 2014 at 11:36:03AM +0900, Jingoo Han wrote: On Friday, June 20, 2014 3:49 AM, Wolfram Sang wrote: Pretty much a year ago, Tushar cleaned up a lot of deprecated uses of devm_request_and_ioremap, yet

[PATCH 0/2] use correct type for dma_map/unmap

2014-07-21 Thread Wolfram Sang
I recently stumbled over the fact that the Atmel I2C driver used a wrong enum for mapping dma, so I wrote a hackish coccinelle script to check the rest of the kernel. Luckily, only those two were found. Wolfram Sang (2): drivers/i2c/busses: use correct type for dma_map/unmap drivers/tty

[PATCH 2/2] drivers/tty/serial: use correct type for dma_map/unmap

2014-07-21 Thread Wolfram Sang
dma_{un}map_* uses 'enum dma_data_direction' not 'enum dma_transfer_direction'. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/tty/serial/atmel_serial.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial

[PATCH 1/2] drivers/i2c/busses: use correct type for dma_map/unmap

2014-07-21 Thread Wolfram Sang
dma_{un}map_* uses 'enum dma_data_direction' not 'enum dma_transfer_direction'. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-at91.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c

Re: [PATCH] drivers: i2c: i2c-st: Update i2c timings

2014-07-21 Thread Wolfram Sang
Sorry for the late reply, but it took time to get the answer. No problem, thanks for keeping at it. Which also came from the HW guys? Please ask for details why 10%, too. This is a safety margin. I understood that. Still why 10%? Is it randomly guessed? Was 5% the first working value, so

Re: [Patch V3 4/5] I2C/ACPI: Add i2c ACPI operation region support

2014-06-27 Thread Wolfram Sang
On Tue, May 20, 2014 at 08:59:23PM +0800, Lan Tianyu wrote: ACPI 5.0 spec(5.5.2.4.5) defines GenericSerialBus(i2c, spi, uart) operation region. It allows ACPI aml code able to access such kind of devices to implement some ACPI standard method. ACPI Spec defines some access attribute to

Re: [Patch V3 5/5] I2C/ACPI: Clean up I2C ACPI code and Add CONFIG_I2C_ACPI config

2014-06-27 Thread Wolfram Sang
On Tue, May 20, 2014 at 08:59:24PM +0800, Lan Tianyu wrote: Clean up ACPI related code in the i2c core and add CONFIG_I2C_ACPI to enable I2C ACPI code. Current there is a race between removing I2C ACPI operation region and ACPI AML code accessing. So make i2c core built-in if CONFIG_I2C_ACPI

Re: [PATCH] i2c-taos-evm: Use module_serio_driver()

2014-06-27 Thread Wolfram Sang
On Fri, Jun 13, 2014 at 09:52:24PM +0200, Christoph Jaeger wrote: Get rid of some boilerplate code by using module_serio_driver(). Signed-off-by: Christoph Jaeger christophjae...@linux.com Applied to for-next, thanks! signature.asc Description: Digital signature

Re: [PATCH] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc

2014-06-27 Thread Wolfram Sang
On Tue, Jun 03, 2014 at 11:30:34PM +0200, Rickard Strandqvist wrote: Fix for possible null pointer dereferenc, and there is a risk for memory leak in when something unexpected happens and the function returns. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se ---

Re: [PATCH v2 07/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-06-27 Thread Wolfram Sang
-by: Wolfram Sang w...@the-dreams.de signature.asc Description: Digital signature

Re: [PATCH v2 09/10] mfd: cros_ec: ec_dev-cmd_xfer() returns number of bytes received from EC

2014-06-27 Thread Wolfram Sang
...@chromium.org Signed-off-by: Doug Anderson diand...@chromium.org Acked-by: Lee Jones lee.jo...@linaro.org Reviewed-by: Simon Glass s...@chromium.org For the I2C part: Acked-by: Wolfram Sang w...@the-dreams.de signature.asc Description: Digital signature

Re: [PATCH] i2c: cros_ec: Remove EC_I2C_FLAG_10BIT

2014-06-27 Thread Wolfram Sang
cleanup series? Reviewed-by: Wolfram Sang w...@the-dreams.de signature.asc Description: Digital signature

Re: [PATCH] i2c: cros_ec: Remove EC_I2C_FLAG_10BIT

2014-06-27 Thread Wolfram Sang
Thanks, that sounds reasonable to me. Lee has Acked the whole series and Simon Glass has reviewed it too, so I'd imagine that we're just waiting on the input subsystem's Ack on a few of the patches. OK. I assume it will go in via the same tree as the cleanup series to simplify dependencies;

Re: [PATCH] clocksource: tidyup Kconfig typo for MTU2

2014-07-08 Thread Wolfram Sang
On Tue, Jul 08, 2014 at 12:30:02AM -0700, Kuninori Morimoto wrote: From: Kuninori Morimoto kuninori.morimoto...@renesas.com It should be MTU2 instead of TMU2 Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- Obviously: Acked-by: Wolfram Sang w...@sang-engineering.com

Re: [PATCH v2] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc

2014-07-03 Thread Wolfram Sang
Hi Rickard, hi Jingoo, I also trust Wolfram. He is one of the most important and active person for Linux kernel. Oh, thanks. I'm flattered :) Wolfram may mean devm_ioremap_resource(), not devm_ioremap(). Yes, you are right. Sorry for missing this detail when suggesting an example to convert

Re: [PATCH] i2c: fix a potential kmemleak of adapter device

2013-12-20 Thread Wolfram Sang
On Wed, Dec 18, 2013 at 09:18:08AM +0800, Gu Zheng wrote: When running with the latest kernel, we get the following kmemleak message: unreferenced object 0x8800c2a36100 (size 256): comm modprobe, pid 629, jiffies 4294676002 (age 1531.115s) hex dump (first 32 bytes): 00 00 00 00 ad

Re: [PATCH 1/2 v3] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

2014-02-07 Thread Wolfram Sang
On Thu, Feb 06, 2014 at 02:50:51PM +0100, Tomasz Figa wrote: Also, please use correct addresses of DT ML and Wolfram's e-mail (fixed in this message). And please don't use In-Reply-To when sending new versions of patches. The message threading became hard to read here... signature.asc

Re: [PATCH] i2c: scx200: drop GPIO based i2c driver

2014-07-16 Thread Wolfram Sang
On Wed, Jul 09, 2014 at 04:27:09PM +0200, Wolfram Sang wrote: This driver is marked as deprecated since the pre-git era. Any user left(?) should really have switched to i2c-gpio meanwhile. Signed-off-by: Wolfram Sang w...@the-dreams.de Applied to for-next, thanks! signature.asc

Re: [PATCH v3] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-07-16 Thread Wolfram Sang
On Wed, Jun 25, 2014 at 09:39:20AM -0700, Doug Anderson wrote: The original code for the exynos i2c controller registered for the noirq variants. However during review feedback it was moved to SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no longer actually noirq (despite

Re: [PATCH v2] i2c: s3c2410: resume the I2C controller earlier

2014-07-16 Thread Wolfram Sang
On Tue, Jun 24, 2014 at 04:56:54PM -0700, Doug Anderson wrote: From: Vincent Palatin vpala...@chromium.org When the wake-up is triggered by the PMIC RTC, the RTC driver is trying to read the PMIC interrupt status over I2C and fails because the I2C controller is not resumed yet. Let's resume

Re: [PATCH 00/16] i2c: drop class based instantiaion for selected drivers

2014-07-16 Thread Wolfram Sang
On Thu, Jul 10, 2014 at 01:46:20PM +0200, Wolfram Sang wrote: Some drivers were flagged to remove class based instantiation soon to improve boot-up time. Originally, I was planning for a longer deprecation time so users could switch over to some other kind of instantiation. However

Re: [PATCH 1/2 v2] i2c: exynos5: remove an unnecessary read of FIFO_STATUS register

2014-07-17 Thread Wolfram Sang
On Thu, Jun 26, 2014 at 10:44:57AM +0530, Naveen Krishna Chatradhi wrote: This patch removes an extra read of FIFO_STATUS register in the interrrupt service routine. Which is read again before the actual use. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Applied to for-next,

Re: [PATCH 2/2 v2] i2c: exynos5: remove extra line and fix an assignment

2014-07-17 Thread Wolfram Sang
On Thu, Jun 26, 2014 at 10:44:58AM +0530, Naveen Krishna Chatradhi wrote: This patch does the following in exynos5_i2c_message_start() function 1. Fixes an assignment As, i2c_auto_conf is initialized to '0' at the beginning of the function and HSI2C_READ_WRITE is defined as (1u 16)

Re: [PATCH v3 0/7] i2c: Relax mandatory I2C ID table passing

2014-07-17 Thread Wolfram Sang
On Thu, Jul 17, 2014 at 11:23:42AM +0100, Lee Jones wrote: Hi Wolfram, Are you going to take a lot at this set? Sure thing, yet I won't make it for 3.17, sadly :( It has high priority for 3.18, though. signature.asc Description: Digital signature

Re: [PATCH v2] i2c: stub: Add support for SMBus block commands

2014-07-17 Thread Wolfram Sang
On Mon, Jul 07, 2014 at 07:23:03AM -0700, Guenter Roeck wrote: SMBus block commands are different to I2C block commands since the returned data is not normally accessible with byte or word commands on other command offsets. Add linked list of 'block' commands to support those commands.

Re: [PATCH v2 1/5] i2c: Don't start transfers when suspended

2014-07-17 Thread Wolfram Sang
On Thu, Jul 17, 2014 at 04:58:17PM +0200, Bastian Hecht wrote: I want to add the remark that I can't help further on the patch series in the next month about. So this is free to be taken/ignored/modified without any approval by my side. Good to know. I'd like to get some Tested-by tags before

Re: [PATCH v3] i2c: stub: Add support for SMBus block commands

2014-07-17 Thread Wolfram Sang
On Thu, Jul 17, 2014 at 09:56:03AM -0700, Guenter Roeck wrote: SMBus block commands are different to I2C block commands since the returned data is not normally accessible with byte or word commands on other command offsets. Add linked list of 'block' commands to support those commands.

Re: I2C Slave monitor mode support

2014-07-18 Thread Wolfram Sang
Currently, one would have to put a loop on the address transfer waiting an ack is received in user space. This is what most i2c master drivers would need to do anyhow. I have never heard of hardware support for that. Do you know an IP core which does that? And how are timeouts defined/handled?

Re: [PATCH v3 0/7] i2c: Relax mandatory I2C ID table passing

2014-08-22 Thread Wolfram Sang
Sure thing, yet I won't make it for 3.17, sadly :( It has high priority for 3.18, though. Do you want me to re-send now the -rc1 had been released? I think this version will do for an initial review. Thanks, Wolfram signature.asc Description: Digital signature

Re: [PATCH/RFC V8 1/1] clk: Support for clock parents and rates assigned from device tree

2014-08-01 Thread Wolfram Sang
. Yes, Acks from SPI and I2C maintainers would be good. I might need to drop those parts of this patch if they don't come through :-( For the I2C part: Acked-by: Wolfram Sang w...@the-dreams.de signature.asc Description: Digital signature

Re: [PATCH v2] drivers: i2c: i2c-st: Update i2c timings

2014-08-01 Thread Wolfram Sang
On Wed, Jul 23, 2014 at 05:44:07PM +0200, Maxime COQUELIN wrote: The i2c timing values specified in the driver are the minimun values defined in the I2C specifications. The I2C specification does not specify any default or maximum values. Some I2C devices are out of spec, such as the HDMI

Re: [PATCH v2] i2c: pca954x: put the mux to disconnected state after resume

2014-08-01 Thread Wolfram Sang
On Fri, Jul 25, 2014 at 07:57:46PM +0800, Jisheng Zhang wrote: pca954x may be power lost during suspend, so after resume we also suffer the issue fixed by commit cd823db8b1161ef0d756514d280715a576d65cc3, pca954x power-on default is channel 0 connected. If multiple pca954x muxes are

Re: [PATCH v4] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereference

2014-08-02 Thread Wolfram Sang
Hi, res = platform_get_resource(dev, IORESOURCE_MEM, 0); irq = platform_get_irq(dev, 0); - if (res == NULL || irq 0) { - ret = -ENODEV; - goto eclk; - } + if (res == NULL || irq 0) + return -ENODEV; No need to check for valid

Re: [PATCH] i2c: designware: deduce speed mode from device tree setting

2014-08-20 Thread Wolfram Sang
With the patch i2c designware add support of I2C standard mode I already proposed: - I2C standard mode is selected with 100kHz clock frequency. - I2C fast mode is selected with 400kHy clock frequency. - EINVAL error is returned if clock frequency is not 10 and not 40. You forgot to

Re: [PATCH] i2c: designware: deduce speed mode from device tree setting

2014-08-20 Thread Wolfram Sang
+ + ret = of_property_read_u32(pdev-dev.of_node, + clock-frequency, bus_rate); + if (!ret (bus_rate = 10)) + speed = DW_IC_CON_SPEED_STD; This looks a bit odd. If the device only supports two particular

[PULL REQUEST] i2c for 3.17

2014-08-20 Thread Wolfram Sang
I2C_ACPI Wolfram Sang (1): MAINTAINERS: add maintainer for ACPI parts of I2C MAINTAINERS | 7 +++ drivers/i2c/Kconfig | 15 ++- drivers/i2c/Makefile | 2 +- drivers/i2c/busses/i2c-i801.c | 2 ++ drivers/i2c/i2c-acpi.c| 2

Re: [PATCH] i2c: rk3x: fix bug that cause transfer fails in master receive mode

2014-08-21 Thread Wolfram Sang
On Thu, Aug 21, 2014 at 10:04:31PM +0400, Sergei Shtylyov wrote: Hello. On 08/21/2014 09:50 PM, Addy Ke wrote: In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data in one transaction, so the size of data to be write/read to/from TXDATAx/RXDATAx must be less than or

Re: [PATCH] i2c: rk3x: fix bug that cause transfer fails in master receive mode

2014-08-21 Thread Wolfram Sang
Actually, reads with 32 bytes of data are possible with the controller. The hw returns the data in 32 byte chunks. Our chunk handling code is just buggy. Understood. Then, I'd prefer 'chunk' in the commit message instead of 'transaction'. signature.asc Description: Digital signature

Re: Trickle charging for rtc-bq32k

2014-08-22 Thread Wolfram Sang
_But_ this should probably be enabled using device tree entry, right? Unfortunately, the driver is i2c driver, not platform one, so I don't see how to do that easily... Trickle charging is usually depending on the hardware setup, so devicetree is actually a good place to put it. We'd just

Re: [PATCH] I2C: Make I2C core able to be module when I2C_ACPI is selected.

2014-08-12 Thread Wolfram Sang
On Tue, Aug 12, 2014 at 12:53:21PM +0300, Mika Westerberg wrote: On Mon, Aug 11, 2014 at 03:00:55PM +0800, Lan Tianyu wrote: Commit da3c6647(I2C/ACPI: Clean up I2C ACPI code and Add CONFIG_I2C_ACPI config) adds a new kernel config I2C_ACPI and make I2C core built in when the config is

Re: [PATCH] I2C: Make I2C core able to be module when I2C_ACPI is selected.

2014-08-14 Thread Wolfram Sang
True, but only the I2C OpRegion parts needs to have I2C=y. Does it make sense to name ACPI_I2C to ACPI_I2C_OPREGION (or something like that) and only enable it when I2C=y? Then we would have ACPI I2C enumeration still in place. Yes, this makes sense to me. I will rewrite the patch.

Re: [can-next PATCH 1/1] net: can: c_can_platform: Use devm_ioremap instead of devm_ioremap_resource.

2014-07-25 Thread Wolfram Sang
Am 25-07-2014 08:19, schrieb Mugunthan V N: From: George Cherian george.cher...@ti.com The raminit register is shared register for both can0 and can1. Using devm_ioremap_resource fails the mapping for can1 interface leading to a non functional can interface. Signed-off-by: George Cherian

Re: [PATCH v6 1/2] i2c: imx: add DMA support for freescale i2c driver

2014-08-06 Thread Wolfram Sang
static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx, struct i2c_msg *msgs) run checkpatch.pl on this patch... Sorry for my code style. I will match open parenthesis in this case. FYI, I am not strict on the open parenthesis thingie. signature.asc

Re: [PATCH] i2c: remove unnecessary 'else' after 'return' statement

2014-08-06 Thread Wolfram Sang
On Wed, Aug 06, 2014 at 12:36:05PM +0530, Kiran Padwal wrote: Fix the following warning reported by checkpatch.pl: WARNING: else is not generally useful after a break or return Signed-off-by: Kiran Padwal kiran.pad...@smartplayin.com Technically true, yet I think the original code is a tad

Re: [PATCHv2] i2c: i2c-imx: Fix format warning for dev_dbg

2014-08-06 Thread Wolfram Sang
On Wed, Aug 06, 2014 at 11:45:08AM +0800, Xiubo Li wrote: drivers/i2c/busses/i2c-imx.c: In function i2c_imx_probe() drivers/i2c/busses/i2c-imx.c:689:2: warning: format 0x%x expects argument of type unsigned int, but argument 4 has type resource_size_t [-Wformat=] dev_dbg(i2c_imx-adapter.dev,

Re: [PATCH] i2c: rk3x: fix interrupt handling issue

2014-08-08 Thread Wolfram Sang
On Fri, Aug 08, 2014 at 05:41:40PM +0800, Addy Ke wrote: If slave holds scl, I2C_IPD[7] will be set 1 by controller for debugging. Driver must ignore it. [5.752391] rk3x-i2c ff16.i2c: unexpected irq in WRITE: 0x80 [5.939027] rk3x-i2c ff16.i2c: timeout, ipd: 0x80, state: 4

Re: [PATCH 1/14] i2c: mpc: delete unneeded test before of_node_put

2014-08-08 Thread Wolfram Sang
On Fri, Aug 08, 2014 at 12:07:42PM +0200, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows:

[PULL REQUEST] i2c for 3.17

2014-08-09 Thread Wolfram Sang
: always enable HSI2C Uwe Kleine-König (1): i2c: efm32: correct namespacing of location property Vincent Palatin (1): i2c: s3c2410: resume the I2C controller earlier Wolfram Sang (19): i2c: s6000: remove duplicate driver i2c: scx200: drop GPIO based i2c driver i2c: add

Re: [PATCH] i2c: qup: disable clks and return instead of just returning error

2014-08-09 Thread Wolfram Sang
. So this patch adds a statement to jump to the fail lable to release the clocks. CC: Wolfram Sang w...@the-dreams.de CC: Grant Likely grant.lik...@linaro.org CC: Bjorn Andersson bjorn.anders...@sonymobile.com CC: Andy Gross agr...@codeaurora.org CC: Ivan T. Ivanov iiva...@mm-sol.com

Re: [PATCH] misc: ti-st: st_kim.c: Cleaning up missing null-terminate after strncpy call

2014-08-11 Thread Wolfram Sang
strncpy(kim_data-dev_name, buf, count); + kim_data-dev_name[count - 1] = '\n'; Of course this does not add termination, but adds a newline at the end of the buffer? Huh? strlcpy? signature.asc Description: Digital signature

Re: [PATCH V2] I2C: Rework kernel config I2C_ACPI

2014-08-15 Thread Wolfram Sang
On Fri, Aug 15, 2014 at 01:38:59PM +0800, Lan Tianyu wrote: Commit da3c6647(I2C/ACPI: Clean up I2C ACPI code and Add CONFIG_I2C_ACPI config) adds a new kernel config I2C_ACPI and make I2C core built in when the config is selected. This is wrong because distributions etc generally compile I2C

Re: [PATCH 1/2] regmap: Add eplicit dependencies to catch select misuse

2014-08-17 Thread Wolfram Sang
to find out which module did the offending select. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Acked-by: Wolfram Sang w...@the-dreams.de signature.asc Description: Digital signature

Re: [PATCH] i2c: i801: Add PCI ID for Intel Braswell

2014-08-19 Thread Wolfram Sang
On Tue, Aug 19, 2014 at 05:37:28PM +0300, Mika Westerberg wrote: From: Alan Cox a...@linux.intel.com The SMBus host controller is the same as used in Baytrail so add the new PCI ID to the driver's list of supported IDs. Signed-off-by: Alan Cox a...@linux.intel.com Signed-off-by: Mika

Re: [PATCH V2] I2C: Rework kernel config I2C_ACPI

2014-08-19 Thread Wolfram Sang
On Fri, Aug 15, 2014 at 01:38:59PM +0800, Lan Tianyu wrote: Commit da3c6647(I2C/ACPI: Clean up I2C ACPI code and Add CONFIG_I2C_ACPI config) adds a new kernel config I2C_ACPI and make I2C core built in when the config is selected. This is wrong because distributions etc generally compile I2C

[PATCH] MAINTAINERS: add maintainer for ACPI parts of I2C

2014-08-19 Thread Wolfram Sang
Mika has done great work in that field, so let people know. Signed-off-by: Wolfram Sang w...@the-dreams.de --- Mika: What do you think? Your help is very valuable and I'd like to make that official :) MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b

Re: [PATCH] MAINTAINERS: add maintainer for ACPI parts of I2C

2014-08-19 Thread Wolfram Sang
On Tue, Aug 19, 2014 at 06:31:14PM +0300, Mika Westerberg wrote: On Tue, Aug 19, 2014 at 10:16:21AM -0500, Wolfram Sang wrote: Mika has done great work in that field, so let people know. Signed-off-by: Wolfram Sang w...@the-dreams.de --- Mika: What do you think? Your help is very

Re: [PATCH 1/2] i2c: designware: device tree bindings for i2c speed mode

2014-08-19 Thread Wolfram Sang
On Tue, Aug 19, 2014 at 01:34:35PM -0500, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com Add speed-mode Device Tree property to select between standard and fast i2c mode. Previously, driver was hardwired as fast mode. Default to fast mode if property is not

Re: [PATH v3 0/4] i2c: show and change bus frequency via sysfs

2014-10-16 Thread Wolfram Sang
On Wed, Oct 15, 2014 at 11:03:27PM +0300, Octavian Purdila wrote: This patch series adds support to show and change the bus frequency via sysfs, by exposing files to show the minimum, maximum and current frequency as well as allowing the frequency to be changed. This allows the user to view or

Re: [PATCH v8 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-10-16 Thread Wolfram Sang
...@intel.com For the I2C part: Acked-by: Wolfram Sang w...@the-dreams.de I assume this goes together with the other patches. If I should pick it, let me know. signature.asc Description: Digital signature

Re: [PATCH 2/4] i2c-i801: Add Device IDs for Intel Sunrise Point PCH

2014-10-16 Thread Wolfram Sang
On Mon, Oct 13, 2014 at 03:20:24PM -0700, James Ralston wrote: This patch adds the I2C/SMBus Device IDs for the Intel Sunrise Point PCH. Signed-off-by: James Ralston james.d.rals...@intel.com Applied to for-next, thanks! signature.asc Description: Digital signature

Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver

2014-10-16 Thread Wolfram Sang
On Thu, Oct 16, 2014 at 10:15:08AM +0200, Andreas Werner wrote: Added driver to support the MEN Board Information EEPROM. The driver exports the production information as read only sysfs entries, as well as a user section which is read/write accessible. Tested on PPC QorIQ and Intel Atom

Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver

2014-10-16 Thread Wolfram Sang
On Thu, Oct 16, 2014 at 11:34:14AM +0200, Greg KH wrote: On Thu, Oct 16, 2014 at 10:58:35AM +0200, Wolfram Sang wrote: +struct eeprom_data { + uint8_t eeprod_id; + + uint8_t revision[3]; + uint32_t serialnr; + uint8_t board_model; + char hw_name[6]; + + uint8_t reserved

Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver

2014-10-16 Thread Wolfram Sang
I do not want to parse the things in userspace because this EEPROM data are related to the hardware and i want to give our customer the easiest way to access the data without installing any tool. I understand that point of view. From an upstream point of view, things may look different,

[PULL REQUEST] i2c for 3.18

2014-10-18 Thread Wolfram Sang
of match table Tan, Raymond (1): i2c: designware: add support of platform data to set I2C mode Wei Yan (1): i2c: hix5hd2: add i2c controller driver Wolfram Sang (1): i2c: rcar: remove sign-compare flaw james.d.rals...@intel.com (1): i2c: i801: Add Device IDs for Intel

Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver

2014-10-20 Thread Wolfram Sang
Most customers wants just to have a running system without installing anything. And for me an EEPROM is so simple and should not need a complicated way to access it. As I pointed out, there are ways to do it other than a seperate driver. Yes of course there are a lot of possibilities.

Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver

2014-10-20 Thread Wolfram Sang
Here it gets frustrating. It seems you have no idea what an OS is for, not even after I tried to describe it :( Sorry, that might have been too strong. Still, we can't map any hardware which is out there 1:1 into userspace, we need abstraction. If you want to help with this abstraction, this

[PATCH 1/4] core: platform: add warning if driver has no owner

2014-10-20 Thread Wolfram Sang
Commit 9447057eaff8 (platform_device: use a macro instead of platform_driver_register) introduced a codepath which could result into drivers having no owner. This went unnoticed for months, so add a warning in case this happens again somewhere else somewhen. Signed-off-by: Wolfram Sang w

<    3   4   5   6   7   8   9   10   11   12   >