[PATCH 05/16] fpga: intel: pcie: add chardev support for feature devices

2017-03-30 Thread Wu Hao
com> Signed-off-by: Shiva Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Zhang Yi <yi.z.zh...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.co

[PATCH 08/16] fpga: intel: add FPGA Management Engine driver basic framework

2017-03-30 Thread Wu Hao
-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- drivers/fpga/intel/Kconfig| 8 +++ drivers/fpga/intel/Makefile | 2 + drivers/fpga/intel/fme-main.c | 158 ++ 3 files changed, 168 insertio

[PATCH 06/16] fpga: intel: pcie: adds fpga_for_each_port callback for fme device

2017-03-30 Thread Wu Hao
intel.com> Signed-off-by: Shiva Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- drivers/fpga/intel/feature-dev.h | 9 + d

[PATCH 10/16] fpga: intel: fme: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2017-03-30 Thread Wu Hao
opher.ra...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- Documentation/ioctl/ioctl-number.txt | 1 + drivers/fpga/intel/fme-main.c| 12 + include/uapi/linux/intel-fpga.h | 52 +

[PATCH 16/16] fpga: intel: afu: add FPGA_PORT_DMA_MAP/UNMAP ioctls support

2017-03-30 Thread Wu Hao
intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- drivers/fpga/intel/Makefile | 2 +- drivers/fpga/intel/afu-dma-region.c | 373 drivers/fpga/intel/afu-main.c |

[PATCH 15/16] fpga: intel: afu: add user afu sub feature support

2017-03-30 Thread Wu Hao
bb...@intel.com> Signed-off-by: Shiva Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- drivers/fpga/intel/Makefile | 2

[PATCH 14/16] fpga: intel: afu add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2017-03-30 Thread Wu Hao
com> Signed-off-by: Enno Luebbers <enno.luebb...@intel.com> Signed-off-by: Shiva Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel

[PATCH 12/16] fpga: intel: add FPGA Accelerated Function Unit driver basic framework

2017-03-30 Thread Wu Hao
.luebb...@intel.com> Signed-off-by: Shiva Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- drivers/fpga/intel/Kconfig

[PATCH 09/16] fpga: intel: fme: add header sub feature support

2017-03-30 Thread Wu Hao
nno Luebbers <enno.luebb...@intel.com> Signed-off-by: Shiva Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Kang Luwei <luwei.k...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com&g

[PATCH 00/16] Intel FPGA Device Drivers

2017-03-30 Thread Wu Hao
connects to. Kang Luwei (3): fpga: intel: add FPGA Management Engine driver basic framework fpga: intel: fme: add header sub feature support fpga: intel: fme: add partial reconfiguration sub feature support Wu Hao (8): docs: fpga: add a document for Intel FPGA driver overview fpga: add FPGA

[PATCH 11/16] fpga: intel: fme: add partial reconfiguration sub feature support

2017-03-30 Thread Wu Hao
; Signed-off-by: Kang Luwei <luwei.k...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- drivers/fpga/intel/Makefile | 2 +- drivers/fpga/intel/feature-dev.h | 58 ++ drivers/fpga/intel/fme-main.c

[PATCH 13/16] fpga: intel: afu: add header sub feature support

2017-03-30 Thread Wu Hao
...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- drivers/fpga/intel/afu-main.c | 44 - include/uapi/linux/intel-fpga.h | 14 + 2 files changed, 57 inse

[PATCH 02/16] fpga: add FPGA device framework

2017-03-30 Thread Wu Hao
> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- drivers/fpga/Kconfig | 6 +++ drivers/fpga/Makefile | 3 ++ drivers/fpga/fpga-dev.c | 120 ++ include/linux/fpga/fp

[PATCH 07/16] fpga: intel: add feature device infrastructure

2017-03-30 Thread Wu Hao
er Rauer <christopher.ra...@intel.com> Signed-off-by: Kang Luwei <luwei.k...@intel.com> Signed-off-by: Zhang Yi <yi.z.zh...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- drivers/fpga/intel/feature-dev

[PATCH 04/16] fpga: intel: pcie: parse feature list and create platform device for features.

2017-03-30 Thread Wu Hao
Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- drivers/fpga/intel/Makefile | 2 +- drivers/fpga/intel/feature-dev.c | 139 +++ drivers/fpga/intel/feature-dev.h | 342 drivers/fpga/intel/pcie.c| 841

[PATCH 01/16] docs: fpga: add a document for Intel FPGA driver overview

2017-03-30 Thread Wu Hao
Add a document for Intel FPGA driver overview. Signed-off-by: Enno Luebbers <enno.luebb...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- Documentation/fpga/intel-fpga.txt | 259

[PATCH 03/16] fpga: intel: add FPGA PCIe device driver

2017-03-30 Thread Wu Hao
intel.com> Signed-off-by: Enno Luebbers <enno.luebb...@intel.com> Signed-off-by: Shiva Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Zhang Yi <yi.z.zh...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...

Re: [PATCH 02/16] fpga: add FPGA device framework

2017-03-31 Thread Wu Hao
On Fri, Mar 31, 2017 at 08:09:09AM +0200, Greg KH wrote: > On Thu, Mar 30, 2017 at 08:08:02PM +0800, Wu Hao wrote: > > During FPGA device (e.g PCI-based) discovery, platform devices are > > registered for different FPGA function units. But the device node path > >

Re: [PATCH 11/16] fpga: intel: fme: add partial reconfiguration sub feature support

2017-03-31 Thread Wu Hao
On Fri, Mar 31, 2017 at 12:11:12PM +0800, Xiao Guangrong wrote: > On 31/03/2017 4:30 AM, Alan Tull wrote: > >On Thu, Mar 30, 2017 at 7:08 AM, Wu Hao <hao...@intel.com> wrote: > >>From: Kang Luwei <luwei.k...@intel.com> > >> > >>Partial Reconfigura

Re: [PATCH 02/16] fpga: add FPGA device framework

2017-03-31 Thread Wu Hao
On Fri, Mar 31, 2017 at 11:03:28AM +0200, Greg KH wrote: > On Fri, Mar 31, 2017 at 03:48:42PM +0800, Wu Hao wrote: > > On Fri, Mar 31, 2017 at 08:09:09AM +0200, Greg KH wrote: > > > On Thu, Mar 30, 2017 at 08:08:02PM +0800, Wu Hao wrote: > > > > During FPGA de

Re: [PATCH 02/16] fpga: add FPGA device framework

2017-03-31 Thread Wu Hao
> On Thu, Mar 30, 2017 at 08:08:02PM +0800, Wu Hao wrote: > > During FPGA device (e.g PCI-based) discovery, platform devices are > > registered for different FPGA function units. But the device node path > > isn't quite friendly to applications. > > > > Cons

Re: [PATCH 01/16] docs: fpga: add a document for Intel FPGA driver overview

2017-04-03 Thread Wu Hao
On Mon, Apr 03, 2017 at 03:44:17PM -0500, Alan Tull wrote: > On Sun, Apr 2, 2017 at 9:41 AM, Moritz Fischer <m...@kernel.org> wrote: > > On Sat, Apr 01, 2017 at 07:16:19PM +0800, Wu Hao wrote: > >> On Fri, Mar 31, 2017 at 01:38:06PM -0500, Alan Tull wrote: > >>

Re: [PATCH 11/16] fpga: intel: fme: add partial reconfiguration sub feature support

2017-04-03 Thread Wu Hao
On Mon, Apr 03, 2017 at 03:26:14PM -0500, Alan Tull wrote: > On Fri, Mar 31, 2017 at 3:50 AM, Wu Hao <hao...@intel.com> wrote: > > On Fri, Mar 31, 2017 at 12:11:12PM +0800, Xiao Guangrong wrote: > >> On 31/03/2017 4:30 AM, Alan Tull wrote: > >> >On Thu,

Re: [PATCH 01/16] docs: fpga: add a document for Intel FPGA driver overview

2017-04-03 Thread Wu Hao
On Sun, Apr 02, 2017 at 07:41:46AM -0700, Moritz Fischer wrote: > On Sat, Apr 01, 2017 at 07:16:19PM +0800, Wu Hao wrote: > > On Fri, Mar 31, 2017 at 01:38:06PM -0500, Alan Tull wrote: > > > On Fri, Mar 31, 2017 at 1:24 PM, <matthew.gerl...@linux.intel.com> wrote: > &

Re: [PATCH 11/16] fpga: intel: fme: add partial reconfiguration sub feature support

2017-04-04 Thread Wu Hao
On Mon, Apr 03, 2017 at 11:30:55AM -0500, Alan Tull wrote: > On Sat, Apr 1, 2017 at 6:08 AM, Wu Hao <hao...@intel.com> wrote: > > On Fri, Mar 31, 2017 at 02:10:12PM -0500, Alan Tull wrote: > >> On Thu, Mar 30, 2017 at 7:08 AM, Wu Hao <hao...@intel.com> wrote: &g

Re: [PATCH 11/16] fpga: intel: fme: add partial reconfiguration sub feature support

2017-04-04 Thread Wu Hao
On Mon, Apr 03, 2017 at 03:49:41PM -0700, matthew.gerl...@linux.intel.com wrote: > > > On Mon, 3 Apr 2017, Alan Tull wrote: > > >On Thu, Mar 30, 2017 at 7:08 AM, Wu Hao <hao...@intel.com> wrote: > >>From: Kang Luwei <luwei.k...@intel.com> > >&

Re: [PATCH 11/16] fpga: intel: fme: add partial reconfiguration sub feature support

2017-04-04 Thread Wu Hao
On Mon, Apr 03, 2017 at 04:24:13PM -0500, Alan Tull wrote: > On Thu, Mar 30, 2017 at 7:08 AM, Wu Hao <hao...@intel.com> wrote: > > From: Kang Luwei <luwei.k...@intel.com> > > > > Partial Reconfiguration (PR) is the most important function for FME. It > >

Re: [PATCH 11/16] fpga: intel: fme: add partial reconfiguration sub feature support

2017-04-01 Thread Wu Hao
On Fri, Mar 31, 2017 at 02:10:12PM -0500, Alan Tull wrote: > On Thu, Mar 30, 2017 at 7:08 AM, Wu Hao <hao...@intel.com> wrote: > > From: Kang Luwei <luwei.k...@intel.com> > > > > Partial Reconfiguration (PR) is the most important function for FME. It > >

Re: [PATCH 01/16] docs: fpga: add a document for Intel FPGA driver overview

2017-04-01 Thread Wu Hao
On Fri, Mar 31, 2017 at 01:38:06PM -0500, Alan Tull wrote: > On Fri, Mar 31, 2017 at 1:24 PM, <matthew.gerl...@linux.intel.com> wrote: > > > > > > On Thu, 30 Mar 2017, Wu Hao wrote: > > > > > > Hi Wu Hao, > > > > Great documentation. I'm l

Re: [PATCH 02/16] fpga: add FPGA device framework

2017-04-01 Thread Wu Hao
On Fri, Mar 31, 2017 at 04:10:09PM +0200, Greg KH wrote: > On Fri, Mar 31, 2017 at 09:31:09PM +0800, Wu Hao wrote: > > > On Thu, Mar 30, 2017 at 08:08:02PM +0800, Wu Hao wrote: > > > > +#include > > > > +#include > > > > +#include > &g

Re: [PATCH 02/16] fpga: add FPGA device framework

2017-04-01 Thread Wu Hao
On Fri, Mar 31, 2017 at 12:01:13PM -0700, matthew.gerl...@linux.intel.com wrote: > On Fri, 31 Mar 2017, Wu Hao wrote: > >On Fri, Mar 31, 2017 at 08:09:09AM +0200, Greg KH wrote: > >>On Thu, Mar 30, 2017 at 08:08:02PM +0800, Wu Hao wrote: > >>>During FPGA device (e.g

RE: [PATCH 01/16] docs: fpga: add a document for Intel FPGA driver overview

2017-04-11 Thread Wu, Hao
> >> > > > >> > > > >> > > Does this HW Architecture require an Intel FPGA? Couldn't any vendors > FPGA > >> > > be used as long as it presented itself the PCIe bus the same and > >> > > contained > >> > > an appropriate Device Feature List? > > > > I think this is a good (and important) point.

Re: [PATCH 04/16] fpga: intel: pcie: parse feature list and create platform device for features.

2017-04-05 Thread Wu Hao
On Tue, Apr 04, 2017 at 05:09:23PM -0500, Alan Tull wrote: > On Thu, Mar 30, 2017 at 7:08 AM, Wu Hao <hao...@intel.com> wrote: > > From: Xiao Guangrong <guangrong.x...@linux.intel.com> > > > > Device Featuer List structure creates a link list of feature headers >

RE: [PATCH 03/16] fpga: intel: add FPGA PCIe device driver

2017-04-05 Thread Wu, Hao
> > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#define DRV_VERSION"EXPERIMENTAL VERSION" > > Is that a leftover? :) Sorry, will fix this. > > +#define DRV_NAME "intel-fpga-pci" > > + > > +/* PCI Device ID */ > >

Re: [PATCH 11/16] fpga: intel: fme: add partial reconfiguration sub feature support

2017-04-06 Thread Wu Hao
On Wed, Apr 05, 2017 at 10:39:05AM -0500, Alan Tull wrote: > On Wed, Apr 5, 2017 at 10:26 AM, Alan Tull <at...@kernel.org> wrote: > > On Wed, Apr 5, 2017 at 6:40 AM, Wu, Hao <hao...@intel.com> wrote: > >>> >> The fpga_image_info struct started life as just i

RE: [PATCH 04/16] fpga: intel: pcie: parse feature list and create platform device for features.

2017-04-12 Thread Wu, Hao
> On Wed, Apr 5, 2017 at 6:58 AM, Wu Hao <hao...@intel.com> wrote: > > On Mon, Apr 03, 2017 at 04:44:15PM -0500, Alan Tull wrote: > >> On Thu, Mar 30, 2017 at 7:08 AM, Wu Hao <hao...@intel.com> wrote: > >> > From: Xiao Guangrong <guangrong.x...@linux

Re: [PATCH 04/16] fpga: intel: pcie: parse feature list and create platform device for features.

2017-04-05 Thread Wu Hao
On Mon, Apr 03, 2017 at 04:44:15PM -0500, Alan Tull wrote: > On Thu, Mar 30, 2017 at 7:08 AM, Wu Hao <hao...@intel.com> wrote: > > From: Xiao Guangrong <guangrong.x...@linux.intel.com> > > > > Device Featuer List structure creates a link list of feature headers >

RE: [PATCH 11/16] fpga: intel: fme: add partial reconfiguration sub feature support

2017-04-05 Thread Wu, Hao
> >> The fpga_image_info struct started life as just image specific info, > >> but I want it to go in the direction of including parameters needed to > >> program it this specific time. Otherwise we are stuck having to keep > >> adding parameters as our use of FPGA develops. It probably could be

Re: [PATCH 04/16] fpga: intel: pcie: parse feature list and create platform device for features.

2017-04-05 Thread Wu Hao
On Mon, Apr 03, 2017 at 07:44:55PM -0700, Moritz Fischer wrote: > Xiao, > > few nits inline, I'll need to come back to this once I went over the > rest of the patchset ;-) Sure, Thanks for your comments and review. :) > > On Thu, Mar 30, 2017 at 08:08:04PM +0800, Wu Hao wro

Re: [PATCH 11/16] fpga: intel: fme: add partial reconfiguration sub feature support

2017-04-07 Thread Wu Hao
On Thu, Apr 06, 2017 at 02:27:42PM -0500, Alan Tull wrote: > On Thu, Apr 6, 2017 at 5:57 AM, Wu Hao <hao...@intel.com> wrote: > > On Wed, Apr 05, 2017 at 10:39:05AM -0500, Alan Tull wrote: > >> On Wed, Apr 5, 2017 at 10:26 AM, Alan Tull <at...@kernel.org> wrote: >

Re: [PATCH v2 22/22] fpga: intel: afu: add FPGA_PORT_DMA_MAP/UNMAP ioctls support

2017-08-01 Thread Wu Hao
On Mon, Jul 31, 2017 at 04:41:26PM -0500, Alan Tull wrote: > On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao <hao...@intel.com> wrote: Hi Alan Thanks a lot for the code review. :) > > Hi Hao, > > Please run checkpatch.pl --strict on this. Sure, thanks for the suggestion,

Re: [PATCH v2 02/22] fpga: add FPGA device framework

2017-08-01 Thread Wu Hao
On Mon, Jul 31, 2017 at 04:40:16PM -0500, Alan Tull wrote: > On Thu, Jul 27, 2017 at 2:10 PM, Rob Herring <robh...@kernel.org> wrote: > > On Thu, Jul 27, 2017 at 11:35 AM, Alan Tull <at...@kernel.org> wrote: > >> On Sun, Jun 25, 2017 at 8:51 PM, Wu Hao <hao...@i

Re: [PATCH v2 22/22] fpga: intel: afu: add FPGA_PORT_DMA_MAP/UNMAP ioctls support

2017-08-02 Thread Wu Hao
On Tue, Aug 01, 2017 at 11:15:48AM -0700, Moritz Fischer wrote: > Hi Wu, > > couple of minor things inline below. Hi Moritz, Thanks a lot for your comments. :) I will fix all the problems below in the next version patchset. Thanks Hao > > On Sun, Jun 25, 2017 at 6:52

Re: [PATCH RFC] fpga: add FPGA Bus device framework

2017-08-03 Thread Wu Hao
On Wed, Aug 02, 2017 at 04:16:32PM -0500, Alan Tull wrote: > On Wed, Aug 2, 2017 at 7:19 AM, Wu Hao <hao...@intel.com> wrote: > > This patch is a RFC patch which replaces the patch[1] which > > creates 'fpga-dev' class as container device. It introduces > > a 'f

RE: [PATCH v2 19/22] fpga: intel: afu: add header sub feature support

2017-08-15 Thread Wu, Hao
> On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao <hao...@intel.com> wrote: > > Hi Hao, > > > The header register set is always present for the Port/AFU, it is mainly > > for capability, control and status of the ports that AFU connected to. > > So just to be

RE: [PATCH v2 06/22] fpga: intel: add FPGA PCIe device driver

2017-08-14 Thread Wu, Hao
> On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao <hao...@intel.com> wrote: > > Hi Hao, > > Making my way through your patchset. Hi Alan Thanks a lot for your comments. :) > > > From: Zhang Yi <yi.z.zh...@intel.com> > > > > The Intel FPGA device ap

RE: [PATCH RFC] fpga: add FPGA Bus device framework

2017-08-14 Thread Wu, Hao
> On Tue, Aug 8, 2017 at 1:25 PM, Wu, Hao <hao...@intel.com> wrote: > >> On Thu, Aug 3, 2017 at 2:53 AM, Wu Hao <hao...@intel.com> wrote: > >> > On Wed, Aug 02, 2017 at 04:16:32PM -0500, Alan Tull wrote: > >> >> On Wed, Aug 2, 2017 at 7:19 AM, Wu

RE: [PATCH 3/3] fpga: intel: Add QSPI FPGA Management Entity Feature

2017-08-14 Thread Wu, Hao
> On Sun, Aug 6, 2017 at 1:24 PM, <matthew.gerl...@linux.intel.com> wrote: > > + Wu Hao and the people who signed off on the Intel feature-dev stuff. > > Hi Matthew, > > By the way, this patch is against v1 of their patchset. They have v2 out. > > You could s

RE: [PATCH RFC] fpga: add FPGA Bus device framework

2017-08-17 Thread Wu, Hao
> On Mon, Aug 14, 2017 at 5:59 AM, Wu, Hao <hao...@intel.com> wrote: > >> On Tue, Aug 8, 2017 at 1:25 PM, Wu, Hao <hao...@intel.com> wrote: > >> >> On Thu, Aug 3, 2017 at 2:53 AM, Wu Hao <hao...@intel.com> wrote: > >> >>

Re: [PATCH v2 17/22] fpga: intel: add fpga region platform driver for FME

2017-07-12 Thread Wu Hao
On Wed, Jul 12, 2017 at 11:09:46AM -0500, Alan Tull wrote: > On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao <hao...@intel.com> wrote: > > Hi Hao, > > Thanks for using the region patchset. This looks good except for one > thing below. Hi Alan Thank you v

Re: [PATCH v2 05/22] fpga: mgr: add status for fpga-mgr

2017-07-12 Thread Wu Hao
On Wed, Jul 12, 2017 at 10:22:17AM -0500, Alan Tull wrote: > On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao <hao...@intel.com> wrote: > > Hi Hao, > Hi Alan Thanks a lot for your feedback. : ) > > This patch adds status to fpga-manager data structure, to allow > >

Re: [PATCH v2 01/22] docs: fpga: add a document for Intel FPGA driver overview

2017-07-12 Thread Wu Hao
On Wed, Jul 12, 2017 at 09:51:32AM -0500, Alan Tull wrote: > On Sun, Jun 25, 2017 at 8:51 PM, Wu Hao <hao...@intel.com> wrote: > > Hi Hao, > > > Add a document for Intel FPGA driver overview. > > > > Signed-off-by: Enno Luebbers <enno.luebb...@intel

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

2017-07-14 Thread Wu Hao
On Thu, Jul 13, 2017 at 12:52:30PM -0500, Alan Tull wrote: > On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao <hao...@intel.com> wrote: > > From: Xiao Guangrong <guangrong.x...@linux.intel.com> > > > > Device Feature List structure creates a link list of feature headers >

RE: [PATCH v2 12/22] fpga: intel: fme: add header sub feature support

2017-07-17 Thread Wu, Hao
> On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao <hao...@intel.com> wrote: > > Hi Hao, > > I'm making my way through this (very large) patchset. Some minor > comments below. > Hi Alan Thanks for your review. : ) > > From: Kang Luwei <luwei.k...@intel.com> &g

RE: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

2017-07-17 Thread Wu, Hao
> On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao <hao...@intel.com> wrote: > > From: Xiao Guangrong <guangrong.x...@linux.intel.com> > > > > Device Feature List structure creates a link list of feature headers > > within the MMIO space to provide an extensible wa

Re: [PATCH 02/16] fpga: add FPGA device framework

2017-07-26 Thread Wu Hao
On Wed, Jul 26, 2017 at 05:29:11PM -0500, Alan Tull wrote: > On Wed, Jul 26, 2017 at 9:20 AM, Alan Tull <at...@kernel.org> wrote: > > On Wed, Jul 26, 2017 at 4:50 AM, Wu Hao <hao...@intel.com> wrote: > >> On Tue, Jul 25, 2017 at 04:32:10PM -0500, Alan Tull wrote: >

Re: [PATCH v2 04/22] fpga: mgr: add region_id to fpga_image_info

2017-07-26 Thread Wu Hao
On Wed, Jul 26, 2017 at 01:33:53PM -0500, Alan Tull wrote: > On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao <hao...@intel.com> wrote: > > Hi Hao, > > > This patch adds region_id to fpga_image_info data structure, it > > allows driver to pass region id information to fp

Re: [PATCH v2 02/22] fpga: add FPGA device framework

2017-07-28 Thread Wu Hao
On Thu, Jul 27, 2017 at 11:44:01AM -0500, Alan Tull wrote: > On Sun, Jun 25, 2017 at 8:51 PM, Wu Hao <hao...@intel.com> wrote: > > During FPGA device (e.g PCI-based) discovery, platform devices are > > registered for different FPGA function units. But the device node path >

Re: [PATCH 02/16] fpga: add FPGA device framework

2017-07-26 Thread Wu Hao
On Tue, Jul 25, 2017 at 04:32:10PM -0500, Alan Tull wrote: > On Sat, Apr 1, 2017 at 7:18 AM, Wu Hao <hao...@intel.com> wrote: > > Hi Hao, > > > On Fri, Mar 31, 2017 at 12:01:13PM -0700, matthew.gerl...@linux.intel.com > > wrote: > >> On Fri, 31 Mar 2017, W

Re: [PATCH v2 16/16] fpga: region: move device tree support to of-fpga-region.c

2017-04-28 Thread Wu Hao
On Thu, Apr 20, 2017 at 09:10:01AM -0500, Alan Tull wrote: > Create of-fpga-region.c > > Move the following functions without modification from > fpga-region.c to of-fpga-region.c: > > * of_fpga_region_find > * of_fpga_region_get_mgr > * of_fpga_region_get_bridges > * child_regions_with_firmware

[PATCH RFC] fpga: add FPGA Bus device framework

2017-08-02 Thread Wu Hao
The following sysfs files are created: * /sys/bus/fpga/devices//name Name of the fpga bus device. [1] http://marc.info/?l=linux-fpga=149844237209829=2 [2] http://marc.info/?l=linux-fpga=149844232609819=2 Signed-off-by: Wu Hao <hao...@intel.com> --- Documentation/ABI/testing/sysfs-bus-fpga

Re: [PATCH v2 02/22] fpga: add FPGA device framework

2017-08-02 Thread Wu Hao
On Tue, Aug 01, 2017 at 04:04:44PM -0500, Alan Tull wrote: > On Tue, Aug 1, 2017 at 3:43 AM, Wu Hao <hao...@intel.com> wrote: > > On Mon, Jul 31, 2017 at 04:40:16PM -0500, Alan Tull wrote: > >> On Thu, Jul 27, 2017 at 2:10 PM, Rob Herring <robh...@kernel.org> wrot

RE: [PATCH RFC] fpga: add FPGA Bus device framework

2017-08-08 Thread Wu, Hao
> On Thu, Aug 3, 2017 at 2:53 AM, Wu Hao <hao...@intel.com> wrote: > > On Wed, Aug 02, 2017 at 04:16:32PM -0500, Alan Tull wrote: > >> On Wed, Aug 2, 2017 at 7:19 AM, Wu Hao <hao...@intel.com> wrote: > >> > This patch is a RFC patch which replaces the patc

Re: [PATCH v2 20/22] fpga: intel: afu add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2017-08-17 Thread Wu Hao
On Thu, Aug 17, 2017 at 12:12:00PM -0700, Moritz Fischer wrote: > Hi, > > On Sun, Jun 25, 2017 at 6:52 PM, Wu Hao <hao...@intel.com> wrote: > > FPGA_GET_API_VERSION and FPGA_CHECK_EXTENSION ioctls are common ones which > > need to be supported by all feature devices dr

Re: [PATCH v2 16/22] fpga: intel: add fpga bridge platform driver for FME

2017-08-17 Thread Wu Hao
On Thu, Aug 17, 2017 at 12:55:37PM -0700, Moritz Fischer wrote: > Hi Wu, > > looks good. Minor nits inline. Hi Moritz, Thanks for your comments. : ) > > On Sun, Jun 25, 2017 at 6:52 PM, Wu Hao <hao...@intel.com> wrote: > > This patch adds fpga bridge platform drive

Re: [PATCH v2 09/22] fpga: intel: pcie: adds fpga_for_each_port callback for fme device

2017-08-18 Thread Wu Hao
On Thu, Aug 17, 2017 at 04:31:56PM -0500, Alan Tull wrote: > On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao <hao...@intel.com> wrote: > > Hi Hao, > > > For FPGA Management Engine (FME), it requires fpga_for_each_port callback > > for actions on ports, so export this funct

Re: [PATCH v2 18/22] fpga: intel: add FPGA Accelerated Function Unit driver basic framework

2017-08-18 Thread Wu Hao
On Thu, Aug 17, 2017 at 02:00:21PM -0500, Alan Tull wrote: > On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao <hao...@intel.com> wrote: > > Hi Hao, > > Just a few minor things below. Otherwise, it's fine. Hi Alan Thanks a lot for the review. :) > > > On Intel FPGA dev

Re: [PATCH v2 18/22] fpga: intel: add FPGA Accelerated Function Unit driver basic framework

2017-08-18 Thread Wu Hao
On Thu, Aug 17, 2017 at 12:09:51PM -0700, Moritz Fischer wrote: > On Sun, Jun 25, 2017 at 6:52 PM, Wu Hao <hao...@intel.com> wrote: > > On Intel FPGA devices, the Accelerated Function Unit (AFU), can be > > reprogrammed for different functions. It connects to the FPGA >

Re: [PATCH v2 02/16] fpga: bridge: support getting bridge from device

2017-05-03 Thread Wu Hao
On Thu, Apr 20, 2017 at 09:09:47AM -0500, Alan Tull wrote: > Add two functions for getting the FPGA bridge from the device > rather than device tree node. This is to enable writing code > that will support using FPGA bridges without device tree. > Rename one old function to make it clear that it

Re: [PATCH v2 02/16] fpga: bridge: support getting bridge from device

2017-05-09 Thread Wu Hao
On Mon, May 08, 2017 at 03:44:12PM -0500, Alan Tull wrote: > On Mon, May 8, 2017 at 3:44 AM, Wu, Hao <hao...@intel.com> wrote: > >> On Wed, May 3, 2017 at 3:07 PM, Alan Tull <at...@kernel.org> wrote: > >> > On Wed, May 3, 2017 at 6:58 AM, Wu Hao <hao...@i

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

2017-06-26 Thread Wu Hao
atches. Hao > > > On Mon, Jun 26, 2017 at 09:52:03AM +0800, Wu Hao wrote: > > From: Xiao Guangrong <guangrong.x...@linux.intel.com> > > > > Device Feature List structure creates a link list of feature headers > > within the MMIO space to provide an extensible way of a

[PATCH v2 02/22] fpga: add FPGA device framework

2017-06-25 Thread Wu Hao
> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- v2: added sysfs documentation for fpga-dev class. switched to GPLv2 license. --- Documentation/ABI/testing/sysfs-class-fpga-dev | 5 ++ drivers/fpga/Kconfig

[PATCH v2 01/22] docs: fpga: add a document for Intel FPGA driver overview

2017-06-25 Thread Wu Hao
Add a document for Intel FPGA driver overview. Signed-off-by: Enno Luebbers <enno.luebb...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> v2: added FME fpga-mgr/bridge/region platform driver to d

[PATCH v2 00/22] Intel FPGA Device Drivers

2017-06-25 Thread Wu Hao
Engine driver basic framework fpga: intel: fme: add header sub feature support fpga: intel: fme: add partial reconfiguration sub feature support Wu Hao (14): docs: fpga: add a document for Intel FPGA driver overview fpga: add FPGA device framework fpga: bridge: remove OF dependency for fpga

[PATCH v2 05/22] fpga: mgr: add status for fpga-mgr

2017-06-25 Thread Wu Hao
This patch adds status to fpga-manager data structure, to allow driver to store full/partial reconfiguration errors and other status information. one sysfs interface created for user space application to read fpga-manager status. Signed-off-by: Wu Hao <hao...@intel.com> --- Documentati

[PATCH v2 14/22] fpga: intel: fme: add partial reconfiguration sub feature support

2017-06-25 Thread Wu Hao
intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Kang Luwei <luwei.k...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- v2: moved the code to drivers/fpga folder

[PATCH v2 09/22] fpga: intel: pcie: adds fpga_for_each_port callback for fme device

2017-06-25 Thread Wu Hao
intel.com> Signed-off-by: Shiva Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- v2: rebased --- drivers/fpga/intel-feature-dev.

[PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge

2017-06-25 Thread Wu Hao
This patch removes OF dependency of fpga-bridge, it allows drivers to use fpga-bridge class without device tree support. Signed-off-by: Wu Hao <hao...@intel.com> --- drivers/fpga/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig index e

[PATCH v2 10/22] fpga: intel: add feature device infrastructure

2017-06-25 Thread Wu Hao
er Rauer <christopher.ra...@intel.com> Signed-off-by: Kang Luwei <luwei.k...@intel.com> Signed-off-by: Zhang Yi <yi.z.zh...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> ---

[PATCH v2 15/22] fpga: intel: add fpga manager platform driver for FME

2017-06-25 Thread Wu Hao
a Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Kang Luwei <luwei.k...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- .../ABI/testing/sysfs-pla

[PATCH v2 06/22] fpga: intel: add FPGA PCIe device driver

2017-06-25 Thread Wu Hao
intel.com> Signed-off-by: Enno Luebbers <enno.luebb...@intel.com> Signed-off-by: Shiva Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Zhang Yi <yi.z.zh...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...

[PATCH v2 08/22] fpga: intel: pcie: add chardev support for feature devices

2017-06-25 Thread Wu Hao
com> Signed-off-by: Shiva Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Zhang Yi <yi.z.zh...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- v

[PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

2017-06-25 Thread Wu Hao
Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- v2: moved the code to drivers/fpga folder as suggested by Alan Tull. switched to GPLv2 license. fixed comments from Moritz Fischer. fixed kbuild warning, typos and clean up the code. --- d

[PATCH v2 11/22] fpga: intel: add FPGA Management Engine driver basic framework

2017-06-25 Thread Wu Hao
-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- v2: moved the code to drivers/fpga folder as suggested by Alan Tull. switched to GPLv2 license. --- drivers/fpga/Kconfig | 8 +++ drivers/fpga/Makefile

[PATCH v2 04/22] fpga: mgr: add region_id to fpga_image_info

2017-06-25 Thread Wu Hao
This patch adds region_id to fpga_image_info data structure, it allows driver to pass region id information to fpga-mgr via fpga_image_info for fpga reconfiguration function. Signed-off-by: Wu Hao <hao...@intel.com> --- include/linux/fpga/fpga-mgr.h | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 18/22] fpga: intel: add FPGA Accelerated Function Unit driver basic framework

2017-06-25 Thread Wu Hao
.luebb...@intel.com> Signed-off-by: Shiva Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- v2: moved the code to drivers/fpga

[PATCH v2 13/22] fpga: intel: fme: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2017-06-25 Thread Wu Hao
opher.ra...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- v2: switched to GPLv2 license. --- Documentation/ioctl/ioctl-number.txt | 1 + drivers/fpga/intel-fme-main.c| 12 + inclu

[PATCH v2 21/22] fpga: intel: afu: add user afu sub feature support

2017-06-25 Thread Wu Hao
bb...@intel.com> Signed-off-by: Shiva Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- v2: moved the code to drivers/fpga folde

[PATCH v2 22/22] fpga: intel: afu: add FPGA_PORT_DMA_MAP/UNMAP ioctls support

2017-06-25 Thread Wu Hao
intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- v2: moved the code to drivers/fpga folder as suggested by Alan Tull. switched to GPLv2 license. fixed kbuild warnings. --- drivers/fpga/Makefile

[PATCH v2 12/22] fpga: intel: fme: add header sub feature support

2017-06-25 Thread Wu Hao
nno Luebbers <enno.luebb...@intel.com> Signed-off-by: Shiva Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Kang Luwei <luwei.k...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signe

[PATCH v2 17/22] fpga: intel: add fpga region platform driver for FME

2017-06-25 Thread Wu Hao
a Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- drivers/fpga/Kconfig | 7 +++ drivers/fpga/Makefile| 1 + drivers/fpga/intel-fpga-fme-region.c | 91 +++

[PATCH v2 16/22] fpga: intel: add fpga bridge platform driver for FME

2017-06-25 Thread Wu Hao
tel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- drivers/fpga/Kconfig | 7 drivers/fpga/Makefile| 1 + drivers/fpga/intel-fpga-fme-br.c | 77

[PATCH v2 19/22] fpga: intel: afu: add header sub feature support

2017-06-25 Thread Wu Hao
...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.com> --- v2: add sysfs documentation. --- .../ABI/testing/sysfs-platform-intel-fpga-afu | 7 drivers/fpga/intel-afu-main.c | 44 ++

[PATCH v2 20/22] fpga: intel: afu add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2017-06-25 Thread Wu Hao
com> Signed-off-by: Enno Luebbers <enno.luebb...@intel.com> Signed-off-by: Shiva Rao <shiva@intel.com> Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Wu Hao <hao...@intel.

Re: [PATCH v2 02/16] fpga: bridge: support getting bridge from device

2017-05-04 Thread Wu Hao
On Wed, May 03, 2017 at 03:07:33PM -0500, Alan Tull wrote: > On Wed, May 3, 2017 at 6:58 AM, Wu Hao <hao...@intel.com> wrote: > > On Thu, Apr 20, 2017 at 09:09:47AM -0500, Alan Tull wrote: > >> Add two functions for getting the FPGA bridge from the device > >

RE: [PATCH v2 02/16] fpga: bridge: support getting bridge from device

2017-05-08 Thread Wu, Hao
> On Wed, May 3, 2017 at 3:07 PM, Alan Tull <at...@kernel.org> wrote: > > On Wed, May 3, 2017 at 6:58 AM, Wu Hao <hao...@intel.com> wrote: > >> On Thu, Apr 20, 2017 at 09:09:47AM -0500, Alan Tull wrote: > >>> Add two functions for getting the FPGA bridg

Re: [PATCH 04/16] fpga: intel: pcie: parse feature list and create platform device for features.

2017-05-04 Thread Wu Hao
On Thu, May 04, 2017 at 10:13:41AM -0500, Li, Yi wrote: > hi Hao > > > On 3/30/2017 7:08 AM, Wu Hao wrote: > >From: Xiao Guangrong <guangrong.x...@linux.intel.com> > > > >Device Featuer List structure creates a link list of feature headers > >within th

Re: [PATCH v4 11/18] fpga: region: add fpga-region.h header

2017-09-14 Thread Wu Hao
On Thu, Sep 14, 2017 at 04:48:34AM +0800, Alan Tull wrote: > * Create fpga-region.h. > * Export fpga_region_program_fpga. > * Move struct fpga_region and other things to the header. > > This is a step in separating FPGA region common code > from Device Tree support. > > Signed-off-by: Alan Tull

Re: [PATCH v4 13/18] fpga: region: add register/unregister functions

2017-09-14 Thread Wu Hao
On Thu, Sep 14, 2017 at 04:48:36AM +0800, Alan Tull wrote: > Another step in separating common code from device tree specific > code for FPGA regions. > > * add FPGA region register/unregister functions. > * add the register/unregister functions to the header > * use devm_kzalloc to alloc the

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

2017-09-22 Thread Wu Hao
On Wed, Sep 20, 2017 at 04:24:10PM -0500, Alan Tull wrote: > a (wh., *()On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao <hao...@intel.com> wrote: > > Hi Hao, > > I'm done with some board bringup so I have time to look at your patchset > again. Hi Alan Thanks for

  1   2   3   4   5   6   7   8   9   >