Call pm_runtime_get_sync() before starting a frame and then
pm_runtime_put() after completing it. This can save power for the time
between processing two frames.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 27
Let v4l2_ctrl_subscribe_event() do the job for other types except
V4L2_EVENT_SOURCE_CHANGE.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
Delete platform_get_resource operation for irq.
Return actual value rather than EINVAL when fail to get and request
irq.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 7 ++-
1 file changed, 2 insertions(+), 5
Add checking created buffer size follow in mtk_jpeg_queue_setup().
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/platform/mtk-jpeg
The driver can be instantiated multiple times, e.g. for a decoder and
an encoder. Moreover, other drivers could coexist on the same system.
This makes the static video node number assignment pointless, so switch
to automatic assignment instead.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
Use the generic clk_bulk_* helpers to enable and disable clocks.
Signed-off-by: Xia Jiang
---
v11: specify the names of the clocks in the driver
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 28 +--
.../media/platform/mtk-jpeg/mtk_jpeg_core.h | 8 +++---
2 files changed
and MTK_JPEG_FMT_FLAG_DEC_CAPTURE are enough.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 64 ++-
.../media/platform/mtk-jpeg/mtk_jpeg_core.h | 3 -
2 files changed, 34 insertions(+), 33 deletions(-)
diff --git a/drivers/media
Add jpeg enc device tree node document.
Reviewed-by: Rob Herring
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
.../bindings/media/mediatek-jpeg-encoder.txt | 35 +++
1 file changed, 35 insertions(+)
create mode 100644
Documentation/devicetree
Add v4l2_m2m_suspend() function call in mtk_jpeg_suspend() to make sure
that the current frame is processed completely before suspend.
Add v4l2_m2m_resume() function call in mtk_jpeg_resume() to unblock the
driver from scheduling next frame.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
There is a delayed work scheduled before starting the hardware and
canceled in the interrupt handler. If the delayed work is executed, it
resets the hardware and reports the failure to V4L2, so that the
execution can continue from next frames.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
Add jpeg enc device tree node.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
arch/arm/boot/dts/mt2701.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
index 8d43a502aada
Delete zeroing the reserved fields because that the core already
does it.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/media/platform/mtk-jpeg
Delete unused member variables annotation.
Delete unused variable definition.
Delete redundant log print, because V4L2 debug logs already print it.
Add annotation for enum mtk_jpeg_ctx_state.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
drivers/media/platform/mtk
Rename the files which are for decode feature. This is preparing
path since the jpeg enc patch will be added later.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
drivers/media/platform/mtk-jpeg/Makefile | 2 +-
drivers/media/platform/mtk-jpeg
The maximum width and height supported by JPEG dec is 65535, so change
them from 8192 to 65535.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 49 ++-
1 file changed, 16 insertions(+), 33 deletions(-)
diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index
Add varability which would be used between jpeg dec and enc to a match
data structure, it will make the code linear.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 113 +++---
.../media/platform/mtk-jpeg
The standard v4l2_pix_format_mplane structure contains width/height/
sizeimage/bytesperline, so use v4l2_pix_format_mplane to replace them.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 101
Rename existing functions/defines/variables with a _dec prefix and
without dec_ prefix to prepare for the addition of the jpeg encoder
feature.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 172
JPEG dec does't support setting a compose rectangle, so remove
mtk_jpeg_dec_s_selection().
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 22 ---
1 file changed, 22 deletions(-)
diff --git a/drivers
Add mtk jpeg encode v4l2 driver based on jpeg decode, because that jpeg
decode and encode have great similarities with function operation.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
drivers/media/platform/mtk-jpeg/Makefile | 5 +-
.../media/platform/mtk
Jpeg doesn't support colorspace conversion, so it shouldn't accept any
other colorspace in S_FMT.
Change the colorspace of jpeg to the fixed value.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 24
Call mtk_jpeg_try_fmt_mplane() to replace the original computation of
sizeimage and bytesperline, because that mtk_jpeg_try_fmt_mplane()
already did it.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 12
Use clamp() to replace mtk_jpeg_bound_align_image() and round() to
replace mtk_jpeg_align().
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 41 +--
drivers/media/platform/mtk-jpeg/mtk_jpeg_hw.c | 8
There is no need to queue an empty buffer for signaling a last frame,
because all frames are separate from each other in JPEG.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 46 +--
1 file changed, 2
Move MTK_JPEG_COMP_MAX definition to mtk_jpeg_core.h file, because it
is used by mtk_jpeg_core.c file.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h | 2 ++
drivers/media/platform/mtk-jpeg/mtk_jpeg_reg.h | 1 -
2
Change register offset hex numerals from uppercase to lowercase.
Change data type of max/min width/height from integer to unsigned
integer.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.h| 8
drivers/media
Change compared to v10:
-specify the names of the clocks in the driver of patch 22/28
Xia Jiang (28):
media: platform: Improve subscribe event flow for bug fixing
media: platform: Improve queue set up flow for bug
Delete the resetting hardware flow in suspend and resume function
because that resetting operation will be done in device_run().
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v11: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 --
1 file changed, 2 deletions
):
media: v4l2-mem2mem: add v4l2_m2m_suspend, v4l2_m2m_resume
Xia Jiang (28):
media: platform: Improve subscribe event flow for bug fixing
media: platform: Improve queue set up flow for bug fixing
media: platform: Improve getting and requesting irq flow for bug
fixing
media: platform
From: Pi-Hsun Shih
Add two functions that can be used to stop new jobs from being queued /
continue running queued job. This can be used while a driver using m2m
helper is going to suspend / wake up from resume, and can ensure that
there's no job running in suspend process.
BUG=b:143046833
Use clamp() to replace mtk_jpeg_bound_align_image() and round() to
replace mtk_jpeg_align().
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 41 +--
drivers/media/platform/mtk-jpeg/mtk_jpeg_hw.c | 8
Delete the resetting hardware flow in suspend and resume function
because that resetting operation will be done in device_run().
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 --
1 file changed, 2 deletions
Delete platform_get_resource operation for irq.
Return actual value rather than EINVAL when fail to get and request
irq.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 7 ++-
1 file changed, 2 insertions(+), 5
Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 49 ++-
1 file changed, 16 insertions(+), 33 deletions(-)
diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index
Let v4l2_ctrl_subscribe_event() do the job for other types except
V4L2_EVENT_SOURCE_CHANGE.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
The maximum width and height supported by JPEG dec is 65535, so change
them from 8192 to 65535.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Move MTK_JPEG_COMP_MAX definition to mtk_jpeg_core.h file, because it
is used by mtk_jpeg_core.c file.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h | 2 ++
drivers/media/platform/mtk-jpeg/mtk_jpeg_reg.h | 1 -
2
Rename the files which are for decode feature. This is preparing
path since the jpeg enc patch will be added later.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
drivers/media/platform/mtk-jpeg/Makefile | 2 +-
drivers/media/platform/mtk-jpeg
Add varability which would be used between jpeg dec and enc to a match
data structure, it will make the code linear.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 113 +++---
.../media/platform/mtk-jpeg
Add jpeg enc device tree node document.
Reviewed-by: Rob Herring
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
.../bindings/media/mediatek-jpeg-encoder.txt | 35 +++
1 file changed, 35 insertions(+)
create mode 100644
Documentation/devicetree
Use the generic clk_bulk_* helpers to enable and disable clocks.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 28 +--
.../media/platform/mtk-jpeg/mtk_jpeg_core.h | 8 +++---
2 files changed, 23
and MTK_JPEG_FMT_FLAG_DEC_CAPTURE are enough.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 64 ++-
.../media/platform/mtk-jpeg/mtk_jpeg_core.h | 3 -
2 files changed, 34 insertions(+), 33 deletions(-)
diff --git a/drivers/media
The standard v4l2_pix_format_mplane structure contains width/height/
sizeimage/bytesperline, so use v4l2_pix_format_mplane to replace them.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 101
Change register offset hex numerals from uppercase to lowercase.
Change data type of max/min width/height from integer to unsigned
integer.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.h| 8
drivers/media
Delete zeroing the reserved fields because that the core already
does it.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/media/platform/mtk-jpeg
There is no need to queue an empty buffer for signaling a last frame,
because all frames are separate from each other in JPEG.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 46 +--
1 file changed, 2
Delete unused member variables annotation.
Delete unused variable definition.
Delete redundant log print, because V4L2 debug logs already print it.
Add annotation for enum mtk_jpeg_ctx_state.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
drivers/media/platform/mtk
Call mtk_jpeg_try_fmt_mplane() to replace the original computation of
sizeimage and bytesperline, because that mtk_jpeg_try_fmt_mplane()
already did it.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 12
Rename existing functions/defines/variables with a _dec prefix and
without dec_ prefix to prepare for the addition of the jpeg encoder
feature.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 172
JPEG dec does't support setting a compose rectangle, so remove
mtk_jpeg_dec_s_selection().
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 22 ---
1 file changed, 22 deletions(-)
diff --git a/drivers
Add mtk jpeg encode v4l2 driver based on jpeg decode, because that jpeg
decode and encode have great similarities with function operation.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: fix the compile warnings
---
drivers/media/platform/mtk-jpeg/Makefile | 5 +-
.../media
Jpeg doesn't support colorspace conversion, so it shouldn't accept any
other colorspace in S_FMT.
Change the colorspace of jpeg to the fixed value.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 24
Add jpeg enc device tree node.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
arch/arm/boot/dts/mt2701.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
index 8d43a502aada
Add v4l2_m2m_suspend() function call in mtk_jpeg_suspend() to make sure
that the current frame is processed completely before suspend.
Add v4l2_m2m_resume() function call in mtk_jpeg_resume() to unblock the
driver from scheduling next frame.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
Call pm_runtime_get_sync() before starting a frame and then
pm_runtime_put() after completing it. This can save power for the time
between processing two frames.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 27
The driver can be instantiated multiple times, e.g. for a decoder and
an encoder. Moreover, other drivers could coexist on the same system.
This makes the static video node number assignment pointless, so switch
to automatic assignment instead.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
There is a delayed work scheduled before starting the hardware and
canceled in the interrupt handler. If the delayed work is executed, it
resets the hardware and reports the failure to V4L2, so that the
execution can continue from next frames.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
):
media: v4l2-mem2mem: add v4l2_m2m_suspend, v4l2_m2m_resume
Xia Jiang (28):
media: platform: Improve subscribe event flow for bug fixing
media: platform: Improve queue set up flow for bug fixing
media: platform: Improve getting and requesting irq flow for bug
fixing
media: platform
Add checking created buffer size follow in mtk_jpeg_queue_setup().
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v12: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/platform/mtk-jpeg
Xia Jiang (5):
media: dt-bindings: Add JPEG ENC device tree node document
media: platform: Rename jpeg dec file name
media: platform: Add jpeg enc feature
media: platform: change GPLv2 license to SPDX
arm: dts: add jpeg enc device
Add JPEG ENC device tree node document.
Signed-off-by: Xia Jiang
---
.../bindings/media/mediatek-jpeg-encoder.txt | 33 +++
1 file changed, 33 insertions(+)
create mode 100644
Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.txt
diff --git a/Documentation
Rename the files which are for decode feature. This is a preparing
patch since the jpeg enc patch will be added later.
Signed-off-by: Xia Jiang
---
drivers/media/platform/mtk-jpeg/Makefile | 2 +-
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4
Switch GPLv2 license to SPDX license.
Signed-off-by: Xia Jiang
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 9 +
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h | 9 +
drivers/media/platform/mtk-jpeg/mtk_jpeg_dec_hw.c| 9 +
drivers/media/platform
add jpeg enc device tree node
Signed-off-by: Xia Jiang
---
arch/arm/boot/dts/mt2701.dtsi | 12
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
index 51e1305c6471..560f27fd9d9e 100644
--- a/arch/arm/boot/dts/mt2701.dtsi
Add mtk jpeg encode v4l2 driver based on jpeg decode, because that jpeg
decode and encode have great similarities with function operation.
add EXIF enable control for jpeg encode.
Signed-off-by: Xia Jiang
---
drivers/media/platform/mtk-jpeg/Makefile | 5 +-
.../media/platform/mtk-jpeg
test Requests: OK (Not Supported)
Total for mtk-jpeg device /dev/video1: 44, Succeeded: 44, Failed: 0, Warnings: 0
Change compared to v1:
-fix compliance test fail, check created buffer size in driver
Xia Jiang (5):
media: dt
Add mtk jpeg encode v4l2 driver based on jpeg decode, because that jpeg
decode and encode have great similarities with function operation.
add EXIF enable control for jpeg encode.
Change-Id: I38bf86a372f69d42a4680c4d772b64a30e81d7be
Signed-off-by: Xia Jiang
---
drivers/media/platform/mtk-jpeg
Switch GPLv2 license to SPDX license.
Change-Id: I2311eb85c06bbf93181f77f1ac6b09780efa8795
Signed-off-by: Xia Jiang
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 9 +
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h | 9 +
drivers/media/platform/mtk-jpeg
add JPEG ENC device tree node document
Change-Id: I9f0a8aec7eced20c88acbc88d6ff179763f91246
Signed-off-by: Xia Jiang
---
.../bindings/media/mediatek-jpeg-encoder.txt | 33 +++
1 file changed, 33 insertions(+)
create mode 100644
Documentation/devicetree/bindings/media/mediatek
Rename the files which are for decode feature. This is a preparing
patch since the jpeg enc patch will be added later.
Change-Id: Ie037f3f62d07632e323e5beff7420759e4862516
Signed-off-by: Xia Jiang
---
drivers/media/platform/mtk-jpeg/Makefile | 2 +-
drivers/media/platform
add jpeg enc device tree node
Change-Id: I901602f04540d619a490746ed61c8cd8b420b051
Signed-off-by: Xia Jiang
---
arch/arm/boot/dts/mt2701.dtsi | 12
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
index 51e1305c6471
On Thu, 2020-05-21 at 15:32 +, Tomasz Figa wrote:
> Hi Xia,
>
> On Fri, Apr 03, 2020 at 05:40:25PM +0800, Xia Jiang wrote:
> > Cancel reset hw operation in suspend and resume function because this
> > will be done in device_run().
>
> This and...
>
> >
On Thu, 2020-05-21 at 13:59 +, Tomasz Figa wrote:
> Hi Xia,
>
> On Fri, Apr 03, 2020 at 05:40:23PM +0800, Xia Jiang wrote:
> > Change device node number from 3 to -1 because that the driver will
> > also support jpeg encoder.
> >
>
> Thanks for the patch. T
On Thu, 2020-05-21 at 15:22 +, Tomasz Figa wrote:
> Hi Xia,
>
> On Fri, Apr 03, 2020 at 05:40:24PM +0800, Xia Jiang wrote:
> > Call pm_runtime_get_sync() before starting a frame and then
> > pm_runtime_put() after completing it. This can save power for the time
>
On Thu, 2020-05-21 at 15:41 +, Tomasz Figa wrote:
> Hi Xia,
>
> On Fri, Apr 03, 2020 at 05:40:26PM +0800, Xia Jiang wrote:
>
> Thank you for the patch. Please see my comments inline.
>
> nit: I'd remove "for improving code quality" from the subject, as it's
On Thu, 2020-05-21 at 15:49 +, Tomasz Figa wrote:
> Hi Xia,
>
> On Fri, Apr 03, 2020 at 05:40:29PM +0800, Xia Jiang wrote:
> > Delete unused member variables annotation.
> > Delete unused variable definition.
> > Delete redundant log print, because V4
On Mon, 2020-05-11 at 10:37 +0200, Hans Verkuil wrote:
> On 03/04/2020 11:40, Xia Jiang wrote:
> > Change register offset hex numberals from upercase to lowercase.
>
> Typos:
>
> numberals -> numerals
>
> upercase -> uppercase
Done.
>
> Regards,
>
&
On Mon, 2020-05-11 at 11:04 +0200, Hans Verkuil wrote:
> On 03/04/2020 11:40, Xia Jiang wrote:
> > Add mtk jpeg encode v4l2 driver based on jpeg decode, because that jpeg
> > decode and encode have great similarities with function operation.
> >
> > Signed-off-by: Xia
.
fix msleadingly indented of 'else'.
Xia Jiang (5):
media: dt-bindings: Add jpeg enc device tree node document
arm: dts: Add jpeg enc device tree node
media: platform: Rename jpeg dec file name
media: platform: Fix v4l2-compliance test bug
media: platform: Add jpeg dec/enc
Add jpeg enc device tree node document
Reviewed-by: Rob Herring
Signed-off-by: Xia Jiang
---
v4: no changes
v3: change compatible to SoC specific compatible
v2: no changes
---
.../bindings/media/mediatek-jpeg-encoder.txt | 37 +++
1 file changed, 37 insertions(+)
create
Rename the files which are for decode feature. This is preparing
path since the jpeg enc patch will be added later.
Signed-off-by: Xia Jiang
---
v4: no changes
v3: no changes
v2: no changes
---
drivers/media/platform/mtk-jpeg/Makefile | 2 +-
drivers/media/platform/mtk
Add jpeg enc device tree node
Signed-off-by: Xia Jiang
---
v4: no changes
v3: change compatible to SoC specific compatible
v2: no changes
---
arch/arm/boot/dts/mt2701.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts
Improve subscribe event handling: let v4l2_ctrl_subscribe_event() do the
job for other types except V4L2_EVENT_SOURCE_CHANGE.
Add checking created buffer size follow in mtk_jpeg_queue_setup().
Signed-off-by: Xia Jiang
---
v4: new add patch for v4l2-compliance test bug fix
---
drivers/media
Add mtk jpeg encode v4l2 driver based on jpeg decode, because that jpeg
decode and encode have great similarities with function operation.
Signed-off-by: Xia Jiang
---
v4: split mtk_jpeg_try_fmt_mplane() to two functions, one for encoder,
one for decoder.
split
Add jpeg enc device tree node document.
Signed-off-by: Xia Jiang
---
v3: change compatible to SoC specific compatible
v2: no changes
---
.../bindings/media/mediatek-jpeg-encoder.txt | 37 +++
1 file changed, 37 insertions(+)
create mode 100644
Documentation/devicetree
-only test once handler->error after the last v4l2_ctrl_new_std()
-add a new separate patch for adding V4L2_CID_JPEG_ENABLE_EXIF
-change device tree node property compatible to an SoC specific compatible
-delete changing GPLv2 license to SPDX patch which new kernel has include
Xia Jiang
Add jpeg enc device tree node.
Signed-off-by: Xia Jiang
---
v3: change compatible to SoC specific compatible
v2: no changes
---
arch/arm/boot/dts/mt2701.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
index
Rename the files which are for decode feature. This is preparing
path since the jpeg enc patch will be added later.
Signed-off-by: Xia Jiang
---
v3: no changes
v2: no changes
---
drivers/media/platform/mtk-jpeg/Makefile | 2 +-
drivers/media/platform/mtk-jpeg
Add mtk jpeg encode v4l2 driver based on jpeg decode, because that jpeg
decode and encode have great similarities with function operation.
Signed-off-by: Xia Jiang
---
v3: delete Change-Id
only test once handler->error after the last v4l2_ctrl_new_std()
seperate changes of v4l2-ctrl
Add jpeg enc CID definition for exif mode control.
Signed-off-by: Xia Jiang
---
v3: new add patch for V4L2_CID_JPEG_ENABLE_EXIF
---
Documentation/media/uapi/v4l/ext-ctrls-jpeg.rst | 10 ++
drivers/media/v4l2-core/v4l2-ctrls.c| 1 +
include/uapi/linux/v4l2-controls.h
On Thu, 2020-07-30 at 16:34 +, Tomasz Figa wrote:
> Hi Xia,
>
> On Thu, Jul 23, 2020 at 11:04:45AM +0800, Xia Jiang wrote:
> > Use the generic of_property_* helpers to get the clock_nums and clocks
> > from device tree.
> > Use the generic clk_bulk_* helpers t
On Mon, 2020-06-08 at 07:36 +0800, Chun-Kuang Hu wrote:
> Hi, Xia:
>
> Xia Jiang 於 2020年6月4日 週四 下午5:21寫道：
> >
> > Add mtk jpeg encode v4l2 driver based on jpeg decode, because that jpeg
> > decode and encode have great similarities with function operation.
>
On Mon, 2020-06-08 at 12:54 +0200, Hans Verkuil wrote:
> On 04/06/2020 11:05, Xia Jiang wrote:
> > Add mtk jpeg encode v4l2 driver based on jpeg decode, because that jpeg
> > decode and encode have great similarities with function operation.
> >
> > Signed-off-by: Xia
On Thu, 2020-06-11 at 18:46 +, Tomasz Figa wrote:
> Hi Xia,
>
> On Thu, Jun 04, 2020 at 05:05:53PM +0800, Xia Jiang wrote:
> > Add mtk jpeg encode v4l2 driver based on jpeg decode, because that jpeg
> > decode and encode have great similarities with function operation
Let v4l2_ctrl_subscribe_event() do the job for other types except
V4L2_EVENT_SOURCE_CHANGE.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v10: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
There is a delayed work scheduled before starting the hardware and
canceled in the interrupt handler. If the delayed work is executed, it
resets the hardware and reports the failure to V4L2, so that the
execution can continue from next frames.
Signed-off-by: Xia Jiang
---
v10: new add patch
There is no need to queue an empty buffer for signaling a last frame,
because all frames are separate from each other in JPEG.
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v10: delete mtk_jpeg_qbuf()
---
.../media/platform/mtk-jpeg/mtk_jpeg_core.c | 46 +--
1 file
Add v4l2_m2m_suspend() function call in mtk_jpeg_suspend() to make sure
that the current frame is processed completely before suspend.
Add v4l2_m2m_resume() function call in mtk_jpeg_resume() to unblock the
driver from scheduling next frame.
Signed-off-by: Xia Jiang
---
v10: use
Add checking created buffer size follow in mtk_jpeg_queue_setup().
Reviewed-by: Tomasz Figa
Signed-off-by: Xia Jiang
---
v10: no changes
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/platform/mtk-jpeg
1 - 100 of 169 matches
Mail list logo
