[PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-11 Thread YH Huang
Add display PWM driver support to modify backlight for MT8173/MT6595. Signed-off-by: YH Huang yh.hu...@mediatek.com --- drivers/pwm/Kconfig | 9 ++ drivers/pwm/Makefile| 1 + drivers/pwm/pwm-disp-mediatek.c | 225 3 files

[PATCH 0/2] Add Mediatek display PWM driver

2015-05-11 Thread YH Huang
This patch series add the use of display PWM driver and documentation for Mediatek SoCs. The driver is used to support the backlight of the panel. This is based on v4.1-rc1. YH Huang (2): dt-bindings: pwm: add Mediatek display PWM bindings pwm: add Mediatek display PWM driver support

[PATCH 1/2] dt-bindings: pwm: add Mediatek display PWM bindings

2015-05-11 Thread YH Huang
Document the device-tree binding of Mediatek display PWM. Signed-off-by: YH Huang yh.hu...@mediatek.com --- .../devicetree/bindings/pwm/pwm-disp-mediatek.txt | 25 ++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/pwm-disp

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-14 Thread YH Huang
On Tue, 2015-05-12 at 14:37 +0200, Matthias Brugger wrote: Hi YH, 2015-05-11 11:26 GMT+02:00 YH Huang yh.hu...@mediatek.com: Add display PWM driver support to modify backlight for MT8173/MT6595. Signed-off-by: YH Huang yh.hu...@mediatek.com --- drivers/pwm/Kconfig | 9

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-14 Thread YH Huang
On Tue, 2015-05-12 at 16:34 +0200, Matthias Brugger wrote: 2015-05-12 15:32 GMT+02:00 Thierry Reding thierry.red...@gmail.com: On Mon, May 11, 2015 at 05:26:22PM +0800, YH Huang wrote: Add display PWM driver support to modify backlight for MT8173/MT6595. Signed-off-by: YH Huang yh.hu

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-14 Thread YH Huang
On Tue, 2015-05-12 at 15:00 +0200, Sascha Hauer wrote: On Mon, May 11, 2015 at 05:26:22PM +0800, YH Huang wrote: + +static int mtk_disp_pwm_probe(struct platform_device *pdev) +{ + struct mtk_disp_pwm_chip *pwm; The struct mtk_disp_pwm_chip * is named 'mpc' in the other functions

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-14 Thread YH Huang
On Tue, 2015-05-12 at 14:44 +0200, Matthias Brugger wrote: 2015-05-12 14:37 GMT+02:00 Matthias Brugger matthias@gmail.com: Hi YH, 2015-05-11 11:26 GMT+02:00 YH Huang yh.hu...@mediatek.com: Add display PWM driver support to modify backlight for MT8173/MT6595. Signed-off-by: YH

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-14 Thread YH Huang
On Tue, 2015-05-12 at 15:32 +0200, Thierry Reding wrote: On Mon, May 11, 2015 at 05:26:22PM +0800, YH Huang wrote: Add display PWM driver support to modify backlight for MT8173/MT6595. Signed-off-by: YH Huang yh.hu...@mediatek.com --- drivers/pwm/Kconfig | 9

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-21 Thread YH Huang
On Mon, 2015-05-18 at 11:42 +0800, Daniel Kurtz wrote: On Mon, May 11, 2015 at 5:26 PM, YH Huang yh.hu...@mediatek.com wrote: Add display PWM driver support to modify backlight for MT8173/MT6595. Signed-off-by: YH Huang yh.hu...@mediatek.com --- drivers/pwm/Kconfig | 9

Re: [PATCH v2 0/2] Add MediaTek display PWM driver

2015-06-05 Thread YH Huang
On Mon, 2015-05-25 at 10:14 +0800, Yingjoe Chen wrote: On Thu, 2015-05-21 at 21:29 +0800, YH Huang wrote: This patch series add the use of display PWM driver and documentation for Mediatek SoCs. The driver is used to support the backlight of the panel. This is based on v4.1-rc1. YH Huang

Re: [PATCH v2 0/2] Add MediaTek display PWM driver

2015-06-05 Thread YH Huang
On Fri, 2015-06-05 at 10:39 +0200, Matthias Brugger wrote: Hi YH, 2015-06-05 8:15 GMT+02:00 YH Huang yh.hu...@mediatek.com: On Mon, 2015-05-25 at 10:14 +0800, Yingjoe Chen wrote: On Thu, 2015-05-21 at 21:29 +0800, YH Huang wrote: This patch series add the use of display PWM driver

Re: [PATCH v2 2/2] pwm: add MediaTek display PWM driver support

2015-06-18 Thread YH Huang
On Fri, 2015-06-12 at 12:20 +0200, Thierry Reding wrote: On Thu, May 21, 2015 at 09:29:24PM +0800, YH Huang wrote: Add display PWM driver support to modify backlight for MT8173. Signed-off-by: YH Huang yh.hu...@mediatek.com --- drivers/pwm/Kconfig| 10 ++ drivers/pwm

Re: [PATCH v2 1/2] dt-bindings: pwm: add MediaTek display PWM bindings

2015-06-18 Thread YH Huang
On Fri, 2015-06-12 at 12:23 +0200, Thierry Reding wrote: On Thu, May 21, 2015 at 09:29:23PM +0800, YH Huang wrote: Document the device-tree binding of MediatTek display PWM. s/MediatTek/MediaTek/ Signed-off-by: YH Huang yh.hu...@mediatek.com This could use a more verbose commit

Re: [PATCH v2 2/2] pwm: add MediaTek display PWM driver support

2015-06-18 Thread YH Huang
On Fri, 2015-06-12 at 12:25 +0200, Thierry Reding wrote: On Thu, May 21, 2015 at 09:29:24PM +0800, YH Huang wrote: Add display PWM driver support to modify backlight for MT8173. The driver also claims compatibility with MT6595, so you should mention that here as well. Also please be more

[PATCH v3 2/2] pwm: add MediaTek display PWM driver support

2015-06-29 Thread YH Huang
-off-by: YH Huang yh.hu...@mediatek.com --- drivers/pwm/Kconfig| 10 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-mtk-disp.c | 256 + 3 files changed, 267 insertions(+) create mode 100644 drivers/pwm/pwm-mtk-disp.c diff --git a/drivers

[PATCH v3 1/2] dt-bindings: pwm: add MediaTek display PWM bindings

2015-06-29 Thread YH Huang
Document the device-tree binding of MediatTek display PWM. The clock main and mm are used to generate PWM signals. The PWM has one channel to control the backlight brightness for display. It supports MT8173 and MT6595. Change-Id: I194ca88b4e4cd01a28b8701e07e86ea6941e5292 Signed-off-by: YH Huang

[PATCH v3 0/2] Add MediaTek display PWM driver

2015-06-29 Thread YH Huang
This patch series add the use of display PWM driver and documentation for Mediatek SoCs. The driver is used to support the backlight of the panel. This is based on v4.1-rc1. Change in v3: 1. Add suspend/resume function 2. Fix the formula for high_width calculation 3. Rewrite some code to make

Re: [PATCH v3 1/2] dt-bindings: pwm: add MediaTek display PWM bindings

2015-06-29 Thread YH Huang
I am sorry for forgetting to remove Change-Id in [PATCH v3 1/2] and [PATCH v3 1/2]. Regards, YH Huang On Mon, 2015-06-29 at 23:03 +0800, YH Huang wrote: Document the device-tree binding of MediatTek display PWM. The clock main and mm are used to generate PWM signals. The PWM has one channel

Re: [PATCH v3 0/2] Add MediaTek display PWM driver

2015-07-06 Thread YH Huang
Hi Daniel, I will add PWM dtsi in the next patch and also fix the code with your suggestions in other mails. Regards, YH Huang On Tue, 2015-06-30 at 14:35 +0800, Daniel Kurtz wrote: Hi YH, Please also include a patch that adds PWM bindings to mt8173.dtsi. The clock definitions

[PATCH v4 2/3] pwm: add MediaTek display PWM driver support

2015-07-06 Thread YH Huang
Add display PWM driver support to modify backlight for MT8173 and MT6595. The PWM has one channel to control the brightness of the display. When the (high_width / period) is closer to 1, the screen is brighter; otherwise, it is darker. Signed-off-by: YH Huang yh.hu...@mediatek.com --- drivers

[PATCH v4 3/3] arm64: dts: mt8173: add MT8173 display PWM driver support dtsi

2015-07-06 Thread YH Huang
Add display PWM node in mt8173.dtsi. Signed-off-by: YH Huang yh.hu...@mediatek.com --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index

[PATCH v4 0/3] Add MediaTek display PWM driver

2015-07-06 Thread YH Huang
clocks of MT8173 Change in v4: 1. Codebase is on v4.2-rc1 2. Add the PWM node in dtsi 3. Change the dependency in Kconfig 4. Rewrite some code for readability YH Huang (3): dt-bindings: pwm: add MediaTek display PWM bindings pwm: add MediaTek display PWM driver support arm64: dts: mt8173: add

[PATCH v4 1/3] dt-bindings: pwm: add MediaTek display PWM bindings

2015-07-06 Thread YH Huang
Document the device-tree binding of MediatTek display PWM. The PWM has one channel to control the backlight brightness for display. It supports MT8173 and MT6595. Signed-off-by: YH Huang yh.hu...@mediatek.com --- .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 24 ++ 1

[PATCH v2 1/2] dt-bindings: pwm: add MediaTek display PWM bindings

2015-05-21 Thread YH Huang
Document the device-tree binding of MediatTek display PWM. Signed-off-by: YH Huang yh.hu...@mediatek.com --- .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 25 ++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt

[PATCH v2 2/2] pwm: add MediaTek display PWM driver support

2015-05-21 Thread YH Huang
Add display PWM driver support to modify backlight for MT8173. Signed-off-by: YH Huang yh.hu...@mediatek.com --- drivers/pwm/Kconfig| 10 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-mtk-disp.c | 228 + 3 files changed, 239

[PATCH v2 0/2] Add MediaTek display PWM driver

2015-05-21 Thread YH Huang
YH Huang (2): dt-bindings: pwm: add MediaTek display PWM bindings pwm: add MediaTek display PWM driver support .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 25 +++ drivers/pwm/Kconfig| 10 + drivers/pwm/Makefile | 1

Re: [PATCH v4 3/3] arm64: dts: mt8173: add MT8173 display PWM driver support dtsi

2015-07-06 Thread YH Huang
On Mon, 2015-07-06 at 21:38 +0800, Daniel Kurtz wrote: On Mon, Jul 6, 2015 at 9:29 PM, YH Huang yh.hu...@mediatek.com wrote: Add display PWM node in mt8173.dtsi. Signed-off-by: YH Huang yh.hu...@mediatek.com --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 22 ++ 1

Re: [PATCH v6 1/3] dt-bindings: pwm: add MediaTek display PWM bindings

2015-08-17 Thread YH Huang
On Mon, 2015-08-17 at 15:23 +0200, Thierry Reding wrote: On Mon, Jul 20, 2015 at 04:17:15PM +0800, YH Huang wrote: Document the device-tree binding of MediatTek display PWM. I already mentioned this a while back: s/MediatTek/MediaTek/. Sorry, I will correct it to MediaTek. Regards, YH

Re: [PATCH v6 2/3] pwm: add MediaTek display PWM driver support

2015-08-17 Thread YH Huang
On Mon, 2015-08-17 at 15:23 +0200, Thierry Reding wrote: On Mon, Jul 20, 2015 at 04:17:16PM +0800, YH Huang wrote: Add display PWM driver support to modify backlight for MT8173 and MT6595. The PWM has one channel to control the brightness of the display. When the (high_width / period

[PATCH v7 2/3] pwm: add MediaTek display PWM driver support

2015-08-18 Thread YH Huang
Add display PWM driver support to modify backlight for MT8173 and MT6595. The PWM has one channel to control the brightness of the display. When the (high_width / period) is closer to 1, the screen is brighter; otherwise, it is darker. Signed-off-by: YH Huang yh.hu...@mediatek.com --- drivers

[PATCH v7 1/3] dt-bindings: pwm: add MediaTek display PWM bindings

2015-08-18 Thread YH Huang
Document the device-tree binding of MediaTek display PWM. The PWM has one channel to control the backlight brightness for display. It supports MT8173 and MT6595. Signed-off-by: YH Huang yh.hu...@mediatek.com --- .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 42 1

[PATCH v7 3/3] arm64: dts: mt8173: add MT8173 display PWM driver support node

2015-08-18 Thread YH Huang
Add display PWM node in mt8173-evb.dts and mt8173.dtsi. Signed-off-by: YH Huang yh.hu...@mediatek.com --- arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 13 + arch/arm64/boot/dts/mediatek/mt8173.dtsi| 22 ++ 2 files changed, 35 insertions(+) diff --git

[PATCH v7 0/3] Add MediaTek display PWM driver

2015-08-18 Thread YH Huang
clocks in the error path. 4. Change the shift values in decimal instead of hex. 5. Rename and add some variables or function name for consistency and readability. 6. Drop unnecessary parentheses, spaces, variables and add newlines to make the code easiler to read. YH Huang (3): dt-bindings: pwm: add

Re: [PATCH v6 0/3] Add MediaTek display PWM driver

2015-07-28 Thread YH Huang
On Fri, 2015-07-24 at 17:10 +0800, YH Huang wrote: On Fri, 2015-07-24 at 10:42 +0200, Matthias Brugger wrote: On Monday, July 20, 2015 04:17:14 PM YH Huang wrote: This patch series add the use of display PWM driver, documentation and device tree for Mediatek SoCs. The driver is used

Re: [PATCH v6 0/3] Add MediaTek display PWM driver

2015-08-03 Thread YH Huang
On Fri, 2015-07-24 at 17:10 +0800, YH Huang wrote: On Fri, 2015-07-24 at 10:42 +0200, Matthias Brugger wrote: On Monday, July 20, 2015 04:17:14 PM YH Huang wrote: This patch series add the use of display PWM driver, documentation and device tree for Mediatek SoCs. The driver is used

Re: [PATCH v6 0/3] Add MediaTek display PWM driver

2015-07-24 Thread YH Huang
On Fri, 2015-07-24 at 10:42 +0200, Matthias Brugger wrote: On Monday, July 20, 2015 04:17:14 PM YH Huang wrote: This patch series add the use of display PWM driver, documentation and device tree for Mediatek SoCs. The driver is used to support the backlight of the panel. This is based

[PATCH v5 1/3] dt-bindings: pwm: add MediaTek display PWM bindings

2015-07-13 Thread YH Huang
Document the device-tree binding of MediatTek display PWM. The PWM has one channel to control the backlight brightness for display. It supports MT8173 and MT6595. Signed-off-by: YH Huang yh.hu...@mediatek.com --- .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 29 ++ 1

[PATCH v5 3/3] arm64: dts: mt8173: add MT8173 display PWM driver support node

2015-07-13 Thread YH Huang
Add display PWM node in mt8173-evb.dts and mt8173.dtsi. Signed-off-by: YH Huang yh.hu...@mediatek.com --- arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 15 +++ arch/arm64/boot/dts/mediatek/mt8173.dtsi| 22 ++ 2 files changed, 37 insertions(+) diff --git

[PATCH v5 2/3] pwm: add MediaTek display PWM driver support

2015-07-13 Thread YH Huang
Add display PWM driver support to modify backlight for MT8173 and MT6595. The PWM has one channel to control the brightness of the display. When the (high_width / period) is closer to 1, the screen is brighter; otherwise, it is darker. Signed-off-by: YH Huang yh.hu...@mediatek.com --- drivers

[PATCH v5 0/3] Add MediaTek display PWM driver

2015-07-13 Thread YH Huang
clocks of MT8173 Change in v5: 1. Configure PWM output via pinctrl 2. Fix the parameter name in dtsi YH Huang (3): dt-bindings: pwm: add MediaTek display PWM bindings pwm: add MediaTek display PWM driver support arm64: dts: mt8173: add MT8173 display PWM driver support node .../devicetree

Re: [PATCH v5 2/3] pwm: add MediaTek display PWM driver support

2015-07-15 Thread YH Huang
On Wed, 2015-07-15 at 23:59 +0800, YH Huang wrote: On Mon, 2015-07-13 at 18:19 +0800, Daniel Kurtz wrote: On Mon, Jul 13, 2015 at 5:04 PM, YH Huang yh.hu...@mediatek.com wrote: Add display PWM driver support to modify backlight for MT8173 and MT6595. The PWM has one channel to control

Re: [PATCH v5 2/3] pwm: add MediaTek display PWM driver support

2015-07-16 Thread YH Huang
On Thu, 2015-07-16 at 14:54 +0800, Daniel Kurtz wrote: On Thu, Jul 16, 2015 at 1:38 PM, YH Huang yh.hu...@mediatek.com wrote: On Wed, 2015-07-15 at 23:59 +0800, YH Huang wrote: On Mon, 2015-07-13 at 18:19 +0800, Daniel Kurtz wrote: On Mon, Jul 13, 2015 at 5:04 PM, YH Huang yh.hu

Re: [PATCH v5 2/3] pwm: add MediaTek display PWM driver support

2015-07-16 Thread YH Huang
On Thu, 2015-07-16 at 23:21 +0800, Daniel Kurtz wrote: On Thu, Jul 16, 2015 at 3:17 PM, YH Huang yh.hu...@mediatek.com wrote: On Thu, 2015-07-16 at 14:54 +0800, Daniel Kurtz wrote: On Thu, Jul 16, 2015 at 1:38 PM, YH Huang yh.hu...@mediatek.com wrote: On Wed, 2015-07-15 at 23:59 +0800, YH

Re: [PATCH v5 2/3] pwm: add MediaTek display PWM driver support

2015-07-17 Thread YH Huang
On Fri, 2015-07-17 at 01:18 +0800, Daniel Kurtz wrote: On Fri, Jul 17, 2015 at 12:44 AM, YH Huang yh.hu...@mediatek.com wrote: On Thu, 2015-07-16 at 23:21 +0800, Daniel Kurtz wrote: On Thu, Jul 16, 2015 at 3:17 PM, YH Huang yh.hu...@mediatek.com wrote: On Thu, 2015-07-16 at 14:54 +0800

Re: [PATCH v5 2/3] pwm: add MediaTek display PWM driver support

2015-07-17 Thread YH Huang
On Fri, 2015-07-17 at 14:59 +0800, Daniel Kurtz wrote: On Fri, Jul 17, 2015 at 2:35 PM, YH Huang yh.hu...@mediatek.com wrote: On Fri, 2015-07-17 at 01:18 +0800, Daniel Kurtz wrote: On Fri, Jul 17, 2015 at 12:44 AM, YH Huang yh.hu...@mediatek.com wrote: On Thu, 2015-07-16 at 23:21 +0800

[PATCH v6 1/3] dt-bindings: pwm: add MediaTek display PWM bindings

2015-07-20 Thread YH Huang
Document the device-tree binding of MediatTek display PWM. The PWM has one channel to control the backlight brightness for display. It supports MT8173 and MT6595. Signed-off-by: YH Huang yh.hu...@mediatek.com --- .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 42 ++ 1

[PATCH v6 3/3] arm64: dts: mt8173: add MT8173 display PWM driver support node

2015-07-20 Thread YH Huang
Add display PWM node in mt8173-evb.dts and mt8173.dtsi. Signed-off-by: YH Huang yh.hu...@mediatek.com --- arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 15 +++ arch/arm64/boot/dts/mediatek/mt8173.dtsi| 22 ++ 2 files changed, 37 insertions(+) diff --git

[PATCH v6 2/3] pwm: add MediaTek display PWM driver support

2015-07-20 Thread YH Huang
Add display PWM driver support to modify backlight for MT8173 and MT6595. The PWM has one channel to control the brightness of the display. When the (high_width / period) is closer to 1, the screen is brighter; otherwise, it is darker. Signed-off-by: YH Huang yh.hu...@mediatek.com --- drivers

[PATCH v6 0/3] Add MediaTek display PWM driver

2015-07-20 Thread YH Huang
clocks of MT8173 Change in v6: 1. Enable clocks in the pwm_enable function 2. Remove suspend/resume code since pwm-backlight driver has done the same things 3. Revise some code to make it easier to read YH Huang (3): dt-bindings: pwm: add MediaTek display PWM bindings pwm: add MediaTek display

Re: [PATCH v5 2/3] pwm: add MediaTek display PWM driver support

2015-07-15 Thread YH Huang
On Mon, 2015-07-13 at 18:19 +0800, Daniel Kurtz wrote: On Mon, Jul 13, 2015 at 5:04 PM, YH Huang yh.hu...@mediatek.com wrote: Add display PWM driver support to modify backlight for MT8173 and MT6595. The PWM has one channel to control the brightness of the display. When the (high_width

Re: [PATCH v5 1/3] dt-bindings: pwm: add MediaTek display PWM bindings

2015-07-15 Thread YH Huang
On Mon, 2015-07-13 at 18:20 +0800, Daniel Kurtz wrote: On Mon, Jul 13, 2015 at 5:04 PM, YH Huang yh.hu...@mediatek.com wrote: Document the device-tree binding of MediatTek display PWM. The PWM has one channel to control the backlight brightness for display. It supports MT8173 and MT6595

Re: [RESEND PATCH] pwm-backlight: fix the panel power sequence

2015-10-22 Thread YH Huang
On Fri, 2015-10-16 at 10:31 +0200, Lucas Stach wrote: > Am Freitag, den 16.10.2015, 09:37 +0800 schrieb YH Huang: > > In order to match the panel power sequence, disable the enable_gpio > > in the probe function. Also, reorder the code in the power_on and > > power_off functio

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

2015-10-22 Thread YH Huang
On Fri, 2015-10-16 at 11:36 +0200, Philipp Zabel wrote: > Am Freitag, den 16.10.2015, 17:17 +0800 schrieb YH Huang: > > In order to match the panel power sequence, disable the enable_gpio > > in the probe function. Also, reorder the code in the power_on and > > power_

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

2015-10-30 Thread YH Huang
Hi Hpilipp, On Thu, 2015-10-29 at 16:40 +0100, Philipp Zabel wrote: > Hi YH, > > Am Donnerstag, den 22.10.2015, 23:12 +0800 schrieb YH Huang: > > In the case of the panel disabled by the bootloader, > > your patch still has the following code and always enables the backl

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

2015-11-03 Thread YH Huang
On Fri, 2015-10-30 at 11:34 +0100, Philipp Zabel wrote: > Am Freitag, den 30.10.2015, 15:41 +0800 schrieb YH Huang: > > > That won't work if the gpio is still configured as input. How about I > > > add the GPIOD_ASIS change to my patch you remove that and the above from &g

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

2015-11-03 Thread YH Huang
On Tue, 2015-11-03 at 12:08 +0100, Philipp Zabel wrote: > Hi YH, > > Am Dienstag, den 03.11.2015, 16:11 +0800 schrieb YH Huang: > > > The reasoning is that devices where there is no phandle link pointing to > > > the backlight (for example from a simple-

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

2015-11-06 Thread YH Huang
direction is > already output and the value is already 1. > Also, I propose to set initial blanking to FB_BLANK_POWERDOWN in this > case, and wait for the panel driver to enable the backlight at the > appropriate time. Thanks your kindly reply. Your patch looks good to me. Regards, YH Huan

Re: [PATCH] pwm-backlight: fix the panel power sequence

2015-10-14 Thread YH Huang
Hi all, If you have any suggestion, please let me know. Thanks. Regards, YH Huang On Wed, 2015-09-16 at 22:42 +0800, YH Huang wrote: > In order to match the panel power sequence, disable the enable_gpio > in the probe function. Also, reorder the code in the power_on and > power_off

[RESEND PATCH] pwm-backlight: fix the panel power sequence

2015-10-15 Thread YH Huang
In order to match the panel power sequence, disable the enable_gpio in the probe function. Also, reorder the code in the power_on and power_off function to match the timing. Signed-off-by: YH Huang <yh.hu...@mediatek.com> --- drivers/video/backlight/pwm_bl.c | 15 +--

Re: [RESEND PATCH] pwm-backlight: fix the panel power sequence

2015-10-16 Thread YH Huang
On Fri, 2015-10-16 at 10:36 +0200, Sascha Hauer wrote: > On Fri, Oct 16, 2015 at 09:37:34AM +0800, YH Huang wrote: > > In order to match the panel power sequence, disable the enable_gpio > > in the probe function. Also, reorder the code in the power_on and > > power_

Re: [RESEND PATCH] pwm-backlight: fix the panel power sequence

2015-10-16 Thread YH Huang
On Fri, 2015-10-16 at 10:42 +0800, kbuild test robot wrote: > Hi YH, > > [auto build test ERROR on pwm/for-next -- if it's inappropriate base, please > suggest rules for selecting the more suitable base] > > url: > https://github.com/0day-ci/linux/commits/YH-Hu

[PATCH v2] pwm-backlight: fix the panel power sequence

2015-10-16 Thread YH Huang
In order to match the panel power sequence, disable the enable_gpio in the probe function. Also, reorder the code in the power_on and power_off function to match the timing. Signed-off-by: YH Huang <yh.hu...@mediatek.com> --- Change in v2: Fix the build error. --- drivers/video/bac

[PATCH] arm64: dts: mt8173: add MT8173 display PWM driver support node

2015-10-06 Thread YH Huang
Add display PWM node in mt8173-evb.dts and mt8173.dtsi. Signed-off-by: YH Huang <yh.hu...@mediatek.com> --- arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 13 + arch/arm64/boot/dts/mediatek/mt8173.dtsi| 22 ++ 2 files changed, 35 insertions(+) diff

Re: [PATCH v4 1/3] dt-bindings: pwm: add MediaTek display PWM bindings

2015-07-08 Thread YH Huang
On Wed, 2015-07-08 at 20:11 +0800, Daniel Kurtz wrote: On Mon, Jul 6, 2015 at 9:29 PM, YH Huang yh.hu...@mediatek.com wrote: Document the device-tree binding of MediatTek display PWM. The PWM has one channel to control the backlight brightness for display. It supports MT8173 and MT6595

Re: [PATCH v4 1/3] dt-bindings: pwm: add MediaTek display PWM bindings

2015-07-09 Thread YH Huang
On Thu, 2015-07-09 at 12:47 +0800, Daniel Kurtz wrote: On Thu, Jul 9, 2015 at 10:45 AM, YH Huang yh.hu...@mediatek.com wrote: On Wed, 2015-07-08 at 20:11 +0800, Daniel Kurtz wrote: On Mon, Jul 6, 2015 at 9:29 PM, YH Huang yh.hu...@mediatek.com wrote: Document the device-tree binding

[PATCH] pwm-backlight: fix the panel power sequence

2015-09-16 Thread YH Huang
In order to match the panel power sequence, disable the enable_gpio in the probe function. Also, reorder the code in the power_on and power_off function to match the timing. Signed-off-by: YH Huang <yh.hu...@mediatek.com> --- drivers/video/backlight/pwm_bl.c | 15 +--

Re: [PATCH v7 0/3] Add MediaTek display PWM driver

2015-09-14 Thread YH Huang
On Tue, 2015-08-18 at 15:27 +0800, YH Huang wrote: > This patch series add the use of display PWM driver, documentation > and device tree for Mediatek SoCs. The driver is used to support > the backlight of the panel. This is based on v4.2-rc1. > > The clock definitions (

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-28 Thread YH Huang
On Mon, 2016-03-28 at 11:57 -0400, Rhyland Klein wrote: > On 3/28/2016 6:05 AM, Daniel Kurtz wrote: > > +Rhyland Klein who original wrote this code... > > > > On Mon, Mar 28, 2016 at 10:32 AM, YH Huang <yh.hu...@mediatek.com> wrote: > >> > >> On Fri,

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-30 Thread YH Huang
On Wed, 2016-03-30 at 17:09 +0200, Sebastian Reichel wrote: > Hi, > > On Wed, Mar 30, 2016 at 04:58:30PM +0800, YH Huang wrote: > > If I revise the description in this way(using your clear explanation): > > ---

[PATCH] sbs-battery: fix power status when battery charging near dry

2016-04-05 Thread YH Huang
BATTERY_DISCHARGING to decide the power supply status is discharging or charging. Signed-off-by: YH Huang <yh.hu...@mediatek.com> --- drivers/power/sbs-battery.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/power/sbs-battery.c b/drivers/power/sbs-battery.c index d6226d6..768b9fc

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-04-05 Thread YH Huang
On Sat, 2016-04-02 at 05:46 +0200, Sebastian Reichel wrote: > Hi, > > On Thu, Mar 31, 2016 at 10:42:31AM +0800, YH Huang wrote: > > On Wed, 2016-03-30 at 17:09 +0200, Sebastian Reichel wrote: > > > Hi, > > > > > > On Wed, Mar 30, 2016 at 04:58:30PM

[PATCH] sbs-battery: fix power status when battery is dry

2016-03-23 Thread YH Huang
When the battery is dry and BATTERY_FULL_DISCHARGED is set, we should check BATTERY_DISCHARGING to decide the power status. If BATTERY_DISCHARGING is set, the power status is not charging. Or the power status should be charging. Signed-off-by: YH Huang <yh.hu...@mediatek.com> --- drivers

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-24 Thread YH Huang
Hi Daniel, On Thu, 2016-03-24 at 12:01 +0800, Daniel Kurtz wrote: > Hi YH, > > On Wed, Mar 23, 2016 at 5:53 PM, YH Huang <yh.hu...@mediatek.com> wrote: > > When the battery is dry and BATTERY_FULL_DISCHARGED is set, > > we should check BATTERY_DISCHARGING

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-27 Thread YH Huang
On Fri, 2016-03-25 at 11:06 +0800, Daniel Kurtz wrote: > On Thu, Mar 24, 2016 at 2:43 PM, YH Huang <yh.hu...@mediatek.com> wrote: > > > > Hi Daniel, > > > > On Thu, 2016-03-24 at 12:01 +0800, Daniel Kurtz wrote: > > > Hi YH, > > > >

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-30 Thread YH Huang
On Tue, 2016-03-29 at 11:05 -0400, Rhyland Klein wrote: > On 3/28/2016 9:52 PM, YH Huang wrote: > > On Mon, 2016-03-28 at 11:57 -0400, Rhyland Klein wrote: > >> On 3/28/2016 6:05 AM, Daniel Kurtz wrote: > >>> +Rhyland Klein who original wrote this code... > >&g

Re: [PATCH v6 0/3] Add MediaTek display PWM driver

2015-07-28 Thread YH Huang
On Fri, 2015-07-24 at 17:10 +0800, YH Huang wrote: > On Fri, 2015-07-24 at 10:42 +0200, Matthias Brugger wrote: > > On Monday, July 20, 2015 04:17:14 PM YH Huang wrote: > > > This patch series add the use of display PWM driver, documentation > > > and device tree fo

Re: [PATCH v6 0/3] Add MediaTek display PWM driver

2015-07-24 Thread YH Huang
On Fri, 2015-07-24 at 10:42 +0200, Matthias Brugger wrote: > On Monday, July 20, 2015 04:17:14 PM YH Huang wrote: > > This patch series add the use of display PWM driver, documentation > > and device tree for Mediatek SoCs. The driver is used to support > > the b

[PATCH v6 3/3] arm64: dts: mt8173: add MT8173 display PWM driver support node

2015-07-20 Thread YH Huang
Add display PWM node in mt8173-evb.dts and mt8173.dtsi. Signed-off-by: YH Huang --- arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 15 +++ arch/arm64/boot/dts/mediatek/mt8173.dtsi| 22 ++ 2 files changed, 37 insertions(+) diff --git a/arch/arm64/boot/dts

[PATCH v6 1/3] dt-bindings: pwm: add MediaTek display PWM bindings

2015-07-20 Thread YH Huang
Document the device-tree binding of MediatTek display PWM. The PWM has one channel to control the backlight brightness for display. It supports MT8173 and MT6595. Signed-off-by: YH Huang --- .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 42 ++ 1 file changed, 42

[PATCH v6 2/3] pwm: add MediaTek display PWM driver support

2015-07-20 Thread YH Huang
Add display PWM driver support to modify backlight for MT8173 and MT6595. The PWM has one channel to control the brightness of the display. When the (high_width / period) is closer to 1, the screen is brighter; otherwise, it is darker. Signed-off-by: YH Huang --- drivers/pwm/Kconfig

[PATCH v6 0/3] Add MediaTek display PWM driver

2015-07-20 Thread YH Huang
clocks of MT8173 Change in v6: 1. Enable clocks in the pwm_enable function 2. Remove suspend/resume code since pwm-backlight driver has done the same things 3. Revise some code to make it easier to read YH Huang (3): dt-bindings: pwm: add MediaTek display PWM bindings pwm: add MediaTek display

Re: [PATCH v4 1/3] dt-bindings: pwm: add MediaTek display PWM bindings

2015-07-08 Thread YH Huang
On Wed, 2015-07-08 at 20:11 +0800, Daniel Kurtz wrote: > On Mon, Jul 6, 2015 at 9:29 PM, YH Huang wrote: > > Document the device-tree binding of MediatTek display PWM. > > The PWM has one channel to control the backlight brightness for display. > > It supports MT8173 and M

Re: [PATCH v4 1/3] dt-bindings: pwm: add MediaTek display PWM bindings

2015-07-09 Thread YH Huang
On Thu, 2015-07-09 at 12:47 +0800, Daniel Kurtz wrote: > On Thu, Jul 9, 2015 at 10:45 AM, YH Huang wrote: > > > > On Wed, 2015-07-08 at 20:11 +0800, Daniel Kurtz wrote: > > > On Mon, Jul 6, 2015 at 9:29 PM, YH Huang wrote: > > > > Document the device-t

Re: [PATCH v5 2/3] pwm: add MediaTek display PWM driver support

2015-07-16 Thread YH Huang
On Thu, 2015-07-16 at 23:21 +0800, Daniel Kurtz wrote: > On Thu, Jul 16, 2015 at 3:17 PM, YH Huang wrote: > > On Thu, 2015-07-16 at 14:54 +0800, Daniel Kurtz wrote: > >> On Thu, Jul 16, 2015 at 1:38 PM, YH Huang wrote: > >> > On Wed, 2015-07-15 at 23:59 +0800,

Re: [PATCH v5 2/3] pwm: add MediaTek display PWM driver support

2015-07-17 Thread YH Huang
On Fri, 2015-07-17 at 01:18 +0800, Daniel Kurtz wrote: > On Fri, Jul 17, 2015 at 12:44 AM, YH Huang wrote: > > On Thu, 2015-07-16 at 23:21 +0800, Daniel Kurtz wrote: > >> On Thu, Jul 16, 2015 at 3:17 PM, YH Huang wrote: > >> > On Thu, 2015-07-16 at 14:54 +0800, Dani

Re: [PATCH v5 2/3] pwm: add MediaTek display PWM driver support

2015-07-17 Thread YH Huang
On Fri, 2015-07-17 at 14:59 +0800, Daniel Kurtz wrote: > On Fri, Jul 17, 2015 at 2:35 PM, YH Huang wrote: > > > > On Fri, 2015-07-17 at 01:18 +0800, Daniel Kurtz wrote: > > > On Fri, Jul 17, 2015 at 12:44 AM, YH Huang wrote: > > > > On Thu, 2015-07-1

Re: [PATCH v5 1/3] dt-bindings: pwm: add MediaTek display PWM bindings

2015-07-15 Thread YH Huang
On Mon, 2015-07-13 at 18:20 +0800, Daniel Kurtz wrote: > On Mon, Jul 13, 2015 at 5:04 PM, YH Huang wrote: > > Document the device-tree binding of MediatTek display PWM. > > The PWM has one channel to control the backlight brightness for display. > > It supports MT8173 and M

Re: [PATCH v5 2/3] pwm: add MediaTek display PWM driver support

2015-07-15 Thread YH Huang
On Mon, 2015-07-13 at 18:19 +0800, Daniel Kurtz wrote: > On Mon, Jul 13, 2015 at 5:04 PM, YH Huang wrote: > > Add display PWM driver support to modify backlight for MT8173 and MT6595. > > The PWM has one channel to control the brightness of the display. > > When the

Re: [PATCH v5 2/3] pwm: add MediaTek display PWM driver support

2015-07-15 Thread YH Huang
On Wed, 2015-07-15 at 23:59 +0800, YH Huang wrote: > On Mon, 2015-07-13 at 18:19 +0800, Daniel Kurtz wrote: > > On Mon, Jul 13, 2015 at 5:04 PM, YH Huang wrote: > > > Add display PWM driver support to modify backlight for MT8173 and MT6595. > > > The PWM has one channe

Re: [PATCH v5 2/3] pwm: add MediaTek display PWM driver support

2015-07-16 Thread YH Huang
On Thu, 2015-07-16 at 14:54 +0800, Daniel Kurtz wrote: > On Thu, Jul 16, 2015 at 1:38 PM, YH Huang wrote: > > On Wed, 2015-07-15 at 23:59 +0800, YH Huang wrote: > >> On Mon, 2015-07-13 at 18:19 +0800, Daniel Kurtz wrote: > >> > On Mon, Jul 13, 2015 at 5:04 PM,

Re: [PATCH v6 0/3] Add MediaTek display PWM driver

2015-08-03 Thread YH Huang
On Fri, 2015-07-24 at 17:10 +0800, YH Huang wrote: > On Fri, 2015-07-24 at 10:42 +0200, Matthias Brugger wrote: > > On Monday, July 20, 2015 04:17:14 PM YH Huang wrote: > > > This patch series add the use of display PWM driver, documentation > > > and device tree fo

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-21 Thread YH Huang
On Mon, 2015-05-18 at 11:42 +0800, Daniel Kurtz wrote: > On Mon, May 11, 2015 at 5:26 PM, YH Huang wrote: > > Add display PWM driver support to modify backlight for MT8173/MT6595. > > > > Signed-off-by: YH Huang > > --- > > drivers/pwm/Kconfig |

[PATCH v2 1/2] dt-bindings: pwm: add MediaTek display PWM bindings

2015-05-21 Thread YH Huang
Document the device-tree binding of MediatTek display PWM. Signed-off-by: YH Huang --- .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 25 ++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt diff --git

[PATCH v2 2/2] pwm: add MediaTek display PWM driver support

2015-05-21 Thread YH Huang
Add display PWM driver support to modify backlight for MT8173. Signed-off-by: YH Huang --- drivers/pwm/Kconfig| 10 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-mtk-disp.c | 228 + 3 files changed, 239 insertions(+) create mode

[PATCH v2 0/2] Add MediaTek display PWM driver

2015-05-21 Thread YH Huang
YH Huang (2): dt-bindings: pwm: add MediaTek display PWM bindings pwm: add MediaTek display PWM driver support .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 25 +++ drivers/pwm/Kconfig| 10 + drivers/pwm/Makefile | 1

Re: [PATCH v2 0/2] Add MediaTek display PWM driver

2015-06-05 Thread YH Huang
On Mon, 2015-05-25 at 10:14 +0800, Yingjoe Chen wrote: > On Thu, 2015-05-21 at 21:29 +0800, YH Huang wrote: This patch series add the use of display PWM driver and documentation for Mediatek SoCs. The driver is used to support the backlight of the panel. This is based on v4.1-rc1. >

Re: [PATCH v2 0/2] Add MediaTek display PWM driver

2015-06-05 Thread YH Huang
On Fri, 2015-06-05 at 10:39 +0200, Matthias Brugger wrote: > Hi YH, > > 2015-06-05 8:15 GMT+02:00 YH Huang : > > On Mon, 2015-05-25 at 10:14 +0800, Yingjoe Chen wrote: > >> On Thu, 2015-05-21 at 21:29 +0800, YH Huang wrote: > > > > This patch seri

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-14 Thread YH Huang
On Tue, 2015-05-12 at 14:37 +0200, Matthias Brugger wrote: > Hi YH, > > 2015-05-11 11:26 GMT+02:00 YH Huang : > > Add display PWM driver support to modify backlight for MT8173/MT6595. > > > > Signed-off-by: YH Huang > > --- > > drivers/pwm/Kconfig

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-14 Thread YH Huang
On Tue, 2015-05-12 at 14:44 +0200, Matthias Brugger wrote: > 2015-05-12 14:37 GMT+02:00 Matthias Brugger : > > Hi YH, > > > > 2015-05-11 11:26 GMT+02:00 YH Huang : > >> Add display PWM driver support to modify backlight for MT8173/MT6595. > >> > >>

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-14 Thread YH Huang
On Tue, 2015-05-12 at 15:00 +0200, Sascha Hauer wrote: > On Mon, May 11, 2015 at 05:26:22PM +0800, YH Huang wrote: > > + > > +static int mtk_disp_pwm_probe(struct platform_device *pdev) > > +{ > > + struct mtk_disp_pwm_chip *pwm; > > The struct mtk_disp_pwm_c

  1   2   >