check_dis(c|k)_change(|d): duplicated code

2001-01-27 Thread Yann Droneaud
' and in 'fs/devfs/base.c' there's a function 'check_disc_changed' They done exactly the same job. I think that one of these must be rewritted to call the other and it's not to me to tell you which one :-). -- Yann Droneaud [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubs

fs block/devfs check disc change

2001-01-31 Thread Yann DRONEAUD
and it's not to me to tell you which one :-). -- Yann Droneaud [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

strange bug, alloca suspected

2001-02-13 Thread Yann Droneaud
. Submitter-Id: net Originator:Yann Droneaud [EMAIL PROTECTED] Organization: no others than mine Confidential: no Synopsis: undetermined Severity: non-critical Priority: low Category: libc Class: sw-bug Release: libc-2.1.3 Environment: Host type: i586-pc

[PATCH 1/2] kvm: use anon_inode_getfd() with O_CLOEXEC flag

2013-08-24 Thread Yann Droneaud
to choose, without race, if the file descriptor is going to be inherited across exec(). This patch set O_CLOEXEC flag on all file descriptors created with anon_inode_getfd() to not leak file descriptors across exec(). Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http://lkml.kernel.org/r/cover

[PATCH 0/2] kvm: use anon_inode_getfd() with O_CLOEXEC flag

2013-08-24 Thread Yann Droneaud
/20130822171744.1297.13711.st...@bling.home Yann Droneaud (2): kvm: use anon_inode_getfd() with O_CLOEXEC flag ppc: kvm: use anon_inode_getfd() with O_CLOEXEC flag arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- arch/powerpc/kvm/book3s_64_vio.c| 2 +- arch/powerpc/kvm/book3s_hv.c| 2 +- virt/kvm

[PATCH 2/2] ppc: kvm: use anon_inode_getfd() with O_CLOEXEC flag

2013-08-24 Thread Yann Droneaud
to choose, without race, if the file descriptor is going to be inherited across exec(). This patch set O_CLOEXEC flag on all file descriptors created with anon_inode_getfd() to not leak file descriptors across exec(). Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http://lkml.kernel.org/r/cover

Re: [PATCH 2/2] ppc: kvm: use anon_inode_getfd() with O_CLOEXEC flag

2013-08-26 Thread Yann Droneaud
Le 26.08.2013 09:39, Paolo Bonzini a écrit : Il 25/08/2013 17:04, Alexander Graf ha scritto: On 24.08.2013, at 21:14, Yann Droneaud wrote: This patch set O_CLOEXEC flag on all file descriptors created with anon_inode_getfd() to not leak file descriptors across exec(). Signed-off-by: Yann

[PATCH] USB: serial: fix stringify operator in usb-serial-simple

2013-08-18 Thread Yann Droneaud
From: Yann Droneaud ydrone...@opteya.com usb-serial-simple uses an unknown stringify macro that make all drivers being named stringify(vendor). This can be a problem when two drivers have the same (wrong) name: kernel: usbcore: registered new interface driver usb_serial_simple kernel

Re: [PATCH] USB: serial: fix stringify operator in usb-serial-simple

2013-08-18 Thread Yann Droneaud
Le 18.08.2013 21:40, Greg Kroah-Hartman a écrit : On Sun, Aug 18, 2013 at 09:29:00PM +0200, Yann Droneaud wrote: Ugh, sorry about that, I thought there used to be a stringify() macro that used to do this. Nice patch, I'll queue it up. That's __stringify() which is defined in linux

[PATCH v2 01/10] ia64: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-08-15 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v2 02/10] ppc/cell: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-08-15 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v2 05/10] vfio: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-08-15 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v2 04/10] android/sync: use get_unused_fd_flags(O_CLOEXEC) instead of get_unused_fd()

2013-08-15 Thread Yann Droneaud
calls to get_unused_fd() with call to get_unused_fd_flags(O_CLOEXEC) following advice from Erik Gilling. Signed-off-by: Yann Droneaud ydrone...@opteya.com Cc: Erik Gilling konk...@android.com Cc: Colin Cross ccr...@google.com Link: http://lkml.kernel.org/r/cacsp8sjxgmk2_kx_

[PATCH v2 07/10] file: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-08-15 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v2 08/10] fanotify: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-08-15 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v2 03/10] android/sw_sync: use get_unused_fd_flags(O_CLOEXEC) instead of get_unused_fd()

2013-08-15 Thread Yann Droneaud
calls to get_unused_fd() with call to get_unused_fd_flags(O_CLOEXEC) following advice from Erik Gilling. Signed-off-by: Yann Droneaud ydrone...@opteya.com Cc: Erik Gilling konk...@android.com Cc: Colin Cross ccr...@google.com Link: http://lkml.kernel.org/r/CACSP8SjZcpcpEtQHzcGYhf-MP7QGo0XpN7

[PATCH v2 06/10] binfmt_misc: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-08-15 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v2 10/10] file: remove get_unused_fd()

2013-08-15 Thread Yann Droneaud
to be inherited across exec(). This patch removes get_unused_fd() so that newer kernel code use anon_inode_getfd() or get_unused_fd_flags() with flags provided by userspace. If flags cannot be given by userspace, O_CLOEXEC must be the default flag. Signed-off-by: Yann Droneaud ydrone...@opteya.com

[PATCH v2 00/10] Getting rid of get_unused_fd_flags()

2013-08-15 Thread Yann Droneaud
maintainer. - sctp: use get_unused_fd_flags(0) instead of get_unused_fd() DROPPED: applied asis by subsystem maintainer. Yann Droneaud (10): ia64: use get_unused_fd_flags(0) instead of get_unused_fd() ppc/cell: use get_unused_fd_flags(0) instead of get_unused_fd() android/sw_sync: use

[PATCH v2 09/10] events: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-08-15 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

Re: [PATCH 10/13] xfs: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-07-10 Thread Yann Droneaud
Hi, Le 09.07.2013 22:53, Ben Myers a écrit : On Mon, Jul 08, 2013 at 05:41:33PM -0500, Ben Myers wrote: On Tue, Jul 02, 2013 at 06:39:34PM +0200, Yann Droneaud wrote: diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index 5e99968..dc5b659 100644 --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs

Re: [PATCH v3 8/8] industrialio: use anon_inode_getfd() with O_CLOEXEC flag

2013-09-15 Thread Yann Droneaud
Hi, Le dimanche 15 septembre 2013 à 17:26 +0100, Jonathan Cameron a écrit : On 09/06/13 11:39, Yann Droneaud wrote: [...] http://lkml.kernel.org/r/cover.1377372576.git.ydrone...@opteya.com Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http://lkml.kernel.org/r/cover

[PATCH] net: use a proper error path in socketpair()

2013-12-02 Thread Yann Droneaud
that errors are catched earlier and being easier to handle. Cc: David S. Miller da...@davemloft.net Cc: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Yann Droneaud ydrone...@opteya.com --- net/socket.c | 41 ++--- 1 file changed, 22 insertions(+), 19 deletions

[PATCH v2] net: handle error more gracefully in socketpair()

2013-12-02 Thread Yann Droneaud
v...@zeniv.linux.org.uk Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http://marc.info/?i=1385977019-12282-1-git-send-email-ydrone...@opteya.com --- Hi, Please discard my previous patch [PATCH] net: handle error more gracefully in socketpair() [1] as I haven't double checked

Re: [PATCH v2] net: handle error more gracefully in socketpair()

2013-12-05 Thread Yann Droneaud
Hi, Le jeudi 05 décembre 2013 à 16:23 -0500, David Miller a écrit : From: Yann Droneaud ydrone...@opteya.com Date: Mon, 2 Dec 2013 11:12:26 +0100 socketpair() error paths can be simplified to not call heavy-weight sys_close(). This patch makes socketpair() use of error paths which

Re: [PATCH v2] net: handle error more gracefully in socketpair()

2013-12-06 Thread Yann Droneaud
Hi, Le jeudi 05 décembre 2013 à 19:43 -0500, David Miller a écrit : From: Yann Droneaud ydrone...@opteya.com Date: Fri, 06 Dec 2013 00:15:31 +0100 AFAIK, using sys_close() seems to be the exception, and writing the file descriptor before installing it is the more or less the norm

[PATCHv4] perf tools: enable close-on-exec flag on perf file descriptor

2014-03-11 Thread Yann Droneaud
a...@linux.intel.com Cc: Ingo Molnar mi...@kernel.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- tools/perf/Makefile.perf | 1 + tools/perf/bench/mem-memcpy.c | 4 ++- tools/perf/bench/mem-memset.c | 4 ++- tools/perf/builtin-sched.c| 4

[PATCHv6 0/6] Getting rid of get_unused_fd() / enable close-on-exec

2014-03-11 Thread Yann Droneaud
...@opteya.com [PATCHSETv1] http://lkml.kernel.org/r/cover.1372777600.git.ydrone...@opteya.com Yann Droneaud (6): ia64: use get_unused_fd_flags(0) instead of get_unused_fd() ppc/cell: use get_unused_fd_flags(0) instead of get_unused_fd() binfmt_misc: use get_unused_fd_flags(0) instead

[PATCHv6 1/6] ia64: use get_unused_fd_flags(0) instead of get_unused_fd()

2014-03-11 Thread Yann Droneaud
...@opteya.com Cc: Al Viro v...@zeniv.linux.org.uk Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- arch/ia64/kernel/perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/ia64/kernel/perfmon.c b/arch/ia64/kernel/perfmon.c index

[PATCHv6 3/6] binfmt_misc: use get_unused_fd_flags(0) instead of get_unused_fd()

2014-03-11 Thread Yann Droneaud
...@opteya.com Cc: Al Viro v...@zeniv.linux.org.uk Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- fs/binfmt_misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c index 1c740e152f38..052f6dc8e549

[PATCHv6 4/6] file: use get_unused_fd_flags(0) instead of get_unused_fd()

2014-03-11 Thread Yann Droneaud
Signed-off-by: Yann Droneaud ydrone...@opteya.com --- fs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/file.c b/fs/file.c index 18f7d27855c4..d8ace9a8a821 100644 --- a/fs/file.c +++ b/fs/file.c @@ -857,7 +857,7 @@ SYSCALL_DEFINE1(dup, unsigned int, fildes) struct

[PATCHv6 5/6] fanotify: enable close-on-exec on events' fd when requested in fanotify_init()

2014-03-11 Thread Yann Droneaud
Viro v...@zeniv.linux.org.uk Cc: Andrew Morton a...@linux-foundation.org Cc: sta...@vger.kernel.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- fs/notify/fanotify/fanotify_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/notify/fanotify/fanotify_user.c b/fs

[PATCHv6 6/6] file: remove macro get_unused_fd()

2014-03-11 Thread Yann Droneaud
-foundation.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- include/linux/file.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/file.h b/include/linux/file.h index cbacf4faf447..866600259c07 100644 --- a/include/linux/file.h +++ b/include/linux/file.h @@ -63,7 +63,6 @@ extern void

[PATCHv6 2/6] ppc/cell: use get_unused_fd_flags(0) instead of get_unused_fd()

2014-03-11 Thread Yann Droneaud
...@opteya.com Cc: Al Viro v...@zeniv.linux.org.uk Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- arch/powerpc/platforms/cell/spufs/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/cell/spufs/inode.c

[PATCH 1/2] perf tools: remove unused test-volatile-register-var.c

2014-01-11 Thread Yann Droneaud
...@gmail.com Cc: Jiri Olsa jo...@redhat.com Cc: Namhyung Kim namhy...@kernel.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- tools/perf/config/feature-checks/test-volatile-register-var.c | 6 -- 1 file changed, 6 deletions(-) delete mode 100644 tools/perf/config/feature-checks/test

[PATCH 2/2] perf tools: add .gitignore for files generated for feature check

2014-01-11 Thread Yann Droneaud
As part of system features auto-detection, some dependency files are generated and some programs are built. These files should not be considered by git, so this patch adds a dedicated .gitignore in tools/perf/config/ sub-directory to ignore the files. Signed-off-by: Yann Droneaud ydrone

[PATCH 0/2] perf: little build clean up

2014-01-11 Thread Yann Droneaud
Hi, Please find 2 little patches to remove an unused file and to ignore files generated as part of the feature auto-detection. Regards. Yann Droneaud (2): perf tools: remove unused test-volatile-register-var.c perf tools: add .gitignore for files generated for feature check tools/perf

[PATCHv1] perf tools: enable close-on-exec flag on perf file descriptor

2014-01-11 Thread Yann Droneaud
/3437111/ Cc: Peter Zijlstra pet...@infradead.org Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Jiri Olsa jo...@redhat.com Cc: Andi Kleen a...@linux.intel.com Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http://lkml.kernel.org/r/cover.1388952061.git.ydrone...@opteya.com --- tools

Re: [PATCH 02/13] ppc/cell: use get_unused_fd_flags(0) instead of get_unused_fd()

2014-01-13 Thread Yann Droneaud
Hi Benjamin, Le lundi 13 janvier 2014 à 10:06 +1100, Benjamin Herrenschmidt a écrit : On Tue, 2013-07-02 at 18:39 +0200, Yann Droneaud wrote: Macro get_unused_fd() is used to allocate a file descriptor with default flags. Those default flags (0) can be unsafe: O_CLOEXEC must be used

Re: [PATCH 2/2] perf tools: add .gitignore for files generated for feature check

2014-01-13 Thread Yann Droneaud
Hi, Le samedi 11 janvier 2014 à 18:48 +0100, Yann Droneaud a écrit : As part of system features auto-detection, some dependency files are generated and some programs are built. These files should not be considered by git, so this patch adds a dedicated .gitignore in tools/perf/config/ sub

[PATCHv2] perf tools: enable close-on-exec flag on perf file descriptor

2014-01-13 Thread Yann Droneaud
: Andi Kleen a...@linux.intel.com Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http://lkml.kernel.org/r/cover.1388952061.git.ydrone...@opteya.com --- tools/perf/Makefile.perf | 1 + tools/perf/bench/mem-memcpy.c | 4 ++- tools/perf/bench/mem-memset.c | 4

[PATCHv1] driver core/platform: don't leak memory allocated for dma_mask

2014-01-13 Thread Yann Droneaud
to a bare minimal [1] http://lkml.kernel.org/r/1386886207-2735-1-git-send-email-ydrone...@opteya.com Signed-off-by: Yann Droneaud ydrone...@opteya.com --- drivers/base/platform.c | 82 + 1 file changed, 62 insertions(+), 20 deletions(-) diff --git

[PATCHv2] driver core/platform: don't leak memory allocated for dma_mask

2014-01-13 Thread Yann Droneaud
...@linuxfoundation.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- Hi Greg, Why haven't you cc:ed the author of that comment? He would be best to evaluate if this patch is good enough or not. I must admit I was a bit lazy: I've tried ./script/get_maintainer.pl --git / --git-blame

Re: [PATCHv2] driver core/platform: don't leak memory allocated for dma_mask

2014-01-14 Thread Yann Droneaud
Hi Uwe, Le mardi 14 janvier 2014 à 09:19 +0100, Uwe Kleine-König a écrit : On Tue, Jan 14, 2014 at 08:18:29AM +0100, Yann Droneaud wrote: Since commit 01dcc60a7cb8, platform_device_register_full() is available to allocate and register a platform device. If a dma_mask is provided as part

[PATCH v4 0/7] Getting rid of get_unused_fd()

2013-10-30 Thread Yann Droneaud
] http://lkml.kernel.org/r/cover.1376327678.git.ydrone...@opteya.com [PATCHSETv1] http://lkml.kernel.org/r/cover.1372777600.git.ydrone...@opteya.com Yann Droneaud (7): ia64: use get_unused_fd_flags(0) instead of get_unused_fd() ppc/cell: use get_unused_fd_flags(0) instead of get_unused_fd

[PATCH v4 2/7] ppc/cell: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-10-30 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v4 1/7] ia64: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-10-30 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v4 4/7] file: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-10-30 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v4 3/7] binfmt_misc: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-10-30 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v4 5/7] fanotify: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-10-30 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v4 7/7] file: remove get_unused_fd() macro

2013-10-30 Thread Yann Droneaud
to be inherited across exec(), by calling fcntl() when needed. This patch removes get_unused_fd() so that newer kernel code use anon_inode_getfd() or get_unused_fd_flags() with flags provided by userspace. If flags cannot be given by userspace, O_CLOEXEC must be used by default. Signed-off-by: Yann

[PATCH v4 6/7] events: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-10-30 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

Re: [PATCH v4 6/7] events: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-10-30 Thread Yann Droneaud
Hi, Le 30.10.2013 21:20, Peter Zijlstra a écrit : On Wed, Oct 30, 2013 at 08:47:46PM +0100, Yann Droneaud wrote: This patch replaces calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should

[PATCH] events: add a flag to perf_event_open() to set O_CLOEXEC

2013-10-30 Thread Yann Droneaud
://lkml.kernel.org/r/94b641a81a06ba4943cf77e80bc27...@meuh.org Link: http://lkml.kernel.org/r/cover.1383121137.git.ydrone...@opteya.com Signed-off-by: Yann Droneaud ydrone...@opteya.com --- Hi Peter, This patch should replaces [PATCH v4 6/7] events: use get_unused_fd_flags(0) instead of get_unused_fd

Re: [PATCH v4 6/7] events: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-10-30 Thread Yann Droneaud
Le mercredi 30 octobre 2013 à 22:18 +0100, Yann Droneaud a écrit : Hi, Le 30.10.2013 21:20, Peter Zijlstra a écrit : On Wed, Oct 30, 2013 at 08:47:46PM +0100, Yann Droneaud wrote: This patch replaces calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve

Re: [PATCH] events: add a flag to perf_event_open() to set O_CLOEXEC

2013-11-04 Thread Yann Droneaud
Hi, Le jeudi 31 octobre 2013 à 19:12 +0100, Peter Zijlstra a écrit : On Wed, Oct 30, 2013 at 10:35:50PM +0100, Yann Droneaud wrote: This patch adds PERF_FLAG_FD_CLOEXEC flag for perf_event_open() syscall. perf_event_open() creates a new file descriptor, but unlike open() syscall

[PATCH v3 0/8] Getting rid of get_unused_fd() / use O_CLOEXEC

2013-09-06 Thread Yann Droneaud
/51d312e8.6090...@gmail.com http://lkml.kernel.org/r/20130702.161428.1703028286206350504.da...@davemloft.net [XFS] http://lkml.kernel.org/r/20130709205321.gv20...@sgi.com [PATCHSETv2] http://lkml.kernel.org/r/cover.1376327678.git.ydrone...@opteya.com Yann Droneaud (8): ia64: use

[PATCH v3 1/8] ia64: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-09-06 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v3 7/8] file: remove get_unused_fd()

2013-09-06 Thread Yann Droneaud
to be inherited across exec(). This patch removes get_unused_fd() so that newer kernel code use anon_inode_getfd() or get_unused_fd_flags() with flags provided by userspace. If flags cannot be given by userspace, O_CLOEXEC must be the default flag. Signed-off-by: Yann Droneaud ydrone...@opteya.com

[PATCH v3 2/8] ppc/cell: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-09-06 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v3 6/8] events: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-09-06 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v3 5/8] fanotify: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-09-06 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v3 4/8] file: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-09-06 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH v3 8/8] industrialio: use anon_inode_getfd() with O_CLOEXEC flag

2013-09-06 Thread Yann Droneaud
/53603.html - [1] kvm: use anon_inode_getfd() with O_CLOEXEC flag http://lkml.kernel.org/r/cover.1377372576.git.ydrone...@opteya.com Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http://lkml.kernel.org/r/cover.1378460926.git.ydrone...@opteya.com --- drivers/iio/industrialio-event.c | 2

[PATCH v3 3/8] binfmt_misc: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-09-06 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH 07/13] binfmt_misc: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-07-02 Thread Yann Droneaud
calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud ydrone...@opteya.com --- fs

Re: [PATCH] MAINTAINERS: x...@oss.sgi.com is a list

2013-07-03 Thread Yann Droneaud
Hi, Le 03.07.2013 08:40, Dave Chinner a écrit : On Tue, Jul 02, 2013 at 05:00:47PM +0200, Yann Droneaud wrote: This patch changes type of x...@oss.sgi.com The output of ./scripts/get_maintainer.pl is modified to report x...@oss.sgi.com as a list: What's the problem with that? All XFS

Re: [PATCH] MAINTAINERS: x...@oss.sgi.com is a list

2013-07-03 Thread Yann Droneaud
Le 03.07.2013 11:24, Dave Chinner a écrit : On Wed, Jul 03, 2013 at 10:14:41AM +0200, Yann Droneaud wrote: Le 03.07.2013 08:40, Dave Chinner a écrit : On Tue, Jul 02, 2013 at 05:00:47PM +0200, Yann Droneaud wrote: This patch changes type of x...@oss.sgi.com The output of ./scripts

Re: [PATCH] MAINTAINERS: x...@oss.sgi.com is a list

2013-07-03 Thread Yann Droneaud
Le 03.07.2013 11:50, Dave Chinner a écrit : On Wed, Jul 03, 2013 at 11:36:39AM +0200, Yann Droneaud wrote: Le 03.07.2013 11:24, Dave Chinner a écrit : On Wed, Jul 03, 2013 at 10:14:41AM +0200, Yann Droneaud wrote: Le 03.07.2013 08:40, Dave Chinner a écrit : On Tue, Jul 02, 2013 at 05:00:47PM

Re: [PATCH 03/13] infiniband: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-07-08 Thread Yann Droneaud
a challenge for thoses API. ] So those file descriptors can safely be opened with O_CLOEXEC without disturbing users of InfiniBand verbs /RDMA 8-- Regards. -- Yann Droneaud OPTEYA -- To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH] scripts/tags.sh: ignore symlink'ed source files

2014-05-21 Thread Yann Droneaud
...@tuxdriver.com Cc: Gerhard Sittig g...@denx.de Cc: Konstantin Khlebnikov koc...@gmail.com Signed-off-by: Yann Droneaud ydrone...@opteya.com --- scripts/tags.sh | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index 1c50de820289

[PATCH] driver core/platform: remove unused implicit padding in platform_object

2014-05-30 Thread Yann Droneaud
Kleine-König u.kleine-koe...@pengutronix.de Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- drivers/base/platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [PATCH] driver core/platform: remove unused implicit padding in platform_object

2014-05-31 Thread Yann Droneaud
. Is it really necessary to resend the patch ? Regards. -- Yann Droneaud OPTEYA -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH] driver core/platform: remove unused implicit padding in platform_object

2014-06-01 Thread Yann Droneaud
Hi Dan, Le samedi 31 mai 2014 à 15:05 +0300, Dan Carpenter a écrit : On Sat, May 31, 2014 at 10:01:39AM +0200, Yann Droneaud wrote: Le vendredi 30 mai 2014 à 23:10 +0300, Dan Carpenter a écrit : This changelog doesn't match the patch. Hum, let me guess I've failed to set

[PATCHv7 1/6] ia64: use get_unused_fd_flags(0) instead of get_unused_fd()

2014-06-01 Thread Yann Droneaud
...@opteya.com Cc: Al Viro v...@zeniv.linux.org.uk Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- arch/ia64/kernel/perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/ia64/kernel/perfmon.c b/arch/ia64/kernel/perfmon.c index

[PATCHv7 0/6] Getting rid of get_unused_fd() / enable close-on-exec

2014-06-01 Thread Yann Droneaud
...@opteya.com [PATCHSETv2] http://lkml.kernel.org/r/cover.1376327678.git.ydrone...@opteya.com [PATCHSETv1] http://lkml.kernel.org/r/cover.1372777600.git.ydrone...@opteya.com Yann Droneaud (6): ia64: use get_unused_fd_flags(0) instead of get_unused_fd() ppc/cell: use get_unused_fd_flags(0

[PATCHv7 4/6] file: use get_unused_fd_flags(0) instead of get_unused_fd()

2014-06-01 Thread Yann Droneaud
Signed-off-by: Yann Droneaud ydrone...@opteya.com --- fs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/file.c b/fs/file.c index 66923fe3176e..4186f81cd9f1 100644 --- a/fs/file.c +++ b/fs/file.c @@ -868,7 +868,7 @@ SYSCALL_DEFINE1(dup, unsigned int, fildes) struct

[PATCHv7 5/6] fanotify: enable close-on-exec on events' fd when requested in fanotify_init()

2014-06-01 Thread Yann Droneaud
: Eric Paris epa...@redhat.com Cc: Al Viro v...@zeniv.linux.org.uk Cc: Andrew Morton a...@linux-foundation.org Cc: sta...@vger.kernel.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- fs/notify/fanotify/fanotify_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs

[PATCHv7 2/6] ppc/cell: use get_unused_fd_flags(0) instead of get_unused_fd()

2014-06-01 Thread Yann Droneaud
...@opteya.com Cc: Al Viro v...@zeniv.linux.org.uk Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- arch/powerpc/platforms/cell/spufs/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/cell/spufs/inode.c

[PATCHv7 3/6] binfmt_misc: use get_unused_fd_flags(0) instead of get_unused_fd()

2014-06-01 Thread Yann Droneaud
...@opteya.com Cc: Al Viro v...@zeniv.linux.org.uk Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- fs/binfmt_misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c index b60500300dd7..3c9fcc08aec9

[PATCHv7 6/6] file: remove macro get_unused_fd()

2014-06-01 Thread Yann Droneaud
-foundation.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- include/linux/file.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/file.h b/include/linux/file.h index 4d69123377a2..f87d30882a24 100644 --- a/include/linux/file.h +++ b/include/linux/file.h @@ -66,7 +66,6 @@ extern void

Re: [PATCH 1/3] driver core/platform: don't leak memory allocated for dma_mask

2014-05-26 Thread Yann Droneaud
, unconditionally set dev.dma_mask pointer is probably going to break, so this part (2) need some rework, I'm gonna try to do. Thanks for reminding me about this patch. Regards. -- Yann Droneaud OPTEYA -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

[PATCHv5] perf tools: enable close-on-exec flag on perf file descriptor

2014-06-02 Thread Yann Droneaud
Molnar mi...@kernel.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- Hi, Quite the same patch from v4. I'm interested in some feedback so that I could improve the patch if needed. Regards. Changes from v4 [1]: - rebase on next-20140530 and update commit message. Changes from v3 [2

Re: [PATCHv5] perf tools: enable close-on-exec flag on perf file descriptor

2014-06-03 Thread Yann Droneaud
Le lundi 02 juin 2014 à 21:23 +0200, Jiri Olsa a écrit : On Mon, Jun 02, 2014 at 12:56:34PM +0200, Yann Droneaud wrote: SNIP Hi, Quite the same patch from v4. I'm interested in some feedback so that I could improve the patch if needed. Regards. Changes from v4 [1

Re: [PATCH 02/13] ppc/cell: use get_unused_fd_flags(0) instead of get_unused_fd()

2014-01-20 Thread Yann Droneaud
Hi, Le lundi 13 janvier 2014 à 10:30 +0100, Yann Droneaud a écrit : Le lundi 13 janvier 2014 à 10:06 +1100, Benjamin Herrenschmidt a écrit : On Tue, 2013-07-02 at 18:39 +0200, Yann Droneaud wrote: Macro get_unused_fd() is used to allocate a file descriptor with default flags. Those

Re: [PATCHv5 5/7] fanotify: enable close-on-exec on events' fd when requested in fanotify_init()

2014-01-20 Thread Yann Droneaud
dimanche 05 janvier 2014 à 21:36 +0100, Yann Droneaud a écrit : According to commit 80af258867648, file descriptor created as part of file access notification events inherit flags from the event_f_flags argument passed to syscall fanotify_init(2). So while it is legal for userspace to call

[PATCH] 6lowpan: add a license to 6lowpan_iphc module

2014-01-22 Thread Yann Droneaud
-by: Yann Droneaud ydrone...@opteya.com --- net/ieee802154/6lowpan_iphc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ieee802154/6lowpan_iphc.c b/net/ieee802154/6lowpan_iphc.c index e14fe8b2c054..860aa2d445ba 100644 --- a/net/ieee802154/6lowpan_iphc.c +++ b/net/ieee802154

[PATCH] perf tools: enable close-on-exec flag on perf file descriptor

2014-01-06 Thread Yann Droneaud
work on older kernel which do not support flag PERF_FLAG_FD_CLOEXEC. [1] http://lkml.kernel.org/r/8c03f54e1598b1727c19706f3af03f98685d9fe6.1388952061.git.ydrone...@opteya.com [2] https://patchwork.kernel.org/patch/3434971/ Cc: Peter Zijlstra pet...@infradead.org Signed-off-by: Yann Droneaud ydrone

Re: [PATCH] perf tools: enable close-on-exec flag on perf file descriptor

2014-01-06 Thread Yann Droneaud
Hi, Le lundi 06 janvier 2014 à 15:22 +0100, Jiri Olsa a écrit : On Mon, Jan 06, 2014 at 11:51:25AM +0100, Yann Droneaud wrote: In a previous patch [1][2], flag PERF_FLAG_FD_CLOEXEC was added to perf_event_open(2) syscall to allows userspace to enable close-on-exec behavor atomically when

Re: [PATCH] perf tools: enable close-on-exec flag on perf file descriptor

2014-01-06 Thread Yann Droneaud
. -- Yann Droneaud OPTEYA -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] perf tools: enable close-on-exec flag on perf file descriptor

2014-01-06 Thread Yann Droneaud
to perf_event_open(). Regards. [1] http://lkml.kernel.org/r/1389022310.13828.9.camel@localhost.localdomain -- Yann Droneaud OPTEYA -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCHv3] driver core/platform: don't leak memory allocated for dma_mask

2014-01-26 Thread Yann Droneaud
-send-email-ydrone...@opteya.com Cc: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- Hi Greg and Uwe, I've tried to add dma_mask to platform_object

[PATCH 0/2] Revamp randomize_range()

2014-01-26 Thread Yann Droneaud
not added the maintainers of the various arch modified by the patches, wanted first to have your opinion about the changes. Regards. Yann Droneaud (2): random: remove unused len argument in randomize_range() function random: don't return 0 in randomize_range() arch/arm/kernel/process.c

[PATCH 2/2] random: don't return 0 in randomize_range()

2014-01-26 Thread Yann Droneaud
.git.ydrone...@opteya.com Cc: Theodore Ts'o ty...@mit.edu Signed-off-by: Yann Droneaud ydrone...@opteya.com --- arch/arm/kernel/process.c| 2 +- arch/tile/mm/mmap.c | 2 +- arch/x86/kernel/process.c| 2 +- arch/x86/kernel/sys_x86_64.c | 5 + drivers/char/random.c| 4 +++- 5

[PATCHv3] perf tools: enable close-on-exec flag on perf file descriptor

2014-01-26 Thread Yann Droneaud
...@infradead.org Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Jiri Olsa jo...@redhat.com Cc: Andi Kleen a...@linux.intel.com Cc: Ingo Molnar mi...@kernel.org Signed-off-by: Yann Droneaud ydrone...@opteya.com --- tools/perf/Makefile.perf | 1 + tools/perf/bench/mem-memcpy.c | 4

[PATCH 1/2] random: remove unused len argument in randomize_range() function

2014-01-26 Thread Yann Droneaud
.git.ydrone...@opteya.com Cc: Theodore Ts'o ty...@mit.edu Signed-off-by: Yann Droneaud ydrone...@opteya.com --- arch/arm/kernel/process.c | 2 +- arch/arm64/kernel/process.c | 2 +- arch/tile/mm/mmap.c | 2 +- arch/unicore32/kernel/process.c | 2 +- arch/x86/kernel/process.c

[PATCHv4] driver core/platform: don't leak memory allocated for dma_mask

2014-01-27 Thread Yann Droneaud
/patch/3480961/ [4] http://lkml.kernel.org/r/1386886207-2735-1-git-send-email-ydrone...@opteya.com Cc: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Yann Droneaud ydrone...@opteya.com

Re: [PATCH v3] net: handle error more gracefully in socketpair()

2013-12-11 Thread Yann Droneaud
Le mardi 10 décembre 2013 à 22:24 -0500, David Miller a écrit : From: Yann Droneaud ydrone...@opteya.com Date: Mon, 9 Dec 2013 22:42:20 +0100 ... Cc: David S. Miller da...@davemloft.net Cc: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http

[PATCH] fs: clear close-on-exec flag as part of put_unused_fd()

2013-12-11 Thread Yann Droneaud
not set, so there's no need to clear it explicitly. Signed-off-by: Yann Droneaud ydrone...@opteya.com --- fs/file.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/file.c b/fs/file.c index 4a78f981557a..e98f5a5b1050 100644 --- a/fs/file.c +++ b/fs/file.c @@ -500,8 +500,6

Re: [PATCH] fs: clear close-on-exec flag as part of put_unused_fd()

2013-12-12 Thread Yann Droneaud
Hi, Le mercredi 11 décembre 2013 à 23:36 +0100, Mateusz Guzik a écrit : On Wed, Dec 11, 2013 at 10:08:27PM +0100, Yann Droneaud wrote: @@ -806,8 +803,6 @@ static int do_dup2(struct files_struct *files, __set_open_fd(fd, fdt); if (flags O_CLOEXEC) __set_close_on_exec

  1   2   3   4   5   >