Re: [PATCH 2/2] aio, mem-hotplug: Add memory barrier to aio ring page migration.

2014-02-27 Thread Yasuaki Ishimatsu
read_events_ring() may not work correctly. So smp_wmb() and smp_rmb() is needed. Thanks, Yasuaki Ishimatsu Also, if you've changed the patch, it is customary to add a "v2" somewhere in the patch title so that I have some idea what version of the patch should be applied.

[Update PATCH 2/2] aio, mem-hotplug: Add memory barrier to aio ring page migration.

2014-02-27 Thread Yasuaki Ishimatsu
Signed-off-by: Yasuaki Ishimatsu --- fs/aio.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/fs/aio.c b/fs/aio.c index 50c089c..8d9b82b 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -327,6 +327,14 @@ static int aio_migratepage(struct address_space *mapping, s

Re: [PATCH 04/46] kernel: Mark function as static in kernel/resource.c

2014-02-27 Thread Yasuaki Ishimatsu
] Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett --- Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu kernel/resource.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/resource.c b/kernel/resource.c index 3f285dc..ede7db2 100644 --- a

Re: [PATCH 2/2] aio, mem-hotplug: Add memory barrier to aio ring page migration.

2014-02-27 Thread Yasuaki Ishimatsu
not fully initialized new ring page. > > So add a wmb to synchronize them. > > Reported-by: Yasuaki Ishimatsu > Signed-off-by: Tang Chen > --- > fs/aio.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/fs/aio.c b/fs/aio.c > index 50c089c

Re: [PATCH] kernel/resource.c: fix sparse non static symbol warning

2014-02-13 Thread Yasuaki Ishimatsu
'reallocate_resource' was not declared. Should it be static? Signed-off-by: Daeseok Youn --- Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu kernel/resource.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/resource.c b/kernel/resource.c ind

Re: [PATCH] ACPI / container: Fix error code path in container_device_attach()

2014-02-11 Thread Yasuaki Ishimatsu
containers in a special way) Signed-off-by: Rafael J. Wysocki --- Looks good to me. Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu 3.14 material. Thanks! --- drivers/acpi/container.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index: linux-pm/drivers/acpi

Re: [PATCH 3/4] hugetlb: add hugepagesnid= command-line option

2014-02-11 Thread Yasuaki Ishimatsu
order = PMD_SHIFT - PAGE_SHIFT; > + } else if (ps == PUD_SIZE && cpu_has_gbpages) { > + order = PUD_SHIFT - PAGE_SHIFT; > + } else { > + printk(KERN_ERR "hugepagesnid: Unsupported page size %lu M\n", > +

Re: [PATCH 48/51] mm, vmstat: Fix CPU hotplug callback registration

2014-02-06 Thread Yasuaki Ishimatsu
Fix the vmstat code in the MM subsystem by using this latter form of callback registration. Cc: Andrew Morton Cc: Christoph Lameter Cc: Rik van Riel Cc: Johannes Weiner Cc: Yasuaki Ishimatsu Cc: Cody P Schafer Cc: Toshi Kani Cc: Dave Hansen Cc: linux...@kvack.org Signed-off-by: Srivatsa

Re: [PATCH] mm: __set_page_dirty_nobuffers uses spin_lock_irqseve instead of spin_lock_irq

2014-02-05 Thread Yasuaki Ishimatsu
] [] __do_page_fault+0x172/0x5a0 [ 600.918065] [] ? retint_swapgs+0x13/0x1b [ 600.943493] [] do_page_fault+0x1a/0x70 [ 600.968081] [] page_fault+0x28/0x30 Signed-off-by: KOSAKI Motohiro Cc: Larry Woodman Cc: Rik van Riel Cc: Johannes Weiner Cc: sta...@vger.kernel.org --- Tested-by: Yasuaki Ishi

Re: [PATCH] acpi memory hotplug, add parameter to disable memory hotplug [v3]

2014-01-14 Thread Yasuaki Ishimatsu
ned up Documentation/kernel-parameters.txt > > Signed-off-by: Prarit Bhargava > Cc: Vivek Goyal > Cc: Len Brown > Cc: "Rafael J. Wysocki" > Cc: kosaki.motoh...@gmail.com > Cc: dyo...@redhat.com > Cc: toshi.k...@hp.com > Cc: isimatu.yasu...@jp.fujitsu.com > C

Re: [RFC] hotplug, memory: move register_memory_resource out of the lock_memory_hotplug

2014-01-14 Thread Yasuaki Ishimatsu
that would need to be dealt with. > > > cc: Andrew Morton > cc: Tang Chen > cc: Wen Congyang > cc: Kamezawa Hiroyuki > cc: Yasuaki Ishimatsu > cc: "Rafael J. Wysocki" > cc: Hedi > cc: Mike Travis > cc: linux...@kvack.org > cc: linux-kernel@v

Re: [PATCH] x86, acpi memory hotplug, add parameter to disable memory hotplug

2014-01-13 Thread Yasuaki Ishimatsu
(2014/01/14 10:41), Toshi Kani wrote: On Tue, 2014-01-14 at 10:11 +0900, Yasuaki Ishimatsu wrote: : I think we need a knob manually enable mem-hotplug when specify memmap. But it is another story. Acked-by: KOSAKI Motohiro As mentioned, self-NAK. I have seen a system that I needed to

Re: [PATCH] x86, acpi memory hotplug, add parameter to disable memory hotplug

2014-01-13 Thread Yasuaki Ishimatsu
(2014/01/14 8:41), Prarit Bhargava wrote: On 01/13/2014 05:17 PM, KOSAKI Motohiro wrote: On Mon, Jan 13, 2014 at 4:56 PM, Prarit Bhargava wrote: When booting a kexec/kdump kernel on a system that has specific memory hotplug regions the boot will fail with warnings like: [2.939467] swapp

Re: kdump failed because of hotplug memory adding in kdump kernel

2014-01-10 Thread Yasuaki Ishimatsu
x-acpi&m=138922019607796&w=2 Thanks, Yasuaki Ishimatsu Am I right? The other question, e820 reserve is done earlier than acpi initialization, because acpi_early_init() invocation is very late in start_kernel(). Does that means at the very beginning all memorys are in

Re: kdump failed because of hotplug memory adding in kdump kernel

2014-01-10 Thread Yasuaki Ishimatsu
when acpi_early_init is called, hotplug memory is detected, they will be moved to different place or need be marked with a specific flag? No. Thanks, Yasuaki Ishimatsu I am more curious to know how makedumpfile decides what memory ranges to dump. The 1st kernel may have performed memory

Re: [PATCH] acpi memory hotplug, add parameter to disable memory hotplug for kexec

2014-01-09 Thread Yasuaki Ishimatsu
thing else. I like Prarit's patch and the boot option name. If it is updated, I'll test it. Thanks, Yasuaki Ishimatsu Thanks Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH 1/2][Untested] ACPI / hotplug: Add demand_offline hotplug profile flag

2013-12-26 Thread Yasuaki Ishimatsu
(2013/12/27 14:18), Yasuaki Ishimatsu wrote: (2013/12/27 9:58), Rafael J. Wysocki wrote: On Thursday, December 26, 2013 01:10:30 PM Yasuaki Ishimatsu wrote: (2013/12/26 12:10), Yasuaki Ishimatsu wrote: (2013/12/23 23:00), Rafael J. Wysocki wrote: From: Rafael J. Wysocki Add a new ACPI

Re: [PATCH 1/2][Untested] ACPI / hotplug: Add demand_offline hotplug profile flag

2013-12-26 Thread Yasuaki Ishimatsu
(2013/12/27 9:58), Rafael J. Wysocki wrote: On Thursday, December 26, 2013 01:10:30 PM Yasuaki Ishimatsu wrote: (2013/12/26 12:10), Yasuaki Ishimatsu wrote: (2013/12/23 23:00), Rafael J. Wysocki wrote: From: Rafael J. Wysocki Add a new ACPI hotplug profile flag, demand_offline, such that if

Re: [PATCH 1/2][Untested] ACPI / hotplug: Add demand_offline hotplug profile flag

2013-12-25 Thread Yasuaki Ishimatsu
(2013/12/26 12:10), Yasuaki Ishimatsu wrote: (2013/12/23 23:00), Rafael J. Wysocki wrote: From: Rafael J. Wysocki Add a new ACPI hotplug profile flag, demand_offline, such that if set for the given ACPI device object's scan handler, it will cause acpi_scan_hot_remove() to check if that d

Re: [PATCH 1/2][Untested] ACPI / hotplug: Add demand_offline hotplug profile flag

2013-12-25 Thread Yasuaki Ishimatsu
PCI root bridge does not has offline function (pn->dev->bus->offline). So I cannot offline the device and pn->dev->offline of the device is always 0. Therefore, following operation always returns -EBUSY even if I offline CPUs and all memory sections on a con

Re: [PATCH 7/10] ACPI / hotplug: Move container-specific code out of the core

2013-12-25 Thread Yasuaki Ishimatsu
HI Rafael, (2013/12/26 10:01), Rafael J. Wysocki wrote: On Monday, December 23, 2013 02:58:38 PM Rafael J. Wysocki wrote: On Saturday, December 14, 2013 06:07:06 AM Rafael J. Wysocki wrote: On Friday, December 13, 2013 02:17:32 PM Yasuaki Ishimatsu wrote: (2013/12/13 13:56), Rafael J

Re: [PATCH 7/10] ACPI / hotplug: Move container-specific code out of the core

2013-12-12 Thread Yasuaki Ishimatsu
(2013/12/13 13:56), Rafael J. Wysocki wrote: On Friday, December 13, 2013 11:56:32 AM Yasuaki Ishimatsu wrote: Hi Rafael, Hi, Please share your more detailed idea. I started to implement the following idea. But the idea has one problem. The eject work flow can be: (1) an eject event

Re: [PATCH 7/10] ACPI / hotplug: Move container-specific code out of the core

2013-12-12 Thread Yasuaki Ishimatsu
Hi Rafael, Please share your more detailed idea. I started to implement the following idea. But the idea has one problem. The eject work flow can be: (1) an eject event occurs, (2) the container "physical" device fails offline in acpi_scan_hot_remove() emmitting, say, KOBJ_CHANG

Re: [PATCH] mm, x86: Skip NUMA_NO_NODE while parsing SLIT

2013-12-05 Thread Yasuaki Ishimatsu
(2013/12/06 0:11), Toshi Kani wrote: On Thu, 2013-12-05 at 19:25 +0900, Yasuaki Ishimatsu wrote: (2013/12/05 6:09), Toshi Kani wrote: When ACPI SLIT table has an I/O locality (i.e. a locality unique to an I/O device), numa_set_distance() emits the warning message below. NUMA: Warning: node

Re: [PATCH] mm, x86: Skip NUMA_NO_NODE while parsing SLIT

2013-12-05 Thread Yasuaki Ishimatsu
I/O localities are not supported and are ignored > today, but emitting such warning message leads unnecessary confusion. In this case, the warning message should not be shown. But if SLIT table is really broken, the message should be shown. Your patch seems to not care for second case. Tha

Re: [PATCH 7/10] ACPI / hotplug: Move container-specific code out of the core

2013-12-03 Thread Yasuaki Ishimatsu
(2013/12/03 22:15), Rafael J. Wysocki wrote: On Tuesday, December 03, 2013 11:46:24 AM Yasuaki Ishimatsu wrote: (2013/11/29 22:08), Rafael J. Wysocki wrote: On Friday, November 29, 2013 11:36:55 AM Yasuaki Ishimatsu wrote: Hi Rafael, Hi, Replying to this mail may be wrong. OK, so this

Re: [PATCH] x86, efi: add efi_whitelist_table to use all efi variable storage

2013-12-02 Thread Yasuaki Ishimatsu
(2013/12/03 14:04), Matthew Garrett wrote: On Tue, Dec 03, 2013 at 01:49:04PM +0900, Yasuaki Ishimatsu wrote: What boot service is the "boot services" in these sentences? The environment prior to ExitBootServices() being called. I see. I'll check it. Thank, Yasuaki I

Re: [PATCH] x86, efi: add efi_whitelist_table to use all efi variable storage

2013-12-02 Thread Yasuaki Ishimatsu
rvice is the "boot services" in these sentences? Thanks, Yasuaki Ishimatsu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Ple

Re: [PATCH] x86, efi: add efi_whitelist_table to use all efi variable storage

2013-12-02 Thread Yasuaki Ishimatsu
(2013/11/23 2:47), Matthew Garrett wrote: On Fri, 2013-11-22 at 15:29 +0900, Yasuaki Ishimatsu wrote: + DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"), + DMI_MATCH(DMI_PRODUCT_NAME, "PRIMEQUEST"), Can we guarantee that no Primequests hav

Re: [PATCH 7/10] ACPI / hotplug: Move container-specific code out of the core

2013-12-02 Thread Yasuaki Ishimatsu
(2013/11/29 22:08), Rafael J. Wysocki wrote: On Friday, November 29, 2013 11:36:55 AM Yasuaki Ishimatsu wrote: Hi Rafael, Hi, Replying to this mail may be wrong. OK, so this particular patch doesn't break things any more? Yes. Do you remember following your patch? http://lkm

Re: [PATCH 7/10] ACPI / hotplug: Move container-specific code out of the core

2013-11-28 Thread Yasuaki Ishimatsu
ed correctly. Then I want to add autoeject variable in acpi_hotplug_profile so that user can change the parameter to "true" or "false". Thanks, Yasuaki Ishimatsu (2013/11/18 1:36), Rafael J. Wysocki wrote: From: Rafael J. Wysocki Move container-specific uevents from the

[PATCH] x86, efi: add efi_whitelist_table to use all efi variable storage

2013-11-21 Thread Yasuaki Ishimatsu
occurs by the 5Kbyte threshold, nvram storage cannot be used until EFI_OUT_OF_RESOURCES occurs on pre OS environment with UEFI. This patch adds whitelist. If a server is in the whitelist, efi_no_storage_paranoia is set to true. And the system can use all efi variable storage. Signed-off-by: Yasuaki Is

Re: [PATCH] x86, efi: add no_bricked_efi whitelist

2013-11-21 Thread Yasuaki Ishimatsu
(2013/11/22 9:03), Matthew Garrett wrote: On Fri, 2013-11-22 at 09:00 +0900, Yasuaki Ishimatsu wrote: (2013/11/22 5:12), Matthew Garrett wrote: On Thu, 2013-11-21 at 18:35 +0900, Yasuaki Ishimatsu wrote: Remaining space is free space that can be used by efi variable. But by 5KB threshold, we

Re: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia

2013-11-21 Thread Yasuaki Ishimatsu
(2013/11/20 17:08), joeyli wrote: 於 三,2013-11-20 於 15:26 +0900,Yasuaki Ishimatsu 提到: (2013/11/19 12:16), Madper Xie wrote: isimatu.yasu...@jp.fujitsu.com writes: Hi Matt, Sorry for late the reply. (2013/11/11 19:54), Matt Fleming wrote: On Mon, 11 Nov, at 05:52:59PM, Yasuaki Ishimatsu

[PATCH] x86, efi: add no_bricked_efi whitelist

2013-11-20 Thread Yasuaki Ishimatsu
occurs by the 5Kbyte threshold, nvram storage cannot be used until EFI_OUT_OF_RESOURCES occurs on pre OS environment with UEFI. This patch adds whitelist. If a server is in the whitelist, efi_no_storage_paranoia is set to true. And the system can use all efi variable storage. Signed-off-by: Yasuaki Is

Re: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia

2013-11-19 Thread Yasuaki Ishimatsu
(2013/11/19 12:16), Madper Xie wrote: > > isimatu.yasu...@jp.fujitsu.com writes: > >> Hi Matt, >> >> Sorry for late the reply. >> >> >> (2013/11/11 19:54), Matt Fleming wrote: >>> On Mon, 11 Nov, at 05:52:59PM, Yasuaki Ishimatsu wrote: >&

Re: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia

2013-11-18 Thread Yasuaki Ishimatsu
Hi Matt, Sorry for late the reply. (2013/11/11 19:54), Matt Fleming wrote: On Mon, 11 Nov, at 05:52:59PM, Yasuaki Ishimatsu wrote: Hi Matt, I uses FUJITSU's x86 box. This does not become bricked even if I use all efi variable storage. Thus I want a way to not need to sp

[PATCH resend] mm: get rid of unnecessary pageblock scanning in setup_zone_migrate_reserve

2013-11-13 Thread Yasuaki Ishimatsu
I resend this patch. I added performance result into description of the patch. -- Yasuaki Ishimatsu reported memory hot-add spent more than 5 _hours_ on 9TB memory machine since onlining memory sections is too slow. And we found out

Re: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia

2013-11-11 Thread Yasuaki Ishimatsu
Hi Matt, I uses FUJITSU's x86 box. This does not become bricked even if I use all efi variable storage. Thus I want a way to not need to specify efi_no_storage_paranoia parameter. Thanks, Yasuaki Ishimatsu (2013/11/08 23:34), Matt Fleming wrote: On Fri, 08 Nov, at 07:32:51PM, Ya

Re: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia

2013-11-08 Thread Yasuaki Ishimatsu
(2013/11/08 19:29), Richard Weinberger wrote: > Am 08.11.2013 11:25, schrieb Yasuaki Ishimatsu: >> (2013/11/08 18:37), Richard Weinberger wrote: >>> Am 08.11.2013 10:34, schrieb Yasuaki Ishimatsu: >>>> (2013/11/08 17:05), Richard Weinberger wrote: >>>

Re: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia

2013-11-08 Thread Yasuaki Ishimatsu
(2013/11/08 18:37), Richard Weinberger wrote: > Am 08.11.2013 10:34, schrieb Yasuaki Ishimatsu: >> (2013/11/08 17:05), Richard Weinberger wrote: >>> Am 08.11.2013 08:33, schrieb Yasuaki Ishimatsu: >>>> By following works, my system very often fails set_variable() t

Re: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia

2013-11-08 Thread Yasuaki Ishimatsu
(2013/11/08 17:05), Richard Weinberger wrote: > Am 08.11.2013 08:33, schrieb Yasuaki Ishimatsu: >> By following works, my system very often fails set_variable() to set new >> variable to efi variable storage and shows "efivars: set_variable() failed: >> status=-2

[PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia

2013-11-07 Thread Yasuaki Ishimatsu
s patch changes name of the parameter to efi_storage_paranoia and uses all efi variable storage with no parameter. Signed-off-by: Yasuaki Ishimatsu CC: Matthew Garrett CC: Richard Weinberger CC: Lee, Chun-Y CC: Matt Fleming --- Documentation/kernel-parameters.txt | 10 +- arch/x8

Re: [PATCH] mm: get rid of unnecessary pageblock scanning in setup_zone_migrate_reserve

2013-11-01 Thread Yasuaki Ishimatsu
: 8 nodes and each node has 32GB of memory In my result, Mel's patch does not seem to fix the problem since time is increasing with increasing amount of memory. Thanks, Yasuaki Ishimatsu (2013/11/01 2:14), KOSAKI Motohiro wrote: Nit. I would like to add following hunk. This is just nit

Re: [PATCH] Release device_hotplug_lock when store_mem_state returns EINVAL

2013-10-16 Thread Yasuaki Ishimatsu
(2013/10/12 1:31), Toshi Kani wrote: On Fri, 2013-10-11 at 15:36 +0900, Yasuaki Ishimatsu wrote: When inserting a wrong value to /sys/devices/system/memory/memoryX/state file, following messages are shown. And device_hotplug_lock is never released

Re: [PATCH] Release device_hotplug_lock when store_mem_state returns EINVAL

2013-10-14 Thread Yasuaki Ishimatsu
Hi Greg, (2013/10/12 0:54), Greg KH wrote: On Fri, Oct 11, 2013 at 03:36:25PM +0900, Yasuaki Ishimatsu wrote: When inserting a wrong value to /sys/devices/system/memory/memoryX/state file, following messages are shown. And device_hotplug_lock is never released

[PATCH] Release device_hotplug_lock when store_mem_state returns EINVAL

2013-10-10 Thread Yasuaki Ishimatsu
for state change). This patch releases device_hotplug_lcok when store_mem_state returns EINVAL. Signed-off-by: Yasuaki Ishimatsu CC: Toshi Kani CC: Seth Jennings CC: Greg Kroah-Hartman --- drivers/base/memory.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH v2] cpu/mem hotplug: Add try_online_node() for cpu_up()

2013-09-10 Thread Yasuaki Ishimatsu
after > try_offline_node() as they have similar purpose. > > There is no functional change in this patch. > > Signed-off-by: Toshi Kani > --- > v2: Added pr_err() in case of NULL pgdat in try_online_node(). > --- Thank you for updating it. It looks good to me. Revi

Re: [PATCH] cpu/mem hotplug: Add try_online_node() for cpu_up()

2013-09-09 Thread Yasuaki Ishimatsu
(2013/09/10 12:31), Yasuaki Ishimatsu wrote: > (2013/09/10 9:24), Toshi Kani wrote: >> cpu_up() has #ifdef CONFIG_MEMORY_HOTPLUG code blocks, which >> call mem_online_node() to put its node online if offlined and >> then call build_all_zonelists() to initialize the zone lis

Re: [PATCH] cpu/mem hotplug: Add try_online_node() for cpu_up()

2013-09-09 Thread Yasuaki Ishimatsu
err = mem_online_node(nid); > - if (err) > - return err; > - } > - > - pgdat = NODE_DATA(nid); > - if (!pgdat) { > - printk(KERN_ERR > - "Can't online cpu %d due to NULL

Re: [PATCH 2/2] mm/cleanup: use pfn_to_nid() instead of page_to_nid(pfn_to_page())

2013-09-08 Thread Yasuaki Ishimatsu
[CCing Kosaki since he maintains mm/memory_hotplug.c] (2013/09/09 12:27), Xishi Qiu wrote: Use "pfn_to_nid(pfn)" instead of "page_to_nid(pfn_to_page(pfn))". Signed-off-by: Xishi Qiu --- Acked-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu mm/memory_hotplug.c

Re: [PATCH 1/2] mm/hotplug: rename the function is_memblock_offlined_cb()

2013-09-08 Thread Yasuaki Ishimatsu
. Signed-off-by: Xishi Qiu Acked-by: Yasuaki Ishimatsu --- I have not acked your previous patch yet. But this patch seems good to me. So I acked the patch. Thanks, Yasuaki Ishimatsu mm/memory_hotplug.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mm

Re: [PATCH] mm/hotplug: rename the function is_memblock_offlined_cb()

2013-09-08 Thread Yasuaki Ishimatsu
_page(pfn)); + nid = pfn_to_nid(pfn); Please split the cleanup from this patch since the cleanup has nothing to do with the description of this patch. Thanks, Yasuaki Ishimatsu ret = memory_notify(MEM_GOING_ONLINE, &arg); ret = notifier_to_errno(ret); @@ -1657,7 +165

Re: [PATCH v2 2/4] acpi cleanup: Use pr_{info|err}() instead of printk() in arch/x86/mm/srat.c

2013-09-04 Thread Yasuaki Ishimatsu
quot;); > + pr_err("Too many proximity domains.\n"); > goto out_err_bad_srat; > } > > @@ -166,9 +168,9 @@ acpi_numa_memory_affinity_init(struct > acpi_srat_mem_affinity *ma) > > node_set(node, numa_nodes_parsed); > &

Re: [RFC PATCH v3 09/35] mm: Track the freepage migratetype of pages accurately

2013-09-04 Thread Yasuaki Ishimatsu
(2013/09/03 17:45), Srivatsa S. Bhat wrote: On 09/03/2013 12:08 PM, Yasuaki Ishimatsu wrote: (2013/08/30 22:16), Srivatsa S. Bhat wrote: Due to the region-wise ordering of the pages in the buddy allocator's free lists, whenever we want to delete a free pageblock from a free list (for ex:

Re: [RFC PATCH v3 08/35] mm: Demarcate and maintain pageblocks in region-order in the zones' freelists

2013-09-04 Thread Yasuaki Ishimatsu
truct list_head *prev_page_lru, *lru, *p; nitpick *p is used only when enabling CONFIG_DEBUG_PAGEALLOC option. When disabling the config option and compiling kernel, the messages are shown. CC mm/page_alloc.o mm/page_alloc.c: In function ‘del_from_freelist’: mm/page_alloc.c:560: 警告: unused

Re: [RFC PATCH v3 09/35] mm: Track the freepage migratetype of pages accurately

2013-09-02 Thread Yasuaki Ishimatsu
migratetype(&page[size], migratetype); } } It this patch a bug fix patch? If so, I want you to split the patch from the patch-set. Thanks, Yasuaki Ishimatsu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majo

Re: [RFC PATCH v3 06/35] mm: Add helpers to retrieve node region and zone region for a given page

2013-09-02 Thread Yasuaki Ishimatsu
ns of each such +* zone for this physical (node) region. +*/ + int zone_region_idx[MAX_NR_ZONES]; You should initialize the zone_region_id[] as negative value. If the zone_region_id is initialized as 0, region 0 belongs to all zones. Thanks, Yasuaki Ishimatsu str

Re: [RFC PATCH v3 04/35] mm: Initialize node memory regions during boot

2013-09-02 Thread Yasuaki Ishimatsu
(2013/09/03 2:43), Srivatsa S. Bhat wrote: On 09/02/2013 11:50 AM, Yasuaki Ishimatsu wrote: (2013/08/30 22:15), Srivatsa S. Bhat wrote: Initialize the node's memory-regions structures with the information about the region-boundaries, at boot time. Based-on-patch-by: Ankita Garg Signed-o

Re: [RFC PATCH v3 04/35] mm: Initialize node memory regions during boot

2013-09-01 Thread Yasuaki Ishimatsu
region = &pgdat->node_regions[idx]; It seems that overflow easily occurs. node_regions[] has 256 entries and MEM_REGION_SIZE is 512MiB. So if the pgdat has more than 128 GiB, overflow will occur. Am I wrong? Thanks, Yasuaki Ishimatsu + region->pgdat = pgdat;

Re: [PATCH v2 0/4] Unify CPU hotplug lock interface

2013-08-29 Thread Yasuaki Ishimatsu
gt; > --- The patch-set looks good to me. Acked-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu > arch/powerpc/kernel/smp.c | 12 -- > arch/powerpc/platforms/pseries/dlpar.c | 40 > +- > arch/x86/Kconfig

Re: [PATCH] drivers/base/memory.c: introduce help macro to_memory_block

2013-08-26 Thread Yasuaki Ishimatsu
(2013/08/26 19:32), Gu Zheng wrote: Introduce help macro to_memory_block to hide the conversion(device-->memory_block), just clean up. Signed-off-by: Gu Zheng --- It looks good to me. Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu drivers/base/memory.c |

Re: [PATCH v2] [BUGFIX] drivers/base: fix show_mem_removable to handle missing sections

2013-08-26 Thread Yasuaki Ishimatsu
2: Add change suggested by Yasuaki Ishimatsu. Signed-off-by: Russ Anderson Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu The failing output: --- harp5-sys:~ # cat /sys/devices/system/memory/memory*/removable 0 1 1 1 1 1 1

Re: [PATCH] [BUGFIX] drivers/base: fix show_mem_removable section count

2013-08-23 Thread Yasuaki Ishimatsu
ion_nr + i)) continue; Thanks, Yasuaki Ishimatsu pfn = section_nr_to_pfn(mem->start_section_nr + i); ret &= is_mem_section_removable(pfn, PAGES_PER_SECTION); } -- To unsubscribe from this list: send the line "uns

Re: [PATCH 1/7] drivers: base: move mutex lock out of add_memory_section()

2013-08-22 Thread Yasuaki Ishimatsu
is intended by this set! All patches were Reviewed-by: Yasuaki Ishimatsu Tested-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu Seth -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majord...@kvack.org. For more info on Linux MM, see: http://www.li

Re: [PATCH 7/7] drivers: base: refactor add_memory_section() to add_memory_block()

2013-08-22 Thread Yasuaki Ishimatsu
(2013/08/22 17:20), Yasuaki Ishimatsu wrote: > (2013/08/21 2:13), Seth Jennings wrote: >> Right now memory_dev_init() maintains the memory block pointer >> between iterations of add_memory_section(). This is nasty. >> >> This patch refactors add_memory_section()

Re: [PATCH 7/7] drivers: base: refactor add_memory_section() to add_memory_block()

2013-08-22 Thread Yasuaki Ishimatsu
(2013/08/21 2:13), Seth Jennings wrote: > Right now memory_dev_init() maintains the memory block pointer > between iterations of add_memory_section(). This is nasty. > > This patch refactors add_memory_section() to become add_memory_block(). > The refactoring pulls the section scanning out of mem

Re: [PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic()

2013-08-08 Thread Yasuaki Ishimatsu
(2013/08/09 11:43), Gu Zheng wrote: > Hi Ishimatsu-san, > On 08/06/2013 06:11 PM, Yasuaki Ishimatsu wrote: > >> try_offline_node() checks that all cpus related with removed node have been >> removed by using cpu_present_bits. If all cpus related with removed node

Re: [PATCH 0/5] ACPI: acpi_bind_one()/acpi_unbind_one() cleanups

2013-08-06 Thread Yasuaki Ishimatsu
code path in acpi_unbind_one(). Acked-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic()

2013-08-06 Thread Yasuaki Ishimatsu
(2013/08/07 1:56), Toshi Kani wrote: On Tue, 2013-08-06 at 19:11 +0900, Yasuaki Ishimatsu wrote: try_offline_node() checks that all cpus related with removed node have been removed by using cpu_present_bits. If all cpus related with removed node have been removed, try_offline_node() clears the

Re: acpi_bus_trim does not detach devices in post order

2013-08-06 Thread Yasuaki Ishimatsu
(2013/08/07 9:57), Rafael J. Wysocki wrote: On Wednesday, August 07, 2013 09:35:51 AM Yasuaki Ishimatsu wrote: (2013/08/06 23:26), Rafael J. Wysocki wrote: On Tuesday, August 06, 2013 07:06:37 PM Yasuaki Ishimatsu wrote: (2013/08/06 12:07), Yasuaki Ishimatsu wrote: I acked the following

Re: acpi_bus_trim does not detach devices in post order

2013-08-06 Thread Yasuaki Ishimatsu
(2013/08/06 23:26), Rafael J. Wysocki wrote: On Tuesday, August 06, 2013 07:06:37 PM Yasuaki Ishimatsu wrote: (2013/08/06 12:07), Yasuaki Ishimatsu wrote: I acked the following commit but I hit a problem by the commit. So I report it. commit cecdb193c8d91a42d9489d00618cc3dfff92e55a Author

[PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic()

2013-08-06 Thread Yasuaki Ishimatsu
ff-by: Yasuaki Ishimatsu --- drivers/acpi/acpi_processor.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c index fd6c51c..5a74a9c 100644 --- a/drivers/acpi/acpi_processor.c +++ b/drivers/acpi/acpi_proces

Re: acpi_bus_trim does not detach devices in post order

2013-08-06 Thread Yasuaki Ishimatsu
(2013/08/06 12:07), Yasuaki Ishimatsu wrote: > > I acked the following commit but I hit a problem by the commit. > So I report it. > > commit cecdb193c8d91a42d9489d00618cc3dfff92e55a > Author: Rafael J. Wysocki > Date: Tue Jan 15 13:24:02 2013 +0100 > >

acpi_bus_trim does not detach devices in post order

2013-08-05 Thread Yasuaki Ishimatsu
pages uevent CPU and memory sysfs files are removed correctly. But node1 sysfs file remained. Thanks, Yasuaki Ishimatsu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: Cannot hot remove a memory device (patch, updated)

2013-08-05 Thread Yasuaki Ishimatsu
dependent physical devices per ACPI device object, which now depends only on the capacity of unsigend int. Signed-off-by: Rafael J. Wysocki Reviewed-by: Yasuaki Ishimatsu Tested-by: Yasuaki Ishimatsu I confirmed that I can add and remove a memory device correctly. Thanks, Yasuaki Ishimatsu

Re: Cannot hot remove a memory device

2013-08-05 Thread Yasuaki Ishimatsu
(2013/08/05 13:00), Yasuaki Ishimatsu wrote: (2013/08/04 9:37), Toshi Kani wrote: On Sat, 2013-08-03 at 03:01 +0200, Rafael J. Wysocki wrote: On Friday, August 02, 2013 06:04:40 PM Toshi Kani wrote: On Sat, 2013-08-03 at 01:43 +0200, Rafael J. Wysocki wrote: On Friday, August 02, 2013 03:46

Re: Cannot hot remove a memory device

2013-08-04 Thread Yasuaki Ishimatsu
23:43 +0200, Rafael J. Wysocki wrote: Hi, Thanks for your report. On Thursday, August 01, 2013 05:37:21 PM Yasuaki Ishimatsu wrote: By following commit, I cannot hot remove a memory device. ACPI / memhotplug: Bind removable memory blocks to ACPI device nodes commit

Cannot hot remove a memory device

2013-08-01 Thread Yasuaki Ishimatsu
is caused by failing acpi_bind_memory_blocks(). I'm now investigating why acpi_bind_memory_blocks() fails. Thanks, Yasuaki Ishimatsu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH v2] mm/hotplug, x86: Disable ARCH_MEMORY_PROBE by default

2013-07-24 Thread Yasuaki Ishimatsu
(2013/07/25 12:34), Hush Bensen wrote: On 07/25/2013 11:08 AM, Yasuaki Ishimatsu wrote: (2013/07/25 9:56), Hush Bensen wrote: On 07/25/2013 12:02 AM, Toshi Kani wrote: On Wed, 2013-07-24 at 08:18 +0800, Hush Bensen wrote: On 07/24/2013 04:45 AM, Toshi Kani wrote: On Tue, 2013-07-23 at 10:01

Re: [PATCH v2] mm/hotplug, x86: Disable ARCH_MEMORY_PROBE by default

2013-07-24 Thread Yasuaki Ishimatsu
s/bus/acpi/devices/PNP0C80:XX/eject both will call eject method? Yes. Both operations will call eject method. What's the difference between these two methods? I guess the former will send SCI and the latter won't. Triggers are different. Former is triggered by SCI, latter is

Re: [PATCH v2] mm/hotplug, x86: Disable ARCH_MEMORY_PROBE by default

2013-07-22 Thread Yasuaki Ishimatsu
on the system. This interface is > currently used for testing as it can fake a hotplug event. > > This patch disables CONFIG_ARCH_MEMORY_PROBE by default on x86, adds > its Kconfig menu entry on x86, and clarifies its use in Documentation/ > memory-hotplug.txt. > > Signed-off

Re: [PATCH] ACPI / memhotplug: Fix a stale pointer in error path

2013-07-11 Thread Yasuaki Ishimatsu
(2013/07/11 1:47), Toshi Kani wrote: > device->driver_data needs to be cleared when releasing its data, > mem_device, in an error path of acpi_memory_device_add(). > > Signed-off-by: Toshi Kani > --- Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu > drivers/a

Re: [PATCH] ACPI / PM: Fix error code path for power resources initialization

2013-06-18 Thread Yasuaki Ishimatsu
field of struct acpi_power_resource upfront. Reported-by: Mika Westerberg Signed-off-by: Rafael J. Wysocki Cc: 3.9+ Acked-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu --- drivers/acpi/power.c |1 + 1 file changed, 1 insertion(+) Index: linux-pm/drive

Re: [PATCH] ACPI: Remove the use of CONFIG_ACPI_HOTPLUG_MEMORY_MODULE

2013-06-18 Thread Yasuaki Ishimatsu
\ > + defined(CONFIG_ACPI_HOTPLUG_MEMORY) && \ > defined(CONFIG_ACPI_CONTAINER) > #define ACPI_HOTPLUG_OST > #endif > -- Good catch!! Acked-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu > To unsubscribe from this list: send the line "uns

Re: [Part3 PATCH v2 0/4] Support hot-remove local pagetable pages.

2013-06-18 Thread Yasuaki Ishimatsu
s work is to put pagetable on local node ram. For this, he needs to know SRAT information before setting pagetable. So part1 does them same time. Thanks, Yasuaki Ishimatsu Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH RFC v2 0/3] add cpu physically hotplug driver

2013-06-09 Thread Yasuaki Ishimatsu
ocess of CPU. I could not understand this explanation too. Why do we need it? Thanks, Yasuaki Ishimatsu so, offline is just like eject, but eject attribute seems not available since recent kernel(can't figure out when), with this driver, if allowed, it will trigger a eject cpu proces

Re: [Resend][Bug fix PATCH v5] Reusing a resource structure allocated by bootmem

2013-04-25 Thread Yasuaki Ishimatsu
2013/04/25 5:37, Andrew Morton wrote: On Wed, 24 Apr 2013 08:50:21 +0900 Yasuaki Ishimatsu wrote: When hot removing memory presented at boot time, following messages are shown: [ 296.867031] [ cut here ] [ 296.922273] kernel BUG at mm/slub.c:3409! ... The reason

Re: [Resend][Bug fix PATCH v5] Reusing a resource structure allocated by bootmem

2013-04-24 Thread Yasuaki Ishimatsu
2013/04/25 5:37, Andrew Morton wrote: On Wed, 24 Apr 2013 08:50:21 +0900 Yasuaki Ishimatsu wrote: When hot removing memory presented at boot time, following messages are shown: [ 296.867031] [ cut here ] [ 296.922273] kernel BUG at mm/slub.c:3409! ... The reason

[Resend][Bug fix PATCH v5] Reusing a resource structure allocated by bootmem

2013-04-23 Thread Yasuaki Ishimatsu
source structures or not. If there is a released resource structure, get_resource() returns it. If there is not a releaed resource structure, get_resource() returns new resource structure allocated by kzalloc(). Signed-off-by: Yasuaki Ishimatsu Reviewed-by: Toshi Kani --- v5:

Re: [Bug fix PATCH v5] Reusing a resource structure allocated by bootmem

2013-04-23 Thread Yasuaki Ishimatsu
2013/04/24 6:05, Toshi Kani wrote: On Tue, 2013-04-23 at 10:37 +0900, Yasuaki Ishimatsu wrote: : The reason why the messages are shown is to release a resource structure, allocated by bootmem, by kfree(). So when we release a resource structure, we should check whether it is allocated by

[Bug fix PATCH v5] Reusing a resource structure allocated by bootmem

2013-04-22 Thread Yasuaki Ishimatsu
When hot removing memory presented at boot time, following messages are shown: [ 296.867031] [ cut here ] [ 296.922273] kernel BUG at mm/slub.c:3409! [ 296.970229] invalid opcode: [#1] SMP [ 297.019453] Modules linked in: ebtable_nat ebtables xt_CHECKSUM iptable_m

Re: [Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-22 Thread Yasuaki Ishimatsu
2013/04/23 9:34, Andrew Morton wrote: On Tue, 23 Apr 2013 09:04:46 +0900 Yasuaki Ishimatsu wrote: 2013/04/23 7:35, Andrew Morton wrote: On Fri, 19 Apr 2013 14:23:23 +0900 Yasuaki Ishimatsu wrote: When booting x86 system contains memoryless node, node numbers of CPUs on memoryless node

Re: [Bug fix PATCH v4] Reusing a resource structure allocated by bootmem

2013-04-22 Thread Yasuaki Ishimatsu
2013/04/19 23:30, Toshi Kani wrote: On Fri, 2013-04-19 at 17:09 +0900, Yasuaki Ishimatsu wrote: Hi Toshi, 2013/04/19 8:33, Yasuaki Ishimatsu wrote: Hi Toshi, 2013/04/18 23:23, Toshi Kani wrote: On Thu, 2013-04-18 at 17:36 +0900, Yasuaki Ishimatsu wrote: When hot removing memory presented

Re: [Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-22 Thread Yasuaki Ishimatsu
2013/04/23 7:35, Andrew Morton wrote: On Fri, 19 Apr 2013 14:23:23 +0900 Yasuaki Ishimatsu wrote: When booting x86 system contains memoryless node, node numbers of CPUs on memoryless node were changed to nearest online node number by init_cpu_to_node() because the node is not online

Re: [Bug fix PATCH v4] Reusing a resource structure allocated by bootmem

2013-04-19 Thread Yasuaki Ishimatsu
Hi Toshi, 2013/04/19 8:33, Yasuaki Ishimatsu wrote: Hi Toshi, 2013/04/18 23:23, Toshi Kani wrote: On Thu, 2013-04-18 at 17:36 +0900, Yasuaki Ishimatsu wrote: When hot removing memory presented at boot time, following messages are shown: : diff --git a/kernel/resource.c b/kernel

[Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-18 Thread Yasuaki Ishimatsu
"cpu to node" and "node to cpu" links when node number changed by onlining CPU. Signed-off-by: Yasuaki Ishimatsu --- v2: Change argument's name from num to cpuid in store_online() Add comments for explaining why node number change --- drivers/base/cpu.c | 25

Re: [Bug fix PATCH] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-18 Thread Yasuaki Ishimatsu
u->dev.id); + from_nid = cpu_to_node(num); + ret = cpu_up(num); + to_nid = cpu_to_node(num); + if (from_nid != to_nid) + change_cpu_under_node(cpu, from_nid, to_nid); You need to add several comments. this code is not

Re: [Bug fix PATCH v4] Reusing a resource structure allocated by bootmem

2013-04-18 Thread Yasuaki Ishimatsu
2013/04/19 8:28, Toshi Kani wrote: On Fri, 2013-04-19 at 08:33 +0900, Yasuaki Ishimatsu wrote: : +static struct resource *get_resource(gfp_t flags) +{ + struct resource *res = NULL; + + spin_lock(&bootmem_resource_lock); + if (bootmem_resource.sib

Re: [Bug fix PATCH v4] Reusing a resource structure allocated by bootmem

2013-04-18 Thread Yasuaki Ishimatsu
Hi Toshi, 2013/04/18 23:23, Toshi Kani wrote: On Thu, 2013-04-18 at 17:36 +0900, Yasuaki Ishimatsu wrote: When hot removing memory presented at boot time, following messages are shown: : diff --git a/kernel/resource.c b/kernel/resource.c index 4aef886..637e8d2 100644 --- a/kernel

<    1   2   3   4   5   6   7   >