is floating and re-route data lines in this case
only, don't touch otherwise.
Signed-off-by: Yauhen Kharuzhy
---
drivers/extcon/extcon-intel-cht-wc.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/extcon/extcon-intel-cht-wc.c
b/drivers/extcon/extcon
On Mon, Aug 12, 2019 at 07:18:45PM +0200, Hans de Goede wrote:
> Hi,
>
> On 09-08-19 17:11, Yauhen Kharuzhy wrote:
> > On Fri, Aug 09, 2019 at 01:06:01PM +0200, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 8/9/19 12:01 AM, Yauhen Kharuzhy wrote:
>
is floating and re-route data lines in this case
only, don't touch otherwise.
Signed-off-by: Yauhen Kharuzhy
---
drivers/extcon/extcon-intel-cht-wc.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/extcon/extcon-intel-cht-wc.c
b/drivers/extcon/extcon
Patch to prevent resetting USB connection if OTG device is connected
during of driver initialization.
v2:
Change (id == INTEL_USB_ID_FLOAT) check to (id != INTEL_USB_ID_GND) as
Hans de Goede advised.
On Tue, Sep 17, 2019 at 02:13:22PM +0300, Andy Shevchenko wrote:
> On Tue, Sep 17, 2019 at 12:15:36AM +0300, Yauhen Kharuzhy wrote:
> > Intel Cherry Trail Whiskey Cove extcon driver connect USB data lines to
> > PMIC at driver probing for further charger detection. This causes r
,typec}.c. Compile all this source to one .ko
module to make user experience easier.
Signed-off-by: Yauhen Kharuzhy
---
drivers/platform/x86/Kconfig | 14 +-
drivers/platform/x86/Makefile | 4 +
.../platform/x86/intel_cht_int33fe_common.c | 148
detection in common code.
Yauhen Kharuzhy (1):
platform/x86/intel_cht_int33fe: Split code to USB TypeB and TypeC
variants
drivers/platform/x86/Kconfig | 14 +-
drivers/platform/x86/Makefile | 4 +
.../platform/x86/intel_cht_int33fe_common.c | 148
On Wed, Sep 18, 2019 at 11:20:21AM +0200, Hans de Goede wrote:
> Hi,
>
> On 17-09-2019 21:45, Yauhen Kharuzhy wrote:
> > Existing intel_cht_int33fe ACPI pseudo-device driver assumes that
> > hardware has TypeC connector and register related devices described as
> >
On Wed, Sep 18, 2019 at 02:38:35PM +0300, Heikki Krogerus wrote:
> On Tue, Sep 17, 2019 at 10:45:07PM +0300, Yauhen Kharuzhy wrote:
> > Existing intel_cht_int33fe ACPI pseudo-device driver assumes that
> > hardware has TypeC connector and register related devices described as
>
{typeb,typec}.c. Compile all this sources to one .ko
module to make user experience easier.
Signed-off-by: Yauhen Kharuzhy
---
drivers/platform/x86/Kconfig | 12 +-
drivers/platform/x86/Makefile | 4 +
.../platform/x86/intel_cht_int33fe_common.c | 147
C"
v2:
Instead of defining two separated modules with two separated config
options, compile {common,typeb,typec} sources into one .ko module.
Call needed variant-specific probe function based after of hardware type
detection in common code.
Yauhen Kharuzhy (1):
platform/x86/intel_cht_int33fe: Spl
On Wed, Sep 18, 2019 at 10:12:43PM +0200, Hans de Goede wrote:
> Hi,
>
> On 18-09-2019 13:42, Yauhen Kharuzhy wrote:
> > On Wed, Sep 18, 2019 at 11:20:21AM +0200, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 17-09-2019 21:45, Yauhen Kharuzhy wrote:
>
On Wed, Sep 18, 2019 at 11:33:32PM +0300, Yauhen Kharuzhy wrote:
> On Wed, Sep 18, 2019 at 10:12:43PM +0200, Hans de Goede wrote:
> > Hi,
> >
> > On 18-09-2019 13:42, Yauhen Kharuzhy wrote:
> > > On Wed, Sep 18, 2019 at 11:20:21AM +0200, Hans de Goede wrote:
> &g
function based after of hardware type
detection in common code.
Yauhen Kharuzhy (1):
platform/x86/intel_cht_int33fe: Split code to USB Micro-B and Type-C
variants
drivers/platform/x86/Kconfig | 12 +-
drivers/platform/x86/Makefile | 4 +
.../platform/x86/intel_
{typeb,typec}.c. Compile all this sources to one .ko
module to make user experience easier.
Signed-off-by: Yauhen Kharuzhy
---
drivers/platform/x86/Kconfig | 12 +-
drivers/platform/x86/Makefile | 4 +
.../platform/x86/intel_cht_int33fe_common.c | 147
{microb,typec}.c. Compile all this sources to one .ko
module to make user experience easier.
Signed-off-by: Yauhen Kharuzhy
---
drivers/platform/x86/Kconfig | 10 +-
drivers/platform/x86/Makefile | 4 +
.../platform/x86/intel_cht_int33fe_common.c | 147
C"
v2:
Instead of defining two separated modules with two separated config
options, compile {common,typeb,typec} sources into one .ko module.
Call needed variant-specific probe function based after of hardware type
detection in common code.
Yauhen Kharuzhy (1):
platform/x86/intel_cht_int33fe: Split
tform/INTCFD9:00/gpio-keys.0.auto/input/input6547
>
>
> And 1 CPU core being stuck at 100% and udev hanging since it is waiting
> for the modprobe of soc_button_array to return.
>
> This patch reverts the soc_button_lookup_gpio() error handling changes,
> fixing this regression.
I confirm this issue and I made similar hotfix while developing of other
things, so it's actual and patch should work. I will test it at my hardware
soon.
--
Yauhen Kharuzhy
C"
v2:
Instead of defining two separated modules with two separated config
options, compile {common,typeb,typec} sources into one .ko module.
Call needed variant-specific probe function based after of hardware type
detection in common code.
Yauhen Kharuzhy (1):
platform/x86/intel_cht_int33fe: Split
{microb,typec}.c. Compile all this sources to one .ko
module to make user experience easier.
Signed-off-by: Yauhen Kharuzhy
---
drivers/platform/x86/Kconfig | 10 +-
drivers/platform/x86/Makefile | 4 +
.../platform/x86/intel_cht_int33fe_common.c | 147
On Fri, Aug 09, 2019 at 01:06:01PM +0200, Hans de Goede wrote:
> Hi,
>
> On 8/9/19 12:01 AM, Yauhen Kharuzhy wrote:
> > Intel Cherry Trail Whiskey Cove extcon driver connect USB data lines to
> > PMIC at driver probing for further charger detection. This causes reset of
On Wed, Sep 25, 2019 at 06:02:22PM +0300, Andy Shevchenko wrote:
> On Sat, Sep 21, 2019 at 9:31 PM Hans de Goede wrote:
> >
> > Hi,
> >
> > On 21-09-2019 00:33, Yauhen Kharuzhy wrote:
> > > Existing intel_cht_int33fe ACPI pseudo-device driver assumes that
On Wed, Sep 25, 2019 at 08:42:03PM +0300, Andy Shevchenko wrote:
> On Wed, Sep 25, 2019 at 7:27 PM Yauhen Kharuzhy wrote:
> > On Wed, Sep 25, 2019 at 06:02:22PM +0300, Andy Shevchenko wrote:
> > > On Sat, Sep 21, 2019 at 9:31 PM Hans de Goede wrote:
>
> > > B
On Wed, Feb 13, 2019 at 11:43:29PM +0100, Hans de Goede wrote:
> Hi,
>
> On 12-02-19 21:59, Yauhen Kharuzhy wrote:
> > Add support for LEDs connected to the Intel Cherry Trail Whiskey Cove
> > PMIC. Charger and general-purpose leds are supported. Hardware blinking
> >
On Thu, Feb 14, 2019 at 12:15:00AM +0100, Hans de Goede wrote:
> Hi,
>
> On 10-02-19 21:36, Yauhen Kharuzhy wrote:
> > Whiskey Cove Cherry Trail PMIC requires disabling OTG host mode before
> > of charger detection procedure. Do this by manipulationg of CHGRCTRL1
> >
t; be switched to manual, and the pattern obviously becomes
> blinking.
>
> I believe this will work well with this hardware and
> nicely allow the user to control all settings.
>
> Regards,
>
> Hans
--
Yauhen Kharuzhy
This patch series introduces new driver for controlling LEDs connected
to Intel Cherry Trail Whiskey Cove PMIC (general-purpose LED and charger
status led). Only simple 'always on' and blinking modes are supported
for now, no breathing.
Driver was tested only with Lenovo Yoga Book notebook, and I
Add support for LEDs connected to the Intel Cherry Trail Whiskey Cove
PMIC. Charger and general-purpose leds are supported. Hardware blinking
is implemented, breathing is not.
This driver was tested with Lenovo Yoga Book notebook.
Signed-off-by: Yauhen Kharuzhy
---
drivers/leds/Kconfig
Add MFD cell for LEDs driver to the Intel Cherry Trail Whiskey Cove PMIC
mfd device driver.
Signed-off-by: Yauhen Kharuzhy
---
drivers/mfd/intel_soc_pmic_chtwc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/intel_soc_pmic_chtwc.c
b/drivers/mfd/intel_soc_pmic_chtwc.c
index
Whiskey Cove Cherry Trail PMIC requires disabling OTG host mode before
of charger detection procedure. Do this by manipulationg of CHGRCTRL1
register.
Source: APCI DSDT code of Lenovo Yoga Book YB1-X91L and open-sourced
Intel's drivers.
Signed-off-by: Yauhen Kharuzhy
---
drivers/extcon/extcon
2].
https://github.com/jekhor/yogabook-linux-android-kernel/blob/b7aa015ab794b516da7b6cb76e5e2d427e3b8b0c/drivers/power/bq2589x_charger.c#L2257
[3].
https://github.com/01org/ProductionKernelQuilts/uefi/cht-m1stable/patches/EM-Charger-Disable-battery-charging-in-S3-and-enable.patch
Yauhen Kharuzhy (2)
In some configuration external charge "#charge enable" signal is
connected to PMIC. Enable it at device probing to allow charging.
Tested at Lenovo Yoga Book (YB1-X91L).
Signed-off-by: Yauhen Kharuzhy
---
drivers/extcon/extcon-intel-cht-wc.c | 33
1 fi
ion outlined below.
>
> Note that glowing is only exported as in kernel functionality, I see no
> use-case for exporting this to userspace and keeping this in kernel allows
> us to keep things nice and simple.
>
Hi,
Unfortunately I am too busy now at fulltime job, so I don't know when I
will return to this. But I still plan to do :)
--
Yauhen Kharuzhy
пн, 18 февр. 2019 г. в 12:24, Hans de Goede :
>
> Hi,
>
> On 17-02-19 22:52, Yauhen Kharuzhy wrote:
> > On Fri, Feb 15, 2019 at 09:32:50AM +0300, Yauhen Kharuzhy wrote:
> >> On Thu, Feb 14, 2019 at 05:31:48PM +0100, Hans de Goede wrote:
> >>> Hi,
> &g
r the max current to
> use while charging the battery (assuming that the input current allows
> drawing enough current in the first place). I would hope that those bits
> have some sane value set from the firmware...
Yes, the charger has separate battery current limit but firmware doesn't
change its default value (2048 mA) while Lenovo's software driver does.
It set battery charging limit to 4 A and input limit to 2 A (it makes
sense because Lenovo adapter and BQ25892 both support voltage increasing
upto 12V).
--
Yauhen Kharuzhy
r.patch
[2].
https://github.com/jekhor/yogabook-linux-android-kernel/blob/b7aa015ab794b516da7b6cb76e5e2d427e3b8b0c/drivers/power/bq2589x_charger.c#L2257
[3].
https://github.com/01org/ProductionKernelQuilts/uefi/cht-m1stable/patches/EM-Charger-Disable-battery-charging-in-S3-and-enable.patch
Yauhen K
e.
Tested at Lenovo Yoga Book (YB1-X91L).
Signed-off-by: Yauhen Kharuzhy
---
drivers/extcon/extcon-intel-cht-wc.c | 91 +++-
1 file changed, 90 insertions(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-intel-cht-wc.c
b/drivers/extcon/extcon-intel-cht-wc.c
index 4f
Whiskey Cove Cherry Trail PMIC requires disabling OTG host mode before
of charger detection procedure. Do this by manipulationg of CHGRCTRL1
register.
Source: APCI DSDT code of Lenovo Yoga Book YB1-X91L and open-sourced
Intel's drivers.
Signed-off-by: Yauhen Kharuzhy
Reviewed-by: Hans de Goede
harge current to 4A everywhere.
Yes, I use such method already in the my kernel:
https://github.com/jekhor/yogabook-linux-kernel/blob/master/drivers/i2c/busses/i2c-cht-wc.c#L247
Anyway, charger tweaking will be next iteration, now I want to complete
current extcon stuff/
> Regards,
>
> Hans
--
Yauhen Kharuzhy
On Wed, Feb 20, 2019 at 02:42:06PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 20, 2019 at 12:24:40AM +0300, Yauhen Kharuzhy wrote:
> > Whiskey Cove Cherry Trail PMIC requires disabling OTG host mode before
> > of charger detection procedure. Do this by manipulationg of CHGRCTR
ср, 20 февр. 2019 г. в 18:53, Hans de Goede :
>
> Hi,
>
> On 2/19/19 10:24 PM, Yauhen Kharuzhy wrote:
> > In some configuration external charger "#charge enable" signal is
> > connected to PMIC. Enable it at device probing to allow charging.
> >
> > Sa
Whiskey Cove Cherry Trail PMIC requires disabling OTG host mode before
of charger detection procedure. Do this by manipulationg of CHGRCTRL1
register.
Source: APCI DSDT code of Lenovo Yoga Book YB1-X91L and open-sourced
Intel's drivers.
Signed-off-by: Yauhen Kharuzhy
Reviewed-by: Hans de Goede
e.
Tested at Lenovo Yoga Book (YB1-X91L).
Signed-off-by: Yauhen Kharuzhy
Reviewed-by: Andy Shevchenko
---
drivers/extcon/extcon-intel-cht-wc.c | 34 +++-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-intel-cht-wc.c
b/drivers/extcon/ex
ging-in-S3-and-enable.patch
Yauhen Kharuzhy (2):
extcon-intel-cht-wc: Make charger detection co-existed with OTG host mode
extcon intel-cht-wc: Enable external charger
drivers/extcon/extcon-intel-cht-wc.c | 60 +++-
1 file changed, 58 insertions(+), 2 deletions(-)
--
2.20.1
On Mon, Feb 11, 2019 at 10:36:30PM +0100, Jacek Anaszewski wrote:
> Hi Yauhen,
>
> Thank you for the patch.
>
> Please find few comments in the code.
>
> On 2/9/19 11:12 PM, Yauhen Kharuzhy wrote:
> > diff --git a/drivers/leds/leds-cht-wcove.c b/drivers/leds/leds-ch
On Tue, Feb 12, 2019 at 08:14:09AM +, Lee Jones wrote:
> On Sun, 10 Feb 2019, Yauhen Kharuzhy wrote:
>
> > Add MFD cell for LEDs driver to the Intel Cherry Trail Whiskey Cove PMIC
> > mfd device driver.
> >
> > Signed-off-by: Yauhen Kharuzhy
> > ---
>
-0-charging-blink-full-solid' as example but
it will valid for platforms with bq27542 battery fuel gauge, of course.
For status led, 'default-on' should be reasonable.
> Pavel
--
Yauhen Kharuzhy
Add MFD cell for LEDs driver to the Intel Cherry Trail Whiskey Cove PMIC
mfd device driver.
Signed-off-by: Yauhen Kharuzhy
---
drivers/mfd/intel_soc_pmic_chtwc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/intel_soc_pmic_chtwc.c
b/drivers/mfd/intel_soc_pmic_chtwc.c
index
Add support for LEDs connected to the Intel Cherry Trail Whiskey Cove
PMIC. Charger and general-purpose leds are supported. Hardware blinking
is implemented, breathing is not.
This driver was tested with Lenovo Yoga Book notebook.
Signed-off-by: Yauhen Kharuzhy
---
drivers/leds/Kconfig
don't have
any documentation for the PMIC, so proposals and testing are welcome.
v2:
- Fix comments and code style
- Add mutex to protect led state
- Add defaults triggers
- Fix module license declaration
Yauhen Kharuzhy (2):
leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs
mfd
On Thu, Feb 14, 2019 at 05:31:48PM +0100, Hans de Goede wrote:
> Hi,
>
> On 10-02-19 21:36, Yauhen Kharuzhy wrote:
> > In some configuration external charge "#charge enable" signal is
> > connected to PMIC. Enable it at device probing to allow charging.
> >
On Thu, Feb 14, 2019 at 04:05:26PM +0100, Hans de Goede wrote:
> Hi,
>
> On 14-02-19 15:15, Yauhen Kharuzhy wrote:
> >
> >
> > чц, 14 лют 2019, 15.47: карыстальнік Andy Shevchenko
> > > <mailto:andriy.shevche...@linux.intel.com>> напісаў:
> >
ates patterns
b) blinking/breathing patterns are generated by the software
entirely.
It seems that we sometimes confuse this two kinds of hw control definitions
in the discussion.
The simple use case question: with this hardware and existing LED class
API, what user/app should to do to make LED breathing with hw-generated
pattern?
As I see, user should activate 'pattern' trigger and write to its hw_pattern
attribute...
hm... big pattern which describes every step of breathing? Some
simplified pattern which should be interpreted as 'enable the breathing
an set its frequency' by driver? Which level of simplification will be
suitable? Which criteria of pattern rejection should be?
--
Yauhen Kharuzhy
On Fri, Feb 15, 2019 at 10:43:17PM +0100, Jacek Anaszewski wrote:
> Hi Yauhen,
>
> On 2/15/19 8:27 AM, Yauhen Kharuzhy wrote:
> > On Fri, Feb 15, 2019 at 12:03:07AM +0100, Pavel Machek wrote:
> > > Hi!
> > >
> > > > > > > I suggest
On Fri, Feb 15, 2019 at 09:32:50AM +0300, Yauhen Kharuzhy wrote:
> On Thu, Feb 14, 2019 at 05:31:48PM +0100, Hans de Goede wrote:
> > Hi,
> >
> > On 10-02-19 21:36, Yauhen Kharuzhy wrote:
> > > In some configuration external charge "#charge enable" s
dev_pm_clear_wake_irq(>dev);
> device_init_wakeup(>dev, false);
>
> + client->irq = 0;
> +
> return status;
> }
>
--
Yauhen Kharuzhy
On Thu, Jan 10, 2019 at 01:32:36PM +, Charles Keepax wrote:
> On Thu, Jan 10, 2019 at 12:47:56AM +0300, Yauhen Kharuzhy wrote:
> > On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote:
> > > The IRQ will be mapped in i2c_device_probe only if c
57 matches
Mail list logo
