Re: [PATCH] net: hns: avoid uninitialized variable warning:

在 2016/1/2 6:27, Arnd Bergmann 写道: > gcc fails to see that the use of the 'last_offset' variable > in hns_nic_reuse_page() is used correctly and issues a bogus > warning: > > drivers/net/ethernet/hisilicon/hns/hns_enet.c: In function > 'hns_nic_reuse_page': >

[PATCH v4 net-next 04/13] net: hisilicon: add support of acpi for hns-mdio

quence by _RST method in DSDT in ACPI case. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v2: 1. use dev_of_node instead of IS_ENABLED macro 2. Add ACPI bits v1: first submit Link: https://lk

[PATCH v4 net-next 03/13] net: hisilicon: cleanup to prepare for other cases

From: Kejian Yan <yankej...@huawei.com> Hns-mdio only supports DT case now. do some cleanup to prepare for introducing other cases later, no functional change. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change

[PATCH v4 net-next 00/13] net: hns: add support of ACPI

From: Kejian Yan This series adds HNS support of acpi. The routine will call some ACPI helper functions, like acpi_dev_found() and acpi_evaluate_dsm(), which are not included in other cases. In order to make system compile successfully in other cases except ACPI, it needs

[PATCH v4 net-next 06/13] net: hns: use platform_get_irq instead of irq_of_parse_and_map

From: Kejian Yan <yankej...@huawei.com> As irq_of_parse_and_map is only used by DT case, it is excepted to use a uniform interface. So it is used platform_get_irq() instead. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com>

[PATCH v4 net-next 09/13] net: hns: add dsaf misc operation method

uawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 4 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 6 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 14 ++-- drivers/net/ethernet/hisilicon/hns/hn

[PATCH v4 net-next 07/13] net: hns: enet specify a reference to dsaf by fwnode_handle

From: Kejian Yan <yankej...@huawei.com> As device_node is only used by DT case, it is expected to find uniform ways. So fwnode_handle is the suitable method. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- chang

[PATCH v4 net-next 12/13] net: hns: implement the miscellaneous operation by asl

From: Kejian Yan <yankej...@huawei.com> The miscellaneous operation is implemented in BIOS, the kernel can call _DSM method help to call the implementation in ACPI case. Here is a patch to do that. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuan

[PATCH v4 net-next 08/13] net: hns: add uniform interface for phy connection

needs to use uniform interface to handle that sequence by both DT and ACPI. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v2: 1. remove the redundant functions, and 2. adds fwnode match method beside DT and

[PATCH v4 net-next 13/13] net: hns: net: hns: enet adds support of acpi

From: Kejian Yan <yankej...@huawei.com> Enet needs to get configration parameter by acpi. This patch adds support of ACPI for enet. The configuration parameter will be configed in BIOS. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zh

[PATCH v4 net-next 11/13] net: hns: register phy device in each mac initial sequence

PHY PHY Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v2: fix the build error by kbuild test robot v1: first submit link: https://lkml.org/lkml/2016/5/13/97 --- drivers/net/ethernet/hisilicon/hns/hn

[PATCH v4 net-next 01/13] ACPI: bus: add stub acpi_dev_found() to linux/acpi.h

acpi.h to make compiled successfully in non-ACPI cases. Cc: Rafael J. Wysocki <r...@rjwysocki.net> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- include/linux/acpi.h | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v4 net-next 10/13] net: hns: dsaf adds support of acpi

From: Kejian Yan <yankej...@huawei.com> Dsaf needs to get configuration parameter by ACPI, so this patch add support of ACPI. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v2: 1. use dev_of_node() ins

[PATCH v4 net-next 05/13] net: hns: use device_* APIs instead of of_* APIs

From: Kejian Yan <yankej...@huawei.com> OF series functions can be used only for DT case. Use unified device property function instead to support both DT and ACPI. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- dr

[PATCH v4 net-next 02/13] ACPI: bus: add stub acpi_evaluate_dsm() to linux/acpi.h

o make compiled successfully in non-ACPI cases. Cc: Rafael J. Wysocki <r...@rjwysocki.net> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- include/linux/acpi.h | 8 1 file changed, 8 insertions(+) diff --git a/includ

[PATCH] net: hns: update the dependency

From: Kejian Yan <yankej...@huawei.com> After the patchset about adding support of ACPI (commit id is 6343488) being applied, HNS does not depend on OF. It depends on OF or ACPI, so the Kconfig file needs to be updated. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by:

Re: [patch net-next] net: hns: add skb_reset_mac_header() after skb being alloc

Hi David, Thanks for your suggestions. Please see my comments below. Thanks, Yisen 在 2016/6/15 13:41, David Miller 写道: > From: Yisen Zhuang <yisen.zhu...@huawei.com> > Date: Mon, 13 Jun 2016 20:41:22 +0800 > >> From: Kejian Yan <yankej...@huawei.com> >> >&

Re: [PATCH] net: hns: update the dependency

Hi David, I'm really sorry for this. Because i didn't receive the first two emails, i resented it a few times. I will pay more attention next time. Thanks, Yisen 在 2016/6/15 14:24, David Miller 写道: > From: Yisen Zhuang <yisen.zhu...@huawei.com> > Date: Wed, 15 Jun 2016 14

Re: [PATCH] net: hns: update the dependency

Hi David, You mean that i send this patch 3 times? I am sorry for this. I don't know why you can receive 3 times. I can only receive an email for this patch. Thanks, Yisen 在 2016/6/15 13:26, David Miller 写道: > From: Yisen Zhuang <yisen.zhu...@huawei.com> > Date: Mon, 13 Jun 2

[patch net-next] net: hns: add skb_reset_mac_header() after skb being alloc

From: Kejian Yan <yankej...@huawei.com> HNS receives a packet without doing anything, but it should call skb_reset_mac_header() to initialize the header before using eth_hdr(). Fixes: 0d6b425a3773c3445b0f51b2f333821beaacb619 Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-o

[PATCH] net: hns: update the dependency

From: Kejian Yan <yankej...@huawei.com> After the patchset about adding support of ACPI (commit id is 6343488) being applied, HNS does not depend on OF. It depends on OF or ACPI, so the Kconfig file needs to be updated. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by:

[PATCH] net: hns: update the dependency

From: Kejian Yan <yankej...@huawei.com> After the patchset about adding support of ACPI (commit id is 6343488) being applied, HNS does not depend on OF. It depends on OF or ACPI, so the Kconfig file needs to be updated. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by:

[PATCH v3 net-next 12/13] net: hns: implement the miscellaneous operation by asl

;andriy.shevche...@linux.intel.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v3: fix potential memory leak add Reviewed-by: Andy Shevchenko v2: use a serial function to implement the reset sequence link: https://lkml.org/lkml/2016/5/29/186 v1: fi

[PATCH v3 net-next 08/13] net: hns: add uniform interface for phy connection

needs to use uniform interface to handle that sequence by both DT and ACPI. Signed-off-by: Kejian Yan <yankej...@huawei.com> Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v3: add Reviewed-

[PATCH v3 net-next 01/13] ACPI: bus: add stub acpi_dev_found() to linux/acpi.h

acpi.h to make compiled successfully in non-ACPI cases. Cc: Rafael J. Wysocki <r...@rjwysocki.net> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- include/linux/acpi.h | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v3 net-next 11/13] net: hns: register phy device in each mac initial sequence

PHY PHY Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v2: fix the build error by kbuild test robot v1: first submit link: https://lkml.org/lkml/2016/5/13/97 --- drivers/net/ethernet/hisilicon/hns/hn

[PATCH v3 net-next 04/13] net: hisilicon: add support of acpi for hns-mdio

quence by _RST method in DSDT in ACPI case. Signed-off-by: Kejian Yan <yankej...@huawei.com> Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v3: add Reviewed-by: Andy Shevchenko v2:

[PATCH v3 net-next 02/13] ACPI: bus: add stub acpi_evaluate_dsm() to linux/acpi.h

o make compiled successfully in non-ACPI cases. Cc: Rafael J. Wysocki <r...@rjwysocki.net> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- include/linux/acpi.h | 8 1 file changed, 8 insertions(+) diff --git a/includ

[PATCH v3 net-next 05/13] net: hns: use device_* APIs instead of of_* APIs

From: Kejian Yan <yankej...@huawei.com> OF series functions can be used only for DT case. Use unified device property function instead to support both DT and ACPI. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- dr

[PATCH v3 net-next 10/13] net: hns: dsaf adds support of acpi

From: Kejian Yan <yankej...@huawei.com> Dsaf needs to get configuration parameter by ACPI, so this patch add support of ACPI. Signed-off-by: Kejian Yan <yankej...@huawei.com> Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Signed-off-by: Yisen Zhuang <yi

[PATCH v3 net-next 00/13] net: hns: add support of ACPI

From: Kejian Yan This series adds HNS support of acpi. The routine will call some ACPI helper functions, like acpi_dev_found() and acpi_evaluate_dsm(), which are not included in other cases. In order to make system compile successfully in other cases except ACPI, it needs

[PATCH v3 net-next 13/13] net: hns: net: hns: enet adds support of acpi

From: Kejian Yan <yankej...@huawei.com> Enet needs to get configration parameter by acpi. This patch adds support of ACPI for enet. The configuration parameter will be configed in BIOS. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zh

[PATCH v3 net-next 07/13] net: hns: enet specify a reference to dsaf by fwnode_handle

From: Kejian Yan <yankej...@huawei.com> As device_node is only used by DT case, it is expected to find uniform ways. So fwnode_handle is the suitable method. Signed-off-by: Kejian Yan <yankej...@huawei.com> Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Si

[PATCH v3 net-next 09/13] net: hns: add dsaf misc operation method

uawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 4 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 6 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 14 ++-- drivers/net/ethernet/hisilicon/hns/hn

[PATCH v3 net-next 06/13] net: hns: use platform_get_irq instead of irq_of_parse_and_map

From: Kejian Yan <yankej...@huawei.com> As irq_of_parse_and_map is only used by DT case, it is excepted to use a uniform interface. So it is used platform_get_irq() instead. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com>

[PATCH v3 net-next 03/13] net: hisilicon: cleanup to prepare for other cases

From: Kejian Yan <yankej...@huawei.com> Hns-mdio only supports DT case now. do some cleanup to prepare for introducing other cases later, no functional change. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- dr

Re: [PATCH v3 net-next 03/13] net: hisilicon: cleanup to prepare for other cases

Hi David, Thanks for your comment, i will use dev name of this mdio bus instead of address. Thanks, Yisen 在 2016/6/2 7:07, David Miller 写道: > From: Yisen Zhuang <yisen.zhu...@huawei.com> > Date: Mon, 30 May 2016 20:34:14 +0800 > >> -static void hns_mdio_bus_na

Re: [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable

在 2016/6/21 21:25, Sergei Shtylyov 写道: > Hello. > > On 6/21/2016 6:56 AM, Yisen Zhuang wrote: > >> From: Jun He <hjat2...@huawei.com> >> >> When hns_nic_poll_rx_skb alloc skb fail, it will break receive cycle and >> read new fbd_num to start

Re: [PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

在 2016/6/21 18:32, Andy Shevchenko 写道: > On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote: >> From: Daode Huang <huangda...@hisilicon.com> >> >> For SoC hip06, PFC pause handled in dsaf, while hip05 in XGMAC, >> so change the statistics of pfc pause in dsa

Re: [PATCH net-next 01/19] net: hns: bug fix of ge reset sequence

在 2016/6/21 18:35, Andy Shevchenko 写道: > On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote: >> From: Qianqian Xie <xieqianq...@huawei.com> >> >> The bit fileds of PPE reset register are different between HNS v1 and >> HNS v2, but the current proce

Re: [patch net-next] net: hns: add skb_reset_mac_header() after skb being alloc

在 2016/6/15 18:30, Yisen Zhuang 写道: > Hi David, > > Thanks for your suggestions. > > Please see my comments below. > > Thanks, > > Yisen > > 在 2016/6/15 13:41, David Miller 写道: >> From: Yisen Zhuang <yisen.zhu...@huawei.com> >> Date: Mon,

Re: [PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

在 2016/6/22 17:41, Andy Shevchenko 写道: > On Wed, 2016-06-22 at 09:43 +0800, Yisen Zhuang wrote: >> >> 在 2016/6/21 18:32, Andy Shevchenko 写道: >>> On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote: >>>> From: Daode Huang <huangda...@hisilicon.com>

[PATCH net-next 13/19] net: hns: add get_coalesce_range api for hns

From: Daode Huang <huangda...@hisilicon.com> This patch adds get_coalesce_range api for hns, it shows range of coalesce usecs and frames that can be set on this interface. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com>

[PATCH net-next 11/19] net: hns: add spin lock for tcam table operation

From: Daode Huang <huangda...@hisilicon.com> This patch adds spin lock for tcam table operation, there maybe a race condition happens when more than one thread try to change the tcam talbe entries. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuan

[PATCH net-next 09/19] net: hns: fix the wrong speed for bond

value at that time.That make for bond's wrong speed. Thus only one state machine should be used and if phy_state_machine is used, it does not need to do hns_nic_update_link_status(). Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com>

[PATCH net-next 14/19] net: hns: delete redundancy ring enable operations

t;huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hnae.c | 1 - drivers/net/ethernet/hisilicon/hns/hnae.h | 1 - drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 22 +- dr

[PATCH net-next 08/19] net: hns: fix ethtool loopback fail bug

right status. Reported-by: hejun <hjat2...@huawei.com> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 35 ++-- 1 file changed, 14 insertions(+), 21

[PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable

about the port unavailable. So we will goto out when alloc skb fail to fix this bug. Signed-off-by: Jun He <hjat2...@huawei.com> Signed-off-by: Ding Tianhong <dingtianh...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_

[PATCH net-next 06/19] net: hns: fix the error info when dma_set_mask_and_coherent fail

From: Qianqian Xie <xieqianq...@huawei.com> The error info should be printed as "set mask to 64bit fail!" instead of "set mask to 32bit fail!" in dma_set_mask_and_coherent(). Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yi

[PATCH net-next 05/19] net: hns: Remove unnecessary device resource free

From: Qianqian Xie <xieqianq...@huawei.com> The driver uses devm_ioremap_resource, it will unmap the map automatically, remove the unnecessary the resource free. Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Reported-by: Kefeng Wang <wangkefeng.w...@huawei.com> Signed-of

[PATCH net-next 17/19] net: hns: fix sbm default parameters config error

; Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 40 ++ drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h | 16 +++-- 2 files changed, 39 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethe

[PATCH net-next 19/19] net: hns: bug fix about TSO on|off when there is traffic

riptor. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ene

[PATCH net-next 04/19] net: hns: typo fix of annotation info for hns_nic_reset_subtask()

From: Qianqian Xie <xieqianq...@huawei.com> The annotation info for hns_nic_reset_subtask() should be "for resetting subtask" instead of "for resetting suntask". Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@hu

[PATCH net-next 15/19] net: hns: bug fix about led control logic when link down

blink frequece other than the driver itself. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff -

[PATCH net-next 02/19] net: hns: fix hns dsaf v1 dont support tx_pause close

From: Qianqian Xie <xieqiaq...@huawei.com> For service port, hns dsaf v1 support to close tx_pause. However, the port will be invalid when it run command ethtool to close tx_pause. This patch will fix it. Signed-off-by: Qianqian Xie <xieqiaq...@huawei.com> Signed-off-by: Yisen Zhuan

[PATCH net-next 03/19] net: hns: add skb_reset_mac_header() after skb being alloc

From: Kejian Yan <yankej...@huawei.com> HNS receives a packet without doing anything, but it should call skb_reset_mac_header() to initialize the header before using eth_hdr(). Fixes: 0d6b425a3773c3445b0f51b2f333821beaacb619 Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-o

[PATCH net-next 07/19] net: hns: select Hilink before serdes loopback for HNS V2

uawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 26 +- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethe

[PATCH net-next 01/19] net: hns: bug fix of ge reset sequence

ie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethernet/hisilicon/h

[PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

From: Daode Huang <huangda...@hisilicon.com> For SoC hip06, PFC pause handled in dsaf, while hip05 in XGMAC, so change the statistics of pfc pause in dsaf and remove the old pfc pause frame statistics. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuan

[PATCH net-next 18/19] net: hns: change the default coalesce usecs

t;huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 2 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns

[PATCH net-next 12/19] net: hns: fix bug of getting the wrong tcam data

licon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns

[PATCH net-next 00/19] net: hns: fix some bugs in hns driver

This series includes some bugs fixed. All these patches needs to be applied after the patchset about ACPI support, so this series is floated to net-next list. The patches are: > from Daode, fixes about pfc pause frame, getting coaslesce, led control logic, TSO on|off and tcam table

Re: [PATCH] asm-generic: remove old nonatomic-io wrapper files

> drivers/dma/idma64.h| 2 +- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c | 2 +- The HNS portion: Acked-by: Yisen Zhuang <yisen.zhu...@huawei.com> > drivers/net/ethernet/netronome/nfp/nfp_net.h| 2 +- > include/asm-generic/io-64-nonatomic-hi-lo.h

Re: [PATCH net 01/10] net: hns: bug fix about ping6

在 2016/3/21 23:39, David Miller 写道: > From: Yisen Zhuang <yisen.zhu...@huawei.com> > Date: Mon, 21 Mar 2016 19:06:32 +0800 > >> From: Kejian Yan <yankej...@huawei.com> >> >> The current upstreaming code fails to ping other IPv6 net device, because >

Re: [PATCH net 09/10] net: hns: adds limitation for debug port mtu

在 2016/3/21 22:17, Sergei Shtylyov 写道: > Hello. > > On 03/21/2016 02:06 PM, Yisen Zhuang wrote: > >> From: Kejian Yan <yankej...@huawei.com> >> >> If mtu for debug port is set more than 1500, it may cause that packets >> are dropped by ppe. So m

Re: [PATCH net 06/10] net: hns: fix return value of the function about rss

在 2016/3/21 23:42, David Miller 写道: > From: Yisen Zhuang <yisen.zhu...@huawei.com> > Date: Mon, 21 Mar 2016 19:06:37 +0800 > >> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c >> b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c >> index 3c4a3bc

Re: [PATCH net 03/10] net: hns: add uc match for debug ports

在 2016/3/21 23:40, David Miller 写道: > From: Yisen Zhuang <yisen.zhu...@huawei.com> > Date: Mon, 21 Mar 2016 19:06:34 +0800 > >> +(void)hns_mac_set_promisc(mac_cb, (u8)!!en); > > This cast to void is unnecssary. I think hns_mac_set_promisc don't need to re

[PATCH V2 net 01/10] net: hns: bug fix about ping6

uawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: PATCH v2: - modifies the wrong charator "whick" to "which" in commit log - use the "eth_hdr()" help to get source mac of packets PATCH v1: - first submit Link: https://

[PATCH V2 net 04/10] net: hns: fixed the bug about GMACs mac setting

ervice ports. It obviously the condition needs to be deleted. Signed-off-by: Sheng Li <lisheng...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 18 -- 1 file changed, 8 insertions(+), 10 deleti

[PATCH V2 net 07/10] net: hns: fixes a bug of RSS

width of data type when using memcpy. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 6 -- drivers/ne

[PATCH V2 net 00/10] net: hns: bugs fixed for hns

This series includes some bug fixes and updates for hns driver. >from Daode, one fix about mss. >from Kejian, one fix about ping6 issue, one fix about mac address setting, two fix for RSS setting, two fix about mtu setting. >from qianqian, fixed HNS v2 xge statistic reg issue. >from Sheng, one

[PATCH V2 net 06/10] net: hns: fix return value of the function about rss

From: Kejian Yan <yankej...@huawei.com> Both .get_rxfh and .set_rxfh are always return 0, it should return result from hardware when getting or setting rss. And the rss function should return the correct data type. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by:

[PATCH V2 net 10/10] net: hns: bug fix about the overflow of mss

From: Daode Huang <huangda...@hisilicon.com> When set MTU to the minimum value 68, there are increasing number of error packets occur, which is caused by the overflowed value of mss. This patch fix the bug. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by:

[PATCH V2 net 08/10] net: hns: fix the bug about mtu setting

From: Kejian Yan <yankej...@huawei.com> In chip V1, the maximum mtu value is 9600. But in chip V2, it is 9728. And it is always configurates as 9600 before this patch. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- dr

[PATCH V2 net 05/10] net: hns: set xge statistic reg as read only

ightly. Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mai

[PATCH V2 net 02/10] net: hns: fixed portid bug in sending manage pkt

, when sending mamagement packets, the driver should config the port id to BD descs. Signed-off-by: Sheng Li <lisheng...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hnae.h | 3 +++ drivers/net/ethernet/hisilicon/hns/

[PATCH V2 net 09/10] net: hns: adds limitation for debug port mtu

From: Kejian Yan <yankej...@huawei.com> If mtu for debug port is set more than 1500, it may cause that packets are dropped by ppe. So maximum value for debug port should be 1500. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com&

[PATCH V2 net 03/10] net: hns: add uc match for debug ports

local addr in mac table. And the switch is ON in initialization. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Peng Li <lipeng...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: PATCH v2: - fix the comments like unne

[PATCH net 0/7] net: hns: fix some bugs in HNS driver

Here are some bug fixed patches for HNS driver. They are: >from Kejian, fix for the warning of passing zero to 'PTR_ERR' >from qianqian, four fixes for inappropriate operation in hns driver >from Sheng, one fix for optimization of irq proccess in hns driver, and one fix for hilink status for

[PATCH net 4/7] net: hns: remove useless variable assignment and comment

; Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c index 71aa3

[PATCH net 2/7] net: hns: optimizate fmt of snprintf()

ring[i].desc); Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) dif

[PATCH net 6/7] net: hns: fix warning of passing zero to 'PTR_ERR'

yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c in

[PATCH net 7/7] net: hns: bug fix about getting hilink status for HNS v2

From: Sheng Li The hilink status reg in HNS V2 is different from HNS v1. In HNS V2, It distinguishes differnt lane status according to the bit-field of the reg. As is shown below: [0:0] ---> lane0 [1:1] ---> lane1 ... But the current driver reads the reg to get the hilink

[PATCH net 5/7] net: hns: optimizate irq proccess for HNS V2

s to NULL. Signed-off-by: Sheng Li <lisheng...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b

[PATCH net 1/7] net: hns: fix a bug for cycle index

From: Qianqian Xie <xieqianq...@huawei.com> The cycle index should be varied while the variable j is a fixed value. The patch will fix this bug. Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethe

[PATCH net 3/7] net: hns: bug fix for return values

From: Qianqian Xie <xieqianq...@huawei.com> The return values in the first two functions mdiobus_write() are ignored. The patch will fix it. Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethe

[PATCH net 02/10] net: hns: fixed portid bug in sending manage pkt

, when sending mamagement packets, the driver should config the port id to BD descs. Signed-off-by: Sheng Li <lisheng...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hnae.h | 3 +++ drivers/net/ethernet/hisilicon/hns/

[PATCH net 04/10] net: hns: fixed the bug about GMACs mac setting

ervice ports. It obviously the condition needs to be deleted. Signed-off-by: Sheng Li <lisheng...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 18 -- 1 file changed, 8 insertions(+), 10 deleti

[PATCH net 05/10] net: hns: set xge statistic reg as read only

ightly. Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mai

[PATCH net 07/10] net: hns: fixes a bug of RSS

width of data type when using memcpy. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 6 -- drivers/ne

[PATCH net 08/10] net: hns: fix the bug about mtu setting

From: Kejian Yan <yankej...@huawei.com> In chip V1, the maximum mtu value is 9600. But in chip V2, it is 9728. And it is always configurates as 9600 before this patch. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- dr

[PATCH net 10/10] net: hns: bug fix about the overflow of mss

From: Daode Huang <huangda...@hisilicon.com> When set MTU to the minimum value 68, there are increasing number of error packets occur, which is caused by the overflowed value of mss. This patch fix the bug. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by:

[PATCH net 09/10] net: hns: adds limitation for debug port mtu

From: Kejian Yan <yankej...@huawei.com> If mtu for debug port is set more than 1500, it may cause that packets are dropped by ppe. So maximum value for debug port should be 1500. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.co

[PATCH net 01/10] net: hns: bug fix about ping6

uawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c index 3f77f

[PATCH net 06/10] net: hns: fix return value of the function about rss

From: Kejian Yan <yankej...@huawei.com> Both .get_rxfh and .get_rxfh are always return 0, it should return result from hardware when getting or setting rss. And the rss function should return the correct data type. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by:

[PATCH net 00/10] net: hns: bugs fixed for hns

This series includes some bug fixes and updates for hns driver. >from Daode, one fix about mss. >from Kejian, one fix about ping6 issue, one fix about mac address setting, two fix for RSS setting, two fix about mtu setting. >from qianqian, fixed HNS v2 xge statistic reg issue. >from Sheng, one

[PATCH net 03/10] net: hns: add uc match for debug ports

local addr in mac table. And the switch is ON in initialization. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Peng Li <lipeng...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 3 +

[PATCH net-next] net: hns: add support of pause frame ctrl for HNS V2

pdated status function called by upper layer routine. Signed-off-by: Lisheng <lisheng...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 21 ++- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 30 +++-

[PATCH net-next 1/2] net: hns: fixed the setting and getting overtime bug

From: Lisheng <lisheng...@huawei.com> The overtime setting and getting REGs in HNS V2 is defferent from HNS V1. It needs to be distinguished between them if getting or setting the REGs. Signed-off-by: Lisheng <lisheng...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zh

[PATCH net-next 0/2] net: hns: add setting coalescing parameters for HNS v2

There are some different REGs about coalescing setting between HNS V2 and HNS V1. The current HNS driver is only considering the situation for HNS V1. It needs to support both of them. And Ethtool needs to know if it is successful to set the parameters as well. The patchset as below: >from

  1   2   3   >