RE: [PATCH v3 08/10] x86/head64.c: Early update ucode in 64-bit

2012-12-17 Thread Yu, Fenghua
> -Original Message- > From: yhlu.ker...@gmail.com [mailto:yhlu.ker...@gmail.com] On Behalf Of > Yinghai Lu > Sent: Sunday, December 16, 2012 4:42 PM > To: Yu, Fenghua > Cc: H. Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; > Tigran Aivazian; Andre

RE: [PATCH v3 08/10] x86/head64.c: Early update ucode in 64-bit

2012-12-17 Thread Yu, Fenghua
-Original Message- From: yhlu.ker...@gmail.com [mailto:yhlu.ker...@gmail.com] On Behalf Of Yinghai Lu Sent: Sunday, December 16, 2012 4:42 PM To: Yu, Fenghua Cc: H. Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borislav Petkov

RE: [PATCH v3 08/10] x86/head64.c: Early update ucode in 64-bit

2012-12-17 Thread Yu, Fenghua
it has to be after #PF handler set page table patch... otherwise when ramdisk is above 1G, customer will get early PF exception. In old kernel, where can I put load_ucode_bsp()? Is calling load_ucode_bsp() after relocate_initrd() earliest place? Thanks. -Fenghua -- To unsubscribe from

RE: [PATCH v3 08/10] x86/head64.c: Early update ucode in 64-bit

2012-12-16 Thread Yu, Fenghua
> -Original Message- > From: yhlu.ker...@gmail.com [mailto:yhlu.ker...@gmail.com] On Behalf Of > Yinghai Lu > Sent: Sunday, December 16, 2012 6:02 PM > To: Yu, Fenghua > Cc: H. Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; > Tigran Aivazian; Andre

RE: [PATCH v3 08/10] x86/head64.c: Early update ucode in 64-bit

2012-12-16 Thread Yu, Fenghua
> -Original Message- > From: yhlu.ker...@gmail.com [mailto:yhlu.ker...@gmail.com] On Behalf Of > Yinghai Lu > Sent: Sunday, December 16, 2012 9:59 AM > To: Yu, Fenghua > Cc: H Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; > Tigran Aivazian; Andreas Herr

RE: [PATCH v3 04/10] x86/microcode_core_early.c: Define interfaces for early loading ucode

2012-12-16 Thread Yu, Fenghua
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Sunday, December 16, 2012 9:57 AM > To: Yu, Fenghua > Cc: H Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; > Tigran Aivazian; Andreas Herrmann; Borislav Petkov; Yinghai Lu; li

RE: [PATCH v3 04/10] x86/microcode_core_early.c: Define interfaces for early loading ucode

2012-12-16 Thread Yu, Fenghua
-Original Message- From: Borislav Petkov [mailto:b...@alien8.de] Sent: Sunday, December 16, 2012 9:57 AM To: Yu, Fenghua Cc: H Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borislav Petkov; Yinghai Lu; linux- kernel; x86 Subject: Re

RE: [PATCH v3 08/10] x86/head64.c: Early update ucode in 64-bit

2012-12-16 Thread Yu, Fenghua
-Original Message- From: yhlu.ker...@gmail.com [mailto:yhlu.ker...@gmail.com] On Behalf Of Yinghai Lu Sent: Sunday, December 16, 2012 9:59 AM To: Yu, Fenghua Cc: H Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borislav Petkov; linux

RE: [PATCH v3 08/10] x86/head64.c: Early update ucode in 64-bit

2012-12-16 Thread Yu, Fenghua
-Original Message- From: yhlu.ker...@gmail.com [mailto:yhlu.ker...@gmail.com] On Behalf Of Yinghai Lu Sent: Sunday, December 16, 2012 6:02 PM To: Yu, Fenghua Cc: H. Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borislav Petkov

RE: [tip:x86/microcode] x86/microcode_intel_early.c: Early update ucode on Intel's CPU

2012-12-11 Thread Yu, Fenghua
> -Original Message- > From: yhlu.ker...@gmail.com [mailto:yhlu.ker...@gmail.com] On Behalf Of > Yinghai Lu > Sent: Tuesday, December 11, 2012 9:16 AM > To: Borislav Petkov; Yinghai Lu; H. Peter Anvin; Yu, Fenghua; > mi...@kernel.org; linux-kernel@vger.kernel.org; t...@

RE: [tip:x86/microcode] x86/microcode_intel_early.c: Early update ucode on Intel's CPU

2012-12-11 Thread Yu, Fenghua
-Original Message- From: yhlu.ker...@gmail.com [mailto:yhlu.ker...@gmail.com] On Behalf Of Yinghai Lu Sent: Tuesday, December 11, 2012 9:16 AM To: Borislav Petkov; Yinghai Lu; H. Peter Anvin; Yu, Fenghua; mi...@kernel.org; linux-kernel@vger.kernel.org; t...@linutronix.de; h

RE: [tip:x86/microcode] x86/microcode_intel_early.c: Early update ucode on Intel's CPU

2012-12-03 Thread Yu, Fenghua
> From: yhlu.ker...@gmail.com [mailto:yhlu.ker...@gmail.com] On Behalf Of > Yinghai Lu > On Fri, Nov 30, 2012 at 4:25 PM, tip-bot for Fenghua Yu > wrote: > > Commit-ID: 474355fe313391de2429ae225e0fb02f67ec6c31 > > Gitweb: > http://git.kernel.org/tip/474355fe313391de2429ae225e0fb02f67ec6c31 > >

RE: [tip:x86/microcode] x86/microcode_intel_early.c: Early update ucode on Intel's CPU

2012-12-03 Thread Yu, Fenghua
From: yhlu.ker...@gmail.com [mailto:yhlu.ker...@gmail.com] On Behalf Of Yinghai Lu On Fri, Nov 30, 2012 at 4:25 PM, tip-bot for Fenghua Yu fenghua...@intel.com wrote: Commit-ID: 474355fe313391de2429ae225e0fb02f67ec6c31 Gitweb: http://git.kernel.org/tip

RE: [PATCH v2 01/10] Documentation/x86: Early load microcode

2012-11-30 Thread Yu, Fenghua
> -Original Message- > From: H. Peter Anvin [mailto:h...@zytor.com] > Sent: Friday, November 30, 2012 11:46 AM > To: Yu, Fenghua > Cc: Ingo Molnar; Thomas Gleixner; Mallick, Asit K; Tigran Aivazian; > Andreas Herrmann; Borislav Petkov; linux-kernel; x86 > Subject

RE: [PATCH v2 01/10] Documentation/x86: Early load microcode

2012-11-30 Thread Yu, Fenghua
-Original Message- From: H. Peter Anvin [mailto:h...@zytor.com] Sent: Friday, November 30, 2012 11:46 AM To: Yu, Fenghua Cc: Ingo Molnar; Thomas Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borislav Petkov; linux-kernel; x86 Subject: Re: [PATCH v2 01/10

RE: [PATCH v9 12/12] x86, topology: Debug CPU00 hotplug

2012-10-18 Thread Yu, Fenghua
> From: Srivatsa S. Bhat [mailto:srivatsa.b...@linux.vnet.ibm.com] > Sent: Wednesday, October 17, 2012 11:43 PM > On 10/17/2012 05:36 AM, Yu, Fenghua wrote: > >>> +#ifdef CONFIG_DEBUG_HOTPLUG_CPU0 > > > +case PM_RESTORE_PREPARE: > >>> +

RE: [PATCH v9 12/12] x86, topology: Debug CPU00 hotplug

2012-10-18 Thread Yu, Fenghua
From: Srivatsa S. Bhat [mailto:srivatsa.b...@linux.vnet.ibm.com] Sent: Wednesday, October 17, 2012 11:43 PM On 10/17/2012 05:36 AM, Yu, Fenghua wrote: +#ifdef CONFIG_DEBUG_HOTPLUG_CPU0 +case PM_RESTORE_PREPARE: + /* + * When system resumes from hibernation

RE: [PATCH v9 05/12] x86, hotplug, suspend: Online CPU0 for suspend or hibernate

2012-10-17 Thread Yu, Fenghua
> From: Srivatsa S. Bhat [mailto:srivatsa.b...@linux.vnet.ibm.com] > On 10/16/2012 02:20 AM, Rafael J. Wysocki wrote: > > On Friday 12 of October 2012 09:09:42 Fenghua Yu wrote: > >> From: Fenghua Yu > >> > >> Because x86 BIOS requires CPU0 to resume from sleep, suspend or > hibernate can't > >>

RE: [PATCH v9 05/12] x86, hotplug, suspend: Online CPU0 for suspend or hibernate

2012-10-17 Thread Yu, Fenghua
> > > On Tuesday, October 16, 2012 10:19 PM Rafael J. Wysocki wrote: > On Tuesday 16 of October 2012 22:12:27 Yu, Fenghua wrote: > > > On 10/16/2012 09:47 PM, Rafael J. Wysocki wrote: > > > > On Tuesday 16 of October 2012 11:05:18 Srivatsa S. Bhat wrote: > >

RE: [PATCH v9 05/12] x86, hotplug, suspend: Online CPU0 for suspend or hibernate

2012-10-17 Thread Yu, Fenghua
On Tuesday, October 16, 2012 10:19 PM Rafael J. Wysocki wrote: On Tuesday 16 of October 2012 22:12:27 Yu, Fenghua wrote: On 10/16/2012 09:47 PM, Rafael J. Wysocki wrote: On Tuesday 16 of October 2012 11:05:18 Srivatsa S. Bhat wrote: On 10/16/2012 02:20 AM, Rafael J. Wysocki wrote

RE: [PATCH v9 05/12] x86, hotplug, suspend: Online CPU0 for suspend or hibernate

2012-10-17 Thread Yu, Fenghua
From: Srivatsa S. Bhat [mailto:srivatsa.b...@linux.vnet.ibm.com] On 10/16/2012 02:20 AM, Rafael J. Wysocki wrote: On Friday 12 of October 2012 09:09:42 Fenghua Yu wrote: From: Fenghua Yu fenghua...@intel.com Because x86 BIOS requires CPU0 to resume from sleep, suspend or hibernate can't

RE: [PATCH v9 12/12] x86, topology: Debug CPU00 hotplug

2012-10-16 Thread Yu, Fenghua
> > +#ifdef CONFIG_DEBUG_HOTPLUG_CPU0 > +case PM_RESTORE_PREPARE: > > + /* > > +* When system resumes from hibernation, online CPU0 > because > > +* 1. it's required for resume and > > +* 2. the CPU was online before hibernation > > +

RE: [PATCH v9 05/12] x86, hotplug, suspend: Online CPU0 for suspend or hibernate

2012-10-16 Thread Yu, Fenghua
> On 10/16/2012 09:47 PM, Rafael J. Wysocki wrote: > > On Tuesday 16 of October 2012 11:05:18 Srivatsa S. Bhat wrote: > >> On 10/16/2012 02:20 AM, Rafael J. Wysocki wrote: > >>> On Friday 12 of October 2012 09:09:42 Fenghua Yu wrote: > From: Fenghua Yu > > + > +/* > + *

RE: [PATCH v9 03/12] x86, topology: Don't offline CPU0 if any PIC irq can not be migrated out of it

2012-10-16 Thread Yu, Fenghua
> On Fri, Oct 12, 2012 at 09:09:40AM -0700, Fenghua Yu wrote: > > From: Fenghua Yu > > > > If CONFIG_BOOTPARAM_HOTPLUG_CPU is turned on, CPU0 hotplug feature is > enabled > > by default. > > > > If CONFIG_BOOTPARAM_HOTPLUG_CPU is not turned on, CPU0 hotplug > feature is not > > enabled by

RE: [PATCH v9 03/12] x86, topology: Don't offline CPU0 if any PIC irq can not be migrated out of it

2012-10-16 Thread Yu, Fenghua
On Fri, Oct 12, 2012 at 09:09:40AM -0700, Fenghua Yu wrote: From: Fenghua Yu fenghua...@intel.com If CONFIG_BOOTPARAM_HOTPLUG_CPU is turned on, CPU0 hotplug feature is enabled by default. If CONFIG_BOOTPARAM_HOTPLUG_CPU is not turned on, CPU0 hotplug feature is not enabled

RE: [PATCH v9 05/12] x86, hotplug, suspend: Online CPU0 for suspend or hibernate

2012-10-16 Thread Yu, Fenghua
On 10/16/2012 09:47 PM, Rafael J. Wysocki wrote: On Tuesday 16 of October 2012 11:05:18 Srivatsa S. Bhat wrote: On 10/16/2012 02:20 AM, Rafael J. Wysocki wrote: On Friday 12 of October 2012 09:09:42 Fenghua Yu wrote: From: Fenghua Yu fenghua...@intel.com + +/* + * When bsp_check

RE: [PATCH v9 12/12] x86, topology: Debug CPU00 hotplug

2012-10-16 Thread Yu, Fenghua
+#ifdef CONFIG_DEBUG_HOTPLUG_CPU0 +case PM_RESTORE_PREPARE: + /* +* When system resumes from hibernation, online CPU0 because +* 1. it's required for resume and +* 2. the CPU was online before hibernation +*/ +

RE: [PATCH v1 0/2] x86, apic: Disable BSP if boot cpu is AP

2012-10-15 Thread Yu, Fenghua
> >> My motivation is to use multiple CPUs in order to quickly generate > >> crash dump on the machine with huge amount of memory. I assume such > >> machine tends to also have a lot of CPUs. So disabling one CPU would > >> be no problem. > > > > Luckily you don't need to disable any CPU to

RE: [PATCH v1 0/2] x86, apic: Disable BSP if boot cpu is AP

2012-10-15 Thread Yu, Fenghua
> -Original Message- > From: HATAYAMA Daisuke [mailto:d.hatay...@jp.fujitsu.com] > Sent: Monday, October 15, 2012 9:35 PM > To: linux-kernel@vger.kernel.org; ke...@lists.infradead.org; > x...@kernel.org > Cc: mi...@elte.hu; t...@linutronix.de; h...@zytor.com; Brown, Len;

RE: [PATCH v1 0/2] x86, apic: Disable BSP if boot cpu is AP

2012-10-15 Thread Yu, Fenghua
-Original Message- From: HATAYAMA Daisuke [mailto:d.hatay...@jp.fujitsu.com] Sent: Monday, October 15, 2012 9:35 PM To: linux-kernel@vger.kernel.org; ke...@lists.infradead.org; x...@kernel.org Cc: mi...@elte.hu; t...@linutronix.de; h...@zytor.com; Brown, Len; Yu, Fenghua; vgo

RE: [PATCH v1 0/2] x86, apic: Disable BSP if boot cpu is AP

2012-10-15 Thread Yu, Fenghua
My motivation is to use multiple CPUs in order to quickly generate crash dump on the machine with huge amount of memory. I assume such machine tends to also have a lot of CPUs. So disabling one CPU would be no problem. Luckily you don't need to disable any CPU to archive your goal with

RE: [PATCH 00/11] x86/microcode: Early load microcode

2012-10-02 Thread Yu, Fenghua
> On Tue, Oct 2, 2012 at 2:06 AM, H. Peter Anvin wrote: > > On 10/01/2012 09:27 AM, Borislav Petkov wrote: > >> > >> On Mon, Oct 01, 2012 at 12:11:51PM -0400, Jamie Gloudon wrote: > >>> > >>> Hey, > >>> > >>>Any chance of this getting merge for the 3.7 cycle? > >> > >> > >> It is not ready

RE: [PATCH 00/11] x86/microcode: Early load microcode

2012-10-02 Thread Yu, Fenghua
On Tue, Oct 2, 2012 at 2:06 AM, H. Peter Anvin h...@zytor.com wrote: On 10/01/2012 09:27 AM, Borislav Petkov wrote: On Mon, Oct 01, 2012 at 12:11:51PM -0400, Jamie Gloudon wrote: Hey, Any chance of this getting merge for the 3.7 cycle? It is not ready yet:

RE: [PATCH v7 02/12] x86/Kconfig: Add config switch for CPU0 hotplug

2012-08-24 Thread Yu, Fenghua
> And, btw, maybe I didn't catch this earlier, but why is in all > user-visible options the thing called "cpu0_*"? Wouldn't it be better > to > call it "bsp_*"? The kernel parameter was called bsp_hotplug before. It was changed to cpu0_hotplug in v5 to keep uniform cpu0/CPU0 names. Thanks.

RE: [PATCH v7 02/12] x86/Kconfig: Add config switch for CPU0 hotplug

2012-08-24 Thread Yu, Fenghua
And, btw, maybe I didn't catch this earlier, but why is in all user-visible options the thing called cpu0_*? Wouldn't it be better to call it bsp_*? The kernel parameter was called bsp_hotplug before. It was changed to cpu0_hotplug in v5 to keep uniform cpu0/CPU0 names. Thanks. -Fenghua

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread Yu, Fenghua
> -Original Message- > From: H. Peter Anvin [mailto:h...@zytor.com] > Sent: Tuesday, August 21, 2012 1:54 PM > To: Yu, Fenghua > Cc: Borislav Petkov; Henrique de Moraes Holschuh; Ingo Molnar; Thomas > Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borisl

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread Yu, Fenghua
> -Original Message- > From: Borislav Petkov [mailto:b...@amd64.org] > Sent: Tuesday, August 21, 2012 1:49 PM > To: H. Peter Anvin > Cc: Yu, Fenghua; Henrique de Moraes Holschuh; Ingo Molnar; Thomas > Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borisl

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread Yu, Fenghua
> -Original Message- > From: Borislav Petkov [mailto:b...@amd64.org] > Sent: Monday, August 20, 2012 1:20 PM > To: H. Peter Anvin > Cc: Yu, Fenghua; Henrique de Moraes Holschuh; Ingo Molnar; Thomas > Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borisl

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread Yu, Fenghua
-Original Message- From: Borislav Petkov [mailto:b...@amd64.org] Sent: Monday, August 20, 2012 1:20 PM To: H. Peter Anvin Cc: Yu, Fenghua; Henrique de Moraes Holschuh; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borislav Petkov; linux-kernel

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread Yu, Fenghua
-Original Message- From: Borislav Petkov [mailto:b...@amd64.org] Sent: Tuesday, August 21, 2012 1:49 PM To: H. Peter Anvin Cc: Yu, Fenghua; Henrique de Moraes Holschuh; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borislav Petkov; linux-kernel

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread Yu, Fenghua
-Original Message- From: H. Peter Anvin [mailto:h...@zytor.com] Sent: Tuesday, August 21, 2012 1:54 PM To: Yu, Fenghua Cc: Borislav Petkov; Henrique de Moraes Holschuh; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borislav Petkov; linux-kernel

RE: [PATCH 00/11] x86/microcode: Early load microcode

2012-08-20 Thread Yu, Fenghua
> -Original Message- > From: Borislav Petkov [mailto:b...@amd64.org] > Sent: Monday, August 20, 2012 8:39 AM > To: Yu, Fenghua > Cc: H Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; > Tigran Aivazian; Andreas Herrmann; Borislav Petkov; linux-kernel; x86 >

RE: [PATCH 00/11] x86/microcode: Early load microcode

2012-08-20 Thread Yu, Fenghua
-Original Message- From: Borislav Petkov [mailto:b...@amd64.org] Sent: Monday, August 20, 2012 8:39 AM To: Yu, Fenghua Cc: H Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borislav Petkov; linux-kernel; x86 Subject: Re: [PATCH 00/11

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-19 Thread Yu, Fenghua
> -Original Message- > From: H. Peter Anvin [mailto:h...@zytor.com] > Sent: Saturday, August 18, 2012 10:25 PM > To: Yu, Fenghua > Cc: Henrique de Moraes Holschuh; Ingo Molnar; Thomas Gleixner; Mallick, > Asit K; Tigran Aivazian; Andreas Herrmann; Borislav Petkov; li

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-19 Thread Yu, Fenghua
-Original Message- From: H. Peter Anvin [mailto:h...@zytor.com] Sent: Saturday, August 18, 2012 10:25 PM To: Yu, Fenghua Cc: Henrique de Moraes Holschuh; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borislav Petkov; linux- kernel; x86 Subject

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-18 Thread Yu, Fenghua
> -Original Message- > From: Henrique de Moraes Holschuh [mailto:h...@hmh.eng.br] > Sent: Saturday, August 18, 2012 3:45 PM > To: Yu, Fenghua > Cc: H Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; > Tigran Aivazian; Andreas Herrmann; Borislav Petkov;

RE: [PATCH 02/11] x86/lib/cpio.c: Find cpio data by its file name

2012-08-18 Thread Yu, Fenghua
> -Original Message- > From: Henrique de Moraes Holschuh [mailto:h...@hmh.eng.br] > Sent: Saturday, August 18, 2012 3:13 PM > To: Yu, Fenghua > Cc: H Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; > Tigran Aivazian; Andreas Herrmann; Borislav Petkov;

RE: [PATCH 02/11] x86/lib/cpio.c: Find cpio data by its file name

2012-08-18 Thread Yu, Fenghua
-Original Message- From: Henrique de Moraes Holschuh [mailto:h...@hmh.eng.br] Sent: Saturday, August 18, 2012 3:13 PM To: Yu, Fenghua Cc: H Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borislav Petkov; linux-kernel; x86 Subject: Re

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-18 Thread Yu, Fenghua
-Original Message- From: Henrique de Moraes Holschuh [mailto:h...@hmh.eng.br] Sent: Saturday, August 18, 2012 3:45 PM To: Yu, Fenghua Cc: H Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borislav Petkov; linux-kernel; x86 Subject: Re

RE: [PATCH] Fix uninitialized local variable "covered" in i386 acpi-cpufreq driver

2007-07-26 Thread Yu, Fenghua
>> How's that for a one-liner? ;) >- the return value from acpi_cpufreq_early_init() gets ignored, > so the module will still load, but won't work. >- Once that is fixed, the test for !acpi_perf_data[cpu] in > acpi_cpufreq_cpu_init() can be removed. We will modify code in those places. - To

RE: [PATCH] Fix uninitialized local variable covered in i386 acpi-cpufreq driver

2007-07-26 Thread Yu, Fenghua
How's that for a one-liner? ;) - the return value from acpi_cpufreq_early_init() gets ignored, so the module will still load, but won't work. - Once that is fixed, the test for !acpi_perf_data[cpu] in acpi_cpufreq_cpu_init() can be removed. We will modify code in those places. - To

RE: BUG: sleeping function called from invalid context at kernel/fork.c:385

2007-05-30 Thread Yu, Fenghua
> Saw this when running strace -f on a script on 2.6.21 on ia64 Run strace -f on 2.6.22-rc3 on Tiger4/Montecito. Couldn't reproduce this issue. Kernel was built with both defconfig and tiger_defconfig. Thanks. -Fenghua - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

RE: BUG: sleeping function called from invalid context at kernel/fork.c:385

2007-05-30 Thread Yu, Fenghua
Saw this when running strace -f on a script on 2.6.21 on ia64 Run strace -f on 2.6.22-rc3 on Tiger4/Montecito. Couldn't reproduce this issue. Kernel was built with both defconfig and tiger_defconfig. Thanks. -Fenghua - To unsubscribe from this list: send the line unsubscribe linux-kernel in the

RE: [PATCH 1/2] Define new percpu interface for shared data -- version 3

2007-05-25 Thread Yu, Fenghua
>What's "shared percpu data" ? It sounds to me like a contradiction in >terms. Isn't percpu data supposed to only be accessed by the CPU which >owns it to prevent cache line bouncing? In which case, what's the point >of sharing that data with other CPUs? Surely "shared percpu data" is >just

RE: [PATCH 1/2] Define new percpu interface for shared data -- version 3

2007-05-25 Thread Yu, Fenghua
What's shared percpu data ? It sounds to me like a contradiction in terms. Isn't percpu data supposed to only be accessed by the CPU which owns it to prevent cache line bouncing? In which case, what's the point of sharing that data with other CPUs? Surely shared percpu data is just the same as

RE: [PATCH 1/2] Define new percpu interface for shared data -- version 3

2007-05-23 Thread Yu, Fenghua
>> So what we have now is space wastage on some architectures, space savings on >> some, but with no measurable performance benefit due to the infrastructure >> itself. Why not push the infrastructure when we really need it, as against >> pushing it now when we are not sure if it benefits? >

RE: [PATCH 1/2] Define new percpu interface for shared data -- version 3

2007-05-23 Thread Yu, Fenghua
>Has there been any measurable benefit yet due to tail padding? We don't have data that tail padding actually helps. It all depends on what data the linker lays out in the cachelines. As of now we just want to create the infrastructure (so that more and more people who need it, can use it).

RE: [PATCH 1/2] Define new percpu interface for shared data -- version 3

2007-05-23 Thread Yu, Fenghua
> elements are cacheline aligned. And as such, this differentiates the local > only data and remotely accessed data cleanly. >OK, but could we please have a concise description of the impact >of these changes on kernel memory footprint? Increase or decrease? >And by approximately how much?

RE: [PATCH 1/2] Define new percpu interface for shared data -- version 3

2007-05-23 Thread Yu, Fenghua
elements are cacheline aligned. And as such, this differentiates the local only data and remotely accessed data cleanly. OK, but could we please have a concise description of the impact of these changes on kernel memory footprint? Increase or decrease? And by approximately how much? Depending

RE: [PATCH 1/2] Define new percpu interface for shared data -- version 3

2007-05-23 Thread Yu, Fenghua
Has there been any measurable benefit yet due to tail padding? We don't have data that tail padding actually helps. It all depends on what data the linker lays out in the cachelines. As of now we just want to create the infrastructure (so that more and more people who need it, can use it). It

RE: [PATCH 1/2] Define new percpu interface for shared data -- version 3

2007-05-23 Thread Yu, Fenghua
So what we have now is space wastage on some architectures, space savings on some, but with no measurable performance benefit due to the infrastructure itself. Why not push the infrastructure when we really need it, as against pushing it now when we are not sure if it benefits? It makes

RE: [PATCH 2/2] Use the new percpu interface for shared data -- version 3

2007-05-22 Thread Yu, Fenghua
>> -DEFINE_PER_CPU(struct tss_struct, init_tss) >>cacheline_internodealigned_in_smp = INIT_TSS; >> +DEFINE_PER_CPU_SHARED_ALIGNED(struct tss_struct, init_tss) = INIT_TSS; >Good work but could we call this something shorter? >Like >DEFINE_CPU_SHARED(...) The PER_CPU_SHARED_ALIGNED is

RE: [PATCH 2/2] Use the new percpu interface for shared data -- version 3

2007-05-22 Thread Yu, Fenghua
-DEFINE_PER_CPU(struct tss_struct, init_tss) cacheline_internodealigned_in_smp = INIT_TSS; +DEFINE_PER_CPU_SHARED_ALIGNED(struct tss_struct, init_tss) = INIT_TSS; Good work but could we call this something shorter? Like DEFINE_CPU_SHARED(...) The PER_CPU_SHARED_ALIGNED is corresponding

RE: [PATCH 2/2] Call percpu smp cacheline algin interface

2007-05-09 Thread Yu, Fenghua
On Wed, 9 May 2007, Andrew Morton wrote: >> erm, it's not obviosu from all this that the patches are worth proceeding >> with, are they? >What was it? 0.5% performance improvement on a synthetic benchmark? >Process wakeup I believe? The initial patch and discussion is from:

RE: [PATCH 2/2] Call percpu smp cacheline algin interface

2007-05-09 Thread Yu, Fenghua
>hm, DEFINE_PER_CPU_SHARED_CACHELINE_ALIGNED is a bit of a mouthful. >I wonder if we can improve things here so that we use the runtime-detected >cacheline size rather than the compile-time size. I guess not, given that >the offsets into the percpu area are calculated at build-time. >Did you

RE: [PATCH 2/2] Call percpu smp cacheline algin interface

2007-05-09 Thread Yu, Fenghua
hm, DEFINE_PER_CPU_SHARED_CACHELINE_ALIGNED is a bit of a mouthful. I wonder if we can improve things here so that we use the runtime-detected cacheline size rather than the compile-time size. I guess not, given that the offsets into the percpu area are calculated at build-time. Did you work

RE: [PATCH 2/2] Call percpu smp cacheline algin interface

2007-05-09 Thread Yu, Fenghua
On Wed, 9 May 2007, Andrew Morton wrote: erm, it's not obviosu from all this that the patches are worth proceeding with, are they? What was it? 0.5% performance improvement on a synthetic benchmark? Process wakeup I believe? The initial patch and discussion is from:

RE: [PATCH 0/2] Add percpu smp cacheline align section

2007-05-07 Thread Yu, Fenghua
On Mon, May 07, 2007 at 10:30:16AM -0700, Christoph Lameter wrote: > Call this area "cpu shared" or so? There are some fields in percpu section which are accessed by other cpu's but not cache line aligned, e.g. cpu_idle_state, flush_state in x86-64. We don't want to place those fields into same

RE: [PATCH 0/2] Add percpu smp cacheline align section

2007-05-07 Thread Yu, Fenghua
On Mon, May 07, 2007 at 10:30:16AM -0700, Christoph Lameter wrote: Call this area cpu shared or so? There are some fields in percpu section which are accessed by other cpu's but not cache line aligned, e.g. cpu_idle_state, flush_state in x86-64. We don't want to place those fields into same

<    1   2   3