Re: [RFC] extending splice for copy offloading

2013-12-18 Thread Zach Brown
On Wed, Dec 18, 2013 at 04:41:26AM -0800, Christoph Hellwig wrote: On Wed, Sep 11, 2013 at 10:06:47AM -0700, Zach Brown wrote: When I first started on this stuff I followed the lead of previous work and added a new syscall for the copy operation: https://lkml.org/lkml/2013/5/14/618

Re: [PATCH 6/7] btrfs: cleanup: removed unused 'btrfs_reada_detach'

2013-08-08 Thread Zach Brown
even though the function is currently unused, I'm hesitating to remove it as it's part of the reada-API and might be handy for anyone going to use the API in the future. I agree. As replied here, http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg24047.html please keep the

Re: btrfs zero divide

2013-08-09 Thread Zach Brown
On Fri, Aug 09, 2013 at 02:26:36PM +0200, Andreas Schwab wrote: Josef Bacik jba...@fusionio.com writes: So stripe_len shouldn't be 0, if it is you have bigger problems :). The bigger problem is that stripe_nr is u64, this is completely bogus. The first operand of do_div must be u32. This

Re: [PATCH 1/1] Btrfs: fix sparse warning

2014-07-16 Thread Zach Brown
char * We can safely use (const char __user *) with set_fs(KERNEL_DS) Yeah, that cast is correct. Reviewed-by: Zach Brown z...@zabbo.net @@ -515,7 +515,8 @@ static int write_buf(struct file *filp, const void *buf, u32 len, loff_t *off) Though this probably wants to be rewritten in terms

Re: [PATCH 1/1] Btrfs: fix sparse warning

2014-07-17 Thread Zach Brown
@@ -515,7 +515,8 @@ static int write_buf(struct file *filp, const void *buf, u32 len, loff_t *off) Though this probably wants to be rewritten in terms of kernel_write(). That'd give an opportunity to get rid of the sctx-send_off and have it use f_pos in the filp. Do you mean

Re: [PATCH, RFC] random: introduce getrandom(2) system call

2014-07-17 Thread Zach Brown
SYNOPSIS #include linux/random.h int getrandom(void *buf, size_t buflen, unsigned int flags); I certainly like the idea of getting entropy without having to worry about fds. If the GRND_RANDOM flags bit is not set, then the /dev/raundom (raundom typo) RETURN VALUE

Re: [PATCH, RFC] random: introduce getrandom(2) system call

2014-07-17 Thread Zach Brown
On Thu, Jul 17, 2014 at 04:54:17PM -0400, Theodore Ts'o wrote: On Thu, Jul 17, 2014 at 12:48:12PM -0700, Zach Brown wrote: + return urandom_read(NULL, buf, count, NULL); I wonder if we want to refactor the entry points a bit more instead of directly calling the device read functions

Re: [PATCH, RFC -v2] random: introduce getrandom(2) system call

2014-07-17 Thread Zach Brown
, buf, count, NULL); +} I like how tiny this ends up being. Feel free to add my rb:. Reviewed-by: Zach Brown z...@zabbo.net - z -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] Remove certain calls for releasing page cache

2014-07-30 Thread Zach Brown
On Wed, Jul 30, 2014 at 04:47:12PM -0400, Josef Bacik wrote: On 07/30/2014 04:42 PM, Nicholas Krause wrote: This patch removes the lines for releasing the page cache in certain files as this may aid in perfomance with writes in the compression rountines of btrfs. Please note that this patch

Re: [PATCH v1 1/9] aio: add aio_kernel_() interface

2014-08-14 Thread Zach Brown
On Thu, Aug 14, 2014 at 11:50:32PM +0800, Ming Lei wrote: From: Dave Kleikamp dave.kleik...@oracle.com This adds an interface that lets kernel callers submit aio iocbs without going through the user space syscalls. This lets kernel callers avoid the management limits and overhead of the

Re: [PATCH 7/9] aio: add aio_kernel_() interface

2014-07-23 Thread Zach Brown
On Thu, Jul 24, 2014 at 06:55:28AM +0800, Ming Lei wrote: From: Dave Kleikamp dave.kleik...@oracle.com This adds an interface that lets kernel callers submit aio iocbs without going through the user space syscalls. This lets kernel callers avoid the management limits and overhead of the

Re: [RFC] readdirplus implementations: xgetdents vs dirreadahead syscalls

2014-07-25 Thread Zach Brown
On Fri, Jul 25, 2014 at 01:37:19PM -0400, Abhijith Das wrote: Hi all, The topic of a readdirplus-like syscall had come up for discussion at last year's LSF/MM collab summit. I wrote a couple of syscalls with their GFS2 implementations to get at a directory's entries as well as stat()

Re: [Cluster-devel] [RFC] readdirplus implementations: xgetdents vs dirreadahead syscalls

2014-07-25 Thread Zach Brown
On Fri, Jul 25, 2014 at 07:08:12PM +0100, Steven Whitehouse wrote: Hi, On 25/07/14 18:52, Zach Brown wrote: On Fri, Jul 25, 2014 at 01:37:19PM -0400, Abhijith Das wrote: Hi all, The topic of a readdirplus-like syscall had come up for discussion at last year's LSF/MM collab summit. I

Re: [PATCH 1/1] Btrfs: fix sparse warning

2014-08-04 Thread Zach Brown
On Sat, Aug 02, 2014 at 02:24:49PM +0200, Fabian Frederick wrote: On Thu, 17 Jul 2014 12:01:52 -0700 Zach Brown z...@zabbo.net wrote: @@ -515,7 +515,8 @@ static int write_buf(struct file *filp, const void *buf, u32 len, loff_t *off) Though this probably wants

Re: [PATCH 1/1] Btrfs: fix sparse warning

2014-08-05 Thread Zach Brown
Hello Zach,      Here's an untested patch which Try testing it.  It's easy with virtualization and xfstests. You'll find that sending to a file fails because each individual file write call that makes up a send starts at offset 0 -- at the start of the file. Getting this

Re: [RFC 1/1 linux-next] btrfs: don't opencode zero_user_segment

2014-10-15 Thread Zach Brown
On Tue, Oct 14, 2014 at 10:18:09PM +0200, Fabian Frederick wrote: On 14 October 2014 at 21:15 Zach Brown z...@zabbo.net wrote: On Tue, Oct 14, 2014 at 07:46:14PM +0200, Fabian Frederick wrote: use function defined in include/linux/highmem.h Note that this reverts 2 last function

Re: [PATCH v1 5/9] block: loop: convert to blk-mq

2014-08-27 Thread Zach Brown
On Wed, Aug 27, 2014 at 09:19:36PM +0400, Maxim Patlasov wrote: On 08/27/2014 08:29 PM, Benjamin LaHaise wrote: On Wed, Aug 27, 2014 at 08:08:59PM +0400, Maxim Patlasov wrote: ... 1) /dev/loop0 of 3.17.0-rc1 with Ming's patches applied -- 11K iops 2) the same as above, but call

Re: [PATCH] target/file: fix inclusive vfs_fsync_range() end

2014-10-07 Thread Zach Brown
On Mon, Oct 06, 2014 at 11:39:45PM -0700, Christoph Hellwig wrote: On Mon, Oct 06, 2014 at 04:40:13PM -0700, Zach Brown wrote: Both of the file target's calls to vfs_fsync_range() got the end offset off by one. The range is inclusive, not exclusive. It would sync a bit more data than

[PATCH] target/file: fix inclusive vfs_fsync_range() end

2014-10-06 Thread Zach Brown
. This is untested. I found the errors by inspection while following other code. Signed-off-by: Zach Brown z...@zabbo.net --- drivers/target/target_core_file.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_file.c b/drivers/target

[PATCH] nfsd: fix inclusive vfs_fsync_range() end

2014-10-06 Thread Zach Brown
in write processing. Maybe a helper would be nice but I kept it trivial. This is untested. I found it while reviewing code for something else entirely. Signed-off-by: Zach Brown z...@zabbo.net --- fs/nfsd/vfs.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/fs/nfsd

Re: [PATCH 1/2] btrfs: fix sparse address space warnings

2014-09-30 Thread Zach Brown
On Sun, Sep 28, 2014 at 03:26:04PM -0700, Omar Sandoval wrote: On Sun, Sep 28, 2014 at 01:48:11AM -0700, Omar Sandoval wrote: diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index 6528aa6..e0be577 100644 --- a/fs/btrfs/send.c +++ b/fs/btrfs/send.c @@ -515,7 +515,8 @@ static int

Re: [PATCH v2 1/3] btrfs: replace open-coded kernel_write

2014-09-30 Thread Zach Brown
On Tue, Sep 30, 2014 at 03:01:40PM -0700, Omar Sandoval wrote: write_buf used by btrfs send has what is more or less a reimplementation of kernel_write. This also gets rid of a sparse address space warning. Seems reasonable to me: Reviewed-by: Zach Brown z...@zabbo.net - z -- To unsubscribe

Re: [RFC PATCH 0/7] Non-blockling buffered fs read (page cache only)

2014-09-16 Thread Zach Brown
On Mon, Sep 15, 2014 at 10:36:46PM +, Elliott, Robert (Server Storage) wrote: -Original Message- From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- ow...@vger.kernel.org] On Behalf Of Andreas Dilger Sent: Monday, 15 September, 2014 4:34 PM To: Milosz Tanski

Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances

2014-09-17 Thread Zach Brown
On Wed, Sep 17, 2014 at 09:56:11AM -0400, Benjamin LaHaise wrote: On Wed, Sep 17, 2014 at 09:47:02AM -0400, Theodore Ts'o wrote: ... % git version git version 2.1.0 Perhaps you and other people are using your own scripts, and not using git send-email? That would be because none of

Re: Setting FS_USERNS_MOUNT in btrfs_fs_type.fs_flags

2014-09-17 Thread Zach Brown
On Wed, Sep 17, 2014 at 04:54:48AM +0100, Al Viro wrote: On Tue, Sep 16, 2014 at 11:05:00PM -0400, Shea Levy wrote: Hi all, What work would be required to mark btrfs_fs_type with FS_USERNS_MOUNT so that btrfs images can be mounted by unprivileged users within a user namespace (along

Re: [PATCH 2/7] Define new syscalls readv2,preadv2,writev2,pwritev2

2014-09-17 Thread Zach Brown
On Wed, Sep 17, 2014 at 12:59:30PM -0400, Theodore Ts'o wrote: On Wed, Sep 17, 2014 at 12:05:23PM -0400, Milosz Tanski wrote: Theodore, I might be missing understanding something, but... I already omitted read2 and write2 which can be implemented in userspace by libc (as you pointed

[PATCH] fs: check bh blocknr earlier when searching lru

2014-09-17 Thread Zach Brown
cmp%rdx,0x20(%r8) 1653: 75 d3 jne1628 __find_get_block+0x38 Signed-off-by: Zach Brown z...@zabbo.net --- fs/buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 8f05111..d14f782 100644

Re: [RFC 1/1 linux-next] btrfs: don't opencode zero_user_segment

2014-10-14 Thread Zach Brown
On Tue, Oct 14, 2014 at 07:46:14PM +0200, Fabian Frederick wrote: use function defined in include/linux/highmem.h Note that this reverts 2 last function call order And adds a BUG_ON(PAGE_CACHE_SIZE PAGE_SIZE). We can take bets on whether that will ever trigger. - z -- To unsubscribe from

Re: [PATCH RFC] vfs: add a O_NOMTIME flag

2015-05-07 Thread Zach Brown
The criteria for using O_NOMTIME is the same as for using O_NOATIME: owning the file or having the CAP_FOWNER capability. If we're not comfortable allowing owners to prevent mtime/ctime updates then we should add a tunable to allow O_NOMTIME. Maybe a mount option? I dislike turn

Re: [PATCH RFC] vfs: add a O_NOMTIME flag

2015-05-06 Thread Zach Brown
On Wed, May 06, 2015 at 03:19:13PM -0700, Sage Weil wrote: On Wed, 6 May 2015, Trond Myklebust wrote: Hi Zach, On Wed, May 6, 2015 at 6:00 PM, Zach Brown z...@redhat.com wrote: Add the O_NOMTIME flag which prevents mtime from being updated which can greatly reduce the IO overhead

[PATCH RFC] vfs: add a O_NOMTIME flag

2015-05-06 Thread Zach Brown
O_NOMTIME. Maybe a mount option? Signed-off-by: Zach Brown z...@redhat.com Cc: Sage Weil sw...@redhat.com --- fs/fcntl.c | 12 +++- fs/inode.c | 2 +- fs/namei.c | 4 ++-- include/linux/fs.h | 7

Re: [PATCH RFC] vfs: add a O_NOMTIME flag

2015-05-08 Thread Zach Brown
On Thu, May 07, 2015 at 06:01:23PM -0700, Sage Weil wrote: On Thu, 7 May 2015, Zach Brown wrote: On Thu, May 07, 2015 at 10:26:17AM +1000, Dave Chinner wrote: On Wed, May 06, 2015 at 03:00:12PM -0700, Zach Brown wrote: The criteria for using O_NOMTIME is the same as for using O_NOATIME

Re: [PATCH RFC] vfs: add a O_NOMTIME flag

2015-05-07 Thread Zach Brown
On Thu, May 07, 2015 at 10:26:17AM +1000, Dave Chinner wrote: On Wed, May 06, 2015 at 03:00:12PM -0700, Zach Brown wrote: Add the O_NOMTIME flag which prevents mtime from being updated which can greatly reduce the IO overhead of writes to allocated and initialized regions of files. Hmmm

[PATCH RFC v2 0/2] O_NOCMTIME protected by generic mount option

2015-05-15 Thread Zach Brown
Here's a current draft of what is now the O_NOCMTIME series. It implements the frequent suggestion to gate unprivileged O_NOCMTIME use with a mount option. This method has the advantage of being entirely runtime. There's no persistence that'd require updating all the tools that deal with each

[PATCH RFC v2 2/2] vfs: add O_NOCMTIME

2015-05-15 Thread Zach Brown
set. This requires priviledged intervention to testify that mtime isn't critical to, say, backup infrastructure or NFS server consistency guarantees. Signed-off-by: Zach Brown z...@zabbo.net --- fs/fcntl.c | 30 +++--- fs/inode.c

[PATCH RFC v2 1/2] vfs: add generic nocmtime mount flag

2015-05-15 Thread Zach Brown
O_NOCMTIME to prevent cmtime updates without harm. Signed-off-by: Zach Brown z...@zabbo.net --- fs/namespace.c | 2 ++ fs/proc_namespace.c | 1 + fs/statfs.c | 2 ++ include/linux/mount.h | 1 + include/linux/statfs.h | 1 + include/uapi/linux/fs.h | 1 + 6 files changed, 8

Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-14 Thread Zach Brown
On Tue, Apr 14, 2015 at 02:19:11PM -0400, J. Bruce Fields wrote: On Tue, Apr 14, 2015 at 01:16:13PM -0400, Anna Schumaker wrote: On 04/14/2015 12:53 PM, Christoph Hellwig wrote: On Sat, Apr 11, 2015 at 09:04:02AM -0400, Jeff Layton wrote: Yuck! How the heck do you clean up the mess if

Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-13 Thread Zach Brown
Could we perhaps instead of a length, define a 'pos_in_start' and a 'pos_in_end' offset (with the latter being -1 for a full-file copy) and then return an 'loff_t' value stating where the copy ended? Well, the resulting offset will be set if the caller provided it. So they could

Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-14 Thread Zach Brown
On Tue, Apr 14, 2015 at 02:29:06PM -0400, J. Bruce Fields wrote: On Tue, Apr 14, 2015 at 11:22:41AM -0700, Zach Brown wrote: On Tue, Apr 14, 2015 at 02:19:11PM -0400, J. Bruce Fields wrote: On Tue, Apr 14, 2015 at 01:16:13PM -0400, Anna Schumaker wrote: On 04/14/2015 12:53 PM, Christoph

Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-14 Thread Zach Brown
On Tue, Apr 14, 2015 at 12:23:25PM -0700, Christoph Hellwig wrote: On Tue, Apr 14, 2015 at 11:54:08AM -0700, Zach Brown wrote: Is this relying on btrfs range cloning being atomic? It certainly doesn't look atomic. It can modify items across an arbitrarily large number of leaf blocks

[PATCH RFC 0/3] simple copy offloading system call

2015-04-10 Thread Zach Brown
Hello everyone! Here's my current attempt at the most basic system call interface for offloading copying between files. The system call and vfs function are relatively light wrappers around the file_operation method that does the heavy lifting. There was interest at LSF in getting the basic

[PATCH RFC 2/3] x86: add sys_copy_file_range to syscall tables

2015-04-10 Thread Zach Brown
Add sys_copy_file_range to the x86 syscall tables. Signed-off-by: Zach Brown z...@redhat.com --- arch/x86/syscalls/syscall_32.tbl | 1 + arch/x86/syscalls/syscall_64.tbl | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/x86/syscalls/syscall_32.tbl b/arch/x86/syscalls/syscall_32.tbl

[PATCH RFC 3/3] btrfs: add .copy_file_range file operation

2015-04-10 Thread Zach Brown
-off-by: Zach Brown z...@redhat.com --- fs/btrfs/ctree.h | 3 ++ fs/btrfs/file.c | 1 + fs/btrfs/ioctl.c | 91 3 files changed, 56 insertions(+), 39 deletions(-) diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index f9c89ca..f7cfa26 100644

[PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-10 Thread Zach Brown
on an existing destination file descriptor, not a path. Currently the high level vfs entry point limits copy offloading to files on the same mount and super (and not in the same file). This can be relaxed if we get implementations which can copy between file systems safely. Signed-off-by: Zach Brown z

Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-10 Thread Zach Brown
On Fri, Apr 10, 2015 at 06:36:41PM -0400, Trond Myklebust wrote: On Fri, Apr 10, 2015 at 6:00 PM, Zach Brown z...@redhat.com wrote: + +/* + * copy_file_range() differs from regular file read and write in that it + * specifically allows return partial success. When it does so is up

[PATCH] phy, leds: add support for led triggers on phy link state change

2016-08-17 Thread Zach Brown
allow a set of LEDs to represent link state changes on the phy. Signed-off-by: Josh Cartwright <josh.cartwri...@ni.com> Signed-off-by: Nathan Sullivan <nathan.sulli...@ni.com> Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/net/phy/Kconfig| 12 +

[PATCH] leds: do not overflow sysfs buffer in led_trigger_show

2016-08-15 Thread Zach Brown
From: Nathan Sullivan <nathan.sulli...@ni.com> Per the documentation, use scnprintf instead of sprintf to ensure there is never more than PAGE_SIZE bytes of trigger names put into the buffer. Signed-off-by: Nathan Sullivan <nathan.sulli...@ni.com> Signed-off-by: Zach Brown <za

[PATCH] sdhci: Add quirk and device tree parameter to force SD test mode

2016-08-22 Thread Zach Brown
rameter to sdhci-pltfm to allow all SDHCI drivers to enable this quirk. Signed-off-by: Jaeden Amero <jaeden.am...@ni.com> Signed-off-by: Zach Brown <zach.br...@ni.com> --- Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++ drivers/mmc/host/sdhci-pltfm.c| 4 ++

[PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit

2016-08-24 Thread Zach Brown
the controller to function with out the cd bit. The device property "fake-cd" will let the arasan driver know it needs to fake the cd bit for the controller inorder for the controller to function with a SD card that does not provide the CD bit. Signed-off-by: Zach Brown <zach

[PATCH 2/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit

2016-08-24 Thread Zach Brown
the controller to function with out the cd bit. The device property "fake-cd" will let the arasan driver know it needs to fake the cd bit for the controller inorder for the controller to function with a SD card that does not provide the CD bit. Signed-off-by: Zach Brown <zach.br...@ni.com>

[PATCH v4 1/2] sdhci-of-arasan: Add device tree parameter xlnx-fails-without-test-cd bit

2016-09-06 Thread Zach Brown
the controller to function without the CD bit. The device property "xlnx-fails-without-test-cd" will let the arasan driver know the controller does not have the CD line wired and that the controller does not function without it. Signed-off-by: Zach Brown <zach.br...@ni.com> --- v2: *

Re: [PATCH 2/2] sdhci-of-arasan: Set controller to test mode when fails-without-test-cd is present

2016-09-06 Thread Zach Brown
On Tue, Aug 30, 2016 at 07:47:17AM +0200, Michal Simek wrote: > On 30.8.2016 01:20, Zach Brown wrote: > > The sdhci controller on xilinx zynq devices will not function unless > > the CD bit is provided. http://www.xilinx.com/support/answers/61064.html > > In cases where it is

[PATCH v4 2/2] sdhci-of-arasan: Set controller to test mode when xlnx-fails-without-test-cd is present

2016-09-06 Thread Zach Brown
the controller to function without the CD bit. When the device has the property xlnx-fails-without-test-cd the driver changes the controller to test mode and sets test inserted to true to make the controller function. Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/mmc/host/sdhci-of-arasan.

[PATCH 2/2] sdhci-of-arasan: Set controller to test mode when fails-without-test-cd is present

2016-08-29 Thread Zach Brown
the controller to function without the CD bit. When the device has the property fails-without-test-cd the driver changes the controller to test mode and sets test inserted to true to make the controller function. Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/mmc/host/sdhci-of-arasan.

[PATCH 1/2] sdhci-of-arasan: Add device tree parameter fails-without-test-cd bit

2016-08-29 Thread Zach Brown
the controller to function without the CD bit. The device property "fails-without-test-cd" will let the arasan driver know the controller does not have the CD line wired and that the controller does not function without it. Signed-off-by: Zach Brown <zach.br...@ni.com> --- v2: * improved

Re: [PATCH v4 2/2] sdhci-of-arasan: Set controller to test mode when xlnx-fails-without-test-cd is present

2016-09-07 Thread Zach Brown
On Wed, Sep 07, 2016 at 07:15:02AM +0200, Michal Simek wrote: > On 6.9.2016 22:34, Zach Brown wrote: > > The sdhci controller on xilinx zynq devices will not function unless > > the CD bit is provided. http://www.xilinx.com/support/answers/61064.html > > In cases where it is

[PATCH v5 2/2] sdhci-of-arasan: Set controller to test mode when xlnx-fails-without-test-cd is present

2016-09-07 Thread Zach Brown
the controller to function without the CD bit. When the device has the property xlnx-fails-without-test-cd the driver changes the controller to test mode and sets test inserted to true to make the controller function. Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/mmc/host/sdhci-of-arasan.

[PATCH v5 1/2] sdhci-of-arasan: Add device tree parameter xlnx-fails-without-test-cd bit

2016-09-07 Thread Zach Brown
the controller to function without the CD bit. The device property "xlnx-fails-without-test-cd" will let the arasan driver know the controller does not have the CD line wired and that the controller does not function without it. Signed-off-by: Zach Brown <zach.br...@ni.com> --- v2: *

[PATCH v7 1/2] sdhci-of-arasan: Add device tree parameter xlnx,fails-without-test-cd bit

2016-09-09 Thread Zach Brown
the controller to function without the CD bit. The device property "xlnx,fails-without-test-cd" will let the arasan driver know the controller does not have the CD line wired and that the controller does not function without it. Signed-off-by: Zach Brown <zach.br...@ni.com> --- v2: *

[PATCH v7 2/2] sdhci-of-arasan: Set controller to test mode when xlnx,fails-without-test-cd is present

2016-09-09 Thread Zach Brown
the controller to function without the CD bit. When the device has the property xlnx,fails-without-test-cd the driver changes the controller to test mode and sets test inserted to true to make the controller function. Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/mmc/host/sdhci-of-arasan.

[RFC 2/3] staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts with LED namespace

2016-09-14 Thread Zach Brown
Adding led support for phy causes namespace conflicts for some phy drivers. The rtl871 driver declared an enum for representing LED states. The enum contains constant LED_OFF which conflicted with declartation found in linux/leds.h. LED_OFF changed to LED_STATE_OFF Signed-off-by: Zach Brown

[RFC 0/3] Add support for led triggers on phy link state change

2016-09-14 Thread Zach Brown
to do so. Josh Cartwright (1): phy,leds: add support for led triggers on phy link state change Zach Brown (2): skge: Change LED_OFF to LED_REG_OFF in marvel skge driver to avoid conflicts with leds namespace staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts

[RFC 1/3] skge: Change LED_OFF to LED_REG_OFF in marvel skge driver to avoid conflicts with leds namespace

2016-09-14 Thread Zach Brown
Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/net/ethernet/marvell/skge.c | 4 ++-- drivers/net/ethernet/marvell/skge.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c index 7173836..f

[RFC 3/3] phy,leds: add support for led triggers on phy link state change

2016-09-14 Thread Zach Brown
f LEDs to represent link state changes on the phy. Signed-off-by: Josh Cartwright <josh.cartwri...@ni.com> Signed-off-by: Nathan Sullivan <nathan.sulli...@ni.com> Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/net/phy/Kconfig| 12 drivers/net/phy/

[PATCH v6 1/2] sdhci-of-arasan: Add device tree parameter xlnx-fails-without-test-cd bit

2016-09-08 Thread Zach Brown
the controller to function without the CD bit. The device property "xlnx-fails-without-test-cd" will let the arasan driver know the controller does not have the CD line wired and that the controller does not function without it. Signed-off-by: Zach Brown <zach.br...@ni.com> --- v2: *

[PATCH v6 2/2] sdhci-of-arasan: Set controller to test mode when xlnx-fails-without-test-cd is present

2016-09-08 Thread Zach Brown
the controller to function without the CD bit. When the device has the property xlnx-fails-without-test-cd the driver changes the controller to test mode and sets test inserted to true to make the controller function. Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/mmc/host/sdhci-of-arasan.

[RFC v3 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

2016-10-07 Thread Zach Brown
changed LED_ON to LED_REG_ON to avoid possible future conflict and for consistency. Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/net/ethernet/marvell/skge.c | 6 +++--- drivers/net/ethernet/marvell/skge.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/d

Re: [RFC 1/2] sdhci: Add device tree property sd-broken-highspeed

2016-10-07 Thread Zach Brown
ansson <ulf.hans...@linaro.org> > >>> wrote: > >>>> On 23 September 2016 at 22:01, Zach Brown <zach.br...@ni.com> wrote: > >>>>> Certain board configurations can make highspeed malfunction due to > >>>>> timing issues. In these cases a

[RFC v3 3/3] phy,leds: add support for led triggers on phy link state change

2016-10-07 Thread Zach Brown
f LEDs to represent link state changes on the phy. Signed-off-by: Josh Cartwright <josh.cartwri...@ni.com> Signed-off-by: Nathan Sullivan <nathan.sulli...@ni.com> Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/net/phy/Kconfig| 13 +++- drivers/net/phy/

[PATCH 0/3] Add support for led triggers on phy link state change

2016-10-07 Thread Zach Brown
and improve consistency. * Dropped rtl8712 patch that was accepted separately. Josh Cartwright (1): phy,leds: add support for led triggers on phy link state change Zach Brown (2): skge: Change LED_OFF to LED_REG_OFF in marvel skge driver to avoid conflicts with leds namespace phy: Encapsulate

[RFC v3 2/3] phy: Encapsulate actions performed during link state changes into function phy_adjust_link

2016-10-07 Thread Zach Brown
ore. Actions that should occur whenever the phy link is adjusted can now be added to the phy_adjust_link function. Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/net/phy/phy.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/phy.c

Re: [PATCH v2] UBI: add debugfs file for tracking PEB state

2016-09-21 Thread Zach Brown
On Wed, Sep 21, 2016 at 01:13:29PM +0200, Richard Weinberger wrote: > Zach, > > On 20.09.2016 22:45, Zach Brown wrote: > > From: Ben Shelton <ben.shel...@ni.com> > > > > Add a file under debugfs to allow easy access to the erase count for > > eac

Re: [RFC 3/3] phy,leds: add support for led triggers on phy link state change

2016-09-19 Thread Zach Brown
On Wed, Sep 14, 2016 at 04:16:15PM -0700, Florian Fainelli wrote: > On 09/14/2016 02:55 PM, Zach Brown wrote: > > From: Josh Cartwright <josh.cartwri...@ni.com> > > > > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will > > create a set of led t

[PATCH] UBI: add debugfs file for tracking PEB state

2016-09-19 Thread Zach Brown
m> Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/mtd/ubi/debug.c | 151 +++- 1 file changed, 150 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/ubi/debug.c b/drivers/mtd/ubi/debug.c index f101a49..09eaab6 100644 --- a/drivers/mtd

[RFC 0/2] Add device tree property and quirk for supporting sdhci

2016-09-23 Thread Zach Brown
property is set Zach Brown (1): sdhci: Add device tree property sd-broken-highspeed Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++ arch/arm/boot/dts/ni-77D5.dts | 1 - drivers/mmc/host/sdhci-pltfm.c| 3 +++ drivers/mmc/host/sdhci.c | 3

[RFC 1/2] sdhci: Add device tree property sd-broken-highspeed

2016-09-23 Thread Zach Brown
that highspeed will not work. Signed-off-by: Zach Brown <zach.br...@ni.com> --- Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt index 8a37782..59332ea

[RFC 2/2] sdhci: Prevent SD from doing highspeed timing when sd-broken-highspeed property is set

2016-09-23 Thread Zach Brown
hspeed, but the board configuration or some other issue make highspeed impossible. Signed-off-by: Chen Yee Chew <chen.yee.c...@ni.com> Reviewed-by: Keng Soon Cheah <keng.soon.ch...@ni.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> Signed-off-by: Zach Brown <zach.br...@ni.com&g

[PATCH v2] UBI: add debugfs file for tracking PEB state

2016-09-20 Thread Zach Brown
m> Signed-off-by: Zach Brown <zach.br...@ni.com> --- v2 * Cast pointer in unsigned long instead of int to avoid build warning * Use ubi->lookuptbl[] to get erase counter instead of reading from flash drivers/mtd/ubi/debug.c | 145 +++-

[RESEND PATCH v7 1/2] sdhci-of-arasan: Add device tree parameter xlnx,fails-without-test-cd bit

2016-09-16 Thread Zach Brown
the controller to function without the CD bit. The device property "xlnx,fails-without-test-cd" will let the arasan driver know the controller does not have the CD line wired and that the controller does not function without it. Signed-off-by: Zach Brown <zach.br...@ni.com> --- v2: *

[RESEND PATCH v7 2/2] sdhci-of-arasan: Set controller to test mode when xlnx,fails-without-test-cd is present

2016-09-16 Thread Zach Brown
the controller to function without the CD bit. When the device has the property xlnx,fails-without-test-cd the driver changes the controller to test mode and sets test inserted to true to make the controller function. Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/mmc/host/sdhci-of-arasan.

Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit

2016-08-25 Thread Zach Brown
On Thu, Aug 25, 2016 at 11:56:55AM +0100, Mark Rutland wrote: > On Wed, Aug 24, 2016 at 06:23:03PM -0500, Zach Brown wrote: > > The sdhci controller on xilinx zynq devices will not function unless > > the cd bit is provided. http://www.xilinx.com/support/answers/61064.html >

Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit

2016-08-26 Thread Zach Brown
On Fri, Aug 26, 2016 at 09:42:38AM +0200, Ulf Hansson wrote: > On 25 August 2016 at 22:46, Zach Brown <zach.br...@ni.com> wrote: > > On Thu, Aug 25, 2016 at 07:28:55PM +0100, Mark Rutland wrote: > >> On Thu, Aug 25, 2016 at 01:26:22PM -0500, Zach Brown wrote: > >>

Re: [PATCH] sdhci: Add quirk and device tree parameter to force SD test mode

2016-08-23 Thread Zach Brown
On Mon, Aug 22, 2016 at 07:46:09PM -0700, Frank Rowand wrote: > On 08/22/16 15:55, Zach Brown wrote: > > From: Jaeden Amero <jaeden.am...@ni.com> > > > > On some devices, CD is broken so that we must force the SDHCI into test > > mode and set CD, so that it alw

Re: [PATCH] sdhci: Add quirk and device tree parameter to force SD test mode

2016-08-23 Thread Zach Brown
On Tue, Aug 23, 2016 at 01:34:20AM +, Haibo Chen wrote: > > -Original Message- > > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > > ow...@vger.kernel.org] On Behalf Of Zach Brown > > Sent: Tuesday, August 23, 2016 6:56 AM > > To: adrian.hun

Re: [PATCH] sdhci: Add quirk and device tree parameter to force SD test mode

2016-08-23 Thread Zach Brown
On Tue, Aug 23, 2016 at 09:22:29AM +0300, Adrian Hunter wrote: > On 23/08/16 01:55, Zach Brown wrote: > > From: Jaeden Amero <jaeden.am...@ni.com> > > > > On some devices, CD is broken so that we must force the SDHCI into test > > mode and set CD, so that it alw

Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit

2016-08-25 Thread Zach Brown
On Thu, Aug 25, 2016 at 07:28:55PM +0100, Mark Rutland wrote: > On Thu, Aug 25, 2016 at 01:26:22PM -0500, Zach Brown wrote: > > On Thu, Aug 25, 2016 at 07:10:00PM +0100, Mark Rutland wrote: > > > On Thu, Aug 25, 2016 at 12:15:44PM -0500, Zach Brown wrote: > > > >

Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit

2016-08-25 Thread Zach Brown
On Thu, Aug 25, 2016 at 07:10:00PM +0100, Mark Rutland wrote: > On Thu, Aug 25, 2016 at 12:15:44PM -0500, Zach Brown wrote: > > On Thu, Aug 25, 2016 at 11:56:55AM +0100, Mark Rutland wrote: > > > On Wed, Aug 24, 2016 at 06:23:03PM -0500, Zach Brown wrote: > > > &g

[PATCH v2 2/2] sdhci-of-arasan: Set controller to test mode when Card Detection is broken.

2016-08-25 Thread Zach Brown
the controller to function without the CD bit. When the device has the property broken-cd the driver changes the controller to test mode and sets test inserted to true to make the controller function. Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/mmc/host/sdhci-of-arasan.

[PATCH v2 1/2] sdhci-of-arasan: Modify arasan sdhci documentation about broken-cd and non-removable properties.

2016-08-25 Thread Zach Brown
est mode to function. This patch modifies the documentation to reflect those differences from the standard behaviours. Signed-off-by: Zach Brown <zach.br...@ni.com> --- v2: * improved commit messages * removed fake-cd device property * removed fake-cd quirk * use broken-cd device p

[RFC v2 4/4] phy,leds: add support for led triggers on phy link state change

2016-09-27 Thread Zach Brown
f LEDs to represent link state changes on the phy. Signed-off-by: Josh Cartwright <josh.cartwri...@ni.com> Signed-off-by: Nathan Sullivan <nathan.sulli...@ni.com> Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/net/phy/Kconfig| 13 +++- drivers/net/phy/

[RFC v2 2/4] staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts with LED namespace

2016-09-27 Thread Zach Brown
future collision LED_ON was changed to LED_STATE_ON as well. Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/staging/rtl8712/rtl8712_led.c | 388 +- 1 file changed, 194 insertions(+), 194 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_le

[RFC v2 1/4] skge: Change LED_OFF to LED_REG_OFF in marvel skge driver to avoid conflicts with leds namespace

2016-09-27 Thread Zach Brown
Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/net/ethernet/marvell/skge.c | 4 ++-- drivers/net/ethernet/marvell/skge.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c index 7173836..f

[RFC v2 0/4] Add support for led triggers on phy link state change

2016-09-27 Thread Zach Brown
Zach Brown (3): skge: Change LED_OFF to LED_REG_OFF in marvel skge driver to avoid conflicts with leds namespace staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts with LED namespace phy: Encapsulate actions performed during link state changes into function

[RFC v2 3/4] phy: Encapsulate actions performed during link state changes into function phy_adjust_link

2016-09-27 Thread Zach Brown
ore. Actions that should occur whenever the phy link is adjusted can now be added to the phy_adjust_link function. Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/net/phy/phy.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/net/ph

[RFC v3] UBI: add debugfs file for tracking PEB state

2016-10-03 Thread Zach Brown
m> Signed-off-by: Zach Brown <zach.br...@ni.com> --- v2 * Cast pointer in unsigned long instead of int to avoid build warning * Use ubi->lookuptbl[] to get erase counter instead of reading from flash v3 * Use wl_lock to protect section that uses ubi_wl_entry * Handle case where ubi-&g

[RFC 2/2] mmc: sdhci: Use sdhci-caps-mask and sdhci-caps to change the caps read during __sdhci_read_caps

2016-10-25 Thread Zach Brown
__sdhci_read_caps Use the sdhci-caps-mask property to turn off the incorrect bits of the sdhci registers after reading them. Use the sdhci-caps to turn on bits after using sdhci-caps-mask to turn off the incorrect ones. Signed-off-by: Zach Brown <zach.br...@ni.com> --- drivers/mmc/host/sdhci.

[RFC 0/2] mmc: sdhci: Fix sdhci caps register bits with corrections provided by dt

2016-10-25 Thread Zach Brown
represent the correction to the sdhci caps register. The second patch uses the new dt properties to correct the caps from the register as they read during __sdhci_read_caps. Zach Brown (2): mmc: sdhci: dt: Add device tree properties sdhci-caps and sdhci-caps-mask mmc: sdhci: Use sdhci-caps-mask

[RFC 1/2] mmc: sdhci: dt: Add device tree properties sdhci-caps and sdhci-caps-mask

2016-10-25 Thread Zach Brown
on. Signed-off-by: Zach Brown <zach.br...@ni.com> --- Documentation/devicetree/bindings/mmc/mmc.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt index 8a37782..1415aa0

Re: Pure polling mode for netdevices

2016-10-27 Thread Zach Brown
On Fri, Oct 21, 2016 at 11:41:46AM -0700, Eric Dumazet wrote: > On Fri, 2016-10-21 at 13:03 -0500, Zach Brown wrote: > > Is there a way to get NAPI to poll all the time? > > Or just any way to get netdevices to use only polling and no interrupts? > > > > We have some

[RESEND PATCH v2 2/3] mtd: nand: implement 'max_bad_blocks' mtd function

2016-10-27 Thread Zach Brown
From: Jeff Westfahl <jeff.westf...@ni.com> Implement the new mtd function 'max_bad_blocks'. Use the ONFI parameter page to find the maximum bad blocks to reserve for an MTD, taking into account how many LUNs the MTD spans. Signed-off-by: Jeff Westfahl <jeff.westf...@ni.com> Signed-

<    1   2   3   4   5   6   7   8   9   10   >