[PATCH 2/6] syslet: asm-generic support to disable syslets

2007-12-06 Thread Zach Brown
-off-by: Zach Brown <[EMAIL PROTECTED]> diff --git a/include/asm-generic/syslet-abi.h b/include/asm-generic/syslet-abi.h new file mode 100644 index 000..5d19971 --- /dev/null +++ b/include/asm-generic/syslet-abi.h @@ -0,0 +1,11 @@ +#ifndef _ASM_GENERIC_SYSLET_ABI_H +#

[PATCH 3/6] syslet: introduce abi structs

2007-12-06 Thread Zach Brown
This patch adds the architecture independent structures of the syslet ABI. Signed-off-by: Zach Brown <[EMAIL PROTECTED]> diff --git a/include/linux/syslet-abi.h b/include/linux/syslet-abi.h new file mode 100644 index 000..a8bc1a3 --- /dev/null +++ b/include/linux/syslet-abi.h @@ -0,0

[PATCH 4/6] syslets: add indirect args

2007-12-06 Thread Zach Brown
turn indirect_params into a struct that contains a union for arguments which can never be used concurrently. This needs wider discussion. Signed-off-by: Zach Brown <[EMAIL PROTECTED]> diff --git a/include/linux/indirect.h b/include/linux/indirect.h index 97f9ac4..5d5abd7 100644 --- a/include

[PATCH 5/6] syslets: add generic syslets infrastructure

2007-12-06 Thread Zach Brown
which was built around 'uatoms'. Enough code has changed that it wasn't appropriate to bring the previous Signed-off-by lines forward. Signed-off-by: Zach Brown <[EMAIL PROTECTED]>; diff --git a/fs/exec.c b/fs/exec.c index 282240a..942262f 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -51,6

[PATCH 6/6] syslets: add both 32bit and 64bit x86 syslet support

2007-12-06 Thread Zach Brown
juggle pointers to transfer the fpu state. The syslets infrastructure needs to work with ptregs for the task which is in sys_indirect(). So we add a PTREGSCALL stub around sys_indirect() in x86_64. Finally, we wire up sys_syslet_ring_wait(). Signed-off-by: Zach Brown <[EMAIL PROTECTED]> diff

Re: [PATCH 5/6] syslets: add generic syslets infrastructure

2007-12-07 Thread Zach Brown
>> +/* >> + * syslet_ring doesn't have any kernel-side storage. Userspace allocates >> them >> + * in their address space and initializes their fields and then passes them >> to >> + * the kernel. >> + * >> + * These hashes provide the kernel-side storage for the wait queues which >> + *

Re: [PATCH 1/6] indirect: use asmlinkage in i386 syscall table prototype

2007-12-08 Thread Zach Brown
>> +extern asmlinkage long (*sys_call_table[])(long, long, long, > This should be something like below instead, otherwise gcc wont parse > asmlinkage as being an attribute of the function signature. > extern long (asmlinkage *sys_call_table[])(long, long, long, Yeah, thanks for

Re: syslets v7: back to basics

2007-12-10 Thread Zach Brown
> I pulled from your tree to look over the patches, and noticed that it > looks like several commits were merged improperly. It looks like they > were auto merged or something from an email, and the commit message > contains the email headers, rather than just the commit message in the > body.

Re: [PATCHv5 0/5] sys_indirect system call

2007-12-11 Thread Zach Brown
> Note that the sys_indirect system call takes an additional parameter which > is for now forced to be zero. This parameter is meant to enable the use > of sys_indirect to create syslets, asynchronously executed system calls. > This syslet approach is also the main reason for the interface in

Re: [PATCH] dio: falling through to buffered I/O when invalidation of a page fails

2007-12-11 Thread Zach Brown
Hisashi Hifumi wrote: > Hi. > > Current dio has some problems: > 1, In ext3 ordered, dio write can return with EIO because of the race > between invalidation of > a page and jbd. jbd pins the bhs while committing journal so > try_to_release_page fails when jbd > is committing the transaction.

Re: [rfc] direct IO submission and completion scalability issues

2008-02-04 Thread Zach Brown
[ ugh, still jet lagged. ] > Hi Nick, > > When Matthew was describing this work at an LCA presentation (not > sure whether you were at that presentation or not), Zach came up > with the idea that allowing the submitting application control the > CPU that the io completion processing was

Re: [2.6.24 BUG] 100% iowait on host while UML is running

2007-12-03 Thread Zach Brown
> We could check ctx->reqs_active before scheduling to determine whether > or not we are waiting for I/O, but this would require taking the > context lock in order to be accurate. Given that the test would be > only for the sake of book keeping, it might be okay to do it outside > of the lock. >

Re: [PATCH] fix invalidate_inode_pages2_range not to clear ret

2007-12-13 Thread Zach Brown
ed by earlier calls. Fix this by storing do_launder_page in a temporary variable which is only promoted to the function's return code if it hadn't already generated an error. Signed-off-by: Zach Brown <[EMAIL PROTECTED]> Cc: Hisashi Hifumi <[EMAIL PROTECTED]> diff --git a/mm/trun

Re: [PATCH] dio: falling through to buffered I/O when invalidation of a page fails

2007-12-14 Thread Zach Brown
> If anyone has a testcase - I can take a look at the problem again. I can try and throw something together.. - z -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Top kernel oopses/warnings this week

2007-12-17 Thread Zach Brown
>> Report counts may be too high due to duplicate recognition of the very >> same report.ยน > > this is true however it's .. a hard issue. It's really hard to > distinguish a duplicate report from > two reports of the same bug. Can we hack some data in to oops output to help? Say a giant

Re: [PATCH 2/6] fs/direct-io.c: Use DIV_ROUND_UP

2008-02-14 Thread Zach Brown
EMAIL PROTECTED]> Acked-By: Zach Brown <[EMAIL PROTECTED]> - z -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 00/25] AIO performance improvements/cleanups

2012-11-28 Thread Zach Brown
On Wed, Nov 28, 2012 at 08:43:24AM -0800, Kent Overstreet wrote: > Bunch of performance improvements and cleanups Zach Brown and I have > been working on. The code should be pretty solid at this point, though > it could of course use more review and testing. Thanks for sending these out

Re: [PATCH 07/25] aio: kiocb_cancel()

2012-11-28 Thread Zach Brown
On Wed, Nov 28, 2012 at 08:43:31AM -0800, Kent Overstreet wrote: > Minor refactoring, to get rid of some duplicated code A minor nit: > spin_lock_irq(>ctx_lock); > - ret = -EAGAIN; > + > kiocb = lookup_kiocb(ctx, iocb, key); > - if (kiocb && kiocb->ki_cancel) { > -

Re: [PATCH 12/25] aio: Refcounting cleanup

2012-11-28 Thread Zach Brown
> struct kioctx { > atomic_tusers; > - int dead; > + atomic_tdead; Do we want to be paranoid and atomic_set() that to 0 when the ioctx is allocated? > + while (!list_empty(>active_reqs)) { > + struct list_head

Re: [PATCH 13/25] aio: Convert read_events() to hrtimers

2012-11-28 Thread Zach Brown
> - int i = 0; > + DEFINE_WAIT(wait); > + struct hrtimer_sleeper t; > + size_t i = 0; Changing i to size_t is kind of surprising. Is that on purpose? > - set_task_state(tsk, TASK_RUNNING); > - remove_wait_queue(>wait, ); > - >

Re: [PATCH 14/25] aio: Make aio_read_evt() more efficient

2012-11-28 Thread Zach Brown
> We can't use cmpxchg() on the ring buffer's head pointer directly, since > it's modded to nr_events and would be susceptible to ABA. So instead we > maintain a shadow head that uses the full 32 bits, and cmpxchg() that > and then updated the real head pointer. Time to update this comment to

Re: [RFC, PATCH] Extensible AIO interface

2012-10-02 Thread Zach Brown
> The generic code wouldn't know about any user pointers inside > attributes, so it'd have to be downstream consumers. Hopefully there > won't be many attributes with user pointers in them (I don't expect > there to be), so we won't have too much of this messyness. I really don't like this. We

Re: [RFC] VFS: File System Mount Wide O_DIRECT Support

2012-09-04 Thread Zach Brown
> > The idea is simple, leave the desicion for the file system user to enable > > file system mount > > wide O_DIRECT support with a new mount option, for example, > I believe a better approach to your problem is actually to enable > loopback device driver to use direct IO. Someone was

[PATCH] fuse: verify all ioctl retry iov elements

2012-07-24 Thread Zach Brown
cc:ing stable because the initial commit did as well. Signed-off-by: Zach Brown CC: [2.6.37+] --- fs/fuse/file.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/fuse/file.c b/fs/fuse/file.c index b321a68..514f12a 100644 --- a/fs/fuse/file.c +++ b/fs/fuse

Re: [RFC][PATCH] Make io_submit non-blocking

2012-07-24 Thread Zach Brown
On Tue, Jul 24, 2012 at 05:11:05PM +0530, Ankit Jain wrote: > > Currently, io_submit tries to execute the io requests on the > same thread, which could block because of various reaons (eg. > allocation of disk blocks). So, essentially, io_submit ends > up being a blocking call. Yup, sadly that's

Re: [RFC][PATCH] Make io_submit non-blocking

2012-07-24 Thread Zach Brown
> And most importantly block devices, as they are one of the biggest > use cases of AIO. With an almost no-op get_blocks callback I can't > see how this change would provide any gain there. Historically we'd often see submission stuck waiting for requests. Tasks often try to submit way more aio

Re: [RFC][PATCH] Make io_submit non-blocking

2012-07-26 Thread Zach Brown
On Fri, Jul 27, 2012 at 01:22:10AM +0530, Ankit Jain wrote: > I should probably be doing better tests, any suggestions on what or > how I can test? Well, is the test actually *doing* anything with these IOs? Calling io_submit() and then immediately waiting for completion is the best case for

Re: [PATCH] mm/slab: add a leak decoder callback

2013-01-15 Thread Zach Brown
> The merge processing occurs during kmem_cache_create and you are setting > up the decoder field afterwards! Wont work. In the thread I suggested providing the callback at destruction: http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg21130.html I liked that it limits accesibility of

Re: [RFC, PATCH] Extensible AIO interface

2012-10-01 Thread Zach Brown
On Mon, Oct 01, 2012 at 03:23:41PM -0700, Kent Overstreet wrote: > So, I and other people keep running into things where we really need to > add an interface to pass some auxiliary... stuff along with a pread() or > pwrite(). Sure. Martin (cc:ed) will sympathize. > A few examples: > > * IO

Re: [RFC, PATCH] Extensible AIO interface

2012-10-01 Thread Zach Brown
> Not just per sector, Per hardware sector. For passing around checksums > userspace would have to find out the hardware sector size and checksum > type/size via a different interface, and then the attribute would > contain a pointer to a buffer that can hold the appropriate number of > checksums.

Re: Improving AIO cancellation

2013-02-08 Thread Zach Brown
> We don't know if the bio was succesfully cancelled until the bio is > completed (and this doesn't change anything about how bio completion > works) - if it was cancelled, the bi_end_io callback will get > -ECANCELLED or something. Yeah, I think that's the right design. > This is very different

Re: [PATCH][WIP v1] aio: experimental use of threads, demonstration of cancel method

2013-02-14 Thread Zach Brown
On Wed, Feb 13, 2013 at 05:16:32PM -0500, Benjamin LaHaise wrote: > This patch is purely for experimentation purposes, and is by no means > complete or cleaned up for submission yet. It is, however, useful for > demonstrating the cancellation of a kiocb when the kiocb is being > processed by

Re: [PATCH][WIP v1] aio: experimental use of threads, demonstration of cancel method

2013-02-14 Thread Zach Brown
On Thu, Feb 14, 2013 at 03:53:28PM -0500, Benjamin LaHaise wrote: > On Thu, Feb 14, 2013 at 11:33:33AM -0800, Zach Brown wrote: > > 1) The patch handles the processing thread's current->mm needing to > >match the submitting thread's. What's the plan for the rest of the

Re: [PATCH 1/2] btrfs: fix sparse address space warnings

2014-09-30 Thread Zach Brown
On Sun, Sep 28, 2014 at 03:26:04PM -0700, Omar Sandoval wrote: > On Sun, Sep 28, 2014 at 01:48:11AM -0700, Omar Sandoval wrote: > > diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c > > index 6528aa6..e0be577 100644 > > --- a/fs/btrfs/send.c > > +++ b/fs/btrfs/send.c > > @@ -515,7 +515,8 @@ static

Re: [RFC PATCH 0/7] Non-blockling buffered fs read (page cache only)

2014-09-16 Thread Zach Brown
On Mon, Sep 15, 2014 at 10:36:46PM +, Elliott, Robert (Server Storage) wrote: > > > > -Original Message- > > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > > ow...@vger.kernel.org] On Behalf Of Andreas Dilger > > Sent: Monday, 15 September, 2014 4:34 PM > > To:

Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances

2014-09-17 Thread Zach Brown
On Wed, Sep 17, 2014 at 09:56:11AM -0400, Benjamin LaHaise wrote: > On Wed, Sep 17, 2014 at 09:47:02AM -0400, Theodore Ts'o wrote: > ... > > % git version > > git version 2.1.0 > > > > Perhaps you and other people are using your own scripts, and not using > > git send-email? > > That would be

Re: Setting FS_USERNS_MOUNT in btrfs_fs_type.fs_flags

2014-09-17 Thread Zach Brown
On Wed, Sep 17, 2014 at 04:54:48AM +0100, Al Viro wrote: > On Tue, Sep 16, 2014 at 11:05:00PM -0400, Shea Levy wrote: > > Hi all, > > > > What work would be required to mark btrfs_fs_type with FS_USERNS_MOUNT > > so that btrfs images can be mounted by unprivileged users within a user > >

Re: [PATCH 2/7] Define new syscalls readv2,preadv2,writev2,pwritev2

2014-09-17 Thread Zach Brown
On Wed, Sep 17, 2014 at 12:59:30PM -0400, Theodore Ts'o wrote: > On Wed, Sep 17, 2014 at 12:05:23PM -0400, Milosz Tanski wrote: > > Theodore, > > > > I might be missing understanding something, but... I already omitted > > read2 and write2 which can be implemented in userspace by libc (as you > >

[PATCH] fs: check bh blocknr earlier when searching lru

2014-09-17 Thread Zach Brown
t; 164f: 49 39 50 20 cmp%rdx,0x20(%r8) 1653: 75 d3 jne1628 <__find_get_block+0x38> Signed-off-by: Zach Brown --- fs/buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 8f

Re: [PATCH v1 5/9] block: loop: convert to blk-mq

2014-08-27 Thread Zach Brown
On Wed, Aug 27, 2014 at 09:19:36PM +0400, Maxim Patlasov wrote: > On 08/27/2014 08:29 PM, Benjamin LaHaise wrote: > >On Wed, Aug 27, 2014 at 08:08:59PM +0400, Maxim Patlasov wrote: > >... > >>1) /dev/loop0 of 3.17.0-rc1 with Ming's patches applied -- 11K iops > >>2) the same as above, but call

[PATCH RFC 0/3] simple copy offloading system call

2015-04-10 Thread Zach Brown
Hello everyone! Here's my current attempt at the most basic system call interface for offloading copying between files. The system call and vfs function are relatively light wrappers around the file_operation method that does the heavy lifting. There was interest at LSF in getting the basic

[PATCH RFC 2/3] x86: add sys_copy_file_range to syscall tables

2015-04-10 Thread Zach Brown
Add sys_copy_file_range to the x86 syscall tables. Signed-off-by: Zach Brown --- arch/x86/syscalls/syscall_32.tbl | 1 + arch/x86/syscalls/syscall_64.tbl | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/x86/syscalls/syscall_32.tbl b/arch/x86/syscalls/syscall_32.tbl index b3560ec

[PATCH RFC 3/3] btrfs: add .copy_file_range file operation

2015-04-10 Thread Zach Brown
-off-by: Zach Brown --- fs/btrfs/ctree.h | 3 ++ fs/btrfs/file.c | 1 + fs/btrfs/ioctl.c | 91 3 files changed, 56 insertions(+), 39 deletions(-) diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index f9c89ca..f7cfa26 100644 --- a/fs/btrfs

[PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-10 Thread Zach Brown
on an existing destination file descriptor, not a path. Currently the high level vfs entry point limits copy offloading to files on the same mount and super (and not in the same file). This can be relaxed if we get implementations which can copy between file systems safely. Signed-off-by: Zach Brown --- fs

Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-10 Thread Zach Brown
On Fri, Apr 10, 2015 at 06:36:41PM -0400, Trond Myklebust wrote: > On Fri, Apr 10, 2015 at 6:00 PM, Zach Brown wrote: > > + > > +/* > > + * copy_file_range() differs from regular file read and write in that it > > + * specifically allows return partial succ

[PATCH RFC v2 0/2] O_NOCMTIME protected by generic mount option

2015-05-15 Thread Zach Brown
Here's a current draft of what is now the O_NOCMTIME series. It implements the frequent suggestion to gate unprivileged O_NOCMTIME use with a mount option. This method has the advantage of being entirely runtime. There's no persistence that'd require updating all the tools that deal with each

[PATCH RFC v2 2/2] vfs: add O_NOCMTIME

2015-05-15 Thread Zach Brown
set. This requires priviledged intervention to testify that mtime isn't critical to, say, backup infrastructure or NFS server consistency guarantees. Signed-off-by: Zach Brown --- fs/fcntl.c | 30 +++--- fs/inode.c | 2 +- fs

[PATCH RFC v2 1/2] vfs: add generic nocmtime mount flag

2015-05-15 Thread Zach Brown
O_NOCMTIME to prevent cmtime updates without harm. Signed-off-by: Zach Brown --- fs/namespace.c | 2 ++ fs/proc_namespace.c | 1 + fs/statfs.c | 2 ++ include/linux/mount.h | 1 + include/linux/statfs.h | 1 + include/uapi/linux/fs.h | 1 + 6 files changed, 8 insertions

Re: [RFC 1/1 linux-next] btrfs: don't opencode zero_user_segment

2014-10-14 Thread Zach Brown
On Tue, Oct 14, 2014 at 07:46:14PM +0200, Fabian Frederick wrote: > use function defined in include/linux/highmem.h > Note that this reverts 2 last function call order And adds a BUG_ON(PAGE_CACHE_SIZE > PAGE_SIZE). We can take bets on whether that will ever trigger. - z -- To unsubscribe from

Re: [RFC 1/1 linux-next] btrfs: don't opencode zero_user_segment

2014-10-15 Thread Zach Brown
On Tue, Oct 14, 2014 at 10:18:09PM +0200, Fabian Frederick wrote: > > > > On 14 October 2014 at 21:15 Zach Brown wrote: > > > > > > On Tue, Oct 14, 2014 at 07:46:14PM +0200, Fabian Frederick wrote: > > > use function defined in include/linux/highme

[PATCH] target/file: fix inclusive vfs_fsync_range() end

2014-10-06 Thread Zach Brown
. This is untested. I found the errors by inspection while following other code. Signed-off-by: Zach Brown --- drivers/target/target_core_file.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c index

[PATCH] nfsd: fix inclusive vfs_fsync_range() end

2014-10-06 Thread Zach Brown
in write processing. Maybe a helper would be nice but I kept it trivial. This is untested. I found it while reviewing code for something else entirely. Signed-off-by: Zach Brown --- fs/nfsd/vfs.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/fs/nfsd/vfs.c b/fs/nfsd

Re: [PATCH] target/file: fix inclusive vfs_fsync_range() end

2014-10-07 Thread Zach Brown
On Mon, Oct 06, 2014 at 11:39:45PM -0700, Christoph Hellwig wrote: > On Mon, Oct 06, 2014 at 04:40:13PM -0700, Zach Brown wrote: > > Both of the file target's calls to vfs_fsync_range() got the end offset > > off by one. The range is inclusive, not exclusive. It would sync a bi

Re: [PATCH v2 1/3] btrfs: replace open-coded kernel_write

2014-09-30 Thread Zach Brown
On Tue, Sep 30, 2014 at 03:01:40PM -0700, Omar Sandoval wrote: > write_buf used by btrfs send has what is more or less a reimplementation of > kernel_write. This also gets rid of a sparse address space warning. Seems reasonable to me: Reviewed-by: Zach Brown - z -- To unsubscrib

[PATCH RFC] vfs: add a O_NOMTIME flag

2015-05-06 Thread Zach Brown
O_NOMTIME. Maybe a mount option? Signed-off-by: Zach Brown Cc: Sage Weil --- fs/fcntl.c | 12 +++- fs/inode.c | 2 +- fs/namei.c | 4 ++-- include/linux/fs.h | 7 +-- include/uapi/asm-generic/fcntl.h | 4

Re: [PATCH RFC] vfs: add a O_NOMTIME flag

2015-05-06 Thread Zach Brown
On Wed, May 06, 2015 at 03:19:13PM -0700, Sage Weil wrote: > On Wed, 6 May 2015, Trond Myklebust wrote: > > Hi Zach, > > > > On Wed, May 6, 2015 at 6:00 PM, Zach Brown wrote: > > > > > > Add the O_NOMTIME flag which prevents mtime from being updated which c

Re: [PATCH RFC] vfs: add a O_NOMTIME flag

2015-05-07 Thread Zach Brown
On Thu, May 07, 2015 at 10:26:17AM +1000, Dave Chinner wrote: > On Wed, May 06, 2015 at 03:00:12PM -0700, Zach Brown wrote: > > Add the O_NOMTIME flag which prevents mtime from being updated which can > > greatly reduce the IO overhead of writes to allocated and initialized >

Re: [PATCH RFC] vfs: add a O_NOMTIME flag

2015-05-07 Thread Zach Brown
> > > The criteria for using O_NOMTIME is the same as for using O_NOATIME: > > > owning the file or having the CAP_FOWNER capability. If we're not > > > comfortable allowing owners to prevent mtime/ctime updates then we > > > should add a tunable to allow O_NOMTIME. Maybe a mount option? > > >

Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-13 Thread Zach Brown
> > >> Could we perhaps instead of a length, define a 'pos_in_start' and a > > >> 'pos_in_end' offset (with the latter being -1 for a full-file copy) > > >> and then return an 'loff_t' value stating where the copy ended? > > > > > > Well, the resulting offset will be set if the caller provided it.

Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-14 Thread Zach Brown
On Tue, Apr 14, 2015 at 02:19:11PM -0400, J. Bruce Fields wrote: > On Tue, Apr 14, 2015 at 01:16:13PM -0400, Anna Schumaker wrote: > > On 04/14/2015 12:53 PM, Christoph Hellwig wrote: > > > On Sat, Apr 11, 2015 at 09:04:02AM -0400, Jeff Layton wrote: > > >> Yuck! How the heck do you clean up the

Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-14 Thread Zach Brown
On Tue, Apr 14, 2015 at 02:29:06PM -0400, J. Bruce Fields wrote: > On Tue, Apr 14, 2015 at 11:22:41AM -0700, Zach Brown wrote: > > On Tue, Apr 14, 2015 at 02:19:11PM -0400, J. Bruce Fields wrote: > > > On Tue, Apr 14, 2015 at 01:16:13PM -0400, Anna Schumaker wrote: > > &g

Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-14 Thread Zach Brown
On Tue, Apr 14, 2015 at 12:23:25PM -0700, Christoph Hellwig wrote: > On Tue, Apr 14, 2015 at 11:54:08AM -0700, Zach Brown wrote: > > Is this relying on btrfs range cloning being atomic? It certainly > > doesn't look atomic. It can modify items across an arbitrarily large >

Re: [PATCH RFC] vfs: add a O_NOMTIME flag

2015-05-08 Thread Zach Brown
On Thu, May 07, 2015 at 06:01:23PM -0700, Sage Weil wrote: > On Thu, 7 May 2015, Zach Brown wrote: > > On Thu, May 07, 2015 at 10:26:17AM +1000, Dave Chinner wrote: > > > On Wed, May 06, 2015 at 03:00:12PM -0700, Zach Brown wrote: > > > > The criteria for using O_NO

Re: [PATCH 0/2] mmc: sdhci-pci: Use ACPI to set max frequency of sdio host

2016-11-22 Thread Zach Brown
On Tue, Nov 22, 2016 at 09:27:29AM +0100, Ulf Hansson wrote: > > Please try to not forget to bump the version number and to provide a > history of the what changes between revisions. It makes life easier > when reviewing and when I am about to apply patches. > Sorry, I'll make sure to include a

[PATCH v2 2/2] mmc: sdhci-pci: Use ACPI to get max frequency for Intel byt sdio controller sub-vended by NI

2016-11-22 Thread Zach Brown
Amero Reviewed-by: Josh Cartwright Signed-off-by: Zach Brown --- drivers/mmc/host/sdhci-pci-core.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c index 9741505..34284b8 100644 --- a/drivers

[PATCH v2 0/2] mmc: sdhci-pci: Use ACPI to set max frequency of sdio host controller

2016-11-22 Thread Zach Brown
()/acpi_evaluate_object() pv1: * Removed redundant comment * Print info message if MXFQ not found in acpi table pv2: * Changed info message to error message if MXFQ not found * Replaced ni_byt_sdio_probe_slot with one of two versions depending on whether CONFIG_ACPI is set. Zach Brown (2

[PATCH v2 1/2] mmc: sdhci-pci: Add PCI ID for Intel byt sdio host controller sub-vended by NI

2016-11-22 Thread Zach Brown
Add PCI ID for Intel byt sdio host controller sub-vended by NI. The controller has different behavior because of the board layout NI puts it on. Signed-off-by: Zach Brown --- drivers/mmc/host/sdhci-pci-core.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers

Re: [PATCH v2] UBI: add debugfs file for tracking PEB state

2016-09-21 Thread Zach Brown
On Wed, Sep 21, 2016 at 01:13:29PM +0200, Richard Weinberger wrote: > Zach, > > On 20.09.2016 22:45, Zach Brown wrote: > > From: Ben Shelton > > > > Add a file under debugfs to allow easy access to the erase count for > > each physical erase block on an

[RFC 1/2] sdhci: Add device tree property sd-broken-highspeed

2016-09-23 Thread Zach Brown
that highspeed will not work. Signed-off-by: Zach Brown --- Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt index 8a37782..59332ea 100644 --- a/Documentation

[RFC 2/2] sdhci: Prevent SD from doing highspeed timing when sd-broken-highspeed property is set

2016-09-23 Thread Zach Brown
or some other issue make highspeed impossible. Signed-off-by: Chen Yee Chew Reviewed-by: Keng Soon Cheah Reviewed-by: Joe Hershberger Signed-off-by: Zach Brown --- drivers/mmc/host/sdhci-pltfm.c | 3 +++ drivers/mmc/host/sdhci.c | 3 ++- drivers/mmc/host/sdhci.h | 2 ++ 3 files changed

[RFC 0/2] Add device tree property and quirk for supporting sdhci

2016-09-23 Thread Zach Brown
property is set Zach Brown (1): sdhci: Add device tree property sd-broken-highspeed Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++ arch/arm/boot/dts/ni-77D5.dts | 1 - drivers/mmc/host/sdhci-pltfm.c| 3 +++ drivers/mmc/host/sdhci.c | 3

Re: [RFC 1/2] sdhci: Add device tree property sd-broken-highspeed

2016-10-07 Thread Zach Brown
on > >>> wrote: > >>>> On 23 September 2016 at 22:01, Zach Brown wrote: > >>>>> Certain board configurations can make highspeed malfunction due to > >>>>> timing issues. In these cases a way is needed to force the controller > >

[RFC v3 3/3] phy,leds: add support for led triggers on phy link state change

2016-10-07 Thread Zach Brown
changes on the phy. Signed-off-by: Josh Cartwright Signed-off-by: Nathan Sullivan Signed-off-by: Zach Brown --- drivers/net/phy/Kconfig| 13 +++- drivers/net/phy/Makefile | 1 + drivers/net/phy/phy.c | 1 + drivers/net/phy/phy_device.c | 4

[PATCH 0/3] Add support for led triggers on phy link state change

2016-10-07 Thread Zach Brown
and improve consistency. * Dropped rtl8712 patch that was accepted separately. Josh Cartwright (1): phy,leds: add support for led triggers on phy link state change Zach Brown (2): skge: Change LED_OFF to LED_REG_OFF in marvel skge driver to avoid conflicts with leds namespace phy: Encapsulate

[RFC v3 2/3] phy: Encapsulate actions performed during link state changes into function phy_adjust_link

2016-10-07 Thread Zach Brown
ore. Actions that should occur whenever the phy link is adjusted can now be added to the phy_adjust_link function. Signed-off-by: Zach Brown --- drivers/net/phy/phy.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/ph

[RFC v3 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

2016-10-07 Thread Zach Brown
changed LED_ON to LED_REG_ON to avoid possible future conflict and for consistency. Signed-off-by: Zach Brown --- drivers/net/ethernet/marvell/skge.c | 6 +++--- drivers/net/ethernet/marvell/skge.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet

Re: [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set.

2016-10-24 Thread Zach Brown
On Mon, Oct 24, 2016 at 10:34:46AM +0300, Adrian Hunter wrote: > On 22/10/16 00:35, Zach Brown wrote: > > When the sdhci-cap-speed-modes-broken DT property is set, the driver > > will ignore the bits of the capability registers that correspond to > > speed modes. > > &g

[RFC v3 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set.

2016-10-24 Thread Zach Brown
When the sdhci-cap-speed-modes-broken DT property is set, the driver will ignore the bits of the capability registers that correspond to speed modes. Signed-off-by: Zach Brown --- drivers/mmc/host/sdhci.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff

[RFC v3 0/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set.

2016-10-24 Thread Zach Brown
of bits to clear in sdhci cap1, not sure that's all of the them now, but I think so. v3: * Read "sdhci-cap-speed-modes-broken" only once. * If caps are provided to sdhci_read_caps the speed bits are not overwritten. Zach Brown (2): mmc: sdhci: Add device tree property sdhci-cap-s

[RFC v3 1/2] mmc: sdhci: Add device tree property sdhci-cap-speed-modes-broken

2016-10-24 Thread Zach Brown
. Signed-off-by: Zach Brown --- Documentation/devicetree/bindings/mmc/mmc.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt index 8a37782..671d6c0 100644 --- a/Documentation/devicetree/bindings/mmc

[RFC 2/2] mmc: sdhci: Use sdhci-caps-mask and sdhci-caps to change the caps read during __sdhci_read_caps

2016-10-25 Thread Zach Brown
__sdhci_read_caps Use the sdhci-caps-mask property to turn off the incorrect bits of the sdhci registers after reading them. Use the sdhci-caps to turn on bits after using sdhci-caps-mask to turn off the incorrect ones. Signed-off-by: Zach Brown --- drivers/mmc/host/sdhci.c | 24

[RFC 0/2] mmc: sdhci: Fix sdhci caps register bits with corrections provided by dt

2016-10-25 Thread Zach Brown
represent the correction to the sdhci caps register. The second patch uses the new dt properties to correct the caps from the register as they read during __sdhci_read_caps. Zach Brown (2): mmc: sdhci: dt: Add device tree properties sdhci-caps and sdhci-caps-mask mmc: sdhci: Use sdhci-caps-mask

[RFC 1/2] mmc: sdhci: dt: Add device tree properties sdhci-caps and sdhci-caps-mask

2016-10-25 Thread Zach Brown
on. Signed-off-by: Zach Brown --- Documentation/devicetree/bindings/mmc/mmc.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt index 8a37782..1415aa0 100644 --- a/Documentation/devicetree

Re: [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set.

2016-10-26 Thread Zach Brown
On Tue, Oct 25, 2016 at 02:30:25PM +0300, Adrian Hunter wrote: > On 24/10/16 18:48, Zach Brown wrote: > > On Mon, Oct 24, 2016 at 10:34:46AM +0300, Adrian Hunter wrote: > >> On 22/10/16 00:35, Zach Brown wrote: > >>> When the sdhci-cap-speed-modes-broken

Re: Pure polling mode for netdevices

2016-10-27 Thread Zach Brown
On Fri, Oct 21, 2016 at 11:41:46AM -0700, Eric Dumazet wrote: > On Fri, 2016-10-21 at 13:03 -0500, Zach Brown wrote: > > Is there a way to get NAPI to poll all the time? > > Or just any way to get netdevices to use only polling and no interrupts? > > > > We have some

[RESEND PATCH v2 3/3] mtd: ubi: use 'max_bad_blocks' to compute bad_peb_limit if available

2016-10-27 Thread Zach Brown
From: Jeff Westfahl Use the MTD function 'max_bad_blocks' to compute the UBI bad_peb_limit, if the function is implemented for an MTD and doesn't return an error. Signed-off-by: Jeff Westfahl Signed-off-by: Zach Brown --- drivers/mtd/ubi/build.c | 9 + 1 file changed, 9 insertions

[RESEND PATCH v2 0/3] mtd: use ONFI bad blocks per LUN to calculate UBI bad PEB limit

2016-10-27 Thread Zach Brown
For ONFI-compliant NAND devices, the ONFI parameters report the maximum number of bad blocks per LUN that will be encountered over the lifetime of the device, so we can use that information to get a more accurate (and smaller) value for the UBI bad PEB limit. The ONFI parameter "maxiumum number

[RESEND PATCH v2 1/3] mtd: introduce function max_bad_blocks

2016-10-27 Thread Zach Brown
From: Jeff Westfahl If implemented, 'max_bad_blocks' returns the maximum number of bad blocks to reserve for an MTD. An implementation for NAND is coming soon. Signed-off-by: Jeff Westfahl Signed-off-by: Zach Brown --- drivers/mtd/mtdpart.c | 12 include/linux/mtd/mtd.h | 1

[RESEND PATCH v2 2/3] mtd: nand: implement 'max_bad_blocks' mtd function

2016-10-27 Thread Zach Brown
From: Jeff Westfahl Implement the new mtd function 'max_bad_blocks'. Use the ONFI parameter page to find the maximum bad blocks to reserve for an MTD, taking into account how many LUNs the MTD spans. Signed-off-by: Jeff Westfahl Signed-off-by: Zach Brown --- drivers/mtd/nand/nand_base.c | 34

[PATCH 1/2] mmc: sdhci: dt: Add device tree properties sdhci-caps and sdhci-caps-mask

2016-10-28 Thread Zach Brown
on. Signed-off-by: Zach Brown --- Documentation/devicetree/bindings/mmc/sdhci.txt | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/devicetree/bindings/mmc/sdhci.txt diff --git a/Documentation/devicetree/bindings/mmc/sdhci.txt b/Documentation/devicetree

[PATCH 2/2] mmc: sdhci: Use sdhci-caps-mask and sdhci-caps to change the caps read during __sdhci_read_caps

2016-10-28 Thread Zach Brown
__sdhci_read_caps Use the sdhci-caps-mask property to turn off the incorrect bits of the sdhci register after reading them. Use the sdhci-caps to turn on bits after using sdhci-caps-mask to turn off the incorrect ones. Signed-off-by: Zach Brown --- drivers/mmc/host/sdhci.c | 24

[PATCH 0/2] mmc: sdhci: Fix sdhci caps register bits with corrections provided by dt

2016-10-28 Thread Zach Brown
represent the correction to the sdhci caps register. The second patch uses the new dt properties to correct the caps from the register as they read during __sdhci_read_caps. Changes from RFC: * /s/registers/register * Moved sdhci dt properties into new documentation file sdhci.txt Zach Brown (2

[PATCH v3 3/5] mtd: nand: Add bb_per_lun and blocks_per_lun fields to nand_chip

2016-10-28 Thread Zach Brown
The fields bb_per_lun and blocks_per_lun are useful determining the number of bad blocks a MTD needs to allocate. How they are set will depend on if the chip is ONFI, JEDEC or a fuill-id entry in the nand_ids table. Signed-off-by: Zach Brown --- include/linux/mtd/nand.h | 5 + 1 file

[PATCH v3 1/5] mtd: introduce function max_bad_blocks

2016-10-28 Thread Zach Brown
From: Jeff Westfahl If implemented, 'max_bad_blocks' returns the maximum number of bad blocks to reserve for an MTD. An implementation for NAND is coming soon. Signed-off-by: Jeff Westfahl Signed-off-by: Zach Brown --- drivers/mtd/mtdpart.c | 13 + include/linux/mtd/mtd.h | 11

[PATCH v3 4/5] mtd: nand: implement 'max_bad_blocks' mtd function

2016-10-28 Thread Zach Brown
Implement the new mtd function 'max_bad_blocks'. Using the chip's bb_per_lun and blocks_per_lun fields to determine the maximum bad blocks to reserve for an MTD. Signed-off-by: Jeff Westfahl Signed-off-by: Zach Brown --- drivers/mtd/nand/nand_base.c | 35 +++ 1

[PATCH v3 2/5] mtd: ubi: use 'max_bad_blocks' to compute bad_peb_limit if available

2016-10-28 Thread Zach Brown
From: Jeff Westfahl Use the MTD function 'max_bad_blocks' to compute the UBI bad_peb_limit, if the function is implemented for an MTD and doesn't return an error. Signed-off-by: Jeff Westfahl Signed-off-by: Zach Brown --- drivers/mtd/ubi/build.c | 4 1 file changed, 4 insertions

[PATCH v3 5/5] mtd: nand: set bb_per_lun and blocks_per_lun for ONFI compliant chips

2016-10-28 Thread Zach Brown
ONFI compliant chips contain the values for the bb_per_lun and blocks_per_lun fields in the parameter page. When the ONFI paged is retrieved/parsed the chip's fields are set by the corresponding fields in the param page. Signed-off-by: Zach Brown --- drivers/mtd/nand/nand_base.c | 5 + 1

[PATCH v3 0/5] mtd: use ONFI bad blocks per LUN to calculate UBI bad PEB limit

2016-10-28 Thread Zach Brown
fi * Max bad blocks calculation now uses the new nand_chip fields [1] http://lkml.iu.edu/hypermail/linux/kernel/1505.1/04822.html Jeff Westfahl (2): mtd: introduce function max_bad_blocks mtd: ubi: use 'max_bad_blocks' to compute bad_peb_limit if available Zach Brown (3): mtd:

[PATCH 2/2] sdhci-of-arasan: Set controller to test mode when fails-without-test-cd is present

2016-08-29 Thread Zach Brown
the controller to function without the CD bit. When the device has the property fails-without-test-cd the driver changes the controller to test mode and sets test inserted to true to make the controller function. Signed-off-by: Zach Brown --- drivers/mmc/host/sdhci-of-arasan.c | 34

[PATCH 1/2] sdhci-of-arasan: Add device tree parameter fails-without-test-cd bit

2016-08-29 Thread Zach Brown
the controller to function without the CD bit. The device property "fails-without-test-cd" will let the arasan driver know the controller does not have the CD line wired and that the controller does not function without it. Signed-off-by: Zach Brown --- v2: * improved commit messages * remov

<    4   5   6   7   8   9   10   11   >