[PATCH v6 08/11] VFS hot tracking: Add documentation

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu Add Documentation for VFS hot tracking feature Signed-off-by: Chandra Seetharaman Signed-off-by: Zhi Yong Wu --- Documentation/filesystems/00-INDEX | 2 + Documentation/filesystems/hot_tracking.txt | 207 + 2 files changed, 209

[PATCH v6 11/11] MAINTAINERS: add the maintainers for VFS hot tracking

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu This patch adds maintainer information for VFS hot tracking into the MAINTAINERS file. Signed-off-by: Zhi Yong Wu Signed-off-by: Chandra Seetharaman --- MAINTAINERS | 12 1 file changed, 12 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ffcaf97

[PATCH v6 06/11] VFS hot tracking: Add a /proc interface to make the interval tunable

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu Add a /proc interface hot-update-interval under the dir /proc/sys/fs/ in order to turn HOT_UPDATE_INTERVAL into a tunable parameter. Signed-off-by: Chandra Seetharaman Signed-off-by: Zhi Yong Wu --- fs/hot_tracking.c| 6 -- fs/hot_tracking.h| 2

[PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu Introduce a /proc interface hot-mem-high-thresh and to cap the memory which is consumed by hot_inode_item and hot_range_item, and they will be in the unit of 1M bytes. Signed-off-by: Chandra Seetharaman Signed-off-by: Zhi Yong Wu --- fs/hot_tracking.c| 29

[PATCH v6 05/11] VFS hot tracking: Add an ioctl to get hot tracking information

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu FS_IOC_GET_HEAT_INFO: return a struct containing the various metrics collected in hot_freq_data structs, and also return a calculated data temperature based on those metrics. Optionally, retrieve the temperature from the hot data hash list instead of recalculating it. Signed

[PATCH v6 02/11] VFS hot tracking: Track IO and record heat information

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu This patch adds read/write code paths: include read_pages(), do_writepages(), do_generic_file_read() and __blockdev_direct_IO() to record heat information. When real disk i/o for an inode is done, its own hot_inode_item will be created or updated in the RB tree for the

[PATCH v6 04/11] VFS hot tracking: Add shrinker functionality to curtail memory usage

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu Register a shrinker to control the amount of memory that is used in tracking hot regions. If we are throwing inodes out of memory due to memory pressure, we most definitely are going to need to reduce the amount of memory the tracking code is using, even if it means losing

[PATCH v6 00/11] VFS hot tracking

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu The patchset is trying to introduce hot tracking function in VFS layer, which will keep track of real disk I/O in memory. By it, you will easily know more details about disk I/O, and then detect where disk I/O hot spots are. Also, specific FS can take use of it to do accurate

Re: [PATCH 2/2] mm: fix the comment in zlc_setup()

2013-11-04 Thread Zhi Yong Wu
CCed Andrew Morton On Thu, Oct 31, 2013 at 8:52 PM, Zhi Yong Wu wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index dd88

Re: [PATCH 1/2] mm: fix the incorrect function name in alloc_low_pages()

2013-11-04 Thread Zhi Yong Wu
CCed Andrew Morton On Thu, Oct 31, 2013 at 8:52 PM, Zhi Yong Wu wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > --- > arch/x86/mm/init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c

[PATCH 1/2] mm: fix the incorrect function name in alloc_low_pages()

2013-10-31 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- arch/x86/mm/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index 04664cd..64d860f 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -53,12 +53,12 @@ __ref void

[PATCH 2/2] mm: fix the comment in zlc_setup()

2013-10-31 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index dd886fa..3d94d0c 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1711,7 +1711,7 @@ bool zone_watermark_ok_safe

[PATCH] net, mc: fix the incorrect comments in two mc-related functions

2013-10-28 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/core/dev_addr_lists.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c index 6cda4e2..ec40a84 100644 --- a/net/core/dev_addr_lists.c +++ b/net/core/dev_addr_lists.c

[PATCH v2 3/3] net, iovec: fix the incorrect comment in memcpy_fromiovecend()

2013-10-27 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/core/iovec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/iovec.c b/net/core/iovec.c index b77eeec..4cdb7c4 100644 --- a/net/core/iovec.c +++ b/net/core/iovec.c @@ -100,7 +100,7 @@ int memcpy_toiovecend(const

[PATCH v2 1/3] vxlan: silence one build warning

2013-10-27 Thread Zhi Yong Wu
From: Zhi Yong Wu drivers/net/vxlan.c: In function ‘vxlan_sock_add’: drivers/net/vxlan.c:2298:11: warning: ‘sock’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/net/vxlan.c:2275:17: note: ‘sock’ was declared here LD drivers/net/built-in.o Signed-off-by: Zhi

[PATCH v2 2/3] net, datagram: fix the incorrect comment in zerocopy_sg_from_iovec()

2013-10-27 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/core/datagram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/datagram.c b/net/core/datagram.c index af814e7..a16ed7b 100644 --- a/net/core/datagram.c +++ b/net/core/datagram.c @@ -577,7 +577,7 @@ EXPORT_SYMBOL

Re: [PATCH 1/3] vxlan: silence one build warning

2013-10-26 Thread Zhi Yong Wu
HI, Stephen I saw it on Fedora 17 without latest kernel. Then what do you think that it is appropriate to solve this problem? discard this patch? If yes, i can also agree. On Sat, Oct 26, 2013 at 10:48 PM, Stephen Hemminger wrote: > On Sat, 26 Oct 2013 15:06:04 +0800 > Zhi Yong Wu

Re: [PATCH 1/3] vxlan: silence one build warning

2013-10-26 Thread Zhi Yong Wu
On Fri, Oct 25, 2013 at 11:41 PM, Stephen Hemminger wrote: > On Fri, 25 Oct 2013 15:49:18 +0800 > Zhi Yong Wu wrote: > >> From: Zhi Yong Wu >> >> drivers/net/vxlan.c: In function ‘vxlan_sock_add’: >> drivers/net/vxlan.c:2298:11: warning: ‘sock’ may be used u

[PATCH 1/3] vxlan: silence one build warning

2013-10-25 Thread Zhi Yong Wu
From: Zhi Yong Wu drivers/net/vxlan.c: In function ‘vxlan_sock_add’: drivers/net/vxlan.c:2298:11: warning: ‘sock’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/net/vxlan.c:2275:17: note: ‘sock’ was declared here LD drivers/net/built-in.o Signed-off-by: Zhi

[PATCH 2/3] net, datagram: fix the uncorrect comment in zerocopy_sg_from_iovec()

2013-10-25 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/core/datagram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/datagram.c b/net/core/datagram.c index af814e7..a16ed7b 100644 --- a/net/core/datagram.c +++ b/net/core/datagram.c @@ -577,7 +577,7 @@ EXPORT_SYMBOL

[PATCH 3/3] net, iovec: fix the uncorrect comment in memcpy_fromiovecend()

2013-10-25 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/core/iovec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/iovec.c b/net/core/iovec.c index b77eeec..4cdb7c4 100644 --- a/net/core/iovec.c +++ b/net/core/iovec.c @@ -100,7 +100,7 @@ int memcpy_toiovecend(const

Re: [PATCH v5 00/10] VFS hot tracking

2013-09-24 Thread Zhi Yong Wu
On Tue, Sep 24, 2013 at 8:20 AM, Al Viro wrote: > On Tue, Sep 17, 2013 at 06:17:45AM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> The patchset is trying to introduce hot tracking function in >> VFS layer, which will keep track of real disk I/O in

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-04 Thread Zhi Yong Wu
On Thu, Sep 5, 2013 at 9:12 AM, Davidlohr Bueso wrote: > On Thu, 2013-09-05 at 08:37 +0800, Zhi Yong Wu wrote: >> On Thu, Sep 5, 2013 at 7:59 AM, Davidlohr Bueso wrote: >> > On Thu, 2013-09-05 at 01:22 +0800, Zhi Yong Wu wrote: >> >> On Mon, Sep 2, 2013

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-04 Thread Zhi Yong Wu
On Thu, Sep 5, 2013 at 7:59 AM, Davidlohr Bueso wrote: > On Thu, 2013-09-05 at 01:22 +0800, Zhi Yong Wu wrote: >> On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote: >> > On Sun, Sep 1, 2013 at 11:30 PM, Zhi Yong Wu wrote: >> >> In Tue, Aug 27, 2013

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-04 Thread Zhi Yong Wu
On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote: > On Sun, Sep 1, 2013 at 11:30 PM, Zhi Yong Wu wrote: >> In Tue, Aug 27, 2013 at 6:01 AM, Michel Lespinasse wrote: >>> On Fri, Aug 23, 2013 at 7:45 AM, wrote: >>>> From: Zhi Yong Wu >&g

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-02 Thread Zhi Yong Wu
On Tue, Sep 3, 2013 at 1:48 PM, Michel Lespinasse wrote: > On Mon, Sep 2, 2013 at 9:45 PM, Zhi Yong Wu wrote: >> On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote: >>> Thanks for the link - I now better understand where you are coming >>> from with these fixes

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-02 Thread Zhi Yong Wu
On Tue, Sep 3, 2013 at 1:48 PM, Michel Lespinasse wrote: > On Mon, Sep 2, 2013 at 9:45 PM, Zhi Yong Wu wrote: >> On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote: >>> Thanks for the link - I now better understand where you are coming >>> from with these fixes

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-02 Thread Zhi Yong Wu
On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote: > On Sun, Sep 1, 2013 at 11:30 PM, Zhi Yong Wu wrote: >> In Tue, Aug 27, 2013 at 6:01 AM, Michel Lespinasse wrote: >>> On Fri, Aug 23, 2013 at 7:45 AM, wrote: >>>> From: Zhi Yong Wu >&g

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-01 Thread Zhi Yong Wu
In Tue, Aug 27, 2013 at 6:01 AM, Michel Lespinasse wrote: > On Fri, Aug 23, 2013 at 7:45 AM, wrote: >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> --- >> include/linux/rbtree_augmented.h | 3 ++- >> lib/rbtree.c | 5 +++--

Re: [PATCH] scsi: fix the build warning

2013-08-21 Thread Zhi Yong Wu
eturn -EINVAL; > } > > - if (scsi_debug_guard > 1) { > + if (scsi_debug_guard < 0 || scsi_debug_guard > 1) { I don't think that it can fix that issue. > printk(KERN_ERR "scsi_debug_init: guard must be 0 or 1\n"); >

Re: [PATCH] scsi: fix the build warning

2013-08-21 Thread Zhi Yong Wu
HI, If you'd like, you should draft one patch for this warning. On Thu, Aug 22, 2013 at 9:02 AM, Joe Perches wrote: > On Thu, 2013-08-22 at 08:44 +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Initialize csum variable to fix the build warning. &

Re: [PATCH v3] xfs: introduce object readahead to log recovery

2013-08-13 Thread Zhi Yong Wu
On Wed, Aug 14, 2013 at 1:35 PM, Dave Chinner wrote: > On Wed, Jul 31, 2013 at 04:42:45PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> It can take a long time to run log recovery operation because it is >> single threaded and is bound by read latenc

Re: [PATCH v3] xfs: introduce object readahead to log recovery

2013-08-07 Thread Zhi Yong Wu
HI, xfs maintainers, any comments? On Wed, Jul 31, 2013 at 4:42 PM, wrote: > From: Zhi Yong Wu > > It can take a long time to run log recovery operation because it is > single threaded and is bound by read latency. We can find that it took > most of the time to wait for the r

Re: [PATCH v2] xfs: introduce object readahead to log recovery

2013-07-31 Thread Zhi Yong Wu
On Wed, Jul 31, 2013 at 9:35 PM, Ben Myers wrote: > Hey Zhi, > > On Wed, Jul 31, 2013 at 12:07:32PM +0800, Zhi Yong Wu wrote: >> On Wed, Jul 31, 2013 at 7:11 AM, Dave Chinner wrote: >> > On Tue, Jul 30, 2013 at 05:59:07PM +0800, zwu.ker...@gmail.com wrote:

Re: [PATCH v2] xfs: introduce object readahead to log recovery

2013-07-30 Thread Zhi Yong Wu
On Wed, Jul 31, 2013 at 7:11 AM, Dave Chinner wrote: > On Tue, Jul 30, 2013 at 05:59:07PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> It can take a long time to run log recovery operation because it is >> single threaded and is bound by read latenc

Re: [PATCH v2] xfs: introduce object readahead to log recovery

2013-07-30 Thread Zhi Yong Wu
On Tue, Jul 30, 2013 at 9:10 PM, Brian Foster wrote: > On 07/30/2013 05:59 AM, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> It can take a long time to run log recovery operation because it is >> single threaded and is bound by read latency. We can find

Re: [PATCH] xfs: fix an assertion failure

2013-07-29 Thread Zhi Yong Wu
On Fri, Jul 26, 2013 at 7:37 PM, Dave Chinner wrote: > On Fri, Jul 26, 2013 at 02:01:23PM +0800, Zhi Yong Wu wrote: >> No, it still raised the same assertion as below: >> >> [ 521.715103] XFS: Assertion failed: !(bip->bli_item.li_flags & >> XFS_LI_IN_AIL), file

Re: [PATCH] xfs: introduce object readahead to log recovery

2013-07-28 Thread Zhi Yong Wu
On Mon, Jul 29, 2013 at 10:45 AM, Dave Chinner wrote: > On Mon, Jul 29, 2013 at 09:38:11AM +0800, Zhi Yong Wu wrote: >> By the way, how do you try the workload which has nothing but dirty >> dquote objects? > > Create quota limits for non-existent users. That will allocate t

Re: [PATCH] xfs: introduce object readahead to log recovery

2013-07-28 Thread Zhi Yong Wu
On Fri, Jul 26, 2013 at 7:35 PM, Dave Chinner wrote: > On Fri, Jul 26, 2013 at 02:36:15PM +0800, Zhi Yong Wu wrote: >> Dave, >> >> All comments are good to me, and will be applied to next version, thanks a >> lot. >> >> On Fri, Jul 26, 2013 at 10:50 AM, D

Re: [PATCH] xfs: introduce object readahead to log recovery

2013-07-25 Thread Zhi Yong Wu
Dave, All comments are good to me, and will be applied to next version, thanks a lot. On Fri, Jul 26, 2013 at 10:50 AM, Dave Chinner wrote: > On Thu, Jul 25, 2013 at 04:23:39PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> It can take a long time to run l

Re: [PATCH] xfs: fix an assertion failure

2013-07-25 Thread Zhi Yong Wu
at 09:38:44PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> When running the compilebench, one assertion failure was found. >> This related line of code was introduced by commit 5f6bed76c0. >> >> commit 5f6bed76c0c85cb4d04885a5de00b629deee550b &

Re: [PATCH v2 00/12] VFS hot tracking

2013-05-23 Thread Zhi Yong Wu
HI, Al Viro. I have incorporated all comments from all reviewers and waited for so long time. If you have no comments, can you merge the patchset? thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH v2 00/12] VFS hot tracking

2013-05-21 Thread Zhi Yong Wu
Ping... On Tue, May 14, 2013 at 8:59 AM, wrote: > From: Zhi Yong Wu > > The patchset is trying to introduce hot tracking function in > VFS layer, which will keep track of real disk I/O in memory. > By it, you will easily know more details about disk I/O, and > then detect

Re: [PATCH RESEND v1 00/16] vfs: hot data tracking

2013-02-21 Thread Zhi Yong Wu
ping? any comments? On Thu, Dec 20, 2012 at 10:43 PM, wrote: > From: Zhi Yong Wu > > HI, guys, > > This patchset has been done scalability or performance tests > by fs_mark, ffsb and compilebench. > I have done the perf testing on Linux 3.7.0-rc8+ with Intel(R) C

Re: [PATCH RESEND v1 03/16] vfs: add I/O frequency update function

2013-01-11 Thread Zhi Yong Wu
On Fri, Jan 11, 2013 at 10:27 PM, David Sterba wrote: > On Fri, Jan 11, 2013 at 03:38:31PM +0800, Zhi Yong Wu wrote: >> On Thu, Jan 10, 2013 at 8:51 AM, David Sterba wrote: >> > On Thu, Dec 20, 2012 at 10:43:22PM +0800, zwu.ker...@gmail.com wrote: >> >> --- a/fs

Re: [PATCH RESEND v1 06/16] vfs: add temp calculation function

2013-01-11 Thread Zhi Yong Wu
unction up to here I've got lost in the shifts that > I don't see the meaning of the resulting value and how can I interpet it > if I watch it change over time. What are the expected weights of the > number and time factors? There are more details in the documentation, but > the b

Re: [PATCH RESEND v1 05/16] vfs: add hooks to enable hot tracking

2013-01-10 Thread Zhi Yong Wu
dahead.c >> @@ -138,6 +139,12 @@ static int read_pages(struct address_space *mapping, >> struct file *filp, >> out: >> blk_finish_plug(&plug); >> >> + /* Hot data tracking */ >> + hot_update_freqs(mapping->host, >> + (loff_t)(list_entry(pages->prev, struct page, lru)->index) >> + << PAGE_CACHE_SHIFT, >> + (size_t)nr_pages * PAGE_CACHE_SIZE, 0); > > same comment here Ditto. thanks. > >> + >> return ret; >> } > > > david -- Regards, Zhi Yong Wu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH RESEND v1 03/16] vfs: add I/O frequency update function

2013-01-10 Thread Zhi Yong Wu
c_sub(cur_time, old_atime); >> + new_delta = timespec_to_ns(&delta_ts) >> FREQ_POWER; >> + >> + *avg = (*avg << FREQ_POWER) - *avg + new_delta; >> + *avg = *avg >> FREQ_POWER; >> +} >> + >> +static void hot_freq_data_update(struct hot_fre

Re: [PATCH RESEND v1 02/16] vfs: add init and cleanup functions

2013-01-10 Thread Zhi Yong Wu
On Thu, Jan 10, 2013 at 8:48 AM, David Sterba wrote: > On Thu, Dec 20, 2012 at 10:43:21PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> --- a/fs/hot_tracking.c >> +++ b/fs/hot_tracking.c >> @@ -107,3 +189,38 @@ err: >> kmem_ca

Re: [PATCH RESEND v1 01/16] vfs: introduce some data structures

2013-01-09 Thread Zhi Yong Wu
the file name written here is not wanted, so > please drop it (and from .h too) Done. > >> + * >> + * Copyright (C) 2012 IBM Corp. All rights reserved. >> + * Written by Zhi Yong Wu >> + * >> + * This program is free software; you can redistribute it and/or

Re: [PATCH RESEND v1 00/16] vfs: hot data tracking

2013-01-07 Thread Zhi Yong Wu
On Thu, Dec 20, 2012 at 10:43 PM, wrote: > From: Zhi Yong Wu > > HI, guys, > > This patchset has been done scalability or performance tests > by fs_mark, ffsb and compilebench. > I have done the perf testing on Linux 3.7.0-rc8+ with Intel(R) Core(TM) > i7-3770 CPU @

Re: [PATCH RESEND v1 00/16] vfs: hot data tracking

2013-01-07 Thread Zhi Yong Wu
/7e010b4fe193c6cf49c8c946be301ed3d3ac9eae 5.) mail_server https://github.com/wuzhy/perf_report/commit/225f2b51ae3baab774e7cda6009d3745ec742d18 On Thu, Dec 20, 2012 at 10:43 PM, wrote: > From: Zhi Yong Wu > > HI, guys, > > This patchset has been done scalability or performance tests > by

Re: [PATCH RESEND v1 00/16] vfs: hot data tracking

2012-12-20 Thread Zhi Yong Wu
HI, The raw data is very big, i don't know if it is appropriate to post them here. If you want to get them, please let me know. On Thu, Dec 20, 2012 at 10:43 PM, wrote: > From: Zhi Yong Wu > > HI, guys, > > This patchset has been done scalability or performance tests &g

Re: [PATCH v1 resend hot_track 00/16] vfs: hot data tracking

2012-12-13 Thread Zhi Yong Wu
On Thu, Dec 13, 2012 at 3:50 AM, Darrick J. Wong wrote: > On Mon, Dec 10, 2012 at 11:30:03AM +0800, Zhi Yong Wu wrote: >> HI, all guys. >> >> any comments or suggestions? > > Why did ffsb drop from 924 transactions/sec to 322? It is maybe that some noise operations i

Re: [PATCH v1 resend hot_track 00/16] vfs: hot data tracking

2012-12-09 Thread Zhi Yong Wu
HI, all guys. any comments or suggestions? On Thu, Dec 6, 2012 at 11:28 AM, Zhi Yong Wu wrote: > HI, guys > > THe perf testing is done separately with fs_mark, fio, ffsb and > compilebench in one kvm guest. > > Below is the performance testing report for hot tracking, and

Re: [PATCH v1 resend hot_track 00/16] vfs: hot data tracking

2012-12-05 Thread Zhi Yong Wu
41.32s) delete tree total runs 10 avg 41.44 seconds (user 6.43s sys 25.19s) delete compiled tree total runs 4 avg 47.81 seconds (user 7.18s sys 29.27s) stat tree total runs 11 avg 20.41 seconds (user 6.39s sys 7.45s) stat compiled tree total runs 7 avg 23.97 seconds (user 7.24s sys 8.74s) On Fri,

Re: [PATCH] ext4: remove some unused code lines

2012-12-02 Thread Zhi Yong Wu
On Sun, Dec 2, 2012 at 8:27 PM, Zheng Liu wrote: > On Thu, Nov 29, 2012 at 06:00:00PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu > > Please write a commit log to describe this patch, even though it is > quite simple and straightfoward Good suggestion, thanks. >

Re: [RFC v4+ hot_track 02/19] vfs: initialize and free data structures

2012-11-15 Thread Zhi Yong Wu
; >> + if (!root) { >> + printk(KERN_ERR "%s: Failed to malloc memory for " >> + "hot_info\n", __func__); >> + return ret; > > minor: you can drop the variable ret and just reurn ENOMEM here > >> + }

Re: [RFC v4+ hot_track 10/19] vfs: introduce hot func register framework

2012-11-07 Thread Zhi Yong Wu
On Thu, Nov 8, 2012 at 2:58 AM, Darrick J. Wong wrote: > On Wed, Nov 07, 2012 at 04:34:35PM +0800, Zhi Yong Wu wrote: >> On Wed, Nov 7, 2012 at 7:30 AM, Darrick J. Wong >> wrote: >> > On Mon, Oct 29, 2012 at 12:30:52PM +0800, zwu.ker...@gmail.com wrote:

Re: [RFC v4+ hot_track 03/19] vfs: add I/O frequency update function

2012-11-07 Thread Zhi Yong Wu
On Thu, Nov 8, 2012 at 2:49 AM, Darrick J. Wong wrote: > On Wed, Nov 07, 2012 at 04:27:05PM +0800, Zhi Yong Wu wrote: >> On Wed, Nov 7, 2012 at 6:45 AM, Darrick J. Wong >> wrote: >> > On Mon, Oct 29, 2012 at 12:30:45PM +0800, zwu.ker...@gmail.com wrote:

Re: [RFC v4+ hot_track 00/19] vfs: hot data tracking

2012-11-07 Thread Zhi Yong Wu
On Mon, Oct 29, 2012 at 12:30 PM, wrote: > From: Zhi Yong Wu > > NOTE: > > The patchset can be obtained via my kernel dev git on github: > g...@github.com:wuzhy/kernel.git hot_tracking > If you're interested, you can also can review them via > https://gi

Re: [PATCH] xfs: add hot tracking support.

2012-11-07 Thread Zhi Yong Wu
super( > { > struct xfs_mount*mp = XFS_M(sb); > > + if (mp->m_flags & XFS_MOUNT_HOTTRACK) > + hot_track_exit(sb); > + > xfs_filestream_unmount(mp); > xfs_unmountfs(mp); > > @@ -1470,6 +1477,8 @@ xfs_fs_fill_super( >

Re: [RFC v4+ hot_track 10/19] vfs: introduce hot func register framework

2012-11-07 Thread Zhi Yong Wu
On Wed, Nov 7, 2012 at 7:30 AM, Darrick J. Wong wrote: > On Mon, Oct 29, 2012 at 12:30:52PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Introduce one framwork to enable that specific FS >> can register its own hot tracking functions. >&

Re: [RFC v4+ hot_track 03/19] vfs: add I/O frequency update function

2012-11-07 Thread Zhi Yong Wu
On Wed, Nov 7, 2012 at 6:45 AM, Darrick J. Wong wrote: > On Mon, Oct 29, 2012 at 12:30:45PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Add some util helpers to update access frequencies >> for one file or its range. >> >> Si

Re: [RFC v4+ hot_track 16/19] btrfs: add hot tracking support

2012-11-07 Thread Zhi Yong Wu
On Wed, Nov 7, 2012 at 8:00 AM, David Sterba wrote: > On Mon, Oct 29, 2012 at 12:30:58PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Introduce one new mount option '-o hot_track', >> and add its parsing support. >> Its usage looks

Re: [RFC v4+ hot_track 14/19] vfs: add debugfs support

2012-11-06 Thread Zhi Yong Wu
; + &root->heat_range_map[i].node_list, pos); >> + goto next; >> + } >> + >> + return NULL; >> +} >> + >> +static void hot_debugfs_exit(struct super_block *sb) >> +{ >> + struct dentry *vol_dentry; >> + >>

Re: [RFC v4+ hot_track 12/19] vfs: add one ioctl interface

2012-11-06 Thread Zhi Yong Wu
; >> + } else { >> + /* not live temperature, get it from the hashlist */ >> + heat_info->temp = he->hot_inode.hot_freq_data.last_temp; >> + } >> + spin_unlock(&he->hot_inode.lock); >> + >> + hot_inode_item_pu

Re: [RFC v4+ hot_track 10/19] vfs: introduce hot func register framework

2012-11-06 Thread Zhi Yong Wu
func_ops { >> + hot_rw_freq_calc_fn *hot_rw_freq_calc_fn; >> + hot_temp_calc_fn *hot_temp_calc_fn; >> + hot_is_obsolete_fn *hot_is_obsolete_fn; >> +}; > > My suggestion is to make the types explicit in the structure. sorry, i don't get your point, can you ela

Re: [RFC v4+ hot_track 05/19] vfs: add hooks to enable hot tracking

2012-11-06 Thread Zhi Yong Wu
t; > There's a stale \ at the end of the line, and I find this formatting > hard to read. Does the following look acceptable? yes, great, thanks. > > hot_update_freqs(mapping->host, > (u64)(list_entry(pages->prev, struct page, lru)->index) >

Re: [RFC v4+ hot_track 03/19] vfs: add I/O frequency update function

2012-11-06 Thread Zhi Yong Wu
kmem_cache_free(hot_range_item_cachep, hr); > > radix_tree_preload_end() I checked some kernel existing cases about the usage of radix_tree_preload(), it seems that when radix_tree_preload() fail, its error handling doesn't need call radix_tree_preload_end() any more. > >

Re: [RFC v4+ hot_track 02/19] vfs: initialize and free data structures

2012-11-06 Thread Zhi Yong Wu
> + int ret = -ENOMEM; >> + >> + root = kzalloc(sizeof(struct hot_info), GFP_NOFS); >> + if (!root) { >> + printk(KERN_ERR "%s: Failed to malloc memory for " >> + "hot_info\n", __func__); >> +

Re: VFS hot tracking: How to calculate data temperature?

2012-11-06 Thread Zhi Yong Wu
On Tue, Nov 6, 2012 at 4:39 PM, Zheng Liu wrote: > On Mon, Nov 05, 2012 at 10:29:39AM +0800, Zhi Yong Wu wrote: >> On Fri, Nov 2, 2012 at 4:41 PM, Zheng Liu wrote: >> > On Fri, Nov 02, 2012 at 02:38:29PM +0800, Zhi Yong Wu wrote: >> >> Here also has another questio

Re: [RFC v4+ hot_track 09/19] vfs: add one work queue

2012-11-05 Thread Zhi Yong Wu
On Mon, Nov 5, 2012 at 8:07 PM, Steven Whitehouse wrote: > Hi, > > On Mon, 2012-11-05 at 19:55 +0800, Zhi Yong Wu wrote: >> On Mon, Nov 5, 2012 at 7:21 PM, Steven Whitehouse >> wrote: >> > Hi, >> > >> > On Mon, 2012-10-29 at 12:30 +0800, zwu

Re: VFS hot tracking: How to calculate data temperature?

2012-11-05 Thread Zhi Yong Wu
On Mon, Nov 5, 2012 at 7:57 PM, Steven Whitehouse wrote: > Hi, > > On Mon, 2012-11-05 at 19:46 +0800, Zhi Yong Wu wrote: >> On Mon, Nov 5, 2012 at 6:33 PM, Steven Whitehouse >> wrote: >> > Hi, >> > >> > On Mon, 2012-11-05 at 16:44 +0800, Zhi Yon

Re: [RFC v4+ hot_track 09/19] vfs: add one work queue

2012-11-05 Thread Zhi Yong Wu
On Mon, Nov 5, 2012 at 7:21 PM, Steven Whitehouse wrote: > Hi, > > On Mon, 2012-10-29 at 12:30 +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Add a per-superblock workqueue and a delayed_work >> to run periodic work to update map info on each sup

Re: [RFC v4+ hot_track 03/19] vfs: add I/O frequency update function

2012-11-05 Thread Zhi Yong Wu
On Mon, Nov 5, 2012 at 7:07 PM, Steven Whitehouse wrote: > Hi, > > On Mon, 2012-10-29 at 12:30 +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Add some util helpers to update access frequencies >> for one file or its range. >> >&

Re: VFS hot tracking: How to calculate data temperature?

2012-11-05 Thread Zhi Yong Wu
On Mon, Nov 5, 2012 at 6:33 PM, Steven Whitehouse wrote: > Hi, > > On Mon, 2012-11-05 at 16:44 +0800, Zhi Yong Wu wrote: >> On Mon, Nov 5, 2012 at 4:28 PM, Dave Chinner wrote: >> > On Mon, Nov 05, 2012 at 10:35:50AM +0800, Zhi Yong Wu wrote: >> >> On Sat,

Re: VFS hot tracking: How to calculate data temperature?

2012-11-05 Thread Zhi Yong Wu
On Mon, Nov 5, 2012 at 4:28 PM, Dave Chinner wrote: > On Mon, Nov 05, 2012 at 10:35:50AM +0800, Zhi Yong Wu wrote: >> On Sat, Nov 3, 2012 at 5:27 AM, Mingming.cao wrote: >> > On Fri, 2012-11-02 at 14:38 +0800, Zhi Yong Wu wrote: >> >> Here also has another questio

Re: [ 00/24] 3.6.6-stable review

2012-11-04 Thread Zhi Yong Wu
On Mon, Nov 5, 2012 at 3:41 PM, Greg Kroah-Hartman wrote: > On Mon, Nov 05, 2012 at 03:37:31PM +0800, Zhi Yong Wu wrote: >> HI, greg >> >> Some of the patchset haven't passed the check of checkpatch.pl as below: >> >> WARNING: line over 80 characters >

Re: [ 00/24] 3.6.6-stable review

2012-11-04 Thread Zhi Yong Wu
/osd_client.h | 2 +- > include/linux/ceph/osdmap.h | 6 +- > net/ceph/messenger.c| 6 +- > net/ceph/osd_client.c | 32 -- > net/ceph/osdmap.c | 18 ++- > 29 files changed, 310 insertions(+

Re: VFS hot tracking: How to calculate data temperature?

2012-11-04 Thread Zhi Yong Wu
On Sat, Nov 3, 2012 at 5:27 AM, Mingming.cao wrote: > On Fri, 2012-11-02 at 14:38 +0800, Zhi Yong Wu wrote: >> Here also has another question. >> >> How to save the file temperature among the umount to be able to >> preserve the file tempreture after reboot? >>

Re: VFS hot tracking: How to calculate data temperature?

2012-11-04 Thread Zhi Yong Wu
On Sat, Nov 3, 2012 at 4:10 AM, Darrick J. Wong wrote: > On Fri, Nov 02, 2012 at 04:41:09PM +0800, Zheng Liu wrote: >> On Fri, Nov 02, 2012 at 02:38:29PM +0800, Zhi Yong Wu wrote: >> > Here also has another question. >> > >> > How to save the file temper

Re: VFS hot tracking: How to calculate data temperature?

2012-11-04 Thread Zhi Yong Wu
On Fri, Nov 2, 2012 at 4:41 PM, Zheng Liu wrote: > On Fri, Nov 02, 2012 at 02:38:29PM +0800, Zhi Yong Wu wrote: >> Here also has another question. >> >> How to save the file temperature among the umount to be able to >> preserve the file tempreture after rebo

Re: [RFC v4+ hot_track 13/19] debugfs: introduce one function

2012-10-29 Thread Zhi Yong Wu
On Tue, Oct 30, 2012 at 6:54 AM, Greg KH wrote: > On Tue, Oct 30, 2012 at 06:45:19AM +0800, Zhi Yong Wu wrote: >> On Tue, Oct 30, 2012 at 6:34 AM, Greg KH wrote: >> > On Tue, Oct 30, 2012 at 06:25:50AM +0800, Zhi Yong Wu wrote: >> >> On Tue, Oct 30, 2012 at

Re: [RFC v4+ hot_track 13/19] debugfs: introduce one function

2012-10-29 Thread Zhi Yong Wu
On Tue, Oct 30, 2012 at 6:34 AM, Greg KH wrote: > On Tue, Oct 30, 2012 at 06:25:50AM +0800, Zhi Yong Wu wrote: >> On Tue, Oct 30, 2012 at 2:11 AM, Greg KH wrote: >> > On Mon, Oct 29, 2012 at 12:30:55PM +0800, zwu.ker...@gmail.com wrote: >> >> From: Zhi Yong Wu >

Re: [RFC v4+ hot_track 15/19] sysfs: add two hot_track proc files

2012-10-29 Thread Zhi Yong Wu
On Tue, Oct 30, 2012 at 2:10 AM, Greg KH wrote: > On Mon, Oct 29, 2012 at 12:30:57PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Add two proc files hot-kick-time and hot-update-delay >> under the dir /proc/sys/fs/ in order to turn >> TIME_TO_K

Re: [RFC v4+ hot_track 13/19] debugfs: introduce one function

2012-10-29 Thread Zhi Yong Wu
On Tue, Oct 30, 2012 at 2:11 AM, Greg KH wrote: > On Mon, Oct 29, 2012 at 12:30:55PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> The debugfs function is used to get expected dentry. > > Huh? Why do you need this? Why haven't you added doc

Re: [RFC v4+ hot_track 00/19] vfs: hot data tracking

2012-10-29 Thread Zhi Yong Wu
utely not optional. ah, i know, but now i need to make sure all the codes are correct at first, then do these tests. > > -Andi > > -- > a...@linux.intel.com -- Speaking for myself only -- Regards, Zhi Yong Wu -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [RFC v4 03/15] vfs,hot_track: add the function for collecting I/O frequency

2012-10-28 Thread Zhi Yong Wu
On Mon, Oct 29, 2012 at 10:01 AM, Dave Chinner wrote: > On Sun, Oct 28, 2012 at 09:51:48PM +0800, Zhi Yong Wu wrote: >> On Sun, Oct 28, 2012 at 3:55 PM, Zheng Liu wrote: >> > Hi Zhiyong, >> > >> > On Thu, Oct 25, 2012 at 11:08:55PM +0800, zwu.ker...@gmail.co

Re: [RFC v4 03/15] vfs,hot_track: add the function for collecting I/O frequency

2012-10-28 Thread Zhi Yong Wu
(he, cur); >> + if (IS_ERR(hr)) { >> + WARN_ON(1); >> + hot_inode_item_put(he); >> + return; >> + } >> + >> + spin_lock(&hr->hot_range.lock); >> +

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-19 Thread Zhi Yong Wu
On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner wrote: > On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> NOTE: >> >> The patchset is currently post out mainly to make sure >> it is going in the correct di

Re: [RFC v3 11/13] vfs: add 3 new ioctl interfaces

2012-10-19 Thread Zhi Yong Wu
On Tue, Oct 16, 2012 at 11:17 AM, Dave Chinner wrote: > On Wed, Oct 10, 2012 at 06:07:33PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> FS_IOC_GET_HEAT_INFO: return a struct containing the various >> metrics collected in btrfs_freq_data structs, an

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-17 Thread Zhi Yong Wu
On Thu, Oct 18, 2012 at 1:17 PM, Dave Chinner wrote: > On Thu, Oct 18, 2012 at 12:44:47PM +0800, Zhi Yong Wu wrote: >> On Thu, Oct 18, 2012 at 12:29 PM, Dave Chinner wrote: >> > On Wed, Oct 17, 2012 at 04:57:14PM +0800, Zhi Yong Wu wrote: >> >> On Tue, Oct 16,

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-17 Thread Zhi Yong Wu
On Thu, Oct 18, 2012 at 12:29 PM, Dave Chinner wrote: > On Wed, Oct 17, 2012 at 04:57:14PM +0800, Zhi Yong Wu wrote: >> On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner wrote: >> > On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote: >> >> From: Zhi Y

Re: [RFC v3 09/13] vfs: add one wq to update map info periodically

2012-10-17 Thread Zhi Yong Wu
On Thu, Oct 18, 2012 at 10:25 AM, Zheng Liu wrote: > On Wed, Oct 17, 2012 at 02:34:15PM +0800, Zhi Yong Wu wrote: >> >> diff --git a/fs/hot_tracking.h b/fs/hot_tracking.h >> >> index d19e64a..7a79a6d 100644 >> >> --- a/fs/hot_tracking.h >> &g

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-17 Thread Zhi Yong Wu
On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner wrote: > On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> NOTE: >> >> The patchset is currently post out mainly to make sure >> it is going in the correct di

Re: [RFC v3 09/13] vfs: add one wq to update map info periodically

2012-10-16 Thread Zhi Yong Wu
On Tue, Oct 16, 2012 at 8:27 AM, Dave Chinner wrote: > On Wed, Oct 10, 2012 at 06:07:31PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Add a per-superblock workqueue and a work_struct >> to run periodic work to update map info on each superblock. &g

Re: [RFC v3 11/13] vfs: add 3 new ioctl interfaces

2012-10-15 Thread Zhi Yong Wu
On Tue, Oct 16, 2012 at 11:17 AM, Dave Chinner wrote: > On Wed, Oct 10, 2012 at 06:07:33PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> FS_IOC_GET_HEAT_INFO: return a struct containing the various >> metrics collected in btrfs_freq_data structs, an

Re: [RFC v3 12/13] vfs: add debugfs support

2012-10-15 Thread Zhi Yong Wu
On Mon, Oct 15, 2012 at 4:04 PM, Dave Chinner wrote: > On Wed, Oct 10, 2012 at 06:07:34PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Add a /sys/kernel/debug/hot_track// directory for each >> volume that contains two files. The first, `inode_

Re: [RFC v3 12/13] vfs: add debugfs support

2012-10-15 Thread Zhi Yong Wu
On Mon, Oct 15, 2012 at 3:55 PM, Dave Chinner wrote: > On Wed, Oct 10, 2012 at 06:07:34PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Add a /sys/kernel/debug/hot_track// directory for each >> volume that contains two files. The first, `inode_

<    1   2   3   >