[PATCH 3/3] iio: ti_am335x_adc: Add continuous sampling support

2013-09-19 Thread Zubair Lutfullah
mode. Signed-off-by: Zubair Lutfullah Acked-by: Greg Kroah-Hartman Signed-off-by: Russ Dill Acked-by: Lee Jones Acked-by: Sebastian Andrzej Siewior --- drivers/iio/adc/ti_am335x_adc.c | 213 +- include/linux/mfd/ti_am335x_tscadc.h |9 ++ 2 files

[PATCH V11 0/3] iio: input: ti_am335x_adc: Add continuous sampling support

2013-09-19 Thread Zubair Lutfullah
these patches meet the mighty kernel standards :) Zubair Zubair Lutfullah (3): input: ti_am335x_tsc: Enable shared IRQ for TSC iio: ti_am335x_adc: optimize memory usage. iio: ti_am335x_adc: Add continuous sampling support drivers/iio/adc/ti_am335x_adc.c | 217

[PATCH 2/3] iio: ti_am335x_adc: optimize memory usage

2013-09-19 Thread Zubair Lutfullah
12 bit ADC data is stored in 32 bits of storage. Change from u32 to u16 to reduce wasted memory. Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc

Re: [PATCH V11 0/3] iio: input: ti_am335x_adc: Add continuous sampling support

2013-09-21 Thread Zubair Lutfullah :
kernel.org/pub/scm/linux/kernel/git/jic23/iio.git Thank-you very much for the quick feedbacks and accepting these patches! :) Zubair > > On 09/19/13 07:24, Zubair Lutfullah wrote: > > Hi, > > > > These apply to the togreg branch in iio. > > > > Round 11 >

Re: [PATCH 3/3] iio: ti_am335x_adc: Add continuous sampling support

2013-09-21 Thread Zubair Lutfullah :
On Sat, Sep 21, 2013 at 07:28:32PM +0100, Jonathan Cameron wrote: > On 09/19/13 07:24, Zubair Lutfullah wrote: > > Previously the driver had only one-shot reading functionality. > > This patch adds continuous sampling support to the driver. ... > I've added a SELECT I

[PATCH 2/3] iio: ti_am335x_adc: cleanup trigger related code

2013-09-22 Thread Zubair Lutfullah
Trigger related headers and variables are not needed as driver is now based on INDIO_BUFFER_HARDWARE mode Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc

[PATCH 1/3] iio: ti_am335x_adc: fix static in function header

2013-09-22 Thread Zubair Lutfullah
Static is missing in function header. Corrected. Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c index 5287bff..91dce1f 100644

[PATCH 3/3] iio: ti_am335x_adc: cleanup error case

2013-09-22 Thread Zubair Lutfullah
Driver is functional without this error case. Cleaned up. Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c index 4eb63eb..8fb5429 100644

[PATCH 0/3] iio: ti_am335x_adc: small fix and cleanup

2013-09-22 Thread Zubair Lutfullah
it. ADC works without it. Thanks Zubair Zubair Lutfullah (3): iio: ti_am335x_adc: fix static in function header iio: ti_am335x_adc: cleanup trigger related code iio: ti_am335x_adc: cleanup error case drivers/iio/adc/ti_am335x_adc.c | 16 +--- 1 file changed, 1 insertion(+), 15

Re: [PATCH 2/2] iio: ti_am335x_adc: Add continuous sampling support

2013-09-11 Thread Zubair Lutfullah :
On Sun, Sep 08, 2013 at 02:42:51PM +0100, Jonathan Cameron wrote: > On 09/01/13 12:17, Zubair Lutfullah wrote: Thanks for the review. Fitting this driver in the usual trigger ABI is a bad workaround indeed. I am still a bit unclear regarding the implementation. Questions and replies inline.

Re: [PATCH 1/2] input: ti_am335x_tsc: Enable shared IRQ for TSC

2013-09-11 Thread Zubair Lutfullah :
On Mon, Sep 09, 2013 at 09:12:30AM -0700, Dmitry Torokhov wrote: > On Sun, Sep 08, 2013 at 12:29:26PM +0100, Jonathan Cameron wrote: > > On 09/01/13 12:17, Zubair Lutfullah wrote: > > > Enable shared IRQ to allow ADC to share IRQ line from > > > parent MFD core.

Re: [PATCH] mfd: ti_am335x_tscadc: avoid possible deadlock of reg_lock

2013-10-25 Thread Zubair Lutfullah :
uses the *_irq* variant which should be used in order to avaoid a deadlock. > > > > Cc: Zubair Lutfullah > > Signed-off-by: Sebastian Andrzej Siewior > > --- > > drivers/mfd/ti_am335x_tscadc.c | 12 > > 1 file changed, 8 insertions(+), 4

Re: [PATCH] mfd: ti_am335x_tscadc: fix spin lock and reg_cache

2013-10-25 Thread Zubair Lutfullah :
On Tue, Oct 22, 2013 at 06:28:13PM +0200, Sebastian Andrzej Siewior wrote: > On 10/22/2013 05:48 PM, Lee Jones wrote: > > On Tue, 22 Oct 2013, Sebastian Andrzej Siewior wrote: > > > >> On 08/07/2013 10:40 AM, Lee Jones wrote: > >>> On Mon,

[PATCH 15/15] iio: ti_am335x_adc: Properly handle out of memory situation.

2013-07-18 Thread Zubair Lutfullah
. Before this patch, the driver would stop capturing without any indication of error to the IIO subsystem or the user. Signed-off-by: Russ Dill Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/iio

[PATCH 13/15] iio: ti_am335x_adc: Fix capture operation during resume

2013-07-18 Thread Zubair Lutfullah
From: Russ Dill The ADC needs to go through a proper initialization sequence after resuming from suspend. Signed-off-by: Russ Dill Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc

[PATCH 14/15] iio: ti_am335x_adc: Reset and clear overrun status before capture

2013-07-18 Thread Zubair Lutfullah
From: Russ Dill While not pulling out samples, the FIFO will fill up causing an overrun event. Before starting up another continuous sample, clear that event. Signed-off-by: Russ Dill Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c | 21 +++-- 1 file

[PATCH 12/15] iio: ti_am335x_adc: Fix allocation count of FIFO buffer.

2013-07-18 Thread Zubair Lutfullah
From: Russ Dill Allocating an extra byte is not necessary here. The driver will check that the allocation is large enough to satisfy the IIO subsystem. Signed-off-by: Russ Dill Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH 09/15] iio: ti_am335x_adc: Avoid double threshold event

2013-07-18 Thread Zubair Lutfullah
the event until the FIFO has actually been emptied, in the workqueue. The unmasking and masking of the interrupt remains unchanged. Signed-off-by: Russ Dill Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 07/15] iio: ti_am335x_adc: Handle set to clear IRQSTATUS

2013-07-18 Thread Zubair Lutfullah
the status and writing it back, the driver is clearing all pending events, not just the one indicated in the bitmask. Signed-off-by: Russ Dill Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

[PATCH 02/15] iio: ti_am335x_adc: Fix wrong samples received on 1st read

2013-07-18 Thread Zubair Lutfullah
From: "Patil, Rachna" Previously we tried to read data form ADC even before ADC sequencer finished sampling. This led to wrong samples. We now wait on ADC status register idle bit to be set. Signed-off-by: Patil, Rachna Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am

[PATCH 10/15] iio: ti_am335x_adc: Also clear threshold event when clearing overrun event

2013-07-18 Thread Zubair Lutfullah
From: Russ Dill When an overrun occurs, the FIFO is cleared. If a FIFO threshold event was pending, the data is now gone. Clear the threshold event when handling an overrun (or underflow). Signed-off-by: Russ Dill Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c |4

[PATCH 11/15] iio: ti_am335x_adc: Print error and handle short FIFO events

2013-07-18 Thread Zubair Lutfullah
a good idea to close this just in case additional bugs in hardware or software exist. Signed-off-by: Russ Dill Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc

[PATCH 06/15] iio: ti_am335x_adc: Handle set to clear IRQENABLE

2013-07-18 Thread Zubair Lutfullah
). Read 1 = Interrupt enabled. Write 1 = Enable interrupt. The current read/update/write method is currently not causing any problems, but could cause confusion in the future. Signed-off-by: Russ Dill Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c | 14 ++ 1

[PATCH 08/15] iio: ti_am335x_adc: Handle overrun before threshold event

2013-07-18 Thread Zubair Lutfullah
From: Russ Dill If an overrun occurs, the threshold event is meaningless, handle the overrun event first. Signed-off-by: Russ Dill Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff

[PATCH 05/15] MFD: ti_tscadc: ADC Clock check not required

2013-07-18 Thread Zubair Lutfullah
just uses the internal ADC clock divider to set the ADC frequency w.r.t the sys clock. Signed-off-by: Patil, Rachna Signed-off-by: Zubair Lutfullah --- drivers/mfd/ti_am335x_tscadc.c |6 +- include/linux/mfd/ti_am335x_tscadc.h |1 - 2 files changed, 1 insertion(+), 6 deletions(-)

[PATCH 04/15] iio: mfd: input: ti_am335x_adc:Add support for continuous mode

2013-07-18 Thread Zubair Lutfullah
il, Rachna Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c | 350 + drivers/input/touchscreen/ti_am335x_tsc.c |9 +- drivers/mfd/ti_am335x_tscadc.c| 12 +- include/linux/mfd/ti_am335x_tscadc.h | 10 + 4 files ch

[PATCH 03/15] input: ti_tsc: Enable shared IRQ for TSC

2013-07-18 Thread Zubair Lutfullah
n. Signed-off-by: Patil, Rachna Acked-by: Vaibhav Hiremath Signed-off-by: Zubair Lutfullah --- drivers/input/touchscreen/ti_am335x_tsc.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/t

[PATCH 00/15] iio: ti_am335x_adc: Add continuous mode take 2

2013-07-18 Thread Zubair Lutfullah
Patches now give correct authorship. and checkpatch.pl issues are checked for each patch. I hope the actual code bashing can begin now. A series of patches that add continuous sampling support for the adc drivers for the am335x. These apply on top of mfd-next after the recent set of patches on

[PATCH 01/15] MFD: ti_tscadc: disable TSC config registers in adc mode

2013-07-18 Thread Zubair Lutfullah
From: "Patil, Rachna" AFE Pen Ctrl and TouchScreen transistors enabling is not required when only ADC mode is being used, so check for availability of TSC driver before accessing control register. Signed-off-by: Patil, Rachna Acked-by: Vaibhav Hiremath Signed-off-by: Zubair

Re: [PATCH 01/15] MFD: ti_tscadc: disable TSC config registers in adc mode

2013-07-19 Thread Zubair Lutfullah :
On Thu, Jul 18, 2013 at 03:45:55PM -0700, Greg KH wrote: > Did Rachna really sign off on this, and the other, patches? Or did they Authored and signed off on it in their TI tree. based on 3.2. I brought them forward to 3.11. I guess I'll remove their sign-offs. Can the code be reviewed as is

Re: [PATCH 00/15] iio: ti_am335x_adc: Add continuous mode take 2

2013-07-20 Thread Zubair Lutfullah :
l but I would much rather have something > that is easy to review, with appropriate comments or if people will give > them, sign offs to reflect the various contributions. > > Jonathan And then one patch for continuous mode with appropriate comments/sign-offs. Thank-you Zubair Lutful

[PATCH 0/4] mfd: iio: ti_am335x_tscadc: fixes adc sampling, TSC config and a typo

2013-07-20 Thread Zubair Lutfullah
relevant lists too. No response.. Patil, Rachna (3): iio: ti_am335x_adc: Fix wrong samples received on 1st read MFD: ti_tscadc: disable TSC config registers in adc mode MFD: ti_tscadc: ADC Clock check not required Zubair Lutfullah (1): mfd: input: arm: dts: doc: ti_am335x: typo fixes

[PATCH 2/4] MFD: ti_tscadc: disable TSC config registers in adc mode

2013-07-20 Thread Zubair Lutfullah
From: "Patil, Rachna" AFE Pen Ctrl and TouchScreen transistors enabling is not required when only ADC mode is being used, so check for availability of TSC driver before accessing control register. Signed-off-by: Patil, Rachna Acked-by: Vaibhav Hiremath Signed-off-by: Zubair

[PATCH 3/4] MFD: ti_tscadc: ADC Clock check not required

2013-07-20 Thread Zubair Lutfullah
just uses the internal ADC clock divider to set the ADC frequency w.r.t the sys clock. Signed-off-by: Patil, Rachna Signed-off-by: Zubair Lutfullah --- drivers/mfd/ti_am335x_tscadc.c |6 +- include/linux/mfd/ti_am335x_tscadc.h |1 - 2 files changed, 1 insertion(+), 6 deletions(-)

[PATCH 4/4] mfd: input: arm: dts: doc: ti_am335x: typo fixes (coordiante -> coordinate)

2013-07-20 Thread Zubair Lutfullah
Did a grep for 'coordiante' and replaced them all with 'coordinate' --- .../bindings/input/touchscreen/ti-tsc-adc.txt |4 ++-- arch/arm/boot/dts/am335x-evm.dts |2 +- drivers/input/touchscreen/ti_am335x_tsc.c |2 +- drivers/mfd/ti_am335x_tscadc.c

[PATCH 1/4] iio: ti_am335x_adc: Fix wrong samples received on 1st read

2013-07-20 Thread Zubair Lutfullah
From: "Patil, Rachna" Previously we tried to read data form ADC even before ADC sequencer finished sampling. This led to wrong samples. We now wait on ADC status register idle bit to be set. Signed-off-by: Patil, Rachna Signed-off-by: Zubair Lutfullah Acked-by: Jonathan Cameron --

Re: [PATCH 1/3] iio: ti_am335x_adc: fix static in function header

2013-09-26 Thread Zubair Lutfullah :
On Sun, Sep 22, 2013 at 07:03:53PM +0100, Jonathan Cameron wrote: > On 09/22/13 09:20, Zubair Lutfullah wrote: > > Static is missing in function header. Corrected. > > > > Signed-off-by: Zubair Lutfullah > Applied to the togreg branch of iio.git > > As you've prob

Re: [PATCH 5/5] mfd: input: iio: ti_amm335x: Rework TSC/ADC synchronization

2013-12-19 Thread Zubair Lutfullah :
On Thu, Dec 19, 2013 at 04:28:31PM +0100, Sebastian Andrzej Siewior wrote: > The ADC driver always programs all possible ADC values and discards > them except for the value IIO asked for. On the am335x-evm the driver > programs four values and it takes 500us to gather them. Reducing the number >

iio_utils.h bug?

2013-12-22 Thread Zubair Lutfullah :
Hi, A guy posted this fix on my blog. I couldn't make sense of it. Thought I'd post it here. I'll send a proper patch file if I knew what commit log I needed to write. And I can't exactly sign-off :s. I asked him to post but he couldn't/wouldn't. Regards ZubairLK "Defend against buffer

[PATCH V6 0/2] iio: input: ti_am335x_adc: Add continuous sampling support

2013-08-25 Thread Zubair Lutfullah
multiple tiny patches. Zubair Lutfullah (2): input: ti_am335x_tsc: Enable shared IRQ for TSC iio: ti_am335x_adc: Add continuous sampling support drivers/iio/adc/ti_am335x_adc.c | 254 ++--- drivers/input/touchscreen/ti_am335x_tsc.c | 24 ++- include/linux/mfd

[PATCH 1/2] input: ti_am335x_tsc: Enable shared IRQ for TSC

2013-08-25 Thread Zubair Lutfullah
is written with the required mask every time. Rachna Patil (TI) laid ground work for shared IRQ. Signed-off-by: Zubair Lutfullah --- drivers/input/touchscreen/ti_am335x_tsc.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/input/touchscreen

[PATCH 2/2] iio: ti_am335x_adc: Add continuous sampling support

2013-08-25 Thread Zubair Lutfullah
channels can be read simultaneously and pushed to userspace. Restructured the driver to fit IIO ABI. And added trigger support. Signed-off-by: Zubair Lutfullah Acked-by: Greg Kroah-Hartman Signed-off-by: Russ Dill --- drivers/iio/adc/ti_am335x_adc.c | 254

[PATCH 1/4] asm-generic: Add dma-contiguous.h

2014-07-16 Thread Zubair Lutfullah Kakakhel
This header is used by arm64 and x86 individually. Adding to asm-generic to avoid further code repetition while adding cma to mips. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- include/asm-generic/dma-contiguous.h | 9 + 1 file changed, 9 insertions(+) create

[PATCH 3/4] x86: use generic dma-contiguous.h

2014-07-16 Thread Zubair Lutfullah Kakakhel
dma-contiguous.h is now in asm-generic. Use that to avoid code repetition in x86. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- arch/x86/include/asm/Kbuild | 1 + arch/x86/include/asm/dma-contiguous.h | 12 2 files changed, 1 insertion(+), 12

[PATCH 4/4] mips: dma: Add cma support

2014-07-16 Thread Zubair Lutfullah Kakakhel
of memory from cma reserved sections. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- arch/mips/Kconfig| 1 + arch/mips/include/asm/Kbuild | 1 + arch/mips/kernel/setup.c | 9 + arch/mips/mm/dma-default.c | 37 + 4

[PATCH 0/4] mips: Add cma support to mips

2014-07-16 Thread Zubair Lutfullah Kakakhel
and x86 welcome. patches based on linux-next b997a07604562f1a54cc531fe1cf7447f0ed6078 Zubair Lutfullah Kakakhel (4): asm-generic: Add dma-contiguous.h arm64: use generic dma-contiguous.h x86: use generic dma-contiguous.h mips: dma: Add cma support arch/arm64/include/asm/Kbuild

[PATCH 2/4] arm64: use generic dma-contiguous.h

2014-07-16 Thread Zubair Lutfullah Kakakhel
dma-contiguous.h is now in asm-generic. Use that to avoid code repetition in arm64. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- arch/arm64/include/asm/Kbuild | 1 + arch/arm64/include/asm/dma-contiguous.h | 28 2 files changed

Re: [PATCH 3/4] x86: use generic dma-contiguous.h

2014-07-17 Thread Zubair Lutfullah Kakakhel
On 16/07/14 17:20, Michal Nazarewicz wrote: On Wed, Jul 16 2014, Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com wrote: dma-contiguous.h is now in asm-generic. Use that to avoid code repetition in x86. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com Acked

Re: [PATCH 4/4] mips: dma: Add cma support

2014-07-17 Thread Zubair Lutfullah Kakakhel
On 16/07/14 17:39, Michal Nazarewicz wrote: On Wed, Jul 16 2014, Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com wrote: Adds cma support to the mips architecture. cma uses memblock. However, mips uses bootmem. Does cma_early_percent_memory work correctly then? Yes it does. All

[RFC] mm: memblock: change default cnt for regions from 1 to 0

2014-10-23 Thread Zubair Lutfullah Kakakhel
The default region counts are set to 1 with a comment saying empty dummy entry. If this is a dummy entry, should this be changed to 0? We have faced this in mips/kernel/setup.c arch_mem_init. cma uses memblock. But even with cma disabled. The for_each_memblock(reserved, reg) goes inside the

Re: [RFC] mm: memblock: change default cnt for regions from 1 to 0

2014-10-27 Thread Zubair Lutfullah Kakakhel
On 27/10/14 14:17, Tejun Heo wrote: Hello, On Thu, Oct 23, 2014 at 12:18:40PM -0700, Andrew Morton wrote: On Thu, 23 Oct 2014 17:56:53 +0100 Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com wrote: The default region counts are set to 1 with a comment saying empty dummy entry

[PATCH] mips: cma: Do not reserve memory if not required

2014-10-28 Thread Zubair Lutfullah Kakakhel
arguments to reserve 0 size location at 0 without EVA. But with EVA enabled, macros would point to different addresses and the code would trigger a BUG. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com Tested-by: Markos Chandras markos.chand...@imgtec.com --- arch/mips/kernel/setup.c

Re: [PATCH v12 0/11] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-11-24 Thread Zubair Lutfullah Kakakhel
Hi Andy, On 24/11/14 14:17, Andy Yan wrote: Hi ZubairLK, Russel King, Greg Kroah-Hartman , Philipp Zabel and Daniel: Do you have any further opinions or suggestions about the the current patch set? I have reviewed the patches as much as I could. They look good to me. But I don't know the

Re: [PATCH V5 7/7] dt-bindings: add document for dw-hdmi

2014-11-10 Thread Zubair Lutfullah Kakakhel
Nice work. This patch should move the binding from Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt to the location instead of making a new file and leaving the old one in place. And use git format-patch -M to highlight any changes. Regards ZubairLK On 08/11/14 05:32, Andy Yan

Re: [PATCH V5 3/7] dw-hdmi: make checkpatch happy

2014-11-10 Thread Zubair Lutfullah Kakakhel
Hi Andy, In 3.18 rc4, I cannot find checkpatch errors in imx-hdmi.c Have these errors come during the previous 2 patches. If yes, then these changes need to be squashed into the previous patches. No patch should add a checkpatch error and then fix it in a later patch. Regards ZubairLK On

Re: [PATCH V5 7/7] dt-bindings: add document for dw-hdmi

2014-11-10 Thread Zubair Lutfullah Kakakhel
On 10/11/14 09:44, Andy Yan wrote: Hi ZubairLK On 2014年11月10日 17:17, Zubair Lutfullah Kakakhel wrote: Nice work. This patch should move the binding from Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt to the location instead of making a new file and leaving the old one

Re: [PATCH V5 1/7] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-10 Thread Zubair Lutfullah Kakakhel
Hi Andy, A few comments inline. On 08/11/14 05:28, Andy Yan wrote: imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS) use the interface compatible Designware HDMI IP, but they also have some lightly difference, such as phy pll configuration, register width, 4K support, clk useage,

Re: [PATCH v7 4/7] staging: imx-drm: imx-hdmi: move imx-hdmi to bridge/dw-hdmi

2014-11-11 Thread Zubair Lutfullah Kakakhel
Hi Andy, On 11/11/14 12:53, Andy Yan wrote: the original imx hdmi driver is under staging/imx-drm, which depends on imx-drm, so move the imx hdmi drvier out Spelling mistake. ^'driver' to drm/bridge and rename imx-hdmi to dw-hdmi

Re: [PATCH v7 5/7] drm: bridge/dw-hdmi: add support for multi byte register width access

2014-11-11 Thread Zubair Lutfullah Kakakhel
Hi Andy, This patch adds the reg-io-width binding. Hence the binding patch should come before it. On 11/11/14 12:53, Andy Yan wrote: On rockchip rk3288, only word(32-bit) accesses are permitted for hdmi registers. Byte width accesses (writeb, readb) generate an imprecise external abort.

Re: [PATCH v7 6/7] drm: bridge/dw-hdmi: convert dw-hdmi to drm_bridge mode

2014-11-11 Thread Zubair Lutfullah Kakakhel
Hi Andy, On 11/11/14 12:54, Andy Yan wrote: From: Yakir Yang y...@rock-chips.com keep the connector birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c Is there a reason for this separation? Keeping encoder in platform files? If yes, then the commit message should explain that.

Re: [PATCH v7 7/7] dt-bindings: add document for dw-hdmi

2014-11-11 Thread Zubair Lutfullah Kakakhel
Hi Andy, Some minor comments inline. On 11/11/14 12:54, Andy Yan wrote: Signed-off-by: Andy Yan andy@rock-chips.com --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None

Re: [PATCH v7 5/7] drm: bridge/dw-hdmi: add support for multi byte register width access

2014-11-11 Thread Zubair Lutfullah Kakakhel
On 11/11/14 14:23, Lucas Stach wrote: Am Dienstag, den 11.11.2014, 14:20 + schrieb Zubair Lutfullah Kakakhel: Hi Andy, This patch adds the reg-io-width binding. Hence the binding patch should come before it. On 11/11/14 12:53, Andy Yan wrote: On rockchip rk3288, only word(32-bit

Re: [PATCH v7 5/7] drm: bridge/dw-hdmi: add support for multi byte register width access

2014-11-11 Thread Zubair Lutfullah Kakakhel
On 11/11/14 14:46, Andy Yan wrote: On 2014年11月11日 22:20, Zubair Lutfullah Kakakhel wrote: Hi Andy, This patch adds the reg-io-width binding. Hence the binding patch should come before it. do you mean that I should put dts binding patch before this patch? Yes. The patch adding

Re: [PATCH v9 9/9] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-13 Thread Zubair Lutfullah Kakakhel
On 13/11/14 12:57, Andy Yan wrote: rk3288 hdmi is compatible with Designware hdmi this patch is depend on patch by Mark Yao Add drm driver for Rockchip Socs see https://lkml.org/lkml/2014/10/8/201 Signed-off-by: Andy Yan andy@rock-chips.com Signed-off-by: Yakir Yang

Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver

2014-11-14 Thread Zubair Lutfullah Kakakhel
Hi Andy, Nice work on this patch series. Its getting better and better :). On 14/11/14 03:27, Andy Yan wrote: hdmi phy clock symbol and transmission termination value can adjust platform specific to get the best SI ^Is this signal integrity?

Re: [PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-14 Thread Zubair Lutfullah Kakakhel
Hi Andy On 14/11/14 03:31, Andy Yan wrote: Rockchip RK3288 hdmi is compatible with dw_hdmi Signed-off-by: Andy Yan andy@rock-chips.com --- Changes in v10: - add more display mode support mpll configuration for rk3288 Changes in v9: - move some phy configuration to platform

Re: [PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-14 Thread Zubair Lutfullah Kakakhel
On 14/11/14 10:37, Andy Yan wrote: On 2014年11月14日 18:23, Zubair Lutfullah Kakakhel wrote: Hi Andy On 14/11/14 03:31, Andy Yan wrote: Rockchip RK3288 hdmi is compatible with dw_hdmi Signed-off-by: Andy Yan andy@rock-chips.com --- Changes in v10: - add more display mode support

Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver

2014-11-14 Thread Zubair Lutfullah Kakakhel
On 14/11/14 10:53, Andy Yan wrote: Hi ZubairLK: Thanks for your review. On 2014年11月14日 18:19, Zubair Lutfullah Kakakhel wrote: Hi Andy, Nice work on this patch series. Its getting better and better :). On 14/11/14 03:27, Andy Yan wrote: hdmi phy clock symbol and transmission

Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver

2014-11-14 Thread Zubair Lutfullah Kakakhel
On 14/11/14 11:08, Andy Yan wrote: On 2014年11月14日 18:55, Zubair Lutfullah Kakakhel wrote: On 14/11/14 10:53, Andy Yan wrote: Hi ZubairLK: Thanks for your review. On 2014年11月14日 18:19, Zubair Lutfullah Kakakhel wrote: Hi Andy, Nice work on this patch series. Its getting better

Re: [PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-14 Thread Zubair Lutfullah Kakakhel
On 14/11/14 11:13, Andy Yan wrote: On 2014年11月14日 18:53, Zubair Lutfullah Kakakhel wrote: On 14/11/14 10:37, Andy Yan wrote: On 2014年11月14日 18:23, Zubair Lutfullah Kakakhel wrote: Hi Andy On 14/11/14 03:31, Andy Yan wrote: Rockchip RK3288 hdmi is compatible with dw_hdmi Signed-off

[PATCH] mips: pci: Add ifdef around pci_proc_domain

2014-12-12 Thread Zubair Lutfullah Kakakhel
Without these, there are multiple definitions of pci_proc_domain() and pci_domain_nr() if linux/pci.h and asm/pci.h are included. Add #ifdefs around them Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com Reviewed-by: Markos Chandras markos.chand...@imgtec.com --- arch/mips

[PATCH] dm9000: Add regulator and reset support to dm9000

2014-12-16 Thread Zubair Lutfullah Kakakhel
In boards, the dm9000 chip's power and reset can be controlled by gpio. It makes sense to add them to the dm9000 driver and let dt be used to enable power and reset the phy. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com Signed-off-by: Paul Burton paul.bur...@imgtec.com

Re: [PATCH] dm9000: Add regulator and reset support to dm9000

2014-12-16 Thread Zubair Lutfullah Kakakhel
On 16/12/14 16:33, Zubair Lutfullah Kakakhel wrote: ... + + power = devm_regulator_get(dev, vcc); + if (IS_ERR(power)) { + dev_dbg(dev, no regulator provided\n); + } else if (!regulator_is_enabled(power)) { + ret = regulator_enable(power

[PATCH_V2] dm9000: Add regulator and reset support to dm9000

2014-12-16 Thread Zubair Lutfullah Kakakhel
In boards, the dm9000 chip's power and reset can be controlled by gpio. It makes sense to add them to the dm9000 driver and let dt be used to enable power and reset the phy. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com Signed-off-by: Paul Burton paul.bur...@imgtec.com

Re: [PATCH 2/2] move imx-hdmi to bridge/dw-hdmi

2014-11-04 Thread Zubair Lutfullah Kakakhel
Hi, On 04/11/14 13:39, Andy Yan wrote: From: Andy yan andy@rock-chips.com the original imx hdmi driver is under staging/imx-drm, which depends on imx-drm, so move the imx hdmi drvier out to drm/bridge and rename imx-hdmi to dw-hdmi Change-Id: I5f417372f256aa26cd00a3cd0160741680afd39d

Re: [PATCH 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-04 Thread Zubair Lutfullah Kakakhel
Hi Andy, On 04/11/14 13:33, Andy Yan wrote: imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS) use the interface compatible Designware HDMI IP, but they also have some lightly difference, such as phy pll configuration, register width(imx hdmi register is one byte, but rk3288 is 4

Re: [PATCH V2 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-05 Thread Zubair Lutfullah Kakakhel
This one patch does too much to be reviewed easily. One patch is supposed to modify/add one thing at a time in the kernel. Separating platform specific code from imx-drm/imx-hdmi is one thing. Adding support for multi-byte register access is something different. i.e. Something like. 1/3 split

[PATCH_V2 0/4] sound:soc: jz4740: DT, dynamic sampling, enable clocks

2015-01-26 Thread Zubair Lutfullah Kakakhel
and stay within jz4740 so should apply easily on other trees. If you would like to have them rebased to a different tree, please tell. Thank-you V2 changes: Removed a redundant #define Added #ifdef CONFIG_OF Added dma in binding document Removed a redundant call to clk_prepare_enable Zubair

[PATCH_V3 4/4] sound: jz4740: set i2s clk rate to 12MHz

2015-01-26 Thread Zubair Lutfullah Kakakhel
i2s clock rate is not set to 12MHz currently. Set it before enabling the clock. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- V2 changes: Removed clk_prepare_enable call as clock was already being enabled elsewhere. Just set rate to 12MHz. --- sound/soc/jz4740/jz4740

[PATCH_V2 3/4] sound: soc: jz4740: Add DT support to jz4740-i2s driver

2015-01-26 Thread Zubair Lutfullah Kakakhel
This patch adds device tree support for the jz4740 driver. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- V2 changes: Added ifdef config_of --- sound/soc/jz4740/jz4740-i2s.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/sound/soc/jz4740/jz4740-i2s.c b

[PATCH_V2 4/4] sound: jz4740: set i2s clk rate to 12MHz

2015-01-26 Thread Zubair Lutfullah Kakakhel
i2s clock rate is not set to 12MHz currently. Set it before enabling the clock. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- V2 changes: Removed clk_prepare_enable call as clock was already being enabled elsewhere. Just set rate to 12MHz. --- sound/soc/jz4740/jz4740

[PATCH_V2 1/4] sound: soc: jz4740: Add dynamic sampling rate support to jz4740-i2s

2015-01-26 Thread Zubair Lutfullah Kakakhel
div registers Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- V2 changes: Removed a redundant #define --- sound/soc/jz4740/jz4740-i2s.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740

[PATCH_V2 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s

2015-01-26 Thread Zubair Lutfullah Kakakhel
This patch adds binding for the jz4740-i2s driver. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- The jz4740 is platform only at the moment. But DT support is being added See http://patchwork.linux-mips.org/bundle/paulburton/ci20-v3.20/ V2 changes: Added DMA bindings

[PATCH_V3 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s

2015-01-26 Thread Zubair Lutfullah Kakakhel
This patch adds binding for the jz4740-i2s driver. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- The jz4740 is platform only at the moment. But DT support is being added See http://patchwork.linux-mips.org/bundle/paulburton/ci20-v3.20/ V3 changes: Missed out adding

[PATCH_V3 3/4] sound: soc: jz4740: Add DT support to jz4740-i2s driver

2015-01-26 Thread Zubair Lutfullah Kakakhel
This patch adds device tree support for the jz4740 driver. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- V2 changes: Added ifdef config_of --- sound/soc/jz4740/jz4740-i2s.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/sound/soc/jz4740/jz4740-i2s.c b

[PATCH_V3 0/4] sound:soc: jz4740: DT, dynamic sampling, enable clocks

2015-01-26 Thread Zubair Lutfullah Kakakhel
Added dma in binding document Removed a redundant call to clk_prepare_enable Zubair Lutfullah Kakakhel (4): sound: soc: jz4740: Add dynamic sampling rate support to jz4740-i2s dt: sound: jz4740: Add binding documentation for jz4740-i2s sound: soc: jz4740: Add DT support to jz4740-i2s driver

[PATCH_V3 1/4] sound: soc: jz4740: Add dynamic sampling rate support to jz4740-i2s

2015-01-26 Thread Zubair Lutfullah Kakakhel
div registers Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- V2 changes: Removed a redundant #define --- sound/soc/jz4740/jz4740-i2s.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740

[PATCH_V2 21/34] MIPS: jz4740: only detect RAM size if not specified in DT

2015-02-04 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com Allow a devicetree to specify the memory present in the system rather than probing it from the memory controller. This both saves the probing for systems where the amount of memory is fixed, and will simplify the bringup of later jz47xx series SoCs where

[PATCH_V2 29/34] clk: add Ingenic jz4780 CGU driver

2015-02-04 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com Add support for the clocks provided by the CGU in the Ingenic jz4780 SoC, making use of the jz47xx-cgu code to do the heavy lifting. Signed-off-by: Paul Burton paul.bur...@imgtec.com Cc: Lars-Peter Clausen l...@metafoo.de Cc: Mike Turquette

[PATCH_V2 24/34] dt: serial: Add ingenic,jz4740-uart binding

2015-02-04 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com Add binding documentation for Ingenic jz4740 UARTs. Signed-off-by: Paul Burton paul.bur...@imgtec.com Cc: Lars-Peter Clausen l...@metafoo.de Cc: devicet...@vger.kernel.org --- .../bindings/serial/ingenic,jz4740-uart.txt| 22 ++

[PATCH_V2 30/34] MIPS: jz4740: add jz4780 interrupt controller support

2015-02-04 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com Allow the jz4780 interrupt controller to be probed from devicetree, supporting the 64 interrupts it provides. Signed-off-by: Paul Burton paul.bur...@imgtec.com Cc: Lars-Peter Clausen l...@metafoo.de --- arch/mips/jz4740/irq.c | 7 +++ 1 file changed,

[PATCH_V2 08/34] MIPS: jz4740: allow interrupt controller probe via DT

2015-02-04 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com Declare the interrupt controller for probe via the standard irqchip_init function. Signed-off-by: Paul Burton paul.bur...@imgtec.com Cc: Lars-Peter Clausen l...@metafoo.de --- arch/mips/jz4740/irq.c | 26 -- 1 file changed, 24

[PATCH_V2 28/34] dt: clk: Add ingenic,jz4780-cgu binding documentation

2015-02-04 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com Document the devictree binding for the Ingenic jz4780 CGU driver. Signed-off-by: Paul Burton paul.bur...@imgtec.com Cc: Lars-Peter Clausen l...@metafoo.de Cc: Mike Turquette mturque...@linaro.org Cc: devicet...@vger.kernel.org ---

[PATCH_V2 09/34] MIPS: jz4740: probe interrupt controller via DT

2015-02-04 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com Add the appropriate DT node to probe the interrupt controller driver using the devicetree, and remove the call to jz4740_intc_init. Signed-off-by: Paul Burton paul.bur...@imgtec.com Cc: Lars-Peter Clausen l...@metafoo.de ---

[PATCH_V2 25/34] serial: 8250_jz47xx: support for Ingenic jz47xx UARTs

2015-02-04 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com Introduce a driver suitable for use with the UARTs present in Ingenic jz47xx series SoCs. These are described as being ns16550 compatible but aren't quite - they require the setting of an extra bit in the FCR register to enable the UART module. The

[PATCH_V2 22/34] MIPS: jz4740: support 32 interrupts

2015-02-04 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com On later jz47xx series SoCs the interrupt controller supports more than 32 interrupts, which it does by duplicating the registers at intervals of 0x20 bytes within its address space. Add support for an arbitrary number of interrupts using multiple generic

[PATCH_V2 26/34] MIPS: allow mach-provided serial.h

2015-02-04 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com Allow platforms to set BAUD_BASE, which is used by earlycon to calculate the baud clock. Signed-off-by: Paul Burton paul.bur...@imgtec.com Cc: Lars-Peter Clausen l...@metafoo.de --- V2 Removed FSF address --- arch/mips/include/asm/Kbuild

[PATCH_V2 27/34] MIPS: jz4740: use jz47xx-uart DT for UART output

2015-02-04 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com Remove the serial support from arch/mips/jz4740 make use of the new jz47xx-uart driver. This is done for both regular early console output. Signed-off-by: Paul Burton paul.bur...@imgtec.com Cc: Lars-Peter Clausen l...@metafoo.de --- V2 Removed FSF

[PATCH_V2 10/34] MIPS: jz4740: remove non-DT interrupt controller init

2015-02-04 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com The jz4740 now probes the interrupt controller using DT, so remove the now dead non-DT init code. Signed-off-by: Paul Burton paul.bur...@imgtec.com Cc: Lars-Peter Clausen l...@metafoo.de --- arch/mips/include/asm/mach-jz4740/irq.h | 2 --

[PATCH_V2 12/34] MIPS: jz4740: call jz4740_clock_init earlier

2015-02-04 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com Call jz4740_clock_init before any uses of jz4740_clock_bdata occur. This is in preparation for replacing uses of that struct with calls to clk_get_rate, which will allow the clocks to be migrated towards common clock framework devicetree. Signed-off-by:

<    1   2   3   4   5   6   7   8   9   10   >