RE: [PATCH 1/2] Input: elan_i2c - Add new trackpoint report type 0x5F.

HI Dmitry: I would prefer if we validated report length versus the packet type before accepting it. -> If the tracking point report is 0x5F, the report length is 7, but the touchpad report length is 32. -> So, report length will be different with this module. THANKS JINGLE -Or

RE: [PATCH] Input: elantech - Remove read/write registers in attr.

HI Dmitry: These changes would not affect all the behavior of the old IC, including all the TP functions THANKS JINGLE -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Tuesday, May 26, 2020 12:17 PM To: Jingle.Wu Cc: linux-kernel@vger.kernel.org; linux

RE: [PATCH 2/2] Input: elan_i2c - Modify the IAP related functio n for page sizes 128, 512 bytes.

20 at 06:27:19PM -0700, Dmitry Torokhov wrote: > Hi Jingle, > > On Thu, Jul 16, 2020 at 02:15:23PM +0800, jingle.wu wrote: > > HI Dmitry: > > > > Just to confirm, the older devices (I assume that pattern 0 means > > older) have version command that is numerically

RE: [PATCH 2/2] Input: elan_i2c - Modify the IAP related functio n for page sizes 128, 512 bytes.

uot;static int elan_i2c_prepare_fw_update(struct i2c_client *client, u16 ic_type, u8 iap_version)" function. The ic is old pattern must be modify correct ic_type. (cmd is ETP_I2C_IAP_VERSION) THANKS -Original Message- From: jingle [mailto:jingle...@emc.com.tw] Sent: Friday, July 17, 2020 4:20 PM To: '

RE: [PATCH 1/2] Input: elan_i2c - Add ic type 0x11 0x13 0x14.

mailto:dmitry.torok...@gmail.com] Sent: Sunday, July 12, 2020 2:09 PM To: Jingle Wu Cc: linux-kernel@vger.kernel.org; linux-in...@vger.kernel.org; phoe...@emc.com.tw; josh.c...@emc.com.tw; dave.w...@emc.com.tw Subject: Re: [PATCH 1/2] Input: elan_i2c - Add ic type 0x11 0x13 0x14. Hi Jingle, On Fri, Jul 10,

RE: [PATCH 1/2] Input: elan_i2c - Add ic type 0x11 0x13 0x14.

; + u8 *page_store = kcalloc(1, fw_page_size + 4, GFP_KERNEL); Why kcalloc()? kzalloc() if you want cleared memoryi, but I think kmalloc would be fine. --> Yes, we want to clear the memory. THANKS -Original Message----- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent

RE: [PATCH 2/2] Input: elan_i2c - High resolution report for new pattern 2.

lso execute 16 bit value. THANKS -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Monday, July 13, 2020 3:11 AM To: Jingle Wu Cc: linux-kernel@vger.kernel.org; linux-in...@vger.kernel.org; phoe...@emc.com.tw; josh.c...@emc.com.tw; dave.w...@emc.com.tw Subject: R

RE: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

ks" is equal 0 at probe state.) THANKS JINGLE -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Friday, March 05, 2021 8:55 AM To: jingle.wu Cc: linux-kernel; linux-input; phoenix; dave.wang; josh.chen Subject: Re: [PATCH] Input: elan_i2c - Reduce the resu

RE: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

HI Dmitry: 1. You mean to let all devices ignore skipping reset/sleep part of device initialization? 2. The test team found that some old firmware will have errors (invalid report etc...), so ELAN can only ensure that the new device can meet the newer parts. Thanks jingle -Original Message

RE: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

%d\n", error); -> https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ref -> s/heads/chromeos-5.4/drivers/input/mouse/elan_i2c_core.c#1434 -> error = elan_initialize(data); this code is in elan_reactivate() function at Chromeos driver. -> Will this change affect cherrypick fro

[PATCH] Input: elan_i2c - Add ic type 0x15.

The update firmware flow of ic type 0x15 is same with ic type 0x14. Signed-off-by: Jingle Wu --- drivers/input/mouse/elan_i2c_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c index

[PATCH] Input: elan_i2c - Add ic type 0x14, modify the iap method for all IC.

The 0x14 is 512 page size. Signed-off-by: Jingle Wu --- drivers/input/mouse/elan_i2c.h | 3 ++- drivers/input/mouse/elan_i2c_core.c | 16 drivers/input/mouse/elan_i2c_i2c.c | 24 drivers/input/mouse/elan_i2c_smbus.c | 2 +- 4 files changed

[PATCH 2/2] Input: elan_i2c - Modify the IAP related function for page sizes 128, 512 bytes.

Get the correct value of ic_type for old and new firmware. Add page sizes 128, 512 bytes for update firmware flow. Signed-off-by: Jingle Wu --- drivers/input/mouse/elan_i2c.h | 7 +- drivers/input/mouse/elan_i2c_core.c | 46 ++- drivers/input/mouse/elan_i2c_i2c.c | 115

[PATCH 1/2] Input: elan_i2c - Add ic type 0x11, 0x13, 0x14.

Add ic type 0x11, 0x13, 0x14 page sizes for update firmware. Signed-off-by: Jingle Wu . --- drivers/input/mouse/elan_i2c_core.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c index 3f9354baac4b..e90beada0ecf

[PATCH 1/2] Input: elan_i2c - Add ic type 0x11 0x13 0x14.

Modify the iap method for all IC. Get the correct value of ic_type for old and new pattern of firmware. Signed-off-by: Jingle Wu --- drivers/input/mouse/elan_i2c.h | 6 +- drivers/input/mouse/elan_i2c_core.c | 52 - drivers/input/mouse/elan_i2c_i2c.c | 109

[PATCH 2/2] Input: elan_i2c - High resolution report for new pattern 2.

in the report packet. Signed-off-by: Jingle Wu --- drivers/input/mouse/elan_i2c.h | 7 +- drivers/input/mouse/elan_i2c_core.c | 134 +++ drivers/input/mouse/elan_i2c_i2c.c | 48 +++--- drivers/input/mouse/elan_i2c_smbus.c | 14 ++- 4 files changed, 170 insertions