Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression

On 2018/12/28 上午10:55, Waiman Long wrote: > On 12/27/2018 08:31 PM, Wang, Kemi wrote: >> Hi, Waiman >>Did you post that patch? Let's see if it helps. > > I did post the patch a while ago. I will need to rebase it to a new > baseline. Will do that in a week or 2. &

RE: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression

Hi, Waiman Did you post that patch? Let's see if it helps. -Original Message- From: LKP [mailto:lkp-boun...@lists.01.org] On Behalf Of Waiman Long Sent: Tuesday, November 6, 2018 6:40 AM To: Linus Torvalds ; vba...@suse.cz; Davidlohr Bueso Cc: yang@linux.alibaba.com; Linux Kernel

Re: [LKP] [lkp-robot] [brd] 316ba5736c: aim7.jobs-per-min -11.2% regression

Hi, All Do we have special reason to keep this patch (316ba5736c9:brd: Mark as non-rotational). which leads to a performance regression when BRD is used as a disk on btrfs. On 2018/7/10 下午1:27, kemi wrote: > Hi, SeongJae > Do you have any input for this regression? thanks > > On

RE: [LKP] [lkp-robot] [brd] 316ba5736c: aim7.jobs-per-min -11.2% regression

Hi, SeongJae Any update or any info you need from my side? -Original Message- From: SeongJae Park [mailto:sj38.p...@gmail.com] Sent: Wednesday, July 11, 2018 12:53 AM To: Wang, Kemi Cc: Ye, Xiaolong ; ax...@kernel.dk; ax...@fb.com; l...@01.org; linux-kernel@vger.kernel.org Subject: Re

RE: [LKP] [lkp-robot] [brd] 316ba5736c: aim7.jobs-per-min -11.2% regression

Hi, SeongJae Any update or any info you need from my side? -Original Message- From: SeongJae Park [mailto:sj38.p...@gmail.com] Sent: Wednesday, July 11, 2018 12:53 AM To: Wang, Kemi Cc: Ye, Xiaolong ; ax...@kernel.dk; ax...@fb.com; l...@01.org; linux-kernel@vger.kernel.org Subject: Re

Re: [LKP] [lkp-robot] [brd] 316ba5736c: aim7.jobs-per-min -11.2% regression

Hi, SeongJae Do you have any input for this regression? thanks On 2018年06月04日 13:52, kernel test robot wrote: > > Greeting, > > FYI, we noticed a -11.2% regression of aim7.jobs-per-min due to commit: > > > commit: 316ba5736c9caa5dbcd84085989862d2df57431d ("brd: Mark as > non-rotational") >

Re: [LKP] [lkp-robot] [brd] 316ba5736c: aim7.jobs-per-min -11.2% regression

Hi, SeongJae Do you have any input for this regression? thanks On 2018年06月04日 13:52, kernel test robot wrote: > > Greeting, > > FYI, we noticed a -11.2% regression of aim7.jobs-per-min due to commit: > > > commit: 316ba5736c9caa5dbcd84085989862d2df57431d ("brd: Mark as > non-rotational") >

RE: [PATCH v11 00/26] Speculative page faults

@gmail.com; Andrea Arcangeli <aarca...@redhat.com>; Alexei Starovoitov <alexei.starovoi...@gmail.com>; Wang, Kemi <kemi.w...@intel.com>; Daniel Jordan <daniel.m.jor...@oracle.com>; David Rientjes <rient...@google.com>; Jerome Glisse <jgli...@redhat.com>; Ganesh M

RE: [PATCH v11 00/26] Speculative page faults

; pau...@samba.org; Thomas Gleixner ; Ingo Molnar ; h...@zytor.com; Will Deacon ; Sergey Senozhatsky ; sergey.senozhatsky.w...@gmail.com; Andrea Arcangeli ; Alexei Starovoitov ; Wang, Kemi ; Daniel Jordan ; David Rientjes ; Jerome Glisse ; Ganesh Mahendran ; Minchan Kim ; Punit Agrawal

Re: [LKP] [lkp-robot] [iversion] c0cef30e4f: aim7.jobs-per-min -18.0% regression

Hi, Jeff Today, I deleted the previous kernel images for commit 3da90b159b146672f830bcd2489dd3a1f4e9e089 and commit c0cef30e4ff0dc025f4a1660b8f0ba43ed58426e, respectively. And, re-run the same aim7 jobs for three times for each commit. The aim7 score between two commit does not have obvious

Re: [LKP] [lkp-robot] [iversion] c0cef30e4f: aim7.jobs-per-min -18.0% regression

Hi, Jeff Today, I deleted the previous kernel images for commit 3da90b159b146672f830bcd2489dd3a1f4e9e089 and commit c0cef30e4ff0dc025f4a1660b8f0ba43ed58426e, respectively. And, re-run the same aim7 jobs for three times for each commit. The aim7 score between two commit does not have obvious

Re: [LKP] [lkp-robot] [iversion] c0cef30e4f: aim7.jobs-per-min -18.0% regression

On 2018年02月28日 01:04, Linus Torvalds wrote: > On Tue, Feb 27, 2018 at 5:43 AM, David Howells wrote: >> Is it possible there's a stall between the load of RCX and the subsequent >> instructions because they all have to wait for RCX to become available? > > No. Modern Intel

Re: [LKP] [lkp-robot] [iversion] c0cef30e4f: aim7.jobs-per-min -18.0% regression

On 2018年02月28日 01:04, Linus Torvalds wrote: > On Tue, Feb 27, 2018 at 5:43 AM, David Howells wrote: >> Is it possible there's a stall between the load of RCX and the subsequent >> instructions because they all have to wait for RCX to become available? > > No. Modern Intel big-core CPU's simply

Re: [LKP] [lkp-robot] [iversion] c0cef30e4f: aim7.jobs-per-min -18.0% regression

On 2018年02月26日 20:33, Jeff Layton wrote: > On Mon, 2018-02-26 at 06:43 -0500, Jeff Layton wrote: >> On Mon, 2018-02-26 at 16:38 +0800, Ye Xiaolong wrote: >>> On 02/25, Jeff Layton wrote: On Sun, 2018-02-25 at 23:05 +0800, kernel test robot wrote: > Greeting, > > FYI, we noticed

Re: [LKP] [lkp-robot] [iversion] c0cef30e4f: aim7.jobs-per-min -18.0% regression

On 2018年02月26日 20:33, Jeff Layton wrote: > On Mon, 2018-02-26 at 06:43 -0500, Jeff Layton wrote: >> On Mon, 2018-02-26 at 16:38 +0800, Ye Xiaolong wrote: >>> On 02/25, Jeff Layton wrote: On Sun, 2018-02-25 at 23:05 +0800, kernel test robot wrote: > Greeting, > > FYI, we noticed

Re: [PATCH v2] buffer: Avoid setting buffer bits that are already set

Hi, Jens Could you help to merge this patch to your tree? Thanks On 2017年11月03日 10:29, kemi wrote: > > > On 2017年10月24日 09:16, Kemi Wang wrote: >> It's expensive to set buffer flags that are already set, because that >> causes a costly cache line transition. >>

Re: [PATCH v2] buffer: Avoid setting buffer bits that are already set

Hi, Jens Could you help to merge this patch to your tree? Thanks On 2017年11月03日 10:29, kemi wrote: > > > On 2017年10月24日 09:16, Kemi Wang wrote: >> It's expensive to set buffer flags that are already set, because that >> causes a costly cache line transition. >>

Re: [PATCH v2 3/5] mm: enlarge NUMA counters threshold size

On 2017年12月22日 01:10, Christopher Lameter wrote: > On Thu, 21 Dec 2017, kemi wrote: > >> Some thinking about that: >> a) the overhead due to cache bouncing caused by NUMA counter update in fast >> path >> severely increase with more and more CPUs cores >>

Re: [PATCH v2 3/5] mm: enlarge NUMA counters threshold size

On 2017年12月22日 01:10, Christopher Lameter wrote: > On Thu, 21 Dec 2017, kemi wrote: > >> Some thinking about that: >> a) the overhead due to cache bouncing caused by NUMA counter update in fast >> path >> severely increase with more and more CPUs cores >>

Re: [PATCH v2 3/5] mm: enlarge NUMA counters threshold size

On 2017年12月21日 16:59, Michal Hocko wrote: > On Thu 21-12-17 16:23:23, kemi wrote: >> >> >> On 2017年12月21日 16:17, Michal Hocko wrote: > [...] >>> Can you see any difference with a more generic workload? >>> >> >> I didn't see obvious im

Re: [PATCH v2 3/5] mm: enlarge NUMA counters threshold size

On 2017年12月21日 16:59, Michal Hocko wrote: > On Thu 21-12-17 16:23:23, kemi wrote: >> >> >> On 2017年12月21日 16:17, Michal Hocko wrote: > [...] >>> Can you see any difference with a more generic workload? >>> >> >> I didn't see obvious im

Re: [PATCH v2 3/5] mm: enlarge NUMA counters threshold size

On 2017年12月21日 16:17, Michal Hocko wrote: > On Thu 21-12-17 16:06:50, kemi wrote: >> >> >> On 2017年12月20日 18:12, Michal Hocko wrote: >>> On Wed 20-12-17 13:52:14, kemi wrote: >>>> >>>> >>>> On 2017年12月19日 20:40, Michal Hocko wrot

Re: [PATCH v2 3/5] mm: enlarge NUMA counters threshold size

On 2017年12月21日 16:17, Michal Hocko wrote: > On Thu 21-12-17 16:06:50, kemi wrote: >> >> >> On 2017年12月20日 18:12, Michal Hocko wrote: >>> On Wed 20-12-17 13:52:14, kemi wrote: >>>> >>>> >>>> On 2017年12月19日 20:40, Michal Hocko wrot

Re: [PATCH v2 3/5] mm: enlarge NUMA counters threshold size

On 2017年12月20日 18:12, Michal Hocko wrote: > On Wed 20-12-17 13:52:14, kemi wrote: >> >> >> On 2017年12月19日 20:40, Michal Hocko wrote: >>> On Tue 19-12-17 14:39:24, Kemi Wang wrote: >>>> We have seen significant overhead in cache bouncing caused by NUMA c

Re: [PATCH v2 3/5] mm: enlarge NUMA counters threshold size

On 2017年12月20日 18:12, Michal Hocko wrote: > On Wed 20-12-17 13:52:14, kemi wrote: >> >> >> On 2017年12月19日 20:40, Michal Hocko wrote: >>> On Tue 19-12-17 14:39:24, Kemi Wang wrote: >>>> We have seen significant overhead in cache bouncing caused by NUMA c

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

On 2017年12月20日 23:58, Christopher Lameter wrote: > On Wed, 20 Dec 2017, kemi wrote: > >>> You are making numastats special and I yet haven't heard any sounds >>> arguments for that. But that should be discussed in the respective >>> patch. >>> >>

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

On 2017年12月20日 23:58, Christopher Lameter wrote: > On Wed, 20 Dec 2017, kemi wrote: > >>> You are making numastats special and I yet haven't heard any sounds >>> arguments for that. But that should be discussed in the respective >>> patch. >>> >>

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

On 2017年12月20日 18:06, Michal Hocko wrote: > On Wed 20-12-17 14:07:35, kemi wrote: >> >> >> On 2017年12月19日 20:43, Michal Hocko wrote: >>> On Tue 19-12-17 14:39:25, Kemi Wang wrote: >>>> To avoid deviation, this patch uses node_page_state_snapshot ins

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

On 2017年12月20日 18:06, Michal Hocko wrote: > On Wed 20-12-17 14:07:35, kemi wrote: >> >> >> On 2017年12月19日 20:43, Michal Hocko wrote: >>> On Tue 19-12-17 14:39:25, Kemi Wang wrote: >>>> To avoid deviation, this patch uses node_page_state_snapshot ins

Re: [PATCH v2 3/5] mm: enlarge NUMA counters threshold size

On 2017年12月20日 18:12, Michal Hocko wrote: > On Wed 20-12-17 13:52:14, kemi wrote: >> >> >> On 2017年12月19日 20:40, Michal Hocko wrote: >>> On Tue 19-12-17 14:39:24, Kemi Wang wrote: >>>> We have seen significant overhead in cache bouncing caused by NUMA c

Re: [PATCH v2 3/5] mm: enlarge NUMA counters threshold size

On 2017年12月20日 18:12, Michal Hocko wrote: > On Wed 20-12-17 13:52:14, kemi wrote: >> >> >> On 2017年12月19日 20:40, Michal Hocko wrote: >>> On Tue 19-12-17 14:39:24, Kemi Wang wrote: >>>> We have seen significant overhead in cache bouncing caused by NUMA c

Re: [PATCH v2 2/5] mm: Extends local cpu counter vm_diff_nodestat from s8 to s16

On 2017年12月20日 01:21, Christopher Lameter wrote: > On Tue, 19 Dec 2017, Michal Hocko wrote: > >>> Well the reason for s8 was to keep the data structures small so that they >>> fit in the higher level cpu caches. The large these structures become the >>> more cachelines are used by the counters

Re: [PATCH v2 2/5] mm: Extends local cpu counter vm_diff_nodestat from s8 to s16

On 2017年12月20日 01:21, Christopher Lameter wrote: > On Tue, 19 Dec 2017, Michal Hocko wrote: > >>> Well the reason for s8 was to keep the data structures small so that they >>> fit in the higher level cpu caches. The large these structures become the >>> more cachelines are used by the counters

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

On 2017年12月19日 20:43, Michal Hocko wrote: > On Tue 19-12-17 14:39:25, Kemi Wang wrote: >> To avoid deviation, this patch uses node_page_state_snapshot instead of >> node_page_state for node page stats query. >> e.g. cat /proc/zoneinfo >> cat /sys/devices/system/no

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

On 2017年12月19日 20:43, Michal Hocko wrote: > On Tue 19-12-17 14:39:25, Kemi Wang wrote: >> To avoid deviation, this patch uses node_page_state_snapshot instead of >> node_page_state for node page stats query. >> e.g. cat /proc/zoneinfo >> cat /sys/devices/system/no

Re: [PATCH v2 3/5] mm: enlarge NUMA counters threshold size

On 2017年12月19日 20:40, Michal Hocko wrote: > On Tue 19-12-17 14:39:24, Kemi Wang wrote: >> We have seen significant overhead in cache bouncing caused by NUMA counters >> update in multi-threaded page allocation. See 'commit 1d90ca897cb0 ("mm: >> update NUMA counter

Re: [PATCH v2 3/5] mm: enlarge NUMA counters threshold size

On 2017年12月19日 20:40, Michal Hocko wrote: > On Tue 19-12-17 14:39:24, Kemi Wang wrote: >> We have seen significant overhead in cache bouncing caused by NUMA counters >> update in multi-threaded page allocation. See 'commit 1d90ca897cb0 ("mm: >> update NUMA counter

Re: [PATCH v2 1/5] mm: migrate NUMA stats from per-zone to per-node

On 2017年12月19日 20:28, Michal Hocko wrote: > On Tue 19-12-17 14:39:22, Kemi Wang wrote: >> There is not really any use to get NUMA stats separated by zone, and >> current per-zone NUMA stats is only consumed in /proc/zoneinfo. For code >> cleanup purpose, we move NUMA stats

Re: [PATCH v2 1/5] mm: migrate NUMA stats from per-zone to per-node

On 2017年12月19日 20:28, Michal Hocko wrote: > On Tue 19-12-17 14:39:22, Kemi Wang wrote: >> There is not really any use to get NUMA stats separated by zone, and >> current per-zone NUMA stats is only consumed in /proc/zoneinfo. For code >> cleanup purpose, we move NUMA stats

Re: [PATCH v2 2/5] mm: Extends local cpu counter vm_diff_nodestat from s8 to s16

On 2017年12月19日 20:38, Michal Hocko wrote: > On Tue 19-12-17 14:39:23, Kemi Wang wrote: >> The type s8 used for vm_diff_nodestat[] as local cpu counters has the >> limitation of global counters update frequency, especially for those >> monotone increasing type of counte

Re: [PATCH v2 2/5] mm: Extends local cpu counter vm_diff_nodestat from s8 to s16

On 2017年12月19日 20:38, Michal Hocko wrote: > On Tue 19-12-17 14:39:23, Kemi Wang wrote: >> The type s8 used for vm_diff_nodestat[] as local cpu counters has the >> limitation of global counters update frequency, especially for those >> monotone increasing type of counte

[PATCH v2 1/5] mm: migrate NUMA stats from per-zone to per-node

com> Suggested-by: Michal Hocko <mho...@kernel.com> Signed-off-by: Kemi Wang <kemi.w...@intel.com> --- drivers/base/node.c| 23 +++ include/linux/mmzone.h | 27 include/linux/vmstat.h | 31 - mm/mempolicy.c | 2 +- mm/page_alloc.c| 16

[PATCH v2 1/5] mm: migrate NUMA stats from per-zone to per-node

Hocko Signed-off-by: Kemi Wang --- drivers/base/node.c| 23 +++ include/linux/mmzone.h | 27 include/linux/vmstat.h | 31 - mm/mempolicy.c | 2 +- mm/page_alloc.c| 16 +++-- mm/vmstat.c| 177

[PATCH v2 5/5] mm: Rename zone_statistics() to numa_statistics()

Since the functionality of zone_statistics() updates numa counters, but numa statistics has been separated from zone statistics framework. Thus, the function name makes people confused. So, change the name to numa_statistics() as well as its call sites accordingly. Signed-off-by: Kemi Wang

[PATCH v2 5/5] mm: Rename zone_statistics() to numa_statistics()

Since the functionality of zone_statistics() updates numa counters, but numa statistics has been separated from zone statistics framework. Thus, the function name makes people confused. So, change the name to numa_statistics() as well as its call sites accordingly. Signed-off-by: Kemi Wang

[PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

worry about it. Signed-off-by: Kemi Wang <kemi.w...@intel.com> --- drivers/base/node.c | 17 ++--- mm/vmstat.c | 2 +- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index a045ea1..cf303f8 100644 --- a/driver

[PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

worry about it. Signed-off-by: Kemi Wang --- drivers/base/node.c | 17 ++--- mm/vmstat.c | 2 +- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index a045ea1..cf303f8 100644 --- a/drivers/base/node.c +++ b/drivers

[PATCH v2 2/5] mm: Extends local cpu counter vm_diff_nodestat from s8 to s16

any functionality change. before after sizeof(struct per_cpu_nodestat)28 68 Signed-off-by: Kemi Wang <kemi.w...@intel.com> --- include/linux/mmzone.h | 4 ++-- mm/vmstat.c| 16 2 files changed, 10 insertions(

[PATCH v2 3/5] mm: enlarge NUMA counters threshold size

ith global counter update using different threshold size for node page stats. Signed-off-by: Kemi Wang <kemi.w...@intel.com> --- mm/vmstat.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index 9c681cc..64e08ae 100644 --- a/mm/v

[PATCH v2 2/5] mm: Extends local cpu counter vm_diff_nodestat from s8 to s16

any functionality change. before after sizeof(struct per_cpu_nodestat)28 68 Signed-off-by: Kemi Wang --- include/linux/mmzone.h | 4 ++-- mm/vmstat.c| 16 2 files changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH v2 3/5] mm: enlarge NUMA counters threshold size

ith global counter update using different threshold size for node page stats. Signed-off-by: Kemi Wang --- mm/vmstat.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index 9c681cc..64e08ae 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -

[PATCH v2 0/5] mm: NUMA stats code cleanup and enhancement

ucture for node page stats by entending local cpu counters vm_node_stat_diff from s8 to s16 b) reuse the per-cpu infrastrcuture for NUMA stats Kemi Wang (5): mm: migrate NUMA stats from per-zone to per-node mm: Extends local cpu counter vm_diff_nodestat from s8 to s16 mm: enlarge NUMA co

[PATCH v2 0/5] mm: NUMA stats code cleanup and enhancement

ucture for node page stats by entending local cpu counters vm_node_stat_diff from s8 to s16 b) reuse the per-cpu infrastrcuture for NUMA stats Kemi Wang (5): mm: migrate NUMA stats from per-zone to per-node mm: Extends local cpu counter vm_diff_nodestat from s8 to s16 mm: enlarge NUMA co

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

On 2017年12月14日 15:29, Michal Hocko wrote: > On Thu 14-12-17 09:40:32, kemi wrote: >> >> >> or sometimes >> NUMA stats can't be disabled in their environments. > > why? > >> That's the reason >> why we spent time to do that optimization oth

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

On 2017年12月14日 15:29, Michal Hocko wrote: > On Thu 14-12-17 09:40:32, kemi wrote: >> >> >> or sometimes >> NUMA stats can't be disabled in their environments. > > why? > >> That's the reason >> why we spent time to do that optimization oth

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

On 2017年12月12日 16:11, Michal Hocko wrote: > On Tue 12-12-17 10:05:26, kemi wrote: >> >> >> On 2017年12月08日 16:47, Michal Hocko wrote: >>> On Fri 08-12-17 16:38:46, kemi wrote: >>>> >>>> >>>> On 2017年11月30日 17:45, Michal Hocko

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

On 2017年12月12日 16:11, Michal Hocko wrote: > On Tue 12-12-17 10:05:26, kemi wrote: >> >> >> On 2017年12月08日 16:47, Michal Hocko wrote: >>> On Fri 08-12-17 16:38:46, kemi wrote: >>>> >>>> >>>> On 2017年11月30日 17:45, Michal Hocko

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

On 2017年12月08日 16:47, Michal Hocko wrote: > On Fri 08-12-17 16:38:46, kemi wrote: >> >> >> On 2017年11月30日 17:45, Michal Hocko wrote: >>> On Thu 30-11-17 17:32:08, kemi wrote: >> >> After thinking about how to optimize our per-node stats more gracef

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

On 2017年12月08日 16:47, Michal Hocko wrote: > On Fri 08-12-17 16:38:46, kemi wrote: >> >> >> On 2017年11月30日 17:45, Michal Hocko wrote: >>> On Thu 30-11-17 17:32:08, kemi wrote: >> >> After thinking about how to optimize our per-node stats more gracef

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

On 2017年11月30日 17:45, Michal Hocko wrote: > On Thu 30-11-17 17:32:08, kemi wrote: > Do not get me wrong. If we want to make per-node stats more optimal, > then by all means let's do that. But having 3 sets of counters is just > way to much. > Hi, Michal Apologize t

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

On 2017年11月30日 17:45, Michal Hocko wrote: > On Thu 30-11-17 17:32:08, kemi wrote: > Do not get me wrong. If we want to make per-node stats more optimal, > then by all means let's do that. But having 3 sets of counters is just > way to much. > Hi, Michal Apologize t

RE: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

Of course, we should do that AFAP. Thanks for your comments :) -Original Message- From: owner-linux...@kvack.org [mailto:owner-linux...@kvack.org] On Behalf Of Michal Hocko Sent: Thursday, November 30, 2017 5:45 PM To: Wang, Kemi <kemi.w...@intel.com> Cc: Greg Kroah-Hartma

RE: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

Of course, we should do that AFAP. Thanks for your comments :) -Original Message- From: owner-linux...@kvack.org [mailto:owner-linux...@kvack.org] On Behalf Of Michal Hocko Sent: Thursday, November 30, 2017 5:45 PM To: Wang, Kemi Cc: Greg Kroah-Hartman ; Andrew Morton ; Vlastimil Babka

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

On 2017年11月30日 16:53, Michal Hocko wrote: > On Thu 30-11-17 13:56:13, kemi wrote: >> >> >> On 2017年11月29日 20:17, Michal Hocko wrote: >>> On Tue 28-11-17 14:00:23, Kemi Wang wrote: >>>> The existed implementation of NUMA counters is per logical CPU alon

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

On 2017年11月30日 16:53, Michal Hocko wrote: > On Thu 30-11-17 13:56:13, kemi wrote: >> >> >> On 2017年11月29日 20:17, Michal Hocko wrote: >>> On Tue 28-11-17 14:00:23, Kemi Wang wrote: >>>> The existed implementation of NUMA counters is per logical CPU alon

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

On 2017年11月29日 20:17, Michal Hocko wrote: > On Tue 28-11-17 14:00:23, Kemi Wang wrote: >> The existed implementation of NUMA counters is per logical CPU along with >> zone->vm_numa_stat[] separated by zone, plus a global numa counter array >> vm_numa_stat[]. However,

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

On 2017年11月29日 20:17, Michal Hocko wrote: > On Tue 28-11-17 14:00:23, Kemi Wang wrote: >> The existed implementation of NUMA counters is per logical CPU along with >> zone->vm_numa_stat[] separated by zone, plus a global numa counter array >> vm_numa_stat[]. However,

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

On 2017年11月28日 16:09, Vlastimil Babka wrote: > On 11/28/2017 07:00 AM, Kemi Wang wrote: >> The existed implementation of NUMA counters is per logical CPU along with >> zone->vm_numa_stat[] separated by zone, plus a global numa counter array >> vm_numa_stat[]. However,

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

On 2017年11月28日 16:09, Vlastimil Babka wrote: > On 11/28/2017 07:00 AM, Kemi Wang wrote: >> The existed implementation of NUMA counters is per logical CPU along with >> zone->vm_numa_stat[] separated by zone, plus a global numa counter array >> vm_numa_stat[]. However,

[PATCH 2/2] mm: Rename zone_statistics() to numa_statistics()

Since numa statistics has been separated from zone statistics framework, but the functionality of zone_statistics() updates numa counters. Thus, the function name makes people confused. So, change the name to numa_statistics() as well as its call sites accordingly. Signed-off-by: Kemi Wang

[PATCH 2/2] mm: Rename zone_statistics() to numa_statistics()

Since numa statistics has been separated from zone statistics framework, but the functionality of zone_statistics() updates numa counters. Thus, the function name makes people confused. So, change the name to numa_statistics() as well as its call sites accordingly. Signed-off-by: Kemi Wang

[PATCH 1/2] mm: NUMA stats code cleanup and enhancement

sys 0m0.000s node/node*/numastat We would not worry it much as it is a slow path and will not be read frequently. Suggested-by: Andi Kleen <a...@linux.intel.com> Signed-off-by: Kemi Wang <kemi.w...@intel.com> --- drivers/base/node.c| 14 ++--- include/linux/mmzone.h |

[PATCH 1/2] mm: NUMA stats code cleanup and enhancement

sys 0m0.000s node/node*/numastat We would not worry it much as it is a slow path and will not be read frequently. Suggested-by: Andi Kleen Signed-off-by: Kemi Wang --- drivers/base/node.c| 14 ++--- include/linux/mmzone.h | 2 - include/linux/vmstat.h | 61 +---

Re: [01/18] x86/asm/64: Remove the restore_c_regs_and_iret label

Some performance regression/improvement is reported by LKP-tools for this patch series tested with Intel Atom processor. So, post the data here for your reference. Branch:x86/entry_consolidation Commit id: base:50da9d439392fdd91601d36e7f05728265bff262

Re: [01/18] x86/asm/64: Remove the restore_c_regs_and_iret label

Some performance regression/improvement is reported by LKP-tools for this patch series tested with Intel Atom processor. So, post the data here for your reference. Branch:x86/entry_consolidation Commit id: base:50da9d439392fdd91601d36e7f05728265bff262

Re: mm, vmstat: Make sure mutex is a global static

On 2017年11月08日 05:38, Kees Cook wrote: > The mutex in sysctl_vm_numa_stat_handler() needs to be a global static, not > a stack variable, otherwise it doesn't serve any purpose. Also, reading the > file with CONFIG_LOCKDEP=y will complain: > It's my mistake. Kees, thanks for catching it. > [

Re: mm, vmstat: Make sure mutex is a global static

On 2017年11月08日 05:38, Kees Cook wrote: > The mutex in sysctl_vm_numa_stat_handler() needs to be a global static, not > a stack variable, otherwise it doesn't serve any purpose. Also, reading the > file with CONFIG_LOCKDEP=y will complain: > It's my mistake. Kees, thanks for catching it. > [

Re: [PATCH v2] buffer: Avoid setting buffer bits that are already set

On 2017年10月24日 09:16, Kemi Wang wrote: > It's expensive to set buffer flags that are already set, because that > causes a costly cache line transition. > > A common case is setting the "verified" flag during ext4 writes. > This patch checks for the flag being set first.

Re: [PATCH v2] buffer: Avoid setting buffer bits that are already set

On 2017年10月24日 09:16, Kemi Wang wrote: > It's expensive to set buffer flags that are already set, because that > causes a costly cache line transition. > > A common case is setting the "verified" flag during ext4 writes. > This patch checks for the flag being set first.

Re: [v5,22/22] powerpc/mm: Add speculative page fault

Some regression is found by LKP-tools(linux kernel performance) on this patch series tested on Intel 2s/4s Skylake platform. The regression result is sorted by the metric will-it-scale.per_process_ops. Branch:Laurent-Dufour/Speculative-page-faults/20171011-213456(V4 patch series) Commit id:

Re: [v5,22/22] powerpc/mm: Add speculative page fault

Some regression is found by LKP-tools(linux kernel performance) on this patch series tested on Intel 2s/4s Skylake platform. The regression result is sorted by the metric will-it-scale.per_process_ops. Branch:Laurent-Dufour/Speculative-page-faults/20171011-213456(V4 patch series) Commit id:

Re: [PATCH] buffer: Avoid setting buffer bits that are already set

On 2017年10月24日 09:21, Andi Kleen wrote: > kemi <kemi.w...@intel.com> writes: >> >> I'll see if I can find some >>> time to implement the above in a nice way. >> >> Agree. Maybe something like test_and_set_bit() would be more suitable. > >

Re: [PATCH] buffer: Avoid setting buffer bits that are already set

On 2017年10月24日 09:21, Andi Kleen wrote: > kemi writes: >> >> I'll see if I can find some >>> time to implement the above in a nice way. >> >> Agree. Maybe something like test_and_set_bit() would be more suitable. > > test_and_set_bit is a ve

[PATCH v2] buffer: Avoid setting buffer bits that are already set

riginal patch is contributed by Andi Kleen. Signed-off-by: Andi Kleen <a...@linux.intel.com> Signed-off-by: Kemi Wang <kemi.w...@intel.com> Tested-by: Kemi Wang <kemi.w...@intel.com> Reviewed-by: Jens Axboe <ax...@kernel.dk> --- include/linux/buffer_head.h | 5 - 1 file

[PATCH v2] buffer: Avoid setting buffer bits that are already set

riginal patch is contributed by Andi Kleen. Signed-off-by: Andi Kleen Signed-off-by: Kemi Wang Tested-by: Kemi Wang Reviewed-by: Jens Axboe --- include/linux/buffer_head.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/linux/buffer_head.h b/include/linux/buffer

Re: [PATCH] buffer: Avoid setting buffer bits that are already set

On 2017年10月24日 00:19, Jens Axboe wrote: > On 10/23/2017 10:27 AM, Kemi Wang wrote: >> It's expensive to set buffer flags that are already set, because that >> causes a costly cache line transition. >> >> A common case is setting the "verified" flag dur

Re: [PATCH] buffer: Avoid setting buffer bits that are already set

On 2017年10月24日 00:19, Jens Axboe wrote: > On 10/23/2017 10:27 AM, Kemi Wang wrote: >> It's expensive to set buffer flags that are already set, because that >> causes a costly cache line transition. >> >> A common case is setting the "verified" flag dur

[PATCH] buffer: Avoid setting buffer bits that are already set

riginal patch is contributed by Andi Kleen. Signed-off-by: Andi Kleen <a...@linux.intel.com> Signed-off-by: Kemi Wang <kemi.w...@intel.com> Tested-by: Kemi Wang <kemi.w...@intel.com> --- include/linux/buffer_head.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

[PATCH] buffer: Avoid setting buffer bits that are already set

riginal patch is contributed by Andi Kleen. Signed-off-by: Andi Kleen Signed-off-by: Kemi Wang Tested-by: Kemi Wang --- include/linux/buffer_head.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/buffer_head.h b/include/linux/buffer_head.h index c8dae55..e

[PATCH v5] mm, sysctl: make NUMA stats configurable

ed-by: Jesper Dangaard Brouer <bro...@redhat.com> Suggested-by: Dave Hansen <dave.han...@intel.com> Suggested-by: Ying Huang <ying.hu...@intel.com> Signed-off-by: Kemi Wang <kemi.w...@intel.com> --- Documentation/sysctl/vm.txt | 16 +++ include/linux/vmstat.h

[PATCH v5] mm, sysctl: make NUMA stats configurable

Jesper Dangaard Brouer Suggested-by: Dave Hansen Suggested-by: Ying Huang Signed-off-by: Kemi Wang --- Documentation/sysctl/vm.txt | 16 +++ include/linux/vmstat.h | 10 +++ kernel/sysctl.c | 9 ++ mm/mempolicy.c | 3 ++ mm/page_alloc.c

Re: [PATCH v4] mm, sysctl: make NUMA stats configurable

On 2017年10月17日 15:54, Michal Hocko wrote: > On Tue 17-10-17 09:20:58, Kemi Wang wrote: > [...] > > Other than two remarks below, it looks good to me and it also looks > simpler. > >> diff --git a/mm/vmstat.c b/mm/vmstat.c >> index 4bb13e7..e746ed1 100644 &g

Re: [PATCH v4] mm, sysctl: make NUMA stats configurable

On 2017年10月17日 15:54, Michal Hocko wrote: > On Tue 17-10-17 09:20:58, Kemi Wang wrote: > [...] > > Other than two remarks below, it looks good to me and it also looks > simpler. > >> diff --git a/mm/vmstat.c b/mm/vmstat.c >> index 4bb13e7..e746ed1 100644 &g

[PATCH v4] mm, sysctl: make NUMA stats configurable

by: Jesper Dangaard Brouer <bro...@redhat.com> Suggested-by: Dave Hansen <dave.han...@intel.com> Suggested-by: Ying Huang <ying.hu...@intel.com> Signed-off-by: Kemi Wang <kemi.w...@intel.com> --- Documentation/sysctl/vm.txt | 16 +++ include/linux/vmstat.h |

[PATCH v4] mm, sysctl: make NUMA stats configurable

rted-by: Jesper Dangaard Brouer Suggested-by: Dave Hansen Suggested-by: Ying Huang Signed-off-by: Kemi Wang --- Documentation/sysctl/vm.txt | 16 +++ include/linux/vmstat.h | 10 +++ kernel/sysctl.c | 7 + mm/mempolicy.c | 3 ++ mm/page_alloc.c

Re: [PATCH v3] mm, sysctl: make NUMA stats configurable

On 2017年10月10日 13:49, Michal Hocko wrote: > On Mon 09-10-17 09:55:49, Michal Hocko wrote: >> I haven't checked closely but what happens (or should happen) when you >> do a partial read? Should you get an inconsistent results? Or is this >> impossible? > > Well, after thinking about it little

Re: [PATCH v3] mm, sysctl: make NUMA stats configurable

On 2017年10月10日 13:49, Michal Hocko wrote: > On Mon 09-10-17 09:55:49, Michal Hocko wrote: >> I haven't checked closely but what happens (or should happen) when you >> do a partial read? Should you get an inconsistent results? Or is this >> impossible? > > Well, after thinking about it little

Re: [PATCH v3] mm, sysctl: make NUMA stats configurable

On 2017年10月03日 17:23, Michal Hocko wrote: > On Thu 28-09-17 14:11:41, Kemi Wang wrote: >> This is the second step which introduces a tunable interface that allow >> numa stats configurable for optimizing zone_statistics(), as suggested by >> Dave

Re: [PATCH v3] mm, sysctl: make NUMA stats configurable

On 2017年10月03日 17:23, Michal Hocko wrote: > On Thu 28-09-17 14:11:41, Kemi Wang wrote: >> This is the second step which introduces a tunable interface that allow >> numa stats configurable for optimizing zone_statistics(), as suggested by >> Dave

Re: [PATCH v3] mm, sysctl: make NUMA stats configurable

On 2017年09月29日 15:03, Vlastimil Babka wrote: > On 09/28/2017 08:11 AM, Kemi Wang wrote: >> This is the second step which introduces a tunable interface that allow >> numa stats configurable for optimizing zone_statistics(), as suggested by >> Dave

  1   2   >