[PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/stub_dev.c |7 --- 1 file

[PATCH] staging: usbip: vhci_hcd: Fixed oops during removal of vhci_hcd

vhci_shoutdown_connection tries to kill kernel threads which are already killed. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/vhci_hcd.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index 12a9a5f..eea8298 100644

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Tue, Sep 18, 2012 at 1:10 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Sep 18, 2012 at 09:30:06AM +0530, navin patidar wrote: stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

in stub_shutdown_connection() but i used stub_device_reset() which is intended to reset usbip_device stuct member variables. i'll resend patches, if maintainer ask for that. thanks --navin-patidar On Tue, Sep 18, 2012 at 3:06 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Sep 18, 2012 at 03:02:15PM

[PATCH v2] staging: usbip: vhci_hcd: Fixed oops during removal of vhci_hcd

[ 312.231696] RSP 88004d6ebdb0 [ 312.233648] CR2: [ 312.256464] ---[ end trace 1971ce612a167279 ]--- Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/vhci_hcd.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH v2] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

] ---[ end trace 1971ce612a16727a ]--- Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/stub_dev.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c index 92ced35..c8d79a7 100644

[PATCH] staging: usbip: vhci_hcd: Fixed oops during removal of vhci_hcd

vhci_shoutdown_connection tries to kill kernel threads which are already killed. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/vhci_hcd.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index 6076f42..b1f427c 100644

[PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/stub_dev.c | 14 +- 1

[PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/stub_dev.c |7 --- 1 file

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

hi, I have sent this patch again with corrections. thank for reviewing the patch. --navin-patidar On 9/14/12, Sebastian Andrzej Siewior sebast...@breakpoint.cc wrote: On Fri, Sep 14, 2012 at 03:42:42PM +0400, Sergei Shtylyov wrote: diff --git a/drivers/staging/usbip/stub_dev.c b/drivers

Re: [PATCH v4] staging: usbip: replace pr_warning() with dev_warn().

On Wed, Jul 24, 2013, Greg KH gre...@linuxfoundation.org said: On Thu, Jun 27, 2013 at 03:34:52PM +0530, navin patidar wrote: dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device

Re: [PATCH v4] staging: usbip: replace pr_warning() with dev_warn().

On Thu, Jul 25, 2013, Greg KH gre...@linuxfoundation.org said: On Thu, Jul 25, 2013 at 10:19:31AM +0530, navin patidar wrote: -pr_warning(Unable to start control thread\n); +struct device *dev; + +if (ud-side == USBIP_STUB) +dev = container_of(ud

[PATCH] staging: rtl8187se: Remove pt_regs * irq handler parameter

struct pt_regs pointer is no longer passed as a irq handler argument. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/rtl8187se/r8180_core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging

Re: [PATCH] staging: rtl8187se: Remove pt_regs * irq handler parameter

On August 23, 2013 at 5:18 PM Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Aug 23, 2013 at 05:00:06PM +0530, navin patidar wrote: struct pt_regs pointer is no longer passed as a irq handler argument. Good eye. Could you also remove the cast to (void *) so the compiler can catch

[PATCH v2] staging: rtl8187se: Remove pt_regs * irq handler parameter

struct pt_regs pointer is no longer passed as a irq handler argument. v2: remove rtl8180_interrupt cast to (void *) . Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/rtl8187se/r8180_core.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH] staging: rtl8192e: Remove pt_regs * irq handler parameter

struct pt_regs pointer is no longer passed as a irq handler argument. and also remove unnecessary macros. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c |5 +++-- drivers/staging/rtl8192e/rtl8192e/rtl_core.h |6 -- 2 files changed, 3

[PATCH] staging: dgrp: add __init/__exit macros

add __init/__exit macros to related init/cleanup functions. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/dgrp/dgrp_driver.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/staging/dgrp/dgrp_driver.c b/drivers/staging/dgrp

[PATCH] staging: usbip: replace pr_warning() with pr_warn()

pr_warn() is preferred over pr_warning(). Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/usbip_event.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/usbip_event.c b/drivers/staging/usbip/usbip_event.c index 82123be..64933b9

[PATCH 3/3] staging: usbip: vhci_hcd: remove check for dma

vhci_hcd is a virtual usb host controller, so no need to check for dma. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/vhci_hcd.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index b3c9217

[PATCH 2/3] staging: usbip: vhci_hcd: correctly handle return value

ret == 0 means success, anything else is failure. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/vhci_hcd.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index d7974cb..b3c9217

[PATCH 1/3] staging: usbip: stub_main: correctly handle return value

ret == 0 means success, anything else is failure. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/stub_main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/stub_main.c b/drivers/staging/usbip/stub_main.c index 33027cc

Re: [PATCH] staging: usbip: Fix build on Debian ppc

: https://lkml.org/lkml/2013/9/10/26 regards, --navin-patidar -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH v2 3/3] staging: rtl8188eu: remove header file ethernet.h

ethernet.h is included in three files but only rtw_recv.c using two macros defined in ethernet.h, so move used macros in rtw_recv.c and remove include/ethernet.h header file and inclusion of this header file. v2: First version of this patch failed to apply. Signed-off-by: navin patidar

Re: [PATCH 3/3] staging: rtl8188eu: remove header file ethernet.h

I've submitted second version of this patch. regards, --navin-patidar On Wed, Feb 12, 2014 at 2:03 AM, Greg KH gre...@linuxfoundation.org wrote: On Sun, Feb 09, 2014 at 02:10:46PM +0530, navin patidar wrote: ethernet.h is included in three files but only rtw_recv.c using two macros defined

[PATCH] staging: rtl8188eu: remove unused header files

Remove h2clbk.h and nic_spec.h header files. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/h2clbk.h | 35 drivers/staging/rtl8188eu/include/nic_spec.h | 44 -- 2 files changed, 79 deletions(-) delete

Re: [PATCH] staging: usbip: replace pr_warning() with pr_warn()

On Tue, Jun 25, 2013, Greg KH gre...@linuxfoundation.org said: On Fri, Jun 21, 2013 at 03:01:04PM +0530, navin patidar wrote: pr_warn() is preferred over pr_warning(). And dev_warn() is preferred over both of them, can you convert the code to use that instead? struct device

[no subject]

On Tue, Jun 25, 2013, Greg KH gre...@linuxfoundation.org said: On Tue, Jun 25, 2013 at 04:27:18PM +0530, navin patidar wrote: On Tue, Jun 25, 2013, Greg KH gre...@linuxfoundation.org said: On Fri, Jun 21, 2013 at 03:01:04PM +0530, navin patidar wrote: pr_warn() is preferred over pr_warning

Re: [PATCH] staging: usbip: replace pr_warning() with pr_warn()

On Tue, Jun 25, 2013, Greg KH gre...@linuxfoundation.org said: On Tue, Jun 25, 2013 at 04:27:18PM +0530, navin patidar wrote: On Tue, Jun 25, 2013, Greg KH gre...@linuxfoundation.org said: On Fri, Jun 21, 2013 at 03:01:04PM +0530, navin patidar wrote: pr_warn() is preferred over pr_warning

[PATCH v2] staging: usbip: replace pr_warning() with dev_warn().

dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device structure required for dev_warn(). Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/usbip_event.c | 14

[PATCH v3] staging: usbip: replace pr_warning() with dev_warn().

dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device structure required for dev_warn(). Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/usbip_event.c | 17

[PATCH] staging: bcm: remove Version.h file.

many of the macros defined in Version.h are not being used, so we can remove the file. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/bcm/Bcmchar.c |4 ++-- drivers/staging/bcm/Version.h | 29 - drivers/staging/bcm/headers.h |3 +-- 3 files

[PATCH 02/13] staging: rtl8188eu: Remove rtw_deinit_intf_priv()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index c2e5276

[PATCH 03/13] staging: rtl8188eu: Remove rtw_init_intf_priv()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index f874270

[PATCH 05/13] staging: rtl8188eu: Remove unused struct intf_priv

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/osdep_intf.h | 33 1 file changed, 33 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_intf.h b/drivers/staging/rtl8188eu/include/osdep_intf.h index a5b3bd3

[PATCH 04/13] staging: rtl8188eu:Move rtw_hw_[suspend,resume]() to rtw_pwrctrl.c

rtw_hw_[suspend,resume]() functions are used only in rtw_pwrctrl.c, so move these functions there. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 103 drivers/staging/rtl8188eu/include/osdep_intf.h |2

[PATCH 11/13] staging: rtl8188eu: HalPhyRf_8188e.c: Remove unnecessary comments

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 37 1 file changed, 6 insertions(+), 31 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c

[PATCH 07/13] staging: rtl8188eu: Remove unused function _rtw_write_mem()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_io.c | 14 -- drivers/staging/rtl8188eu/hal/usb_ops_linux.c|1 - drivers/staging/rtl8188eu/include/rtw_io.h |5 - drivers/staging/rtl8188eu/os_dep

[PATCH 08/13] staging: rtl8188eu: Remove unused function declaration and macro

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_io.h |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_io.h b/drivers/staging/rtl8188eu/include/rtw_io.h index 958fc52..e30b84b 100644 --- a/drivers

[PATCH 09/13] staging: rtl8188eu: rtw_io.h: Remove unused structures

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_io.h | 85 1 file changed, 85 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_io.h b/drivers/staging/rtl8188eu/include/rtw_io.h index e30b84b..e56c52b

[PATCH] staging: rtl8188eu: os_dep: usb_intf.c: Cleaning up unnecessary code

From: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se Removes unnecessary code that does not do anything useful. This was partly found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se ---

[PATCH 06/13] staging: rtl8188eu: Remove unused funtion _rtw_read_mem()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_io.c | 15 --- drivers/staging/rtl8188eu/hal/usb_ops_linux.c|1 - drivers/staging/rtl8188eu/include/rtw_io.h |2 -- drivers/staging/rtl8188eu/os_dep

[PATCH 10/13] staging: rtl8188eu: HalPhyRf_8188e.c: Remove unused macro

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c index fafb18c..5afaad2 100644

Re: [PATCH] staging: rtl8188eu: os_dep: usb_intf.c: Cleaning up unnecessary code

sorry, my script picked up Rickard's patch and send it out again along my patches. I need to fix my script. regards, navin patidar On Fri, Jun 6, 2014 at 9:45 PM, navin patidar navin.pati...@gmail.com wrote: From: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se Removes unnecessary

[PATCH 12/13] staging: rtl8188eu: rtw_io.h: Remove unused macros

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_io.h | 57 1 file changed, 57 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_io.h b/drivers/staging/rtl8188eu/include/rtw_io.h index e56c52b..9c6384b

[PATCH 01/13] staging: rtl8188eu: usb_halinit.c: Remove ReadAdapterInfo8188EU()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index e60b5e9..316c821

[PATCH 13/13] staging: rtl8188eu: rtw_io.h: Remove unused members from struct _io_ops

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_io.h |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_io.h b/drivers/staging/rtl8188eu/include/rtw_io.h index 9c6384b..bc36129 100644 --- a/drivers/staging

[PATCH v2 25/26] staging: rtl8188eu: Remove unused function nat25_handle_frame()

Signed-off-by: navin patidar navin.pati...@gmail.com --- V2: Restore sequence of source code compilation, sequence was changed by v1 of this patch. drivers/staging/rtl8188eu/core/rtw_br_ext.c| 61 drivers/staging/rtl8188eu/include/recv_osdep.h |1 - 2 files

[PATCH 00/13]staging: rtl8188eu: Remove unused functions and variables

From: navin patidar navin.pati...@gmail.com Following patches remove unused functions, variables and functions with empty definition. navin patidar (13): staging: rtl8188eu: Remove 'semaphore allrxreturnevt' from struct recv_priv staging: rtl8188eu: Remove unused member variables

[PATCH 01/13] staging: rtl8188eu: Remove 'semaphore allrxreturnevt' from struct recv_priv

From: navin patidar navin.pati...@gmail.com Remove unused variable 'semaphore allrxreturnevt'. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_recv.c|2 -- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 3 deletions

[PATCH 02/13] staging: rtl8188eu: Remove unused member variables of struct recv_priv

From: navin patidar navin.pati...@gmail.com Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_recv.h |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include

[PATCH 03/13] staging: rtl8188eu: Remove 'spinlock_t lock' from struct recv_priv

From: navin patidar navin.pati...@gmail.com Remove unused variable 'spinlock_t lock'. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_recv.c|2 -- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 3 deletions(-) diff

[PATCH 04/13] staging: rtl8188eu: Remove struct zero_bulkout_context

From: navin patidar navin.pati...@gmail.com Remove unused struct zero_bulkout_context. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep

[PATCH 05/13] staging: rtl8188eu: Remove function rtw_os_recv_resource_init()

From: navin patidar navin.pati...@gmail.com rtw_os_recv_resource_init() has empty defination, so we can remove it. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_recv.c |2 -- drivers/staging/rtl8188eu/include/recv_osdep.h |1 - drivers

[PATCH 07/13] staging: rtl8188eu: Remove function rtw_hostapd_mlme_rx()

From: navin patidar navin.pati...@gmail.com rtw_hostapd_mlme_rx() has empty defination, so we can remove it. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c |2 -- drivers/staging/rtl8188eu/include/recv_osdep.h |1 - drivers

[PATCH 08/13] staging: rtl8188eu: Remove function rtw_os_recvbuf_resource_free()

From: navin patidar navin.pati...@gmail.com Use usb_free_urb() instead of rtw_os_recvbuf_resource_free() to free URB. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |2 +- drivers/staging/rtl8188eu/include/recv_osdep.h |1

[PATCH 06/13] staging: rtl8188eu: Remove function rtw_os_recv_resource_free()

From: navin patidar navin.pati...@gmail.com rtw_os_recv_resource_free() has empty defination, so we can remove it. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_recv.c |2 -- drivers/staging/rtl8188eu/include/recv_osdep.h |1 - drivers

[PATCH 09/13] staging: rtl8188eu: Remove unused inline function recvframe_push()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_recv.h | 20 1 file changed, 20 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index 68c2ad5f..e5b4e10

[PATCH 10/13] staging: rtl8188eu: Remove unused inline function get_rx_status()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_recv.h |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index e5b4e10..dac2e0c 100644 --- a/drivers

[PATCH 11/13] staging: rtl8188eu: Remove 'void *precvbuf' from struct recv_frame

Remove unused variable 'void *precvbuf'. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_ops_linux.c |1 - drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal

[PATCH 13/13] staging: rtl8188eu: Remove 'u8 fragcnt' from struct recv_frame

Remove unused variable 'u8 fragcnt'. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index

[PATCH 12/13] staging: rtl8188eu: Remove 'int frame_tag' from struct recv_frame

Remove unused variable 'int frame_tag'. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index

Re: [PATCH 06/13] staging: rtl8188eu: Remove unused funtion _rtw_read_mem()

some times i get confused by one patch should do only one thing policy, for example this patch removes many other things along _rtw_read_mem(). But you are also right it's much easier to review when they are all folded together. I'm glad, i did it right this time. :) regards, navin patidar

[PATCH 01/22] staging: rtl8188eu: rtw_io.c: Remove unused function _rtw_write8_async()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_io.c| 12 drivers/staging/rtl8188eu/include/rtw_io.h |4 2 files changed, 16 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core

[PATCH 02/22] staging: rtl8188eu: rtw_io.c: Remove unused function rtw_write16_async()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_io.c| 13 - drivers/staging/rtl8188eu/include/rtw_io.h |4 2 files changed, 17 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu

[PATCH 03/22] staging: rtl8188eu: rtw_io.c: Remove unused function _rtw_write32_async()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_io.c| 13 - drivers/staging/rtl8188eu/include/rtw_io.h |5 - 2 files changed, 18 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu

[PATCH 04/22] staging: rtl8188eu: rtw_io.c: Remove unused function _rtw_write_port_and_wait()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_io.c| 17 - drivers/staging/rtl8188eu/include/rtw_io.h |4 2 files changed, 21 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu

[PATCH 12/22] staging: rtl8188eu: Remove function _rtw_write32()

_rtw_write32() is a wrapper function, being used to call usb_write32(). Call usb_write32() directly and drop _rtw_write32(). Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_debug.c|2 +- drivers/staging/rtl8188eu/core/rtw_io.c

[PATCH 08/22] staging: rtl8188eu: Remove function _rtw_read_port()

_rtw_read_port() is a wrapper function, being used to call usb_read_port(). use usb_read_port() directly and drop _rtw_read_port(). Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_io.c | 20 drivers/staging/rtl8188eu/hal

[PATCH 07/22] staging: rtl8188eu: Remove function _rtw_writeN()

_rtw_writeN() is a wrapper function, being used to call usb_writeN(). Call usb_writeN() directly and drop _rtw_writeN(). Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_io.c | 13 - drivers/staging/rtl8188eu/hal

[PATCH 09/22] staging: rtl8188eu: Remove function _rtw_read_port_cancel()

_rtw_read_port_cancel() is a wrapper function, being used to call usb_read_port_cancel(). Call usb_read_port_cancel() directly and drop _rtw_read_port_cancel(). Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_io.c | 12 drivers

[PATCH 13/22] staging: rtl8188eu: Remove function _rtw_write16()

_rtw_write16() is a wrapper function, being used to call usb_write16(). Call usb_write16() directly and drop _rtw_write16(). Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_debug.c |2 +- drivers/staging/rtl8188eu/core/rtw_io.c

[PATCH 05/22] staging: rtl8188eu: rtw_io.h: Remove unused function declarations

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_io.h | 43 1 file changed, 43 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_io.h b/drivers/staging/rtl8188eu/include/rtw_io.h index 4c8a8c1..5c76815

[PATCH 11/22] staging: rtl8188eu: Remove function _rtw_write_port_cancel()

_rtw_write_port_cancel() is a wrapper function, being used to call usb_write_port_cancel(). Call usb_write_port_cancel() directly and drop _rtw_write_port_cancel(). Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_io.c | 12 drivers

[PATCH 06/22] staging: rtl8188eu: Instead of intf_hdl pass adapter in read write functions

used to call usb_[read,write][8,16,32]() functions. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_io.c | 44 ++--- drivers/staging/rtl8188eu/hal/usb_halinit.c |4 +- drivers/staging/rtl8188eu/hal/usb_ops_linux.c

[PATCH 10/22] staging: rtl8188eu: Remove function _rtw_write_port()

_rtw_write_port() is a wrapper function, being used to call usb_write_port(). Call usb_write_port() directly and drop _rtw_write_port(). Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_io.c| 16 drivers/staging/rtl8188eu/hal

[PATCH 16/22] staging: rtl8188eu: Remove function _rtw_read16()

_rtw_read16() is a wrapper function, being used to call usb_read16(). Call usb_read16() directly and drop _rtw_read16(). Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_debug.c|2 +- drivers/staging/rtl8188eu/core/rtw_io.c | 12

[PATCH 21/22] staging: rtl8188eu: Move usb_[read,write]() declarations to usb_ops_linux.h

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_debug.c|1 + drivers/staging/rtl8188eu/core/rtw_efuse.c|3 +-- drivers/staging/rtl8188eu/core/rtw_mp.c |2 +- drivers/staging/rtl8188eu/core/rtw_mp_ioctl.c |2

[PATCH 15/22] staging: rtl8188eu: Remove function _rtw_read32()

_rtw_read32() is a wrapper function, being used to call usb_read32(). Call usb_read32() directly and drop _rtw_read32(). Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_debug.c | 14 ++--- drivers/staging/rtl8188eu/core/rtw_efuse.c

[PATCH 22/22] staging: rtl8188eu: Remove empty files rtw_io.[c,h]

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/Makefile |1 - drivers/staging/rtl8188eu/core/rtw_io.c | 53 -- drivers/staging/rtl8188eu/include/drv_types.h|1 - drivers/staging/rtl8188eu/include/rtw_io.h

[PATCH 20/22] staging: rtl8188eu: rtw_io.h: Remove unused structures and macros

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/drv_types.h |1 - drivers/staging/rtl8188eu/include/rtw_io.h| 42 - 2 files changed, 43 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h b/drivers

[PATCH 18/22] staging: rtl8188eu: Remove functions initialize rtw_[read,write] wrapper

we have removed all rtw_[read,write]() function calls, so no need to initialize structures used to build rtw_[read,write] abstraction. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_io.c | 16 drivers/staging/rtl8188eu/hal

[PATCH 17/22] staging: rtl8188eu: Remove function _rtw_read8()

_rtw_read8() is a wrapper function, being used to call usb_read8(). Call usb_read8() directly and drop _rtw_read8(). Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_debug.c|2 +- drivers/staging/rtl8188eu/core/rtw_efuse.c| 24

[PATCH 19/22] staging: rtl8188eu: usb_ops_linux.h: Remove unused function declarations

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/usb_ops_linux.h |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/usb_ops_linux.h b/drivers/staging/rtl8188eu/include/usb_ops_linux.h index e722c45..0a6e5d0 100644

Re: [PATCH 06/22] staging: rtl8188eu: Instead of intf_hdl pass adapter in read write functions

On Thu, Jun 12, 2014 at 1:13 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Wed, Jun 11, 2014 at 10:51:25PM +0530, navin patidar wrote: diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c index a0a31e6..85306bf 100644 --- a/drivers/staging

Re: [PATCH 05/28] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

On Tue, May 20, 2014 at 12:34 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Mon, May 19, 2014 at 09:19:07PM +0530, navin patidar wrote: You have changed it to return _FAIL instead of true. Perhaps that is ok but you need to explain it in the changelog. oops, I'll resend this patch

Re: [PATCH 00/13]staging: rtl8188eu: Remove unused functions and variables

Hi Greg, Please merge this patchset, It has been pending for some time. regards, navin patidar On Wed, May 7, 2014 at 9:27 AM, navin.pati...@gmail.com wrote: From: navin patidar navin.pati...@gmail.com Following patches remove unused functions, variables and functions with empty definition

[PATCH 01/28] staging: rtl8188eu: Remove function with empty definition _InitBeaconMaxError().

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 617e4c6..9ce6173 100644 --- a/drivers

[PATCH 02/28] staging: rtl8188eu: Remove function with empty definition _InitOperationMode()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 9ce6173..2e7b81ce 100644 --- a/drivers

[PATCH 00/28] staging: rtl8188eu: Remove unnecessary functions.

Following patches remove functions which are unused or have empty definition. navin patidar (28): staging: rtl8188eu: Remove function with empty definition _InitBeaconMaxError(). staging: rtl8188eu: Remove function with empty definition _InitOperationMode() staging: rtl8188eu

[PATCH 03/28] staging: rtl8188eu: Remove function with empty definition _ps_open_RF()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |7 --- drivers/staging/rtl8188eu/include/rtl8188e_hal.h |1 - 2 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging

[PATCH 08/28] staging: rtl8188eu: Remove unused function rtl8192c_PHY_GetHWRegOriginalValue()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index b50df3e

[PATCH 04/28] staging: rtl8188eu: Remove unused function _ps_close_RF()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 2fe1135..1a83d31 100644 --- a/drivers

[PATCH 06/28] staging:rtl8188eu:Remove funtion Hal_CustomizeByCustomerID_8188EU()

Function has empty defination. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 4c3f8c8

[PATCH 05/28] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 1a83d31..4c3f8c8 100644 --- a/drivers

[PATCH 07/28] staging: rtl8188eu: Remove unused function rtl8188e_PHY_ConfigRFWithParaFile()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index 8079fc6

[PATCH 10/28] staging:rtl8188eu: Remove unused function phy_DbmToTxPwrIdx()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 44 --- 1 file changed, 44 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index 7cc7f44

[PATCH 09/28] staging: rtl8188eu: Remove unused function PHY_UpdateTxPowerDbm8188E()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 37 drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h |1 - 2 files changed, 38 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b

[PATCH 11/28] staging: rtl8188eu: Remove unused funtion PHY_GetTxPowerLevel8188E()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 46 --- 1 file changed, 46 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index 16f46c3

[PATCH 14/28] staging: rtl8188eu: Remove unused structure rf_shadow

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c index b1cb5c4

[PATCH 12/28] staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 34 --- 1 file changed, 34 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index 099345f

  1   2   3   4   5   6   7   8   9   10   >