Re: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq

2020-05-29 Thread oulijun
在 2020/5/28 23:04, Colin King 写道: From: Colin Ian King The pointer raq is being assigned twice. Fix this by removing one of the redundant assignments. Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general pointers") Addressses-Coverity: ("Evaluation order violation")

Re: [PATCH 1/2][next] RDMA/hns: fix comparison of unsigned long variable 'end' with less than zero

2019-07-09 Thread oulijun
在 2019/5/31 17:21, Colin King 写道: > From: Colin Ian King > > Currently the comparison of end with less than zero is always false > because end is an unsigned long. Also, replace checks of end with > non-zero with end > 0 as it is possible that the #defined decrement > may be changed in the

Re: linux-next: build failure after merge of the rdma tree

2019-07-04 Thread oulijun
在 2019/7/4 10:04, Jason Gunthorpe 写道: > On Thu, Jul 04, 2019 at 12:02:35PM +1000, Stephen Rothwell wrote: >> Hi all, >> >> On Mon, 1 Jul 2019 14:14:31 +1000 Stephen Rothwell >> wrote: >>> Hi all, >>> >>> After merging the rdma tree, today's linux-next build (x86_64 >>> allmodconfig) failed like

Re: linux-next: build failure after merge of the rdma tree

2019-07-03 Thread oulijun
在 2019/7/4 10:04, Jason Gunthorpe 写道: > On Thu, Jul 04, 2019 at 12:02:35PM +1000, Stephen Rothwell wrote: >> Hi all, >> >> On Mon, 1 Jul 2019 14:14:31 +1000 Stephen Rothwell >> wrote: >>> Hi all, >>> >>> After merging the rdma tree, today's linux-next build (x86_64 >>> allmodconfig) failed like

【Application】hns RoCE driver integration

2019-07-02 Thread oulijun
Hi, Arlin Davis & Jason I am the maintainer of hns. I understand that hns is still not integrated into OFED. A long time ago I received a consultation email about hns integration into OFED. Sorry for the long time of reply. I am trying to push the support for the hns RoCE driver in

Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable

2018-04-16 Thread oulijun
在 2018/4/13 20:47, Bart Van Assche 写道: > On Fri, 2018-04-13 at 00:06 -0700, Greg Thelen wrote: >> Allow INFINIBAND without INFINIBAND_ADDR_TRANS. >> >> Signed-off-by: Greg Thelen >> Cc: Tarick Bedeir >> --- >> drivers/infiniband/Kconfig | 2 +- >> 1 file

Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable

2018-04-16 Thread oulijun
在 2018/4/13 20:47, Bart Van Assche 写道: > On Fri, 2018-04-13 at 00:06 -0700, Greg Thelen wrote: >> Allow INFINIBAND without INFINIBAND_ADDR_TRANS. >> >> Signed-off-by: Greg Thelen >> Cc: Tarick Bedeir >> --- >> drivers/infiniband/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-)

Re: 【build error report for for next branch】

2017-10-23 Thread oulijun
在 2017/10/23 23:24, Doug Ledford 写道: > On Wed, 2017-10-18 at 14:21 +0800, oulijun wrote: >> Hi, Doug Ledford >>I am use the for-next branch for building and the result is fail. >> Is the branch a bug or my buidl way incorrectly? > > [ snip ] > >> C

Re: 【build error report for for next branch】

2017-10-23 Thread oulijun
在 2017/10/23 23:24, Doug Ledford 写道: > On Wed, 2017-10-18 at 14:21 +0800, oulijun wrote: >> Hi, Doug Ledford >>I am use the for-next branch for building and the result is fail. >> Is the branch a bug or my buidl way incorrectly? > > [ snip ] > >> C

Re: [patch 1/2] IB/hns: Fix a couple pointer math bugs

2016-10-14 Thread oulijun
在 2016/10/14 15:28, Dan Carpenter 写道: > "wqe" is a void pointer so adding sizeof() works. The original code > adds sizeof() multiplied by sizeof() so it doesn't work at all. > > Fixes: 9a4435375cd1 ('IB/hns: Add driver files for hns RoCE driver') > Signed-off-by: Dan Carpenter

Re: [patch 1/2] IB/hns: Fix a couple pointer math bugs

2016-10-14 Thread oulijun
在 2016/10/14 15:28, Dan Carpenter 写道: > "wqe" is a void pointer so adding sizeof() works. The original code > adds sizeof() multiplied by sizeof() so it doesn't work at all. > > Fixes: 9a4435375cd1 ('IB/hns: Add driver files for hns RoCE driver') > Signed-off-by: Dan Carpenter > > diff --git

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

2016-07-13 Thread oulijun
在 2016/7/2 17:39, Lijun Ou 写道: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon RoCEE(RoCE Engine) is a

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

2016-07-13 Thread oulijun
在 2016/7/2 17:39, Lijun Ou 写道: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon RoCEE(RoCE Engine) is a

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

2016-07-07 Thread oulijun
在 2016/7/2 17:39, Lijun Ou 写道: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon RoCEE(RoCE Engine) is a

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

2016-07-07 Thread oulijun
在 2016/7/2 17:39, Lijun Ou 写道: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon RoCEE(RoCE Engine) is a

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

2016-07-04 Thread oulijun
在 2016/7/2 20:58, Leon Romanovsky 写道: > On Sat, Jul 02, 2016 at 05:39:02PM +0800, Lijun Ou wrote: > > This v11 >> 28 files changed, 10626 insertions(+), 1 deletion(-) > > First version >> 27 files changed, 11670 insertions(+), 11 deletions(-) > > 1K LOC less, we are moving in right direction.

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

2016-07-04 Thread oulijun
在 2016/7/2 20:58, Leon Romanovsky 写道: > On Sat, Jul 02, 2016 at 05:39:02PM +0800, Lijun Ou wrote: > > This v11 >> 28 files changed, 10626 insertions(+), 1 deletion(-) > > First version >> 27 files changed, 11670 insertions(+), 11 deletions(-) > > 1K LOC less, we are moving in right direction.

Re: [PATCH v10 07/22] IB/hns: Add event queue support

2016-06-29 Thread oulijun
Hi, Leon 在 2016/6/24 23:46, Leon Romanovsky 写道: > On Thu, Jun 16, 2016 at 10:35:15PM +0800, Lijun Ou wrote: >> This patch added event queue support for RoCE driver. It is used >> for RoCE interrupt. RoCE includes 32 synchronous event irqs, 1 >> asynchronous event irq and 1 common overflow irq. >>

Re: [PATCH v10 07/22] IB/hns: Add event queue support

2016-06-29 Thread oulijun
Hi, Leon 在 2016/6/24 23:46, Leon Romanovsky 写道: > On Thu, Jun 16, 2016 at 10:35:15PM +0800, Lijun Ou wrote: >> This patch added event queue support for RoCE driver. It is used >> for RoCE interrupt. RoCE includes 32 synchronous event irqs, 1 >> asynchronous event irq and 1 common overflow irq. >>

Re: [PATCH v10 05/22] IB/hns: Add initial profile resource

2016-06-28 Thread oulijun
Hi, leon 在 2016/6/24 23:10, Leon Romanovsky 写道: > On Thu, Jun 16, 2016 at 10:35:13PM +0800, Lijun Ou wrote: >> This patch added the operation for cmd, and added some functions >> for initializing eq table and selecting cmd mode. >> >> Signed-off-by: Wei Hu >>

Re: [PATCH v10 05/22] IB/hns: Add initial profile resource

2016-06-28 Thread oulijun
Hi, leon 在 2016/6/24 23:10, Leon Romanovsky 写道: > On Thu, Jun 16, 2016 at 10:35:13PM +0800, Lijun Ou wrote: >> This patch added the operation for cmd, and added some functions >> for initializing eq table and selecting cmd mode. >> >> Signed-off-by: Wei Hu >> Signed-off-by: Nenglong Zhao >>

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

2016-06-27 Thread oulijun
Hi, Leon 在 2016/6/27 16:01, Leon Romanovsky 写道: > On Sat, Jun 25, 2016 at 06:25:37PM +0800, Wei Hu (Xavier) wrote: >> >> >> On 2016/6/24 22:59, Leon Romanovsky wrote: >>> On Thu, Jun 16, 2016 at 10:35:12PM +0800, Lijun Ou wrote: This patch mainly added reset flow of RoCE engine in RoCE

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

2016-06-27 Thread oulijun
Hi, Leon 在 2016/6/27 16:01, Leon Romanovsky 写道: > On Sat, Jun 25, 2016 at 06:25:37PM +0800, Wei Hu (Xavier) wrote: >> >> >> On 2016/6/24 22:59, Leon Romanovsky wrote: >>> On Thu, Jun 16, 2016 at 10:35:12PM +0800, Lijun Ou wrote: This patch mainly added reset flow of RoCE engine in RoCE

Re: [PATCH v10 01/22] net: hns: Add reset function support for RoCE driver

2016-06-27 Thread oulijun
Hi, Leon 在 2016/6/24 19:49, Leon Romanovsky 写道: > On Thu, Jun 16, 2016 at 10:35:09PM +0800, Lijun Ou wrote: >> It added reset function for RoCE driver. RoCE is a feature of hns. >> In hip06 SoC, in RoCE reset process, it's needed to configure dsaf >> channel reset, port and sl map info. Reset

Re: [PATCH v10 01/22] net: hns: Add reset function support for RoCE driver

2016-06-27 Thread oulijun
Hi, Leon 在 2016/6/24 19:49, Leon Romanovsky 写道: > On Thu, Jun 16, 2016 at 10:35:09PM +0800, Lijun Ou wrote: >> It added reset function for RoCE driver. RoCE is a feature of hns. >> In hip06 SoC, in RoCE reset process, it's needed to configure dsaf >> channel reset, port and sl map info. Reset

Re: [RESEND PATCH v9 00/22] Add HiSilicon RoCE driver

2016-06-20 Thread oulijun
On 2016/6/8 19:55, Doug Ledford wrote: > On 6/8/2016 2:44 AM, Lijun Ou wrote: >> The HiSilicon Network Substem is a long term evolution IP which is >> supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network >> Sybsystem) also has a hardware support of performing RDMA with >> RoCEE. >>

Re: [RESEND PATCH v9 00/22] Add HiSilicon RoCE driver

2016-06-20 Thread oulijun
On 2016/6/8 19:55, Doug Ledford wrote: > On 6/8/2016 2:44 AM, Lijun Ou wrote: >> The HiSilicon Network Substem is a long term evolution IP which is >> supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network >> Sybsystem) also has a hardware support of performing RDMA with >> RoCEE. >>

Re: [PATCH v9 05/22] IB/hns: Add initial profile resource

2016-06-14 Thread oulijun
Hi, On 2016/6/9 15:01, Leon Romanovsky wrote: > On Wed, Jun 01, 2016 at 11:37:47PM +0800, Lijun Ou wrote: >> This patch mainly configured some profile resoure. For example, >> vendor_id, hardware version, and some data structure sizes so on. >> >> Signed-off-by: Wei Hu >>

Re: [PATCH v9 05/22] IB/hns: Add initial profile resource

2016-06-14 Thread oulijun
Hi, On 2016/6/9 15:01, Leon Romanovsky wrote: > On Wed, Jun 01, 2016 at 11:37:47PM +0800, Lijun Ou wrote: >> This patch mainly configured some profile resoure. For example, >> vendor_id, hardware version, and some data structure sizes so on. >> >> Signed-off-by: Wei Hu >> Signed-off-by: Nenglong

Re: [PATCH v6 00/21] Add HiSilicon RoCE driver

2016-05-04 Thread oulijun
On 2016/5/4 2:48, Leon Romanovsky wrote: > On Thu, Apr 28, 2016 at 08:09:35PM +0800, Lijun Ou wrote: >> The HiSilicon Network Substem is a long term evolution IP which is >> supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network >> Sybsystem) also has a hardware support of performing

Re: [PATCH v6 00/21] Add HiSilicon RoCE driver

2016-05-04 Thread oulijun
On 2016/5/4 2:48, Leon Romanovsky wrote: > On Thu, Apr 28, 2016 at 08:09:35PM +0800, Lijun Ou wrote: >> The HiSilicon Network Substem is a long term evolution IP which is >> supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network >> Sybsystem) also has a hardware support of performing

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-04-26 Thread oulijun
On 2016/4/26 22:18, Leon Romanovsky wrote: > On Tue, Apr 26, 2016 at 02:34:44PM +0800, oulijun wrote: >> On 2016/4/24 15:54, Leon Romanovsky wrote: >>> On Sat, Apr 23, 2016 at 06:26:47PM +0800, Lijun Ou wrote: >>>> This patch mainly setup hca for RoCE. it will do

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-04-26 Thread oulijun
On 2016/4/26 22:18, Leon Romanovsky wrote: > On Tue, Apr 26, 2016 at 02:34:44PM +0800, oulijun wrote: >> On 2016/4/24 15:54, Leon Romanovsky wrote: >>> On Sat, Apr 23, 2016 at 06:26:47PM +0800, Lijun Ou wrote: >>>> This patch mainly setup hca for RoCE. it will do

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-04-26 Thread oulijun
On 2016/4/26 22:25, Jiri Pirko wrote: > Tue, Apr 26, 2016 at 04:18:21PM CEST, l...@kernel.org wrote: >> On Tue, Apr 26, 2016 at 02:34:44PM +0800, oulijun wrote: >>> On 2016/4/24 15:54, Leon Romanovsky wrote: > > > >>>>> +int hns_roce_bitmap_allo

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-04-26 Thread oulijun
On 2016/4/26 22:25, Jiri Pirko wrote: > Tue, Apr 26, 2016 at 04:18:21PM CEST, l...@kernel.org wrote: >> On Tue, Apr 26, 2016 at 02:34:44PM +0800, oulijun wrote: >>> On 2016/4/24 15:54, Leon Romanovsky wrote: > > > >>>>> +int hns_roce_bitmap_allo

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-04-26 Thread oulijun
On 2016/4/24 15:54, Leon Romanovsky wrote: > On Sat, Apr 23, 2016 at 06:26:47PM +0800, Lijun Ou wrote: >> This patch mainly setup hca for RoCE. it will do a series of >> initial works as follows: >> 1. init uar table, allocate uar resource >> 2. init pd table >> 3. init cq table

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-04-26 Thread oulijun
On 2016/4/24 15:54, Leon Romanovsky wrote: > On Sat, Apr 23, 2016 at 06:26:47PM +0800, Lijun Ou wrote: >> This patch mainly setup hca for RoCE. it will do a series of >> initial works as follows: >> 1. init uar table, allocate uar resource >> 2. init pd table >> 3. init cq table

Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support

2016-04-05 Thread oulijun
Hi, Leon Romanovsky On 2016/4/2 9:58, Leon Romanovsky wrote: > On Fri, Apr 01, 2016 at 05:21:31PM +0800, Lijun Ou wrote: >> The driver for HiSilicon RoCE is a platform driver. >> The driver will support multiple versions of hardware. Currently only "v1" >> for hip06 SoC is supported. >> The

Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support

2016-04-05 Thread oulijun
Hi, Leon Romanovsky On 2016/4/2 9:58, Leon Romanovsky wrote: > On Fri, Apr 01, 2016 at 05:21:31PM +0800, Lijun Ou wrote: >> The driver for HiSilicon RoCE is a platform driver. >> The driver will support multiple versions of hardware. Currently only "v1" >> for hip06 SoC is supported. >> The

Re: call attention to review

2016-03-24 Thread oulijun
On 2016/3/24 14:17, Leon Romanovsky wrote: > On Thu, Mar 24, 2016 at 01:50:30PM +0800, oulijun wrote: >> Hi, >>I am Lijun Ou. I have sent the PATCH v4 of HiSilicon RoCE driver at March >> 22, 2016. >> if you are convenient, please help to review. Welcome to give yo

Re: call attention to review

2016-03-24 Thread oulijun
On 2016/3/24 14:17, Leon Romanovsky wrote: > On Thu, Mar 24, 2016 at 01:50:30PM +0800, oulijun wrote: >> Hi, >>I am Lijun Ou. I have sent the PATCH v4 of HiSilicon RoCE driver at March >> 22, 2016. >> if you are convenient, please help to review. Welcome to give yo

call attention to review

2016-03-23 Thread oulijun
Hi, I am Lijun Ou. I have sent the PATCH v4 of HiSilicon RoCE driver at March 22, 2016. if you are convenient, please help to review. Welcome to give your reviewing. thanks Lijun Ou

call attention to review

2016-03-23 Thread oulijun
Hi, I am Lijun Ou. I have sent the PATCH v4 of HiSilicon RoCE driver at March 22, 2016. if you are convenient, please help to review. Welcome to give your reviewing. thanks Lijun Ou

Re: [PATCH v4 2/3] IB/hns: Add HiSilicon RoCE driver support

2016-03-23 Thread oulijun
On 2016/3/23 2:54, Christoph Hellwig wrote: >> drivers/infiniband/Kconfig |1 + >> drivers/infiniband/hw/Makefile |1 + >> drivers/infiniband/hw/hisilicon/hns/Kconfig| 10 + > > To fit in with the other drivers drop the hisilicon level

Re: [PATCH v4 2/3] IB/hns: Add HiSilicon RoCE driver support

2016-03-23 Thread oulijun
On 2016/3/23 2:54, Christoph Hellwig wrote: >> drivers/infiniband/Kconfig |1 + >> drivers/infiniband/hw/Makefile |1 + >> drivers/infiniband/hw/hisilicon/hns/Kconfig| 10 + > > To fit in with the other drivers drop the hisilicon level

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-19 Thread oulijun
On 2016/3/15 2:20, Parav Pandit wrote: >>> >>> Since SRQ is not supported in this driver version, can you keep >>> remaining code base also to not bother about SRQ specifically >>> poll_cq_one, modify_qp, destroy_qp etc? >>> SRQ support can come as complete additional patch along with cmd_mask,

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-19 Thread oulijun
On 2016/3/15 2:20, Parav Pandit wrote: >>> >>> Since SRQ is not supported in this driver version, can you keep >>> remaining code base also to not bother about SRQ specifically >>> poll_cq_one, modify_qp, destroy_qp etc? >>> SRQ support can come as complete additional patch along with cmd_mask,

Re: [PATCH 2/3] net: hns: add Hisilicon RoCE support

2016-03-19 Thread oulijun
On 2016/3/14 14:49, Leon Romanovsky wrote: > On Mon, Mar 14, 2016 at 09:12:28AM +0800, Yankejian (Hackim Yim) wrote: >> >> >> On 2016/3/12 18:43, Leon Romanovsky wrote: >>> On Fri, Mar 11, 2016 at 06:37:10PM +0800, Lijun Ou wrote: It added hns_dsaf_roce_reset routine for roce driver.

Re: [PATCH 2/3] net: hns: add Hisilicon RoCE support

2016-03-19 Thread oulijun
On 2016/3/14 14:49, Leon Romanovsky wrote: > On Mon, Mar 14, 2016 at 09:12:28AM +0800, Yankejian (Hackim Yim) wrote: >> >> >> On 2016/3/12 18:43, Leon Romanovsky wrote: >>> On Fri, Mar 11, 2016 at 06:37:10PM +0800, Lijun Ou wrote: It added hns_dsaf_roce_reset routine for roce driver.

Re: [PATCH 3/3] infiniband: IB/hns: add Hisilicon RoCE support with bindings

2016-03-19 Thread oulijun
On 2016/3/11 21:39, Sergei Shtylyov wrote: > Hello. > > On 3/11/2016 1:37 PM, Lijun Ou wrote: > >> This submit add binding file and dts file. > >I see no .dts file. > >> >> Signed-off-by: Lijun Ou >> Signed-off-by: Wei Hu(Xavier) >> --- >>

Re: [PATCH 3/3] infiniband: IB/hns: add Hisilicon RoCE support with bindings

2016-03-19 Thread oulijun
On 2016/3/11 21:39, Sergei Shtylyov wrote: > Hello. > > On 3/11/2016 1:37 PM, Lijun Ou wrote: > >> This submit add binding file and dts file. > >I see no .dts file. > >> >> Signed-off-by: Lijun Ou >> Signed-off-by: Wei Hu(Xavier) >> --- >> .../bindings/infiniband/hisilicon-hns-roce.txt

Re: [PATCH 0/3] infiniband: IB/hns: Hisilicon RoCE support

2016-03-19 Thread oulijun
On 2016/3/12 18:20, Leon Romanovsky wrote: > On Fri, Mar 11, 2016 at 06:37:08PM +0800, Lijun Ou wrote: > > 1) It is redundant to write "infiniband" and "IB" in one title to mention > relevant subsystem, since it is the same. > > Please take a look on the other submissions here on the list and

Re: [PATCH 0/3] infiniband: IB/hns: Hisilicon RoCE support

2016-03-19 Thread oulijun
On 2016/3/12 18:20, Leon Romanovsky wrote: > On Fri, Mar 11, 2016 at 06:37:08PM +0800, Lijun Ou wrote: > > 1) It is redundant to write "infiniband" and "IB" in one title to mention > relevant subsystem, since it is the same. > > Please take a look on the other submissions here on the list and

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-19 Thread oulijun
On 2016/3/17 14:43, Leon Romanovsky wrote: > On Wed, Mar 16, 2016 at 11:36:38AM +0100, Jiri Pirko wrote: >>> so, I continue to have it. >> >> I will continue to bash on your odd codingstyle. Please fix it! > > Jiri, > > Checkpatch errors is an easiest issue with this patch. > > It is full of

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-19 Thread oulijun
On 2016/3/17 14:43, Leon Romanovsky wrote: > On Wed, Mar 16, 2016 at 11:36:38AM +0100, Jiri Pirko wrote: >>> so, I continue to have it. >> >> I will continue to bash on your odd codingstyle. Please fix it! > > Jiri, > > Checkpatch errors is an easiest issue with this patch. > > It is full of

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-16 Thread oulijun
Hi dledford, thanks for reviewing. I have modified according to your reivews. I will send a new patch at soon. thanks Lijun Ou On 2016/3/12 18:39, Leon Romanovsky wrote: > On Fri, Mar 11, 2016 at 06:37:09PM +0800, Lijun Ou wrote: >> The driver for Hisilicon RoCE is a platform driver. >> The

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-16 Thread oulijun
Hi dledford, thanks for reviewing. I have modified according to your reivews. I will send a new patch at soon. thanks Lijun Ou On 2016/3/12 18:39, Leon Romanovsky wrote: > On Fri, Mar 11, 2016 at 06:37:09PM +0800, Lijun Ou wrote: >> The driver for Hisilicon RoCE is a platform driver. >> The

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-16 Thread oulijun
Hi Jiri Pirko, thanks your reviewing. sorry, I will send a new patch according to your reviews. On 2016/3/11 18:42, Jiri Pirko wrote: > Fri, Mar 11, 2016 at 11:37:09AM CET, ouli...@huawei.com wrote: >> The driver for Hisilicon RoCE is a platform driver. >> The driver will support mulitple

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-16 Thread oulijun
Hi Jiri Pirko, thanks your reviewing. sorry, I will send a new patch according to your reviews. On 2016/3/11 18:42, Jiri Pirko wrote: > Fri, Mar 11, 2016 at 11:37:09AM CET, ouli...@huawei.com wrote: >> The driver for Hisilicon RoCE is a platform driver. >> The driver will support mulitple

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-14 Thread oulijun
Hi Parav Pandit, thanks your reviewing. On 2016/3/4 17:37, Parav Pandit wrote: > On Fri, Mar 4, 2016 at 2:11 PM, Wei Hu(Xavier) > wrote: >> + >> +int hns_roce_register_device(struct hns_roce_dev *hr_dev) >> +{ >> + int ret; >> + struct hns_roce_ib_iboe *iboe

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-14 Thread oulijun
Hi Parav Pandit, thanks your reviewing. On 2016/3/4 17:37, Parav Pandit wrote: > On Fri, Mar 4, 2016 at 2:11 PM, Wei Hu(Xavier) > wrote: >> + >> +int hns_roce_register_device(struct hns_roce_dev *hr_dev) >> +{ >> + int ret; >> + struct hns_roce_ib_iboe *iboe = NULL; >> + struct

Re: [PATCH 4/4] infiniband: hns: add Hisilicon RoCE support(Kconfig)

2016-03-09 Thread oulijun
It will be send soon. thanks Lijun Ou > >> >> Signed-off-by: Wei Hu(Xavier) <xavier.hu...@huawei.com> >> Signed-off-by: oulijun <ouli...@huawei.com> > > ^^^.. -- Is this first name or second name? > >> --- >> drivers/inf

Re: [PATCH 4/4] infiniband: hns: add Hisilicon RoCE support(Kconfig)

2016-03-09 Thread oulijun
It will be send soon. thanks Lijun Ou > >> >> Signed-off-by: Wei Hu(Xavier) >> Signed-off-by: oulijun > > ^^^.. -- Is this first name or second name? > >> --- >> drivers/infiniband/Kconfig | 2 +- >> 1 file changed, 1 in

Re: [PATCH 1/4] net: hns: add Hisilicon RoCE support(the dependent routine)

2016-03-09 Thread oulijun
for roce driver. >> RoCE is a feature of hns. >> In hip06 SOC, in roce reset process, it's needed to configure >> dsaf channel reset,port and sl map info. >> >> Signed-off-by: Wei Hu(Xavier) <xavier.hu...@huawei.com> >> Signed-off-by: Lisheng <lisheng.

Re: [PATCH 1/4] net: hns: add Hisilicon RoCE support(the dependent routine)

2016-03-09 Thread oulijun
for roce driver. >> RoCE is a feature of hns. >> In hip06 SOC, in roce reset process, it's needed to configure >> dsaf channel reset,port and sl map info. >> >> Signed-off-by: Wei Hu(Xavier) >> Signed-off-by: Lisheng >> Signed-off-by: oulijun >>

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-09 Thread oulijun
Hi Jiri Pirko, thanks for reviewing On 2016/3/4 17:16, Jiri Pirko wrote: > Fri, Mar 04, 2016 at 09:41:16AM CET, xavier.hu...@huawei.com wrote: > > > >> +int hns_roce_buf_alloc( >> +struct hns_roce_dev *hr_dev, >> +int size, int max_direct, >> +

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-09 Thread oulijun
Hi Jiri Pirko, thanks for reviewing On 2016/3/4 17:16, Jiri Pirko wrote: > Fri, Mar 04, 2016 at 09:41:16AM CET, xavier.hu...@huawei.com wrote: > > > >> +int hns_roce_buf_alloc( >> +struct hns_roce_dev *hr_dev, >> +int size, int max_direct, >> +

Re: [PATCH 2/4] infiniband: hns: add Hisilicon RoCE support(binding)

2016-03-09 Thread oulijun
t;> This submit add binding file and dts file. >> >> Signed-off-by: Wei Hu(Xavier) <xavier.hu...@huawei.com> >> Signed-off-by: oulijun <ouli...@huawei.com> >> --- >> .../bindings/infiniband/hisilicon-hns-roce.txt | 68 >> ++

Re: [PATCH 2/4] infiniband: hns: add Hisilicon RoCE support(binding)

2016-03-09 Thread oulijun
t;> This submit add binding file and dts file. >> >> Signed-off-by: Wei Hu(Xavier) >> Signed-off-by: oulijun >> --- >> .../bindings/infiniband/hisilicon-hns-roce.txt | 68 >> ++ >> 1 file changed, 68 insertions(+) &